Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-04-27 18:57:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Updated Note code review (markdown)

Felix S Klock II
2014-01-24 09:35:02 -08:00
parent 11d01160d4
commit 13b5a6bd2a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Note-code-review.md
+1 -1
@@ -3,7 +3,7 @@ Code review checklist
* Code should respect the policy described in the [style](https://github.com/mozilla/rust/wiki/Note-style-guide) page.
* Commit message summaries have to be descriptive.
* Commit messages should be *accurate*: if the commits have deviated from top-level description, don't `r+` without fixing the description (since bors will pull in the PR description as the commit message); see e.g. [flip-i-mean-rev commit](../commit/bf9c25562da1c0e768309693617e54e998a953d1) as an example of such deviation.
* Commit messages should be *accurate*: if it has deviated from top-level description, don't `r+` without getting that fixed; see e.g. [flip-i-mean-rev commit](../commit/bf9c25562da1c0e768309693617e54e998a953d1) as an example of accidental deviation.
* Almost every change should contain a test case as described in the [testing](https://github.com/mozilla/rust/wiki/Doc-unit-testing) page.
* Code optimization should contain a bench case as described in the [bench](https://github.com/mozilla/rust/wiki/Doc-unit-testing#benchmarking) section of the [testing](https://github.com/mozilla/rust/wiki/Doc-unit-testing) page.
* Look for commits that could be squashed.