From 13b5a6bd2a8e1bfefbd26b912f905120fd6fe6f7 Mon Sep 17 00:00:00 2001 From: Felix S Klock II Date: Fri, 24 Jan 2014 09:35:02 -0800 Subject: [PATCH] Updated Note code review (markdown) --- Note-code-review.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Note-code-review.md b/Note-code-review.md index 5164aa8..750aa9f 100644 --- a/Note-code-review.md +++ b/Note-code-review.md @@ -3,7 +3,7 @@ Code review checklist * Code should respect the policy described in the [style](https://github.com/mozilla/rust/wiki/Note-style-guide) page. * Commit message summaries have to be descriptive. -* Commit messages should be *accurate*: if the commits have deviated from top-level description, don't `r+` without fixing the description (since bors will pull in the PR description as the commit message); see e.g. [flip-i-mean-rev commit](../commit/bf9c25562da1c0e768309693617e54e998a953d1) as an example of such deviation. +* Commit messages should be *accurate*: if it has deviated from top-level description, don't `r+` without getting that fixed; see e.g. [flip-i-mean-rev commit](../commit/bf9c25562da1c0e768309693617e54e998a953d1) as an example of accidental deviation. * Almost every change should contain a test case as described in the [testing](https://github.com/mozilla/rust/wiki/Doc-unit-testing) page. * Code optimization should contain a bench case as described in the [bench](https://github.com/mozilla/rust/wiki/Doc-unit-testing#benchmarking) section of the [testing](https://github.com/mozilla/rust/wiki/Doc-unit-testing) page. * Look for commits that could be squashed.