Mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-04-27 19:09:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix redundant safety checks being emitted for slicing

Browse Source
This commit is contained in:
pentuppup
2025-09-10 11:59:47 -04:00
committed by Andrew Kelley
parent cdaf279314
commit d2d8b969a1
1 changed files with 14 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Sema.zig
+14 -9
View File
@@ -32272,9 +32272,15 @@ fn analyzeSlice(
var runtime_src: ?LazySrcLoc = null;
// requirement: start <= end
if (try sema.resolveDefinedValue(block, end_src, end)) |end_val| {
if (try sema.resolveDefinedValue(block, start_src, start)) |start_val| {
if (!by_length and !(try sema.compareAll(start_val, .lte, end_val, .usize))) {
if (try sema.resolveDefinedValue(block, start_src, start)) |start_val| {
if (try sema.compareAll(start_val, .eq, .zero_usize, .usize)) {
checked_start_lte_end = true;
}
if (try sema.resolveDefinedValue(block, end_src, end)) |end_val| {
if (!checked_start_lte_end and
!by_length and
!(try sema.compareAll(start_val, .lte, end_val, .usize)))
{
return sema.fail(
block,
start_src,
@@ -32330,10 +32336,10 @@ fn analyzeSlice(
runtime_src = ptr_src;
}
} else {
runtime_src = start_src;
runtime_src = end_src;
}
} else {
runtime_src = end_src;
runtime_src = start_src;
}
if (!checked_start_lte_end and block.wantSafety() and !block.isComptime()) {
@@ -32396,7 +32402,9 @@ fn analyzeSlice(
else
end;
try sema.addSafetyCheckIndexOob(block, src, actual_end, actual_len, .cmp_lte);
if (try sema.resolveDefinedValue(block, src, actual_len) == null or
try sema.resolveDefinedValue(block, src, actual_end) == null)
try sema.addSafetyCheckIndexOob(block, src, actual_end, actual_len, .cmp_lte);
}
// requirement: result[new_len] == slice_sentinel
@@ -32461,9 +32469,6 @@ fn analyzeSlice(
end;
try sema.addSafetyCheckIndexOob(block, src, actual_end, len_inst, .cmp_lte);
}
// requirement: start <= end
try sema.addSafetyCheckIndexOob(block, src, start, end, .cmp_lte);
}
const result = try block.addInst(.{
.tag = .slice,