Mirrors/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-04-26 13:01:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

Cleans up binary annotation opcodes that we don't handle

Browse Source
This commit is contained in:
Mason Remaley
2026-04-07 16:35:10 -07:00
parent fa26ab6fa3
commit cc15c8ae7e
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/std/debug/Pdb.zig
+13 -8
View File
@@ -357,8 +357,8 @@ pub const BinaryAnnotation = union(enum) {
.change_file => |file_id| {
self.curr.file_id = file_id;
},
// LLVM never emits this opcode, but it's clear enough how to interpret it so we may as
// well in case they use it in the future
// LLVM never emits this opcode, but it's clear enough how to interpret it so we
// may as well in case they use it in the future
.change_code_length_and_code_offset => |info| {
self.curr.code_length = info.length;
self.curr.code_offset += info.delta;
@@ -371,21 +371,24 @@ pub const BinaryAnnotation = union(enum) {
self.curr.line_offset += info.line_delta;
},
// Not emitted by LLVM at the time of writing, but if we get it from elsewhere it should
// be safe to ignore since we don't use this info. Theoretically we could use column
// info if it was present, but it's not easy to test since LLVM doesn't output it.
// Not emitted by LLVM at the time of writing, and we don't want to add support
// without a test csae. Safe to ignore since we don't use this info right now.
.change_line_end_delta,
.change_column_start,
.change_column_end_delta,
.change_column_end,
=> {},
// Not emitted by LLVM at the time of writing. Various sources conflict on how these
// instructions should be interpreted, so we make no attempt to handle them.
// Not emitted by LLVM at the time of writing. Various sources conflict on how
// these opcodes should be interpreted, so we make no attempt to handle them.
.code_offset,
.change_code_offset_base,
.change_range_kind,
=> @panic("unimplemented"),
=> {
self.annotations = .empty;
self.prev = null;
return null;
},
}
switch (annotation) {
@@ -433,6 +436,8 @@ pub const BinaryAnnotation = union(enum) {
pub const Iterator = struct {
reader: Io.Reader,
pub const empty: Iterator = .{ .reader = .ending_instance };
pub fn next(self: *Iterator) error{InvalidDebugInfo}!?BinaryAnnotation {
return take(&self.reader) catch |err| switch (err) {
error.ReadFailed => return error.InvalidDebugInfo,