f394bb57bb
Always use const param envs for const eval.
...
Nothing else makes sense, and there is no "danger" in doing so, as it only does something if there are const bounds, which are unstable. This used to happen implicitly via the inferctxt before, which was much more fragile.
2021-11-29 21:19:50 +08:00
a9a79f657c
Completely remove ConstnessAnd
2021-11-29 21:19:49 +08:00
a848c4ba3f
Avoid storing the ImplPolarity and Constness next to a TraitRef and use TraitPredicate instead
2021-11-29 21:19:49 +08:00
d161cc2071
Replace ConstnessAnd<TraitRef> with TraitPredicate which conveys the same information
2021-11-29 21:19:48 +08:00
b16c811f1c
Prefer TraitPredicate over ConstnessAnd<TraitRef>
2021-11-29 21:19:48 +08:00
40f39e6c6a
Fixup
2021-11-29 21:19:48 +08:00
d51068ca28
Use the constness from the param env instead of having a separate dimension for it
...
This breaks a ~const test that will be fixed in a follow up commit of this PR
2021-11-29 21:19:47 +08:00
19f2101272
Fixup add const to param env
2021-11-29 21:19:47 +08:00
e37947f097
Re-use constness_for_typeck instead of rolling it ourselves
2021-11-29 21:19:46 +08:00
1761d88f4a
Static items are also const
2021-11-29 21:19:46 +08:00
721ffd14c3
Add constness to ParamEnv
...
This now causes a lot of queries to be executed twice, as reveal_all forces NotConst
2021-11-29 21:19:46 +08:00
22eeff700e
Prepare for more ParamEnv flags
2021-11-29 21:19:42 +08:00
44723c5d59
Auto merge of #91043 - camsteffen:descendant-eq, r=petrochenkov
...
Add fast path to `is_descendant_of`
2021-11-29 07:46:36 +00:00
9981e56d3b
Auto merge of #91344 - RalfJung:miri, r=RalfJung
...
update Miri
Fixes https://github.com/rust-lang/rust/issues/91289
2021-11-29 04:40:31 +00:00
8a7e90ab9e
update Miri
2021-11-28 20:37:49 -05:00
a19e748baa
Auto merge of #91338 - matthiaskrgr:rollup-46ry8wi, r=matthiaskrgr
...
Rollup of 3 pull requests
Successful merges:
- #90131 (Fix a format_args span to be expansion)
- #90832 (Add 1.57.0 release notes)
- #90833 (Emit LLVM optimization remarks when enabled with `-Cremark`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-29 01:35:33 +00:00
67762ffe35
Rollup merge of #90833 - tmiasko:optimization-remarks, r=nikic
...
Emit LLVM optimization remarks when enabled with `-Cremark`
The default diagnostic handler considers all remarks to be disabled by
default unless configured otherwise through LLVM internal flags:
`-pass-remarks`, `-pass-remarks-missed`, and `-pass-remarks-analysis`.
This behaviour makes `-Cremark` ineffective on its own.
Fix this by configuring a custom diagnostic handler that enables
optimization remarks based on the value of `-Cremark` option. With
`-Cremark=all` enabling all remarks.
Fixes #90924 .
r? `@nikic`
2021-11-28 23:45:17 +01:00
9ef0bcfc68
Rollup merge of #90832 - cuviper:relnotes-1.57.0, r=Mark-Simulacrum
...
Add 1.57.0 release notes
2021-11-28 23:45:16 +01:00
9715724006
Rollup merge of #90131 - camsteffen:fmt-args-span-fix, r=cjgillot
...
Fix a format_args span to be expansion
I found this while exploring solutions for rust-lang/rust-clippy#7843 .
r? `@m-ou-se`
2021-11-28 23:45:15 +01:00
ac8d514376
Add parent crate assert to register_expn_id
2021-11-28 16:35:54 -06:00
768cfac705
Add fast path to is_descendant_of
2021-11-28 16:35:54 -06:00
350158dd6d
Auto merge of #90681 - workingjubilee:update-libc, r=JohnTitor
...
Update libc to 0.2.108
Changelog:
https://github.com/rust-lang/libc/releases/tag/0.2.107
https://github.com/rust-lang/libc/releases/tag/0.2.108
Primarily intended to pull in rust-lang/libc@fd331f65f2
This should help with https://github.com/rust-lang/rust/pull/90044
2021-11-28 22:29:57 +00:00
db9d361a47
Auto merge of #91320 - matthiaskrgr:rollup-r209seq, r=matthiaskrgr
...
Rollup of 3 pull requests
Successful merges:
- #91251 (Perform Sync check on static items in wf-check instead of during const checks)
- #91308 (Fix ICE when lowering `trait A where for<'a> Self: 'a`)
- #91319 (Change output path to {{build-base}} for rustdoc scrape_examples ui test)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-28 17:14:04 +00:00
a7639b67ac
Rollup merge of #91319 - fee1-dead:rustdoc-ice-fix, r=jyn514
...
Change output path to {{build-base}} for rustdoc scrape_examples ui test
See https://github.com/rust-lang/rust/pull/90611#issuecomment-981092909
r? `@jyn514`
cc `@petrochenkov`
2021-11-28 17:11:12 +01:00
67d175515f
Rollup merge of #91308 - BGR360:issue-88586, r=jackh726
...
Fix ICE when lowering `trait A where for<'a> Self: 'a`
Fixes #88586 .
r? `@jackh726`
Jack, this fix is much smaller in scope than what I think you were proposing in the issue. Let me know if you had a vision for a larger refactor here.
cc `@JohnTitor`
2021-11-28 17:11:11 +01:00
233c50e79e
Rollup merge of #91251 - oli-obk:wf_sync_statics, r=matthewjasper
...
Perform Sync check on static items in wf-check instead of during const checks
r? `@RalfJung`
This check is solely happening on the signature of the static item and not on its body, therefor it belongs into wf-checking instead of const checking.
2021-11-28 17:11:10 +01:00
e13562c118
Change output path to {{build-base}}
2021-11-28 23:42:47 +08:00
6df2c78e1c
Address PR feedback
2021-11-28 07:05:23 -06:00
e6d2de9483
Auto merge of #91230 - eggyal:fallible-type-fold, r=jackh726
...
Make `TypeFolder::fold_*` return `Result`
Implements rust-lang/compiler-team#432.
Initially this is just a rebase of `@LeSeulArtichaut's` work in #85469 (abandoned; see https://github.com/rust-lang/rust/pull/85485#issuecomment-908781112 ). At that time, it caused a regression in performance that required some further exploration... with this rebased PR bors can hopefully report some perf analysis from which we can investigate further (if the regression is indeed still present).
r? `@jackh726` cc `@nikomatsakis`
2021-11-28 13:04:27 +00:00
58f9efd36d
Auto merge of #91311 - matthiaskrgr:rollup-ju9xizl, r=matthiaskrgr
...
Rollup of 3 pull requests
Successful merges:
- #90896 (Stabilize some `MaybeUninit` behavior as const)
- #91254 (Only check for errors in predicate when skipping impl assembly)
- #91303 (Miri: fix alignment check in array initialization)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-28 09:57:59 +00:00
7134ae0a8d
Rollup merge of #91303 - RalfJung:array-init-align, r=oli-obk
...
Miri: fix alignment check in array initialization
https://github.com/rust-lang/rust/pull/85376 introduced a regression in Miri, reported at https://github.com/rust-lang/miri/issues/1919 and https://github.com/rust-lang/miri/issues/1925 . This PR fixes that. I will add tests to Miri once this lands.
r? `@oli-obk`
Fixes https://github.com/rust-lang/miri/issues/1919
Fixes https://github.com/rust-lang/miri/issues/1925
2021-11-28 10:42:40 +01:00
9e8dfcffb7
Rollup merge of #91254 - Aaron1011:impl-candidate-err-ty, r=lcnr
...
Only check for errors in predicate when skipping impl assembly
Prior to PR #91205 , checking for errors in the overall obligation
would check checking the `ParamEnv`, due to an incorrect
`super_visit_with` impl. With this bug fixed, we will now
bail out of impl candidate assembly if the `ParamEnv` contains
any error types.
In practice, this appears to be overly conservative - when an error
occurs early in compilation, we end up giving up early for some
predicates that we could have successfully evaluated without overflow.
By only checking for errors in the predicate itself, we avoid causing
additional spurious 'type annotations needed' errors after a 'real'
error has already occurred.
With this PR, the diagnostic changes caused by PR #91205 are reverted.
2021-11-28 10:42:39 +01:00
af0cf34787
Rollup merge of #90896 - jhpratt:stabilize_const_maybe_uninit, r=oli-obk
...
Stabilize some `MaybeUninit` behavior as const
This stabilizes the `MaybeUninit::as_ptr`, `MaybeUninit::assume_init`, and `MaybeUninit::assume_init_ref` as `const fn`. `MaybeUninit::as_mut_ptr` has been moved to a new flag: `const_maybe_uninit_as_mut_ptr`, which is blocked on #57349 . `MaybeUninit::slice_assume_init_ref` can be `const fn` when the method is stabilized in general.
The relevant intrinsic has been stabilized as `const` as well, though this isn't user-visible. Due to the seemingly unrelated feature name I performed `rg const_assert_type` and found no other instances of it being used.
r? `@oli-obk`
`@rustbot` label: +A-const-fn +S-waiting-on-review +T-libs-api
2021-11-28 10:42:38 +01:00
44b5b838d2
Add test for const MaybeUninit
2021-11-28 01:31:25 -05:00
ad8e6bf5cc
Stabilize some MaybeUninit behavior as const
2021-11-28 01:01:47 -05:00
9155f672bf
typeck: Ensure proper bound vars passed to add_bounds.
...
Fixes the ICE in #88586 .
2021-11-27 23:59:08 -06:00
27d5935df1
Auto merge of #91301 - scottmcm:stabilize-nonzero-ipot, r=nagisa
...
Stabilize nonzero_is_power_of_two
Closes #81106
FCP has finished in the tracking issue
2021-11-28 05:55:09 +00:00
9a04ae4997
Update libc to 0.2.108
...
Changelog:
https://github.com/rust-lang/libc/releases/tag/0.2.107
https://github.com/rust-lang/libc/releases/tag/0.2.108
Primarily intended to pull in fd331f65f214ea75b6210b415b5fd8650be15c73
This should help with https://github.com/rust-lang/rust/pull/90044
2021-11-27 16:13:04 -08:00
f8e3b31858
Miri: fix alignment check in array initialization
2021-11-27 18:18:48 -05:00
4919988fe1
Auto merge of #91241 - dtolnay:firstchunk, r=oli-obk
...
Eliminate an unreachable codepath from String::from_utf8_lossy
`Utf8Lossy`'s `Iterator` implementation ensures that only the **final** chunk has an empty slice for `broken`:
https://github.com/rust-lang/rust/blob/dd549dcab404ec4c7d07b5a83aca5bdd7171138f/library/core/src/str/lossy.rs#L46-L47
Thus the only way the **first** chunk could have an empty `broken` is if it is the **final** chunk, i.e. there is only one chunk total. And the only way that there could be one chunk total with an empty `broken` is if the whole input is valid utf8 and non-empty.
That condition has already been handled by an early return, so at the point that the first `REPLACEMENT` is being pushed, it's impossible for `first_broken` to be empty.
2021-11-27 22:53:21 +00:00
23045eb622
Stabilize nonzero_is_power_of_two
...
Fixes 81106
FCP has finished in the tracking issue
2021-11-27 13:13:04 -08:00
d18065d997
Only check for errors in predicate when skipping impl assembly
...
Prior to PR #91205 , checking for errors in the overall obligation
would check checking the `ParamEnv`, due to an incorrect
`super_visit_with` impl. With this bug fixed, we will now
bail out of impl candidate assembly if the `ParamEnv` contains
any error types.
In practice, this appears to be overly conservative - when an error
occurs early in compilation, we end up giving up early for some
predicates that we could have successfully evaluated without overflow.
By only checking for errors in the predicate itself, we avoid causing
additional spurious 'type annotations needed' errors after a 'real'
error has already occurred.
With this PR, the diagnostic changes caused by PR #91205 are reverted.
2021-11-27 11:33:55 -06:00
afa6f92c46
Use intrinsic pointer methods
2021-11-27 16:59:18 +00:00
9f714ef035
Delegate from map_id to try_map_id
2021-11-27 16:55:21 +00:00
04f1c09f90
Avoid UB when short-circuiting try_map_id for Vec
2021-11-27 15:06:06 +00:00
686e313a9a
Auto merge of #91288 - matthiaskrgr:rollup-yp5h41r, r=matthiaskrgr
...
Rollup of 6 pull requests
Successful merges:
- #83791 (Weaken guarantee around advancing underlying iterators in zip)
- #90995 (Document non-guarantees for Hash)
- #91057 (Expand `available_parallelism` docs in anticipation of cgroup quota support)
- #91062 (rustdoc: Consolidate static-file replacement mechanism)
- #91208 (Account for incorrect `where T::Assoc = Ty` bound)
- #91266 (Use non-generic inner function for pointer formatting)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
2021-11-27 14:29:12 +00:00
51e15ac709
Remove erroneous merge conflict
2021-11-27 11:53:00 +00:00
5fd3a5c7c1
Auto merge of #89916 - the8472:advance_by-avoid-err-0, r=dtolnay
...
Fix Iterator::advance_by contract inconsistency
The `advance_by(n)` docs state that in the error case `Err(k)` that k is always less than n.
It also states that `advance_by(0)` may return `Err(0)` to indicate an exhausted iterator.
These statements are inconsistent.
Since only one implementation (Skip) actually made use of that I changed it to return Ok(()) in that case too.
While adding some tests I also found a bug in `Take::advance_back_by`.
2021-11-27 11:31:26 +00:00
073b1208f0
Rollup merge of #91266 - jam1garner:fmt-ptr-fix, r=dtolnay
...
Use non-generic inner function for pointer formatting
Previously, despite the implementation being type-unaware, `fmt::Pointer`'s implementation for `*const T` in monomorphized. This affects:
* `fmt::Debug` for `*const T`
* `fmt::Debug` for `*mut T`
* `fmt::Pointer` for `*const T`
* `fmt::Pointer` for `*mut T`
And since the implementation is non-trivial, this results in a large amount of LLVM bitcode being generated. For example, with a large bindgen project with Debug implementations enabled, it will generate a lot of calls to `fmt::Debug for *const T`, which in turn will perform codegen for a copy of this function for every type.
For example, in a real-world bindgen'd header I've been testing with (4,189,245 lines of bindgen Rust with layout tests disabled) the difference between a slightly old nightly (`rustc 1.58.0-nightly (e249ce6b2454cc5fb37c8f25
2021-11-27 11:46:45 +01:00
7c5bcd548b
Rollup merge of #91208 - estebank:eq-constraint, r=cjgillot
...
Account for incorrect `where T::Assoc = Ty` bound
Provide suggestoin to constrain trait bound for associated type.
Revert incorrect changes to `missing-bounds` test.
Address part of #20041 .
2021-11-27 11:46:44 +01:00
Oli Scherer