c39849a34d
fix: not suggest seek_to_start_instead_of_rewind when expr is used
2022-12-17 17:31:34 +05:30
3b67e6af9e
Auto merge of #10059 - alex-semenyuk:fix_badge_book, r=flip1995
...
Fix badge
Apply this #9734 for book
changelog: none
2022-12-10 22:24:29 +00:00
55f1698a6c
Fix badge
2022-12-10 19:15:08 +03:00
c0130e45df
Auto merge of #10055 - taiki-e:uninlined_format_args, r=llogiq
...
uninlined_format_args: Ignore assert! and debug_assert! before 2021 edition
Similar to https://github.com/rust-lang/rust-clippy/pull/9605 , but for `assert!` and `debug_assert!` macros. ([non_fmt_panics lint triggers them](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=18b20c408ec62a67f1503cd5d284424b ))
changelog: [`uninlined_format_args`]: Do not inline `assert!` and `debug_assert!` macros before 2021 edition
r? `@llogiq`
2022-12-10 09:48:11 +00:00
e5010c996e
uninlined_format_args: Ignore assert! and debug_assert! before 2021 edition
2022-12-10 18:35:24 +09:00
ef2018cc49
Auto merge of #10043 - phtown:master, r=Jarcho
...
Add lint `almost_complete_digit_range`
changelog: [`almost_complete_digit_range`]: Add digit analog to `almost_complete_letter_range`
I have added a lint that will detect `'0'..'9'` and suggest converting it to `'0'..='9'`, the same way `almost_complete_letter_range` does for ascii letters. I tied into the implementation of `AlmostCompleteLetterRange` in order to do that, but I didn't change its interface.
This is my first contribution to Clippy, so please let me know if there's anything I should do differently. I'll be happy to incorporate any suggestions you have.
Thanks!
2022-12-09 19:40:21 +00:00
4c80f210c3
Add lint almost_complete_range
...
This replaces and expands `almost_complete_letter_range`.
2022-12-09 13:29:50 -05:00
3492856c07
Auto merge of #10047 - Alexendoo:collapsible-str-replace-msrv, r=xFrednet
...
Add 1.58 MSRV for `collapsible_str_replace`
The `Pattern` impl for `[char; N]` was added in 1.58
changelog: Enhancement: [`collapsible_str_replace`]: Now takes MSRV into consideration. The minimal version is 1.58
[#10047 ](https://github.com/rust-lang/rust-clippy/pull/10047 )
2022-12-09 12:05:20 +00:00
5a3a722c05
Auto merge of #10004 - Jarcho:issue_9904, r=llogiq
...
Don't suggest keeping borrows in `identity_op`
fixes #9904
changelog: `identity_op`: Don't suggest keeping borrows
2022-12-09 11:53:14 +00:00
d4cd91c288
Auto merge of #9826 - Veykril:semi-blocks, r=Alexendoo
...
Add semicolon-outside/inside-block lints
changelog: Add `semicolon_outside_block` and `semicolon_inside_block` lints
Fixes https://github.com/rust-lang/rust-clippy/issues/7322
An earlier attempt at this can be found here https://github.com/rust-lang/rust-clippy/pull/7564 . This PR still implements two separate lints but I am open to merging them into a single one that's configurable.
2022-12-09 11:41:24 +00:00
39f0719a25
Auto merge of #9840 - c410-f3r:arith-2, r=Alexendoo
...
[`arithmetic-side-effects`]: Consider user-provided pairs
Depends on https://github.com/rust-lang/rust-clippy/pull/9592 .
Because of https://github.com/rust-lang/rust-clippy/pull/9559#discussion_r985293523 , r? `@Alexendoo`
```
changelog: [`arithmetic-side-effects`]: Consider user-provided pairs
```
2022-12-09 11:27:15 +00:00
1f92f97e5a
[arithmetic-side-effects]: Consider user-provided pairs
2022-12-08 17:41:49 -03:00
591c18d2f0
Add 1.58 MSRV for collapsible_str_replace
2022-12-07 17:45:12 +00:00
911864df46
Auto merge of #10046 - flip1995:ci-i386, r=xFrednet
...
CI: Don't install no longer needed dependencies on i386
changelog: none
closes #10040
2022-12-07 12:17:52 +00:00
1c03cd3fa3
Don't install dependencies on i386
2022-12-07 12:43:37 +01:00
bb6a0aa8ed
Revert "Use ubuntu-20.04 instead of ubuntu-latest"
...
This reverts commit f170b1f01a
2022-12-07 12:29:13 +01:00
d18f31efa3
Auto merge of #10036 - rust-lang:flip1995/labels, r=xFrednet
...
Add beta-nominated label to triagebot
Also non-maintainers should be able to label PRs with `beta-nominated`.
changelog: none
2022-12-06 19:09:24 +00:00
4129054120
Auto merge of #10023 - Jarcho:issue_10017, r=xFrednet
...
Fix `zero_ptr` suggestion for `no_std` crates
fixes #10017
---
changelog: Sugg: [`zero_ptr`]: Now suggests `core::` paths for `no_std` crates
[#10023 ](https://github.com/rust-lang/rust-clippy/pull/10023 )
2022-12-06 18:57:05 +00:00
5d70746251
Auto merge of #9920 - naosense:suppress_lint_in_const, r=xFrednet
...
add `suppress_restriction_lint_in_const` config
According to #9808 , add a new lint `suppress_lint_in_const` to report even in const context. BTW, i am not good at naming either, if anyone have a better idea, i am happy to change it.
This PR is still in progress, so i keep it draft.
- \[x] Followed [lint naming conventions][lint_naming]
- \[x] Added passing UI tests (including committed `.stderr` file)
- \[x] `cargo test` passes locally
- \[x] Executed `cargo dev update_lints`
- \[x] Added lint documentation
- \[x] Run `cargo dev fmt`
changelog: Enhancement: [`indexing_slicing`]: add new config `suppress-restriction-lint-in-const` to enable restriction lints, even if the suggestion might not be applicable
r? `@xFrendet`
2022-12-06 18:43:28 +00:00
8a0bf70eee
Auto merge of #10039 - xFrednet:00000-travel-back-in-ubuntu-time, r=dswij
...
Use ubuntu-20.04 instead of ubuntu-latest
changelog: none
r? `@ghost`
I'll create an issue, to undo this change, once the CI passes on `ubuntu-latest` again
2022-12-06 18:30:58 +00:00
f170b1f01a
Use ubuntu-20.04 instead of ubuntu-latest
2022-12-06 19:13:53 +01:00
00192d299d
Add beta-nominated label to triagebot
...
Also non-maintainers should be able to label PRs with `beta-nominated`.
2022-12-06 09:47:59 +01:00
20ec2ceab8
Add test case for blocks with semicolon inside and outside a block
2022-12-05 11:02:10 +01:00
cb8df45333
Auto merge of #10027 - smoelius:fix-10021, r=dswij
...
Fix 10021
This PR proposes a fix for #10021 .
The problem is similar to the one that `@mikerite` described in #9505 . The compiler is generating an empty substitution for a call, even though the type of `Self` seems to be needed for a predicate. In `@mikerite's` case, the call was to [`IntoFuture::into_future`](https://doc.rust-lang.org/std/future/trait.IntoFuture.html#tymethod.into_future ). In this case, the call is to [`Try::branch`](https://doc.rust-lang.org/std/ops/trait.Try.html#tymethod.branch ).
The proposed fix is to verify that the parameter whose type is changing has an index within the substitution. The strikes me as a reasonable approach, since if the check were to fail, the following code would be a no-op:
https://github.com/rust-lang/rust-clippy/blob/4c123a06ba3c2ec17d3a4dfa251dccdc5368b712/clippy_lints/src/methods/unnecessary_to_owned.rs#L420-L428
Like `@mikerite's` original solution, this solution turns ICEs into false negatives.
changelog: fix `unnecessary_to_owned` false positive involving `Try::branch`
2022-12-04 01:58:43 +00:00
eec5039f09
fix test
2022-12-03 16:06:57 +08:00
2701a4076f
Fix #10021
2022-12-02 20:48:18 -05:00
cb420080ac
Add test for #10021
2022-12-02 20:48:18 -05:00
6ba2cda79a
Fix zero_ptr suggestion for no_std crates
2022-12-02 15:36:17 -05:00
4c123a06ba
Auto merge of #10026 - samueltardieu:missing-slash, r=flip1995
...
Add missing slash to produce function documentation
changelog: none
2022-12-02 16:27:29 +00:00
fa4288af1f
Add missing slash to produce function documentation
2022-12-02 16:26:15 +01:00
38fce1235a
Auto merge of #10022 - Jarcho:issue_10019, r=giraffate
...
Don't lint `implicit_clone` when the type doesn't implement clone
fixes #10019
changelog: `implicit_clone`: Don't lint when the type doesn't implement clone
2022-12-02 07:17:13 +00:00
56d5657880
Auto merge of #9962 - mdgaziur:master, r=dswij
...
Fix #9958
This PR fixes #9958 . In order to fix the issue, the lint will now peel reference operators and enclose the expression with parentheses when necessary.
changelog: [`comparison_to_empty`]: Peel deref operators in suggestions when necessary
2022-12-02 05:49:26 +00:00
b43c9f7638
Auto merge of #9982 - Jarcho:issue_9935, r=flip1995
...
Don't lint `from_over_into` for opaque types
fixes #9935
This is stalled until the next sync. The impl in question can't be written on the pinned nightly.
changelog: Don't lint `from_over_into` for opaque types
2022-12-02 04:31:55 +00:00
ab8c6beb85
Don't lint implicit_clone when the type doesn't implement clone
2022-12-01 23:05:53 -05:00
fec00573a5
Auto merge of #10013 - Jarcho:issue_9886, r=Manishearth
...
Don't lint `manual_assert` in `else if`
fixes #9886
changelog: `manual_assert`: Don't lint in `else if`
2022-12-01 22:49:40 +00:00
47fb67fa08
Don't lint manual_assert in else if
2022-12-01 17:37:18 -05:00
e16a8b93ba
Auto merge of #10008 - Jarcho:issue_9882, r=Manishearth
...
Treat custom enum discriminant values as constants
fixes #9882
changelog: All lints: Don't lint in enum discriminant values when the suggestion won't work in a const context
2022-12-01 22:37:15 +00:00
be0eb20fff
Auto merge of #10006 - Jarcho:issue_9890, r=Manishearth
...
Don't suggest removing `mut` from references in `redundant_static_lifetimes`
fixes #9890
changelog: `redundant_static_lifetimes`: Don't suggest removing `mut` from references
2022-12-01 22:25:38 +00:00
53e1b45137
Auto merge of #9966 - alex-semenyuk:manual_let_else_paren, r=xFrednet
...
Fix manual_let_else produces a wrong suggestion with or-patterns
Fix #9938
changelog: Sugg: [`manual_let_else`]: Suggestions for or-patterns now include required brackets.
[#9966 ](https://github.com/rust-lang/rust-clippy/pull/9966 )
2022-12-01 22:11:01 +00:00
3b8a10cfab
Auto merge of #10012 - Jarcho:issue_9885, r=Alexendoo
...
Don't lint `string_lit_as_bytes` in match scrutinees
fixes #9885
changelog: `string_lit_as_bytes`: Don't lint in match scrutinees
2022-12-01 20:26:46 +00:00
a21b5b25f6
Don't lint string_lit_as_bytes in match scrutinees
2022-12-01 14:52:41 -05:00
05477ff8df
Fix manual_let_else produces a wrong suggestion with or-patterns
2022-12-01 22:05:06 +03:00
6ecdff07e5
Don't lint from_over_into for opaque types
2022-12-01 11:51:31 -05:00
d822110d3b
Auto merge of #10010 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2022-12-01 13:21:51 +00:00
4063712bf4
Bump nightly version -> 2022-12-01
2022-12-01 12:55:29 +01:00
11434f270f
Merge remote-tracking branch 'upstream/master' into rustup
2022-12-01 12:55:15 +01:00
641ced4eb9
Auto merge of #10007 - Jarcho:issue_10005, r=giraffate
...
Fix ICE in `result_large_err` with uninhabited enums
fixes #10005
changelog: `result_large_err`: Fix ICE with uninhabited enums
2022-12-01 07:20:06 +00:00
a1b15f13f7
Treat custom enum discriminant values as constants
2022-11-30 22:34:42 -05:00
7ae5c81e9f
Fix ICE in result large_err with uninhabited enums
2022-11-30 21:44:18 -05:00
55096eab0f
Don't suggest removing mut from references in redundant_static_lifetimes
2022-11-30 21:29:48 -05:00
feniljain