bbd0fbd98d
Merge #2101
...
2101: Preserve whitespace at the end of doc comments r=matklad a=kjeremy
Whitespace can have special meaning in markdown. For instance ending a line with three spaces will render a new line.
Note that this behavior diverges from RLS.
Fixes #1997
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com >
2019-10-27 21:00:16 +00:00
1438f38eb6
Preserve whitespace at the end of doc comments
...
Whitespace can have special meaning in markdown. For instance
ending a line with three spaces will render a new line.
Note that this behavior diverges from RLS.
Fixes #1997
2019-10-27 16:56:25 -04:00
46b63c462d
Merge #2099
...
2099: Fix panic on raw string assist r=matklad a=aee11
Strings that do not contain two quotation marks would cause a slice indexing panic because `find_usual_string_range` would return a range that only contained a single quotation mark.
Panic example:
```
fn main() {
let s = "<|>
}
```
I noticed a lot of panics from the `make_raw_string` assist while working on another issue today.
Co-authored-by: Alexander Elís Ebenesersson <alex2789@gmail.com >
2019-10-27 19:20:01 +00:00
17bd3e59f8
Fix panic on raw string assist
...
Strings that do not contain two quotation marks
would cause a slice indexing panic because code
was assuming `find_usual_string_range` would return
a string with two quotes, but it would incorrectly
also return text ranges containing only a single quote.
2019-10-28 03:00:28 +09:00
534c8a0d78
Merge #2096
...
2096: further simplify assists r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 15:24:14 +00:00
ad3fe316c6
further simplify assists
2019-10-27 18:22:14 +03:00
f6588b8676
Merge #2095
...
2095: move all assists to use generated docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 14:50:27 +00:00
b6fcacd96d
move all assists to use generated docs
2019-10-27 17:49:39 +03:00
cf309b6a5f
Merge #2094
...
2094: simplify AssistCtx API r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 14:38:28 +00:00
cda6355de2
simplify AssistCtx API
...
We never actually use ability to create multiple actions out of a
single context
2019-10-27 17:35:37 +03:00
9e638c9f3e
simplify
2019-10-27 17:27:05 +03:00
ad950830d0
Merge #2090
...
2090: move public stuff to top r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 14:13:09 +00:00
6a454c7133
Merge #2091
...
2091: use new api for flip_trait_bound assist r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 14:03:05 +00:00
85c64ec7be
use new api for flip_trait_bound assist
2019-10-27 17:02:43 +03:00
fc2fc8528b
Add tests for the trait bound flip assist.
...
Co-authored-by: vlthr <vlthr@users.noreply.github.com >
2019-10-27 16:52:33 +03:00
3a64a85a52
Fixes #2054 .
...
This adds the `flip_trait_bound` assist which allows for the swapping of two trait bounds in a trait list that are next to each other.
2019-10-27 16:52:33 +03:00
be0f48f7cf
move public stuff to top
2019-10-27 16:48:20 +03:00
73532e900e
rename auto_import -> add_import
...
We are long way from auto imports at the moment
2019-10-27 16:46:49 +03:00
e46c73dc4e
Merge #2088
...
2088: Extend selection in trait bound extends to plus r=matklad a=aee11
When multiple traits bounds are present, expanded selection
from a single trait bound will include the nearest plus sign
(and whitespace after) before including the whole trait bound.
Fixes : #2055
Co-authored-by: Alexander Elís Ebenesersson <alex2789@gmail.com >
2019-10-27 13:34:26 +00:00
3e7e3fdf16
extend selection in trait bound extends to plus
...
When multiple traits bounds are present, expanded selection
from a single trait bound will include the nearest plus sign
(and whitespace after) before including the whole trait bound.
2019-10-27 21:29:06 +09:00
7dfbe28211
Merge #2087
...
2087: remove relative_path_buf workaround r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 09:40:57 +00:00
8464c45086
remove relative_path_buf workaround
...
The upstream problem was fixed with the change to 1.0
2019-10-27 12:36:40 +03:00
5a3d2332f8
Merge #2086
...
2086: document almost all assists r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 09:23:55 +00:00
da5528824a
document almost all assists
2019-10-27 12:23:22 +03:00
a455635b48
Merge #2085
...
2085: lightly document assist_ctx module r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 09:04:43 +00:00
860bbd56ef
lightly document assist_ctx module
2019-10-27 12:04:06 +03:00
c185f74fc9
Merge #2084
...
2084: use more consistent naming r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 08:53:56 +00:00
8118dc1bb9
use more consistent naming
...
I think this is the first time I use global rename for rust-analyzer
itself :-)
2019-10-27 11:53:09 +03:00
61349a3d18
extract assist helper for getting a specific token
2019-10-27 11:53:01 +03:00
3840324429
raw string assists work in macros
2019-10-27 11:49:13 +03:00
b85f6d522a
Merge #2083
...
2083: document some more assists r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-27 08:27:19 +00:00
a490ba06fa
document some more assists
2019-10-27 11:26:46 +03:00
85984b09e1
Merge #2081
...
2081: use unicode bar for drawing the cursor r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 18:23:59 +00:00
cf4720ffd5
use unicode bar for drawing the cursor
2019-10-26 21:22:40 +03:00
1060041393
Merge #2078
...
2078: support range selection in assist docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 17:58:12 +00:00
4a83aae098
support range selection in assist docs
2019-10-26 20:57:23 +03:00
733fd64260
Merge #2079
...
2079: avoid TextEditorBuilder for simple edits r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 17:11:58 +00:00
431e4ff4ef
avoid TextEditorBuilder for simple edits
2019-10-26 20:09:56 +03:00
568ef921ac
Merge #2077
...
2077: check style for assist docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 16:12:17 +00:00
a5cbd8d5e8
check style for assist docs
2019-10-26 19:08:13 +03:00
2f7d1f10c1
Merge #2076
...
2076: use correct spacing for enum pattern r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 15:04:26 +00:00
4ef9b8d17a
use correct spacing for enum pattern
2019-10-26 18:03:55 +03:00
65e3fc8e77
Merge #2075
...
2075: document a couple of assists r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 14:38:20 +00:00
3126152a84
document a couple of assists
2019-10-26 17:37:55 +03:00
394e474479
add blank lines for readability
2019-10-26 17:27:47 +03:00
fa4ccc5fef
Merge #2074
...
2074: document tasks module r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 14:25:35 +00:00
e3a253d80f
document tasks module
2019-10-26 17:20:44 +03:00
75cd15c84f
Merge #2073
...
2073: warn if npm is not found r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-10-26 14:13:21 +00:00
8e8b6e7f62
warn if npm is not found
2019-10-26 17:12:56 +03:00
37770a3adf
Merge #2072
...
2072: Upgrade Chalk (without using its dyn/impl Trait support) r=matklad a=flodiebold
Co-authored-by: Florian Diebold <flodiebold@gmail.com >
2019-10-26 14:01:02 +00:00
bors[bot]