6750c11df3
Rename a few crate_def_maps to def_map
...
These could all be block `DefMap`s instead of crate-level `DefMap`s
2021-03-07 00:20:13 +01:00
c44575b485
Merge #7896
...
7896: Only replace quotes in replace_string_with_char assist r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-03-06 20:22:36 +00:00
1a276f8959
Only replace quotes in replace_string_with_char assist
2021-03-06 21:21:18 +01:00
5480bed936
Merge #7800
...
7800: [WIP] 7708: Initial implementation of generate Default assist. r=Veykril a=chetankhilosiya
The Generate Default impl from new function.
Co-authored-by: Chetan Khilosiya <chetan.khilosiya@gmail.com >
2021-03-06 20:01:50 +00:00
d40a4fc92c
7708: rust ideomatic code fixes.
2021-03-07 01:26:05 +05:30
856c2850cd
Merge #7865
...
7865: preserve escape sequences when replacing string with char r=Veykril a=jDomantas
Currently it replaces escape sequence with the actual value, which is very wrong for `"\n"`.
Co-authored-by: Domantas Jadenkus <djadenkus@gmail.com >
2021-03-06 19:54:36 +00:00
e4b6541c7a
7708: handle both FamousDefs fixture and plain code.
...
Also fix typo in example.
2021-03-07 00:51:48 +05:30
9a84daf47d
7708: Added the updated implementation of is_default_implemented.
...
The implementation uses hir create to find the implemented trait.
2021-03-07 00:49:03 +05:30
b8e6d6a606
7708: Added the logic to check is default impl is already present.
...
Also added test cases for code present within module.
2021-03-07 00:49:03 +05:30
a59a97ae04
7708: Updated generate default fn logic.
2021-03-07 00:49:03 +05:30
54b4727fa3
7708: Added the work for review comments.
...
Also added 1 test case to test multiple struct blocks are present.
2021-03-07 00:49:03 +05:30
135c9e2027
7708: Fixed many documentaion example issues.
2021-03-07 00:49:03 +05:30
69a6e4c80c
7708: Format code through rust-analyzer formatter.
2021-03-07 00:49:03 +05:30
cb3f4d43d9
7708: Initial implementation of generate Default assist.
...
The Generate Default impl from new function.
2021-03-07 00:49:03 +05:30
71b8fb7c57
Merge #7894
...
7894: generate_function assist: convert arg names to lower snake case r=Veykril a=JoshMcguigan
This PR fixes one of the points listed by @TimoFreiberg in #3639 . Specifically that all generated argument names should be converted to lower snake case.
```rust
struct BazBaz;
fn foo() {
bar$0(BazBaz);
// ^ when triggering the assist here, you get the output below
}
// BEFORE
fn bar(BazBaz: BazBaz) ${0:-> ()} {
todo!()
}
// AFTER
fn bar(baz_baz: BazBaz) ${0:-> ()} {
todo!()
}
```
Co-authored-by: Josh Mcguigan <joshmcg88@gmail.com >
2021-03-06 18:44:34 +00:00
e29b53f1e6
generate function assist convert arg names to lower snake case
2021-03-06 09:53:21 -08:00
cd60c4f76c
Merge #7888
...
7888: Add a line about code action commands to the CoC section of the docs r=lnicola a=flodiebold
Co-authored-by: Florian Diebold <flodiebold@gmail.com >
2021-03-06 10:38:57 +00:00
d6094c70fb
Add a line about code action commands to the CoC section of the docs
2021-03-06 11:35:04 +01:00
750d3cb846
Merge #7887
...
7887: Fix fail to parse :: for meta in mbe r=edwin0cheng a=edwin0cheng
fixes #7886
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com >
2021-03-05 20:59:31 +00:00
20eda09712
Fix fail to parse :: for meta in mbe
2021-03-06 04:57:34 +08:00
94012e24e0
Merge #7884
...
7884: Simplify TokenStream FromStr r=edwin0cheng a=edwin0cheng
Make sure `FromStr` ignore all `TokenMap` in all cases.
bors r+
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com >
2021-03-05 20:00:04 +00:00
7199d5b56d
Merge #7869
...
7869: Add support for deref assignments to "pull assignment up" assist. r=Veykril a=Jesse-Bakker
Fixes #7867
Co-authored-by: Jesse Bakker <github@jessebakker.com >
2021-03-05 19:52:15 +00:00
ab84a4746b
Add support for deref assignments to "pull assignment up" assist.
...
Fixes #7867
2021-03-05 20:42:23 +01:00
83230b2704
Fix test
2021-03-06 03:30:22 +08:00
0405d758a5
Simplify TokenStream FromStr
2021-03-06 03:17:36 +08:00
3d662e320b
Merge #7883
...
7883: Make two calls virtual r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro >
2021-03-05 18:49:29 +00:00
d3ca22876c
Make two calls virtual
2021-03-05 20:25:24 +02:00
069efbbb52
Merge #7882
...
7882: cargo update r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com >
2021-03-05 18:15:10 +00:00
124c9fe006
cargo update
2021-03-05 13:14:29 -05:00
3ee531afd8
Merge #7881
...
7881: Underengineer `cargo xtask install --client` r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2021-03-05 17:43:23 +00:00
bf4aaa4fb0
Underengineer cargo xtask install --client
2021-03-05 20:42:41 +03:00
2b55cce49e
Merge #7880
...
7880: Honor snippet capability when using the extract function assist r=lnicola a=Arthamys
This fixes issue #7793
Co-authored-by: san <san@alien.parts >
2021-03-05 16:24:32 +00:00
769b3bca28
Honor snippet capability in extract function assist
2021-03-05 17:20:26 +01:00
6c27c55041
Merge #7870
...
7870: Use chalk_ir::AdtId r=Veykril a=Veykril
It's a bit unfortunate that we got two AdtId's now(technically 3 with the alias in the chalk module but that one won't allow pattern matching), one from hir_def and one from chalk_ir(hir_ty). But the hir_ty/chalk one doesn't leave hir so it shouldn't be that bad I suppose. Though if I see this right this will happen for almost all IDs.
I imagine most of the intermediate changes to using chalk ids will turn out not too nice until the refactor is over.
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-03-05 16:04:49 +00:00
25a43e24c8
Merge #7879
...
7879: Fix some warnings r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro >
2021-03-05 14:12:19 +00:00
42057896bc
Fix some warnings
2021-03-05 15:59:50 +02:00
9707acb59b
Merge #7876
...
7876: Cleanup install command r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2021-03-05 08:52:07 +00:00
142f9a03fd
Cleanup install command
2021-03-05 11:51:32 +03:00
97b1550dda
Fix regression where the client was not installed
2021-03-05 11:12:40 +03:00
50e01d2bc7
Use chalk_ir::AdtId
2021-03-04 19:38:02 +01:00
16a76aa158
Merge #7868
...
7868: Migrate to user-centric config name for `cargo check` stuff r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2021-03-04 12:39:36 +00:00
3d80e0a154
Migrate to user-centric config name for cargo check stuff
2021-03-04 15:38:53 +03:00
7275750e42
Merge #7866
...
7866: Complete `while let` r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-03-03 22:05:38 +00:00
02e9440e23
Complete while let
2021-03-03 23:04:11 +01:00
5bb4aec05f
preserve escape sequences when replacing string with char
2021-03-03 23:20:18 +02:00
1914b7723f
Don't complete super unless its valid in paths
2021-03-03 21:58:48 +01:00
d0fa7abc50
Merge #7863
...
7863: Prevent renaming SelfType and BuiltinType r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-03-03 18:49:43 +00:00
e194f2edc4
Prevent renaming SelfType and BuiltinType
2021-03-03 19:48:53 +01:00
183ba483a9
Reorder functions in rename.rs
2021-03-03 19:48:35 +01:00
607716d213
Merge #7862
...
7862: Remove incorrect broken test r=jonas-schievink a=jonas-schievink
`Struct` cannot be named at all in that position, since `super` doesn't
resolve to the block scope
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com >
2021-03-03 18:11:56 +00:00
Jonas Schievink