Commit Graph

89554 Commits

Author SHA1 Message Date
Oliver Scherer 1dba7cb202 Fiddle through the module visibilities for tests 2019-02-11 15:08:17 +01:00
Oliver Scherer a83e73dce4 Move out tests of a deprecated module to work around #[test] bugs
https://github.com/rust-lang/rust/issues/47238
2019-02-11 15:08:17 +01:00
Oliver Scherer 4cfc2ce46d Use allow_internal_unstable in rustc itself 2019-02-11 15:08:17 +01:00
Oliver Scherer 36e7424b86 Update fulldeps test 2019-02-11 15:08:17 +01:00
Oliver Scherer da8352cee4 Fixup RustcDeserialize internal features 2019-02-11 15:08:17 +01:00
Oliver Scherer 19208367d4 Use a more fitting name for a respanning function 2019-02-11 15:08:17 +01:00
Oliver Scherer 0b3d8de2a0 Consistent attribute argument suggestion 2019-02-11 15:08:17 +01:00
Oliver Scherer 87d5383ec3 Rename the exp field to mirror its uses 2019-02-11 15:08:17 +01:00
Oliver Scherer 33bf81eec0 Ease the transition to requiring features by just warning if there's no feature list
while we could make this change (it's all unstable after all), there are crates.io crates that use the feature and that the compiler depends upon. We can instead roll out this feature while still supporting the old way.
2019-02-11 15:08:17 +01:00
Oliver Scherer d3c212c552 Require a list of features to allow in allow_internal_unstable 2019-02-11 15:08:16 +01:00
bors 57d7cfc3cf Auto merge of #56645 - pietroalbini:fix-unused-imports, r=estebank
Initial implementation of rustfixable unused_imports lint

This PR adds the initial implementation of rustfixable `unused_imports` lint. The implementation works, but rustfix is not able to apply all the suggestions until https://github.com/rust-lang/rust/issues/53934 is fixed. It also needs https://github.com/rust-lang/rust/pull/58296 to hide the suggested note since it's really useless.

cc https://github.com/rust-lang/rust/issues/47888

<details><summary><code>cargo fix</code> in action on the <code>unused_imports</code> lint</summary>

![screenshot from 2018-12-09 15-49-01](https://user-images.githubusercontent.com/2299951/49698874-3a026080-fbca-11e8-9bf1-24060b6c59c8.png)

</details>
2019-02-11 10:34:09 +00:00
bors 576df31bed Auto merge of #58153 - ljedrz:HirIdify_typeck, r=Zoxc
Partially Hiridify typeck

Another step towards https://github.com/rust-lang/rust/pull/57578.
2019-02-11 06:03:58 +00:00
bors 4424a2c31a Auto merge of #58152 - ljedrz:HirIdify_mir, r=Zoxc
Partially HirIdify mir

Another step towards https://github.com/rust-lang/rust/pull/57578.
2019-02-11 03:35:22 +00:00
bors 2d725287e3 Auto merge of #58358 - pietroalbini:update-cargo, r=Mark-Simulacrum
Bump cargo to 865cb70

Merged PRs:

* Replace util::without_prefix with Path::strip_prefix rust-lang/cargo#6620
* keep track of crates that are whitelisted to be used even if yanked rust-lang/cargo#6611
* Fix default DYLD_FALLBACK_LIBRARY_PATH on MacOS. rust-lang/cargo#6625
* Bail when trying to run "test --doc --no-run" rust-lang/cargo#6628
* In cargo test's help, add that examples are built rust-lang/cargo#6619
* Extract & re-use filter_targets in cargo_compile rust-lang/cargo#6621
* Test cleanup: remove unnecessary with_status(0) rust-lang/cargo#6630
* Fix run's help message rust-lang/cargo#6631
* Some updates to bash completion. rust-lang/cargo#6644
* Introduce Source::download_now rust-lang/cargo#6637
* Switch from unused_imports to deprecated to test unfixable warnings rust-lang/cargo#6649
2019-02-11 01:05:22 +00:00
bors 3d845e131f Auto merge of #58361 - GuillaumeGomez:rollup, r=GuillaumeGomez
Rollup of 16 pull requests

Successful merges:

 - #57259 (Update reference of rlibc crate to compiler-builtins crate)
 - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets)
 - #57926 (Tiny expansion to docs for `core::convert`.)
 - #58157 (Add Cargo.lock automatically adding message)
 - #58203 (rustdoc: display sugared return types for async functions)
 - #58243 (Add trait alias support in rustdoc)
 - #58262 (Add #[must_use] message to Fn* traits)
 - #58295 (std::sys::unix::stdio: explain why we do into_raw)
 - #58297 (Cleanup JS a bit)
 - #58317 (Some writing improvement, conciseness of intro)
 - #58324 (miri: give non-generic functions a stable address)
 - #58332 (operand-to-place copies should never be overlapping)
 - #58345 (When there are multiple filenames, print what got interpreted as filenames)
 - #58346 (rpath computation: explain why we pop())
 - #58350 (Fix failing tidy (line endings on Windows))
 - #58352 (miri value visitor: use `?` in macro)

Failed merges:

r? @ghost
2019-02-10 22:35:36 +00:00
Guillaume Gomez d792cef573 Rollup merge of #58352 - RalfJung:macro, r=oli-obk
miri value visitor: use `?` in macro
2019-02-10 21:45:27 +01:00
Guillaume Gomez 585f9a7acc Rollup merge of #58350 - petrochenkov:embed, r=frewsxcv
Fix failing tidy (line endings on Windows)

Updates to `embedded-book` including https://github.com/rust-embedded/book/pull/127.
2019-02-10 21:45:25 +01:00
Guillaume Gomez 9ccfb74a8a Rollup merge of #58346 - RalfJung:rpath-pop, r=Mark-Simulacrum
rpath computation: explain why we pop()

I was quite confused by this code until I got a debug log of what is going on.
2019-02-10 21:45:24 +01:00
Guillaume Gomez 53e9a654e1 Rollup merge of #58345 - RalfJung:2nd-filename, r=matthewjasper
When there are multiple filenames, print what got interpreted as filenames

I have written code that crafts command lines for rustc, and when I get "multiple input filenames provided" it can be quite hard to figure out where in this long list of arguments the mistake is hiding.  Probably I passed an argument to a flag that does not expect an argument, but which flag would that be?

This changes the error message to print the first two filenames, to make it easier to debug what is going on.
2019-02-10 21:45:22 +01:00
Guillaume Gomez c3aa84700a Rollup merge of #58332 - RalfJung:miri-copy-nonoverlapping, r=oli-obk
operand-to-place copies should never be overlapping

This seems to just work (verified with the Miri test suite).

r? @oli-obk
2019-02-10 21:45:21 +01:00
Guillaume Gomez a09aa0fde1 Rollup merge of #58324 - RalfJung:fn-ptr-eq, r=oli-obk
miri: give non-generic functions a stable address

This makes Miri correctly handle format string parameters despite https://github.com/rust-lang/rust/issues/58320.

Matching Miri PR: https://github.com/solson/miri/pull/626

r? @oli-obk
2019-02-10 21:45:20 +01:00
Guillaume Gomez f4e7bc50a0 Rollup merge of #58317 - hayekr:patch-1, r=frewsxcv
Some writing improvement, conciseness of intro

Made unstable-features doc more concise in the introduction paragraph
2019-02-10 21:45:19 +01:00
Guillaume Gomez d5a8b247be Rollup merge of #58297 - GuillaumeGomez:cleanup-js, r=QuietMisdreavus
Cleanup JS a bit

r? @QuietMisdreavus
2019-02-10 21:45:18 +01:00
Guillaume Gomez d59ca59b90 Rollup merge of #58295 - RalfJung:stdio, r=alexcrichton
std::sys::unix::stdio: explain why we do into_raw

I was quite puzzled why someone would call `into_raw` and then ignore the result.
2019-02-10 21:45:16 +01:00
Guillaume Gomez 112629b921 Rollup merge of #58262 - taiki-e:must_use, r=estebank
Add #[must_use] message to Fn* traits

This PR adds `#[must_use]` message to `Fn*` traits.

Related: #57549

r? @estebank
2019-02-10 21:45:15 +01:00
Guillaume Gomez adf516b94e Rollup merge of #58243 - GuillaumeGomez:trait-alias-docs, r=Manishearth
Add trait alias support in rustdoc

Fixes #57595.

r? @QuietMisdreavus
2019-02-10 21:45:13 +01:00
Guillaume Gomez cdbd07cc40 Rollup merge of #58203 - euclio:rustdoc-async, r=GuillaumeGomez
rustdoc: display sugared return types for async functions

Fixes #58027.
2019-02-10 21:45:12 +01:00
Guillaume Gomez a74e4f7fd5 Rollup merge of #58157 - h-michael:cargo-lock, r=alexcrichton
Add Cargo.lock automatically adding message

If I execute `cargo +nightly fix`, this change always occurs; cc #58099
r? @Centril
2019-02-10 21:45:11 +01:00
Guillaume Gomez 82e051b6ce Rollup merge of #57926 - icefoxen:test-doc-pr, r=frewsxcv
Tiny expansion to docs for `core::convert`.

This is not really significant, accept or reject as you wish.  I just want to make sure I understand how the PR process works and that I'm doing it right before doing a bigger one for #33417.
2019-02-10 21:45:09 +01:00
Guillaume Gomez d9f9780918 Rollup merge of #57740 - JakubOnderka:ipv4addr-to_ne_bytes, r=scottmcm
Use `to_ne_bytes` for converting IPv4Addr to octets

It is easier and it should be also faster, because [`to_ne_bytes`](https://doc.rust-lang.org/std/primitive.u32.html#method.to_ne_bytes) just calls `mem::transmute`.
2019-02-10 21:45:08 +01:00
Guillaume Gomez e917f8b531 Rollup merge of #57259 - king6cong:master, r=alexcrichton
Update reference of rlibc crate to compiler-builtins crate

None
2019-02-10 21:45:07 +01:00
bors 0b7af2668a Auto merge of #58129 - RalfJung:maybe-uninit, r=cramertj
MaybeUninit: some docs, rename into_inner -> into_initialized, return &mut from set
2019-02-10 20:03:03 +00:00
Ralf Jung 4833074a9a fix SGX build failures 2019-02-10 19:08:49 +01:00
Pietro Albini 998e584522 bump cargo submodule 2019-02-10 18:36:00 +01:00
Guillaume Gomez b1d82ac6ed Remove spotlight for trait aliases and fix nits 2019-02-10 16:56:21 +01:00
Ralf Jung 4853ce660e it is okay not to use into_inner 2019-02-10 15:35:47 +01:00
bors c3d2490433 Auto merge of #58151 - ljedrz:HirIdify_rustc, r=Zoxc
Partially HirId-ify rustc

Another step towards https://github.com/rust-lang/rust/pull/57578.
2019-02-10 14:30:37 +00:00
Ralf Jung eaf81c2e3e miri value visitor: use in macro 2019-02-10 15:16:25 +01:00
Guillaume Gomez c20357a62a Add trait aliases to js types 2019-02-10 14:49:20 +01:00
Guillaume Gomez 29354ddc15 Add style for trait aliases 2019-02-10 14:49:20 +01:00
Guillaume Gomez 74e97f3381 Add trait alias support in rustdoc 2019-02-10 14:49:20 +01:00
Vadim Petrochenkov 55f90c77e8 Fix failing tidy (line endings on Windows) 2019-02-10 16:21:47 +03:00
Ralf Jung adb33008f7 rpath computation: explain why we pop() 2019-02-10 13:05:43 +01:00
Ralf Jung 3a3691f187 when there are multiple filenames, print what got interpreted as 2nd filename 2019-02-10 13:01:09 +01:00
bors 68650cacf2 Auto merge of #58085 - wesleywiser:profiler_2, r=wesleywiser
Implement more detailed self profiling

Timing data and cache hits/misses are now recorded at the query level.
This allows us to show detailed per query information such as total time
for each query.

To see detailed query information in the summary pass the `-Z verbose`
flag. For example:

```
rustc -Z self-profile -Z verbose hello_world.rs
```

results in something like:

```md
Self profiling results:

| Phase                                     | Time (ms)      | Time (%) | Queries        | Hits (%)
| ----------------------------------------- | -------------- | -------- | -------------- | --------
| Other                                     |            177 |    54.97 |           8094 |    45.47
| - {time spent not running queries}        |            113 |    35.09 |              0 |     0.00
| - const_eval                              |             16 |     4.97 |             26 |    11.54
| - type_of                                 |              9 |     2.80 |            627 |    27.75
| - const_eval_raw                          |              8 |     2.48 |             22 |     0.00
| - adt_def                                 |              7 |     2.17 |            381 |    11.55
| - visible_parent_map                      |              7 |     2.17 |             99 |    98.99
| - item_attrs                              |              6 |     1.86 |            698 |    50.14
| - item_children                           |              5 |     1.55 |           2815 |     0.00
| - adt_dtorck_constraint                   |              4 |     1.24 |              2 |     0.00
| - adt_destructor                          |              2 |     0.62 |             15 |    86.67
| TypeChecking                              |             53 |    16.46 |           2834 |    79.89
| - trait_impls_of                          |              9 |     2.80 |             65 |    86.15
| - evaluate_obligation                     |              7 |     2.17 |             80 |     2.50
| - const_is_rvalue_promotable_to_static    |              6 |     1.86 |              1 |     0.00
| - is_copy_raw                             |              6 |     1.86 |             29 |    58.62
| - rvalue_promotable_map                   |              6 |     1.86 |              2 |    50.00
| - {time spent not running queries}        |              6 |     1.86 |              0 |     0.00
| - typeck_item_bodies                      |              5 |     1.55 |              1 |     0.00
| - typeck_tables_of                        |              5 |     1.55 |             19 |    94.74
| - dropck_outlives                         |              2 |     0.62 |              1 |     0.00
| - layout_raw                              |              1 |     0.31 |            668 |    87.87
| Linking                                   |             48 |    14.91 |             43 |    46.51
| - {time spent not running queries}        |             48 |    14.91 |              0 |     0.00
| Codegen                                   |             29 |     9.01 |            420 |    61.90
| - {time spent not running queries}        |             16 |     4.97 |              0 |     0.00
| - collect_and_partition_mono_items        |             11 |     3.42 |             13 |    92.31
| - mir_const                               |              1 |     0.31 |              1 |     0.00
| - mir_validated                           |              1 |     0.31 |              3 |    66.67
| Expansion                                 |             14 |     4.35 |              0 |     0.00
| - {time spent not running queries}        |             14 |     4.35 |              0 |     0.00
| BorrowChecking                            |              1 |     0.31 |             12 |    41.67
| - borrowck                                |              1 |     0.31 |              2 |    50.00
| Parsing                                   |              0 |     0.00 |              0 |     0.00

Optimization level: No
Incremental: off
```

<details>
<summary>Rendered</summary>

Self profiling results:

| Phase                                     | Time (ms)      | Time (%) | Queries        | Hits (%)
| ----------------------------------------- | -------------- | -------- | -------------- | --------
| **Other**                                     |           **177** |   **54.97** |   **8094** |  **45.47**
| - {time spent not running queries}        |            113 |    35.09 |              0 |     0.00
| - const_eval                              |             16 |     4.97 |             26 |    11.54
| - type_of                                 |              9 |     2.80 |            627 |    27.75
| - const_eval_raw                          |              8 |     2.48 |             22 |     0.00
| - adt_def                                 |              7 |     2.17 |            381 |    11.55
| - visible_parent_map                      |              7 |     2.17 |             99 |    98.99
| - item_attrs                              |              6 |     1.86 |            698 |    50.14
| - item_children                           |              5 |     1.55 |           2815 |     0.00
| - adt_dtorck_constraint                   |              4 |     1.24 |              2 |     0.00
| - adt_destructor                          |              2 |     0.62 |             15 |    86.67
| TypeChecking                              |             53 |    16.46 |           2834 |    79.89
| - trait_impls_of                          |              9 |     2.80 |             65 |    86.15
| - evaluate_obligation                     |              7 |     2.17 |             80 |     2.50
| - const_is_rvalue_promotable_to_static    |              6 |     1.86 |              1 |     0.00
| - is_copy_raw                             |              6 |     1.86 |             29 |    58.62
| - rvalue_promotable_map                   |              6 |     1.86 |              2 |    50.00
| - {time spent not running queries}        |              6 |     1.86 |              0 |     0.00
| - typeck_item_bodies                      |              5 |     1.55 |              1 |     0.00
| - typeck_tables_of                        |              5 |     1.55 |             19 |    94.74
| - dropck_outlives                         |              2 |     0.62 |              1 |     0.00
| - layout_raw                              |              1 |     0.31 |            668 |    87.87
| Linking                                   |             48 |    14.91 |             43 |    46.51
| - {time spent not running queries}        |             48 |    14.91 |              0 |     0.00
| Codegen                                   |             29 |     9.01 |            420 |    61.90
| - {time spent not running queries}        |             16 |     4.97 |              0 |     0.00
| - collect_and_partition_mono_items        |             11 |     3.42 |             13 |    92.31
| - mir_const                               |              1 |     0.31 |              1 |     0.00
| - mir_validated                           |              1 |     0.31 |              3 |    66.67
| Expansion                                 |             14 |     4.35 |              0 |     0.00
| - {time spent not running queries}        |             14 |     4.35 |              0 |     0.00
| BorrowChecking                            |              1 |     0.31 |             12 |    41.67
| - borrowck                                |              1 |     0.31 |              2 |    50.00
| Parsing                                   |              0 |     0.00 |              0 |     0.00

Optimization level: No
Incremental: off

</details>
cc @nikomatsakis @michaelwoerister @Zoxc

Fixes #54141
2019-02-10 11:18:50 +00:00
bors de111e6367 Auto merge of #58103 - RalfJung:mir-shim-dump, r=eddyb
Make -Zdump-mir dump shims

Fixes https://github.com/rust-lang/rust/issues/53532 by (a) making the MIR shim generation use the MIR pass infrastructure, and (b) fixing said infrastructure to handle the fallout.

Cc @eddyb @oli-obk
2019-02-10 08:52:10 +00:00
bors 2e08bb1dd2 Auto merge of #58339 - Mark-Simulacrum:embedded-book, r=Mark-Simulacrum
Add EmbeddedBook to test list in bootstrap

r? @alexcrichton
2019-02-10 04:34:12 +00:00
Mark Rousskov 80942e95ea Add EmbeddedBook to test list in bootstrap 2019-02-09 19:42:23 -07:00
bors 1bfb44133d Auto merge of #57770 - Zoxc:no-hash-query, r=michaelwoerister
Add a query type which is always marked as red if it runs

This is useful for queries which produce results which are very likely to change if their inputs do.

I also expect this to be useful for end to end queries because 1) we don't need `HashStable` impls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map.

r? @michaelwoerister
2019-02-10 01:33:17 +00:00
bors abcfc3b762 Auto merge of #58065 - alexreg:refactor-smart_resolve_path_fragment, r=petrochenkov
Factor out error reporting from `smart_resolve_path_fragment` fn

This function was ridiculously monolithic before. We now have three rather-less-monolithic-and-horrifying functions.

r? @centril
2019-02-09 23:02:15 +00:00