Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-04-27 18:57:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #154995 - RalfJung:minmaxby-tests, r=jhpratt

Browse Source 
min/max_by tests: also check result

These tests were recently added in https://github.com/rust-lang/rust/pull/154761. IMO there's no reason to ignore the actual result of the function in the test, so let's also assert that this is correct.
This commit is contained in:
Jacob Pratt
2026-04-08 23:03:59 -04:00
committed by GitHub
parent 6bd1a6cd31 923311c40b
commit f869e45669
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
library/coretests/tests/cmp.rs
+6 -3
View File
@@ -52,30 +52,33 @@ fn test_ord_min_max_by() {
#[test]
fn min_by_compare_argument_order() {
let mut order = vec![];
let _ = cmp::min_by(1i32, 2, |a, b| {
let res = cmp::min_by(1i32, 2, |a, b| {
order.push((*a, *b));
a.cmp(b)
});
assert_eq!(res, 1);
assert_eq!(order, [(1, 2)]);
}
#[test]
fn max_by_compare_argument_order() {
let mut order = vec![];
let _ = cmp::max_by(1i32, 2, |a, b| {
let res = cmp::max_by(1i32, 2, |a, b| {
order.push((*a, *b));
a.cmp(b)
});
assert_eq!(res, 2);
assert_eq!(order, [(1, 2)]);
}
#[test]
fn minmax_by_compare_argument_order() {
let mut order = vec![];
let _ = cmp::minmax_by(1i32, 2, |a, b| {
let res = cmp::minmax_by(1i32, 2, |a, b| {
order.push((*a, *b));
a.cmp(b)
});
assert_eq!(res, [1, 2]);
assert_eq!(order, [(1, 2)]);
}