Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-06-02 06:28:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix + add test.

Browse Source
This commit is contained in:
laurent
2017-11-17 21:52:11 +00:00
parent 8e9d0c277c
commit ed202b6055
3 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clippy_lints/src/booleans.rs
+2 -7
View File
@@ -218,13 +218,8 @@ fn recurse(&mut self, suggestion: &Bool) {
self.output.push_str(&str)
} else {
self.output.push('!');
if let ExprBinary(..) = terminal.node {
self.output.push('(');
}
self.recurse(inner);
if let ExprBinary(..) = terminal.node {
self.output.push(';');
}
let snip = self.snip(terminal);
self.output.push_str(&snip);
}
},
True | False | Not(_) => {
tests/ui/booleans.rs
+1
View File
@@ -53,4 +53,5 @@ fn methods_with_negation() {
let _ = !b.is_ok();
let c = false;
let _ = !(a.is_some() && !c);
let _ = !(!c ^ c) || !a.is_some();
}
tests/ui/booleans.stderr
+6
View File
@@ -160,3 +160,9 @@ error: this boolean expression can be simplified
55 | let _ = !(a.is_some() && !c);
| ^^^^^^^^^^^^^^^^^^^^ help: try: `c || a.is_none()`
error: this boolean expression can be simplified
--> $DIR/booleans.rs:56:13
|
56 | let _ = !(!c ^ c) || !a.is_some();
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(!c ^ c) || a.is_none()`