Merge #1555

1555: drop memory size of subtree r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

crates/ra_ide_api/src/status.rs

@@ -9,7 +9,7 @@
     FileTextQuery, SourceRootId,
 };
 use ra_prof::{memory_usage, Bytes};
-use ra_syntax::{ast, AstNode, Parse, SyntaxNode};
+use ra_syntax::{ast, Parse, SyntaxNode};
 
 use crate::{
     db::RootDatabase,
@@ -70,12 +70,11 @@ fn from_iter<T>(iter: T) -> FilesStats
 pub(crate) struct SyntaxTreeStats {
     total: usize,
     pub(crate) retained: usize,
-    retained_size: Bytes,
 }
 
 impl fmt::Display for SyntaxTreeStats {
     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
-        write!(fmt, "{} trees, {} ({}) retained", self.total, self.retained, self.retained_size,)
+        write!(fmt, "{} trees, {} retained", self.total, self.retained)
     }
 }
 
@@ -87,10 +86,7 @@ fn from_iter<T>(iter: T) -> SyntaxTreeStats
         let mut res = SyntaxTreeStats::default();
         for entry in iter {
             res.total += 1;
-            if let Some(tree) = entry.value.as_ref().map(|it| it.tree()) {
-                res.retained += 1;
-                res.retained_size += tree.syntax().memory_size_of_subtree();
-            }
+            res.retained += entry.value.is_some() as usize;
         }
         res
     }
@@ -104,10 +100,7 @@ fn from_iter<T>(iter: T) -> SyntaxTreeStats
         let mut res = SyntaxTreeStats::default();
         for entry in iter {
             res.total += 1;
-            if let Some(tree) = entry.value.and_then(|it| it).map(|it| it.syntax_node()) {
-                res.retained += 1;
-                res.retained_size += tree.memory_size_of_subtree();
-            }
+            res.retained += entry.value.is_some() as usize;
         }
         res
     }

crates/ra_syntax/src/syntax_node.rs

@@ -173,10 +173,6 @@ pub fn preorder_with_tokens(&self) -> impl Iterator<Item = WalkEvent<SyntaxEleme
         })
     }
 
-    pub fn memory_size_of_subtree(&self) -> usize {
-        0
-    }
-
     pub fn debug_dump(&self) -> String {
         let mut level = 0;
         let mut buf = String::new();