auto merge of #8977 : pnkfelix/rust/fsk-followup-on-6009-rebased, r=alexcrichton

Fix #6009.  Rebased version of #8970.  Inherits review from alexcrichton.

src/librustpkg/conditions.rs

@@ -14,33 +14,33 @@
 pub use package_id::PkgId;
 
 condition! {
-    bad_path: (Path, ~str) -> Path;
+    pub bad_path: (Path, ~str) -> Path;
 }
 
 condition! {
-    nonexistent_package: (PkgId, ~str) -> Path;
+    pub nonexistent_package: (PkgId, ~str) -> Path;
 }
 
 condition! {
-    copy_failed: (Path, Path) -> ();
+    pub copy_failed: (Path, Path) -> ();
 }
 
 condition! {
-    missing_pkg_files: (PkgId) -> ();
+    pub missing_pkg_files: (PkgId) -> ();
 }
 
 condition! {
-    bad_pkg_id: (Path, ~str) -> PkgId;
+    pub bad_pkg_id: (Path, ~str) -> PkgId;
 }
 
 condition! {
-    no_rust_path: (~str) -> Path;
+    pub no_rust_path: (~str) -> Path;
 }
 
 condition! {
-    not_a_workspace: (~str) -> Path;
+    pub not_a_workspace: (~str) -> Path;
 }
 
 condition! {
-    failed_to_create_temp_dir: (~str) -> Path;
+    pub failed_to_create_temp_dir: (~str) -> Path;
 }

src/librustpkg/package_source.rs

@@ -34,6 +34,7 @@ pub struct PkgSrc {
 }
 
 condition! {
+    // #6009: should this be pub or not, when #8215 is fixed?
     build_err: (~str) -> ();
 }
 

src/libstd/c_str.rs

@@ -28,10 +28,10 @@ pub enum NullByteResolution {
 }
 
 condition! {
-    // this should be &[u8] but there's a lifetime issue
+    // This should be &[u8] but there's a lifetime issue (#5370).
     // NOTE: this super::NullByteResolution should be NullByteResolution
-    // Change this next time the snapshot it updated.
-    null_byte: (~[u8]) -> super::NullByteResolution;
+    // Change this next time the snapshot is updated.
+    pub null_byte: (~[u8]) -> super::NullByteResolution;
 }
 
 /// The representation of a C String.

src/libstd/condition.rs

@@ -193,7 +193,8 @@ fn test_default() {
     // Issue #6009
     mod m {
         condition! {
-            sadness: int -> int;
+            // #6009, #8215: should this truly need a `pub` for access from n?
+            pub sadness: int -> int;
         }
 
         mod n {

src/libstd/rt/io/mod.rs

@@ -384,19 +384,17 @@ fn to_str(&self) -> ~str {
 // XXX: Can't put doc comments on macros
 // Raised by `I/O` operations on error.
 condition! {
-    // FIXME (#6009): uncomment `pub` after expansion support lands.
     // NOTE: this super::IoError should be IoError
-    // Change this next time the snapshot it updated.
-    /*pub*/ io_error: super::IoError -> ();
+    // Change this next time the snapshot is updated.
+    pub io_error: super::IoError -> ();
 }
 
 // XXX: Can't put doc comments on macros
 // Raised by `read` on error
 condition! {
-    // FIXME (#6009): uncomment `pub` after expansion support lands.
     // NOTE: this super::IoError should be IoError
     // Change this next time the snapshot it updated.
-    /*pub*/ read_error: super::IoError -> ();
+    pub read_error: super::IoError -> ();
 }
 
 pub trait Reader {

src/libstd/str.rs

@@ -43,7 +43,7 @@
 */
 
 condition! {
-    not_utf8: (~str) -> ~str;
+    pub not_utf8: (~str) -> ~str;
 }
 
 /*

src/libsyntax/ext/expand.rs

@@ -909,8 +909,7 @@ pub mod $c {
 
         { $c:ident: $input:ty -> $out:ty; } => {
 
-            // FIXME (#6009): remove mod's `pub` below once variant above lands.
-            pub mod $c {
+            mod $c {
                 #[allow(unused_imports)];
                 #[allow(non_uppercase_statics)];