borrow_deref_ref: do not trigger on &raw references

This commit is contained in:
Samuel Tardieu
2024-10-20 17:11:35 +02:00
parent 5873cb9d17
commit b0412d0dd7
3 changed files with 14 additions and 2 deletions
+2 -2
View File
@@ -4,7 +4,7 @@
use clippy_utils::ty::implements_trait;
use clippy_utils::{get_parent_expr, is_from_proc_macro, is_lint_allowed};
use rustc_errors::Applicability;
use rustc_hir::{ExprKind, UnOp};
use rustc_hir::{BorrowKind, ExprKind, UnOp};
use rustc_lint::{LateContext, LateLintPass};
use rustc_middle::mir::Mutability;
use rustc_middle::ty;
@@ -49,7 +49,7 @@
impl<'tcx> LateLintPass<'tcx> for BorrowDerefRef {
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &rustc_hir::Expr<'tcx>) {
if let ExprKind::AddrOf(_, Mutability::Not, addrof_target) = e.kind
if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Not, addrof_target) = e.kind
&& let ExprKind::Unary(UnOp::Deref, deref_target) = addrof_target.kind
&& !matches!(deref_target.kind, ExprKind::Unary(UnOp::Deref, ..))
&& !e.span.from_expansion()
+6
View File
@@ -71,3 +71,9 @@ mod false_negative {
assert_ne!(addr_x, addr_y);
}
}
fn issue_13584() {
let s = "Hello, world!\n";
let p = &raw const *s;
let _ = p as *const i8;
}
+6
View File
@@ -71,3 +71,9 @@ fn foo() {
assert_ne!(addr_x, addr_y);
}
}
fn issue_13584() {
let s = "Hello, world!\n";
let p = &raw const *s;
let _ = p as *const i8;
}