mirror of
https://github.com/rust-lang/rust.git
synced 2026-04-27 18:57:42 +03:00
Allow auto jobs to be non-blocking
This commit is contained in:
@@ -200,12 +200,14 @@ fn equivalent_modulo_carve_out(pr_job: &Job, auto_job: &Job) -> anyhow::Result<(
|
||||
equivalent_modulo_carve_out(pr_job, auto_job)?;
|
||||
}
|
||||
|
||||
// Auto CI jobs must all "fail-fast" to avoid wasting Auto CI resources. For instance, `tidy`.
|
||||
// Auto CI should "fail-fast" to avoid wasting Auto CI resources.
|
||||
// However, some experimental auto jobs can be made optional, for example if we are unsure about
|
||||
// their flakiness. Those have to be prefixed with `optional-`.
|
||||
for auto_job in &db.auto_jobs {
|
||||
if auto_job.continue_on_error == Some(true) {
|
||||
if auto_job.continue_on_error == Some(true) && !auto_job.name.starts_with("optional-") {
|
||||
return Err(anyhow!(
|
||||
"Auto job `{}` cannot have `continue_on_error: true`",
|
||||
auto_job.name
|
||||
"Auto job `{job}` cannot have `continue_on_error: true`. If the job should be optional, name it `optional-{job}`.",
|
||||
job = auto_job.name
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user