Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-04-27 18:57:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #117701 - lnicola:sync-from-ra, r=onur-ozkan,HKalbasi

Browse Source 
Subtree update of `rust-analyzer`

r? `@HKalbasi`
This commit is contained in:
bors
2023-11-14 18:43:27 +00:00
parent 8d57ad1ade 6ad73f5ee8
commit 49b27f4efb
184 changed files with 14949 additions and 2109 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bootstrap/src/core/build_steps/check.rs
+3 -3
View File
@@ -376,12 +376,12 @@ fn run(self, builder: &Builder<'_>) {
let compiler = builder.compiler(builder.top_stage, builder.config.build);
let target = self.target;
builder.ensure(Std::new(target));
builder.ensure(Rustc::new(target, builder));
let mut cargo = prepare_tool_cargo(
builder,
compiler,
Mode::ToolStd,
Mode::ToolRustc,
target,
cargo_subcommand(builder.kind),
"src/tools/rust-analyzer",
@@ -414,7 +414,7 @@ fn run(self, builder: &Builder<'_>) {
/// Cargo's output path in a given stage, compiled by a particular
/// compiler for the specified target.
fn stamp(builder: &Builder<'_>, compiler: Compiler, target: TargetSelection) -> PathBuf {
builder.cargo_out(compiler, Mode::ToolStd, target).join(".rust-analyzer-check.stamp")
builder.cargo_out(compiler, Mode::ToolRustc, target).join(".rust-analyzer-check.stamp")
}
}
}
src/bootstrap/src/core/build_steps/test.rs
+2 -2
View File
@@ -369,7 +369,7 @@ fn run(self, builder: &Builder<'_>) {
// We don't need to build the whole Rust Analyzer for the proc-macro-srv test suite,
// but we do need the standard library to be present.
builder.ensure(compile::Std::new(compiler, host));
builder.ensure(compile::Rustc::new(compiler, host));
let workspace_path = "src/tools/rust-analyzer";
// until the whole RA test suite runs on `i686`, we only run
@@ -378,7 +378,7 @@ fn run(self, builder: &Builder<'_>) {
let mut cargo = tool::prepare_tool_cargo(
builder,
compiler,
Mode::ToolStd,
Mode::ToolRustc,
host,
"test",
crate_path,
src/bootstrap/src/core/build_steps/tool.rs
+2 -3
View File
@@ -603,8 +603,7 @@ pub struct RustAnalyzer {
}
impl RustAnalyzer {
pub const ALLOW_FEATURES: &'static str =
"proc_macro_internals,proc_macro_diagnostic,proc_macro_span,proc_macro_span_shrink";
pub const ALLOW_FEATURES: &'static str = "rustc_private,proc_macro_internals,proc_macro_diagnostic,proc_macro_span,proc_macro_span_shrink";
}
impl Step for RustAnalyzer {
@@ -636,7 +635,7 @@ fn run(self, builder: &Builder<'_>) -> Option<PathBuf> {
compiler: self.compiler,
target: self.target,
tool: "rust-analyzer",
mode: Mode::ToolStd,
mode: Mode::ToolRustc,
path: "src/tools/rust-analyzer",
extra_features: vec!["rust-analyzer/in-rust-tree".to_owned()],
is_optional_tool: false,
src/tools/rust-analyzer/.github/workflows/autopublish.yaml
Vendored
+4
View File
@@ -19,6 +19,10 @@ jobs:
with:
fetch-depth: 0
# https://github.com/jlumbroso/free-disk-space/blob/main/action.yml
- name: Free up some disk space
run: sudo rm -rf /usr/local/lib/android /usr/share/dotnet /opt/ghc /usr/local/.ghcup
- name: Install Rust toolchain
run: rustup update --no-self-update stable
src/tools/rust-analyzer/.github/workflows/ci.yaml
Vendored
+2
View File
@@ -8,6 +8,7 @@ on:
branches:
- auto
- try
- automation/bors/try
env:
CARGO_INCREMENTAL: 0
@@ -84,6 +85,7 @@ jobs:
run: cargo build --quiet ${{ env.USE_SYSROOT_ABI }}
- name: Test
if: matrix.os == 'ubuntu-latest' || github.event_name == 'push'
run: cargo test ${{ env.USE_SYSROOT_ABI }} -- --nocapture --quiet
- name: Switch to stable toolchain
src/tools/rust-analyzer/.github/workflows/metrics.yaml
Vendored
+6 -3
View File
@@ -140,11 +140,14 @@ jobs:
- name: Combine json
run: |
git clone --depth 1 https://$METRICS_TOKEN@github.com/rust-analyzer/metrics.git
mkdir ~/.ssh
echo "${{ secrets.METRICS_DEPLOY_KEY }}" > ~/.ssh/id_ed25519
chmod 600 ~/.ssh/id_ed25519
chmod 700 ~/.ssh
git clone --depth 1 git@github.com:rust-analyzer/metrics.git
jq -s ".[0] * .[1] * .[2] * .[3] * .[4] * .[5]" build.json self.json ripgrep-13.0.0.json webrender-2022.json diesel-1.4.8.json hyper-0.14.18.json -c >> metrics/metrics.json
cd metrics
git add .
git -c user.name=Bot -c user.email=dummy@example.com commit --message 📈
git push origin master
env:
METRICS_TOKEN: ${{ secrets.METRICS_TOKEN }}
src/tools/rust-analyzer/Cargo.lock
+72 -59
View File
@@ -32,12 +32,6 @@ version = "1.0.71"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "9c7d0618f0e0b7e8ff11427422b64564d5fb0be1940354bfe2e0529b18a9d9b8"
[[package]]
name = "anymap"
version = "1.0.0-beta.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8f1f8f5a6f3d50d89e3797d7593a50f96bb2aaa20ca0cc7be1fb673232c91d72"
[[package]]
name = "arbitrary"
version = "1.3.0"
@@ -177,9 +171,9 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"
[[package]]
name = "chalk-derive"
version = "0.92.0"
version = "0.93.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "ff5053a8a42dbff5279a82423946fc56dc1253b76cf211b2b3c14b3aad4e1281"
checksum = "264726159011fc7f22c23eb51f49021ece6e71bc358b96e7f2e842db0b14162b"
dependencies = [
"proc-macro2",
"quote",
@@ -189,9 +183,9 @@ dependencies = [
[[package]]
name = "chalk-ir"
version = "0.92.0"
version = "0.93.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8a56de2146a8ed0fcd54f4bd50db852f1de4eac9e1efe568494f106c21b77d2a"
checksum = "d65c17407d4c756b8f7f84344acb0fb96364d0298822743219bb25769b6d00df"
dependencies = [
"bitflags 1.3.2",
"chalk-derive",
@@ -200,9 +194,9 @@ dependencies = [
[[package]]
name = "chalk-recursive"
version = "0.92.0"
version = "0.93.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "5cc09e6e9531f3544989ef89b189e80fbc7ad9e2f73f1c5e03ddc9ffb0527463"
checksum = "80e2cf7b70bedaaf3a8cf3c93b6120c2bb65be89389124028e724d19e209686e"
dependencies = [
"chalk-derive",
"chalk-ir",
@@ -213,9 +207,9 @@ dependencies = [
[[package]]
name = "chalk-solve"
version = "0.92.0"
version = "0.93.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b392e02b4c81ec76d3748da839fc70a5539b83d27c9030668463d34d5110b860"
checksum = "afc67c548d3854f64e97e67dc5b7c88513425c5bfa347cff96b7992ae6379288"
dependencies = [
"chalk-derive",
"chalk-ir",
@@ -518,7 +512,6 @@ dependencies = [
name = "hir-def"
version = "0.0.0"
dependencies = [
"anymap",
"arrayvec",
"base-db",
"bitflags 2.3.2",
@@ -531,8 +524,6 @@ dependencies = [
"fst",
"hashbrown 0.12.3",
"hir-expand",
"hkalbasi-rustc-ap-rustc_abi",
"hkalbasi-rustc-ap-rustc_index",
"indexmap 2.0.0",
"intern",
"itertools",
@@ -541,7 +532,7 @@ dependencies = [
"mbe",
"once_cell",
"profile",
"ra-ap-rustc_parse_format",
"rustc-dependencies",
"rustc-hash",
"smallvec",
"stdx",
@@ -594,7 +585,6 @@ dependencies = [
"expect-test",
"hir-def",
"hir-expand",
"hkalbasi-rustc-ap-rustc_index",
"intern",
"itertools",
"la-arena 0.3.1 (registry+https://github.com/rust-lang/crates.io-index)",
@@ -604,6 +594,7 @@ dependencies = [
"oorandom",
"profile",
"project-model",
"rustc-dependencies",
"rustc-hash",
"scoped-tls",
"smallvec",
@@ -617,27 +608,6 @@ dependencies = [
"typed-arena",
]
[[package]]
name = "hkalbasi-rustc-ap-rustc_abi"
version = "0.0.20221221"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "adabaadad9aa7576f97af02241cdf5554d62fb3d51a84cb05d77ba28edd3013f"
dependencies = [
"bitflags 1.3.2",
"hkalbasi-rustc-ap-rustc_index",
"tracing",
]
[[package]]
name = "hkalbasi-rustc-ap-rustc_index"
version = "0.0.20221221"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f4d3c48474e09afb0f5efbd6f758e05411699301a113c47d454d28ec7059d00e"
dependencies = [
"arrayvec",
"smallvec",
]
[[package]]
name = "home"
version = "0.5.5"
@@ -918,9 +888,9 @@ checksum = "e2abad23fbc42b3700f2f279844dc832adb2b2eb069b2df918f455c4e18cc646"
[[package]]
name = "libc"
version = "0.2.146"
version = "0.2.148"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f92be4933c13fd498862a9e02a3055f8a8d9c039ce33db97306fd5a6caa7f29b"
checksum = "9cdc71e17332e86d2e1d38c1f99edcb6288ee11b815fb1a4b049eaa2114d369b"
[[package]]
name = "libloading"
@@ -1277,7 +1247,7 @@ dependencies = [
"drop_bomb",
"expect-test",
"limit",
"ra-ap-rustc_lexer",
"rustc-dependencies",
"sourcegen",
"stdx",
]
@@ -1435,9 +1405,9 @@ dependencies = [
[[package]]
name = "protobuf"
version = "3.1.0"
version = "3.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "4ee4a7d8b91800c8f167a6268d1a1026607368e1adc84e98fe044aeb905302f7"
checksum = "b55bad9126f378a853655831eb7363b7b01b81d19f8cb1218861086ca4a1a61e"
dependencies = [
"once_cell",
"protobuf-support",
@@ -1446,9 +1416,9 @@ dependencies = [
[[package]]
name = "protobuf-support"
version = "3.1.0"
version = "3.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8ca157fe12fc7ee2e315f2f735e27df41b3d97cdd70ea112824dac1ffb08ee1c"
checksum = "a5d4d7b8601c814cfb36bcebb79f0e61e45e1e93640cf778837833bbed05c372"
dependencies = [
"thiserror",
]
@@ -1483,10 +1453,31 @@ dependencies = [
]
[[package]]
name = "ra-ap-rustc_index"
version = "0.10.0"
name = "ra-ap-rustc_abi"
version = "0.18.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "07b5fa61d34da18e148dc3a81f654488ea07f40938d8aefb17f8b64bb78c6120"
checksum = "7082716cb2bbcd8b5f062fe950cbbc87f3aba022d6da4168db35af6732a7f15d"
dependencies = [
"bitflags 1.3.2",
"ra-ap-rustc_index 0.18.0",
"tracing",
]
[[package]]
name = "ra-ap-rustc_index"
version = "0.14.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "643ca3609870b1778d9cd1f2a8e4ccb4af0f48f3637cc257a09494d087bd93dc"
dependencies = [
"arrayvec",
"smallvec",
]
[[package]]
name = "ra-ap-rustc_index"
version = "0.18.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "19e14b1fc835d6992b128a03a3f3a8365ba9f03e1c656a1670305f63f30d786d"
dependencies = [
"arrayvec",
"smallvec",
@@ -1494,9 +1485,19 @@ dependencies = [
[[package]]
name = "ra-ap-rustc_lexer"
version = "0.10.0"
version = "0.14.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f2e2f6b48422e4eed5218277ab7cc9733e60dd8f3167f4f36a49a0cafe4dc195"
checksum = "30ffd24f9ba4f1d25ff27ca1469b8d22a3bdfb12cf644fc8bfcb63121fa5da6b"
dependencies = [
"unicode-properties",
"unicode-xid",
]
[[package]]
name = "ra-ap-rustc_lexer"
version = "0.18.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1762abb25eb1e37c1823f62b5da0821bbcd870812318db084c9516c2f78d2dcd"
dependencies = [
"unicode-properties",
"unicode-xid",
@@ -1504,12 +1505,12 @@ dependencies = [
[[package]]
name = "ra-ap-rustc_parse_format"
version = "0.10.0"
version = "0.14.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "c3c7369ad01cc79f9e3513c9f6a6326f6b980100e4862a7ac71b9991c88108bb"
checksum = "207b5ac1a21d4926695e03b605ffb9f63d4968e0488e9197c04c512c37303aa7"
dependencies = [
"ra-ap-rustc_index",
"ra-ap-rustc_lexer",
"ra-ap-rustc_index 0.14.0",
"ra-ap-rustc_lexer 0.14.0",
]
[[package]]
@@ -1594,10 +1595,12 @@ dependencies = [
"oorandom",
"parking_lot 0.12.1",
"parking_lot_core 0.9.6",
"parser",
"proc-macro-api",
"profile",
"project-model",
"rayon",
"rustc-dependencies",
"rustc-hash",
"scip",
"serde",
@@ -1626,6 +1629,16 @@ version = "0.1.23"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d626bb9dae77e28219937af045c257c28bfd3f69333c512553507f5f9798cb76"
[[package]]
name = "rustc-dependencies"
version = "0.0.0"
dependencies = [
"ra-ap-rustc_abi",
"ra-ap-rustc_index 0.18.0",
"ra-ap-rustc_lexer 0.18.0",
"ra-ap-rustc_parse_format",
]
[[package]]
name = "rustc-hash"
version = "1.1.0"
@@ -1678,9 +1691,9 @@ dependencies = [
[[package]]
name = "scip"
version = "0.1.1"
version = "0.3.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "b2bfbb10286f69fad7c78db71004b7839bf957788359fe0c479f029f9849136b"
checksum = "3e84d21062a3ba08d58870c8c36b0c005b2b2261c6ad1bf7042585427c781883"
dependencies = [
"protobuf",
]
@@ -1853,9 +1866,9 @@ dependencies = [
"proc-macro2",
"profile",
"quote",
"ra-ap-rustc_lexer",
"rayon",
"rowan",
"rustc-dependencies",
"rustc-hash",
"smol_str",
"sourcegen",
src/tools/rust-analyzer/Cargo.toml
+4 -8
View File
@@ -79,6 +79,7 @@ toolchain = { path = "./crates/toolchain", version = "0.0.0" }
tt = { path = "./crates/tt", version = "0.0.0" }
vfs-notify = { path = "./crates/vfs-notify", version = "0.0.0" }
vfs = { path = "./crates/vfs", version = "0.0.0" }
rustc-dependencies = { path = "./crates/rustc-dependencies", version = "0.0.0" }
# local crates that aren't published to crates.io. These should not have versions.
proc-macro-test = { path = "./crates/proc-macro-test" }
@@ -101,11 +102,6 @@ serde = { version = "1.0.156", features = ["derive"] }
serde_json = "1.0.96"
triomphe = { version = "0.1.8", default-features = false, features = ["std"] }
# can't upgrade due to dashmap depending on 0.12.3 currently
hashbrown = { version = "0.12.3", features = ["inline-more"], default-features = false }
rustc_lexer = { version = "0.10.0", package = "ra-ap-rustc_lexer" }
rustc_parse_format = { version = "0.10.0", package = "ra-ap-rustc_parse_format", default-features = false }
# Upstream broke this for us so we can't update it
rustc_abi = { version = "0.0.20221221", package = "hkalbasi-rustc-ap-rustc_abi", default-features = false }
rustc_index = { version = "0.0.20221221", package = "hkalbasi-rustc-ap-rustc_index", default-features = false }
hashbrown = { version = "0.12.3", features = [
"inline-more",
], default-features = false }
src/tools/rust-analyzer/crates/base-db/src/input.rs
+1
View File
@@ -257,6 +257,7 @@ fn expand(
) -> Result<Subtree, ProcMacroExpansionError>;
}
#[derive(Debug)]
pub enum ProcMacroExpansionError {
Panic(String),
/// Things like "proc macro server was killed by OOM".
src/tools/rust-analyzer/crates/base-db/src/lib.rs
+1 -1
View File
@@ -75,7 +75,7 @@ pub trait SourceDatabase: FileLoader + std::fmt::Debug {
#[salsa::input]
fn crate_graph(&self) -> Arc<CrateGraph>;
/// The crate graph.
/// The proc macros.
#[salsa::input]
fn proc_macros(&self) -> Arc<ProcMacros>;
}
src/tools/rust-analyzer/crates/flycheck/src/lib.rs
+5
View File
@@ -50,6 +50,7 @@ pub enum FlycheckConfig {
extra_args: Vec<String>,
extra_env: FxHashMap<String, String>,
ansi_color_output: bool,
target_dir: Option<PathBuf>,
},
CustomCommand {
command: String,
@@ -308,6 +309,7 @@ fn check_command(&self) -> Command {
features,
extra_env,
ansi_color_output,
target_dir,
} => {
let mut cmd = Command::new(toolchain::cargo());
cmd.arg(command);
@@ -340,6 +342,9 @@ fn check_command(&self) -> Command {
cmd.arg(features.join(" "));
}
}
if let Some(target_dir) = target_dir {
cmd.arg("--target-dir").arg(target_dir);
}
cmd.envs(extra_env);
(cmd, extra_args)
}
src/tools/rust-analyzer/crates/hir-def/Cargo.toml
+5 -5
View File
@@ -12,7 +12,6 @@ rust-version.workspace = true
doctest = false
[dependencies]
anymap = "1.0.0-beta.2"
arrayvec = "0.7.2"
bitflags = "2.1.0"
cov-mark = "2.0.0-pre.1"
@@ -31,10 +30,7 @@ smallvec.workspace = true
hashbrown.workspace = true
triomphe.workspace = true
rustc_abi.workspace = true
rustc_index.workspace = true
rustc_parse_format.workspace = true
rustc-dependencies.workspace = true
# local deps
stdx.workspace = true
@@ -48,8 +44,12 @@ cfg.workspace = true
tt.workspace = true
limit.workspace = true
[dev-dependencies]
expect-test = "1.4.0"
# local deps
test-utils.workspace = true
[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]
src/tools/rust-analyzer/crates/hir-def/src/attr.rs
+4
View File
@@ -215,6 +215,10 @@ pub fn doc_aliases(&self) -> impl Iterator<Item = SmolStr> + '_ {
self.doc_exprs().flat_map(|doc_expr| doc_expr.aliases().to_vec())
}
pub fn export_name(&self) -> Option<&SmolStr> {
self.by_key("export_name").string_value()
}
pub fn is_proc_macro(&self) -> bool {
self.by_key("proc_macro").exists()
}
src/tools/rust-analyzer/crates/hir-def/src/body.rs
+3 -3
View File
@@ -57,7 +57,7 @@ pub struct Body {
pub type ExprPtr = AstPtr<ast::Expr>;
pub type ExprSource = InFile<ExprPtr>;
pub type PatPtr = Either<AstPtr<ast::Pat>, AstPtr<ast::SelfParam>>;
pub type PatPtr = AstPtr<Either<ast::Pat, ast::SelfParam>>;
pub type PatSource = InFile<PatPtr>;
pub type LabelPtr = AstPtr<ast::Label>;
@@ -356,12 +356,12 @@ pub fn pat_syntax(&self, pat: PatId) -> Result<PatSource, SyntheticSyntax> {
}
pub fn node_pat(&self, node: InFile<&ast::Pat>) -> Option<PatId> {
let src = node.map(|it| Either::Left(AstPtr::new(it)));
let src = node.map(|it| AstPtr::new(it).wrap_left());
self.pat_map.get(&src).cloned()
}
pub fn node_self_param(&self, node: InFile<&ast::SelfParam>) -> Option<PatId> {
let src = node.map(|it| Either::Right(AstPtr::new(it)));
let src = node.map(|it| AstPtr::new(it).wrap_right());
self.pat_map.get(&src).cloned()
}
src/tools/rust-analyzer/crates/hir-def/src/body/lower.rs
+11 -15
View File
@@ -196,16 +196,12 @@ fn collect(
if let Some(self_param) =
param_list.self_param().filter(|_| attr_enabled.next().unwrap_or(false))
{
let ptr = AstPtr::new(&self_param);
let binding_id: la_arena::Idx<Binding> = self.alloc_binding(
name![self],
BindingAnnotation::new(
self_param.mut_token().is_some() && self_param.amp_token().is_none(),
false,
),
);
let param_pat =
self.alloc_pat(Pat::Bind { id: binding_id, subpat: None }, Either::Right(ptr));
let is_mutable =
self_param.mut_token().is_some() && self_param.amp_token().is_none();
let ptr = AstPtr::new(&Either::Right(self_param));
let binding_id: la_arena::Idx<Binding> =
self.alloc_binding(name![self], BindingAnnotation::new(is_mutable, false));
let param_pat = self.alloc_pat(Pat::Bind { id: binding_id, subpat: None }, ptr);
self.add_definition_to_binding(binding_id, param_pat);
self.body.params.push(param_pat);
}
@@ -1260,8 +1256,8 @@ fn collect_pat(&mut self, pat: ast::Pat, binding_list: &mut BindingList) -> PatI
(Some(id), Pat::Bind { id, subpat })
};
let ptr = AstPtr::new(&pat);
let pat = self.alloc_pat(pattern, Either::Left(ptr));
let ptr = AstPtr::new(&Either::Left(pat));
let pat = self.alloc_pat(pattern, ptr);
if let Some(binding_id) = binding {
self.add_definition_to_binding(binding_id, pat);
}
@@ -1395,7 +1391,7 @@ fn collect_pat(&mut self, pat: ast::Pat, binding_list: &mut BindingList) -> PatI
ast::Pat::MacroPat(mac) => match mac.macro_call() {
Some(call) => {
let macro_ptr = AstPtr::new(&call);
let src = self.expander.to_source(Either::Left(AstPtr::new(&pat)));
let src = self.expander.to_source(AstPtr::new(&Either::Left(pat)));
let pat =
self.collect_macro_call(call, macro_ptr, true, |this, expanded_pat| {
this.collect_pat_opt(expanded_pat, binding_list)
@@ -1430,8 +1426,8 @@ fn collect_pat(&mut self, pat: ast::Pat, binding_list: &mut BindingList) -> PatI
Pat::Range { start, end }
}
};
let ptr = AstPtr::new(&pat);
self.alloc_pat(pattern, Either::Left(ptr))
let ptr = AstPtr::new(&Either::Left(pat));
self.alloc_pat(pattern, ptr)
}
fn collect_pat_opt(&mut self, pat: Option<ast::Pat>, binding_list: &mut BindingList) -> PatId {
src/tools/rust-analyzer/crates/hir-def/src/body/scope.rs
+6 -10
View File
@@ -1,7 +1,6 @@
//! Name resolution for expressions.
use hir_expand::name::Name;
use la_arena::{Arena, Idx, IdxRange, RawIdx};
use rustc_hash::FxHashMap;
use la_arena::{Arena, ArenaMap, Idx, IdxRange, RawIdx};
use triomphe::Arc;
use crate::{
@@ -17,7 +16,7 @@
pub struct ExprScopes {
scopes: Arena<ScopeData>,
scope_entries: Arena<ScopeEntry>,
scope_by_expr: FxHashMap<ExprId, ScopeId>,
scope_by_expr: ArenaMap<ExprId, ScopeId>,
}
#[derive(Debug, PartialEq, Eq)]
@@ -77,10 +76,10 @@ pub fn resolve_name_in_scope(&self, scope: ScopeId, name: &Name) -> Option<&Scop
}
pub fn scope_for(&self, expr: ExprId) -> Option<ScopeId> {
self.scope_by_expr.get(&expr).copied()
self.scope_by_expr.get(expr).copied()
}
pub fn scope_by_expr(&self) -> &FxHashMap<ExprId, ScopeId> {
pub fn scope_by_expr(&self) -> &ArenaMap<ExprId, ScopeId> {
&self.scope_by_expr
}
}
@@ -94,7 +93,7 @@ fn new(body: &Body) -> ExprScopes {
let mut scopes = ExprScopes {
scopes: Arena::default(),
scope_entries: Arena::default(),
scope_by_expr: FxHashMap::default(),
scope_by_expr: ArenaMap::with_capacity(body.exprs.len()),
};
let mut root = scopes.root_scope();
scopes.add_params_bindings(body, root, &body.params);
@@ -476,10 +475,7 @@ fn do_check_local_name(ra_fixture: &str, expected_offset: u32) {
.pat_syntax(*body.bindings[resolved.binding()].definitions.first().unwrap())
.unwrap();
let local_name = pat_src.value.either(
|it| it.syntax_node_ptr().to_node(file.syntax()),
|it| it.syntax_node_ptr().to_node(file.syntax()),
);
let local_name = pat_src.value.syntax_node_ptr().to_node(file.syntax());
assert_eq!(local_name.text_range(), expected_name.syntax().text_range());
}
src/tools/rust-analyzer/crates/hir-def/src/data.rs
+3 -8
View File
@@ -15,9 +15,7 @@
attr::Attrs,
db::DefDatabase,
expander::{Expander, Mark},
item_tree::{
self, AssocItem, FnFlags, ItemTree, ItemTreeId, MacroCall, ModItem, Param, TreeId,
},
item_tree::{self, AssocItem, FnFlags, ItemTree, ItemTreeId, MacroCall, ModItem, TreeId},
macro_call_as_call_id, macro_id_to_def_id,
nameres::{
attr_resolution::ResolvedAttr,
@@ -69,7 +67,7 @@ pub(crate) fn fn_data_query(db: &dyn DefDatabase, func: FunctionId) -> Arc<Funct
let is_varargs = enabled_params
.clone()
.next_back()
.map_or(false, |param| matches!(item_tree[param], Param::Varargs));
.map_or(false, |param| item_tree[param].type_ref.is_none());
let mut flags = func.flags;
if is_varargs {
@@ -105,10 +103,7 @@ pub(crate) fn fn_data_query(db: &dyn DefDatabase, func: FunctionId) -> Arc<Funct
name: func.name.clone(),
params: enabled_params
.clone()
.filter_map(|id| match &item_tree[id] {
Param::Normal(ty) => Some(ty.clone()),
Param::Varargs => None,
})
.filter_map(|id| item_tree[id].type_ref.clone())
.collect(),
ret_type: func.ret_type.clone(),
attrs: item_tree.attrs(db, krate, ModItem::from(loc.id.value).into()),
src/tools/rust-analyzer/crates/hir-def/src/data/adt.rs
+1 -1
View File
@@ -11,7 +11,7 @@
};
use intern::Interned;
use la_arena::{Arena, ArenaMap};
use rustc_abi::{Align, Integer, IntegerType, ReprFlags, ReprOptions};
use rustc_dependencies::abi::{Align, Integer, IntegerType, ReprFlags, ReprOptions};
use syntax::ast::{self, HasName, HasVisibility};
use triomphe::Arc;
src/tools/rust-analyzer/crates/hir-def/src/dyn_map.rs
+1 -1
View File
@@ -29,8 +29,8 @@
ops::{Index, IndexMut},
};
use anymap::Map;
use rustc_hash::FxHashMap;
use stdx::anymap::Map;
pub struct Key<K, V, P = (K, V)> {
_phantom: PhantomData<(K, V, P)>,
src/tools/rust-analyzer/crates/hir-def/src/hir/format_args.rs
+1 -1
View File
@@ -2,7 +2,7 @@
use std::mem;
use hir_expand::name::Name;
use rustc_parse_format as parse;
use rustc_dependencies::parse_format as parse;
use syntax::{
ast::{self, IsString},
AstToken, SmolStr, TextRange,
src/tools/rust-analyzer/crates/hir-def/src/import_map.rs
+19 -7
View File
@@ -1,7 +1,6 @@
//! A map of all publicly exported items in a crate.
use std::collections::hash_map::Entry;
use std::{fmt, hash::BuildHasherDefault};
use std::{collections::hash_map::Entry, fmt, hash::BuildHasherDefault};
use base_db::CrateId;
use fst::{self, Streamer};
@@ -11,10 +10,12 @@
use rustc_hash::{FxHashMap, FxHashSet, FxHasher};
use triomphe::Arc;
use crate::item_scope::ImportOrExternCrate;
use crate::{
db::DefDatabase, item_scope::ItemInNs, nameres::DefMap, visibility::Visibility, AssocItemId,
ModuleDefId, ModuleId, TraitId,
db::DefDatabase,
item_scope::{ImportOrExternCrate, ItemInNs},
nameres::DefMap,
visibility::Visibility,
AssocItemId, ModuleDefId, ModuleId, TraitId,
};
type FxIndexMap<K, V> = IndexMap<K, V, BuildHasherDefault<FxHasher>>;
@@ -94,7 +95,7 @@ fn collect_import_map(db: &dyn DefDatabase, krate: CrateId) -> FxIndexMap<ItemIn
// We look only into modules that are public(ly reexported), starting with the crate root.
let root = def_map.module_id(DefMap::ROOT);
let mut worklist = vec![(root, 0)];
let mut worklist = vec![(root, 0u32)];
// Records items' minimum module depth.
let mut depth_map = FxHashMap::default();
@@ -278,6 +279,8 @@ enum SearchMode {
/// Import map entry should contain all letters from the query string,
/// in the same order, but not necessary adjacent.
Fuzzy,
/// Import map entry should match the query string by prefix.
Prefix,
}
/// Three possible ways to search for the name in associated and/or other items.
@@ -319,6 +322,14 @@ pub fn fuzzy(self) -> Self {
Self { search_mode: SearchMode::Fuzzy, ..self }
}
pub fn prefix(self) -> Self {
Self { search_mode: SearchMode::Prefix, ..self }
}
pub fn exact(self) -> Self {
Self { search_mode: SearchMode::Exact, ..self }
}
/// Specifies whether we want to include associated items in the result.
pub fn assoc_search_mode(self, assoc_mode: AssocSearchMode) -> Self {
Self { assoc_mode, ..self }
@@ -356,7 +367,8 @@ fn import_matches(
let query_string = if case_insensitive { &self.lowercased } else { &self.query };
match self.search_mode {
SearchMode::Exact => &input == query_string,
SearchMode::Exact => input == *query_string,
SearchMode::Prefix => input.starts_with(query_string),
SearchMode::Fuzzy => {
let mut input_chars = input.chars();
for query_char in query_string.chars() {
src/tools/rust-analyzer/crates/hir-def/src/item_tree.rs
+11 -4
View File
@@ -613,10 +613,17 @@ pub struct Function {
pub(crate) flags: FnFlags,
}
#[derive(Debug, Clone, Eq, PartialEq)]
pub enum Param {
Normal(Interned<TypeRef>),
Varargs,
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct Param {
/// This is [`None`] for varargs
pub type_ref: Option<Interned<TypeRef>>,
pub ast_id: ParamAstId,
}
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum ParamAstId {
Param(FileAstId<ast::Param>),
SelfParam(FileAstId<ast::SelfParam>),
}
bitflags::bitflags! {
src/tools/rust-analyzer/crates/hir-def/src/item_tree/lower.rs
+16 -4
View File
@@ -295,8 +295,12 @@ fn lower_function(&mut self, func: &ast::Fn) -> Option<FileItemTreeId<Function>>
}
}
};
let ty = Interned::new(self_type);
let idx = self.data().params.alloc(Param::Normal(ty));
let type_ref = Interned::new(self_type);
let ast_id = self.source_ast_id_map.ast_id(&self_param);
let idx = self.data().params.alloc(Param {
type_ref: Some(type_ref),
ast_id: ParamAstId::SelfParam(ast_id),
});
self.add_attrs(
idx.into(),
RawAttrs::new(self.db.upcast(), &self_param, self.hygiene()),
@@ -305,11 +309,19 @@ fn lower_function(&mut self, func: &ast::Fn) -> Option<FileItemTreeId<Function>>
}
for param in param_list.params() {
let idx = match param.dotdotdot_token() {
Some(_) => self.data().params.alloc(Param::Varargs),
Some(_) => {
let ast_id = self.source_ast_id_map.ast_id(&param);
self.data()
.params
.alloc(Param { type_ref: None, ast_id: ParamAstId::Param(ast_id) })
}
None => {
let type_ref = TypeRef::from_ast_opt(&self.body_ctx, param.ty());
let ty = Interned::new(type_ref);
self.data().params.alloc(Param::Normal(ty))
let ast_id = self.source_ast_id_map.ast_id(&param);
self.data()
.params
.alloc(Param { type_ref: Some(ty), ast_id: ParamAstId::Param(ast_id) })
}
};
self.add_attrs(idx.into(), RawAttrs::new(self.db.upcast(), &param, self.hygiene()));
src/tools/rust-analyzer/crates/hir-def/src/item_tree/pretty.rs
+3 -3
View File
@@ -261,15 +261,15 @@ fn print_mod_item(&mut self, item: ModItem) {
self.indented(|this| {
for param in params.clone() {
this.print_attrs_of(param, "\n");
match &this.tree[param] {
Param::Normal(ty) => {
match &this.tree[param].type_ref {
Some(ty) => {
if flags.contains(FnFlags::HAS_SELF_PARAM) {
w!(this, "self: ");
}
this.print_type_ref(ty);
wln!(this, ",");
}
Param::Varargs => {
None => {
wln!(this, "...");
}
};
src/tools/rust-analyzer/crates/hir-def/src/lib.rs
+16 -5
View File
@@ -8,6 +8,7 @@
//! actually true.
#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#[allow(unused)]
macro_rules! eprintln {
@@ -48,7 +49,7 @@ macro_rules! eprintln {
pub mod find_path;
pub mod import_map;
pub use rustc_abi as layout;
pub use rustc_dependencies::abi as layout;
use triomphe::Arc;
#[cfg(test)]
@@ -72,6 +73,7 @@ macro_rules! eprintln {
db::ExpandDatabase,
eager::expand_eager_macro_input,
hygiene::Hygiene,
name::Name,
proc_macro::ProcMacroExpander,
AstId, ExpandError, ExpandResult, ExpandTo, HirFileId, InFile, MacroCallId, MacroCallKind,
MacroDefId, MacroDefKind, UnresolvedMacro,
@@ -173,6 +175,18 @@ pub fn krate(self) -> CrateId {
self.krate
}
pub fn name(self, db: &dyn db::DefDatabase) -> Option<Name> {
let def_map = self.def_map(db);
let parent = def_map[self.local_id].parent?;
def_map[parent].children.iter().find_map(|(name, module_id)| {
if *module_id == self.local_id {
Some(name.clone())
} else {
None
}
})
}
pub fn containing_module(self, db: &dyn db::DefDatabase) -> Option<ModuleId> {
self.def_map(db).containing_module(self.local_id)
}
@@ -498,10 +512,7 @@ pub enum MacroId {
impl MacroId {
pub fn is_attribute(self, db: &dyn db::DefDatabase) -> bool {
match self {
MacroId::ProcMacroId(it) => it.lookup(db).kind == ProcMacroKind::Attr,
_ => false,
}
matches!(self, MacroId::ProcMacroId(it) if it.lookup(db).kind == ProcMacroKind::Attr)
}
}
src/tools/rust-analyzer/crates/hir-expand/src/ast_id_map.rs
+1 -1
View File
@@ -99,7 +99,7 @@ impl AstIdNode for
TraitAlias,
TypeAlias,
Use,
AssocItem, BlockExpr, Variant, RecordField, TupleField, ConstArg
AssocItem, BlockExpr, Variant, RecordField, TupleField, ConstArg, Param, SelfParam
}
/// Maps items' `SyntaxNode`s to `ErasedFileAstId`s and back.
src/tools/rust-analyzer/crates/hir-expand/src/db.rs
+28 -8
View File
@@ -12,11 +12,15 @@
use triomphe::Arc;
use crate::{
ast_id_map::AstIdMap, builtin_attr_macro::pseudo_derive_attr_expansion,
builtin_fn_macro::EagerExpander, fixup, hygiene::HygieneFrame, tt, AstId, BuiltinAttrExpander,
BuiltinDeriveExpander, BuiltinFnLikeExpander, EagerCallInfo, ExpandError, ExpandResult,
ExpandTo, HirFileId, HirFileIdRepr, MacroCallId, MacroCallKind, MacroCallLoc, MacroDefId,
MacroDefKind, MacroFile, ProcMacroExpander,
ast_id_map::AstIdMap,
builtin_attr_macro::pseudo_derive_attr_expansion,
builtin_fn_macro::EagerExpander,
fixup,
hygiene::HygieneFrame,
name::{name, AsName},
tt, AstId, BuiltinAttrExpander, BuiltinDeriveExpander, BuiltinFnLikeExpander, EagerCallInfo,
ExpandError, ExpandResult, ExpandTo, HirFileId, HirFileIdRepr, MacroCallId, MacroCallKind,
MacroCallLoc, MacroDefId, MacroDefKind, MacroFile, ProcMacroExpander,
};
/// Total limit on the number of tokens produced by any macro invocation.
@@ -614,9 +618,25 @@ fn macro_expand(db: &dyn ExpandDatabase, id: MacroCallId) -> ExpandResult<Arc<tt
err = error.clone().or(err);
}
// Set a hard limit for the expanded tt
if let Err(value) = check_tt_count(&tt) {
return value;
// Skip checking token tree limit for include! macro call
let skip_check_tt_count = match loc.kind {
MacroCallKind::FnLike { ast_id, expand_to: _ } => {
if let Some(name_ref) =
ast_id.to_node(db).path().and_then(|p| p.segment()).and_then(|s| s.name_ref())
{
name_ref.as_name() == name!(include)
} else {
false
}
}
_ => false,
};
if !skip_check_tt_count {
// Set a hard limit for the expanded tt
if let Err(value) = check_tt_count(&tt) {
return value;
}
}
ExpandResult { value: Arc::new(tt), err }
src/tools/rust-analyzer/crates/hir-ty/Cargo.toml
+8 -5
View File
@@ -23,17 +23,17 @@ oorandom = "11.1.3"
tracing = "0.1.35"
rustc-hash = "1.1.0"
scoped-tls = "1.0.0"
chalk-solve = { version = "0.92.0", default-features = false }
chalk-ir = "0.92.0"
chalk-recursive = { version = "0.92.0", default-features = false }
chalk-derive = "0.92.0"
chalk-solve = { version = "0.93.0", default-features = false }
chalk-ir = "0.93.0"
chalk-recursive = { version = "0.93.0", default-features = false }
chalk-derive = "0.93.0"
la-arena.workspace = true
once_cell = "1.17.0"
triomphe.workspace = true
nohash-hasher.workspace = true
typed-arena = "2.0.1"
rustc_index.workspace = true
rustc-dependencies.workspace = true
# local deps
stdx.workspace = true
@@ -56,3 +56,6 @@ project-model = { path = "../project-model" }
# local deps
test-utils.workspace = true
[features]
in-rust-tree = ["rustc-dependencies/in-rust-tree"]
src/tools/rust-analyzer/crates/hir-ty/src/consteval/tests.rs
+14
View File
@@ -1159,6 +1159,20 @@ const fn f(x: &[usize]) -> usize {
"#,
33213,
);
check_number(
r#"
//- minicore: slice, index, coerce_unsized, copy
const fn f(mut slice: &[u32]) -> usize {
slice = match slice {
[0, rest @ ..] | rest => rest,
};
slice.len()
}
const GOAL: usize = f(&[]) + f(&[10]) + f(&[0, 100])
+ f(&[1000, 1000, 1000]) + f(&[0, 57, 34, 46, 10000, 10000]);
"#,
10,
);
}
#[test]
src/tools/rust-analyzer/crates/hir-ty/src/diagnostics/decl_check.rs
+88 -39
View File
@@ -9,6 +9,7 @@
//! - constants (e.g. `const FOO: u8 = 10;`)
//! - static items (e.g. `static FOO: u8 = 10;`)
//! - match arm bindings (e.g. `foo @ Some(_)`)
//! - modules (e.g. `mod foo { ... }` or `mod foo;`)
mod case_conv;
@@ -19,7 +20,7 @@
hir::{Pat, PatId},
src::HasSource,
AdtId, AttrDefId, ConstId, DefWithBodyId, EnumId, EnumVariantId, FunctionId, ItemContainerId,
Lookup, ModuleDefId, StaticId, StructId,
Lookup, ModuleDefId, ModuleId, StaticId, StructId,
};
use hir_expand::{
name::{AsName, Name},
@@ -83,6 +84,7 @@ pub enum IdentType {
Structure,
Variable,
Variant,
Module,
}
impl fmt::Display for IdentType {
@@ -97,6 +99,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
IdentType::Structure => "Structure",
IdentType::Variable => "Variable",
IdentType::Variant => "Variant",
IdentType::Module => "Module",
};
repr.fmt(f)
@@ -132,6 +135,7 @@ pub(super) fn new(db: &'a dyn HirDatabase) -> DeclValidator<'a> {
pub(super) fn validate_item(&mut self, item: ModuleDefId) {
match item {
ModuleDefId::ModuleId(module_id) => self.validate_module(module_id),
ModuleDefId::FunctionId(func) => self.validate_func(func),
ModuleDefId::AdtId(adt) => self.validate_adt(adt),
ModuleDefId::ConstId(const_id) => self.validate_const(const_id),
@@ -230,6 +234,55 @@ fn allowed(&self, id: AttrDefId, allow_name: &str, recursing: bool) -> bool {
|| parent()
}
fn validate_module(&mut self, module_id: ModuleId) {
// Check whether non-snake case identifiers are allowed for this module.
if self.allowed(module_id.into(), allow::NON_SNAKE_CASE, false) {
return;
}
// Check the module name.
let Some(module_name) = module_id.name(self.db.upcast()) else { return };
let module_name_replacement =
module_name.as_str().and_then(to_lower_snake_case).map(|new_name| Replacement {
current_name: module_name,
suggested_text: new_name,
expected_case: CaseType::LowerSnakeCase,
});
if let Some(module_name_replacement) = module_name_replacement {
let module_data = &module_id.def_map(self.db.upcast())[module_id.local_id];
let module_src = module_data.declaration_source(self.db.upcast());
if let Some(module_src) = module_src {
let ast_ptr = match module_src.value.name() {
Some(name) => name,
None => {
never!(
"Replacement ({:?}) was generated for a module without a name: {:?}",
module_name_replacement,
module_src
);
return;
}
};
let diagnostic = IncorrectCase {
file: module_src.file_id,
ident_type: IdentType::Module,
ident: AstPtr::new(&ast_ptr),
expected_case: module_name_replacement.expected_case,
ident_text: module_name_replacement
.current_name
.display(self.db.upcast())
.to_string(),
suggested_text: module_name_replacement.suggested_text,
};
self.sink.push(diagnostic);
}
}
}
fn validate_func(&mut self, func: FunctionId) {
let data = self.db.function_data(func);
if matches!(func.lookup(self.db.upcast()).container, ItemContainerId::ExternBlockId(_)) {
@@ -336,48 +389,44 @@ fn create_incorrect_case_diagnostic_for_variables(
for (id, replacement) in pats_replacements {
if let Ok(source_ptr) = source_map.pat_syntax(id) {
if let Some(expr) = source_ptr.value.as_ref().left() {
if let Some(ptr) = source_ptr.value.clone().cast::<ast::IdentPat>() {
let root = source_ptr.file_syntax(self.db.upcast());
if let ast::Pat::IdentPat(ident_pat) = expr.to_node(&root) {
let parent = match ident_pat.syntax().parent() {
Some(parent) => parent,
None => continue,
};
let name_ast = match ident_pat.name() {
Some(name_ast) => name_ast,
None => continue,
};
let ident_pat = ptr.to_node(&root);
let parent = match ident_pat.syntax().parent() {
Some(parent) => parent,
None => continue,
};
let name_ast = match ident_pat.name() {
Some(name_ast) => name_ast,
None => continue,
};
let is_param = ast::Param::can_cast(parent.kind());
let is_param = ast::Param::can_cast(parent.kind());
// We have to check that it's either `let var = ...` or `var @ Variant(_)` statement,
// because e.g. match arms are patterns as well.
// In other words, we check that it's a named variable binding.
let is_binding = ast::LetStmt::can_cast(parent.kind())
|| (ast::MatchArm::can_cast(parent.kind())
&& ident_pat.at_token().is_some());
if !(is_param || is_binding) {
// This pattern is not an actual variable declaration, e.g. `Some(val) => {..}` match arm.
continue;
}
let ident_type =
if is_param { IdentType::Parameter } else { IdentType::Variable };
let diagnostic = IncorrectCase {
file: source_ptr.file_id,
ident_type,
ident: AstPtr::new(&name_ast),
expected_case: replacement.expected_case,
ident_text: replacement
.current_name
.display(self.db.upcast())
.to_string(),
suggested_text: replacement.suggested_text,
};
self.sink.push(diagnostic);
// We have to check that it's either `let var = ...` or `var @ Variant(_)` statement,
// because e.g. match arms are patterns as well.
// In other words, we check that it's a named variable binding.
let is_binding = ast::LetStmt::can_cast(parent.kind())
|| (ast::MatchArm::can_cast(parent.kind())
&& ident_pat.at_token().is_some());
if !(is_param || is_binding) {
// This pattern is not an actual variable declaration, e.g. `Some(val) => {..}` match arm.
continue;
}
let ident_type =
if is_param { IdentType::Parameter } else { IdentType::Variable };
let diagnostic = IncorrectCase {
file: source_ptr.file_id,
ident_type,
ident: AstPtr::new(&name_ast),
expected_case: replacement.expected_case,
ident_text: replacement.current_name.display(self.db.upcast()).to_string(),
suggested_text: replacement.suggested_text,
};
self.sink.push(diagnostic);
}
}
}
src/tools/rust-analyzer/crates/hir-ty/src/diagnostics/decl_check/case_conv.rs
+4 -50
View File
@@ -11,50 +11,7 @@ pub(crate) fn to_camel_case(ident: &str) -> Option<String> {
return None;
}
// Taken from rustc.
let ret = ident
.trim_matches('_')
.split('_')
.filter(|component| !component.is_empty())
.map(|component| {
let mut camel_cased_component = String::with_capacity(component.len());
let mut new_word = true;
let mut prev_is_lower_case = true;
for c in component.chars() {
// Preserve the case if an uppercase letter follows a lowercase letter, so that
// `camelCase` is converted to `CamelCase`.
if prev_is_lower_case && c.is_uppercase() {
new_word = true;
}
if new_word {
camel_cased_component.extend(c.to_uppercase());
} else {
camel_cased_component.extend(c.to_lowercase());
}
prev_is_lower_case = c.is_lowercase();
new_word = false;
}
camel_cased_component
})
.fold((String::new(), None), |(acc, prev): (_, Option<String>), next| {
// separate two components with an underscore if their boundary cannot
// be distinguished using an uppercase/lowercase case distinction
let join = prev
.and_then(|prev| {
let f = next.chars().next()?;
let l = prev.chars().last()?;
Some(!char_has_case(l) && !char_has_case(f))
})
.unwrap_or(false);
(acc + if join { "_" } else { "" } + &next, Some(next))
})
.0;
Some(ret)
Some(stdx::to_camel_case(ident))
}
/// Converts an identifier to a lower_snake_case form.
@@ -97,7 +54,9 @@ fn is_camel_case(name: &str) -> bool {
&& !name.chars().any(|snd| {
let ret = match fst {
None => false,
Some(fst) => char_has_case(fst) && snd == '_' || char_has_case(snd) && fst == '_',
Some(fst) => {
stdx::char_has_case(fst) && snd == '_' || stdx::char_has_case(snd) && fst == '_'
}
};
fst = Some(snd);
@@ -135,11 +94,6 @@ fn is_snake_case<F: Fn(char) -> bool>(ident: &str, wrong_case: F) -> bool {
})
}
// Taken from rustc.
fn char_has_case(c: char) -> bool {
c.is_lowercase() || c.is_uppercase()
}
#[cfg(test)]
mod tests {
use super::*;
src/tools/rust-analyzer/crates/hir-ty/src/diagnostics/match_check.rs
+1 -1
View File
@@ -147,7 +147,7 @@ fn lower_pattern_unadjusted(&mut self, pat: PatId) -> Pat {
}
hir_def::hir::Pat::Bind { id, subpat, .. } => {
let bm = self.infer.binding_modes[id];
let bm = self.infer.binding_modes[pat];
ty = &self.infer[id];
let name = &self.body.bindings[id].name;
match (bm, ty.kind(Interner)) {
src/tools/rust-analyzer/crates/hir-ty/src/infer.rs
+13 -1
View File
@@ -420,7 +420,19 @@ pub struct InferenceResult {
standard_types: InternedStandardTypes,
/// Stores the types which were implicitly dereferenced in pattern binding modes.
pub pat_adjustments: FxHashMap<PatId, Vec<Ty>>,
pub binding_modes: ArenaMap<BindingId, BindingMode>,
/// Stores the binding mode (`ref` in `let ref x = 2`) of bindings.
///
/// This one is tied to the `PatId` instead of `BindingId`, because in some rare cases, a binding in an
/// or pattern can have multiple binding modes. For example:
/// ```
/// fn foo(mut slice: &[u32]) -> usize {
/// slice = match slice {
/// [0, rest @ ..] | rest => rest,
/// };
/// }
/// ```
/// the first `rest` has implicit `ref` binding mode, but the second `rest` binding mode is `move`.
pub binding_modes: ArenaMap<PatId, BindingMode>,
pub expr_adjustments: FxHashMap<ExprId, Vec<Adjustment>>,
pub(crate) closure_info: FxHashMap<ClosureId, (Vec<CapturedItem>, FnTrait)>,
// FIXME: remove this field
src/tools/rust-analyzer/crates/hir-ty/src/infer/closure.rs
+3 -3
View File
@@ -679,7 +679,7 @@ fn walk_pat_inner(
| Pat::Range { .. } => {
update_result(CaptureKind::ByRef(BorrowKind::Shared));
}
Pat::Bind { id, .. } => match self.result.binding_modes[*id] {
Pat::Bind { id, .. } => match self.result.binding_modes[p] {
crate::BindingMode::Move => {
if self.is_ty_copy(self.result.type_of_binding[*id].clone()) {
update_result(CaptureKind::ByRef(BorrowKind::Shared));
@@ -838,8 +838,8 @@ fn consume_with_pat(&mut self, mut place: HirPlace, pat: PatId) {
| Pat::ConstBlock(_)
| Pat::Path(_)
| Pat::Lit(_) => self.consume_place(place, pat.into()),
Pat::Bind { id, subpat: _ } => {
let mode = self.result.binding_modes[*id];
Pat::Bind { id: _, subpat: _ } => {
let mode = self.result.binding_modes[pat];
let capture_kind = match mode {
BindingMode::Move => {
self.consume_place(place, pat.into());
src/tools/rust-analyzer/crates/hir-ty/src/infer/pat.rs
+1 -1
View File
@@ -421,7 +421,7 @@ fn infer_bind_pat(
} else {
BindingMode::convert(mode)
};
self.result.binding_modes.insert(binding, mode);
self.result.binding_modes.insert(pat, mode);
let inner_ty = match subpat {
Some(subpat) => self.infer_pat(subpat, &expected, default_bm),
src/tools/rust-analyzer/crates/hir-ty/src/layout.rs
+51 -27
View File
@@ -9,6 +9,10 @@
LocalEnumVariantId, LocalFieldId, StructId,
};
use la_arena::{Idx, RawIdx};
use rustc_dependencies::{
abi::AddressSpace,
index::{IndexSlice, IndexVec},
};
use stdx::never;
use triomphe::Arc;
@@ -34,7 +38,7 @@ macro_rules! user_error {
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct RustcEnumVariantIdx(pub LocalEnumVariantId);
impl rustc_index::vec::Idx for RustcEnumVariantIdx {
impl rustc_dependencies::index::Idx for RustcEnumVariantIdx {
fn new(idx: usize) -> Self {
RustcEnumVariantIdx(Idx::from_raw(RawIdx::from(idx as u32)))
}
@@ -44,9 +48,28 @@ fn index(self) -> usize {
}
}
pub type Layout = LayoutS<RustcEnumVariantIdx>;
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct RustcFieldIdx(pub LocalFieldId);
impl RustcFieldIdx {
pub fn new(idx: usize) -> Self {
RustcFieldIdx(Idx::from_raw(RawIdx::from(idx as u32)))
}
}
impl rustc_dependencies::index::Idx for RustcFieldIdx {
fn new(idx: usize) -> Self {
RustcFieldIdx(Idx::from_raw(RawIdx::from(idx as u32)))
}
fn index(self) -> usize {
u32::from(self.0.into_raw()) as usize
}
}
pub type Layout = LayoutS<RustcFieldIdx, RustcEnumVariantIdx>;
pub type TagEncoding = hir_def::layout::TagEncoding<RustcEnumVariantIdx>;
pub type Variants = hir_def::layout::Variants<RustcEnumVariantIdx>;
pub type Variants = hir_def::layout::Variants<RustcFieldIdx, RustcEnumVariantIdx>;
#[derive(Debug, PartialEq, Eq, Clone)]
pub enum LayoutError {
@@ -66,7 +89,7 @@ struct LayoutCx<'a> {
impl<'a> LayoutCalculator for LayoutCx<'a> {
type TargetDataLayoutRef = &'a TargetDataLayout;
fn delay_bug(&self, txt: &str) {
fn delay_bug(&self, txt: String) {
never!("{}", txt);
}
@@ -145,6 +168,8 @@ fn layout_of_simd_ty(
largest_niche: e_ly.largest_niche,
size,
align,
max_repr_align: None,
unadjusted_abi_align: align.abi,
}))
}
@@ -230,7 +255,7 @@ pub fn layout_of_ty_query(
.map(|k| db.layout_of_ty(k.assert_ty_ref(Interner).clone(), trait_env.clone()))
.collect::<Result<Vec<_>, _>>()?;
let fields = fields.iter().map(|it| &**it).collect::<Vec<_>>();
let fields = fields.iter().collect::<Vec<_>>();
let fields = fields.iter().collect::<IndexVec<_, _>>();
cx.univariant(dl, &fields, &ReprOptions::default(), kind).ok_or(LayoutError::Unknown)?
}
TyKind::Array(element, count) => {
@@ -255,6 +280,8 @@ pub fn layout_of_ty_query(
largest_niche,
align: element.align,
size,
max_repr_align: None,
unadjusted_abi_align: element.align.abi,
}
}
TyKind::Slice(element) => {
@@ -266,11 +293,23 @@ pub fn layout_of_ty_query(
largest_niche: None,
align: element.align,
size: Size::ZERO,
max_repr_align: None,
unadjusted_abi_align: element.align.abi,
}
}
TyKind::Str => Layout {
variants: Variants::Single { index: struct_variant_idx() },
fields: FieldsShape::Array { stride: Size::from_bytes(1), count: 0 },
abi: Abi::Aggregate { sized: false },
largest_niche: None,
align: dl.i8_align,
size: Size::ZERO,
max_repr_align: None,
unadjusted_abi_align: dl.i8_align.abi,
},
// Potentially-wide pointers.
TyKind::Ref(_, _, pointee) | TyKind::Raw(_, pointee) => {
let mut data_ptr = scalar_unit(dl, Primitive::Pointer);
let mut data_ptr = scalar_unit(dl, Primitive::Pointer(AddressSpace::DATA));
if matches!(ty.kind(Interner), TyKind::Ref(..)) {
data_ptr.valid_range_mut().start = 1;
}
@@ -294,7 +333,7 @@ pub fn layout_of_ty_query(
scalar_unit(dl, Primitive::Int(dl.ptr_sized_integer(), false))
}
TyKind::Dyn(..) => {
let mut vtable = scalar_unit(dl, Primitive::Pointer);
let mut vtable = scalar_unit(dl, Primitive::Pointer(AddressSpace::DATA));
vtable.valid_range_mut().start = 1;
vtable
}
@@ -308,22 +347,7 @@ pub fn layout_of_ty_query(
cx.scalar_pair(data_ptr, metadata)
}
TyKind::FnDef(_, _) => layout_of_unit(&cx, dl)?,
TyKind::Str => Layout {
variants: Variants::Single { index: struct_variant_idx() },
fields: FieldsShape::Array { stride: Size::from_bytes(1), count: 0 },
abi: Abi::Aggregate { sized: false },
largest_niche: None,
align: dl.i8_align,
size: Size::ZERO,
},
TyKind::Never => Layout {
variants: Variants::Single { index: struct_variant_idx() },
fields: FieldsShape::Primitive,
abi: Abi::Uninhabited,
largest_niche: None,
align: dl.i8_align,
size: Size::ZERO,
},
TyKind::Never => cx.layout_of_never_type(),
TyKind::Dyn(_) | TyKind::Foreign(_) => {
let mut unit = layout_of_unit(&cx, dl)?;
match unit.abi {
@@ -333,7 +357,7 @@ pub fn layout_of_ty_query(
unit
}
TyKind::Function(_) => {
let mut ptr = scalar_unit(dl, Primitive::Pointer);
let mut ptr = scalar_unit(dl, Primitive::Pointer(dl.instruction_address_space));
ptr.valid_range_mut().start = 1;
Layout::scalar(dl, ptr)
}
@@ -363,7 +387,7 @@ pub fn layout_of_ty_query(
})
.collect::<Result<Vec<_>, _>>()?;
let fields = fields.iter().map(|it| &**it).collect::<Vec<_>>();
let fields = fields.iter().collect::<Vec<_>>();
let fields = fields.iter().collect::<IndexVec<_, _>>();
cx.univariant(dl, &fields, &ReprOptions::default(), StructKind::AlwaysSized)
.ok_or(LayoutError::Unknown)?
}
@@ -398,9 +422,9 @@ pub fn layout_of_ty_recover(
}
fn layout_of_unit(cx: &LayoutCx<'_>, dl: &TargetDataLayout) -> Result<Layout, LayoutError> {
cx.univariant::<RustcEnumVariantIdx, &&Layout>(
cx.univariant::<RustcFieldIdx, RustcEnumVariantIdx, &&Layout>(
dl,
&[],
IndexSlice::empty(),
&ReprOptions::default(),
StructKind::AlwaysSized,
)
src/tools/rust-analyzer/crates/hir-ty/src/layout/adt.rs
+14 -5
View File
@@ -8,6 +8,7 @@
AdtId, EnumVariantId, LocalEnumVariantId, VariantId,
};
use la_arena::RawIdx;
use rustc_dependencies::index::IndexVec;
use smallvec::SmallVec;
use triomphe::Arc;
@@ -20,8 +21,8 @@
use super::LayoutCx;
pub(crate) fn struct_variant_idx() -> RustcEnumVariantIdx {
RustcEnumVariantIdx(LocalEnumVariantId::from_raw(RawIdx::from(0)))
pub(crate) const fn struct_variant_idx() -> RustcEnumVariantIdx {
RustcEnumVariantIdx(LocalEnumVariantId::from_raw(RawIdx::from_u32(0)))
}
pub fn layout_of_adt_query(
@@ -74,7 +75,7 @@ pub fn layout_of_adt_query(
.iter()
.map(|it| it.iter().map(|it| &**it).collect::<Vec<_>>())
.collect::<SmallVec<[_; 1]>>();
let variants = variants.iter().map(|it| it.iter().collect()).collect();
let variants = variants.iter().map(|it| it.iter().collect()).collect::<IndexVec<_, _>>();
let result = if matches!(def, AdtId::UnionId(..)) {
cx.layout_of_union(&repr, &variants).ok_or(LayoutError::Unknown)?
} else {
@@ -105,7 +106,7 @@ pub fn layout_of_adt_query(
&& variants
.iter()
.next()
.and_then(|it| it.last().map(|it| !it.is_unsized()))
.and_then(|it| it.iter().last().map(|it| !it.is_unsized()))
.unwrap_or(true),
)
.ok_or(LayoutError::SizeOverflow)?
@@ -119,7 +120,15 @@ fn layout_scalar_valid_range(db: &dyn HirDatabase, def: AdtId) -> (Bound<u128>,
let attr = attrs.by_key(name).tt_values();
for tree in attr {
if let Some(it) = tree.token_trees.first() {
if let Ok(it) = it.to_string().parse() {
let text = it.to_string().replace('_', "");
let (text, base) = match text.as_bytes() {
[b'0', b'x', ..] => (&text[2..], 16),
[b'0', b'o', ..] => (&text[2..], 8),
[b'0', b'b', ..] => (&text[2..], 2),
_ => (&*text, 10),
};
if let Ok(it) = u128::from_str_radix(text, base) {
return Bound::Included(it);
}
}
src/tools/rust-analyzer/crates/hir-ty/src/layout/tests/closure.rs
+2 -2
View File
@@ -186,9 +186,9 @@ fn capture_specific_fields() {
fn match_pattern() {
size_and_align_expr! {
struct X(i64, i32, (u8, i128));
let y: X = X(2, 5, (7, 3));
let _y: X = X(2, 5, (7, 3));
move |x: i64| {
match y {
match _y {
_ => x,
}
}
src/tools/rust-analyzer/crates/hir-ty/src/lib.rs
+1
View File
@@ -1,6 +1,7 @@
//! The type system. We currently use this to infer types for completion, hover
//! information and various assists.
#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#[allow(unused)]
macro_rules! eprintln {
src/tools/rust-analyzer/crates/hir-ty/src/mir.rs
+11 -9
View File
@@ -243,16 +243,16 @@ fn default() -> Self {
}
impl ProjectionStore {
fn shrink_to_fit(&mut self) {
pub fn shrink_to_fit(&mut self) {
self.id_to_proj.shrink_to_fit();
self.proj_to_id.shrink_to_fit();
}
fn intern_if_exist(&self, projection: &[PlaceElem]) -> Option<ProjectionId> {
pub fn intern_if_exist(&self, projection: &[PlaceElem]) -> Option<ProjectionId> {
self.proj_to_id.get(projection).copied()
}
fn intern(&mut self, projection: Box<[PlaceElem]>) -> ProjectionId {
pub fn intern(&mut self, projection: Box<[PlaceElem]>) -> ProjectionId {
let new_id = ProjectionId(self.proj_to_id.len() as u32);
match self.proj_to_id.entry(projection) {
Entry::Occupied(id) => *id.get(),
@@ -267,20 +267,20 @@ fn intern(&mut self, projection: Box<[PlaceElem]>) -> ProjectionId {
}
impl ProjectionId {
const EMPTY: ProjectionId = ProjectionId(0);
pub const EMPTY: ProjectionId = ProjectionId(0);
fn lookup(self, store: &ProjectionStore) -> &[PlaceElem] {
pub fn lookup(self, store: &ProjectionStore) -> &[PlaceElem] {
store.id_to_proj.get(&self).unwrap()
}
fn project(self, projection: PlaceElem, store: &mut ProjectionStore) -> ProjectionId {
pub fn project(self, projection: PlaceElem, store: &mut ProjectionStore) -> ProjectionId {
let mut current = self.lookup(store).to_vec();
current.push(projection);
store.intern(current.into())
}
}
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct Place {
pub local: LocalId,
pub projection: ProjectionId,
@@ -1007,7 +1007,7 @@ pub enum Rvalue {
#[derive(Debug, PartialEq, Eq, Clone)]
pub enum StatementKind {
Assign(Place, Rvalue),
//FakeRead(Box<(FakeReadCause, Place)>),
FakeRead(Place),
//SetDiscriminant {
// place: Box<Place>,
// variant_index: VariantIdx,
@@ -1109,7 +1109,9 @@ fn for_operand(
}
}
}
StatementKind::Deinit(p) => f(p, &mut self.projection_store),
StatementKind::FakeRead(p) | StatementKind::Deinit(p) => {
f(p, &mut self.projection_store)
}
StatementKind::StorageLive(_)
| StatementKind::StorageDead(_)
| StatementKind::Nop => (),
src/tools/rust-analyzer/crates/hir-ty/src/mir/borrowck.rs
+74 -14
View File
@@ -24,6 +24,7 @@
pub enum MutabilityReason {
Mut { spans: Vec<MirSpan> },
Not,
Unused,
}
#[derive(Debug, Clone, PartialEq, Eq)]
@@ -144,7 +145,8 @@ fn moved_out_of_ref(db: &dyn HirDatabase, body: &MirBody) -> Vec<MovedOutOfRef>
}
}
},
StatementKind::Deinit(_)
StatementKind::FakeRead(_)
| StatementKind::Deinit(_)
| StatementKind::StorageLive(_)
| StatementKind::StorageDead(_)
| StatementKind::Nop => (),
@@ -264,7 +266,10 @@ fn dfs(
is_ever_initialized = false;
}
}
StatementKind::Deinit(_) | StatementKind::Nop | StatementKind::StorageLive(_) => (),
StatementKind::Deinit(_)
| StatementKind::FakeRead(_)
| StatementKind::Nop
| StatementKind::StorageLive(_) => (),
}
}
let Some(terminator) = &block.terminator else {
@@ -331,16 +336,37 @@ fn dfs(
result
}
fn push_mut_span(local: LocalId, span: MirSpan, result: &mut ArenaMap<LocalId, MutabilityReason>) {
match &mut result[local] {
MutabilityReason::Mut { spans } => spans.push(span),
it @ (MutabilityReason::Not | MutabilityReason::Unused) => {
*it = MutabilityReason::Mut { spans: vec![span] }
}
};
}
fn record_usage(local: LocalId, result: &mut ArenaMap<LocalId, MutabilityReason>) {
match &mut result[local] {
it @ MutabilityReason::Unused => {
*it = MutabilityReason::Not;
}
_ => (),
};
}
fn record_usage_for_operand(arg: &Operand, result: &mut ArenaMap<LocalId, MutabilityReason>) {
if let Operand::Copy(p) | Operand::Move(p) = arg {
record_usage(p.local, result);
}
}
fn mutability_of_locals(
db: &dyn HirDatabase,
body: &MirBody,
) -> ArenaMap<LocalId, MutabilityReason> {
let mut result: ArenaMap<LocalId, MutabilityReason> =
body.locals.iter().map(|it| (it.0, MutabilityReason::Not)).collect();
let mut push_mut_span = |local, span| match &mut result[local] {
MutabilityReason::Mut { spans } => spans.push(span),
it @ MutabilityReason::Not => *it = MutabilityReason::Mut { spans: vec![span] },
};
body.locals.iter().map(|it| (it.0, MutabilityReason::Unused)).collect();
let ever_init_maps = ever_initialized_map(db, body);
for (block_id, mut ever_init_map) in ever_init_maps.into_iter() {
let block = &body.basic_blocks[block_id];
@@ -350,23 +376,51 @@ fn mutability_of_locals(
match place_case(db, body, place) {
ProjectionCase::Direct => {
if ever_init_map.get(place.local).copied().unwrap_or_default() {
push_mut_span(place.local, statement.span);
push_mut_span(place.local, statement.span, &mut result);
} else {
ever_init_map.insert(place.local, true);
}
}
ProjectionCase::DirectPart => {
// Partial initialization is not supported, so it is definitely `mut`
push_mut_span(place.local, statement.span);
push_mut_span(place.local, statement.span, &mut result);
}
ProjectionCase::Indirect => (),
ProjectionCase::Indirect => {
record_usage(place.local, &mut result);
}
}
match value {
Rvalue::CopyForDeref(p)
| Rvalue::Discriminant(p)
| Rvalue::Len(p)
| Rvalue::Ref(_, p) => {
record_usage(p.local, &mut result);
}
Rvalue::Use(o)
| Rvalue::Repeat(o, _)
| Rvalue::Cast(_, o, _)
| Rvalue::UnaryOp(_, o) => record_usage_for_operand(o, &mut result),
Rvalue::CheckedBinaryOp(_, o1, o2) => {
for o in [o1, o2] {
record_usage_for_operand(o, &mut result);
}
}
Rvalue::Aggregate(_, args) => {
for arg in args.iter() {
record_usage_for_operand(arg, &mut result);
}
}
Rvalue::ShallowInitBox(_, _) | Rvalue::ShallowInitBoxWithAlloc(_) => (),
}
if let Rvalue::Ref(BorrowKind::Mut { .. }, p) = value {
if place_case(db, body, p) != ProjectionCase::Indirect {
push_mut_span(p.local, statement.span);
push_mut_span(p.local, statement.span, &mut result);
}
}
}
StatementKind::FakeRead(p) => {
record_usage(p.local, &mut result);
}
StatementKind::StorageDead(p) => {
ever_init_map.insert(*p, false);
}
@@ -386,15 +440,21 @@ fn mutability_of_locals(
| TerminatorKind::FalseEdge { .. }
| TerminatorKind::FalseUnwind { .. }
| TerminatorKind::GeneratorDrop
| TerminatorKind::SwitchInt { .. }
| TerminatorKind::Drop { .. }
| TerminatorKind::DropAndReplace { .. }
| TerminatorKind::Assert { .. }
| TerminatorKind::Yield { .. } => (),
TerminatorKind::Call { destination, .. } => {
TerminatorKind::SwitchInt { discr, targets: _ } => {
record_usage_for_operand(discr, &mut result);
}
TerminatorKind::Call { destination, args, func, .. } => {
record_usage_for_operand(func, &mut result);
for arg in args.iter() {
record_usage_for_operand(arg, &mut result);
}
if destination.projection.lookup(&body.projection_store).len() == 0 {
if ever_init_map.get(destination.local).copied().unwrap_or_default() {
push_mut_span(destination.local, MirSpan::Unknown);
push_mut_span(destination.local, MirSpan::Unknown, &mut result);
} else {
ever_init_map.insert(destination.local, true);
}
src/tools/rust-analyzer/crates/hir-ty/src/mir/eval.rs
+4 -6
View File
@@ -162,7 +162,7 @@ pub struct Evaluator<'a> {
not_special_fn_cache: RefCell<FxHashSet<FunctionId>>,
mir_or_dyn_index_cache: RefCell<FxHashMap<(FunctionId, Substitution), MirOrDynIndex>>,
/// Constantly dropping and creating `Locals` is very costly. We store
/// old locals that we normaly want to drop here, to reuse their allocations
/// old locals that we normally want to drop here, to reuse their allocations
/// later.
unused_locals_store: RefCell<FxHashMap<DefWithBodyId, Vec<Locals>>>,
cached_ptr_size: usize,
@@ -375,10 +375,7 @@ pub fn pretty_print(
Err(_) => continue,
},
MirSpan::PatId(p) => match source_map.pat_syntax(*p) {
Ok(s) => s.map(|it| match it {
Either::Left(e) => e.into(),
Either::Right(e) => e.into(),
}),
Ok(s) => s.map(|it| it.syntax_node_ptr()),
Err(_) => continue,
},
MirSpan::Unknown => continue,
@@ -842,6 +839,7 @@ fn interpret_mir(
}
StatementKind::Deinit(_) => not_supported!("de-init statement"),
StatementKind::StorageLive(_)
| StatementKind::FakeRead(_)
| StatementKind::StorageDead(_)
| StatementKind::Nop => (),
}
@@ -2301,7 +2299,7 @@ fn exec_fn_with_args(
match self.get_mir_or_dyn_index(def, generic_args.clone(), locals, span)? {
MirOrDynIndex::Dyn(self_ty_idx) => {
// In the layout of current possible receiver, which at the moment of writing this code is one of
// `&T`, `&mut T`, `Box<T>`, `Rc<T>`, `Arc<T>`, and `Pin<P>` where `P` is one of possible recievers,
// `&T`, `&mut T`, `Box<T>`, `Rc<T>`, `Arc<T>`, and `Pin<P>` where `P` is one of possible receivers,
// the vtable is exactly in the `[ptr_size..2*ptr_size]` bytes. So we can use it without branching on
// the type.
let first_arg = arg_bytes.clone().next().unwrap();
src/tools/rust-analyzer/crates/hir-ty/src/mir/eval/shim.rs
+2 -2
View File
@@ -1045,7 +1045,7 @@ fn exec_intrinsic(
}
"transmute" => {
let [arg] = args else {
return Err(MirEvalError::TypeError("trasmute arg is not provided"));
return Err(MirEvalError::TypeError("transmute arg is not provided"));
};
destination.write_from_interval(self, arg.interval)
}
@@ -1065,7 +1065,7 @@ fn exec_intrinsic(
}
"ctlz" | "ctlz_nonzero" => {
let [arg] = args else {
return Err(MirEvalError::TypeError("cttz arg is not provided"));
return Err(MirEvalError::TypeError("ctlz arg is not provided"));
};
let result =
u128::from_le_bytes(pad16(arg.get(self)?, false)).leading_zeros() as usize;
src/tools/rust-analyzer/crates/hir-ty/src/mir/lower.rs
+17 -2
View File
@@ -529,6 +529,7 @@ fn lower_expr_to_place_without_adjust(
else {
return Ok(None);
};
self.push_fake_read(current, cond_place, expr_id.into());
let (then_target, else_target) =
self.pattern_match(current, None, cond_place, *pat)?;
self.write_bytes_to_place(
@@ -668,6 +669,7 @@ fn lower_expr_to_place_without_adjust(
else {
return Ok(None);
};
self.push_fake_read(current, cond_place, expr_id.into());
let mut end = None;
for MatchArm { pat, guard, expr } in arms.iter() {
let (then, mut otherwise) =
@@ -1299,6 +1301,7 @@ fn lower_assignment(
return Ok(None);
};
if matches!(&self.body.exprs[lhs], Expr::Underscore) {
self.push_fake_read_for_operand(current, rhs_op, span);
return Ok(Some(current));
}
if matches!(
@@ -1575,6 +1578,16 @@ fn push_statement(&mut self, block: BasicBlockId, statement: Statement) {
self.result.basic_blocks[block].statements.push(statement);
}
fn push_fake_read(&mut self, block: BasicBlockId, p: Place, span: MirSpan) {
self.push_statement(block, StatementKind::FakeRead(p).with_span(span));
}
fn push_fake_read_for_operand(&mut self, block: BasicBlockId, operand: Operand, span: MirSpan) {
if let Operand::Move(p) | Operand::Copy(p) = operand {
self.push_fake_read(block, p, span);
}
}
fn push_assignment(
&mut self,
block: BasicBlockId,
@@ -1733,6 +1746,7 @@ fn lower_block_to_place(
return Ok(None);
};
current = c;
self.push_fake_read(current, init_place, span);
(current, else_block) =
self.pattern_match(current, None, init_place, *pat)?;
match (else_block, else_branch) {
@@ -1760,13 +1774,14 @@ fn lower_block_to_place(
}
}
}
hir_def::hir::Statement::Expr { expr, has_semi: _ } => {
&hir_def::hir::Statement::Expr { expr, has_semi: _ } => {
let scope2 = self.push_drop_scope();
let Some((_, c)) = self.lower_expr_as_place(current, *expr, true)? else {
let Some((p, c)) = self.lower_expr_as_place(current, expr, true)? else {
scope2.pop_assume_dropped(self);
scope.pop_assume_dropped(self);
return Ok(None);
};
self.push_fake_read(c, p, expr.into());
current = scope2.pop_and_drop(self, c);
}
}
src/tools/rust-analyzer/crates/hir-ty/src/mir/lower/pattern_matching.rs
+4 -1
View File
@@ -284,6 +284,7 @@ fn pattern_match_inner(
);
(current, current_else) = self.pattern_match_binding(
id,
*slice,
next_place,
(*slice).into(),
current,
@@ -395,6 +396,7 @@ fn pattern_match_inner(
if mode == MatchingMode::Bind {
self.pattern_match_binding(
*id,
pattern,
cond_place,
pattern.into(),
current,
@@ -431,13 +433,14 @@ fn pattern_match_inner(
fn pattern_match_binding(
&mut self,
id: BindingId,
pat: PatId,
cond_place: Place,
span: MirSpan,
current: BasicBlockId,
current_else: Option<BasicBlockId>,
) -> Result<(BasicBlockId, Option<BasicBlockId>)> {
let target_place = self.binding_local(id)?;
let mode = self.infer.binding_modes[id];
let mode = self.infer.binding_modes[pat];
self.push_storage_live(id, current)?;
self.push_assignment(
current,
src/tools/rust-analyzer/crates/hir-ty/src/mir/monomorphization.rs
+1
View File
@@ -248,6 +248,7 @@ fn fill_body(&mut self, body: &mut MirBody) -> Result<(), MirLowerError> {
| Rvalue::CopyForDeref(_) => (),
},
StatementKind::Deinit(_)
| StatementKind::FakeRead(_)
| StatementKind::StorageLive(_)
| StatementKind::StorageDead(_)
| StatementKind::Nop => (),
src/tools/rust-analyzer/crates/hir-ty/src/mir/pretty.rs
+5
View File
@@ -233,6 +233,11 @@ fn blocks(&mut self) {
this.place(p);
wln!(this, ");");
}
StatementKind::FakeRead(p) => {
w!(this, "FakeRead(");
this.place(p);
wln!(this, ");");
}
StatementKind::Nop => wln!(this, "Nop;"),
}
}
src/tools/rust-analyzer/crates/hir-ty/src/tests.rs
+2 -12
View File
@@ -269,12 +269,7 @@ fn pat_node(
Some(match body_source_map.pat_syntax(pat) {
Ok(sp) => {
let root = db.parse_or_expand(sp.file_id);
sp.map(|ptr| {
ptr.either(
|it| it.to_node(&root).syntax().clone(),
|it| it.to_node(&root).syntax().clone(),
)
})
sp.map(|ptr| ptr.to_node(&root).syntax().clone())
}
Err(SyntheticSyntax) => return None,
})
@@ -303,12 +298,7 @@ fn infer_with_mismatches(content: &str, include_mismatches: bool) -> String {
let syntax_ptr = match body_source_map.pat_syntax(pat) {
Ok(sp) => {
let root = db.parse_or_expand(sp.file_id);
sp.map(|ptr| {
ptr.either(
|it| it.to_node(&root).syntax().clone(),
|it| it.to_node(&root).syntax().clone(),
)
})
sp.map(|ptr| ptr.to_node(&root).syntax().clone())
}
Err(SyntheticSyntax) => continue,
};
src/tools/rust-analyzer/crates/hir/Cargo.toml
+3
View File
@@ -30,3 +30,6 @@ profile.workspace = true
stdx.workspace = true
syntax.workspace = true
tt.workspace = true
[features]
in-rust-tree = []
src/tools/rust-analyzer/crates/hir/src/diagnostics.rs
+11 -6
View File
@@ -66,6 +66,7 @@ fn from(d: $diag) -> AnyDiagnostic {
UnresolvedModule,
UnresolvedProcMacro,
UnusedMut,
UnusedVariable,
];
#[derive(Debug)]
@@ -173,20 +174,19 @@ pub struct MalformedDerive {
#[derive(Debug)]
pub struct NoSuchField {
pub field: InFile<Either<AstPtr<ast::RecordExprField>, AstPtr<ast::RecordPatField>>>,
pub field: InFile<AstPtr<Either<ast::RecordExprField, ast::RecordPatField>>>,
pub private: bool,
}
#[derive(Debug)]
pub struct PrivateAssocItem {
pub expr_or_pat:
InFile<Either<AstPtr<ast::Expr>, Either<AstPtr<ast::Pat>, AstPtr<ast::SelfParam>>>>,
pub expr_or_pat: InFile<AstPtr<Either<ast::Expr, Either<ast::Pat, ast::SelfParam>>>>,
pub item: AssocItem,
}
#[derive(Debug)]
pub struct MismatchedTupleStructPatArgCount {
pub expr_or_pat: InFile<Either<AstPtr<ast::Expr>, AstPtr<ast::Pat>>>,
pub expr_or_pat: InFile<AstPtr<Either<ast::Expr, ast::Pat>>>,
pub expected: usize,
pub found: usize,
}
@@ -227,7 +227,7 @@ pub struct MissingUnsafe {
#[derive(Debug)]
pub struct MissingFields {
pub file: HirFileId,
pub field_list_parent: Either<AstPtr<ast::RecordExpr>, AstPtr<ast::RecordPat>>,
pub field_list_parent: AstPtr<Either<ast::RecordExpr, ast::RecordPat>>,
pub field_list_parent_path: Option<AstPtr<ast::Path>>,
pub missed_fields: Vec<Name>,
}
@@ -254,7 +254,7 @@ pub struct MissingMatchArms {
#[derive(Debug)]
pub struct TypeMismatch {
pub expr_or_pat: Either<InFile<AstPtr<ast::Expr>>, InFile<AstPtr<ast::Pat>>>,
pub expr_or_pat: InFile<AstPtr<Either<ast::Expr, ast::Pat>>>,
pub expected: Type,
pub actual: Type,
}
@@ -270,6 +270,11 @@ pub struct UnusedMut {
pub local: Local,
}
#[derive(Debug)]
pub struct UnusedVariable {
pub local: Local,
}
#[derive(Debug)]
pub struct MovedOutOfRef {
pub ty: Type,
src/tools/rust-analyzer/crates/hir/src/lib.rs
+98 -63
View File
@@ -18,6 +18,7 @@
//! <https://www.tedinski.com/2018/02/06/system-boundaries.html>.
#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#![recursion_limit = "512"]
mod semantics;
@@ -64,7 +65,7 @@
consteval::{try_const_usize, unknown_const_as_generic, ConstEvalError, ConstExt},
diagnostics::BodyValidationDiagnostic,
known_const_to_ast,
layout::{Layout as TyLayout, RustcEnumVariantIdx, TagEncoding},
layout::{Layout as TyLayout, RustcEnumVariantIdx, RustcFieldIdx, TagEncoding},
method_resolution::{self, TyFingerprint},
mir::{self, interpret_mir},
primitive::UintTy,
@@ -98,7 +99,7 @@
ReplaceFilterMapNextWithFindMap, TypeMismatch, TypedHole, UndeclaredLabel,
UnimplementedBuiltinMacro, UnreachableLabel, UnresolvedExternCrate, UnresolvedField,
UnresolvedImport, UnresolvedMacroCall, UnresolvedMethodCall, UnresolvedModule,
UnresolvedProcMacro, UnusedMut,
UnresolvedProcMacro, UnusedMut, UnusedVariable,
},
has_source::HasSource,
semantics::{PathResolution, Semantics, SemanticsScope, TypeInfo, VisibleTraits},
@@ -452,15 +453,7 @@ fn visibility(&self, db: &dyn HirDatabase) -> Visibility {
impl Module {
/// Name of this module.
pub fn name(self, db: &dyn HirDatabase) -> Option<Name> {
let def_map = self.id.def_map(db.upcast());
let parent = def_map[self.id.local_id].parent?;
def_map[parent].children.iter().find_map(|(name, module_id)| {
if *module_id == self.id.local_id {
Some(name.clone())
} else {
None
}
})
self.id.name(db.upcast())
}
/// Returns the crate this module is part of.
@@ -571,6 +564,7 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
if def_map[m.id.local_id].origin.is_inline() {
m.diagnostics(db, acc)
}
acc.extend(def.diagnostics(db))
}
ModuleDef::Trait(t) => {
for diag in db.trait_data_with_diagnostics(t.id).1.iter() {
@@ -1509,10 +1503,10 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
&hir_ty::InferenceDiagnostic::NoSuchField { field: expr, private } => {
let expr_or_pat = match expr {
ExprOrPatId::ExprId(expr) => {
source_map.field_syntax(expr).map(Either::Left)
source_map.field_syntax(expr).map(AstPtr::wrap_left)
}
ExprOrPatId::PatId(pat) => {
source_map.pat_field_syntax(pat).map(Either::Right)
source_map.pat_field_syntax(pat).map(AstPtr::wrap_right)
}
};
acc.push(NoSuchField { field: expr_or_pat, private }.into())
@@ -1530,8 +1524,8 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
}
&hir_ty::InferenceDiagnostic::PrivateAssocItem { id, item } => {
let expr_or_pat = match id {
ExprOrPatId::ExprId(expr) => expr_syntax(expr).map(Either::Left),
ExprOrPatId::PatId(pat) => pat_syntax(pat).map(Either::Right),
ExprOrPatId::ExprId(expr) => expr_syntax(expr).map(AstPtr::wrap_left),
ExprOrPatId::PatId(pat) => pat_syntax(pat).map(AstPtr::wrap_right),
};
let item = item.into();
acc.push(PrivateAssocItem { expr_or_pat, item }.into())
@@ -1609,12 +1603,17 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
found,
} => {
let expr_or_pat = match pat {
ExprOrPatId::ExprId(expr) => expr_syntax(expr).map(Either::Left),
ExprOrPatId::PatId(pat) => source_map
.pat_syntax(pat)
.expect("unexpected synthetic")
.map(|it| it.unwrap_left())
.map(Either::Right),
ExprOrPatId::ExprId(expr) => expr_syntax(expr).map(AstPtr::wrap_left),
ExprOrPatId::PatId(pat) => {
let InFile { file_id, value } =
source_map.pat_syntax(pat).expect("unexpected synthetic");
// cast from Either<Pat, SelfParam> -> Either<_, Pat>
let Some(ptr) = AstPtr::try_from_raw(value.syntax_node_ptr()) else {
continue;
};
InFile { file_id, value: ptr }
}
};
acc.push(
MismatchedTupleStructPatArgCount { expr_or_pat, expected, found }.into(),
@@ -1628,11 +1627,15 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
ExprOrPatId::PatId(pat) => source_map.pat_syntax(pat).map(Either::Right),
};
let expr_or_pat = match expr_or_pat {
Ok(Either::Left(expr)) => Either::Left(expr),
Ok(Either::Right(InFile { file_id, value: Either::Left(pat) })) => {
Either::Right(InFile { file_id, value: pat })
Ok(Either::Left(expr)) => expr.map(AstPtr::wrap_left),
Ok(Either::Right(InFile { file_id, value: pat })) => {
// cast from Either<Pat, SelfParam> -> Either<_, Pat>
let Some(ptr) = AstPtr::try_from_raw(pat.syntax_node_ptr()) else {
continue;
};
InFile { file_id, value: ptr }
}
Ok(Either::Right(_)) | Err(SyntheticSyntax) => continue,
Err(SyntheticSyntax) => continue,
};
acc.push(
@@ -1667,10 +1670,7 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
Err(_) => continue,
},
mir::MirSpan::PatId(p) => match source_map.pat_syntax(p) {
Ok(s) => s.map(|it| match it {
Either::Left(e) => e.into(),
Either::Right(e) => e.into(),
}),
Ok(s) => s.map(|it| it.into()),
Err(_) => continue,
},
mir::MirSpan::Unknown => continue,
@@ -1697,9 +1697,20 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
// Skip synthetic bindings
continue;
}
let need_mut = &mol[local];
let mut need_mut = &mol[local];
if body[binding_id].name.as_str() == Some("self")
&& need_mut == &mir::MutabilityReason::Unused
{
need_mut = &mir::MutabilityReason::Not;
}
let local = Local { parent: self.into(), binding_id };
match (need_mut, local.is_mut(db)) {
(mir::MutabilityReason::Unused, _) => {
let should_ignore = matches!(body[binding_id].name.as_str(), Some(it) if it.starts_with("_"));
if !should_ignore {
acc.push(UnusedVariable { local }.into())
}
}
(mir::MutabilityReason::Mut { .. }, true)
| (mir::MutabilityReason::Not, false) => (),
(mir::MutabilityReason::Mut { spans }, false) => {
@@ -1710,10 +1721,7 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
Err(_) => continue,
},
mir::MirSpan::PatId(p) => match source_map.pat_syntax(*p) {
Ok(s) => s.map(|it| match it {
Either::Left(e) => e.into(),
Either::Right(e) => e.into(),
}),
Ok(s) => s.map(|it| it.into()),
Err(_) => continue,
},
mir::MirSpan::Unknown => continue,
@@ -1752,18 +1760,18 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
Ok(source_ptr) => {
let root = source_ptr.file_syntax(db.upcast());
if let ast::Expr::RecordExpr(record_expr) =
&source_ptr.value.to_node(&root)
source_ptr.value.to_node(&root)
{
if record_expr.record_expr_field_list().is_some() {
let field_list_parent_path =
record_expr.path().map(|path| AstPtr::new(&path));
acc.push(
MissingFields {
file: source_ptr.file_id,
field_list_parent: Either::Left(AstPtr::new(
field_list_parent: AstPtr::new(&Either::Left(
record_expr,
)),
field_list_parent_path: record_expr
.path()
.map(|path| AstPtr::new(&path)),
field_list_parent_path,
missed_fields,
}
.into(),
@@ -1775,24 +1783,24 @@ pub fn diagnostics(self, db: &dyn HirDatabase, acc: &mut Vec<AnyDiagnostic>) {
},
Either::Right(record_pat) => match source_map.pat_syntax(record_pat) {
Ok(source_ptr) => {
if let Some(expr) = source_ptr.value.as_ref().left() {
if let Some(ptr) = source_ptr.value.clone().cast::<ast::RecordPat>()
{
let root = source_ptr.file_syntax(db.upcast());
if let ast::Pat::RecordPat(record_pat) = expr.to_node(&root) {
if record_pat.record_pat_field_list().is_some() {
acc.push(
MissingFields {
file: source_ptr.file_id,
field_list_parent: Either::Right(AstPtr::new(
&record_pat,
)),
field_list_parent_path: record_pat
.path()
.map(|path| AstPtr::new(&path)),
missed_fields,
}
.into(),
)
}
let record_pat = ptr.to_node(&root);
if record_pat.record_pat_field_list().is_some() {
let field_list_parent_path =
record_pat.path().map(|path| AstPtr::new(&path));
acc.push(
MissingFields {
file: source_ptr.file_id,
field_list_parent: AstPtr::new(&Either::Right(
record_pat,
)),
field_list_parent_path,
missed_fields,
}
.into(),
)
}
}
}
@@ -1960,6 +1968,17 @@ pub fn is_test(self, db: &dyn HirDatabase) -> bool {
db.function_data(self.id).attrs.is_test()
}
/// is this a `fn main` or a function with an `export_name` of `main`?
pub fn is_main(self, db: &dyn HirDatabase) -> bool {
if !self.module(db).is_crate_root() {
return false;
}
let data = db.function_data(self.id);
data.name.to_smol_str() == "main"
|| data.attrs.export_name().map(core::ops::Deref::deref) == Some("main")
}
/// Does this function have the ignore attribute?
pub fn is_ignore(self, db: &dyn HirDatabase) -> bool {
db.function_data(self.id).attrs.is_ignore()
@@ -2926,10 +2945,10 @@ fn sources_<'a>(
.map(|&definition| {
let src = source_map.pat_syntax(definition).unwrap(); // Hmm...
let root = src.file_syntax(db.upcast());
src.map(|ast| match ast {
// Suspicious unwrap
Either::Left(it) => Either::Left(it.cast().unwrap().to_node(&root)),
Either::Right(it) => Either::Right(it.to_node(&root)),
src.map(|ast| match ast.to_node(&root) {
Either::Left(ast::Pat::IdentPat(it)) => Either::Left(it),
Either::Left(_) => unreachable!("local with non ident-pattern"),
Either::Right(it) => Either::Right(it),
})
})
.map(move |source| LocalSource { local: self, source })
@@ -4515,15 +4534,31 @@ pub fn niches(&self) -> Option<u128> {
Some(self.0.largest_niche?.available(&*self.1))
}
pub fn field_offset(&self, idx: usize) -> Option<u64> {
pub fn field_offset(&self, field: Field) -> Option<u64> {
match self.0.fields {
layout::FieldsShape::Primitive => None,
layout::FieldsShape::Union(_) => Some(0),
layout::FieldsShape::Array { stride, count } => {
let i = u64::try_from(idx).ok()?;
let i = u64::try_from(field.index()).ok()?;
(i < count).then_some((stride * i).bytes())
}
layout::FieldsShape::Arbitrary { ref offsets, .. } => Some(offsets.get(idx)?.bytes()),
layout::FieldsShape::Arbitrary { ref offsets, .. } => {
Some(offsets.get(RustcFieldIdx(field.id))?.bytes())
}
}
}
pub fn tuple_field_offset(&self, field: usize) -> Option<u64> {
match self.0.fields {
layout::FieldsShape::Primitive => None,
layout::FieldsShape::Union(_) => Some(0),
layout::FieldsShape::Array { stride, count } => {
let i = u64::try_from(field).ok()?;
(i < count).then_some((stride * i).bytes())
}
layout::FieldsShape::Arbitrary { ref offsets, .. } => {
Some(offsets.get(RustcFieldIdx::new(field))?.bytes())
}
}
}
src/tools/rust-analyzer/crates/hir/src/source_analyzer.rs
+4 -4
View File
@@ -236,9 +236,9 @@ pub(crate) fn binding_mode_of_pat(
_db: &dyn HirDatabase,
pat: &ast::IdentPat,
) -> Option<BindingMode> {
let binding_id = self.binding_id_of_pat(pat)?;
let id = self.pat_id(&pat.clone().into())?;
let infer = self.infer.as_ref()?;
infer.binding_modes.get(binding_id).map(|bm| match bm {
infer.binding_modes.get(id).map(|bm| match bm {
hir_ty::BindingMode::Move => BindingMode::Move,
hir_ty::BindingMode::Ref(hir_ty::Mutability::Mut) => BindingMode::Ref(Mutability::Mut),
hir_ty::BindingMode::Ref(hir_ty::Mutability::Not) => {
@@ -888,7 +888,7 @@ fn scope_for_offset(
.scope_by_expr()
.iter()
.filter_map(|(id, scope)| {
let InFile { file_id, value } = source_map.expr_syntax(*id).ok()?;
let InFile { file_id, value } = source_map.expr_syntax(id).ok()?;
if from_file == file_id {
return Some((value.text_range(), scope));
}
@@ -923,7 +923,7 @@ fn adjust(
.scope_by_expr()
.iter()
.filter_map(|(id, scope)| {
let source = source_map.expr_syntax(*id).ok()?;
let source = source_map.expr_syntax(id).ok()?;
// FIXME: correctly handle macro expansion
if source.file_id != from_file {
return None;
src/tools/rust-analyzer/crates/ide-assists/src/handlers/add_missing_match_arms.rs
+42 -8
View File
@@ -273,9 +273,10 @@ pub(crate) fn add_missing_match_arms(acc: &mut Assists, ctx: &AssistContext<'_>)
syntax::SyntaxElement::Token(it) => {
// Don't have a way to make tokens mut, so instead make the parent mut
// and find the token again
let parent = edit.make_syntax_mut(it.parent().unwrap());
let parent =
edit.make_syntax_mut(it.parent().expect("Token must have a parent."));
let mut_token =
parent.covering_element(it.text_range()).into_token().unwrap();
parent.covering_element(it.text_range()).into_token().expect("Covering element cannot be found. Range may be beyond the current node's range");
syntax::SyntaxElement::from(mut_token)
}
@@ -446,21 +447,23 @@ fn build_pat(
mod_path_to_ast(&module.find_use_path(db, ModuleDef::from(var), prefer_no_std)?);
// FIXME: use HIR for this; it doesn't currently expose struct vs. tuple vs. unit variants though
let pat: ast::Pat = match var.source(db)?.value.kind() {
Some(match var.source(db)?.value.kind() {
ast::StructKind::Tuple(field_list) => {
let pats =
iter::repeat(make::wildcard_pat().into()).take(field_list.fields().count());
make::tuple_struct_pat(path, pats).into()
}
ast::StructKind::Record(field_list) => {
let pats = field_list
.fields()
.map(|f| make::ext::simple_ident_pat(f.name().unwrap()).into());
let pats = field_list.fields().map(|f| {
make::ext::simple_ident_pat(
f.name().expect("Record field must have a name"),
)
.into()
});
make::record_pat(path, pats).into()
}
ast::StructKind::Unit => make::path_pat(path),
};
Some(pat)
})
}
ExtendedVariant::True => Some(ast::Pat::from(make::literal_pat("true"))),
ExtendedVariant::False => Some(ast::Pat::from(make::literal_pat("false"))),
@@ -1941,4 +1944,35 @@ fn main() {
"#,
);
}
/// See [`discussion`](https://github.com/rust-lang/rust-analyzer/pull/15594#discussion_r1322960614)
#[test]
fn missing_field_name() {
check_assist(
add_missing_match_arms,
r#"
enum A {
A,
Missing { a: u32, : u32, c: u32 }
}
fn a() {
let b = A::A;
match b$0 {}
}"#,
r#"
enum A {
A,
Missing { a: u32, : u32, c: u32 }
}
fn a() {
let b = A::A;
match b {
$0A::A => todo!(),
A::Missing { a, u32, c } => todo!(),
}
}"#,
)
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/apply_demorgan.rs
+332 -2
View File
@@ -1,7 +1,13 @@
use std::collections::VecDeque;
use ide_db::{
assists::GroupLabel,
famous_defs::FamousDefs,
source_change::SourceChangeBuilder,
syntax_helpers::node_ext::{for_each_tail_expr, walk_expr},
};
use syntax::{
ast::{self, AstNode, Expr::BinExpr},
ast::{self, make, AstNode, Expr::BinExpr, HasArgList},
ted::{self, Position},
SyntaxKind,
};
@@ -89,7 +95,8 @@ pub(crate) fn apply_demorgan(acc: &mut Assists, ctx: &AssistContext<'_>) -> Opti
let dm_lhs = demorganed.lhs()?;
acc.add(
acc.add_group(
&GroupLabel("Apply De Morgan's law".to_string()),
AssistId("apply_demorgan", AssistKind::RefactorRewrite),
"Apply De Morgan's law",
op_range,
@@ -143,6 +150,127 @@ pub(crate) fn apply_demorgan(acc: &mut Assists, ctx: &AssistContext<'_>) -> Opti
)
}
// Assist: apply_demorgan_iterator
//
// Apply https://en.wikipedia.org/wiki/De_Morgan%27s_laws[De Morgan's law] to
// `Iterator::all` and `Iterator::any`.
//
// This transforms expressions of the form `!iter.any(|x| predicate(x))` into
// `iter.all(|x| !predicate(x))` and vice versa. This also works the other way for
// `Iterator::all` into `Iterator::any`.
//
// ```
// # //- minicore: iterator
// fn main() {
// let arr = [1, 2, 3];
// if !arr.into_iter().$0any(|num| num == 4) {
// println!("foo");
// }
// }
// ```
// ->
// ```
// fn main() {
// let arr = [1, 2, 3];
// if arr.into_iter().all(|num| num != 4) {
// println!("foo");
// }
// }
// ```
pub(crate) fn apply_demorgan_iterator(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
let method_call: ast::MethodCallExpr = ctx.find_node_at_offset()?;
let (name, arg_expr) = validate_method_call_expr(ctx, &method_call)?;
let ast::Expr::ClosureExpr(closure_expr) = arg_expr else { return None };
let closure_body = closure_expr.body()?;
let op_range = method_call.syntax().text_range();
let label = format!("Apply De Morgan's law to `Iterator::{}`", name.text().as_str());
acc.add_group(
&GroupLabel("Apply De Morgan's law".to_string()),
AssistId("apply_demorgan_iterator", AssistKind::RefactorRewrite),
label,
op_range,
|edit| {
// replace the method name
let new_name = match name.text().as_str() {
"all" => make::name_ref("any"),
"any" => make::name_ref("all"),
_ => unreachable!(),
}
.clone_for_update();
edit.replace_ast(name, new_name);
// negate all tail expressions in the closure body
let tail_cb = &mut |e: &_| tail_cb_impl(edit, e);
walk_expr(&closure_body, &mut |expr| {
if let ast::Expr::ReturnExpr(ret_expr) = expr {
if let Some(ret_expr_arg) = &ret_expr.expr() {
for_each_tail_expr(ret_expr_arg, tail_cb);
}
}
});
for_each_tail_expr(&closure_body, tail_cb);
// negate the whole method call
if let Some(prefix_expr) = method_call
.syntax()
.parent()
.and_then(ast::PrefixExpr::cast)
.filter(|prefix_expr| matches!(prefix_expr.op_kind(), Some(ast::UnaryOp::Not)))
{
edit.delete(
prefix_expr
.op_token()
.expect("prefix expression always has an operator")
.text_range(),
);
} else {
edit.insert(method_call.syntax().text_range().start(), "!");
}
},
)
}
/// Ensures that the method call is to `Iterator::all` or `Iterator::any`.
fn validate_method_call_expr(
ctx: &AssistContext<'_>,
method_call: &ast::MethodCallExpr,
) -> Option<(ast::NameRef, ast::Expr)> {
let name_ref = method_call.name_ref()?;
if name_ref.text() != "all" && name_ref.text() != "any" {
return None;
}
let arg_expr = method_call.arg_list()?.args().next()?;
let sema = &ctx.sema;
let receiver = method_call.receiver()?;
let it_type = sema.type_of_expr(&receiver)?.adjusted();
let module = sema.scope(receiver.syntax())?.module();
let krate = module.krate();
let iter_trait = FamousDefs(sema, krate).core_iter_Iterator()?;
it_type.impls_trait(sema.db, iter_trait, &[]).then_some((name_ref, arg_expr))
}
fn tail_cb_impl(edit: &mut SourceChangeBuilder, e: &ast::Expr) {
match e {
ast::Expr::BreakExpr(break_expr) => {
if let Some(break_expr_arg) = break_expr.expr() {
for_each_tail_expr(&break_expr_arg, &mut |e| tail_cb_impl(edit, e))
}
}
ast::Expr::ReturnExpr(_) => {
// all return expressions have already been handled by the walk loop
}
e => {
let inverted_body = invert_boolean_expression(e.clone());
edit.replace(e.syntax().text_range(), inverted_body.syntax().text());
}
}
}
#[cfg(test)]
mod tests {
use super::*;
@@ -255,4 +383,206 @@ fn demorgan_removes_pars_in_eq_precedence() {
"fn() { let x = a && b && c; }",
)
}
#[test]
fn demorgan_iterator_any_all_reverse() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().all(|num| num $0!= 4) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().any(|num| num == 4) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_all_any() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0all(|num| num > 3) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().any(|num| num <= 3) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_multiple_terms() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0any(|num| num > 3 && num == 23 && num <= 30) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().all(|num| !(num > 3 && num == 23 && num <= 30)) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_double_negation() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0all(|num| !(num > 3)) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().any(|num| num > 3) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_double_parens() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0any(|num| (num > 3 && (num == 1 || num == 2))) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().all(|num| !(num > 3 && (num == 1 || num == 2))) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_multiline() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if arr
.into_iter()
.all$0(|num| !num.is_negative())
{
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [1, 2, 3];
if !arr
.into_iter()
.any(|num| num.is_negative())
{
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_block_closure() {
check_assist(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [-1, 1, 2, 3];
if arr.into_iter().all(|num: i32| {
$0if num.is_positive() {
num <= 3
} else {
num >= -1
}
}) {
println!("foo");
}
}
"#,
r#"
fn main() {
let arr = [-1, 1, 2, 3];
if !arr.into_iter().any(|num: i32| {
if num.is_positive() {
num > 3
} else {
num < -1
}
}) {
println!("foo");
}
}
"#,
);
}
#[test]
fn demorgan_iterator_wrong_method() {
check_assist_not_applicable(
apply_demorgan_iterator,
r#"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0map(|num| num > 3) {
println!("foo");
}
}
"#,
);
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/auto_import.rs
+250 -10
View File
@@ -5,7 +5,7 @@
helpers::mod_path_to_ast,
imports::{
import_assets::{ImportAssets, ImportCandidate, LocatedImport},
insert_use::{insert_use, ImportScope},
insert_use::{insert_use, insert_use_as_alias, ImportScope},
},
};
use syntax::{ast, AstNode, NodeOrToken, SyntaxElement};
@@ -129,10 +129,12 @@ pub(crate) fn auto_import(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<
for import in proposed_imports {
let import_path = import.import_path;
let (assist_id, import_name) =
(AssistId("auto_import", AssistKind::QuickFix), import_path.display(ctx.db()));
acc.add_group(
&group_label,
AssistId("auto_import", AssistKind::QuickFix),
format!("Import `{}`", import_path.display(ctx.db())),
assist_id,
format!("Import `{}`", import_name),
range,
|builder| {
let scope = match scope.clone() {
@@ -143,6 +145,38 @@ pub(crate) fn auto_import(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<
insert_use(&scope, mod_path_to_ast(&import_path), &ctx.config.insert_use);
},
);
match import_assets.import_candidate() {
ImportCandidate::TraitAssocItem(name) | ImportCandidate::TraitMethod(name) => {
let is_method =
matches!(import_assets.import_candidate(), ImportCandidate::TraitMethod(_));
let type_ = if is_method { "method" } else { "item" };
let group_label = GroupLabel(format!(
"Import a trait for {} {} by alias",
type_,
name.assoc_item_name.text()
));
acc.add_group(
&group_label,
assist_id,
format!("Import `{} as _`", import_name),
range,
|builder| {
let scope = match scope.clone() {
ImportScope::File(it) => ImportScope::File(builder.make_mut(it)),
ImportScope::Module(it) => ImportScope::Module(builder.make_mut(it)),
ImportScope::Block(it) => ImportScope::Block(builder.make_mut(it)),
};
insert_use_as_alias(
&scope,
mod_path_to_ast(&import_path),
&ctx.config.insert_use,
);
},
);
}
_ => {}
}
}
Some(())
}
@@ -253,7 +287,8 @@ mod tests {
};
use crate::tests::{
check_assist, check_assist_not_applicable, check_assist_target, TEST_CONFIG,
check_assist, check_assist_by_label, check_assist_not_applicable, check_assist_target,
TEST_CONFIG,
};
fn check_auto_import_order(before: &str, order: &[&str]) {
@@ -705,7 +740,7 @@ fn main() {
#[test]
fn associated_trait_function() {
check_assist(
check_assist_by_label(
auto_import,
r"
mod test_mod {
@@ -739,6 +774,44 @@ fn main() {
test_mod::TestStruct::test_function
}
",
"Import `test_mod::TestTrait`",
);
check_assist_by_label(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
test_mod::TestStruct::test_function$0
}
",
r"
use test_mod::TestTrait as _;
mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
fn main() {
test_mod::TestStruct::test_function
}
",
"Import `test_mod::TestTrait as _`",
);
}
@@ -776,7 +849,44 @@ fn main() {
#[test]
fn associated_trait_const() {
check_assist(
check_assist_by_label(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
const TEST_CONST: u8;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
test_mod::TestStruct::TEST_CONST$0
}
",
r"
use test_mod::TestTrait as _;
mod test_mod {
pub trait TestTrait {
const TEST_CONST: u8;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const TEST_CONST: u8 = 42;
}
}
fn main() {
test_mod::TestStruct::TEST_CONST
}
",
"Import `test_mod::TestTrait as _`",
);
check_assist_by_label(
auto_import,
r"
mod test_mod {
@@ -810,6 +920,7 @@ fn main() {
test_mod::TestStruct::TEST_CONST
}
",
"Import `test_mod::TestTrait`",
);
}
@@ -847,7 +958,46 @@ fn main() {
#[test]
fn trait_method() {
check_assist(
check_assist_by_label(
auto_import,
r"
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
test_struct.test_meth$0od()
}
",
r"
use test_mod::TestTrait as _;
mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
fn main() {
let test_struct = test_mod::TestStruct {};
test_struct.test_method()
}
",
"Import `test_mod::TestTrait as _`",
);
check_assist_by_label(
auto_import,
r"
mod test_mod {
@@ -883,12 +1033,43 @@ fn main() {
test_struct.test_method()
}
",
"Import `test_mod::TestTrait`",
);
}
#[test]
fn trait_method_cross_crate() {
check_assist(
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
let test_struct = dep::test_mod::TestStruct {};
test_struct.test_meth$0od()
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
fn test_method(&self);
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_method(&self) {}
}
}
",
r"
use dep::test_mod::TestTrait as _;
fn main() {
let test_struct = dep::test_mod::TestStruct {};
test_struct.test_method()
}
",
"Import `dep::test_mod::TestTrait as _`",
);
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
@@ -915,12 +1096,41 @@ fn main() {
test_struct.test_method()
}
",
"Import `dep::test_mod::TestTrait`",
);
}
#[test]
fn assoc_fn_cross_crate() {
check_assist(
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
dep::test_mod::TestStruct::test_func$0tion
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
fn test_function();
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
fn test_function() {}
}
}
",
r"
use dep::test_mod::TestTrait as _;
fn main() {
dep::test_mod::TestStruct::test_function
}
",
"Import `dep::test_mod::TestTrait as _`",
);
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
@@ -945,12 +1155,41 @@ fn main() {
dep::test_mod::TestStruct::test_function
}
",
"Import `dep::test_mod::TestTrait`",
);
}
#[test]
fn assoc_const_cross_crate() {
check_assist(
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
fn main() {
dep::test_mod::TestStruct::CONST$0
}
//- /dep.rs crate:dep
pub mod test_mod {
pub trait TestTrait {
const CONST: bool;
}
pub struct TestStruct {}
impl TestTrait for TestStruct {
const CONST: bool = true;
}
}
",
r"
use dep::test_mod::TestTrait as _;
fn main() {
dep::test_mod::TestStruct::CONST
}
",
"Import `dep::test_mod::TestTrait as _`",
);
check_assist_by_label(
auto_import,
r"
//- /main.rs crate:main deps:dep
@@ -975,6 +1214,7 @@ fn main() {
dep::test_mod::TestStruct::CONST
}
",
"Import `dep::test_mod::TestTrait`",
);
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/bool_to_enum.rs
+1672
View File
@@ -0,0 +1,1672 @@
use hir::ModuleDef;
use ide_db::{
assists::{AssistId, AssistKind},
defs::Definition,
helpers::mod_path_to_ast,
imports::insert_use::{insert_use, ImportScope},
search::{FileReference, UsageSearchResult},
source_change::SourceChangeBuilder,
FxHashSet,
};
use itertools::Itertools;
use syntax::{
ast::{
self,
edit::IndentLevel,
edit_in_place::{AttrsOwnerEdit, Indent},
make, HasName,
},
ted, AstNode, NodeOrToken, SyntaxKind, SyntaxNode, T,
};
use text_edit::TextRange;
use crate::assist_context::{AssistContext, Assists};
// Assist: bool_to_enum
//
// This converts boolean local variables, fields, constants, and statics into a new
// enum with two variants `Bool::True` and `Bool::False`, as well as replacing
// all assignments with the variants and replacing all usages with `== Bool::True` or
// `== Bool::False`.
//
// ```
// fn main() {
// let $0bool = true;
//
// if bool {
// println!("foo");
// }
// }
// ```
// ->
// ```
// #[derive(PartialEq, Eq)]
// enum Bool { True, False }
//
// fn main() {
// let bool = Bool::True;
//
// if bool == Bool::True {
// println!("foo");
// }
// }
// ```
pub(crate) fn bool_to_enum(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
let BoolNodeData { target_node, name, ty_annotation, initializer, definition } =
find_bool_node(ctx)?;
let target_module = ctx.sema.scope(&target_node)?.module().nearest_non_block_module(ctx.db());
let target = name.syntax().text_range();
acc.add(
AssistId("bool_to_enum", AssistKind::RefactorRewrite),
"Convert boolean to enum",
target,
|edit| {
if let Some(ty) = &ty_annotation {
cov_mark::hit!(replaces_ty_annotation);
edit.replace(ty.syntax().text_range(), "Bool");
}
if let Some(initializer) = initializer {
replace_bool_expr(edit, initializer);
}
let usages = definition.usages(&ctx.sema).all();
add_enum_def(edit, ctx, &usages, target_node, &target_module);
replace_usages(edit, ctx, &usages, definition, &target_module);
},
)
}
struct BoolNodeData {
target_node: SyntaxNode,
name: ast::Name,
ty_annotation: Option<ast::Type>,
initializer: Option<ast::Expr>,
definition: Definition,
}
/// Attempts to find an appropriate node to apply the action to.
fn find_bool_node(ctx: &AssistContext<'_>) -> Option<BoolNodeData> {
let name: ast::Name = ctx.find_node_at_offset()?;
if let Some(let_stmt) = name.syntax().ancestors().find_map(ast::LetStmt::cast) {
let bind_pat = match let_stmt.pat()? {
ast::Pat::IdentPat(pat) => pat,
_ => {
cov_mark::hit!(not_applicable_in_non_ident_pat);
return None;
}
};
let def = ctx.sema.to_def(&bind_pat)?;
if !def.ty(ctx.db()).is_bool() {
cov_mark::hit!(not_applicable_non_bool_local);
return None;
}
Some(BoolNodeData {
target_node: let_stmt.syntax().clone(),
name,
ty_annotation: let_stmt.ty(),
initializer: let_stmt.initializer(),
definition: Definition::Local(def),
})
} else if let Some(const_) = name.syntax().parent().and_then(ast::Const::cast) {
let def = ctx.sema.to_def(&const_)?;
if !def.ty(ctx.db()).is_bool() {
cov_mark::hit!(not_applicable_non_bool_const);
return None;
}
Some(BoolNodeData {
target_node: const_.syntax().clone(),
name,
ty_annotation: const_.ty(),
initializer: const_.body(),
definition: Definition::Const(def),
})
} else if let Some(static_) = name.syntax().parent().and_then(ast::Static::cast) {
let def = ctx.sema.to_def(&static_)?;
if !def.ty(ctx.db()).is_bool() {
cov_mark::hit!(not_applicable_non_bool_static);
return None;
}
Some(BoolNodeData {
target_node: static_.syntax().clone(),
name,
ty_annotation: static_.ty(),
initializer: static_.body(),
definition: Definition::Static(def),
})
} else {
let field = name.syntax().parent().and_then(ast::RecordField::cast)?;
if field.name()? != name {
return None;
}
let adt = field.syntax().ancestors().find_map(ast::Adt::cast)?;
let def = ctx.sema.to_def(&field)?;
if !def.ty(ctx.db()).is_bool() {
cov_mark::hit!(not_applicable_non_bool_field);
return None;
}
Some(BoolNodeData {
target_node: adt.syntax().clone(),
name,
ty_annotation: field.ty(),
initializer: None,
definition: Definition::Field(def),
})
}
}
fn replace_bool_expr(edit: &mut SourceChangeBuilder, expr: ast::Expr) {
let expr_range = expr.syntax().text_range();
let enum_expr = bool_expr_to_enum_expr(expr);
edit.replace(expr_range, enum_expr.syntax().text())
}
/// Converts an expression of type `bool` to one of the new enum type.
fn bool_expr_to_enum_expr(expr: ast::Expr) -> ast::Expr {
let true_expr = make::expr_path(make::path_from_text("Bool::True")).clone_for_update();
let false_expr = make::expr_path(make::path_from_text("Bool::False")).clone_for_update();
if let ast::Expr::Literal(literal) = &expr {
match literal.kind() {
ast::LiteralKind::Bool(true) => true_expr,
ast::LiteralKind::Bool(false) => false_expr,
_ => expr,
}
} else {
make::expr_if(
expr,
make::tail_only_block_expr(true_expr),
Some(ast::ElseBranch::Block(make::tail_only_block_expr(false_expr))),
)
.clone_for_update()
}
}
/// Replaces all usages of the target identifier, both when read and written to.
fn replace_usages(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
usages: &UsageSearchResult,
target_definition: Definition,
target_module: &hir::Module,
) {
for (file_id, references) in usages.iter() {
edit.edit_file(*file_id);
let refs_with_imports =
augment_references_with_imports(edit, ctx, references, target_module);
refs_with_imports.into_iter().rev().for_each(
|FileReferenceWithImport { range, old_name, new_name, import_data }| {
// replace the usages in patterns and expressions
if let Some(ident_pat) = old_name.syntax().ancestors().find_map(ast::IdentPat::cast)
{
cov_mark::hit!(replaces_record_pat_shorthand);
let definition = ctx.sema.to_def(&ident_pat).map(Definition::Local);
if let Some(def) = definition {
replace_usages(
edit,
ctx,
&def.usages(&ctx.sema).all(),
target_definition,
target_module,
)
}
} else if let Some(initializer) = find_assignment_usage(&new_name) {
cov_mark::hit!(replaces_assignment);
replace_bool_expr(edit, initializer);
} else if let Some((prefix_expr, inner_expr)) = find_negated_usage(&new_name) {
cov_mark::hit!(replaces_negation);
edit.replace(
prefix_expr.syntax().text_range(),
format!("{} == Bool::False", inner_expr),
);
} else if let Some((record_field, initializer)) = old_name
.as_name_ref()
.and_then(ast::RecordExprField::for_field_name)
.and_then(|record_field| ctx.sema.resolve_record_field(&record_field))
.and_then(|(got_field, _, _)| {
find_record_expr_usage(&new_name, got_field, target_definition)
})
{
cov_mark::hit!(replaces_record_expr);
let record_field = edit.make_mut(record_field);
let enum_expr = bool_expr_to_enum_expr(initializer);
record_field.replace_expr(enum_expr);
} else if let Some(pat) = find_record_pat_field_usage(&old_name) {
match pat {
ast::Pat::IdentPat(ident_pat) => {
cov_mark::hit!(replaces_record_pat);
let definition = ctx.sema.to_def(&ident_pat).map(Definition::Local);
if let Some(def) = definition {
replace_usages(
edit,
ctx,
&def.usages(&ctx.sema).all(),
target_definition,
target_module,
)
}
}
ast::Pat::LiteralPat(literal_pat) => {
cov_mark::hit!(replaces_literal_pat);
if let Some(expr) = literal_pat.literal().and_then(|literal| {
literal.syntax().ancestors().find_map(ast::Expr::cast)
}) {
replace_bool_expr(edit, expr);
}
}
_ => (),
}
} else if let Some((ty_annotation, initializer)) = find_assoc_const_usage(&new_name)
{
edit.replace(ty_annotation.syntax().text_range(), "Bool");
replace_bool_expr(edit, initializer);
} else if let Some(receiver) = find_method_call_expr_usage(&new_name) {
edit.replace(
receiver.syntax().text_range(),
format!("({} == Bool::True)", receiver),
);
} else if new_name.syntax().ancestors().find_map(ast::UseTree::cast).is_none() {
// for any other usage in an expression, replace it with a check that it is the true variant
if let Some((record_field, expr)) = new_name
.as_name_ref()
.and_then(ast::RecordExprField::for_field_name)
.and_then(|record_field| {
record_field.expr().map(|expr| (record_field, expr))
})
{
record_field.replace_expr(
make::expr_bin_op(
expr,
ast::BinaryOp::CmpOp(ast::CmpOp::Eq { negated: false }),
make::expr_path(make::path_from_text("Bool::True")),
)
.clone_for_update(),
);
} else {
edit.replace(range, format!("{} == Bool::True", new_name.text()));
}
}
// add imports across modules where needed
if let Some((import_scope, path)) = import_data {
insert_use(&import_scope, path, &ctx.config.insert_use);
}
},
)
}
}
struct FileReferenceWithImport {
range: TextRange,
old_name: ast::NameLike,
new_name: ast::NameLike,
import_data: Option<(ImportScope, ast::Path)>,
}
fn augment_references_with_imports(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
references: &[FileReference],
target_module: &hir::Module,
) -> Vec<FileReferenceWithImport> {
let mut visited_modules = FxHashSet::default();
references
.iter()
.filter_map(|FileReference { range, name, .. }| {
ctx.sema.scope(name.syntax()).map(|scope| (*range, name, scope.module()))
})
.map(|(range, name, ref_module)| {
let old_name = name.clone();
let new_name = edit.make_mut(name.clone());
// if the referenced module is not the same as the target one and has not been seen before, add an import
let import_data = if ref_module.nearest_non_block_module(ctx.db()) != *target_module
&& !visited_modules.contains(&ref_module)
{
visited_modules.insert(ref_module);
let import_scope =
ImportScope::find_insert_use_container(new_name.syntax(), &ctx.sema);
let path = ref_module
.find_use_path_prefixed(
ctx.sema.db,
ModuleDef::Module(*target_module),
ctx.config.insert_use.prefix_kind,
ctx.config.prefer_no_std,
)
.map(|mod_path| {
make::path_concat(mod_path_to_ast(&mod_path), make::path_from_text("Bool"))
});
import_scope.zip(path)
} else {
None
};
FileReferenceWithImport { range, old_name, new_name, import_data }
})
.collect()
}
fn find_assignment_usage(name: &ast::NameLike) -> Option<ast::Expr> {
let bin_expr = name.syntax().ancestors().find_map(ast::BinExpr::cast)?;
if !bin_expr.lhs()?.syntax().descendants().contains(name.syntax()) {
cov_mark::hit!(dont_assign_incorrect_ref);
return None;
}
if let Some(ast::BinaryOp::Assignment { op: None }) = bin_expr.op_kind() {
bin_expr.rhs()
} else {
None
}
}
fn find_negated_usage(name: &ast::NameLike) -> Option<(ast::PrefixExpr, ast::Expr)> {
let prefix_expr = name.syntax().ancestors().find_map(ast::PrefixExpr::cast)?;
if !matches!(prefix_expr.expr()?, ast::Expr::PathExpr(_) | ast::Expr::FieldExpr(_)) {
cov_mark::hit!(dont_overwrite_expression_inside_negation);
return None;
}
if let Some(ast::UnaryOp::Not) = prefix_expr.op_kind() {
let inner_expr = prefix_expr.expr()?;
Some((prefix_expr, inner_expr))
} else {
None
}
}
fn find_record_expr_usage(
name: &ast::NameLike,
got_field: hir::Field,
target_definition: Definition,
) -> Option<(ast::RecordExprField, ast::Expr)> {
let name_ref = name.as_name_ref()?;
let record_field = ast::RecordExprField::for_field_name(name_ref)?;
let initializer = record_field.expr()?;
if let Definition::Field(expected_field) = target_definition {
if got_field != expected_field {
return None;
}
}
Some((record_field, initializer))
}
fn find_record_pat_field_usage(name: &ast::NameLike) -> Option<ast::Pat> {
let record_pat_field = name.syntax().parent().and_then(ast::RecordPatField::cast)?;
let pat = record_pat_field.pat()?;
match pat {
ast::Pat::IdentPat(_) | ast::Pat::LiteralPat(_) | ast::Pat::WildcardPat(_) => Some(pat),
_ => None,
}
}
fn find_assoc_const_usage(name: &ast::NameLike) -> Option<(ast::Type, ast::Expr)> {
let const_ = name.syntax().parent().and_then(ast::Const::cast)?;
if const_.syntax().parent().and_then(ast::AssocItemList::cast).is_none() {
return None;
}
Some((const_.ty()?, const_.body()?))
}
fn find_method_call_expr_usage(name: &ast::NameLike) -> Option<ast::Expr> {
let method_call = name.syntax().ancestors().find_map(ast::MethodCallExpr::cast)?;
let receiver = method_call.receiver()?;
if !receiver.syntax().descendants().contains(name.syntax()) {
return None;
}
Some(receiver)
}
/// Adds the definition of the new enum before the target node.
fn add_enum_def(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
usages: &UsageSearchResult,
target_node: SyntaxNode,
target_module: &hir::Module,
) {
let make_enum_pub = usages
.iter()
.flat_map(|(_, refs)| refs)
.filter_map(|FileReference { name, .. }| {
ctx.sema.scope(name.syntax()).map(|scope| scope.module())
})
.any(|module| module.nearest_non_block_module(ctx.db()) != *target_module);
let enum_def = make_bool_enum(make_enum_pub);
let insert_before = node_to_insert_before(target_node);
let indent = IndentLevel::from_node(&insert_before);
enum_def.reindent_to(indent);
ted::insert_all(
ted::Position::before(&edit.make_syntax_mut(insert_before)),
vec![
enum_def.syntax().clone().into(),
make::tokens::whitespace(&format!("\n\n{indent}")).into(),
],
);
}
/// Finds where to put the new enum definition.
/// Tries to find the ast node at the nearest module or at top-level, otherwise just
/// returns the input node.
fn node_to_insert_before(target_node: SyntaxNode) -> SyntaxNode {
target_node
.ancestors()
.take_while(|it| !matches!(it.kind(), SyntaxKind::MODULE | SyntaxKind::SOURCE_FILE))
.filter(|it| ast::Item::can_cast(it.kind()))
.last()
.unwrap_or(target_node)
}
fn make_bool_enum(make_pub: bool) -> ast::Enum {
let enum_def = make::enum_(
if make_pub { Some(make::visibility_pub()) } else { None },
make::name("Bool"),
make::variant_list(vec![
make::variant(make::name("True"), None),
make::variant(make::name("False"), None),
]),
)
.clone_for_update();
let derive_eq = make::attr_outer(make::meta_token_tree(
make::ext::ident_path("derive"),
make::token_tree(
T!['('],
vec![
NodeOrToken::Token(make::tokens::ident("PartialEq")),
NodeOrToken::Token(make::token(T![,])),
NodeOrToken::Token(make::tokens::single_space()),
NodeOrToken::Token(make::tokens::ident("Eq")),
],
),
))
.clone_for_update();
enum_def.add_attr(derive_eq);
enum_def
}
#[cfg(test)]
mod tests {
use super::*;
use crate::tests::{check_assist, check_assist_not_applicable};
#[test]
fn local_variable_with_usage() {
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = true;
if foo {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = Bool::True;
if foo == Bool::True {
println!("foo");
}
}
"#,
)
}
#[test]
fn local_variable_with_usage_negated() {
cov_mark::check!(replaces_negation);
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = true;
if !foo {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = Bool::True;
if foo == Bool::False {
println!("foo");
}
}
"#,
)
}
#[test]
fn local_variable_with_type_annotation() {
cov_mark::check!(replaces_ty_annotation);
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo: bool = false;
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo: Bool = Bool::False;
}
"#,
)
}
#[test]
fn local_variable_with_non_literal_initializer() {
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = 1 == 2;
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = if 1 == 2 { Bool::True } else { Bool::False };
}
"#,
)
}
#[test]
fn local_variable_binexpr_usage() {
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = false;
let bar = true;
if !foo && bar {
println!("foobar");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = Bool::False;
let bar = true;
if foo == Bool::False && bar {
println!("foobar");
}
}
"#,
)
}
#[test]
fn local_variable_unop_usage() {
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = true;
if *&foo {
println!("foobar");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = Bool::True;
if *&foo == Bool::True {
println!("foobar");
}
}
"#,
)
}
#[test]
fn local_variable_assigned_later() {
cov_mark::check!(replaces_assignment);
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo: bool;
foo = true;
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo: Bool;
foo = Bool::True;
}
"#,
)
}
#[test]
fn local_variable_does_not_apply_recursively() {
check_assist(
bool_to_enum,
r#"
fn main() {
let $0foo = true;
let bar = !foo;
if bar {
println!("bar");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let foo = Bool::True;
let bar = foo == Bool::False;
if bar {
println!("bar");
}
}
"#,
)
}
#[test]
fn local_variable_nested_in_negation() {
cov_mark::check!(dont_overwrite_expression_inside_negation);
check_assist(
bool_to_enum,
r#"
fn main() {
if !"foo".chars().any(|c| {
let $0foo = true;
foo
}) {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
if !"foo".chars().any(|c| {
let foo = Bool::True;
foo == Bool::True
}) {
println!("foo");
}
}
"#,
)
}
#[test]
fn local_variable_non_bool() {
cov_mark::check!(not_applicable_non_bool_local);
check_assist_not_applicable(
bool_to_enum,
r#"
fn main() {
let $0foo = 1;
}
"#,
)
}
#[test]
fn local_variable_cursor_not_on_ident() {
check_assist_not_applicable(
bool_to_enum,
r#"
fn main() {
let foo = $0true;
}
"#,
)
}
#[test]
fn local_variable_non_ident_pat() {
cov_mark::check!(not_applicable_in_non_ident_pat);
check_assist_not_applicable(
bool_to_enum,
r#"
fn main() {
let ($0foo, bar) = (true, false);
}
"#,
)
}
#[test]
fn field_struct_basic() {
cov_mark::check!(replaces_record_expr);
check_assist(
bool_to_enum,
r#"
struct Foo {
$0bar: bool,
baz: bool,
}
fn main() {
let foo = Foo { bar: true, baz: false };
if foo.bar {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
bar: Bool,
baz: bool,
}
fn main() {
let foo = Foo { bar: Bool::True, baz: false };
if foo.bar == Bool::True {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_enum_basic() {
cov_mark::check!(replaces_record_pat);
check_assist(
bool_to_enum,
r#"
enum Foo {
Foo,
Bar { $0bar: bool },
}
fn main() {
let foo = Foo::Bar { bar: true };
if let Foo::Bar { bar: baz } = foo {
if baz {
println!("foo");
}
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
enum Foo {
Foo,
Bar { bar: Bool },
}
fn main() {
let foo = Foo::Bar { bar: Bool::True };
if let Foo::Bar { bar: baz } = foo {
if baz == Bool::True {
println!("foo");
}
}
}
"#,
)
}
#[test]
fn field_enum_cross_file() {
check_assist(
bool_to_enum,
r#"
//- /foo.rs
pub enum Foo {
Foo,
Bar { $0bar: bool },
}
fn foo() {
let foo = Foo::Bar { bar: true };
}
//- /main.rs
use foo::Foo;
mod foo;
fn main() {
let foo = Foo::Bar { bar: false };
}
"#,
r#"
//- /foo.rs
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
pub enum Foo {
Foo,
Bar { bar: Bool },
}
fn foo() {
let foo = Foo::Bar { bar: Bool::True };
}
//- /main.rs
use foo::{Foo, Bool};
mod foo;
fn main() {
let foo = Foo::Bar { bar: Bool::False };
}
"#,
)
}
#[test]
fn field_enum_shorthand() {
cov_mark::check!(replaces_record_pat_shorthand);
check_assist(
bool_to_enum,
r#"
enum Foo {
Foo,
Bar { $0bar: bool },
}
fn main() {
let foo = Foo::Bar { bar: true };
match foo {
Foo::Bar { bar } => {
if bar {
println!("foo");
}
}
_ => (),
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
enum Foo {
Foo,
Bar { bar: Bool },
}
fn main() {
let foo = Foo::Bar { bar: Bool::True };
match foo {
Foo::Bar { bar } => {
if bar == Bool::True {
println!("foo");
}
}
_ => (),
}
}
"#,
)
}
#[test]
fn field_enum_replaces_literal_patterns() {
cov_mark::check!(replaces_literal_pat);
check_assist(
bool_to_enum,
r#"
enum Foo {
Foo,
Bar { $0bar: bool },
}
fn main() {
let foo = Foo::Bar { bar: true };
if let Foo::Bar { bar: true } = foo {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
enum Foo {
Foo,
Bar { bar: Bool },
}
fn main() {
let foo = Foo::Bar { bar: Bool::True };
if let Foo::Bar { bar: Bool::True } = foo {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_enum_keeps_wildcard_patterns() {
check_assist(
bool_to_enum,
r#"
enum Foo {
Foo,
Bar { $0bar: bool },
}
fn main() {
let foo = Foo::Bar { bar: true };
if let Foo::Bar { bar: _ } = foo {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
enum Foo {
Foo,
Bar { bar: Bool },
}
fn main() {
let foo = Foo::Bar { bar: Bool::True };
if let Foo::Bar { bar: _ } = foo {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_union_basic() {
check_assist(
bool_to_enum,
r#"
union Foo {
$0foo: bool,
bar: usize,
}
fn main() {
let foo = Foo { foo: true };
if unsafe { foo.foo } {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
union Foo {
foo: Bool,
bar: usize,
}
fn main() {
let foo = Foo { foo: Bool::True };
if unsafe { foo.foo == Bool::True } {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_negated() {
check_assist(
bool_to_enum,
r#"
struct Foo {
$0bar: bool,
}
fn main() {
let foo = Foo { bar: false };
if !foo.bar {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
bar: Bool,
}
fn main() {
let foo = Foo { bar: Bool::False };
if foo.bar == Bool::False {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_in_mod_properly_indented() {
check_assist(
bool_to_enum,
r#"
mod foo {
struct Bar {
$0baz: bool,
}
impl Bar {
fn new(baz: bool) -> Self {
Self { baz }
}
}
}
"#,
r#"
mod foo {
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Bar {
baz: Bool,
}
impl Bar {
fn new(baz: bool) -> Self {
Self { baz: if baz { Bool::True } else { Bool::False } }
}
}
}
"#,
)
}
#[test]
fn field_multiple_initializations() {
check_assist(
bool_to_enum,
r#"
struct Foo {
$0bar: bool,
baz: bool,
}
fn main() {
let foo1 = Foo { bar: true, baz: false };
let foo2 = Foo { bar: false, baz: false };
if foo1.bar && foo2.bar {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
bar: Bool,
baz: bool,
}
fn main() {
let foo1 = Foo { bar: Bool::True, baz: false };
let foo2 = Foo { bar: Bool::False, baz: false };
if foo1.bar == Bool::True && foo2.bar == Bool::True {
println!("foo");
}
}
"#,
)
}
#[test]
fn field_assigned_to_another() {
cov_mark::check!(dont_assign_incorrect_ref);
check_assist(
bool_to_enum,
r#"
struct Foo {
$0foo: bool,
}
struct Bar {
bar: bool,
}
fn main() {
let foo = Foo { foo: true };
let mut bar = Bar { bar: true };
bar.bar = foo.foo;
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
foo: Bool,
}
struct Bar {
bar: bool,
}
fn main() {
let foo = Foo { foo: Bool::True };
let mut bar = Bar { bar: true };
bar.bar = foo.foo == Bool::True;
}
"#,
)
}
#[test]
fn field_initialized_with_other() {
check_assist(
bool_to_enum,
r#"
struct Foo {
$0foo: bool,
}
struct Bar {
bar: bool,
}
fn main() {
let foo = Foo { foo: true };
let bar = Bar { bar: foo.foo };
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
foo: Bool,
}
struct Bar {
bar: bool,
}
fn main() {
let foo = Foo { foo: Bool::True };
let bar = Bar { bar: foo.foo == Bool::True };
}
"#,
)
}
#[test]
fn field_method_chain_usage() {
check_assist(
bool_to_enum,
r#"
struct Foo {
$0bool: bool,
}
fn main() {
let foo = Foo { bool: true };
foo.bool.then(|| 2);
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
struct Foo {
bool: Bool,
}
fn main() {
let foo = Foo { bool: Bool::True };
(foo.bool == Bool::True).then(|| 2);
}
"#,
)
}
#[test]
fn field_non_bool() {
cov_mark::check!(not_applicable_non_bool_field);
check_assist_not_applicable(
bool_to_enum,
r#"
struct Foo {
$0bar: usize,
}
fn main() {
let foo = Foo { bar: 1 };
}
"#,
)
}
#[test]
fn const_basic() {
check_assist(
bool_to_enum,
r#"
const $0FOO: bool = false;
fn main() {
if FOO {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
const FOO: Bool = Bool::False;
fn main() {
if FOO == Bool::True {
println!("foo");
}
}
"#,
)
}
#[test]
fn const_in_module() {
check_assist(
bool_to_enum,
r#"
fn main() {
if foo::FOO {
println!("foo");
}
}
mod foo {
pub const $0FOO: bool = true;
}
"#,
r#"
use foo::Bool;
fn main() {
if foo::FOO == Bool::True {
println!("foo");
}
}
mod foo {
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
pub const FOO: Bool = Bool::True;
}
"#,
)
}
#[test]
fn const_in_module_with_import() {
check_assist(
bool_to_enum,
r#"
fn main() {
use foo::FOO;
if FOO {
println!("foo");
}
}
mod foo {
pub const $0FOO: bool = true;
}
"#,
r#"
use crate::foo::Bool;
fn main() {
use foo::FOO;
if FOO == Bool::True {
println!("foo");
}
}
mod foo {
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
pub const FOO: Bool = Bool::True;
}
"#,
)
}
#[test]
fn const_cross_file() {
check_assist(
bool_to_enum,
r#"
//- /main.rs
mod foo;
fn main() {
if foo::FOO {
println!("foo");
}
}
//- /foo.rs
pub const $0FOO: bool = true;
"#,
r#"
//- /main.rs
use foo::Bool;
mod foo;
fn main() {
if foo::FOO == Bool::True {
println!("foo");
}
}
//- /foo.rs
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
pub const FOO: Bool = Bool::True;
"#,
)
}
#[test]
fn const_cross_file_and_module() {
check_assist(
bool_to_enum,
r#"
//- /main.rs
mod foo;
fn main() {
use foo::bar;
if bar::BAR {
println!("foo");
}
}
//- /foo.rs
pub mod bar {
pub const $0BAR: bool = false;
}
"#,
r#"
//- /main.rs
use crate::foo::bar::Bool;
mod foo;
fn main() {
use foo::bar;
if bar::BAR == Bool::True {
println!("foo");
}
}
//- /foo.rs
pub mod bar {
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
pub const BAR: Bool = Bool::False;
}
"#,
)
}
#[test]
fn const_in_impl_cross_file() {
check_assist(
bool_to_enum,
r#"
//- /main.rs
mod foo;
struct Foo;
impl Foo {
pub const $0BOOL: bool = true;
}
//- /foo.rs
use crate::Foo;
fn foo() -> bool {
Foo::BOOL
}
"#,
r#"
//- /main.rs
mod foo;
struct Foo;
#[derive(PartialEq, Eq)]
pub enum Bool { True, False }
impl Foo {
pub const BOOL: Bool = Bool::True;
}
//- /foo.rs
use crate::{Foo, Bool};
fn foo() -> bool {
Foo::BOOL == Bool::True
}
"#,
)
}
#[test]
fn const_in_trait() {
check_assist(
bool_to_enum,
r#"
trait Foo {
const $0BOOL: bool;
}
impl Foo for usize {
const BOOL: bool = true;
}
fn main() {
if <usize as Foo>::BOOL {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
trait Foo {
const BOOL: Bool;
}
impl Foo for usize {
const BOOL: Bool = Bool::True;
}
fn main() {
if <usize as Foo>::BOOL == Bool::True {
println!("foo");
}
}
"#,
)
}
#[test]
fn const_non_bool() {
cov_mark::check!(not_applicable_non_bool_const);
check_assist_not_applicable(
bool_to_enum,
r#"
const $0FOO: &str = "foo";
fn main() {
println!("{FOO}");
}
"#,
)
}
#[test]
fn static_basic() {
check_assist(
bool_to_enum,
r#"
static mut $0BOOL: bool = true;
fn main() {
unsafe { BOOL = false };
if unsafe { BOOL } {
println!("foo");
}
}
"#,
r#"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
static mut BOOL: Bool = Bool::True;
fn main() {
unsafe { BOOL = Bool::False };
if unsafe { BOOL == Bool::True } {
println!("foo");
}
}
"#,
)
}
#[test]
fn static_non_bool() {
cov_mark::check!(not_applicable_non_bool_static);
check_assist_not_applicable(
bool_to_enum,
r#"
static mut $0FOO: usize = 0;
fn main() {
if unsafe { FOO } == 0 {
println!("foo");
}
}
"#,
)
}
#[test]
fn not_applicable_to_other_names() {
check_assist_not_applicable(bool_to_enum, "fn $0main() {}")
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/convert_comment_block.rs
+10 -7
View File
@@ -25,9 +25,7 @@ pub(crate) fn convert_comment_block(acc: &mut Assists, ctx: &AssistContext<'_>)
let comment = ctx.find_token_at_offset::<ast::Comment>()?;
// Only allow comments which are alone on their line
if let Some(prev) = comment.syntax().prev_token() {
if Whitespace::cast(prev).filter(|w| w.text().contains('\n')).is_none() {
return None;
}
Whitespace::cast(prev).filter(|w| w.text().contains('\n'))?;
}
match comment.kind().shape {
@@ -78,7 +76,7 @@ fn line_to_block(acc: &mut Assists, comment: ast::Comment) -> Option<()> {
// Establish the target of our edit based on the comments we found
let target = TextRange::new(
comments[0].syntax().text_range().start(),
comments.last().unwrap().syntax().text_range().end(),
comments.last()?.syntax().text_range().end(),
);
acc.add(
@@ -91,8 +89,12 @@ fn line_to_block(acc: &mut Assists, comment: ast::Comment) -> Option<()> {
// contents of each line comment when they're put into the block comment.
let indentation = IndentLevel::from_token(comment.syntax());
let block_comment_body =
comments.into_iter().map(|c| line_comment_text(indentation, c)).join("\n");
let block_comment_body = comments
.into_iter()
.map(|c| line_comment_text(indentation, c))
.collect::<Vec<String>>()
.into_iter()
.join("\n");
let block_prefix =
CommentKind { shape: CommentShape::Block, ..comment.kind() }.prefix();
@@ -160,7 +162,8 @@ pub(crate) fn relevant_line_comments(comment: &ast::Comment) -> Vec<Comment> {
//
// But since such comments aren't idiomatic we're okay with this.
pub(crate) fn line_comment_text(indentation: IndentLevel, comm: ast::Comment) -> String {
let contents_without_prefix = comm.text().strip_prefix(comm.prefix()).unwrap();
let text = comm.text();
let contents_without_prefix = text.strip_prefix(comm.prefix()).unwrap_or(text);
let contents = contents_without_prefix.strip_prefix(' ').unwrap_or(contents_without_prefix);
// Don't add the indentation if the line is empty
src/tools/rust-analyzer/crates/ide-assists/src/handlers/convert_to_guarded_return.rs
+57 -19
View File
@@ -51,22 +51,7 @@ pub(crate) fn convert_to_guarded_return(acc: &mut Assists, ctx: &AssistContext<'
// Check if there is an IfLet that we can handle.
let (if_let_pat, cond_expr) = if is_pattern_cond(cond.clone()) {
let let_ = single_let(cond)?;
match let_.pat() {
Some(ast::Pat::TupleStructPat(pat)) if pat.fields().count() == 1 => {
let path = pat.path()?;
if path.qualifier().is_some() {
return None;
}
let bound_ident = pat.fields().next()?;
if !ast::IdentPat::can_cast(bound_ident.syntax().kind()) {
return None;
}
(Some((path, bound_ident)), let_.expr()?)
}
_ => return None, // Unsupported IfLet.
}
(Some(let_.pat()?), let_.expr()?)
} else {
(None, cond)
};
@@ -136,11 +121,10 @@ pub(crate) fn convert_to_guarded_return(acc: &mut Assists, ctx: &AssistContext<'
};
new_expr.syntax().clone_for_update()
}
Some((path, bound_ident)) => {
Some(pat) => {
// If-let.
let pat = make::tuple_struct_pat(path, once(bound_ident));
let let_else_stmt = make::let_else_stmt(
pat.into(),
pat,
None,
cond_expr,
ast::make::tail_only_block_expr(early_expression),
@@ -442,6 +426,60 @@ fn main() {
);
}
#[test]
fn convert_arbitrary_if_let_patterns() {
check_assist(
convert_to_guarded_return,
r#"
fn main() {
$0if let None = Some(92) {
foo();
}
}
"#,
r#"
fn main() {
let None = Some(92) else { return };
foo();
}
"#,
);
check_assist(
convert_to_guarded_return,
r#"
fn main() {
$0if let [1, x] = [1, 92] {
foo(x);
}
}
"#,
r#"
fn main() {
let [1, x] = [1, 92] else { return };
foo(x);
}
"#,
);
check_assist(
convert_to_guarded_return,
r#"
fn main() {
$0if let (Some(x), None) = (Some(92), None) {
foo(x);
}
}
"#,
r#"
fn main() {
let (Some(x), None) = (Some(92), None) else { return };
foo(x);
}
"#,
);
}
#[test]
fn ignore_already_converted_if() {
check_assist_not_applicable(
src/tools/rust-analyzer/crates/ide-assists/src/handlers/convert_tuple_return_type_to_struct.rs
+886
View File
@@ -0,0 +1,886 @@
use either::Either;
use hir::ModuleDef;
use ide_db::{
assists::{AssistId, AssistKind},
defs::Definition,
helpers::mod_path_to_ast,
imports::insert_use::{insert_use, ImportScope},
search::{FileReference, UsageSearchResult},
source_change::SourceChangeBuilder,
syntax_helpers::node_ext::{for_each_tail_expr, walk_expr},
FxHashSet,
};
use syntax::{
ast::{self, edit::IndentLevel, edit_in_place::Indent, make, HasName},
match_ast, ted, AstNode, SyntaxNode,
};
use crate::assist_context::{AssistContext, Assists};
// Assist: convert_tuple_return_type_to_struct
//
// This converts the return type of a function from a tuple type
// into a tuple struct and updates the body accordingly.
//
// ```
// fn bar() {
// let (a, b, c) = foo();
// }
//
// fn foo() -> ($0u32, u32, u32) {
// (1, 2, 3)
// }
// ```
// ->
// ```
// fn bar() {
// let FooResult(a, b, c) = foo();
// }
//
// struct FooResult(u32, u32, u32);
//
// fn foo() -> FooResult {
// FooResult(1, 2, 3)
// }
// ```
pub(crate) fn convert_tuple_return_type_to_struct(
acc: &mut Assists,
ctx: &AssistContext<'_>,
) -> Option<()> {
let ret_type = ctx.find_node_at_offset::<ast::RetType>()?;
let type_ref = ret_type.ty()?;
let ast::Type::TupleType(tuple_ty) = &type_ref else { return None };
if tuple_ty.fields().any(|field| matches!(field, ast::Type::ImplTraitType(_))) {
return None;
}
let fn_ = ret_type.syntax().parent().and_then(ast::Fn::cast)?;
let fn_def = ctx.sema.to_def(&fn_)?;
let fn_name = fn_.name()?;
let target_module = ctx.sema.scope(fn_.syntax())?.module().nearest_non_block_module(ctx.db());
let target = type_ref.syntax().text_range();
acc.add(
AssistId("convert_tuple_return_type_to_struct", AssistKind::RefactorRewrite),
"Convert tuple return type to tuple struct",
target,
move |edit| {
let ret_type = edit.make_mut(ret_type);
let fn_ = edit.make_mut(fn_);
let usages = Definition::Function(fn_def).usages(&ctx.sema).all();
let struct_name = format!("{}Result", stdx::to_camel_case(&fn_name.to_string()));
let parent = fn_.syntax().ancestors().find_map(<Either<ast::Impl, ast::Trait>>::cast);
add_tuple_struct_def(
edit,
ctx,
&usages,
parent.as_ref().map(|it| it.syntax()).unwrap_or(fn_.syntax()),
tuple_ty,
&struct_name,
&target_module,
);
ted::replace(
ret_type.syntax(),
make::ret_type(make::ty(&struct_name)).syntax().clone_for_update(),
);
if let Some(fn_body) = fn_.body() {
replace_body_return_values(ast::Expr::BlockExpr(fn_body), &struct_name);
}
replace_usages(edit, ctx, &usages, &struct_name, &target_module);
},
)
}
/// Replaces tuple usages with the corresponding tuple struct pattern.
fn replace_usages(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
usages: &UsageSearchResult,
struct_name: &str,
target_module: &hir::Module,
) {
for (file_id, references) in usages.iter() {
edit.edit_file(*file_id);
let refs_with_imports =
augment_references_with_imports(edit, ctx, references, struct_name, target_module);
refs_with_imports.into_iter().rev().for_each(|(name, import_data)| {
if let Some(fn_) = name.syntax().parent().and_then(ast::Fn::cast) {
cov_mark::hit!(replace_trait_impl_fns);
if let Some(ret_type) = fn_.ret_type() {
ted::replace(
ret_type.syntax(),
make::ret_type(make::ty(struct_name)).syntax().clone_for_update(),
);
}
if let Some(fn_body) = fn_.body() {
replace_body_return_values(ast::Expr::BlockExpr(fn_body), struct_name);
}
} else {
// replace tuple patterns
let pats = name
.syntax()
.ancestors()
.find(|node| {
ast::CallExpr::can_cast(node.kind())
|| ast::MethodCallExpr::can_cast(node.kind())
})
.and_then(|node| node.parent())
.and_then(node_to_pats)
.unwrap_or(Vec::new());
let tuple_pats = pats.iter().filter_map(|pat| match pat {
ast::Pat::TuplePat(tuple_pat) => Some(tuple_pat),
_ => None,
});
for tuple_pat in tuple_pats {
ted::replace(
tuple_pat.syntax(),
make::tuple_struct_pat(
make::path_from_text(struct_name),
tuple_pat.fields(),
)
.clone_for_update()
.syntax(),
);
}
}
// add imports across modules where needed
if let Some((import_scope, path)) = import_data {
insert_use(&import_scope, path, &ctx.config.insert_use);
}
})
}
}
fn node_to_pats(node: SyntaxNode) -> Option<Vec<ast::Pat>> {
match_ast! {
match node {
ast::LetStmt(it) => it.pat().map(|pat| vec![pat]),
ast::LetExpr(it) => it.pat().map(|pat| vec![pat]),
ast::MatchExpr(it) => it.match_arm_list().map(|arm_list| {
arm_list.arms().filter_map(|arm| arm.pat()).collect()
}),
_ => None,
}
}
}
fn augment_references_with_imports(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
references: &[FileReference],
struct_name: &str,
target_module: &hir::Module,
) -> Vec<(ast::NameLike, Option<(ImportScope, ast::Path)>)> {
let mut visited_modules = FxHashSet::default();
references
.iter()
.filter_map(|FileReference { name, .. }| {
ctx.sema.scope(name.syntax()).map(|scope| (name, scope.module()))
})
.map(|(name, ref_module)| {
let new_name = edit.make_mut(name.clone());
// if the referenced module is not the same as the target one and has not been seen before, add an import
let import_data = if ref_module.nearest_non_block_module(ctx.db()) != *target_module
&& !visited_modules.contains(&ref_module)
{
visited_modules.insert(ref_module);
let import_scope =
ImportScope::find_insert_use_container(new_name.syntax(), &ctx.sema);
let path = ref_module
.find_use_path_prefixed(
ctx.sema.db,
ModuleDef::Module(*target_module),
ctx.config.insert_use.prefix_kind,
ctx.config.prefer_no_std,
)
.map(|mod_path| {
make::path_concat(
mod_path_to_ast(&mod_path),
make::path_from_text(struct_name),
)
});
import_scope.zip(path)
} else {
None
};
(new_name, import_data)
})
.collect()
}
// Adds the definition of the tuple struct before the parent function.
fn add_tuple_struct_def(
edit: &mut SourceChangeBuilder,
ctx: &AssistContext<'_>,
usages: &UsageSearchResult,
parent: &SyntaxNode,
tuple_ty: &ast::TupleType,
struct_name: &str,
target_module: &hir::Module,
) {
let make_struct_pub = usages
.iter()
.flat_map(|(_, refs)| refs)
.filter_map(|FileReference { name, .. }| {
ctx.sema.scope(name.syntax()).map(|scope| scope.module())
})
.any(|module| module.nearest_non_block_module(ctx.db()) != *target_module);
let visibility = if make_struct_pub { Some(make::visibility_pub()) } else { None };
let field_list = ast::FieldList::TupleFieldList(make::tuple_field_list(
tuple_ty.fields().map(|ty| make::tuple_field(visibility.clone(), ty)),
));
let struct_name = make::name(struct_name);
let struct_def = make::struct_(visibility, struct_name, None, field_list).clone_for_update();
let indent = IndentLevel::from_node(parent);
struct_def.reindent_to(indent);
edit.insert(parent.text_range().start(), format!("{struct_def}\n\n{indent}"));
}
/// Replaces each returned tuple in `body` with the constructor of the tuple struct named `struct_name`.
fn replace_body_return_values(body: ast::Expr, struct_name: &str) {
let mut exprs_to_wrap = Vec::new();
let tail_cb = &mut |e: &_| tail_cb_impl(&mut exprs_to_wrap, e);
walk_expr(&body, &mut |expr| {
if let ast::Expr::ReturnExpr(ret_expr) = expr {
if let Some(ret_expr_arg) = &ret_expr.expr() {
for_each_tail_expr(ret_expr_arg, tail_cb);
}
}
});
for_each_tail_expr(&body, tail_cb);
for ret_expr in exprs_to_wrap {
if let ast::Expr::TupleExpr(tuple_expr) = &ret_expr {
let struct_constructor = make::expr_call(
make::expr_path(make::ext::ident_path(struct_name)),
make::arg_list(tuple_expr.fields()),
)
.clone_for_update();
ted::replace(ret_expr.syntax(), struct_constructor.syntax());
}
}
}
fn tail_cb_impl(acc: &mut Vec<ast::Expr>, e: &ast::Expr) {
match e {
ast::Expr::BreakExpr(break_expr) => {
if let Some(break_expr_arg) = break_expr.expr() {
for_each_tail_expr(&break_expr_arg, &mut |e| tail_cb_impl(acc, e))
}
}
ast::Expr::ReturnExpr(_) => {
// all return expressions have already been handled by the walk loop
}
e => acc.push(e.clone()),
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::tests::{check_assist, check_assist_not_applicable};
#[test]
fn function_basic() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(&'static str, bool) {
("bar", true)
}
"#,
r#"
struct BarResult(&'static str, bool);
fn bar() -> BarResult {
BarResult("bar", true)
}
"#,
)
}
#[test]
fn struct_and_usages_indented() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
mod foo {
pub(crate) fn foo() {
let (bar, baz) = bar();
println!("{bar} {baz}");
}
pub(crate) fn bar() -> $0(usize, bool) {
(42, true)
}
}
"#,
r#"
mod foo {
pub(crate) fn foo() {
let BarResult(bar, baz) = bar();
println!("{bar} {baz}");
}
struct BarResult(usize, bool);
pub(crate) fn bar() -> BarResult {
BarResult(42, true)
}
}
"#,
)
}
#[test]
fn field_usage() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, bool) {
(42, true)
}
fn main() {
let bar_result = bar();
println!("{} {}", bar_result.1, bar().0);
}
"#,
r#"
struct BarResult(usize, bool);
fn bar() -> BarResult {
BarResult(42, true)
}
fn main() {
let bar_result = bar();
println!("{} {}", bar_result.1, bar().0);
}
"#,
)
}
#[test]
fn method_usage() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
struct Foo;
impl Foo {
fn foo(&self, x: usize) -> $0(usize, usize) {
(x, x)
}
}
fn main() {
let foo = Foo {};
let (x, y) = foo.foo(2);
}
"#,
r#"
struct Foo;
struct FooResult(usize, usize);
impl Foo {
fn foo(&self, x: usize) -> FooResult {
FooResult(x, x)
}
}
fn main() {
let foo = Foo {};
let FooResult(x, y) = foo.foo(2);
}
"#,
)
}
#[test]
fn method_usage_within_same_impl() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
struct Foo;
impl Foo {
fn new() -> $0(usize, usize) {
(0, 0)
}
fn foo() {
let (mut foo1, mut foo2) = Self::new();
}
}
"#,
r#"
struct Foo;
struct NewResult(usize, usize);
impl Foo {
fn new() -> NewResult {
NewResult(0, 0)
}
fn foo() {
let NewResult(mut foo1, mut foo2) = Self::new();
}
}
"#,
)
}
#[test]
fn multiple_usages() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, usize) {
(42, 24)
}
fn main() {
let bar_result = bar();
let (foo, b) = bar();
let (b, baz) = bar();
if foo == b && b == baz {
println!("{} {}", bar_result.1, bar().0);
}
}
"#,
r#"
struct BarResult(usize, usize);
fn bar() -> BarResult {
BarResult(42, 24)
}
fn main() {
let bar_result = bar();
let BarResult(foo, b) = bar();
let BarResult(b, baz) = bar();
if foo == b && b == baz {
println!("{} {}", bar_result.1, bar().0);
}
}
"#,
)
}
#[test]
fn usage_match_tuple_pat() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, bool) {
(42, true)
}
fn main() {
match bar() {
x if x.0 == 0 => println!("0"),
(x, false) => println!("{x}"),
(42, true) => println!("bar"),
_ => println!("foo"),
}
}
"#,
r#"
struct BarResult(usize, bool);
fn bar() -> BarResult {
BarResult(42, true)
}
fn main() {
match bar() {
x if x.0 == 0 => println!("0"),
BarResult(x, false) => println!("{x}"),
BarResult(42, true) => println!("bar"),
_ => println!("foo"),
}
}
"#,
)
}
#[test]
fn usage_if_let_tuple_pat() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, bool) {
(42, true)
}
fn main() {
if let (42, true) = bar() {
println!("bar")
}
}
"#,
r#"
struct BarResult(usize, bool);
fn bar() -> BarResult {
BarResult(42, true)
}
fn main() {
if let BarResult(42, true) = bar() {
println!("bar")
}
}
"#,
)
}
#[test]
fn function_nested_outer() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, bool) {
fn foo() -> (usize, bool) {
(42, true)
}
foo()
}
"#,
r#"
struct BarResult(usize, bool);
fn bar() -> BarResult {
fn foo() -> (usize, bool) {
(42, true)
}
foo()
}
"#,
)
}
#[test]
fn function_nested_inner() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> (usize, bool) {
fn foo() -> $0(usize, bool) {
(42, true)
}
foo()
}
"#,
r#"
fn bar() -> (usize, bool) {
struct FooResult(usize, bool);
fn foo() -> FooResult {
FooResult(42, true)
}
foo()
}
"#,
)
}
#[test]
fn trait_impl_and_usage() {
cov_mark::check!(replace_trait_impl_fns);
check_assist(
convert_tuple_return_type_to_struct,
r#"
struct Struct;
trait Foo {
fn foo(&self) -> $0(usize, bool);
}
impl Foo for Struct {
fn foo(&self) -> (usize, bool) {
(0, true)
}
}
fn main() {
let s = Struct {};
let (foo, bar) = s.foo();
let (foo, bar) = Struct::foo(&s);
println!("{foo} {bar}");
}
"#,
r#"
struct Struct;
struct FooResult(usize, bool);
trait Foo {
fn foo(&self) -> FooResult;
}
impl Foo for Struct {
fn foo(&self) -> FooResult {
FooResult(0, true)
}
}
fn main() {
let s = Struct {};
let FooResult(foo, bar) = s.foo();
let FooResult(foo, bar) = Struct::foo(&s);
println!("{foo} {bar}");
}
"#,
)
}
#[test]
fn body_wraps_nested() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn foo() -> $0(u8, usize, u32) {
if true {
match 3 {
0 => (1, 2, 3),
_ => return (4, 5, 6),
}
} else {
(2, 1, 3)
}
}
"#,
r#"
struct FooResult(u8, usize, u32);
fn foo() -> FooResult {
if true {
match 3 {
0 => FooResult(1, 2, 3),
_ => return FooResult(4, 5, 6),
}
} else {
FooResult(2, 1, 3)
}
}
"#,
)
}
#[test]
fn body_wraps_break_and_return() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn foo(mut i: isize) -> (usize, $0u32, u8) {
if i < 0 {
return (0, 0, 0);
}
loop {
if i == 2 {
println!("foo");
break (1, 2, 3);
}
i += 1;
}
}
"#,
r#"
struct FooResult(usize, u32, u8);
fn foo(mut i: isize) -> FooResult {
if i < 0 {
return FooResult(0, 0, 0);
}
loop {
if i == 2 {
println!("foo");
break FooResult(1, 2, 3);
}
i += 1;
}
}
"#,
)
}
#[test]
fn body_doesnt_wrap_identifier() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn foo() -> $0(u8, usize, u32) {
let tuple = (1, 2, 3);
tuple
}
"#,
r#"
struct FooResult(u8, usize, u32);
fn foo() -> FooResult {
let tuple = (1, 2, 3);
tuple
}
"#,
)
}
#[test]
fn body_doesnt_wrap_other_exprs() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar(num: usize) -> (u8, usize, u32) {
(1, num, 3)
}
fn foo() -> $0(u8, usize, u32) {
bar(2)
}
"#,
r#"
fn bar(num: usize) -> (u8, usize, u32) {
(1, num, 3)
}
struct FooResult(u8, usize, u32);
fn foo() -> FooResult {
bar(2)
}
"#,
)
}
#[test]
fn cross_file_and_module() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
//- /main.rs
mod foo;
fn main() {
use foo::bar;
let (bar, baz) = bar::bar();
println!("{}", bar == baz);
}
//- /foo.rs
pub mod bar {
pub fn bar() -> $0(usize, usize) {
(1, 3)
}
}
"#,
r#"
//- /main.rs
use crate::foo::bar::BarResult;
mod foo;
fn main() {
use foo::bar;
let BarResult(bar, baz) = bar::bar();
println!("{}", bar == baz);
}
//- /foo.rs
pub mod bar {
pub struct BarResult(pub usize, pub usize);
pub fn bar() -> BarResult {
BarResult(1, 3)
}
}
"#,
)
}
#[test]
fn does_not_replace_nested_usage() {
check_assist(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(usize, bool) {
(42, true)
}
fn main() {
let ((bar1, bar2), foo) = (bar(), 3);
println!("{bar1} {bar2} {foo}");
}
"#,
r#"
struct BarResult(usize, bool);
fn bar() -> BarResult {
BarResult(42, true)
}
fn main() {
let ((bar1, bar2), foo) = (bar(), 3);
println!("{bar1} {bar2} {foo}");
}
"#,
)
}
#[test]
fn function_with_non_tuple_return_type() {
check_assist_not_applicable(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0usize {
0
}
"#,
)
}
#[test]
fn function_with_impl_type() {
check_assist_not_applicable(
convert_tuple_return_type_to_struct,
r#"
fn bar() -> $0(impl Clone, usize) {
("bar", 0)
}
"#,
)
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/desugar_doc_comment.rs
+7 -7
View File
@@ -33,9 +33,7 @@ pub(crate) fn desugar_doc_comment(acc: &mut Assists, ctx: &AssistContext<'_>) ->
// Only allow comments which are alone on their line
if let Some(prev) = comment.syntax().prev_token() {
if Whitespace::cast(prev).filter(|w| w.text().contains('\n')).is_none() {
return None;
}
Whitespace::cast(prev).filter(|w| w.text().contains('\n'))?;
}
let indentation = IndentLevel::from_token(comment.syntax()).to_string();
@@ -50,7 +48,7 @@ pub(crate) fn desugar_doc_comment(acc: &mut Assists, ctx: &AssistContext<'_>) ->
(
TextRange::new(
comments[0].syntax().text_range().start(),
comments.last().unwrap().syntax().text_range().end(),
comments.last()?.syntax().text_range().end(),
),
Either::Right(comments),
)
@@ -71,9 +69,11 @@ pub(crate) fn desugar_doc_comment(acc: &mut Assists, ctx: &AssistContext<'_>) ->
.map(|l| l.strip_prefix(&indentation).unwrap_or(l))
.join("\n")
}
Either::Right(comments) => {
comments.into_iter().map(|c| line_comment_text(IndentLevel(0), c)).join("\n")
}
Either::Right(comments) => comments
.into_iter()
.map(|cm| line_comment_text(IndentLevel(0), cm))
.collect::<Vec<_>>()
.join("\n"),
};
let hashes = "#".repeat(required_hashes(&text));
src/tools/rust-analyzer/crates/ide-assists/src/handlers/extract_variable.rs
+151 -10
View File
@@ -29,22 +29,31 @@
// }
// ```
pub(crate) fn extract_variable(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
if ctx.has_empty_selection() {
return None;
}
let node = match ctx.covering_element() {
NodeOrToken::Node(it) => it,
NodeOrToken::Token(it) if it.kind() == COMMENT => {
cov_mark::hit!(extract_var_in_comment_is_not_applicable);
let node = if ctx.has_empty_selection() {
if let Some(expr_stmt) = ctx.find_node_at_offset::<ast::ExprStmt>() {
expr_stmt.syntax().clone()
} else if let Some(expr) = ctx.find_node_at_offset::<ast::Expr>() {
expr.syntax().ancestors().find_map(valid_target_expr)?.syntax().clone()
} else {
return None;
}
NodeOrToken::Token(it) => it.parent()?,
} else {
match ctx.covering_element() {
NodeOrToken::Node(it) => it,
NodeOrToken::Token(it) if it.kind() == COMMENT => {
cov_mark::hit!(extract_var_in_comment_is_not_applicable);
return None;
}
NodeOrToken::Token(it) => it.parent()?,
}
};
let node = node.ancestors().take_while(|anc| anc.text_range() == node.text_range()).last()?;
let range = node.text_range();
let to_extract = node
.descendants()
.take_while(|it| ctx.selection_trimmed().contains_range(it.text_range()))
.take_while(|it| range.contains_range(it.text_range()))
.find_map(valid_target_expr)?;
let ty = ctx.sema.type_of_expr(&to_extract).map(TypeInfo::adjusted);
@@ -235,6 +244,138 @@ mod tests {
use super::*;
#[test]
fn test_extract_var_simple_without_select() {
check_assist(
extract_variable,
r#"
fn main() -> i32 {
if true {
1
} else {
2
}$0
}
"#,
r#"
fn main() -> i32 {
let $0var_name = if true {
1
} else {
2
};
var_name
}
"#,
);
check_assist(
extract_variable,
r#"
fn foo() -> i32 { 1 }
fn main() {
foo();$0
}
"#,
r#"
fn foo() -> i32 { 1 }
fn main() {
let $0foo = foo();
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
let a = Some(2);
a.is_some();$0
}
"#,
r#"
fn main() {
let a = Some(2);
let $0is_some = a.is_some();
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
"hello"$0;
}
"#,
r#"
fn main() {
let $0var_name = "hello";
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
1 + 2$0;
}
"#,
r#"
fn main() {
let $0var_name = 1 + 2;
}
"#,
);
check_assist(
extract_variable,
r#"
fn main() {
match () {
() if true => 1,
_ => 2,
};$0
}
"#,
r#"
fn main() {
let $0var_name = match () {
() if true => 1,
_ => 2,
};
}
"#,
);
}
#[test]
fn test_extract_var_unit_expr_without_select_not_applicable() {
check_assist_not_applicable(
extract_variable,
r#"
fn foo() {}
fn main() {
foo()$0;
}
"#,
);
check_assist_not_applicable(
extract_variable,
r#"
fn foo() {
let mut i = 3;
if i >= 0 {
i += 1;
} else {
i -= 1;
}$0
}"#,
);
}
#[test]
fn test_extract_var_simple() {
check_assist(
src/tools/rust-analyzer/crates/ide-assists/src/handlers/generate_function.rs
+6 -2
View File
@@ -404,7 +404,11 @@ fn render(self, is_method: bool) -> FunctionTemplate {
leading_ws,
ret_type: fn_def.ret_type(),
// PANIC: we guarantee we always create a function body with a tail expr
tail_expr: fn_def.body().unwrap().tail_expr().unwrap(),
tail_expr: fn_def
.body()
.expect("generated function should have a body")
.tail_expr()
.expect("function body should have a tail expression"),
should_focus_return_type: self.should_focus_return_type,
fn_def,
trailing_ws,
@@ -683,7 +687,7 @@ fn get_bounds_in_scope<D>(
{
// This function should be only called with `Impl`, `Trait`, or `Function`, for which it's
// infallible to get source ast.
let node = ctx.sema.source(def).unwrap().value;
let node = ctx.sema.source(def).expect("definition's source couldn't be found").value;
let generic_params = node.generic_param_list().into_iter().flat_map(|it| it.generic_params());
let where_clauses = node.where_clause().into_iter().flat_map(|it| it.predicates());
(generic_params, where_clauses)
src/tools/rust-analyzer/crates/ide-assists/src/handlers/generate_mut_trait_impl.rs
+202
View File
@@ -0,0 +1,202 @@
use ide_db::famous_defs::FamousDefs;
use syntax::{
ast::{self, make},
ted, AstNode,
};
use crate::{AssistContext, AssistId, AssistKind, Assists};
// FIXME: Generate proper `index_mut` method body refer to `index` method body may impossible due to the unpredicable case [#15581].
// Here just leave the `index_mut` method body be same as `index` method body, user can modify it manually to meet their need.
// Assist: generate_mut_trait_impl
//
// Adds a IndexMut impl from the `Index` trait.
//
// ```
// # //- minicore: index
// pub enum Axis { X = 0, Y = 1, Z = 2 }
//
// impl<T> core::ops::Index$0<Axis> for [T; 3] {
// type Output = T;
//
// fn index(&self, index: Axis) -> &Self::Output {
// &self[index as usize]
// }
// }
// ```
// ->
// ```
// pub enum Axis { X = 0, Y = 1, Z = 2 }
//
// $0impl<T> core::ops::IndexMut<Axis> for [T; 3] {
// fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
// &self[index as usize]
// }
// }
//
// impl<T> core::ops::Index<Axis> for [T; 3] {
// type Output = T;
//
// fn index(&self, index: Axis) -> &Self::Output {
// &self[index as usize]
// }
// }
// ```
pub(crate) fn generate_mut_trait_impl(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> {
let impl_def = ctx.find_node_at_offset::<ast::Impl>()?.clone_for_update();
let trait_ = impl_def.trait_()?;
if let ast::Type::PathType(trait_path) = trait_.clone() {
let trait_type = ctx.sema.resolve_trait(&trait_path.path()?)?;
let scope = ctx.sema.scope(trait_path.syntax())?;
if trait_type != FamousDefs(&ctx.sema, scope.krate()).core_convert_Index()? {
return None;
}
}
// Index -> IndexMut
let index_trait = impl_def
.syntax()
.descendants()
.filter_map(ast::NameRef::cast)
.find(|it| it.text() == "Index")?;
ted::replace(
index_trait.syntax(),
make::path_segment(make::name_ref("IndexMut")).clone_for_update().syntax(),
);
// index -> index_mut
let trait_method_name = impl_def
.syntax()
.descendants()
.filter_map(ast::Name::cast)
.find(|it| it.text() == "index")?;
ted::replace(trait_method_name.syntax(), make::name("index_mut").clone_for_update().syntax());
let type_alias = impl_def.syntax().descendants().find_map(ast::TypeAlias::cast)?;
ted::remove(type_alias.syntax());
// &self -> &mut self
let mut_self_param = make::mut_self_param();
let self_param: ast::SelfParam =
impl_def.syntax().descendants().find_map(ast::SelfParam::cast)?;
ted::replace(self_param.syntax(), mut_self_param.clone_for_update().syntax());
// &Self::Output -> &mut Self::Output
let ret_type = impl_def.syntax().descendants().find_map(ast::RetType::cast)?;
ted::replace(
ret_type.syntax(),
make::ret_type(make::ty("&mut Self::Output")).clone_for_update().syntax(),
);
let fn_ = impl_def.assoc_item_list()?.assoc_items().find_map(|it| match it {
ast::AssocItem::Fn(f) => Some(f),
_ => None,
})?;
let assoc_list = make::assoc_item_list().clone_for_update();
assoc_list.add_item(syntax::ast::AssocItem::Fn(fn_));
ted::replace(impl_def.assoc_item_list()?.syntax(), assoc_list.syntax());
let target = impl_def.syntax().text_range();
acc.add(
AssistId("generate_mut_trait_impl", AssistKind::Generate),
"Generate `IndexMut` impl from this `Index` trait",
target,
|edit| {
edit.insert(target.start(), format!("$0{}\n\n", impl_def.to_string()));
},
)
}
#[cfg(test)]
mod tests {
use crate::tests::{check_assist, check_assist_not_applicable};
use super::*;
#[test]
fn test_generate_mut_trait_impl() {
check_assist(
generate_mut_trait_impl,
r#"
//- minicore: index
pub enum Axis { X = 0, Y = 1, Z = 2 }
impl<T> core::ops::Index$0<Axis> for [T; 3] {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
&self[index as usize]
}
}
"#,
r#"
pub enum Axis { X = 0, Y = 1, Z = 2 }
$0impl<T> core::ops::IndexMut<Axis> for [T; 3] {
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
&self[index as usize]
}
}
impl<T> core::ops::Index<Axis> for [T; 3] {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
&self[index as usize]
}
}
"#,
);
check_assist(
generate_mut_trait_impl,
r#"
//- minicore: index
pub enum Axis { X = 0, Y = 1, Z = 2 }
impl<T> core::ops::Index$0<Axis> for [T; 3] where T: Copy {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
let var_name = &self[index as usize];
var_name
}
}
"#,
r#"
pub enum Axis { X = 0, Y = 1, Z = 2 }
$0impl<T> core::ops::IndexMut<Axis> for [T; 3] where T: Copy {
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
let var_name = &self[index as usize];
var_name
}
}
impl<T> core::ops::Index<Axis> for [T; 3] where T: Copy {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
let var_name = &self[index as usize];
var_name
}
}
"#,
);
}
#[test]
fn test_generate_mut_trait_impl_not_applicable() {
check_assist_not_applicable(
generate_mut_trait_impl,
r#"
pub trait Index<Idx: ?Sized> {}
impl<T> Index$0<i32> for [T; 3] {}
"#,
);
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/inline_call.rs
+43 -7
View File
@@ -224,7 +224,6 @@ pub(crate) fn inline_call(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<
syntax.text_range(),
|builder| {
let replacement = inline(&ctx.sema, file_id, function, &fn_body, &params, &call_info);
builder.replace_ast(
match call_info.node {
ast::CallableExpr::Call(it) => ast::Expr::CallExpr(it),
@@ -363,16 +362,22 @@ fn inline(
.collect();
if function.self_param(sema.db).is_some() {
let this = || make::name_ref("this").syntax().clone_for_update().first_token().unwrap();
let this = || {
make::name_ref("this")
.syntax()
.clone_for_update()
.first_token()
.expect("NameRef should have had a token.")
};
if let Some(self_local) = params[0].2.as_local(sema.db) {
usages_for_locals(self_local)
.filter_map(|FileReference { name, range, .. }| match name {
ast::NameLike::NameRef(_) => Some(body.syntax().covering_element(range)),
_ => None,
})
.for_each(|it| {
ted::replace(it, &this());
})
.for_each(|usage| {
ted::replace(usage, &this());
});
}
}
@@ -470,7 +475,9 @@ fn inline(
}
} else if let Some(stmt_list) = body.stmt_list() {
ted::insert_all(
ted::Position::after(stmt_list.l_curly_token().unwrap()),
ted::Position::after(
stmt_list.l_curly_token().expect("L_CURLY for StatementList is missing."),
),
let_stmts.into_iter().map(|stmt| stmt.syntax().clone().into()).collect(),
);
}
@@ -481,8 +488,12 @@ fn inline(
};
body.reindent_to(original_indentation);
let no_stmts = body.statements().next().is_none();
match body.tail_expr() {
Some(expr) if !is_async_fn && body.statements().next().is_none() => expr,
Some(expr) if matches!(expr, ast::Expr::ClosureExpr(_)) && no_stmts => {
make::expr_paren(expr).clone_for_update()
}
Some(expr) if !is_async_fn && no_stmts => expr,
_ => match node
.syntax()
.parent()
@@ -1471,6 +1482,31 @@ fn main() {
}
});
}
"#,
);
}
#[test]
fn inline_call_closure_body() {
check_assist(
inline_call,
r#"
fn f() -> impl Fn() -> i32 {
|| 2
}
fn main() {
let _ = $0f()();
}
"#,
r#"
fn f() -> impl Fn() -> i32 {
|| 2
}
fn main() {
let _ = (|| 2)();
}
"#,
);
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/inline_local_variable.rs
+19 -2
View File
@@ -96,8 +96,7 @@ pub(crate) fn inline_local_variable(acc: &mut Assists, ctx: &AssistContext<'_>)
);
let parent = matches!(
usage_parent,
ast::Expr::CallExpr(_)
| ast::Expr::TupleExpr(_)
ast::Expr::TupleExpr(_)
| ast::Expr::ArrayExpr(_)
| ast::Expr::ParenExpr(_)
| ast::Expr::ForExpr(_)
@@ -949,6 +948,24 @@ fn f() {
let S$0 = S;
S;
}
"#,
);
}
#[test]
fn test_inline_closure() {
check_assist(
inline_local_variable,
r#"
fn main() {
let $0f = || 2;
let _ = f();
}
"#,
r#"
fn main() {
let _ = (|| 2)();
}
"#,
);
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/into_to_qualified_from.rs
+71 -3
View File
@@ -52,9 +52,13 @@ pub(crate) fn into_to_qualified_from(acc: &mut Assists, ctx: &AssistContext<'_>)
== FamousDefs(sema, scope.krate()).core_convert_Into()?
{
let type_call = sema.type_of_expr(&method_call.clone().into())?;
let type_call_disp =
type_call.adjusted().display_source_code(db, scope.module().into(), true).ok()?;
let adjusted_tc = type_call.adjusted();
if adjusted_tc.contains_unknown() {
return None;
}
let sc = adjusted_tc.display_source_code(db, scope.module().into(), true).ok()?;
acc.add(
AssistId("into_to_qualified_from", AssistKind::Generate),
"Convert `into` to fully qualified `from`",
@@ -62,7 +66,11 @@ pub(crate) fn into_to_qualified_from(acc: &mut Assists, ctx: &AssistContext<'_>)
|edit| {
edit.replace(
method_call.syntax().text_range(),
format!("{}::from({})", type_call_disp, receiver),
if sc.chars().all(|c| c.is_alphanumeric() || c == ':') {
format!("{}::from({})", sc, receiver)
} else {
format!("<{}>::from({})", sc, receiver)
},
);
},
);
@@ -199,6 +207,66 @@ fn from(a: A) -> Self {
fn main() -> () {
let a: A = A;
let b: C::B = C::B::from(a);
}"#,
)
}
#[test]
fn preceding_type_qualifier() {
check_assist(
into_to_qualified_from,
r#"
//- minicore: from
impl From<(i32,i32)> for [i32;2] {
fn from(value: (i32,i32)) -> Self {
[value.0, value.1]
}
}
fn tuple_to_array() -> [i32; 2] {
(0,1).in$0to()
}"#,
r#"
impl From<(i32,i32)> for [i32;2] {
fn from(value: (i32,i32)) -> Self {
[value.0, value.1]
}
}
fn tuple_to_array() -> [i32; 2] {
<[i32; 2]>::from((0,1))
}"#,
)
}
#[test]
fn type_with_gens() {
check_assist(
into_to_qualified_from,
r#"
//- minicore: from
struct StructA<Gen>(Gen);
impl From<i32> for StructA<i32> {
fn from(value: i32) -> Self {
StructA(value + 1)
}
}
fn main() -> () {
let a: StructA<i32> = 3.in$0to();
}"#,
r#"
struct StructA<Gen>(Gen);
impl From<i32> for StructA<i32> {
fn from(value: i32) -> Self {
StructA(value + 1)
}
}
fn main() -> () {
let a: StructA<i32> = <StructA<i32>>::from(3);
}"#,
)
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/replace_is_method_with_if_let_method.rs
+172
View File
@@ -0,0 +1,172 @@
use syntax::ast::{self, AstNode};
use crate::{utils::suggest_name, AssistContext, AssistId, AssistKind, Assists};
// Assist: replace_is_some_with_if_let_some
//
// Replace `if x.is_some()` with `if let Some(_tmp) = x` or `if x.is_ok()` with `if let Ok(_tmp) = x`.
//
// ```
// fn main() {
// let x = Some(1);
// if x.is_som$0e() {}
// }
// ```
// ->
// ```
// fn main() {
// let x = Some(1);
// if let Some(${0:x}) = x {}
// }
// ```
pub(crate) fn replace_is_method_with_if_let_method(
acc: &mut Assists,
ctx: &AssistContext<'_>,
) -> Option<()> {
let if_expr = ctx.find_node_at_offset::<ast::IfExpr>()?;
let cond = if_expr.condition()?;
let call_expr = match cond {
ast::Expr::MethodCallExpr(call) => call,
_ => return None,
};
let name_ref = call_expr.name_ref()?;
match name_ref.text().as_str() {
"is_some" | "is_ok" => {
let receiver = call_expr.receiver()?;
let var_name = if let ast::Expr::PathExpr(path_expr) = receiver.clone() {
path_expr.path()?.to_string()
} else {
suggest_name::for_variable(&receiver, &ctx.sema)
};
let target = call_expr.syntax().text_range();
let (assist_id, message, text) = if name_ref.text() == "is_some" {
("replace_is_some_with_if_let_some", "Replace `is_some` with `if let Some`", "Some")
} else {
("replace_is_ok_with_if_let_ok", "Replace `is_ok` with `if let Ok`", "Ok")
};
acc.add(AssistId(assist_id, AssistKind::RefactorRewrite), message, target, |edit| {
let var_name = format!("${{0:{}}}", var_name);
let replacement = format!("let {}({}) = {}", text, var_name, receiver);
edit.replace(target, replacement);
})
}
_ => return None,
}
}
#[cfg(test)]
mod tests {
use crate::tests::{check_assist, check_assist_not_applicable};
use super::replace_is_method_with_if_let_method;
#[test]
fn replace_is_some_with_if_let_some_works() {
check_assist(
replace_is_method_with_if_let_method,
r#"
fn main() {
let x = Some(1);
if x.is_som$0e() {}
}
"#,
r#"
fn main() {
let x = Some(1);
if let Some(${0:x}) = x {}
}
"#,
);
check_assist(
replace_is_method_with_if_let_method,
r#"
fn test() -> Option<i32> {
Some(1)
}
fn main() {
if test().is_som$0e() {}
}
"#,
r#"
fn test() -> Option<i32> {
Some(1)
}
fn main() {
if let Some(${0:test}) = test() {}
}
"#,
);
}
#[test]
fn replace_is_some_with_if_let_some_not_applicable() {
check_assist_not_applicable(
replace_is_method_with_if_let_method,
r#"
fn main() {
let x = Some(1);
if x.is_non$0e() {}
}
"#,
);
}
#[test]
fn replace_is_ok_with_if_let_ok_works() {
check_assist(
replace_is_method_with_if_let_method,
r#"
fn main() {
let x = Ok(1);
if x.is_o$0k() {}
}
"#,
r#"
fn main() {
let x = Ok(1);
if let Ok(${0:x}) = x {}
}
"#,
);
check_assist(
replace_is_method_with_if_let_method,
r#"
fn test() -> Result<i32> {
Ok(1)
}
fn main() {
if test().is_o$0k() {}
}
"#,
r#"
fn test() -> Result<i32> {
Ok(1)
}
fn main() {
if let Ok(${0:test}) = test() {}
}
"#,
);
}
#[test]
fn replace_is_ok_with_if_let_ok_not_applicable() {
check_assist_not_applicable(
replace_is_method_with_if_let_method,
r#"
fn main() {
let x = Ok(1);
if x.is_e$0rr() {}
}
"#,
);
}
}
src/tools/rust-analyzer/crates/ide-assists/src/handlers/unmerge_use.rs
+16 -20
View File
@@ -36,29 +36,25 @@ pub(crate) fn unmerge_use(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<
let old_parent_range = use_.syntax().parent()?.text_range();
let new_parent = use_.syntax().parent()?;
// If possible, explain what is going to be done.
let label = match tree.path().and_then(|path| path.first_segment()) {
Some(name) => format!("Unmerge use of `{name}`"),
None => "Unmerge use".into(),
};
let target = tree.syntax().text_range();
acc.add(
AssistId("unmerge_use", AssistKind::RefactorRewrite),
"Unmerge use",
target,
|builder| {
let new_use = make::use_(
use_.visibility(),
make::use_tree(
path,
tree.use_tree_list(),
tree.rename(),
tree.star_token().is_some(),
),
)
.clone_for_update();
acc.add(AssistId("unmerge_use", AssistKind::RefactorRewrite), label, target, |builder| {
let new_use = make::use_(
use_.visibility(),
make::use_tree(path, tree.use_tree_list(), tree.rename(), tree.star_token().is_some()),
)
.clone_for_update();
tree.remove();
ted::insert(Position::after(use_.syntax()), new_use.syntax());
tree.remove();
ted::insert(Position::after(use_.syntax()), new_use.syntax());
builder.replace(old_parent_range, new_parent.to_string());
},
)
builder.replace(old_parent_range, new_parent.to_string());
})
}
fn resolve_full_path(tree: &ast::UseTree) -> Option<ast::Path> {
src/tools/rust-analyzer/crates/ide-assists/src/handlers/unqualify_method_call.rs
+51 -1
View File
@@ -1,3 +1,4 @@
use ide_db::imports::insert_use::ImportScope;
use syntax::{
ast::{self, make, AstNode, HasArgList},
TextRange,
@@ -17,6 +18,8 @@
// ```
// ->
// ```
// use std::ops::Add;
//
// fn main() {
// 1.add(2);
// }
@@ -38,7 +41,7 @@ pub(crate) fn unqualify_method_call(acc: &mut Assists, ctx: &AssistContext<'_>)
let first_arg = args_iter.next()?;
let second_arg = args_iter.next();
_ = path.qualifier()?;
let qualifier = path.qualifier()?;
let method_name = path.segment()?.name_ref()?;
let res = ctx.sema.resolve_path(&path)?;
@@ -76,10 +79,51 @@ pub(crate) fn unqualify_method_call(acc: &mut Assists, ctx: &AssistContext<'_>)
edit.insert(close, ")");
}
edit.replace(replace_comma, format!(".{method_name}("));
add_import(qualifier, ctx, edit);
},
)
}
fn add_import(
qualifier: ast::Path,
ctx: &AssistContext<'_>,
edit: &mut ide_db::source_change::SourceChangeBuilder,
) {
if let Some(path_segment) = qualifier.segment() {
// for `<i32 as std::ops::Add>`
let path_type = path_segment.syntax().children().filter_map(ast::PathType::cast).last();
let import = match path_type {
Some(it) => {
if let Some(path) = it.path() {
path
} else {
return;
}
}
None => qualifier,
};
// in case for `<_>`
if import.coloncolon_token().is_none() {
return;
}
let scope = ide_db::imports::insert_use::ImportScope::find_insert_use_container(
import.syntax(),
&ctx.sema,
);
if let Some(scope) = scope {
let scope = match scope {
ImportScope::File(it) => ImportScope::File(edit.make_mut(it)),
ImportScope::Module(it) => ImportScope::Module(edit.make_mut(it)),
ImportScope::Block(it) => ImportScope::Block(edit.make_mut(it)),
};
ide_db::imports::insert_use::insert_use(&scope, import, &ctx.config.insert_use);
}
}
}
fn needs_parens_as_receiver(expr: &ast::Expr) -> bool {
// Make `(expr).dummy()`
let dummy_call = make::expr_method_call(
@@ -127,6 +171,8 @@ fn unqualify_method_call_trait() {
//- minicore: add
fn f() { <u32 as core::ops::Add>::$0add(2, 2); }"#,
r#"
use core::ops::Add;
fn f() { 2.add(2); }"#,
);
@@ -136,6 +182,8 @@ fn unqualify_method_call_trait() {
//- minicore: add
fn f() { core::ops::Add::$0add(2, 2); }"#,
r#"
use core::ops::Add;
fn f() { 2.add(2); }"#,
);
@@ -179,6 +227,8 @@ fn deref(&self) -> &S { self }
}
fn f() { core::ops::Deref::$0deref(&S); }"#,
r#"
use core::ops::Deref;
struct S;
impl core::ops::Deref for S {
type Target = S;
src/tools/rust-analyzer/crates/ide-assists/src/handlers/unwrap_result_return_type.rs
+20 -4
View File
@@ -123,10 +123,8 @@ fn tail_cb_impl(acc: &mut Vec<ast::Expr>, e: &ast::Expr) {
for_each_tail_expr(&break_expr_arg, &mut |e| tail_cb_impl(acc, e))
}
}
Expr::ReturnExpr(ret_expr) => {
if let Some(ret_expr_arg) = &ret_expr.expr() {
for_each_tail_expr(ret_expr_arg, &mut |e| tail_cb_impl(acc, e));
}
Expr::ReturnExpr(_) => {
// all return expressions have already been handled by the walk loop
}
e => acc.push(e.clone()),
}
@@ -800,6 +798,24 @@ fn foo() -> i32 {
);
}
#[test]
fn wrap_return_in_tail_position() {
check_assist(
unwrap_result_return_type,
r#"
//- minicore: result
fn foo(num: i32) -> $0Result<i32, String> {
return Ok(num)
}
"#,
r#"
fn foo(num: i32) -> i32 {
return num
}
"#,
);
}
#[test]
fn unwrap_result_return_type_simple_with_closure() {
check_assist(
src/tools/rust-analyzer/crates/ide-assists/src/handlers/wrap_return_type_in_result.rs
+20 -4
View File
@@ -98,10 +98,8 @@ fn tail_cb_impl(acc: &mut Vec<ast::Expr>, e: &ast::Expr) {
for_each_tail_expr(&break_expr_arg, &mut |e| tail_cb_impl(acc, e))
}
}
Expr::ReturnExpr(ret_expr) => {
if let Some(ret_expr_arg) = &ret_expr.expr() {
for_each_tail_expr(ret_expr_arg, &mut |e| tail_cb_impl(acc, e));
}
Expr::ReturnExpr(_) => {
// all return expressions have already been handled by the walk loop
}
e => acc.push(e.clone()),
}
@@ -732,6 +730,24 @@ fn foo() -> Result<i32, ${0:_}> {
);
}
#[test]
fn wrap_return_in_tail_position() {
check_assist(
wrap_return_type_in_result,
r#"
//- minicore: result
fn foo(num: i32) -> $0i32 {
return num
}
"#,
r#"
fn foo(num: i32) -> Result<i32, ${0:_}> {
return Ok(num)
}
"#,
);
}
#[test]
fn wrap_return_type_in_result_simple_with_closure() {
check_assist(
src/tools/rust-analyzer/crates/ide-assists/src/lib.rs
+9
View File
@@ -115,6 +115,7 @@ mod handlers {
mod apply_demorgan;
mod auto_import;
mod bind_unused_param;
mod bool_to_enum;
mod change_visibility;
mod convert_bool_then;
mod convert_comment_block;
@@ -124,6 +125,7 @@ mod handlers {
mod convert_let_else_to_match;
mod convert_match_to_let_else;
mod convert_nested_function_to_closure;
mod convert_tuple_return_type_to_struct;
mod convert_tuple_struct_to_named_struct;
mod convert_named_struct_to_tuple_struct;
mod convert_to_guarded_return;
@@ -158,6 +160,7 @@ mod handlers {
mod generate_getter_or_setter;
mod generate_impl;
mod generate_is_empty_from_len;
mod generate_mut_trait_impl;
mod generate_new;
mod generate_delegate_methods;
mod generate_trait_from_impl;
@@ -193,6 +196,7 @@ mod handlers {
mod replace_try_expr_with_match;
mod replace_derive_with_manual_impl;
mod replace_if_let_with_match;
mod replace_is_method_with_if_let_method;
mod replace_method_eager_lazy;
mod replace_arith_op;
mod introduce_named_generic;
@@ -225,8 +229,10 @@ pub(crate) fn all() -> &'static [Handler] {
add_return_type::add_return_type,
add_turbo_fish::add_turbo_fish,
apply_demorgan::apply_demorgan,
apply_demorgan::apply_demorgan_iterator,
auto_import::auto_import,
bind_unused_param::bind_unused_param,
bool_to_enum::bool_to_enum,
change_visibility::change_visibility,
convert_bool_then::convert_bool_then_to_if,
convert_bool_then::convert_if_to_bool_then,
@@ -237,6 +243,7 @@ pub(crate) fn all() -> &'static [Handler] {
convert_iter_for_each_to_for::convert_for_loop_with_for_each,
convert_let_else_to_match::convert_let_else_to_match,
convert_match_to_let_else::convert_match_to_let_else,
convert_tuple_return_type_to_struct::convert_tuple_return_type_to_struct,
convert_named_struct_to_tuple_struct::convert_named_struct_to_tuple_struct,
convert_nested_function_to_closure::convert_nested_function_to_closure,
convert_to_guarded_return::convert_to_guarded_return,
@@ -268,6 +275,7 @@ pub(crate) fn all() -> &'static [Handler] {
generate_function::generate_function,
generate_impl::generate_impl,
generate_impl::generate_trait_impl,
generate_mut_trait_impl::generate_mut_trait_impl,
generate_is_empty_from_len::generate_is_empty_from_len,
generate_new::generate_new,
generate_trait_from_impl::generate_trait_from_impl,
@@ -308,6 +316,7 @@ pub(crate) fn all() -> &'static [Handler] {
replace_derive_with_manual_impl::replace_derive_with_manual_impl,
replace_if_let_with_match::replace_if_let_with_match,
replace_if_let_with_match::replace_match_with_if_let,
replace_is_method_with_if_let_method::replace_is_method_with_if_let_method,
replace_let_with_if_let::replace_let_with_if_let,
replace_method_eager_lazy::replace_with_eager_method,
replace_method_eager_lazy::replace_with_lazy_method,
src/tools/rust-analyzer/crates/ide-assists/src/tests/generated.rs
+136
View File
@@ -244,6 +244,30 @@ fn main() {
)
}
#[test]
fn doctest_apply_demorgan_iterator() {
check_doc_test(
"apply_demorgan_iterator",
r#####"
//- minicore: iterator
fn main() {
let arr = [1, 2, 3];
if !arr.into_iter().$0any(|num| num == 4) {
println!("foo");
}
}
"#####,
r#####"
fn main() {
let arr = [1, 2, 3];
if arr.into_iter().all(|num| num != 4) {
println!("foo");
}
}
"#####,
)
}
#[test]
fn doctest_auto_import() {
check_doc_test(
@@ -280,6 +304,34 @@ fn some_function(x: i32) {
)
}
#[test]
fn doctest_bool_to_enum() {
check_doc_test(
"bool_to_enum",
r#####"
fn main() {
let $0bool = true;
if bool {
println!("foo");
}
}
"#####,
r#####"
#[derive(PartialEq, Eq)]
enum Bool { True, False }
fn main() {
let bool = Bool::True;
if bool == Bool::True {
println!("foo");
}
}
"#####,
)
}
#[test]
fn doctest_change_visibility() {
check_doc_test(
@@ -558,6 +610,33 @@ fn main() {
)
}
#[test]
fn doctest_convert_tuple_return_type_to_struct() {
check_doc_test(
"convert_tuple_return_type_to_struct",
r#####"
fn bar() {
let (a, b, c) = foo();
}
fn foo() -> ($0u32, u32, u32) {
(1, 2, 3)
}
"#####,
r#####"
fn bar() {
let FooResult(a, b, c) = foo();
}
struct FooResult(u32, u32, u32);
fn foo() -> FooResult {
FooResult(1, 2, 3)
}
"#####,
)
}
#[test]
fn doctest_convert_tuple_struct_to_named_struct() {
check_doc_test(
@@ -1459,6 +1538,42 @@ pub fn is_empty(&self) -> bool {
)
}
#[test]
fn doctest_generate_mut_trait_impl() {
check_doc_test(
"generate_mut_trait_impl",
r#####"
//- minicore: index
pub enum Axis { X = 0, Y = 1, Z = 2 }
impl<T> core::ops::Index$0<Axis> for [T; 3] {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
&self[index as usize]
}
}
"#####,
r#####"
pub enum Axis { X = 0, Y = 1, Z = 2 }
$0impl<T> core::ops::IndexMut<Axis> for [T; 3] {
fn index_mut(&mut self, index: Axis) -> &mut Self::Output {
&self[index as usize]
}
}
impl<T> core::ops::Index<Axis> for [T; 3] {
type Output = T;
fn index(&self, index: Axis) -> &Self::Output {
&self[index as usize]
}
}
"#####,
)
}
#[test]
fn doctest_generate_new() {
check_doc_test(
@@ -2479,6 +2594,25 @@ fn handle(action: Action) {
)
}
#[test]
fn doctest_replace_is_some_with_if_let_some() {
check_doc_test(
"replace_is_some_with_if_let_some",
r#####"
fn main() {
let x = Some(1);
if x.is_som$0e() {}
}
"#####,
r#####"
fn main() {
let x = Some(1);
if let Some(${0:x}) = x {}
}
"#####,
)
}
#[test]
fn doctest_replace_let_with_if_let() {
check_doc_test(
@@ -2850,6 +2984,8 @@ fn main() {
mod std { pub mod ops { pub trait Add { fn add(self, _: Self) {} } impl Add for i32 {} } }
"#####,
r#####"
use std::ops::Add;
fn main() {
1.add(2);
}
src/tools/rust-analyzer/crates/ide-completion/src/completions/flyimport.rs
+7 -5
View File
@@ -13,10 +13,9 @@
TypeLocation,
},
render::{render_resolution_with_import, render_resolution_with_import_pat, RenderContext},
Completions,
};
use super::Completions;
// Feature: Completion With Autoimport
//
// When completing names in the current scope, proposes additional imports from other modules or crates,
@@ -377,9 +376,12 @@ fn import_assets_for_path(
&ctx.sema,
ctx.token.parent()?,
)?;
if fuzzy_name_length < 3 {
cov_mark::hit!(flyimport_exact_on_short_path);
assets_for_path.path_fuzzy_name_to_exact(false);
if fuzzy_name_length == 0 {
// nothing matches the empty string exactly, but we still compute assoc items in this case
assets_for_path.path_fuzzy_name_to_exact();
} else if fuzzy_name_length < 3 {
cov_mark::hit!(flyimport_prefix_on_short_path);
assets_for_path.path_fuzzy_name_to_prefix();
}
Some(assets_for_path)
}
src/tools/rust-analyzer/crates/ide-completion/src/config.rs
+1
View File
@@ -14,6 +14,7 @@ pub struct CompletionConfig {
pub enable_imports_on_the_fly: bool,
pub enable_self_on_the_fly: bool,
pub enable_private_editable: bool,
pub full_function_signatures: bool,
pub callable: Option<CallableSnippets>,
pub snippet_cap: Option<SnippetCap>,
pub insert_use: InsertUseConfig,
src/tools/rust-analyzer/crates/ide-completion/src/item.rs
+1 -1
View File
@@ -89,7 +89,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
let mut s = f.debug_struct("CompletionItem");
s.field("label", &self.label).field("source_range", &self.source_range);
if self.text_edit.len() == 1 {
let atom = &self.text_edit.iter().next().unwrap();
let atom = self.text_edit.iter().next().unwrap();
s.field("delete", &atom.delete);
s.field("insert", &atom.insert);
} else {
src/tools/rust-analyzer/crates/ide-completion/src/lib.rs
+22
View File
@@ -169,6 +169,28 @@ pub fn completions(
return Some(completions.into());
}
// when the user types a bare `_` (that is it does not belong to an identifier)
// the user might just wanted to type a `_` for type inference or pattern discarding
// so try to suppress completions in those cases
if trigger_character == Some('_') && ctx.original_token.kind() == syntax::SyntaxKind::UNDERSCORE
{
if let CompletionAnalysis::NameRef(NameRefContext {
kind:
NameRefKind::Path(
path_ctx @ PathCompletionCtx {
kind: PathKind::Type { .. } | PathKind::Pat { .. },
..
},
),
..
}) = analysis
{
if path_ctx.is_trivial_path() {
return None;
}
}
}
{
let acc = &mut completions;
src/tools/rust-analyzer/crates/ide-completion/src/render/function.rs
+21 -1
View File
@@ -98,9 +98,14 @@ fn render(
_ => (),
}
let detail = if ctx.completion.config.full_function_signatures {
detail_full(db, func)
} else {
detail(db, func)
};
item.set_documentation(ctx.docs(func))
.set_deprecated(ctx.is_deprecated(func) || ctx.is_deprecated_assoc_item(func))
.detail(detail(db, func))
.detail(detail)
.lookup_by(name.unescaped().to_smol_str());
match ctx.completion.config.snippet_cap {
@@ -263,6 +268,21 @@ fn detail(db: &dyn HirDatabase, func: hir::Function) -> String {
detail
}
fn detail_full(db: &dyn HirDatabase, func: hir::Function) -> String {
let signature = format!("{}", func.display(db));
let mut detail = String::with_capacity(signature.len());
for segment in signature.split_whitespace() {
if !detail.is_empty() {
detail.push(' ');
}
detail.push_str(segment);
}
detail
}
fn params_display(db: &dyn HirDatabase, func: hir::Function) -> String {
if let Some(self_param) = func.self_param(db) {
let assoc_fn_params = func.assoc_fn_params(db);
src/tools/rust-analyzer/crates/ide-completion/src/tests.rs
+1
View File
@@ -64,6 +64,7 @@ union Union { field: i32 }
enable_imports_on_the_fly: true,
enable_self_on_the_fly: true,
enable_private_editable: false,
full_function_signatures: false,
callable: Some(CallableSnippets::FillArguments),
snippet_cap: SnippetCap::new(true),
prefer_no_std: false,
src/tools/rust-analyzer/crates/ide-completion/src/tests/flyimport.rs
+66 -10
View File
@@ -116,19 +116,47 @@ fn main() {
}
#[test]
fn short_paths_are_ignored() {
cov_mark::check!(flyimport_exact_on_short_path);
fn short_paths_are_prefix_matched() {
cov_mark::check!(flyimport_prefix_on_short_path);
check(
r#"
//- /lib.rs crate:dep
pub struct Bar;
pub struct Barc;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
pub mod some_module {
pub struct Bar;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
}
//- /main.rs crate:main deps:dep
fn main() {
Rc$0
}
"#,
expect![[r#"
st Rc (use dep::Rc)
st Rcar (use dep::Rcar)
st Rc (use dep::some_module::Rc)
st Rcar (use dep::some_module::Rcar)
"#]],
);
check(
r#"
//- /lib.rs crate:dep
pub struct Barc;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
pub mod some_module {
pub struct Bar;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
}
//- /main.rs crate:main deps:dep
@@ -137,8 +165,36 @@ fn main() {
}
"#,
expect![[r#"
ct RC (use dep::RC)
st Rc (use dep::Rc)
st Rcar (use dep::Rcar)
ct RC (use dep::some_module::RC)
st Rc (use dep::some_module::Rc)
st Rcar (use dep::some_module::Rcar)
"#]],
);
check(
r#"
//- /lib.rs crate:dep
pub struct Barc;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
pub mod some_module {
pub struct Bar;
pub struct Rcar;
pub struct Rc;
pub const RC: () = ();
}
//- /main.rs crate:main deps:dep
fn main() {
RC$0
}
"#,
expect![[r#"
ct RC (use dep::RC)
ct RC (use dep::some_module::RC)
"#]],
);
}
@@ -841,8 +897,8 @@ fn main() {
TES$0
}"#,
expect![[r#"
ct TEST_CONST (use foo::TEST_CONST)
"#]],
ct TEST_CONST (use foo::TEST_CONST)
"#]],
);
check(
@@ -858,9 +914,9 @@ fn main() {
tes$0
}"#,
expect![[r#"
ct TEST_CONST (use foo::TEST_CONST)
fn test_function() (use foo::test_function) fn() -> i32
"#]],
ct TEST_CONST (use foo::TEST_CONST)
fn test_function() (use foo::test_function) fn() -> i32
"#]],
);
check(
@@ -873,9 +929,9 @@ pub fn test_function() -> i32 {
}
fn main() {
Te$0
Tes$0
}"#,
expect![[]],
expect![""],
);
}
src/tools/rust-analyzer/crates/ide-completion/src/tests/special.rs
+180 -2
View File
@@ -2,10 +2,15 @@
use expect_test::{expect, Expect};
use crate::tests::{
check_edit, completion_list, completion_list_no_kw, completion_list_with_trigger_character,
use crate::{
tests::{
check_edit, completion_list, completion_list_no_kw, completion_list_with_trigger_character,
},
CompletionItemKind,
};
use super::{do_completion_with_config, TEST_CONFIG};
fn check_no_kw(ra_fixture: &str, expect: Expect) {
let actual = completion_list_no_kw(ra_fixture);
expect.assert_eq(&actual)
@@ -1303,3 +1308,176 @@ struct Foo<T: PartialOrd
"#,
);
}
fn check_signatures(src: &str, kind: CompletionItemKind, reduced: Expect, full: Expect) {
const FULL_SIGNATURES_CONFIG: crate::CompletionConfig = {
let mut x = TEST_CONFIG;
x.full_function_signatures = true;
x
};
// reduced signature
let completion = do_completion_with_config(TEST_CONFIG, src, kind);
assert!(completion[0].detail.is_some());
reduced.assert_eq(completion[0].detail.as_ref().unwrap());
// full signature
let completion = do_completion_with_config(FULL_SIGNATURES_CONFIG, src, kind);
assert!(completion[0].detail.is_some());
full.assert_eq(completion[0].detail.as_ref().unwrap());
}
#[test]
fn respects_full_function_signatures() {
check_signatures(
r#"
pub fn foo<'x, T>(x: &'x mut T) -> u8 where T: Clone, { 0u8 }
fn main() { fo$0 }
"#,
CompletionItemKind::SymbolKind(ide_db::SymbolKind::Function),
expect!("fn(&mut T) -> u8"),
expect!("pub fn foo<'x, T>(x: &'x mut T) -> u8 where T: Clone,"),
);
check_signatures(
r#"
struct Foo;
struct Bar;
impl Bar {
pub const fn baz(x: Foo) -> ! { loop {} };
}
fn main() { Bar::b$0 }
"#,
CompletionItemKind::SymbolKind(ide_db::SymbolKind::Function),
expect!("const fn(Foo) -> !"),
expect!("pub const fn baz(x: Foo) -> !"),
);
check_signatures(
r#"
struct Foo;
struct Bar;
impl Bar {
pub const fn baz<'foo>(&'foo mut self, x: &'foo Foo) -> ! { loop {} };
}
fn main() {
let mut bar = Bar;
bar.b$0
}
"#,
CompletionItemKind::Method,
expect!("const fn(&'foo mut self, &Foo) -> !"),
expect!("pub const fn baz<'foo>(&'foo mut self, x: &'foo Foo) -> !"),
);
}
#[test]
fn skips_underscore() {
check_with_trigger_character(
r#"
fn foo(_$0) { }
"#,
Some('_'),
expect![[r#""#]],
);
check_with_trigger_character(
r#"
fn foo(_: _$0) { }
"#,
Some('_'),
expect![[r#""#]],
);
check_with_trigger_character(
r#"
fn foo<T>() {
foo::<_$0>();
}
"#,
Some('_'),
expect![[r#""#]],
);
// underscore expressions are fine, they are invalid so the user definitely meant to type an
// underscored name here
check_with_trigger_character(
r#"
fn foo() {
_$0
}
"#,
Some('_'),
expect![[r#"
fn foo() fn()
bt u32
kw const
kw crate::
kw enum
kw extern
kw false
kw fn
kw for
kw if
kw if let
kw impl
kw let
kw loop
kw match
kw mod
kw return
kw self::
kw static
kw struct
kw trait
kw true
kw type
kw union
kw unsafe
kw use
kw while
kw while let
sn macro_rules
sn pd
sn ppd
"#]],
);
}
#[test]
fn no_skip_underscore_ident() {
check_with_trigger_character(
r#"
fn foo(a_$0) { }
"#,
Some('_'),
expect![[r#"
kw mut
kw ref
"#]],
);
check_with_trigger_character(
r#"
fn foo(_: a_$0) { }
"#,
Some('_'),
expect![[r#"
bt u32
kw crate::
kw self::
"#]],
);
check_with_trigger_character(
r#"
fn foo<T>() {
foo::<a_$0>();
}
"#,
Some('_'),
expect![[r#"
tp T
bt u32
kw crate::
kw self::
"#]],
);
}
src/tools/rust-analyzer/crates/ide-db/src/defs.rs
+2 -2
View File
@@ -161,8 +161,8 @@ pub fn classify_node(
ast::AwaitExpr(await_expr) => OperatorClass::classify_await(sema, &await_expr).map(IdentClass::Operator),
ast::BinExpr(bin_expr) => OperatorClass::classify_bin(sema, &bin_expr).map(IdentClass::Operator),
ast::IndexExpr(index_expr) => OperatorClass::classify_index(sema, &index_expr).map(IdentClass::Operator),
ast::PrefixExpr(prefix_expr) => OperatorClass::classify_prefix(sema,&prefix_expr).map(IdentClass::Operator),
ast::TryExpr(try_expr) => OperatorClass::classify_try(sema,&try_expr).map(IdentClass::Operator),
ast::PrefixExpr(prefix_expr) => OperatorClass::classify_prefix(sema, &prefix_expr).map(IdentClass::Operator),
ast::TryExpr(try_expr) => OperatorClass::classify_try(sema, &try_expr).map(IdentClass::Operator),
_ => None,
}
}
src/tools/rust-analyzer/crates/ide-db/src/famous_defs.rs
+4
View File
@@ -54,6 +54,10 @@ pub fn core_convert_Into(&self) -> Option<Trait> {
self.find_trait("core:convert:Into")
}
pub fn core_convert_Index(&self) -> Option<Trait> {
self.find_trait("core:ops:Index")
}
pub fn core_option_Option(&self) -> Option<Enum> {
self.find_enum("core:option:Option")
}
src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs
+7424 -1079
View File
@@ -9,12 +9,18 @@ pub struct LintGroup {
pub lint: Lint,
pub children: &'static [&'static str],
}
pub const DEFAULT_LINTS: &[Lint] = &[
Lint {
label: "absolute_paths_not_starting_with_crate",
description: r##"fully qualified paths that start with a module name instead of `crate`, `self`, or an extern crate name"##,
},
Lint { label: "ambiguous_associated_items", description: r##"ambiguous associated items"## },
Lint {
label: "ambiguous_glob_imports",
description: r##"detects certain glob imports that require reporting an ambiguity error"##,
},
Lint { label: "ambiguous_glob_reexports", description: r##"ambiguous glob re-exports"## },
Lint { label: "anonymous_parameters", description: r##"detects anonymous parameters"## },
Lint { label: "arithmetic_overflow", description: r##"arithmetic operation overflows"## },
Lint {
@@ -25,6 +31,10 @@ pub struct LintGroup {
label: "asm_sub_register",
description: r##"using only a subset of a register for inline asm inputs"##,
},
Lint {
label: "async_fn_in_trait",
description: r##"use of `async fn` in definition of a publicly-reachable trait"##,
},
Lint { label: "bad_asm_style", description: r##"incorrect use of inline assembly"## },
Lint {
label: "bare_trait_objects",
@@ -39,6 +49,10 @@ pub struct LintGroup {
label: "break_with_label_and_loop",
description: r##"`break` expression with label and unlabeled loop as value expression"##,
},
Lint {
label: "byte_slice_in_packed_struct_with_derive",
description: r##"`[u8]` or `str` used in a packed struct with `derive`"##,
},
Lint {
label: "cenum_impl_drop_cast",
description: r##"a C-like enum implementing Drop is cast"##,
@@ -51,6 +65,10 @@ pub struct LintGroup {
label: "coherence_leak_check",
description: r##"distinct impls distinguished only by the leak-check code"##,
},
Lint {
label: "coinductive_overlap_in_coherence",
description: r##"impls that are not considered to overlap may be considered to overlap in the future"##,
},
Lint {
label: "conflicting_repr_hints",
description: r##"conflicts between `#[repr(..)]` hints that were previously accepted and used in practice"##,
@@ -59,10 +77,6 @@ pub struct LintGroup {
label: "confusable_idents",
description: r##"detects visually confusable pairs between identifiers"##,
},
Lint {
label: "const_err",
description: r##"constant evaluation encountered erroneous expression"##,
},
Lint {
label: "const_evaluatable_unchecked",
description: r##"detects a generic constant is used in a type without a emitting a warning"##,
@@ -71,12 +85,24 @@ pub struct LintGroup {
label: "const_item_mutation",
description: r##"detects attempts to mutate a `const` item"##,
},
Lint {
label: "const_patterns_without_partial_eq",
description: r##"constant in pattern does not implement `PartialEq`"##,
},
Lint { label: "dead_code", description: r##"detect unused, unexported items"## },
Lint { label: "deprecated", description: r##"detects use of deprecated items"## },
Lint {
label: "deprecated_cfg_attr_crate_type_name",
description: r##"detects usage of `#![cfg_attr(..., crate_type/crate_name = "...")]`"##,
},
Lint {
label: "deprecated_in_future",
description: r##"detects use of items that will be deprecated in a future version"##,
},
Lint {
label: "deprecated_where_clause_location",
description: r##"deprecated where clause location"##,
},
Lint {
label: "deref_into_dyn_supertrait",
description: r##"`Deref` implementation usage with a supertrait trait object for output might be shadowed in the future"##,
@@ -89,10 +115,23 @@ pub struct LintGroup {
label: "drop_bounds",
description: r##"bounds of the form `T: Drop` are most likely incorrect"##,
},
Lint {
label: "dropping_copy_types",
description: r##"calls to `std::mem::drop` with a value that implements Copy"##,
},
Lint {
label: "dropping_references",
description: r##"calls to `std::mem::drop` with a reference instead of an owned value"##,
},
Lint { label: "duplicate_macro_attributes", description: r##"duplicated attribute"## },
Lint {
label: "dyn_drop",
description: r##"trait objects of the form `dyn Drop` are useless"##,
},
Lint {
label: "elided_lifetimes_in_associated_constant",
description: r##"elided lifetimes cannot be used in associated constants in impls"##,
},
Lint {
label: "elided_lifetimes_in_paths",
description: r##"hidden lifetime parameters in types are deprecated"##,
@@ -113,14 +152,38 @@ pub struct LintGroup {
label: "exported_private_dependencies",
description: r##"public interface leaks type from a private dependency"##,
},
Lint {
label: "ffi_unwind_calls",
description: r##"call to foreign functions or function pointers with FFI-unwind ABI"##,
},
Lint {
label: "for_loops_over_fallibles",
description: r##"for-looping over an `Option` or a `Result`, which is more clearly expressed as an `if let`"##,
},
Lint { label: "forbidden_lint_groups", description: r##"applying forbid to lint-groups"## },
Lint {
label: "forgetting_copy_types",
description: r##"calls to `std::mem::forget` with a value that implements Copy"##,
},
Lint {
label: "forgetting_references",
description: r##"calls to `std::mem::forget` with a reference instead of an owned value"##,
},
Lint {
label: "function_item_references",
description: r##"suggest casting to a function pointer when attempting to take references to function items"##,
},
Lint {
label: "future_incompatible",
description: r##"lint group for: forbidden-lint-groups, illegal-floating-point-literal-pattern, private-in-public, pub-use-of-private-extern-crate, invalid-type-param-default, const-err, unaligned-references, patterns-in-fns-without-body, missing-fragment-specifier, late-bound-lifetime-arguments, order-dependent-trait-objects, coherence-leak-check, unstable-name-collisions, where-clauses-object-safety, proc-macro-derive-resolution-fallback, macro-expanded-macro-exports-accessed-by-absolute-paths, ill-formed-attribute-input, conflicting-repr-hints, ambiguous-associated-items, mutable-borrow-reservation-conflict, indirect-structural-match, pointer-structural-match, nontrivial-structural-match, soft-unstable, cenum-impl-drop-cast, const-evaluatable-unchecked, uninhabited-static, unsupported-naked-functions, invalid-doc-attributes, semicolon-in-expressions-from-macros, legacy-derive-helpers, proc-macro-back-compat, unsupported-calling-conventions, deref-into-dyn-supertrait"##,
description: r##"lint group for: deref-into-dyn-supertrait, ambiguous-associated-items, ambiguous-glob-imports, byte-slice-in-packed-struct-with-derive, cenum-impl-drop-cast, coherence-leak-check, coinductive-overlap-in-coherence, conflicting-repr-hints, const-evaluatable-unchecked, const-patterns-without-partial-eq, deprecated-cfg-attr-crate-type-name, elided-lifetimes-in-associated-constant, forbidden-lint-groups, ill-formed-attribute-input, illegal-floating-point-literal-pattern, implied-bounds-entailment, indirect-structural-match, invalid-alignment, invalid-doc-attributes, invalid-type-param-default, late-bound-lifetime-arguments, legacy-derive-helpers, macro-expanded-macro-exports-accessed-by-absolute-paths, missing-fragment-specifier, nontrivial-structural-match, order-dependent-trait-objects, patterns-in-fns-without-body, pointer-structural-match, proc-macro-back-compat, proc-macro-derive-resolution-fallback, pub-use-of-private-extern-crate, repr-transparent-external-private-fields, semicolon-in-expressions-from-macros, soft-unstable, suspicious-auto-trait-impls, uninhabited-static, unstable-name-collisions, unstable-syntax-pre-expansion, unsupported-calling-conventions, where-clauses-object-safety"##,
},
Lint {
label: "fuzzy_provenance_casts",
description: r##"a fuzzy integer to pointer cast is used"##,
},
Lint {
label: "hidden_glob_reexports",
description: r##"name introduced by a private item shadows a name introduced by a public glob re-export"##,
},
Lint {
label: "ill_formed_attribute_input",
@@ -130,6 +193,10 @@ pub struct LintGroup {
label: "illegal_floating_point_literal_pattern",
description: r##"floating-point literals cannot be used in patterns"##,
},
Lint {
label: "implied_bounds_entailment",
description: r##"impl method assumes more implied bounds than its corresponding trait method"##,
},
Lint {
label: "improper_ctypes",
description: r##"proper use of libc types in foreign modules"##,
@@ -155,6 +222,14 @@ pub struct LintGroup {
label: "inline_no_sanitize",
description: r##"detects incompatible use of `#[inline(always)]` and `#[no_sanitize(...)]`"##,
},
Lint {
label: "internal_features",
description: r##"internal features are not supposed to be used"##,
},
Lint {
label: "invalid_alignment",
description: r##"raw pointers must be aligned before dereferencing"##,
},
Lint {
label: "invalid_atomic_ordering",
description: r##"usage of invalid atomic ordering in atomic operations and memory fences"##,
@@ -163,6 +238,26 @@ pub struct LintGroup {
label: "invalid_doc_attributes",
description: r##"detects invalid `#[doc(...)]` attributes"##,
},
Lint {
label: "invalid_from_utf8",
description: r##"using a non UTF-8 literal in `std::str::from_utf8`"##,
},
Lint {
label: "invalid_from_utf8_unchecked",
description: r##"using a non UTF-8 literal in `std::str::from_utf8_unchecked`"##,
},
Lint {
label: "invalid_macro_export_arguments",
description: r##""invalid_parameter" isn't a valid argument for `#[macro_export]`"##,
},
Lint {
label: "invalid_nan_comparisons",
description: r##"detects invalid floating point NaN comparisons"##,
},
Lint {
label: "invalid_reference_casting",
description: r##"casts of `&T` to `&mut T` without interior mutability"##,
},
Lint {
label: "invalid_type_param_default",
description: r##"type parameter default erroneously allowed in invalid location"##,
@@ -188,6 +283,26 @@ pub struct LintGroup {
label: "legacy_derive_helpers",
description: r##"detects derive helper attributes that are used before they are introduced"##,
},
Lint {
label: "let_underscore",
description: r##"lint group for: let-underscore-drop, let-underscore-lock"##,
},
Lint {
label: "let_underscore_drop",
description: r##"non-binding let on a type that implements `Drop`"##,
},
Lint {
label: "let_underscore_lock",
description: r##"non-binding let on a synchronization lock"##,
},
Lint {
label: "long_running_const_eval",
description: r##"detects long const eval operations"##,
},
Lint {
label: "lossy_provenance_casts",
description: r##"a lossy pointer to integer cast is used"##,
},
Lint {
label: "macro_expanded_macro_exports_accessed_by_absolute_paths",
description: r##"macro-expanded `macro_export` macros from the current crate cannot be referred to by absolute paths"##,
@@ -196,6 +311,10 @@ pub struct LintGroup {
label: "macro_use_extern_crate",
description: r##"the `#[macro_use]` attribute is now deprecated in favor of using macros via the module system"##,
},
Lint {
label: "map_unit_fn",
description: r##"`Iterator::map` call that discard the iterator's values"##,
},
Lint {
label: "meta_variable_misuse",
description: r##"possible meta-variable misuse at macro definition"##,
@@ -221,17 +340,21 @@ pub struct LintGroup {
label: "mixed_script_confusables",
description: r##"detects Unicode scripts whose mixed script confusables codepoints are solely used"##,
},
Lint {
label: "multiple_supertrait_upcastable",
description: r##"detect when an object-safe trait has multiple supertraits"##,
},
Lint {
label: "must_not_suspend",
description: r##"use of a `#[must_not_suspend]` value across a yield point"##,
},
Lint {
label: "mutable_borrow_reservation_conflict",
description: r##"reservation of a two-phased borrow conflicts with other shared borrows"##,
label: "mutable_transmutes",
description: r##"transmuting &T to &mut T is undefined behavior, even if the reference is unused"##,
},
Lint {
label: "mutable_transmutes",
description: r##"mutating transmuted &mut T from &T may cause undefined behavior"##,
label: "named_arguments_used_positionally",
description: r##"named arguments in format used positionally"##,
},
Lint { label: "named_asm_labels", description: r##"named labels in inline assembly"## },
Lint {
@@ -276,6 +399,10 @@ pub struct LintGroup {
label: "noop_method_call",
description: r##"detects the use of well-known noop methods"##,
},
Lint {
label: "opaque_hidden_inferred_bound",
description: r##"detects the use of nested `impl Trait` types in associated type bounds that are not general enough"##,
},
Lint {
label: "order_dependent_trait_objects",
description: r##"trait-object types were treated as different depending on marker-trait order"##,
@@ -295,8 +422,12 @@ pub struct LintGroup {
description: r##"pointers are not structural-match"##,
},
Lint {
label: "private_in_public",
description: r##"detect private items in public interfaces not caught by the old implementation"##,
label: "private_bounds",
description: r##"private type in secondary interface of an item"##,
},
Lint {
label: "private_interfaces",
description: r##"private type in primary interface of an item"##,
},
Lint {
label: "proc_macro_back_compat",
@@ -314,13 +445,21 @@ pub struct LintGroup {
label: "redundant_semicolons",
description: r##"detects unnecessary trailing semicolons"##,
},
Lint {
label: "refining_impl_trait",
description: r##"impl trait in impl method signature does not match trait method signature"##,
},
Lint {
label: "renamed_and_removed_lints",
description: r##"lints that have been renamed or removed"##,
},
Lint {
label: "repr_transparent_external_private_fields",
description: r##"transparent type contains an external ZST that is marked #[non_exhaustive] or contains private fields"##,
},
Lint {
label: "rust_2018_compatibility",
description: r##"lint group for: keyword-idents, anonymous-parameters, tyvar-behind-raw-pointer, absolute-paths-not-starting-with-crate"##,
description: r##"lint group for: keyword-idents, anonymous-parameters, absolute-paths-not-starting-with-crate, tyvar-behind-raw-pointer"##,
},
Lint {
label: "rust_2018_idioms",
@@ -328,7 +467,7 @@ pub struct LintGroup {
},
Lint {
label: "rust_2021_compatibility",
description: r##"lint group for: ellipsis-inclusive-range-patterns, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prelude-collisions, rust-2021-prefixes-incompatible-syntax, array-into-iter, non-fmt-panics"##,
description: r##"lint group for: ellipsis-inclusive-range-patterns, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prefixes-incompatible-syntax, rust-2021-prelude-collisions, array-into-iter, non-fmt-panics"##,
},
Lint {
label: "rust_2021_incompatible_closure_captures",
@@ -358,14 +497,30 @@ pub struct LintGroup {
label: "soft_unstable",
description: r##"a feature gate that doesn't break dependent crates"##,
},
Lint {
label: "special_module_name",
description: r##"module declarations for files with a special meaning"##,
},
Lint {
label: "stable_features",
description: r##"stable features found in `#[feature]` directive"##,
},
Lint {
label: "suspicious_auto_trait_impls",
description: r##"the rules governing auto traits have recently changed resulting in potential breakage"##,
},
Lint {
label: "suspicious_double_ref_op",
description: r##"suspicious call of trait method on `&&T`"##,
},
Lint {
label: "temporary_cstring_as_ptr",
description: r##"detects getting the inner pointer of a temporary `CString`"##,
},
Lint {
label: "test_unstable_lint",
description: r##"this unstable lint is only for testing"##,
},
Lint {
label: "text_direction_codepoint_in_comment",
description: r##"invisible directionality-changing codepoints in comment"##,
@@ -394,10 +549,6 @@ pub struct LintGroup {
label: "tyvar_behind_raw_pointer",
description: r##"raw pointer to an inference variable"##,
},
Lint {
label: "unaligned_references",
description: r##"detects unaligned references to fields of packed structs"##,
},
Lint {
label: "uncommon_codepoints",
description: r##"detects uncommon Unicode codepoints in identifiers"##,
@@ -410,23 +561,54 @@ pub struct LintGroup {
label: "unconditional_recursion",
description: r##"functions that cannot return without calling themselves"##,
},
Lint {
label: "undefined_naked_function_abi",
description: r##"undefined naked function ABI"##,
},
Lint {
label: "undropped_manually_drops",
description: r##"calls to `std::mem::drop` with `std::mem::ManuallyDrop` instead of it's inner value"##,
},
Lint {
label: "unexpected_cfgs",
description: r##"detects unexpected names and values in `#[cfg]` conditions"##,
},
Lint {
label: "unfulfilled_lint_expectations",
description: r##"unfulfilled lint expectation"##,
},
Lint {
label: "ungated_async_fn_track_caller",
description: r##"enabling track_caller on an async fn is a no-op unless the async_fn_track_caller feature is enabled"##,
},
Lint { label: "uninhabited_static", description: r##"uninhabited static"## },
Lint {
label: "unknown_crate_types",
description: r##"unknown crate type found in `#[crate_type]` directive"##,
},
Lint { label: "unknown_lints", description: r##"unrecognized lint attribute"## },
Lint {
label: "unknown_or_malformed_diagnostic_attributes",
description: r##"unrecognized or malformed diagnostic attribute"##,
},
Lint {
label: "unnameable_test_items",
description: r##"detects an item that cannot be named being marked as `#[test_case]`"##,
},
Lint {
label: "unnameable_types",
description: r##"effective visibility of a type is larger than the area in which it can be named"##,
},
Lint { label: "unreachable_code", description: r##"detects unreachable code paths"## },
Lint { label: "unreachable_patterns", description: r##"detects unreachable patterns"## },
Lint {
label: "unreachable_pub",
description: r##"`pub` items not reachable from crate root"##,
},
Lint { label: "unsafe_code", description: r##"usage of `unsafe` code"## },
Lint {
label: "unsafe_code",
description: r##"usage of `unsafe` code and other potentially unsound constructs"##,
},
Lint {
label: "unsafe_op_in_unsafe_fn",
description: r##"unsafe operations in unsafe functions without an explicit unsafe block are deprecated"##,
@@ -439,17 +621,17 @@ pub struct LintGroup {
label: "unstable_name_collisions",
description: r##"detects name collision with an existing but unstable method"##,
},
Lint {
label: "unstable_syntax_pre_expansion",
description: r##"unstable syntax can change at any point in the future, causing a hard error!"##,
},
Lint {
label: "unsupported_calling_conventions",
description: r##"use of unsupported calling convention"##,
},
Lint {
label: "unsupported_naked_functions",
description: r##"unsupported naked function definitions"##,
},
Lint {
label: "unused",
description: r##"lint group for: unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons"##,
description: r##"lint group for: unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-macro-rules, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons, map-unit-fn"##,
},
Lint {
label: "unused_allocation",
@@ -459,6 +641,10 @@ pub struct LintGroup {
label: "unused_assignments",
description: r##"detect assignments that will never be read"##,
},
Lint {
label: "unused_associated_type_bounds",
description: r##"detects unused `Foo = Bar` bounds in `dyn Trait<Foo = Bar>`"##,
},
Lint {
label: "unused_attributes",
description: r##"detects attributes that were not used by the compiler"##,
@@ -491,6 +677,10 @@ pub struct LintGroup {
label: "unused_lifetimes",
description: r##"detects lifetime parameters that are never used"##,
},
Lint {
label: "unused_macro_rules",
description: r##"detects macro rules that were not used"##,
},
Lint { label: "unused_macros", description: r##"detects macros that were not used"## },
Lint {
label: "unused_must_use",
@@ -512,6 +702,10 @@ pub struct LintGroup {
label: "unused_results",
description: r##"unused result of an expression in a statement"##,
},
Lint {
label: "unused_tuple_struct_fields",
description: r##"detects tuple struct fields that are never read"##,
},
Lint { label: "unused_unsafe", description: r##"unnecessary use of an `unsafe` block"## },
Lint {
label: "unused_variables",
@@ -521,6 +715,10 @@ pub struct LintGroup {
label: "useless_deprecated",
description: r##"detects deprecation attributes with no effect"##,
},
Lint {
label: "useless_ptr_null_checks",
description: r##"useless checking of non-null-typed pointer"##,
},
Lint {
label: "variant_size_differences",
description: r##"detects enums with widely varying variant sizes"##,
@@ -542,49 +740,63 @@ pub struct LintGroup {
description: r##"suggest using `loop { }` instead of `while true { }`"##,
},
];
pub const DEFAULT_LINT_GROUPS: &[LintGroup] = &[
LintGroup {
lint: Lint {
label: "future_incompatible",
description: r##"lint group for: forbidden-lint-groups, illegal-floating-point-literal-pattern, private-in-public, pub-use-of-private-extern-crate, invalid-type-param-default, const-err, unaligned-references, patterns-in-fns-without-body, missing-fragment-specifier, late-bound-lifetime-arguments, order-dependent-trait-objects, coherence-leak-check, unstable-name-collisions, where-clauses-object-safety, proc-macro-derive-resolution-fallback, macro-expanded-macro-exports-accessed-by-absolute-paths, ill-formed-attribute-input, conflicting-repr-hints, ambiguous-associated-items, mutable-borrow-reservation-conflict, indirect-structural-match, pointer-structural-match, nontrivial-structural-match, soft-unstable, cenum-impl-drop-cast, const-evaluatable-unchecked, uninhabited-static, unsupported-naked-functions, invalid-doc-attributes, semicolon-in-expressions-from-macros, legacy-derive-helpers, proc-macro-back-compat, unsupported-calling-conventions, deref-into-dyn-supertrait"##,
description: r##"lint group for: deref-into-dyn-supertrait, ambiguous-associated-items, ambiguous-glob-imports, byte-slice-in-packed-struct-with-derive, cenum-impl-drop-cast, coherence-leak-check, coinductive-overlap-in-coherence, conflicting-repr-hints, const-evaluatable-unchecked, const-patterns-without-partial-eq, deprecated-cfg-attr-crate-type-name, elided-lifetimes-in-associated-constant, forbidden-lint-groups, ill-formed-attribute-input, illegal-floating-point-literal-pattern, implied-bounds-entailment, indirect-structural-match, invalid-alignment, invalid-doc-attributes, invalid-type-param-default, late-bound-lifetime-arguments, legacy-derive-helpers, macro-expanded-macro-exports-accessed-by-absolute-paths, missing-fragment-specifier, nontrivial-structural-match, order-dependent-trait-objects, patterns-in-fns-without-body, pointer-structural-match, proc-macro-back-compat, proc-macro-derive-resolution-fallback, pub-use-of-private-extern-crate, repr-transparent-external-private-fields, semicolon-in-expressions-from-macros, soft-unstable, suspicious-auto-trait-impls, uninhabited-static, unstable-name-collisions, unstable-syntax-pre-expansion, unsupported-calling-conventions, where-clauses-object-safety"##,
},
children: &[
"forbidden_lint_groups",
"illegal_floating_point_literal_pattern",
"private_in_public",
"pub_use_of_private_extern_crate",
"invalid_type_param_default",
"const_err",
"unaligned_references",
"patterns_in_fns_without_body",
"missing_fragment_specifier",
"late_bound_lifetime_arguments",
"order_dependent_trait_objects",
"coherence_leak_check",
"unstable_name_collisions",
"where_clauses_object_safety",
"proc_macro_derive_resolution_fallback",
"macro_expanded_macro_exports_accessed_by_absolute_paths",
"ill_formed_attribute_input",
"conflicting_repr_hints",
"ambiguous_associated_items",
"mutable_borrow_reservation_conflict",
"indirect_structural_match",
"pointer_structural_match",
"nontrivial_structural_match",
"soft_unstable",
"cenum_impl_drop_cast",
"const_evaluatable_unchecked",
"uninhabited_static",
"unsupported_naked_functions",
"invalid_doc_attributes",
"semicolon_in_expressions_from_macros",
"legacy_derive_helpers",
"proc_macro_back_compat",
"unsupported_calling_conventions",
"deref_into_dyn_supertrait",
"ambiguous_associated_items",
"ambiguous_glob_imports",
"byte_slice_in_packed_struct_with_derive",
"cenum_impl_drop_cast",
"coherence_leak_check",
"coinductive_overlap_in_coherence",
"conflicting_repr_hints",
"const_evaluatable_unchecked",
"const_patterns_without_partial_eq",
"deprecated_cfg_attr_crate_type_name",
"elided_lifetimes_in_associated_constant",
"forbidden_lint_groups",
"ill_formed_attribute_input",
"illegal_floating_point_literal_pattern",
"implied_bounds_entailment",
"indirect_structural_match",
"invalid_alignment",
"invalid_doc_attributes",
"invalid_type_param_default",
"late_bound_lifetime_arguments",
"legacy_derive_helpers",
"macro_expanded_macro_exports_accessed_by_absolute_paths",
"missing_fragment_specifier",
"nontrivial_structural_match",
"order_dependent_trait_objects",
"patterns_in_fns_without_body",
"pointer_structural_match",
"proc_macro_back_compat",
"proc_macro_derive_resolution_fallback",
"pub_use_of_private_extern_crate",
"repr_transparent_external_private_fields",
"semicolon_in_expressions_from_macros",
"soft_unstable",
"suspicious_auto_trait_impls",
"uninhabited_static",
"unstable_name_collisions",
"unstable_syntax_pre_expansion",
"unsupported_calling_conventions",
"where_clauses_object_safety",
],
},
LintGroup {
lint: Lint {
label: "let_underscore",
description: r##"lint group for: let-underscore-drop, let-underscore-lock"##,
},
children: &["let_underscore_drop", "let_underscore_lock"],
},
LintGroup {
lint: Lint {
label: "nonstandard_style",
@@ -595,13 +807,13 @@ pub struct LintGroup {
LintGroup {
lint: Lint {
label: "rust_2018_compatibility",
description: r##"lint group for: keyword-idents, anonymous-parameters, tyvar-behind-raw-pointer, absolute-paths-not-starting-with-crate"##,
description: r##"lint group for: keyword-idents, anonymous-parameters, absolute-paths-not-starting-with-crate, tyvar-behind-raw-pointer"##,
},
children: &[
"keyword_idents",
"anonymous_parameters",
"tyvar_behind_raw_pointer",
"absolute_paths_not_starting_with_crate",
"tyvar_behind_raw_pointer",
],
},
LintGroup {
@@ -620,15 +832,15 @@ pub struct LintGroup {
LintGroup {
lint: Lint {
label: "rust_2021_compatibility",
description: r##"lint group for: ellipsis-inclusive-range-patterns, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prelude-collisions, rust-2021-prefixes-incompatible-syntax, array-into-iter, non-fmt-panics"##,
description: r##"lint group for: ellipsis-inclusive-range-patterns, bare-trait-objects, rust-2021-incompatible-closure-captures, rust-2021-incompatible-or-patterns, rust-2021-prefixes-incompatible-syntax, rust-2021-prelude-collisions, array-into-iter, non-fmt-panics"##,
},
children: &[
"ellipsis_inclusive_range_patterns",
"bare_trait_objects",
"rust_2021_incompatible_closure_captures",
"rust_2021_incompatible_or_patterns",
"rust_2021_prelude_collisions",
"rust_2021_prefixes_incompatible_syntax",
"rust_2021_prelude_collisions",
"array_into_iter",
"non_fmt_panics",
],
@@ -636,7 +848,7 @@ pub struct LintGroup {
LintGroup {
lint: Lint {
label: "unused",
description: r##"lint group for: unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons"##,
description: r##"lint group for: unused-imports, unused-variables, unused-assignments, dead-code, unused-mut, unreachable-code, unreachable-patterns, unused-must-use, unused-unsafe, path-statements, unused-attributes, unused-macros, unused-macro-rules, unused-allocation, unused-doc-comments, unused-extern-crates, unused-features, unused-labels, unused-parens, unused-braces, redundant-semicolons, map-unit-fn"##,
},
children: &[
"unused_imports",
@@ -651,6 +863,7 @@ pub struct LintGroup {
"path_statements",
"unused_attributes",
"unused_macros",
"unused_macro_rules",
"unused_allocation",
"unused_doc_comments",
"unused_extern_crates",
@@ -659,6 +872,7 @@ pub struct LintGroup {
"unused_parens",
"unused_braces",
"redundant_semicolons",
"map_unit_fn",
],
},
LintGroup {
@@ -673,7 +887,7 @@ pub struct LintGroup {
pub const RUSTDOC_LINTS: &[Lint] = &[
Lint {
label: "rustdoc::all",
description: r##"lint group for: rustdoc::broken-intra-doc-links, rustdoc::private-intra-doc-links, rustdoc::missing-doc-code-examples, rustdoc::private-doc-tests, rustdoc::invalid-codeblock-attributes, rustdoc::invalid-rust-codeblocks, rustdoc::invalid-html-tags, rustdoc::bare-urls, rustdoc::missing-crate-level-docs"##,
description: r##"lint group for: rustdoc::broken-intra-doc-links, rustdoc::private-intra-doc-links, rustdoc::private-doc-tests, rustdoc::invalid-codeblock-attributes, rustdoc::invalid-rust-codeblocks, rustdoc::invalid-html-tags, rustdoc::bare-urls, rustdoc::missing-crate-level-docs, rustdoc::unescaped-backticks, rustdoc::redundant-explicit-links"##,
},
Lint { label: "rustdoc::bare_urls", description: r##"detects URLs that are not hyperlinks"## },
Lint {
@@ -708,26 +922,69 @@ pub struct LintGroup {
label: "rustdoc::private_intra_doc_links",
description: r##"linking from a public item to a private one"##,
},
Lint {
label: "rustdoc::redundant_explicit_links",
description: r##"detects redundant explicit links in doc comments"##,
},
Lint {
label: "rustdoc::unescaped_backticks",
description: r##"detects unescaped backticks in doc comments"##,
},
];
pub const RUSTDOC_LINT_GROUPS: &[LintGroup] = &[LintGroup {
lint: Lint {
label: "rustdoc::all",
description: r##"lint group for: rustdoc::broken-intra-doc-links, rustdoc::private-intra-doc-links, rustdoc::missing-doc-code-examples, rustdoc::private-doc-tests, rustdoc::invalid-codeblock-attributes, rustdoc::invalid-rust-codeblocks, rustdoc::invalid-html-tags, rustdoc::bare-urls, rustdoc::missing-crate-level-docs"##,
description: r##"lint group for: rustdoc::broken-intra-doc-links, rustdoc::private-intra-doc-links, rustdoc::private-doc-tests, rustdoc::invalid-codeblock-attributes, rustdoc::invalid-rust-codeblocks, rustdoc::invalid-html-tags, rustdoc::bare-urls, rustdoc::missing-crate-level-docs, rustdoc::unescaped-backticks, rustdoc::redundant-explicit-links"##,
},
children: &[
"rustdoc::broken_intra_doc_links",
"rustdoc::private_intra_doc_links",
"rustdoc::missing_doc_code_examples",
"rustdoc::private_doc_tests",
"rustdoc::invalid_codeblock_attributes",
"rustdoc::invalid_rust_codeblocks",
"rustdoc::invalid_html_tags",
"rustdoc::bare_urls",
"rustdoc::missing_crate_level_docs",
"rustdoc::unescaped_backticks",
"rustdoc::redundant_explicit_links",
],
}];
pub const FEATURES: &[Lint] = &[
Lint {
label: "aarch64_ver_target_feature",
description: r##"# `aarch64_ver_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "abi_amdgpu_kernel",
description: r##"# `abi_amdgpu_kernel`
The tracking issue for this feature is: [#51575]
[#51575]: https://github.com/rust-lang/rust/issues/51575
------------------------
"##,
},
Lint {
label: "abi_avr_interrupt",
description: r##"# `abi_avr_interrupt`
The tracking issue for this feature is: [#69664]
[#69664]: https://github.com/rust-lang/rust/issues/69664
------------------------
"##,
},
Lint {
label: "abi_c_cmse_nonsecure_call",
description: r##"# `abi_c_cmse_nonsecure_call`
@@ -928,6 +1185,121 @@ pub fn device_function() {
ret;
}
```
"##,
},
Lint {
label: "abi_riscv_interrupt",
description: r##"# `abi_riscv_interrupt`
The tracking issue for this feature is: [#111889]
[#111889]: https://github.com/rust-lang/rust/issues/111889
------------------------
"##,
},
Lint {
label: "abi_unadjusted",
description: r##"# `abi_unadjusted`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "abi_vectorcall",
description: r##"# `abi_vectorcall`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "abi_x86_interrupt",
description: r##"# `abi_x86_interrupt`
The tracking issue for this feature is: [#40180]
[#40180]: https://github.com/rust-lang/rust/issues/40180
------------------------
"##,
},
Lint {
label: "absolute_path",
description: r##"# `absolute_path`
The tracking issue for this feature is: [#92750]
[#92750]: https://github.com/rust-lang/rust/issues/92750
------------------------
"##,
},
Lint {
label: "addr_parse_ascii",
description: r##"# `addr_parse_ascii`
The tracking issue for this feature is: [#101035]
[#101035]: https://github.com/rust-lang/rust/issues/101035
------------------------
"##,
},
Lint {
label: "adt_const_params",
description: r##"# `adt_const_params`
The tracking issue for this feature is: [#95174]
[#95174]: https://github.com/rust-lang/rust/issues/95174
------------------------
"##,
},
Lint {
label: "alloc_error_handler",
description: r##"# `alloc_error_handler`
The tracking issue for this feature is: [#51540]
[#51540]: https://github.com/rust-lang/rust/issues/51540
------------------------
"##,
},
Lint {
label: "alloc_error_hook",
description: r##"# `alloc_error_hook`
The tracking issue for this feature is: [#51245]
[#51245]: https://github.com/rust-lang/rust/issues/51245
------------------------
"##,
},
Lint {
label: "alloc_internals",
description: r##"# `alloc_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "alloc_layout_extra",
description: r##"# `alloc_layout_extra`
The tracking issue for this feature is: [#55724]
[#55724]: https://github.com/rust-lang/rust/issues/55724
------------------------
"##,
},
Lint {
@@ -961,53 +1333,171 @@ pub fn device_function() {
"##,
},
Lint {
label: "arbitrary_enum_discriminant",
description: r##"# `arbitrary_enum_discriminant`
label: "allow_internal_unsafe",
description: r##"# `allow_internal_unsafe`
The tracking issue for this feature is: [#60553]
[#60553]: https://github.com/rust-lang/rust/issues/60553
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "allow_internal_unstable",
description: r##"# `allow_internal_unstable`
The `arbitrary_enum_discriminant` feature permits tuple-like and
struct-like enum variants with `#[repr(<int-type>)]` to have explicit discriminants.
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
## Examples
------------------------
"##,
},
Lint {
label: "anonymous_lifetime_in_impl_trait",
description: r##"# `anonymous_lifetime_in_impl_trait`
```rust
#![feature(arbitrary_enum_discriminant)]
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
#[allow(dead_code)]
#[repr(u8)]
enum Enum {
Unit = 3,
Tuple(u16) = 2,
Struct {
a: u8,
b: u16,
} = 1,
}
------------------------
"##,
},
Lint {
label: "arbitrary_self_types",
description: r##"# `arbitrary_self_types`
impl Enum {
fn tag(&self) -> u8 {
unsafe { *(self as *const Self as *const u8) }
}
}
The tracking issue for this feature is: [#44874]
assert_eq!(3, Enum::Unit.tag());
assert_eq!(2, Enum::Tuple(5).tag());
assert_eq!(1, Enum::Struct{a: 7, b: 11}.tag());
```
[#44874]: https://github.com/rust-lang/rust/issues/44874
------------------------
"##,
},
Lint {
label: "arc_unwrap_or_clone",
description: r##"# `arc_unwrap_or_clone`
The tracking issue for this feature is: [#93610]
[#93610]: https://github.com/rust-lang/rust/issues/93610
------------------------
"##,
},
Lint {
label: "arm_target_feature",
description: r##"# `arm_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "array_chunks",
description: r##"# `array_chunks`
The tracking issue for this feature is: [#74985]
[#74985]: https://github.com/rust-lang/rust/issues/74985
------------------------
"##,
},
Lint {
label: "array_into_iter_constructors",
description: r##"# `array_into_iter_constructors`
The tracking issue for this feature is: [#91583]
[#91583]: https://github.com/rust-lang/rust/issues/91583
------------------------
"##,
},
Lint {
label: "array_methods",
description: r##"# `array_methods`
The tracking issue for this feature is: [#76118]
[#76118]: https://github.com/rust-lang/rust/issues/76118
------------------------
"##,
},
Lint {
label: "array_try_from_fn",
description: r##"# `array_try_from_fn`
The tracking issue for this feature is: [#89379]
[#89379]: https://github.com/rust-lang/rust/issues/89379
------------------------
"##,
},
Lint {
label: "array_try_map",
description: r##"# `array_try_map`
The tracking issue for this feature is: [#79711]
[#79711]: https://github.com/rust-lang/rust/issues/79711
------------------------
"##,
},
Lint {
label: "array_windows",
description: r##"# `array_windows`
The tracking issue for this feature is: [#75027]
[#75027]: https://github.com/rust-lang/rust/issues/75027
------------------------
"##,
},
Lint {
label: "as_array_of_cells",
description: r##"# `as_array_of_cells`
The tracking issue for this feature is: [#88248]
[#88248]: https://github.com/rust-lang/rust/issues/88248
------------------------
"##,
},
Lint {
label: "ascii_char",
description: r##"# `ascii_char`
The tracking issue for this feature is: [#110998]
[#110998]: https://github.com/rust-lang/rust/issues/110998
------------------------
"##,
},
Lint {
label: "ascii_char_variants",
description: r##"# `ascii_char_variants`
The tracking issue for this feature is: [#110998]
[#110998]: https://github.com/rust-lang/rust/issues/110998
------------------------
"##,
},
Lint {
label: "asm_const",
description: r##"# `asm_const`
The tracking issue for this feature is: [#72016]
The tracking issue for this feature is: [#93332]
[#72016]: https://github.com/rust-lang/rust/issues/72016
[#93332]: https://github.com/rust-lang/rust/issues/93332
------------------------
@@ -1020,9 +1510,9 @@ fn tag(&self) -> u8 {
label: "asm_experimental_arch",
description: r##"# `asm_experimental_arch`
The tracking issue for this feature is: [#72016]
The tracking issue for this feature is: [#93335]
[#72016]: https://github.com/rust-lang/rust/issues/72016
[#93335]: https://github.com/rust-lang/rust/issues/93335
------------------------
@@ -1035,6 +1525,10 @@ fn tag(&self) -> u8 {
- BPF
- SPIR-V
- AVR
- MSP430
- M68k
- CSKY
- s390x
## Register classes
@@ -1059,6 +1553,14 @@ fn tag(&self) -> u8 {
| AVR | `reg_pair` | `r3r2` .. `r25r24`, `X`, `Z` | `r` |
| AVR | `reg_iw` | `r25r24`, `X`, `Z` | `w` |
| AVR | `reg_ptr` | `X`, `Z` | `e` |
| MSP430 | `reg` | `r[0-15]` | `r` |
| M68k | `reg` | `d[0-7]`, `a[0-7]` | `r` |
| M68k | `reg_data` | `d[0-7]` | `d` |
| M68k | `reg_addr` | `a[0-3]` | `a` |
| CSKY | `reg` | `r[0-31]` | `r` |
| CSKY | `freg` | `f[0-31]` | `f` |
| s390x | `reg` | `r[0-10]`, `r[12-14]` | `r` |
| s390x | `freg` | `f[0-15]` | `f` |
> **Notes**:
> - NVPTX doesn't have a fixed register set, so named registers are not supported.
@@ -1087,6 +1589,13 @@ fn tag(&self) -> u8 {
| BPF | `wreg` | `alu32` | `i8` `i16` `i32` |
| AVR | `reg`, `reg_upper` | None | `i8` |
| AVR | `reg_pair`, `reg_iw`, `reg_ptr` | None | `i16` |
| MSP430 | `reg` | None | `i8`, `i16` |
| M68k | `reg`, `reg_addr` | None | `i16`, `i32` |
| M68k | `reg_data` | None | `i8`, `i16`, `i32` |
| CSKY | `reg` | None | `i8`, `i16`, `i32` |
| CSKY | `freg` | None | `f32`, |
| s390x | `reg` | None | `i8`, `i16`, `i32`, `i64` |
| s390x | `freg` | None | `f32`, `f64` |
## Register aliases
@@ -1100,13 +1609,36 @@ fn tag(&self) -> u8 {
| AVR | `XL` | `r26` |
| AVR | `ZH` | `r31` |
| AVR | `ZL` | `r30` |
| MSP430 | `r0` | `pc` |
| MSP430 | `r1` | `sp` |
| MSP430 | `r2` | `sr` |
| MSP430 | `r3` | `cg` |
| MSP430 | `r4` | `fp` |
| M68k | `a5` | `bp` |
| M68k | `a6` | `fp` |
| M68k | `a7` | `sp`, `usp`, `ssp`, `isp` |
| CSKY | `r[0-3]` | `a[0-3]` |
| CSKY | `r[4-11]` | `l[0-7]` |
| CSKY | `r[12-13]` | `t[0-1]` |
| CSKY | `r14` | `sp` |
| CSKY | `r15` | `lr` |
| CSKY | `r[16-17]` | `l[8-9]` |
| CSKY | `r[18-25]` | `t[2-9]` |
| CSKY | `r28` | `rgb` |
| CSKY | `r29` | `rtb` |
| CSKY | `r30` | `svbr` |
| CSKY | `r31` | `tls` |
> **Notes**:
> - TI does not mandate a frame pointer for MSP430, but toolchains are allowed
to use one; LLVM uses `r4`.
## Unsupported registers
| Architecture | Unsupported register | Reason |
| ------------ | --------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| All | `sp` | The stack pointer must be restored to its original value at the end of an asm code block. |
| All | `fr` (Hexagon), `$fp` (MIPS), `Y` (AVR) | The frame pointer cannot be used as an input or output. |
| All | `sp`, `r15` (s390x) | The stack pointer must be restored to its original value at the end of an asm code block. |
| All | `fr` (Hexagon), `$fp` (MIPS), `Y` (AVR), `r4` (MSP430), `a6` (M68k), `r11` (s390x) | The frame pointer cannot be used as an input or output. |
| All | `r19` (Hexagon) | This is used internally by LLVM as a "base pointer" for functions with complex stack frames. |
| MIPS | `$0` or `$zero` | This is a constant zero register which can't be modified. |
| MIPS | `$1` or `$at` | Reserved for assembler. |
@@ -1115,6 +1647,15 @@ fn tag(&self) -> u8 {
| MIPS | `$ra` | Return address cannot be used as inputs or outputs. |
| Hexagon | `lr` | This is the link register which cannot be used as an input or output. |
| AVR | `r0`, `r1`, `r1r0` | Due to an issue in LLVM, the `r0` and `r1` registers cannot be used as inputs or outputs. If modified, they must be restored to their original values before the end of the block. |
|MSP430 | `r0`, `r2`, `r3` | These are the program counter, status register, and constant generator respectively. Neither the status register nor constant generator can be written to. |
| M68k | `a4`, `a5` | Used internally by LLVM for the base pointer and global base pointer. |
| CSKY | `r7`, `r28` | Used internally by LLVM for the base pointer and global base pointer. |
| CSKY | `r8` | Used internally by LLVM for the frame pointer. |
| CSKY | `r14` | Used internally by LLVM for the stack pointer. |
| CSKY | `r15` | This is the link register. |
| CSKY | `r[26-30]` | Reserved by its ABI. |
| CSKY | `r31` | This is the TLS register. |
## Template modifiers
@@ -1129,42 +1670,167 @@ fn tag(&self) -> u8 {
| PowerPC | `reg` | None | `0` | None |
| PowerPC | `reg_nonzero` | None | `3` | `b` |
| PowerPC | `freg` | None | `0` | None |
| s390x | `reg` | None | `%r0` | None |
| s390x | `freg` | None | `%f0` | None |
| CSKY | `reg` | None | `r0` | None |
| CSKY | `freg` | None | `f0` | None |
# Flags covered by `preserves_flags`
These flags registers must be restored upon exiting the asm block if the `preserves_flags` option is set:
- AVR
- The status register `SREG`.
"##,
},
Lint {
label: "asm_sym",
description: r##"# `asm_sym`
The tracking issue for this feature is: [#72016]
[#72016]: https://github.com/rust-lang/rust/issues/72016
------------------------
This feature adds a `sym <path>` operand type to `asm!` and `global_asm!`.
- `<path>` must refer to a `fn` or `static`.
- A mangled symbol name referring to the item is substituted into the asm template string.
- The substituted string does not include any modifiers (e.g. GOT, PLT, relocations, etc).
- `<path>` is allowed to point to a `#[thread_local]` static, in which case the asm code can combine the symbol with relocations (e.g. `@plt`, `@TPOFF`) to read from thread-local data.
- MSP430
- The status register `r2`.
- M68k
- The condition code register `ccr`.
- s390x
- The condition code register `cc`.
"##,
},
Lint {
label: "asm_unwind",
description: r##"# `asm_unwind`
The tracking issue for this feature is: [#72016]
The tracking issue for this feature is: [#93334]
[#72016]: https://github.com/rust-lang/rust/issues/72016
[#93334]: https://github.com/rust-lang/rust/issues/93334
------------------------
This feature adds a `may_unwind` option to `asm!` which allows an `asm` block to unwind stack and be part of the stack unwinding process. This option is only supported by the LLVM backend right now.
"##,
},
Lint {
label: "assert_matches",
description: r##"# `assert_matches`
The tracking issue for this feature is: [#82775]
[#82775]: https://github.com/rust-lang/rust/issues/82775
------------------------
"##,
},
Lint {
label: "associated_const_equality",
description: r##"# `associated_const_equality`
The tracking issue for this feature is: [#92827]
[#92827]: https://github.com/rust-lang/rust/issues/92827
------------------------
"##,
},
Lint {
label: "associated_type_bounds",
description: r##"# `associated_type_bounds`
The tracking issue for this feature is: [#52662]
[#52662]: https://github.com/rust-lang/rust/issues/52662
------------------------
"##,
},
Lint {
label: "associated_type_defaults",
description: r##"# `associated_type_defaults`
The tracking issue for this feature is: [#29661]
[#29661]: https://github.com/rust-lang/rust/issues/29661
------------------------
"##,
},
Lint {
label: "async_closure",
description: r##"# `async_closure`
The tracking issue for this feature is: [#62290]
[#62290]: https://github.com/rust-lang/rust/issues/62290
------------------------
"##,
},
Lint {
label: "async_fn_in_trait",
description: r##"# `async_fn_in_trait`
The tracking issue for this feature is: [#91611]
[#91611]: https://github.com/rust-lang/rust/issues/91611
------------------------
"##,
},
Lint {
label: "async_fn_track_caller",
description: r##"# `async_fn_track_caller`
The tracking issue for this feature is: [#110011]
[#110011]: https://github.com/rust-lang/rust/issues/110011
------------------------
"##,
},
Lint {
label: "async_iter_from_iter",
description: r##"# `async_iter_from_iter`
The tracking issue for this feature is: [#81798]
[#81798]: https://github.com/rust-lang/rust/issues/81798
------------------------
"##,
},
Lint {
label: "async_iterator",
description: r##"# `async_iterator`
The tracking issue for this feature is: [#79024]
[#79024]: https://github.com/rust-lang/rust/issues/79024
------------------------
"##,
},
Lint {
label: "atomic_bool_fetch_not",
description: r##"# `atomic_bool_fetch_not`
The tracking issue for this feature is: [#98485]
[#98485]: https://github.com/rust-lang/rust/issues/98485
------------------------
"##,
},
Lint {
label: "atomic_from_mut",
description: r##"# `atomic_from_mut`
The tracking issue for this feature is: [#76314]
[#76314]: https://github.com/rust-lang/rust/issues/76314
------------------------
"##,
},
Lint {
label: "atomic_from_ptr",
description: r##"# `atomic_from_ptr`
The tracking issue for this feature is: [#108652]
[#108652]: https://github.com/rust-lang/rust/issues/108652
------------------------
"##,
},
Lint {
@@ -1184,8 +1850,8 @@ fn tag(&self) -> u8 {
has explicitly opted out via a negative impl. (Negative impls are separately controlled
by the `negative_impls` feature.)
[`Send`]: https://doc.rust-lang.org/std/marker/trait.Send.html
[`Sync`]: https://doc.rust-lang.org/std/marker/trait.Sync.html
[`Send`]: ../../std/marker/trait.Send.html
[`Sync`]: ../../std/marker/trait.Sync.html
```rust,ignore (partial-example)
impl !Trait for Type {}
@@ -1275,6 +1941,116 @@ trait matching, this cycle would be an error, but for an auto trait it
## Supertraits
Auto traits cannot have supertraits. This is for soundness reasons, as the interaction of coinduction with implied bounds is difficult to reconcile.
"##,
},
Lint {
label: "avx512_target_feature",
description: r##"# `avx512_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "backtrace_frames",
description: r##"# `backtrace_frames`
The tracking issue for this feature is: [#79676]
[#79676]: https://github.com/rust-lang/rust/issues/79676
------------------------
"##,
},
Lint {
label: "bigint_helper_methods",
description: r##"# `bigint_helper_methods`
The tracking issue for this feature is: [#85532]
[#85532]: https://github.com/rust-lang/rust/issues/85532
------------------------
"##,
},
Lint {
label: "binary_heap_as_slice",
description: r##"# `binary_heap_as_slice`
The tracking issue for this feature is: [#83659]
[#83659]: https://github.com/rust-lang/rust/issues/83659
------------------------
"##,
},
Lint {
label: "binary_heap_drain_sorted",
description: r##"# `binary_heap_drain_sorted`
The tracking issue for this feature is: [#59278]
[#59278]: https://github.com/rust-lang/rust/issues/59278
------------------------
"##,
},
Lint {
label: "binary_heap_into_iter_sorted",
description: r##"# `binary_heap_into_iter_sorted`
The tracking issue for this feature is: [#59278]
[#59278]: https://github.com/rust-lang/rust/issues/59278
------------------------
"##,
},
Lint {
label: "bound_as_ref",
description: r##"# `bound_as_ref`
The tracking issue for this feature is: [#80996]
[#80996]: https://github.com/rust-lang/rust/issues/80996
------------------------
"##,
},
Lint {
label: "bound_map",
description: r##"# `bound_map`
The tracking issue for this feature is: [#86026]
[#86026]: https://github.com/rust-lang/rust/issues/86026
------------------------
"##,
},
Lint {
label: "box_into_boxed_slice",
description: r##"# `box_into_boxed_slice`
The tracking issue for this feature is: [#71582]
[#71582]: https://github.com/rust-lang/rust/issues/71582
------------------------
"##,
},
Lint {
label: "box_into_inner",
description: r##"# `box_into_inner`
The tracking issue for this feature is: [#80437]
[#80437]: https://github.com/rust-lang/rust/issues/80437
------------------------
"##,
},
Lint {
@@ -1285,8 +2061,6 @@ trait matching, this cycle would be an error, but for an auto trait it
[#29641]: https://github.com/rust-lang/rust/issues/29641
See also [`box_syntax`](box-syntax.md)
------------------------
Box patterns let you match on `Box<T>`s:
@@ -1299,10 +2073,10 @@ fn main() {
let b = Some(Box::new(5));
match b {
Some(box n) if n < 0 => {
println!("Box contains negative number {}", n);
println!("Box contains negative number {n}");
},
Some(box n) if n >= 0 => {
println!("Box contains non-negative number {}", n);
println!("Box contains non-negative number {n}");
},
None => {
println!("No box");
@@ -1314,29 +2088,102 @@ fn main() {
"##,
},
Lint {
label: "box_syntax",
description: r##"# `box_syntax`
label: "bpf_target_feature",
description: r##"# `bpf_target_feature`
The tracking issue for this feature is: [#49733]
The tracking issue for this feature is: [#44839]
[#49733]: https://github.com/rust-lang/rust/issues/49733
See also [`box_patterns`](box-patterns.md)
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "btree_cursors",
description: r##"# `btree_cursors`
Currently the only stable way to create a `Box` is via the `Box::new` method.
Also it is not possible in stable Rust to destructure a `Box` in a match
pattern. The unstable `box` keyword can be used to create a `Box`. An example
usage would be:
The tracking issue for this feature is: [#107540]
```rust
#![feature(box_syntax)]
[#107540]: https://github.com/rust-lang/rust/issues/107540
fn main() {
let b = box 5;
}
```
------------------------
"##,
},
Lint {
label: "btree_extract_if",
description: r##"# `btree_extract_if`
The tracking issue for this feature is: [#70530]
[#70530]: https://github.com/rust-lang/rust/issues/70530
------------------------
"##,
},
Lint {
label: "btreemap_alloc",
description: r##"# `btreemap_alloc`
The tracking issue for this feature is: [#32838]
[#32838]: https://github.com/rust-lang/rust/issues/32838
------------------------
"##,
},
Lint {
label: "buf_read_has_data_left",
description: r##"# `buf_read_has_data_left`
The tracking issue for this feature is: [#86423]
[#86423]: https://github.com/rust-lang/rust/issues/86423
------------------------
"##,
},
Lint {
label: "builtin_syntax",
description: r##"# `builtin_syntax`
The tracking issue for this feature is: [#110680]
[#110680]: https://github.com/rust-lang/rust/issues/110680
------------------------
"##,
},
Lint {
label: "byte_slice_trim_ascii",
description: r##"# `byte_slice_trim_ascii`
The tracking issue for this feature is: [#94035]
[#94035]: https://github.com/rust-lang/rust/issues/94035
------------------------
"##,
},
Lint {
label: "c_size_t",
description: r##"# `c_size_t`
The tracking issue for this feature is: [#88345]
[#88345]: https://github.com/rust-lang/rust/issues/88345
------------------------
"##,
},
Lint {
label: "c_str_literals",
description: r##"# `c_str_literals`
The tracking issue for this feature is: [#105723]
[#105723]: https://github.com/rust-lang/rust/issues/105723
------------------------
"##,
},
Lint {
@@ -1349,9 +2196,20 @@ fn main() {
------------------------
Introduces four new ABI strings: "C-unwind", "stdcall-unwind",
"thiscall-unwind", and "system-unwind". These enable unwinding from other
languages (such as C++) into Rust frames and from Rust into other languages.
Introduces new ABI strings:
- "C-unwind"
- "cdecl-unwind"
- "stdcall-unwind"
- "fastcall-unwind"
- "vectorcall-unwind"
- "thiscall-unwind"
- "aapcs-unwind"
- "win64-unwind"
- "sysv64-unwind"
- "system-unwind"
These enable unwinding from other languages (such as C++) into Rust frames and
from Rust into other languages.
See [RFC 2945] for more information.
@@ -1369,7 +2227,7 @@ fn main() {
------------------------
The `c_variadic` language feature enables C-variadic functions to be
defined in Rust. The may be called both from within Rust and via FFI.
defined in Rust. They may be called both from within Rust and via FFI.
## Examples
@@ -1426,45 +2284,91 @@ fn main() {
"##,
},
Lint {
label: "cfg_panic",
description: r##"# `cfg_panic`
label: "can_vector",
description: r##"# `can_vector`
The tracking issue for this feature is: [#77443]
The tracking issue for this feature is: [#69941]
[#77443]: https://github.com/rust-lang/rust/issues/77443
[#69941]: https://github.com/rust-lang/rust/issues/69941
------------------------
"##,
},
Lint {
label: "cell_leak",
description: r##"# `cell_leak`
The `cfg_panic` feature makes it possible to execute different code
depending on the panic strategy.
The tracking issue for this feature is: [#69099]
Possible values at the moment are `"unwind"` or `"abort"`, although
it is possible that new panic strategies may be added to Rust in the
future.
[#69099]: https://github.com/rust-lang/rust/issues/69099
## Examples
------------------------
"##,
},
Lint {
label: "cell_update",
description: r##"# `cell_update`
```rust
#![feature(cfg_panic)]
The tracking issue for this feature is: [#50186]
#[cfg(panic = "unwind")]
fn a() {
// ...
}
[#50186]: https://github.com/rust-lang/rust/issues/50186
#[cfg(not(panic = "unwind"))]
fn a() {
// ...
}
------------------------
"##,
},
Lint {
label: "cfg_accessible",
description: r##"# `cfg_accessible`
fn b() {
if cfg!(panic = "abort") {
// ...
} else {
// ...
}
}
```
The tracking issue for this feature is: [#64797]
[#64797]: https://github.com/rust-lang/rust/issues/64797
------------------------
"##,
},
Lint {
label: "cfg_eval",
description: r##"# `cfg_eval`
The tracking issue for this feature is: [#82679]
[#82679]: https://github.com/rust-lang/rust/issues/82679
------------------------
"##,
},
Lint {
label: "cfg_match",
description: r##"# `cfg_match`
The tracking issue for this feature is: [#115585]
[#115585]: https://github.com/rust-lang/rust/issues/115585
------------------------
"##,
},
Lint {
label: "cfg_overflow_checks",
description: r##"# `cfg_overflow_checks`
The tracking issue for this feature is: [#111466]
[#111466]: https://github.com/rust-lang/rust/issues/111466
------------------------
"##,
},
Lint {
label: "cfg_relocation_model",
description: r##"# `cfg_relocation_model`
The tracking issue for this feature is: [#114929]
[#114929]: https://github.com/rust-lang/rust/issues/114929
------------------------
"##,
},
Lint {
@@ -1503,6 +2407,61 @@ fn b() {
}
}
```
"##,
},
Lint {
label: "cfg_target_abi",
description: r##"# `cfg_target_abi`
The tracking issue for this feature is: [#80970]
[#80970]: https://github.com/rust-lang/rust/issues/80970
------------------------
"##,
},
Lint {
label: "cfg_target_compact",
description: r##"# `cfg_target_compact`
The tracking issue for this feature is: [#96901]
[#96901]: https://github.com/rust-lang/rust/issues/96901
------------------------
"##,
},
Lint {
label: "cfg_target_has_atomic",
description: r##"# `cfg_target_has_atomic`
The tracking issue for this feature is: [#94039]
[#94039]: https://github.com/rust-lang/rust/issues/94039
------------------------
"##,
},
Lint {
label: "cfg_target_has_atomic_equal_alignment",
description: r##"# `cfg_target_has_atomic_equal_alignment`
The tracking issue for this feature is: [#93822]
[#93822]: https://github.com/rust-lang/rust/issues/93822
------------------------
"##,
},
Lint {
label: "cfg_target_thread_local",
description: r##"# `cfg_target_thread_local`
The tracking issue for this feature is: [#29594]
[#29594]: https://github.com/rust-lang/rust/issues/29594
------------------------
"##,
},
Lint {
@@ -1545,10 +2504,72 @@ fn b() {
"##,
},
Lint {
label: "char_error_internals",
description: r##"# `char_error_internals`
label: "cfi_encoding",
description: r##"# `cfi_encoding`
This feature is internal to the Rust compiler and is not intended for general use.
The tracking issue for this feature is: [#89653]
[#89653]: https://github.com/rust-lang/rust/issues/89653
------------------------
The `cfi_encoding` feature allows the user to define a CFI encoding for a type.
It allows the user to use a different names for types that otherwise would be
required to have the same name as used in externally defined C functions.
## Examples
```rust
#![feature(cfi_encoding, extern_types)]
#[cfi_encoding = "3Foo"]
pub struct Type1(i32);
extern {
#[cfi_encoding = "3Bar"]
type Type2;
}
```
"##,
},
Lint {
label: "char_indices_offset",
description: r##"# `char_indices_offset`
The tracking issue for this feature is: [#83871]
[#83871]: https://github.com/rust-lang/rust/issues/83871
------------------------
"##,
},
Lint {
label: "char_internals",
description: r##"# `char_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "char_min",
description: r##"# `char_min`
The tracking issue for this feature is: [#114298]
[#114298]: https://github.com/rust-lang/rust/issues/114298
------------------------
"##,
},
Lint {
label: "closure_lifetime_binder",
description: r##"# `closure_lifetime_binder`
The tracking issue for this feature is: [#97362]
[#97362]: https://github.com/rust-lang/rust/issues/97362
------------------------
"##,
@@ -1567,6 +2588,17 @@ fn b() {
Calls made to the closure or generator will have caller information
available through `std::panic::Location::caller()`, just like using
`#[track_caller]` on a function.
"##,
},
Lint {
label: "cmp_minmax",
description: r##"# `cmp_minmax`
The tracking issue for this feature is: [#115939]
[#115939]: https://github.com/rust-lang/rust/issues/115939
------------------------
"##,
},
Lint {
@@ -1652,6 +2684,28 @@ pub extern "C" fn entry_function(input: u32) -> u32 {
3c: f7ff fffe bl 0 <_ZN4core9panicking5panic17h5c028258ca2fb3f5E>
40: defe udf #254 ; 0xfe
```
"##,
},
Lint {
label: "coerce_unsized",
description: r##"# `coerce_unsized`
The tracking issue for this feature is: [#18598]
[#18598]: https://github.com/rust-lang/rust/issues/18598
------------------------
"##,
},
Lint {
label: "collapse_debuginfo",
description: r##"# `collapse_debuginfo`
The tracking issue for this feature is: [#100758]
[#100758]: https://github.com/rust-lang/rust/issues/100758
------------------------
"##,
},
Lint {
@@ -1660,6 +2714,17 @@ pub extern "C" fn entry_function(input: u32) -> u32 {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "concat_bytes",
description: r##"# `concat_bytes`
The tracking issue for this feature is: [#87555]
[#87555]: https://github.com/rust-lang/rust/issues/87555
------------------------
"##,
},
@@ -1690,14 +2755,1027 @@ fn foobar() -> u32 { 23 }
"##,
},
Lint {
label: "const_eval_limit",
description: r##"# `const_eval_limit`
label: "const_align_of_val",
description: r##"# `const_align_of_val`
The tracking issue for this feature is: [#67217]
The tracking issue for this feature is: [#46571]
[#67217]: https://github.com/rust-lang/rust/issues/67217
[#46571]: https://github.com/rust-lang/rust/issues/46571
The `const_eval_limit` allows someone to limit the evaluation steps the CTFE undertakes to evaluate a `const fn`.
------------------------
"##,
},
Lint {
label: "const_align_of_val_raw",
description: r##"# `const_align_of_val_raw`
The tracking issue for this feature is: [#46571]
[#46571]: https://github.com/rust-lang/rust/issues/46571
------------------------
"##,
},
Lint {
label: "const_align_offset",
description: r##"# `const_align_offset`
The tracking issue for this feature is: [#90962]
[#90962]: https://github.com/rust-lang/rust/issues/90962
------------------------
"##,
},
Lint {
label: "const_alloc_error",
description: r##"# `const_alloc_error`
The tracking issue for this feature is: [#92523]
[#92523]: https://github.com/rust-lang/rust/issues/92523
------------------------
"##,
},
Lint {
label: "const_alloc_layout",
description: r##"# `const_alloc_layout`
The tracking issue for this feature is: [#67521]
[#67521]: https://github.com/rust-lang/rust/issues/67521
------------------------
"##,
},
Lint {
label: "const_arguments_as_str",
description: r##"# `const_arguments_as_str`
The tracking issue for this feature is: [#103900]
[#103900]: https://github.com/rust-lang/rust/issues/103900
------------------------
"##,
},
Lint {
label: "const_array_from_ref",
description: r##"# `const_array_from_ref`
The tracking issue for this feature is: [#90206]
[#90206]: https://github.com/rust-lang/rust/issues/90206
------------------------
"##,
},
Lint {
label: "const_array_into_iter_constructors",
description: r##"# `const_array_into_iter_constructors`
The tracking issue for this feature is: [#91583]
[#91583]: https://github.com/rust-lang/rust/issues/91583
------------------------
"##,
},
Lint {
label: "const_assert_type2",
description: r##"# `const_assert_type2`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_assume",
description: r##"# `const_assume`
The tracking issue for this feature is: [#76972]
[#76972]: https://github.com/rust-lang/rust/issues/76972
------------------------
"##,
},
Lint {
label: "const_async_blocks",
description: r##"# `const_async_blocks`
The tracking issue for this feature is: [#85368]
[#85368]: https://github.com/rust-lang/rust/issues/85368
------------------------
"##,
},
Lint {
label: "const_bigint_helper_methods",
description: r##"# `const_bigint_helper_methods`
The tracking issue for this feature is: [#85532]
[#85532]: https://github.com/rust-lang/rust/issues/85532
------------------------
"##,
},
Lint {
label: "const_black_box",
description: r##"# `const_black_box`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_box",
description: r##"# `const_box`
The tracking issue for this feature is: [#92521]
[#92521]: https://github.com/rust-lang/rust/issues/92521
------------------------
"##,
},
Lint {
label: "const_btree_len",
description: r##"# `const_btree_len`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_caller_location",
description: r##"# `const_caller_location`
The tracking issue for this feature is: [#76156]
[#76156]: https://github.com/rust-lang/rust/issues/76156
------------------------
"##,
},
Lint {
label: "const_cell_into_inner",
description: r##"# `const_cell_into_inner`
The tracking issue for this feature is: [#78729]
[#78729]: https://github.com/rust-lang/rust/issues/78729
------------------------
"##,
},
Lint {
label: "const_char_from_u32_unchecked",
description: r##"# `const_char_from_u32_unchecked`
The tracking issue for this feature is: [#89259]
[#89259]: https://github.com/rust-lang/rust/issues/89259
------------------------
"##,
},
Lint {
label: "const_closures",
description: r##"# `const_closures`
The tracking issue for this feature is: [#106003]
[#106003]: https://github.com/rust-lang/rust/issues/106003
------------------------
"##,
},
Lint {
label: "const_collections_with_hasher",
description: r##"# `const_collections_with_hasher`
The tracking issue for this feature is: [#102575]
[#102575]: https://github.com/rust-lang/rust/issues/102575
------------------------
"##,
},
Lint {
label: "const_cow_is_borrowed",
description: r##"# `const_cow_is_borrowed`
The tracking issue for this feature is: [#65143]
[#65143]: https://github.com/rust-lang/rust/issues/65143
------------------------
"##,
},
Lint {
label: "const_cstr_from_ptr",
description: r##"# `const_cstr_from_ptr`
The tracking issue for this feature is: [#113219]
[#113219]: https://github.com/rust-lang/rust/issues/113219
------------------------
"##,
},
Lint {
label: "const_discriminant",
description: r##"# `const_discriminant`
The tracking issue for this feature is: [#69821]
[#69821]: https://github.com/rust-lang/rust/issues/69821
------------------------
"##,
},
Lint {
label: "const_eval_select",
description: r##"# `const_eval_select`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_exact_div",
description: r##"# `const_exact_div`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_extern_fn",
description: r##"# `const_extern_fn`
The tracking issue for this feature is: [#64926]
[#64926]: https://github.com/rust-lang/rust/issues/64926
------------------------
"##,
},
Lint {
label: "const_float_bits_conv",
description: r##"# `const_float_bits_conv`
The tracking issue for this feature is: [#72447]
[#72447]: https://github.com/rust-lang/rust/issues/72447
------------------------
"##,
},
Lint {
label: "const_float_classify",
description: r##"# `const_float_classify`
The tracking issue for this feature is: [#72505]
[#72505]: https://github.com/rust-lang/rust/issues/72505
------------------------
"##,
},
Lint {
label: "const_fmt_arguments_new",
description: r##"# `const_fmt_arguments_new`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_fn_floating_point_arithmetic",
description: r##"# `const_fn_floating_point_arithmetic`
The tracking issue for this feature is: [#57241]
[#57241]: https://github.com/rust-lang/rust/issues/57241
------------------------
"##,
},
Lint {
label: "const_for",
description: r##"# `const_for`
The tracking issue for this feature is: [#87575]
[#87575]: https://github.com/rust-lang/rust/issues/87575
------------------------
"##,
},
Lint {
label: "const_format_args",
description: r##"# `const_format_args`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_hash",
description: r##"# `const_hash`
The tracking issue for this feature is: [#104061]
[#104061]: https://github.com/rust-lang/rust/issues/104061
------------------------
"##,
},
Lint {
label: "const_heap",
description: r##"# `const_heap`
The tracking issue for this feature is: [#79597]
[#79597]: https://github.com/rust-lang/rust/issues/79597
------------------------
"##,
},
Lint {
label: "const_index_range_slice_index",
description: r##"# `const_index_range_slice_index`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_inherent_unchecked_arith",
description: r##"# `const_inherent_unchecked_arith`
The tracking issue for this feature is: [#85122]
[#85122]: https://github.com/rust-lang/rust/issues/85122
------------------------
"##,
},
Lint {
label: "const_int_unchecked_arith",
description: r##"# `const_int_unchecked_arith`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_intoiterator_identity",
description: r##"# `const_intoiterator_identity`
The tracking issue for this feature is: [#90603]
[#90603]: https://github.com/rust-lang/rust/issues/90603
------------------------
"##,
},
Lint {
label: "const_intrinsic_compare_bytes",
description: r##"# `const_intrinsic_compare_bytes`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_intrinsic_forget",
description: r##"# `const_intrinsic_forget`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_intrinsic_raw_eq",
description: r##"# `const_intrinsic_raw_eq`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_io_structs",
description: r##"# `const_io_structs`
The tracking issue for this feature is: [#78812]
[#78812]: https://github.com/rust-lang/rust/issues/78812
------------------------
"##,
},
Lint {
label: "const_ip",
description: r##"# `const_ip`
The tracking issue for this feature is: [#76205]
[#76205]: https://github.com/rust-lang/rust/issues/76205
------------------------
"##,
},
Lint {
label: "const_ipv4",
description: r##"# `const_ipv4`
The tracking issue for this feature is: [#76205]
[#76205]: https://github.com/rust-lang/rust/issues/76205
------------------------
"##,
},
Lint {
label: "const_ipv6",
description: r##"# `const_ipv6`
The tracking issue for this feature is: [#76205]
[#76205]: https://github.com/rust-lang/rust/issues/76205
------------------------
"##,
},
Lint {
label: "const_likely",
description: r##"# `const_likely`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_location_fields",
description: r##"# `const_location_fields`
The tracking issue for this feature is: [#102911]
[#102911]: https://github.com/rust-lang/rust/issues/102911
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_array_assume_init",
description: r##"# `const_maybe_uninit_array_assume_init`
The tracking issue for this feature is: [#96097]
[#96097]: https://github.com/rust-lang/rust/issues/96097
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_as_mut_ptr",
description: r##"# `const_maybe_uninit_as_mut_ptr`
The tracking issue for this feature is: [#75251]
[#75251]: https://github.com/rust-lang/rust/issues/75251
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_assume_init",
description: r##"# `const_maybe_uninit_assume_init`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_assume_init_read",
description: r##"# `const_maybe_uninit_assume_init_read`
The tracking issue for this feature is: [#63567]
[#63567]: https://github.com/rust-lang/rust/issues/63567
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_uninit_array",
description: r##"# `const_maybe_uninit_uninit_array`
The tracking issue for this feature is: [#96097]
[#96097]: https://github.com/rust-lang/rust/issues/96097
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_write",
description: r##"# `const_maybe_uninit_write`
The tracking issue for this feature is: [#63567]
[#63567]: https://github.com/rust-lang/rust/issues/63567
------------------------
"##,
},
Lint {
label: "const_maybe_uninit_zeroed",
description: r##"# `const_maybe_uninit_zeroed`
The tracking issue for this feature is: [#91850]
[#91850]: https://github.com/rust-lang/rust/issues/91850
------------------------
"##,
},
Lint {
label: "const_mut_refs",
description: r##"# `const_mut_refs`
The tracking issue for this feature is: [#57349]
[#57349]: https://github.com/rust-lang/rust/issues/57349
------------------------
"##,
},
Lint {
label: "const_nonnull_new",
description: r##"# `const_nonnull_new`
The tracking issue for this feature is: [#93235]
[#93235]: https://github.com/rust-lang/rust/issues/93235
------------------------
"##,
},
Lint {
label: "const_num_midpoint",
description: r##"# `const_num_midpoint`
The tracking issue for this feature is: [#110840]
[#110840]: https://github.com/rust-lang/rust/issues/110840
------------------------
"##,
},
Lint {
label: "const_option",
description: r##"# `const_option`
The tracking issue for this feature is: [#67441]
[#67441]: https://github.com/rust-lang/rust/issues/67441
------------------------
"##,
},
Lint {
label: "const_option_ext",
description: r##"# `const_option_ext`
The tracking issue for this feature is: [#91930]
[#91930]: https://github.com/rust-lang/rust/issues/91930
------------------------
"##,
},
Lint {
label: "const_pin",
description: r##"# `const_pin`
The tracking issue for this feature is: [#76654]
[#76654]: https://github.com/rust-lang/rust/issues/76654
------------------------
"##,
},
Lint {
label: "const_pointer_byte_offsets",
description: r##"# `const_pointer_byte_offsets`
The tracking issue for this feature is: [#96283]
[#96283]: https://github.com/rust-lang/rust/issues/96283
------------------------
"##,
},
Lint {
label: "const_pointer_is_aligned",
description: r##"# `const_pointer_is_aligned`
The tracking issue for this feature is: [#104203]
[#104203]: https://github.com/rust-lang/rust/issues/104203
------------------------
"##,
},
Lint {
label: "const_precise_live_drops",
description: r##"# `const_precise_live_drops`
The tracking issue for this feature is: [#73255]
[#73255]: https://github.com/rust-lang/rust/issues/73255
------------------------
"##,
},
Lint {
label: "const_pref_align_of",
description: r##"# `const_pref_align_of`
The tracking issue for this feature is: [#91971]
[#91971]: https://github.com/rust-lang/rust/issues/91971
------------------------
"##,
},
Lint {
label: "const_ptr_as_ref",
description: r##"# `const_ptr_as_ref`
The tracking issue for this feature is: [#91822]
[#91822]: https://github.com/rust-lang/rust/issues/91822
------------------------
"##,
},
Lint {
label: "const_ptr_is_null",
description: r##"# `const_ptr_is_null`
The tracking issue for this feature is: [#74939]
[#74939]: https://github.com/rust-lang/rust/issues/74939
------------------------
"##,
},
Lint {
label: "const_ptr_sub_ptr",
description: r##"# `const_ptr_sub_ptr`
The tracking issue for this feature is: [#95892]
[#95892]: https://github.com/rust-lang/rust/issues/95892
------------------------
"##,
},
Lint {
label: "const_ptr_write",
description: r##"# `const_ptr_write`
The tracking issue for this feature is: [#86302]
[#86302]: https://github.com/rust-lang/rust/issues/86302
------------------------
"##,
},
Lint {
label: "const_range_bounds",
description: r##"# `const_range_bounds`
The tracking issue for this feature is: [#108082]
[#108082]: https://github.com/rust-lang/rust/issues/108082
------------------------
"##,
},
Lint {
label: "const_raw_ptr_comparison",
description: r##"# `const_raw_ptr_comparison`
The tracking issue for this feature is: [#53020]
[#53020]: https://github.com/rust-lang/rust/issues/53020
------------------------
"##,
},
Lint {
label: "const_refs_to_cell",
description: r##"# `const_refs_to_cell`
The tracking issue for this feature is: [#80384]
[#80384]: https://github.com/rust-lang/rust/issues/80384
------------------------
"##,
},
Lint {
label: "const_replace",
description: r##"# `const_replace`
The tracking issue for this feature is: [#83164]
[#83164]: https://github.com/rust-lang/rust/issues/83164
------------------------
"##,
},
Lint {
label: "const_result",
description: r##"# `const_result`
The tracking issue for this feature is: [#82814]
[#82814]: https://github.com/rust-lang/rust/issues/82814
------------------------
"##,
},
Lint {
label: "const_size_of_val",
description: r##"# `const_size_of_val`
The tracking issue for this feature is: [#46571]
[#46571]: https://github.com/rust-lang/rust/issues/46571
------------------------
"##,
},
Lint {
label: "const_size_of_val_raw",
description: r##"# `const_size_of_val_raw`
The tracking issue for this feature is: [#46571]
[#46571]: https://github.com/rust-lang/rust/issues/46571
------------------------
"##,
},
Lint {
label: "const_slice_first_last",
description: r##"# `const_slice_first_last`
The tracking issue for this feature is: [#83570]
[#83570]: https://github.com/rust-lang/rust/issues/83570
------------------------
"##,
},
Lint {
label: "const_slice_from_mut_ptr_range",
description: r##"# `const_slice_from_mut_ptr_range`
The tracking issue for this feature is: [#89792]
[#89792]: https://github.com/rust-lang/rust/issues/89792
------------------------
"##,
},
Lint {
label: "const_slice_from_ptr_range",
description: r##"# `const_slice_from_ptr_range`
The tracking issue for this feature is: [#89792]
[#89792]: https://github.com/rust-lang/rust/issues/89792
------------------------
"##,
},
Lint {
label: "const_slice_from_raw_parts_mut",
description: r##"# `const_slice_from_raw_parts_mut`
The tracking issue for this feature is: [#67456]
[#67456]: https://github.com/rust-lang/rust/issues/67456
------------------------
"##,
},
Lint {
label: "const_slice_from_ref",
description: r##"# `const_slice_from_ref`
The tracking issue for this feature is: [#90206]
[#90206]: https://github.com/rust-lang/rust/issues/90206
------------------------
"##,
},
Lint {
label: "const_slice_index",
description: r##"# `const_slice_index`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "const_slice_ptr_len",
description: r##"# `const_slice_ptr_len`
The tracking issue for this feature is: [#71146]
[#71146]: https://github.com/rust-lang/rust/issues/71146
------------------------
"##,
},
Lint {
label: "const_slice_split_at_mut",
description: r##"# `const_slice_split_at_mut`
The tracking issue for this feature is: [#101804]
[#101804]: https://github.com/rust-lang/rust/issues/101804
------------------------
"##,
},
Lint {
label: "const_str_from_utf8",
description: r##"# `const_str_from_utf8`
The tracking issue for this feature is: [#91006]
[#91006]: https://github.com/rust-lang/rust/issues/91006
------------------------
"##,
},
Lint {
label: "const_str_from_utf8_unchecked_mut",
description: r##"# `const_str_from_utf8_unchecked_mut`
The tracking issue for this feature is: [#91005]
[#91005]: https://github.com/rust-lang/rust/issues/91005
------------------------
"##,
},
Lint {
label: "const_swap",
description: r##"# `const_swap`
The tracking issue for this feature is: [#83163]
[#83163]: https://github.com/rust-lang/rust/issues/83163
------------------------
"##,
},
Lint {
label: "const_trait_impl",
description: r##"# `const_trait_impl`
The tracking issue for this feature is: [#67792]
[#67792]: https://github.com/rust-lang/rust/issues/67792
------------------------
"##,
},
Lint {
label: "const_try",
description: r##"# `const_try`
The tracking issue for this feature is: [#74935]
[#74935]: https://github.com/rust-lang/rust/issues/74935
------------------------
"##,
},
Lint {
label: "const_type_id",
description: r##"# `const_type_id`
The tracking issue for this feature is: [#77125]
[#77125]: https://github.com/rust-lang/rust/issues/77125
------------------------
"##,
},
Lint {
label: "const_type_name",
description: r##"# `const_type_name`
The tracking issue for this feature is: [#63084]
[#63084]: https://github.com/rust-lang/rust/issues/63084
------------------------
"##,
},
Lint {
label: "const_unicode_case_lookup",
description: r##"# `const_unicode_case_lookup`
The tracking issue for this feature is: [#101400]
[#101400]: https://github.com/rust-lang/rust/issues/101400
------------------------
"##,
},
Lint {
label: "const_unsafecell_get_mut",
description: r##"# `const_unsafecell_get_mut`
The tracking issue for this feature is: [#88836]
[#88836]: https://github.com/rust-lang/rust/issues/88836
------------------------
"##,
},
Lint {
label: "const_waker",
description: r##"# `const_waker`
The tracking issue for this feature is: [#102012]
[#102012]: https://github.com/rust-lang/rust/issues/102012
------------------------
"##,
},
Lint {
label: "container_error_extra",
description: r##"# `container_error_extra`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "control_flow_enum",
description: r##"# `control_flow_enum`
The tracking issue for this feature is: [#75744]
[#75744]: https://github.com/rust-lang/rust/issues/75744
------------------------
"##,
},
Lint {
label: "convert_float_to_int",
description: r##"# `convert_float_to_int`
The tracking issue for this feature is: [#67057]
[#67057]: https://github.com/rust-lang/rust/issues/67057
------------------------
"##,
},
Lint {
@@ -1737,27 +3815,112 @@ fn foobar() -> u32 { 23 }
"##,
},
Lint {
label: "crate_visibility_modifier",
description: r##"# `crate_visibility_modifier`
label: "coverage_attribute",
description: r##"# `coverage_attribute`
The tracking issue for this feature is: [#53120]
The tracking issue for this feature is: [#84605]
[#53120]: https://github.com/rust-lang/rust/issues/53120
[#84605]: https://github.com/rust-lang/rust/issues/84605
-----
---
The `crate_visibility_modifier` feature allows the `crate` keyword to be used
as a visibility modifier synonymous to `pub(crate)`, indicating that a type
(function, _&c._) is to be visible to the entire enclosing crate, but not to
other crates.
The `coverage` attribute can be used to selectively disable coverage
instrumentation in an annotated function. This might be useful to:
- Avoid instrumentation overhead in a performance critical function
- Avoid generating coverage for a function that is not meant to be executed,
but still target 100% coverage for the rest of the program.
## Example
```rust
#![feature(crate_visibility_modifier)]
#![feature(coverage_attribute)]
crate struct Foo {
bar: usize,
// `foo()` will get coverage instrumentation (by default)
fn foo() {
// ...
}
#[coverage(off)]
fn bar() {
// ...
}
```
"##,
},
Lint {
label: "cow_is_borrowed",
description: r##"# `cow_is_borrowed`
The tracking issue for this feature is: [#65143]
[#65143]: https://github.com/rust-lang/rust/issues/65143
------------------------
"##,
},
Lint {
label: "csky_target_feature",
description: r##"# `csky_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "cstr_count_bytes",
description: r##"# `cstr_count_bytes`
The tracking issue for this feature is: [#114441]
[#114441]: https://github.com/rust-lang/rust/issues/114441
------------------------
"##,
},
Lint {
label: "cursor_remaining",
description: r##"# `cursor_remaining`
The tracking issue for this feature is: [#86369]
[#86369]: https://github.com/rust-lang/rust/issues/86369
------------------------
"##,
},
Lint {
label: "custom_code_classes_in_docs",
description: r##"# `custom_code_classes_in_docs`
The tracking issue for this feature is: [#79483]
[#79483]: https://github.com/rust-lang/rust/issues/79483
------------------------
"##,
},
Lint {
label: "custom_inner_attributes",
description: r##"# `custom_inner_attributes`
The tracking issue for this feature is: [#54726]
[#54726]: https://github.com/rust-lang/rust/issues/54726
------------------------
"##,
},
Lint {
label: "custom_mir",
description: r##"# `custom_mir`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
@@ -1794,6 +3957,17 @@ fn my_runner(tests: &[&i32]) {
#[test_case]
const WILL_FAIL: i32 = 4;
```
"##,
},
Lint {
label: "deadline_api",
description: r##"# `deadline_api`
The tracking issue for this feature is: [#46316]
[#46316]: https://github.com/rust-lang/rust/issues/46316
------------------------
"##,
},
Lint {
@@ -1806,54 +3980,47 @@ fn my_runner(tests: &[&i32]) {
"##,
},
Lint {
label: "default_free_fn",
description: r##"# `default_free_fn`
label: "decl_macro",
description: r##"# `decl_macro`
The tracking issue for this feature is: [#73014]
The tracking issue for this feature is: [#39412]
[#73014]: https://github.com/rust-lang/rust/issues/73014
[#39412]: https://github.com/rust-lang/rust/issues/39412
------------------------
"##,
},
Lint {
label: "default_type_parameter_fallback",
description: r##"# `default_type_parameter_fallback`
Adds a free `default()` function to the `std::default` module. This function
just forwards to [`Default::default()`], but may remove repetition of the word
"default" from the call site.
The tracking issue for this feature is: [#27336]
[`Default::default()`]: https://doc.rust-lang.org/nightly/std/default/trait.Default.html#tymethod.default
[#27336]: https://github.com/rust-lang/rust/issues/27336
Here is an example:
------------------------
"##,
},
Lint {
label: "deprecated_safe",
description: r##"# `deprecated_safe`
```rust
#![feature(default_free_fn)]
use std::default::default;
The tracking issue for this feature is: [#94978]
#[derive(Default)]
struct AppConfig {
foo: FooConfig,
bar: BarConfig,
}
[#94978]: https://github.com/rust-lang/rust/issues/94978
#[derive(Default)]
struct FooConfig {
foo: i32,
}
------------------------
"##,
},
Lint {
label: "deprecated_suggestion",
description: r##"# `deprecated_suggestion`
#[derive(Default)]
struct BarConfig {
bar: f32,
baz: u8,
}
The tracking issue for this feature is: [#94785]
fn main() {
let options = AppConfig {
foo: default(),
bar: BarConfig {
bar: 10.1,
..default()
},
};
}
```
[#94785]: https://github.com/rust-lang/rust/issues/94785
------------------------
"##,
},
Lint {
@@ -1862,6 +4029,15 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "derive_const",
description: r##"# `derive_const`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
@@ -1871,6 +4047,79 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "diagnostic_namespace",
description: r##"# `diagnostic_namespace`
The tracking issue for this feature is: [#111996]
[#111996]: https://github.com/rust-lang/rust/issues/111996
------------------------
"##,
},
Lint {
label: "dir_entry_ext2",
description: r##"# `dir_entry_ext2`
The tracking issue for this feature is: [#85573]
[#85573]: https://github.com/rust-lang/rust/issues/85573
------------------------
"##,
},
Lint {
label: "discriminant_kind",
description: r##"# `discriminant_kind`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "dispatch_from_dyn",
description: r##"# `dispatch_from_dyn`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "div_duration",
description: r##"# `div_duration`
The tracking issue for this feature is: [#63139]
[#63139]: https://github.com/rust-lang/rust/issues/63139
------------------------
"##,
},
Lint {
label: "do_not_recommend",
description: r##"# `do_not_recommend`
The tracking issue for this feature is: [#51992]
[#51992]: https://github.com/rust-lang/rust/issues/51992
------------------------
"##,
},
Lint {
label: "doc_auto_cfg",
description: r##"# `doc_auto_cfg`
The tracking issue for this feature is: [#43781]
[#43781]: https://github.com/rust-lang/rust/issues/43781
------------------------
"##,
},
@@ -1885,7 +4134,7 @@ fn main() {
The `doc_cfg` feature allows an API be documented as only available in some specific platforms.
This attribute has two effects:
1. In the annotated item's documentation, there will be a message saying "This is supported on
1. In the annotated item's documentation, there will be a message saying "Available on
(platform) only".
2. The item's doc-tests will only run on the specific platform.
@@ -1922,6 +4171,17 @@ pub struct Icon {
[#43781]: https://github.com/rust-lang/rust/issues/43781
[#43348]: https://github.com/rust-lang/rust/issues/43348
"##,
},
Lint {
label: "doc_cfg_hide",
description: r##"# `doc_cfg_hide`
The tracking issue for this feature is: [#43781]
[#43781]: https://github.com/rust-lang/rust/issues/43781
------------------------
"##,
},
Lint {
@@ -1987,6 +4247,180 @@ pub fn my_fn() -> MyStruct { MyStruct }
[#45040]: https://github.com/rust-lang/rust/issues/45040
[#45039]: https://github.com/rust-lang/rust/pull/45039
[rustdoc-book-notable_trait]: ../../rustdoc/unstable-features.html#adding-your-trait-to-the-notable-traits-dialog
"##,
},
Lint {
label: "downcast_unchecked",
description: r##"# `downcast_unchecked`
The tracking issue for this feature is: [#90850]
[#90850]: https://github.com/rust-lang/rust/issues/90850
------------------------
"##,
},
Lint {
label: "drain_keep_rest",
description: r##"# `drain_keep_rest`
The tracking issue for this feature is: [#101122]
[#101122]: https://github.com/rust-lang/rust/issues/101122
------------------------
"##,
},
Lint {
label: "dropck_eyepatch",
description: r##"# `dropck_eyepatch`
The tracking issue for this feature is: [#34761]
[#34761]: https://github.com/rust-lang/rust/issues/34761
------------------------
"##,
},
Lint {
label: "duration_constants",
description: r##"# `duration_constants`
The tracking issue for this feature is: [#57391]
[#57391]: https://github.com/rust-lang/rust/issues/57391
------------------------
"##,
},
Lint {
label: "duration_consts_float",
description: r##"# `duration_consts_float`
The tracking issue for this feature is: [#72440]
[#72440]: https://github.com/rust-lang/rust/issues/72440
------------------------
"##,
},
Lint {
label: "dyn_star",
description: r##"# `dyn_star`
The tracking issue for this feature is: [#102425]
[#102425]: https://github.com/rust-lang/rust/issues/102425
------------------------
"##,
},
Lint {
label: "edition_panic",
description: r##"# `edition_panic`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "effects",
description: r##"# `effects`
The tracking issue for this feature is: [#102090]
[#102090]: https://github.com/rust-lang/rust/issues/102090
------------------------
"##,
},
Lint {
label: "entry_insert",
description: r##"# `entry_insert`
The tracking issue for this feature is: [#65225]
[#65225]: https://github.com/rust-lang/rust/issues/65225
------------------------
"##,
},
Lint {
label: "ermsb_target_feature",
description: r##"# `ermsb_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "error_generic_member_access",
description: r##"# `error_generic_member_access`
The tracking issue for this feature is: [#99301]
[#99301]: https://github.com/rust-lang/rust/issues/99301
------------------------
"##,
},
Lint {
label: "error_in_core",
description: r##"# `error_in_core`
The tracking issue for this feature is: [#103765]
[#103765]: https://github.com/rust-lang/rust/issues/103765
------------------------
"##,
},
Lint {
label: "error_iter",
description: r##"# `error_iter`
The tracking issue for this feature is: [#58520]
[#58520]: https://github.com/rust-lang/rust/issues/58520
------------------------
"##,
},
Lint {
label: "error_reporter",
description: r##"# `error_reporter`
The tracking issue for this feature is: [#90172]
[#90172]: https://github.com/rust-lang/rust/issues/90172
------------------------
"##,
},
Lint {
label: "error_type_id",
description: r##"# `error_type_id`
The tracking issue for this feature is: [#60784]
[#60784]: https://github.com/rust-lang/rust/issues/60784
------------------------
"##,
},
Lint {
label: "exact_size_is_empty",
description: r##"# `exact_size_is_empty`
The tracking issue for this feature is: [#35428]
[#35428]: https://github.com/rust-lang/rust/issues/35428
------------------------
"##,
},
Lint {
@@ -2020,60 +4454,105 @@ pub fn my_fn() -> MyStruct { MyStruct }
"##,
},
Lint {
label: "explicit_generic_args_with_impl_trait",
description: r##"# `explicit_generic_args_with_impl_trait`
label: "exclusive_wrapper",
description: r##"# `exclusive_wrapper`
The tracking issue for this feature is: [#83701]
The tracking issue for this feature is: [#98407]
[#83701]: https://github.com/rust-lang/rust/issues/83701
[#98407]: https://github.com/rust-lang/rust/issues/98407
------------------------
"##,
},
Lint {
label: "exhaustive_patterns",
description: r##"# `exhaustive_patterns`
The tracking issue for this feature is: [#51085]
[#51085]: https://github.com/rust-lang/rust/issues/51085
------------------------
"##,
},
Lint {
label: "exit_status_error",
description: r##"# `exit_status_error`
The tracking issue for this feature is: [#84908]
[#84908]: https://github.com/rust-lang/rust/issues/84908
------------------------
"##,
},
Lint {
label: "exitcode_exit_method",
description: r##"# `exitcode_exit_method`
The tracking issue for this feature is: [#97100]
[#97100]: https://github.com/rust-lang/rust/issues/97100
------------------------
"##,
},
Lint {
label: "explicit_tail_calls",
description: r##"# `explicit_tail_calls`
The tracking issue for this feature is: [#112788]
[#112788]: https://github.com/rust-lang/rust/issues/112788
------------------------
"##,
},
Lint {
label: "extend_one",
description: r##"# `extend_one`
The tracking issue for this feature is: [#72631]
[#72631]: https://github.com/rust-lang/rust/issues/72631
------------------------
"##,
},
Lint {
label: "extended_varargs_abi_support",
description: r##"# `extended_varargs_abi_support`
The tracking issue for this feature is: [#100189]
[#100189]: https://github.com/rust-lang/rust/issues/100189
------------------------
The `explicit_generic_args_with_impl_trait` feature gate lets you specify generic arguments even
when `impl Trait` is used in argument position.
This feature adds the possibility of using `sysv64`, `win64` or `efiapi` calling
conventions on functions with varargs.
"##,
},
Lint {
label: "extern_types",
description: r##"# `extern_types`
A simple example is:
The tracking issue for this feature is: [#43467]
```rust
#![feature(explicit_generic_args_with_impl_trait)]
[#43467]: https://github.com/rust-lang/rust/issues/43467
fn foo<T: ?Sized>(_f: impl AsRef<T>) {}
------------------------
"##,
},
Lint {
label: "extract_if",
description: r##"# `extract_if`
fn main() {
foo::<str>("".to_string());
}
```
The tracking issue for this feature is: [#43244]
This is currently rejected:
[#43244]: https://github.com/rust-lang/rust/issues/43244
```text
error[E0632]: cannot provide explicit generic arguments when `impl Trait` is used in argument position
--> src/main.rs:6:11
|
6 | foo::<str>("".to_string());
| ^^^ explicit generic argument not allowed
```
However it would compile if `explicit_generic_args_with_impl_trait` is enabled.
Note that the synthetic type parameters from `impl Trait` are still implicit and you
cannot explicitly specify these:
```rust,compile_fail
#![feature(explicit_generic_args_with_impl_trait)]
fn foo<T: ?Sized>(_f: impl AsRef<T>) {}
fn bar<T: ?Sized, F: AsRef<T>>(_f: F) {}
fn main() {
bar::<str, _>("".to_string()); // Okay
bar::<str, String>("".to_string()); // Okay
foo::<str>("".to_string()); // Okay
foo::<str, String>("".to_string()); // Error, you cannot specify `impl Trait` explicitly
}
```
------------------------
"##,
},
Lint {
@@ -2208,6 +4687,72 @@ fn main() {
[ARM C/C++ compiler]: http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0491c/Cacigdac.html
[GCC]: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-pure-function-attribute
[IBM ILE C/C++]: https://www.ibm.com/support/knowledgecenter/fr/ssw_ibm_i_71/rzarg/fn_attrib_pure.htm
"##,
},
Lint {
label: "ffi_returns_twice",
description: r##"# `ffi_returns_twice`
The tracking issue for this feature is: [#58314]
[#58314]: https://github.com/rust-lang/rust/issues/58314
------------------------
"##,
},
Lint {
label: "file_create_new",
description: r##"# `file_create_new`
The tracking issue for this feature is: [#105135]
[#105135]: https://github.com/rust-lang/rust/issues/105135
------------------------
"##,
},
Lint {
label: "file_set_times",
description: r##"# `file_set_times`
The tracking issue for this feature is: [#98245]
[#98245]: https://github.com/rust-lang/rust/issues/98245
------------------------
"##,
},
Lint {
label: "float_gamma",
description: r##"# `float_gamma`
The tracking issue for this feature is: [#99842]
[#99842]: https://github.com/rust-lang/rust/issues/99842
------------------------
"##,
},
Lint {
label: "float_minimum_maximum",
description: r##"# `float_minimum_maximum`
The tracking issue for this feature is: [#91079]
[#91079]: https://github.com/rust-lang/rust/issues/91079
------------------------
"##,
},
Lint {
label: "float_next_up_down",
description: r##"# `float_next_up_down`
The tracking issue for this feature is: [#91399]
[#91399]: https://github.com/rust-lang/rust/issues/91399
------------------------
"##,
},
Lint {
@@ -2216,6 +4761,15 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "fmt_helpers_for_derive",
description: r##"# `fmt_helpers_for_derive`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
@@ -2225,6 +4779,26 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "fn_align",
description: r##"# `fn_align`
The tracking issue for this feature is: [#82232]
[#82232]: https://github.com/rust-lang/rust/issues/82232
------------------------
"##,
},
Lint {
label: "fn_ptr_trait",
description: r##"# `fn_ptr_trait`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
@@ -2243,7 +4817,7 @@ fn main() {
The `fn_traits` feature allows for implementation of the [`Fn*`] traits
for creating custom closure-like types.
[`Fn*`]: https://doc.rust-lang.org/std/ops/trait.Fn.html
[`Fn*`]: ../../std/ops/trait.Fn.html
```rust
#![feature(unboxed_closures)]
@@ -2265,6 +4839,90 @@ fn main() {
assert_eq!(adder(2), 5);
}
```
"##,
},
Lint {
label: "forget_unsized",
description: r##"# `forget_unsized`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "format_args_nl",
description: r##"# `format_args_nl`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "fs_try_exists",
description: r##"# `fs_try_exists`
The tracking issue for this feature is: [#83186]
[#83186]: https://github.com/rust-lang/rust/issues/83186
------------------------
"##,
},
Lint {
label: "fundamental",
description: r##"# `fundamental`
The tracking issue for this feature is: [#29635]
[#29635]: https://github.com/rust-lang/rust/issues/29635
------------------------
"##,
},
Lint {
label: "future_join",
description: r##"# `future_join`
The tracking issue for this feature is: [#91642]
[#91642]: https://github.com/rust-lang/rust/issues/91642
------------------------
"##,
},
Lint {
label: "gen_future",
description: r##"# `gen_future`
The tracking issue for this feature is: [#50547]
[#50547]: https://github.com/rust-lang/rust/issues/50547
------------------------
"##,
},
Lint {
label: "generator_clone",
description: r##"# `generator_clone`
The tracking issue for this feature is: [#95360]
[#95360]: https://github.com/rust-lang/rust/issues/95360
------------------------
"##,
},
Lint {
label: "generator_trait",
description: r##"# `generator_trait`
The tracking issue for this feature is: [#43122]
[#43122]: https://github.com/rust-lang/rust/issues/43122
------------------------
"##,
},
Lint {
@@ -2518,82 +5176,253 @@ fn resume(mut self: Pin<&mut Self>, resume: ()) -> GeneratorState<i32, &'static
"##,
},
Lint {
label: "half_open_range_patterns",
description: r##"# `half_open_range_patterns`
label: "generic_arg_infer",
description: r##"# `generic_arg_infer`
The tracking issue for this feature is: [#85077]
[#85077]: https://github.com/rust-lang/rust/issues/85077
------------------------
"##,
},
Lint {
label: "generic_assert",
description: r##"# `generic_assert`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "generic_assert_internals",
description: r##"# `generic_assert_internals`
The tracking issue for this feature is: [#44838]
[#44838]: https://github.com/rust-lang/rust/issues/44838
------------------------
"##,
},
Lint {
label: "generic_associated_types_extended",
description: r##"# `generic_associated_types_extended`
The tracking issue for this feature is: [#95451]
[#95451]: https://github.com/rust-lang/rust/issues/95451
------------------------
"##,
},
Lint {
label: "generic_const_exprs",
description: r##"# `generic_const_exprs`
The tracking issue for this feature is: [#76560]
[#76560]: https://github.com/rust-lang/rust/issues/76560
------------------------
"##,
},
Lint {
label: "generic_const_items",
description: r##"# `generic_const_items`
The tracking issue for this feature is: [#113521]
[#113521]: https://github.com/rust-lang/rust/issues/113521
------------------------
"##,
},
Lint {
label: "get_many_mut",
description: r##"# `get_many_mut`
The tracking issue for this feature is: [#104642]
[#104642]: https://github.com/rust-lang/rust/issues/104642
------------------------
"##,
},
Lint {
label: "get_mut_unchecked",
description: r##"# `get_mut_unchecked`
The tracking issue for this feature is: [#63292]
[#63292]: https://github.com/rust-lang/rust/issues/63292
------------------------
"##,
},
Lint {
label: "half_open_range_patterns_in_slices",
description: r##"# `half_open_range_patterns_in_slices`
The tracking issue for this feature is: [#67264]
It is part of the `#![exclusive_range_pattern]` feature,
It is part of the `exclusive_range_pattern` feature,
tracked at [#37854].
[#67264]: https://github.com/rust-lang/rust/issues/67264
[#37854]: https://github.com/rust-lang/rust/issues/37854
-----
The `half_open_range_patterns` feature allows RangeTo patterns
(`..10`) to be used in appropriate pattern matching contexts.
This requires also enabling the `exclusive_range_pattern` feature.
It also enabled RangeFrom patterns but that has since been
stabilized.
This feature allow using top-level half-open range patterns in slices.
```rust
#![feature(half_open_range_patterns)]
#![feature(half_open_range_patterns_in_slices)]
#![feature(exclusive_range_pattern)]
let x = 5;
match x {
..0 => println!("negative!"), // "RangeTo" pattern. Unstable.
0 => println!("zero!"),
1.. => println!("positive!"), // "RangeFrom" pattern. Stable.
}
fn main() {
let xs = [13, 1, 5, 2, 3, 1, 21, 8];
let [a @ 3.., b @ ..3, c @ 4..6, ..] = xs else { return; };
}
```
Note that this feature is not required if the patterns are wrapped between parenthesis.
```rust
fn main() {
let xs = [13, 1];
let [(a @ 3..), c] = xs else { return; };
}
```
"##,
},
Lint {
label: "infer_static_outlives_requirements",
description: r##"# `infer_static_outlives_requirements`
label: "hash_extract_if",
description: r##"# `hash_extract_if`
The tracking issue for this feature is: [#54185]
The tracking issue for this feature is: [#59618]
[#54185]: https://github.com/rust-lang/rust/issues/54185
[#59618]: https://github.com/rust-lang/rust/issues/59618
------------------------
The `infer_static_outlives_requirements` feature indicates that certain
`'static` outlives requirements can be inferred by the compiler rather than
stating them explicitly.
"##,
},
Lint {
label: "hash_raw_entry",
description: r##"# `hash_raw_entry`
Note: It is an accompanying feature to `infer_outlives_requirements`,
which must be enabled to infer outlives requirements.
The tracking issue for this feature is: [#56167]
For example, currently generic struct definitions that contain
references, require where-clauses of the form T: 'static. By using
this feature the outlives predicates will be inferred, although
they may still be written explicitly.
[#56167]: https://github.com/rust-lang/rust/issues/56167
```rust,ignore (pseudo-Rust)
struct Foo<U> where U: 'static { // <-- currently required
bar: Bar<U>
}
struct Bar<T: 'static> {
x: T,
}
```
------------------------
"##,
},
Lint {
label: "hash_set_entry",
description: r##"# `hash_set_entry`
The tracking issue for this feature is: [#60896]
## Examples:
[#60896]: https://github.com/rust-lang/rust/issues/60896
```rust,ignore (pseudo-Rust)
#![feature(infer_outlives_requirements)]
#![feature(infer_static_outlives_requirements)]
------------------------
"##,
},
Lint {
label: "hasher_prefixfree_extras",
description: r##"# `hasher_prefixfree_extras`
#[rustc_outlives]
// Implicitly infer U: 'static
struct Foo<U> {
bar: Bar<U>
}
struct Bar<T: 'static> {
x: T,
}
```
The tracking issue for this feature is: [#96762]
[#96762]: https://github.com/rust-lang/rust/issues/96762
------------------------
"##,
},
Lint {
label: "hashmap_internals",
description: r##"# `hashmap_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "hexagon_target_feature",
description: r##"# `hexagon_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "hint_must_use",
description: r##"# `hint_must_use`
The tracking issue for this feature is: [#94745]
[#94745]: https://github.com/rust-lang/rust/issues/94745
------------------------
"##,
},
Lint {
label: "if_let_guard",
description: r##"# `if_let_guard`
The tracking issue for this feature is: [#51114]
[#51114]: https://github.com/rust-lang/rust/issues/51114
------------------------
"##,
},
Lint {
label: "impl_trait_in_assoc_type",
description: r##"# `impl_trait_in_assoc_type`
The tracking issue for this feature is: [#63063]
[#63063]: https://github.com/rust-lang/rust/issues/63063
------------------------
"##,
},
Lint {
label: "impl_trait_in_fn_trait_return",
description: r##"# `impl_trait_in_fn_trait_return`
The tracking issue for this feature is: [#99697]
[#99697]: https://github.com/rust-lang/rust/issues/99697
------------------------
"##,
},
Lint {
label: "imported_main",
description: r##"# `imported_main`
The tracking issue for this feature is: [#28937]
[#28937]: https://github.com/rust-lang/rust/issues/28937
------------------------
"##,
},
Lint {
label: "inherent_associated_types",
description: r##"# `inherent_associated_types`
The tracking issue for this feature is: [#8995]
[#8995]: https://github.com/rust-lang/rust/issues/8995
------------------------
"##,
},
Lint {
@@ -2661,10 +5490,41 @@ const fn one() -> i32 { 1 }
"##,
},
Lint {
label: "int_error_internals",
description: r##"# `int_error_internals`
label: "inplace_iteration",
description: r##"# `inplace_iteration`
This feature is internal to the Rust compiler and is not intended for general use.
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "int_roundings",
description: r##"# `int_roundings`
The tracking issue for this feature is: [#88581]
[#88581]: https://github.com/rust-lang/rust/issues/88581
------------------------
"##,
},
Lint {
label: "integer_atomics",
description: r##"# `integer_atomics`
The tracking issue for this feature is: [#99069]
[#99069]: https://github.com/rust-lang/rust/issues/99069
------------------------
"##,
},
Lint {
label: "internal_impls_macro",
description: r##"# `internal_impls_macro`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
@@ -2718,16 +5578,103 @@ const fn one() -> i32 { 1 }
```rust
#![feature(intrinsics)]
#![allow(internal_features)]
# fn main() {}
extern "rust-intrinsic" {
fn transmute<T, U>(x: T) -> U;
fn offset<T>(dst: *const T, offset: isize) -> *const T;
fn arith_offset<T>(dst: *const T, offset: isize) -> *const T;
}
```
As with any other FFI functions, these are always `unsafe` to call.
"##,
},
Lint {
label: "io_error_downcast",
description: r##"# `io_error_downcast`
The tracking issue for this feature is: [#99262]
[#99262]: https://github.com/rust-lang/rust/issues/99262
------------------------
"##,
},
Lint {
label: "io_error_more",
description: r##"# `io_error_more`
The tracking issue for this feature is: [#86442]
[#86442]: https://github.com/rust-lang/rust/issues/86442
------------------------
"##,
},
Lint {
label: "io_error_uncategorized",
description: r##"# `io_error_uncategorized`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "io_slice_advance",
description: r##"# `io_slice_advance`
The tracking issue for this feature is: [#62726]
[#62726]: https://github.com/rust-lang/rust/issues/62726
------------------------
"##,
},
Lint {
label: "ip",
description: r##"# `ip`
The tracking issue for this feature is: [#27709]
[#27709]: https://github.com/rust-lang/rust/issues/27709
------------------------
"##,
},
Lint {
label: "ip_bits",
description: r##"# `ip_bits`
The tracking issue for this feature is: [#113744]
[#113744]: https://github.com/rust-lang/rust/issues/113744
------------------------
"##,
},
Lint {
label: "ip_in_core",
description: r##"# `ip_in_core`
The tracking issue for this feature is: [#108443]
[#108443]: https://github.com/rust-lang/rust/issues/108443
------------------------
"##,
},
Lint {
label: "is_ascii_octdigit",
description: r##"# `is_ascii_octdigit`
The tracking issue for this feature is: [#101288]
[#101288]: https://github.com/rust-lang/rust/issues/101288
------------------------
"##,
},
Lint {
@@ -2743,6 +5690,160 @@ const fn one() -> i32 { 1 }
Add the methods `is_sorted`, `is_sorted_by` and `is_sorted_by_key` to `[T]`;
add the methods `is_sorted`, `is_sorted_by` and `is_sorted_by_key` to
`Iterator`.
"##,
},
Lint {
label: "isqrt",
description: r##"# `isqrt`
The tracking issue for this feature is: [#116226]
[#116226]: https://github.com/rust-lang/rust/issues/116226
------------------------
"##,
},
Lint {
label: "iter_advance_by",
description: r##"# `iter_advance_by`
The tracking issue for this feature is: [#77404]
[#77404]: https://github.com/rust-lang/rust/issues/77404
------------------------
"##,
},
Lint {
label: "iter_array_chunks",
description: r##"# `iter_array_chunks`
The tracking issue for this feature is: [#100450]
[#100450]: https://github.com/rust-lang/rust/issues/100450
------------------------
"##,
},
Lint {
label: "iter_collect_into",
description: r##"# `iter_collect_into`
The tracking issue for this feature is: [#94780]
[#94780]: https://github.com/rust-lang/rust/issues/94780
------------------------
"##,
},
Lint {
label: "iter_from_generator",
description: r##"# `iter_from_generator`
The tracking issue for this feature is: [#43122]
[#43122]: https://github.com/rust-lang/rust/issues/43122
------------------------
"##,
},
Lint {
label: "iter_intersperse",
description: r##"# `iter_intersperse`
The tracking issue for this feature is: [#79524]
[#79524]: https://github.com/rust-lang/rust/issues/79524
------------------------
"##,
},
Lint {
label: "iter_is_partitioned",
description: r##"# `iter_is_partitioned`
The tracking issue for this feature is: [#62544]
[#62544]: https://github.com/rust-lang/rust/issues/62544
------------------------
"##,
},
Lint {
label: "iter_map_windows",
description: r##"# `iter_map_windows`
The tracking issue for this feature is: [#87155]
[#87155]: https://github.com/rust-lang/rust/issues/87155
------------------------
"##,
},
Lint {
label: "iter_next_chunk",
description: r##"# `iter_next_chunk`
The tracking issue for this feature is: [#98326]
[#98326]: https://github.com/rust-lang/rust/issues/98326
------------------------
"##,
},
Lint {
label: "iter_order_by",
description: r##"# `iter_order_by`
The tracking issue for this feature is: [#64295]
[#64295]: https://github.com/rust-lang/rust/issues/64295
------------------------
"##,
},
Lint {
label: "iter_partition_in_place",
description: r##"# `iter_partition_in_place`
The tracking issue for this feature is: [#62543]
[#62543]: https://github.com/rust-lang/rust/issues/62543
------------------------
"##,
},
Lint {
label: "iter_repeat_n",
description: r##"# `iter_repeat_n`
The tracking issue for this feature is: [#104434]
[#104434]: https://github.com/rust-lang/rust/issues/104434
------------------------
"##,
},
Lint {
label: "iterator_try_collect",
description: r##"# `iterator_try_collect`
The tracking issue for this feature is: [#94047]
[#94047]: https://github.com/rust-lang/rust/issues/94047
------------------------
"##,
},
Lint {
label: "iterator_try_reduce",
description: r##"# `iterator_try_reduce`
The tracking issue for this feature is: [#87053]
[#87053]: https://github.com/rust-lang/rust/issues/87053
------------------------
"##,
},
Lint {
@@ -2758,304 +5859,190 @@ const fn one() -> i32 { 1 }
implemented in libraries, with a special marker to tell the compiler
it exists. The marker is the attribute `#[lang = "..."]` and there are
various different values of `...`, i.e. various different 'lang
items'.
items'. Most of them can only be defined once.
For example, `Box` pointers require two lang items, one for allocation
and one for deallocation. A freestanding program that uses the `Box`
sugar for dynamic allocations via `malloc` and `free`:
Lang items are loaded lazily by the compiler; e.g. if one never uses `Box`
then there is no need to define a function for `exchange_malloc`.
`rustc` will emit an error when an item is needed but not found in the current
crate or any that it depends on.
Some features provided by lang items:
- overloadable operators via traits: the traits corresponding to the
`==`, `<`, dereferencing (`*`) and `+` (etc.) operators are all
marked with lang items; those specific four are `eq`, `partial_ord`,
`deref`/`deref_mut`, and `add` respectively.
- panicking: the `panic` and `panic_impl` lang items, among others.
- stack unwinding: the lang item `eh_personality` is a function used by the
failure mechanisms of the compiler. This is often mapped to GCC's personality
function (see the [`std` implementation][personality] for more information),
but programs which don't trigger a panic can be assured that this function is
never called. Additionally, a `eh_catch_typeinfo` static is needed for certain
targets which implement Rust panics on top of C++ exceptions.
- the traits in `core::marker` used to indicate types of
various kinds; e.g. lang items `sized`, `sync` and `copy`.
- memory allocation, see below.
Most lang items are defined by `core`, but if you're trying to build
an executable without the `std` crate, you might run into the need
for lang item definitions.
[personality]: https://github.com/rust-lang/rust/blob/master/library/std/src/sys/personality/gcc.rs
## Example: Implementing a `Box`
`Box` pointers require two lang items: one for the type itself and one for
allocation. A freestanding program that uses the `Box` sugar for dynamic
allocations via `malloc` and `free`:
```rust,ignore (libc-is-finicky)
#![feature(lang_items, box_syntax, start, libc, core_intrinsics, rustc_private)]
#![feature(lang_items, start, core_intrinsics, rustc_private, panic_unwind, rustc_attrs)]
#![allow(internal_features)]
#![no_std]
use core::intrinsics;
use core::panic::PanicInfo;
extern crate libc;
extern crate unwind;
use core::ffi::c_void;
use core::intrinsics;
use core::panic::PanicInfo;
use core::ptr::NonNull;
pub struct Global; // the global allocator
struct Unique<T>(NonNull<T>);
#[lang = "owned_box"]
pub struct Box<T>(*mut T);
pub struct Box<T, A = Global>(Unique<T>, A);
impl<T> Box<T> {
pub fn new(x: T) -> Self {
#[rustc_box]
Box::new(x)
}
}
impl<T, A> Drop for Box<T, A> {
fn drop(&mut self) {
unsafe {
libc::free(self.0.0.as_ptr() as *mut c_void);
}
}
}
#[lang = "exchange_malloc"]
unsafe fn allocate(size: usize, _align: usize) -> *mut u8 {
let p = libc::malloc(size as libc::size_t) as *mut u8;
let p = libc::malloc(size) as *mut u8;
// Check if `malloc` failed:
if p as usize == 0 {
if p.is_null() {
intrinsics::abort();
}
p
}
#[lang = "box_free"]
unsafe fn box_free<T: ?Sized>(ptr: *mut T) {
libc::free(ptr as *mut libc::c_void)
}
#[start]
fn main(_argc: isize, _argv: *const *const u8) -> isize {
let _x = box 1;
let _x = Box::new(1);
0
}
#[lang = "eh_personality"] extern fn rust_eh_personality() {}
#[lang = "panic_impl"] extern fn rust_begin_panic(info: &PanicInfo) -> ! { unsafe { intrinsics::abort() } }
#[no_mangle] pub extern fn rust_eh_register_frames () {}
#[no_mangle] pub extern fn rust_eh_unregister_frames () {}
#[lang = "eh_personality"]
fn rust_eh_personality() {}
#[panic_handler]
fn panic_handler(_info: &PanicInfo) -> ! { intrinsics::abort() }
```
Note the use of `abort`: the `exchange_malloc` lang item is assumed to
return a valid pointer, and so needs to do the check internally.
Other features provided by lang items include:
- overloadable operators via traits: the traits corresponding to the
`==`, `<`, dereferencing (`*`) and `+` (etc.) operators are all
marked with lang items; those specific four are `eq`, `ord`,
`deref`, and `add` respectively.
- stack unwinding and general failure; the `eh_personality`,
`panic` and `panic_bounds_check` lang items.
- the traits in `std::marker` used to indicate types of
various kinds; lang items `send`, `sync` and `copy`.
- the marker types and variance indicators found in
`std::marker`; lang items `covariant_type`,
`contravariant_lifetime`, etc.
Lang items are loaded lazily by the compiler; e.g. if one never uses
`Box` then there is no need to define functions for `exchange_malloc`
and `box_free`. `rustc` will emit an error when an item is needed
but not found in the current crate or any that it depends on.
Most lang items are defined by `libcore`, but if you're trying to build
an executable without the standard library, you'll run into the need
for lang items. The rest of this page focuses on this use-case, even though
lang items are a bit broader than that.
### Using libc
In order to build a `#[no_std]` executable we will need libc as a dependency.
We can specify this using our `Cargo.toml` file:
```toml
[dependencies]
libc = { version = "0.2.14", default-features = false }
```
Note that the default features have been disabled. This is a critical step -
**the default features of libc include the standard library and so must be
disabled.**
### Writing an executable without stdlib
Controlling the entry point is possible in two ways: the `#[start]` attribute,
or overriding the default shim for the C `main` function with your own.
The function marked `#[start]` is passed the command line parameters
in the same format as C:
```rust,ignore (libc-is-finicky)
#![feature(lang_items, core_intrinsics, rustc_private)]
#![feature(start)]
#![no_std]
use core::intrinsics;
use core::panic::PanicInfo;
// Pull in the system libc library for what crt0.o likely requires.
extern crate libc;
// Entry point for this program.
#[start]
fn start(_argc: isize, _argv: *const *const u8) -> isize {
0
}
// These functions are used by the compiler, but not
// for a bare-bones hello world. These are normally
// provided by libstd.
#[lang = "eh_personality"]
#[no_mangle]
pub extern fn rust_eh_personality() {
}
#[lang = "panic_impl"]
#[no_mangle]
pub extern fn rust_begin_panic(info: &PanicInfo) -> ! {
unsafe { intrinsics::abort() }
}
```
To override the compiler-inserted `main` shim, one has to disable it
with `#![no_main]` and then create the appropriate symbol with the
correct ABI and the correct name, which requires overriding the
compiler's name mangling too:
```rust,ignore (libc-is-finicky)
#![feature(lang_items, core_intrinsics, rustc_private)]
#![feature(start)]
#![no_std]
#![no_main]
use core::intrinsics;
use core::panic::PanicInfo;
// Pull in the system libc library for what crt0.o likely requires.
extern crate libc;
// Entry point for this program.
#[no_mangle] // ensure that this symbol is called `main` in the output
pub extern fn main(_argc: i32, _argv: *const *const u8) -> i32 {
0
}
// These functions are used by the compiler, but not
// for a bare-bones hello world. These are normally
// provided by libstd.
#[lang = "eh_personality"]
#[no_mangle]
pub extern fn rust_eh_personality() {
}
#[lang = "panic_impl"]
#[no_mangle]
pub extern fn rust_begin_panic(info: &PanicInfo) -> ! {
unsafe { intrinsics::abort() }
}
```
In many cases, you may need to manually link to the `compiler_builtins` crate
when building a `no_std` binary. You may observe this via linker error messages
such as "```undefined reference to `__rust_probestack'```".
## More about the language items
The compiler currently makes a few assumptions about symbols which are
available in the executable to call. Normally these functions are provided by
the standard library, but without it you must define your own. These symbols
are called "language items", and they each have an internal name, and then a
signature that an implementation must conform to.
The first of these functions, `rust_eh_personality`, is used by the failure
mechanisms of the compiler. This is often mapped to GCC's personality function
(see the [libstd implementation][unwind] for more information), but crates
which do not trigger a panic can be assured that this function is never
called. The language item's name is `eh_personality`.
[unwind]: https://github.com/rust-lang/rust/blob/master/library/panic_unwind/src/gcc.rs
The second function, `rust_begin_panic`, is also used by the failure mechanisms of the
compiler. When a panic happens, this controls the message that's displayed on
the screen. While the language item's name is `panic_impl`, the symbol name is
`rust_begin_panic`.
Finally, a `eh_catch_typeinfo` static is needed for certain targets which
implement Rust panics on top of C++ exceptions.
## List of all language items
This is a list of all language items in Rust along with where they are located in
the source code.
An up-to-date list of all language items can be found [here] in the compiler code.
- Primitives
- `i8`: `libcore/num/mod.rs`
- `i16`: `libcore/num/mod.rs`
- `i32`: `libcore/num/mod.rs`
- `i64`: `libcore/num/mod.rs`
- `i128`: `libcore/num/mod.rs`
- `isize`: `libcore/num/mod.rs`
- `u8`: `libcore/num/mod.rs`
- `u16`: `libcore/num/mod.rs`
- `u32`: `libcore/num/mod.rs`
- `u64`: `libcore/num/mod.rs`
- `u128`: `libcore/num/mod.rs`
- `usize`: `libcore/num/mod.rs`
- `f32`: `libstd/f32.rs`
- `f64`: `libstd/f64.rs`
- `char`: `libcore/char.rs`
- `slice`: `liballoc/slice.rs`
- `str`: `liballoc/str.rs`
- `const_ptr`: `libcore/ptr.rs`
- `mut_ptr`: `libcore/ptr.rs`
- `unsafe_cell`: `libcore/cell.rs`
- Runtime
- `start`: `libstd/rt.rs`
- `eh_personality`: `libpanic_unwind/emcc.rs` (EMCC)
- `eh_personality`: `libpanic_unwind/gcc.rs` (GNU)
- `eh_personality`: `libpanic_unwind/seh.rs` (SEH)
- `eh_catch_typeinfo`: `libpanic_unwind/emcc.rs` (EMCC)
- `panic`: `libcore/panicking.rs`
- `panic_bounds_check`: `libcore/panicking.rs`
- `panic_impl`: `libcore/panicking.rs`
- `panic_impl`: `libstd/panicking.rs`
- Allocations
- `owned_box`: `liballoc/boxed.rs`
- `exchange_malloc`: `liballoc/heap.rs`
- `box_free`: `liballoc/heap.rs`
- Operands
- `not`: `libcore/ops/bit.rs`
- `bitand`: `libcore/ops/bit.rs`
- `bitor`: `libcore/ops/bit.rs`
- `bitxor`: `libcore/ops/bit.rs`
- `shl`: `libcore/ops/bit.rs`
- `shr`: `libcore/ops/bit.rs`
- `bitand_assign`: `libcore/ops/bit.rs`
- `bitor_assign`: `libcore/ops/bit.rs`
- `bitxor_assign`: `libcore/ops/bit.rs`
- `shl_assign`: `libcore/ops/bit.rs`
- `shr_assign`: `libcore/ops/bit.rs`
- `deref`: `libcore/ops/deref.rs`
- `deref_mut`: `libcore/ops/deref.rs`
- `index`: `libcore/ops/index.rs`
- `index_mut`: `libcore/ops/index.rs`
- `add`: `libcore/ops/arith.rs`
- `sub`: `libcore/ops/arith.rs`
- `mul`: `libcore/ops/arith.rs`
- `div`: `libcore/ops/arith.rs`
- `rem`: `libcore/ops/arith.rs`
- `neg`: `libcore/ops/arith.rs`
- `add_assign`: `libcore/ops/arith.rs`
- `sub_assign`: `libcore/ops/arith.rs`
- `mul_assign`: `libcore/ops/arith.rs`
- `div_assign`: `libcore/ops/arith.rs`
- `rem_assign`: `libcore/ops/arith.rs`
- `eq`: `libcore/cmp.rs`
- `ord`: `libcore/cmp.rs`
- Functions
- `fn`: `libcore/ops/function.rs`
- `fn_mut`: `libcore/ops/function.rs`
- `fn_once`: `libcore/ops/function.rs`
- `generator_state`: `libcore/ops/generator.rs`
- `generator`: `libcore/ops/generator.rs`
- Other
- `coerce_unsized`: `libcore/ops/unsize.rs`
- `drop`: `libcore/ops/drop.rs`
- `drop_in_place`: `libcore/ptr.rs`
- `clone`: `libcore/clone.rs`
- `copy`: `libcore/marker.rs`
- `send`: `libcore/marker.rs`
- `sized`: `libcore/marker.rs`
- `unsize`: `libcore/marker.rs`
- `sync`: `libcore/marker.rs`
- `phantom_data`: `libcore/marker.rs`
- `discriminant_kind`: `libcore/marker.rs`
- `freeze`: `libcore/marker.rs`
- `debug_trait`: `libcore/fmt/mod.rs`
- `non_zero`: `libcore/nonzero.rs`
- `arc`: `liballoc/sync.rs`
- `rc`: `liballoc/rc.rs`
[here]: https://github.com/rust-lang/rust/blob/master/compiler/rustc_hir/src/lang_items.rs
"##,
},
Lint {
label: "libstd_sys_internals",
description: r##"# `libstd_sys_internals`
label: "large_assignments",
description: r##"# `large_assignments`
This feature is internal to the Rust compiler and is not intended for general use.
The tracking issue for this feature is: [#83518]
[#83518]: https://github.com/rust-lang/rust/issues/83518
------------------------
"##,
},
Lint {
label: "libstd_thread_internals",
description: r##"# `libstd_thread_internals`
label: "layout_for_ptr",
description: r##"# `layout_for_ptr`
The tracking issue for this feature is: [#69835]
[#69835]: https://github.com/rust-lang/rust/issues/69835
------------------------
"##,
},
Lint {
label: "lazy_cell",
description: r##"# `lazy_cell`
The tracking issue for this feature is: [#109736]
[#109736]: https://github.com/rust-lang/rust/issues/109736
------------------------
"##,
},
Lint {
label: "lazy_cell_consume",
description: r##"# `lazy_cell_consume`
The tracking issue for this feature is: [#109736]
[#109736]: https://github.com/rust-lang/rust/issues/109736
------------------------
"##,
},
Lint {
label: "lazy_type_alias",
description: r##"# `lazy_type_alias`
The tracking issue for this feature is: [#112792]
[#112792]: https://github.com/rust-lang/rust/issues/112792
------------------------
"##,
},
Lint {
label: "let_chains",
description: r##"# `let_chains`
The tracking issue for this feature is: [#53667]
[#53667]: https://github.com/rust-lang/rust/issues/53667
------------------------
"##,
},
Lint {
label: "liballoc_internals",
description: r##"# `liballoc_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "libstd_sys_internals",
description: r##"# `libstd_sys_internals`
This feature is internal to the Rust compiler and is not intended for general use.
@@ -3072,197 +6059,124 @@ fn start(_argc: isize, _argv: *const *const u8) -> isize {
"##,
},
Lint {
label: "llvm_asm",
description: r##"# `llvm_asm`
label: "link_llvm_intrinsics",
description: r##"# `link_llvm_intrinsics`
The tracking issue for this feature is: [#70173]
The tracking issue for this feature is: [#29602]
[#70173]: https://github.com/rust-lang/rust/issues/70173
[#29602]: https://github.com/rust-lang/rust/issues/29602
------------------------
"##,
},
Lint {
label: "linkage",
description: r##"# `linkage`
For extremely low-level manipulations and performance reasons, one
might wish to control the CPU directly. Rust supports using inline
assembly to do this via the `llvm_asm!` macro.
The tracking issue for this feature is: [#29603]
```rust,ignore (pseudo-code)
llvm_asm!(assembly template
: output operands
: input operands
: clobbers
: options
);
```
[#29603]: https://github.com/rust-lang/rust/issues/29603
Any use of `llvm_asm` is feature gated (requires `#![feature(llvm_asm)]` on the
crate to allow) and of course requires an `unsafe` block.
------------------------
"##,
},
Lint {
label: "linked_list_cursors",
description: r##"# `linked_list_cursors`
> **Note**: the examples here are given in x86/x86-64 assembly, but
> all platforms are supported.
The tracking issue for this feature is: [#58533]
## Assembly template
[#58533]: https://github.com/rust-lang/rust/issues/58533
The `assembly template` is the only required parameter and must be a
literal string (i.e. `""`)
------------------------
"##,
},
Lint {
label: "linked_list_remove",
description: r##"# `linked_list_remove`
```rust
#![feature(llvm_asm)]
The tracking issue for this feature is: [#69210]
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
fn foo() {
unsafe {
llvm_asm!("NOP");
}
}
[#69210]: https://github.com/rust-lang/rust/issues/69210
// Other platforms:
#[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
fn foo() { /* ... */ }
------------------------
"##,
},
Lint {
label: "lint_reasons",
description: r##"# `lint_reasons`
fn main() {
// ...
foo();
// ...
}
```
The tracking issue for this feature is: [#54503]
(The `feature(llvm_asm)` and `#[cfg]`s are omitted from now on.)
[#54503]: https://github.com/rust-lang/rust/issues/54503
Output operands, input operands, clobbers and options are all optional
but you must add the right number of `:` if you skip them:
------------------------
"##,
},
Lint {
label: "linux_pidfd",
description: r##"# `linux_pidfd`
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
# fn main() { unsafe {
llvm_asm!("xor %eax, %eax"
:
:
: "eax"
);
# } }
# #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
# fn main() {}
```
The tracking issue for this feature is: [#82971]
Whitespace also doesn't matter:
[#82971]: https://github.com/rust-lang/rust/issues/82971
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
# fn main() { unsafe {
llvm_asm!("xor %eax, %eax" ::: "eax");
# } }
# #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
# fn main() {}
```
------------------------
"##,
},
Lint {
label: "log_syntax",
description: r##"# `log_syntax`
## Operands
The tracking issue for this feature is: [#29598]
Input and output operands follow the same format: `:
"constraints1"(expr1), "constraints2"(expr2), ..."`. Output operand
expressions must be mutable place, or not yet assigned:
[#29598]: https://github.com/rust-lang/rust/issues/29598
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
fn add(a: i32, b: i32) -> i32 {
let c: i32;
unsafe {
llvm_asm!("add $2, $0"
: "=r"(c)
: "0"(a), "r"(b)
);
}
c
}
# #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
# fn add(a: i32, b: i32) -> i32 { a + b }
------------------------
"##,
},
Lint {
label: "macro_metavar_expr",
description: r##"# `macro_metavar_expr`
fn main() {
assert_eq!(add(3, 14159), 14162)
}
```
The tracking issue for this feature is: [#83527]
If you would like to use real operands in this position, however,
you are required to put curly braces `{}` around the register that
you want, and you are required to put the specific size of the
operand. This is useful for very low level programming, where
which register you use is important:
[#83527]: https://github.com/rust-lang/rust/issues/83527
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
# unsafe fn read_byte_in(port: u16) -> u8 {
let result: u8;
llvm_asm!("in %dx, %al" : "={al}"(result) : "{dx}"(port));
result
# }
```
------------------------
"##,
},
Lint {
label: "map_entry_replace",
description: r##"# `map_entry_replace`
## Clobbers
The tracking issue for this feature is: [#44286]
Some instructions modify registers which might otherwise have held
different values so we use the clobbers list to indicate to the
compiler not to assume any values loaded into those registers will
stay valid.
[#44286]: https://github.com/rust-lang/rust/issues/44286
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
# fn main() { unsafe {
// Put the value 0x200 in eax:
llvm_asm!("mov $$0x200, %eax" : /* no outputs */ : /* no inputs */ : "eax");
# } }
# #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
# fn main() {}
```
------------------------
"##,
},
Lint {
label: "map_many_mut",
description: r##"# `map_many_mut`
Input and output registers need not be listed since that information
is already communicated by the given constraints. Otherwise, any other
registers used either implicitly or explicitly should be listed.
The tracking issue for this feature is: [#97601]
If the assembly changes the condition code register `cc` should be
specified as one of the clobbers. Similarly, if the assembly modifies
memory, `memory` should also be specified.
[#97601]: https://github.com/rust-lang/rust/issues/97601
## Options
------------------------
"##,
},
Lint {
label: "map_try_insert",
description: r##"# `map_try_insert`
The last section, `options` is specific to Rust. The format is comma
separated literal strings (i.e. `:"foo", "bar", "baz"`). It's used to
specify some extra info about the inline assembly:
The tracking issue for this feature is: [#82766]
Current valid options are:
[#82766]: https://github.com/rust-lang/rust/issues/82766
1. `volatile` - specifying this is analogous to
`__asm__ __volatile__ (...)` in gcc/clang.
2. `alignstack` - certain instructions expect the stack to be
aligned a certain way (i.e. SSE) and specifying this indicates to
the compiler to insert its usual stack alignment code
3. `intel` - use intel syntax instead of the default AT&T.
```rust
# #![feature(llvm_asm)]
# #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
# fn main() {
let result: i32;
unsafe {
llvm_asm!("mov eax, 2" : "={eax}"(result) : : : "intel")
}
println!("eax is currently {}", result);
# }
# #[cfg(not(any(target_arch = "x86", target_arch = "x86_64")))]
# fn main() {}
```
## More Information
The current implementation of the `llvm_asm!` macro is a direct binding to [LLVM's
inline assembler expressions][llvm-docs], so be sure to check out [their
documentation as well][llvm-docs] for more information about clobbers,
constraints, etc.
[llvm-docs]: http://llvm.org/docs/LangRef.html#inline-assembler-expressions
------------------------
"##,
},
Lint {
@@ -3302,6 +6216,116 @@ fn cheap_clone<T: CheapToClone>(t: T) -> T {
This is expected to replace the unstable `overlapping_marker_traits`
feature, which applied to all empty traits (without needing an opt-in).
"##,
},
Lint {
label: "maybe_uninit_array_assume_init",
description: r##"# `maybe_uninit_array_assume_init`
The tracking issue for this feature is: [#96097]
[#96097]: https://github.com/rust-lang/rust/issues/96097
------------------------
"##,
},
Lint {
label: "maybe_uninit_as_bytes",
description: r##"# `maybe_uninit_as_bytes`
The tracking issue for this feature is: [#93092]
[#93092]: https://github.com/rust-lang/rust/issues/93092
------------------------
"##,
},
Lint {
label: "maybe_uninit_slice",
description: r##"# `maybe_uninit_slice`
The tracking issue for this feature is: [#63569]
[#63569]: https://github.com/rust-lang/rust/issues/63569
------------------------
"##,
},
Lint {
label: "maybe_uninit_uninit_array",
description: r##"# `maybe_uninit_uninit_array`
The tracking issue for this feature is: [#96097]
[#96097]: https://github.com/rust-lang/rust/issues/96097
------------------------
"##,
},
Lint {
label: "maybe_uninit_uninit_array_transpose",
description: r##"# `maybe_uninit_uninit_array_transpose`
The tracking issue for this feature is: [#96097]
[#96097]: https://github.com/rust-lang/rust/issues/96097
------------------------
"##,
},
Lint {
label: "maybe_uninit_write_slice",
description: r##"# `maybe_uninit_write_slice`
The tracking issue for this feature is: [#79995]
[#79995]: https://github.com/rust-lang/rust/issues/79995
------------------------
"##,
},
Lint {
label: "mem_copy_fn",
description: r##"# `mem_copy_fn`
The tracking issue for this feature is: [#98262]
[#98262]: https://github.com/rust-lang/rust/issues/98262
------------------------
"##,
},
Lint {
label: "min_specialization",
description: r##"# `min_specialization`
The tracking issue for this feature is: [#31844]
[#31844]: https://github.com/rust-lang/rust/issues/31844
------------------------
"##,
},
Lint {
label: "mips_target_feature",
description: r##"# `mips_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "more_float_constants",
description: r##"# `more_float_constants`
The tracking issue for this feature is: [#103883]
[#103883]: https://github.com/rust-lang/rust/issues/103883
------------------------
"##,
},
Lint {
@@ -3338,18 +6362,56 @@ impl A for Foo {
"##,
},
Lint {
label: "native_link_modifiers",
description: r##"# `native_link_modifiers`
label: "multiple_supertrait_upcastable",
description: r##"# `multiple_supertrait_upcastable`
The tracking issue for this feature is: [#81490]
[#81490]: https://github.com/rust-lang/rust/issues/81490
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "must_not_suspend",
description: r##"# `must_not_suspend`
The `native_link_modifiers` feature allows you to use the `modifiers` syntax with the `#[link(..)]` attribute.
The tracking issue for this feature is: [#83310]
Modifiers are specified as a comma-delimited string with each modifier prefixed with either a `+` or `-` to indicate that the modifier is enabled or disabled, respectively. The last boolean value specified for a given modifier wins.
[#83310]: https://github.com/rust-lang/rust/issues/83310
------------------------
"##,
},
Lint {
label: "mutex_unlock",
description: r##"# `mutex_unlock`
The tracking issue for this feature is: [#81872]
[#81872]: https://github.com/rust-lang/rust/issues/81872
------------------------
"##,
},
Lint {
label: "mutex_unpoison",
description: r##"# `mutex_unpoison`
The tracking issue for this feature is: [#96469]
[#96469]: https://github.com/rust-lang/rust/issues/96469
------------------------
"##,
},
Lint {
label: "naked_functions",
description: r##"# `naked_functions`
The tracking issue for this feature is: [#32408]
[#32408]: https://github.com/rust-lang/rust/issues/32408
------------------------
"##,
},
Lint {
@@ -3375,72 +6437,23 @@ impl A for Foo {
"##,
},
Lint {
label: "native_link_modifiers_bundle",
description: r##"# `native_link_modifiers_bundle`
label: "needs_panic_runtime",
description: r##"# `needs_panic_runtime`
The tracking issue for this feature is: [#81490]
The tracking issue for this feature is: [#32837]
[#81490]: https://github.com/rust-lang/rust/issues/81490
[#32837]: https://github.com/rust-lang/rust/issues/32837
------------------------
The `native_link_modifiers_bundle` feature allows you to use the `bundle` modifier.
Only compatible with the `static` linking kind. Using any other kind will result in a compiler error.
`+bundle` means objects from the static library are bundled into the produced crate (a rlib, for example) and are used from this crate later during linking of the final binary.
`-bundle` means the static library is included into the produced rlib "by name" and object files from it are included only during linking of the final binary, the file search by that name is also performed during final linking.
This modifier is supposed to supersede the `static-nobundle` linking kind defined by [RFC 1717](https://github.com/rust-lang/rfcs/pull/1717).
The default for this modifier is currently `+bundle`, but it could be changed later on some future edition boundary.
"##,
},
Lint {
label: "native_link_modifiers_verbatim",
description: r##"# `native_link_modifiers_verbatim`
label: "negative_bounds",
description: r##"# `negative_bounds`
The tracking issue for this feature is: [#81490]
[#81490]: https://github.com/rust-lang/rust/issues/81490
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
The `native_link_modifiers_verbatim` feature allows you to use the `verbatim` modifier.
`+verbatim` means that rustc itself won't add any target-specified library prefixes or suffixes (like `lib` or `.a`) to the library name, and will try its best to ask for the same thing from the linker.
For `ld`-like linkers rustc will use the `-l:filename` syntax (note the colon) when passing the library, so the linker won't add any prefixes or suffixes as well.
See [`-l namespec`](https://sourceware.org/binutils/docs/ld/Options.html) in ld documentation for more details.
For linkers not supporting any verbatim modifiers (e.g. `link.exe` or `ld64`) the library name will be passed as is.
The default for this modifier is `-verbatim`.
This RFC changes the behavior of `raw-dylib` linking kind specified by [RFC 2627](https://github.com/rust-lang/rfcs/pull/2627). The `.dll` suffix (or other target-specified suffixes for other targets) is now added automatically.
If your DLL doesn't have the `.dll` suffix, it can be specified with `+verbatim`.
"##,
},
Lint {
label: "native_link_modifiers_whole_archive",
description: r##"# `native_link_modifiers_whole_archive`
The tracking issue for this feature is: [#81490]
[#81490]: https://github.com/rust-lang/rust/issues/81490
------------------------
The `native_link_modifiers_whole_archive` feature allows you to use the `whole-archive` modifier.
Only compatible with the `static` linking kind. Using any other kind will result in a compiler error.
`+whole-archive` means that the static library is linked as a whole archive without throwing any object files away.
This modifier translates to `--whole-archive` for `ld`-like linkers, to `/WHOLEARCHIVE` for `link.exe`, and to `-force_load` for `ld64`.
The modifier does nothing for linkers that don't support it.
The default for this modifier is `-whole-archive`.
"##,
},
Lint {
@@ -3505,37 +6518,47 @@ impl at all, but that is not an option for auto traits. A workaround
"##,
},
Lint {
label: "coverage",
description: r##"# `coverage`
label: "never_type",
description: r##"# `never_type`
The tracking issue for this feature is: [#84605]
The tracking issue for this feature is: [#35121]
[#84605]: https://github.com/rust-lang/rust/issues/84605
[#35121]: https://github.com/rust-lang/rust/issues/35121
---
------------------------
"##,
},
Lint {
label: "never_type_fallback",
description: r##"# `never_type_fallback`
The `coverage` attribute can be used to selectively disable coverage
instrumentation in an annotated function. This might be useful to:
The tracking issue for this feature is: [#65992]
- Avoid instrumentation overhead in a performance critical function
- Avoid generating coverage for a function that is not meant to be executed,
but still target 100% coverage for the rest of the program.
[#65992]: https://github.com/rust-lang/rust/issues/65992
## Example
------------------------
"##,
},
Lint {
label: "new_uninit",
description: r##"# `new_uninit`
```rust
#![feature(coverage)]
The tracking issue for this feature is: [#63291]
// `foo()` will get coverage instrumentation (by default)
fn foo() {
// ...
}
[#63291]: https://github.com/rust-lang/rust/issues/63291
#[coverage(off)]
fn bar() {
// ...
}
```
------------------------
"##,
},
Lint {
label: "no_core",
description: r##"# `no_core`
The tracking issue for this feature is: [#29639]
[#29639]: https://github.com/rust-lang/rust/issues/29639
------------------------
"##,
},
Lint {
@@ -3569,6 +6592,319 @@ fn foo() {
// ...
}
```
"##,
},
Lint {
label: "non_exhaustive_omitted_patterns_lint",
description: r##"# `non_exhaustive_omitted_patterns_lint`
The tracking issue for this feature is: [#89554]
[#89554]: https://github.com/rust-lang/rust/issues/89554
------------------------
"##,
},
Lint {
label: "non_lifetime_binders",
description: r##"# `non_lifetime_binders`
The tracking issue for this feature is: [#108185]
[#108185]: https://github.com/rust-lang/rust/issues/108185
------------------------
"##,
},
Lint {
label: "nonzero_ops",
description: r##"# `nonzero_ops`
The tracking issue for this feature is: [#84186]
[#84186]: https://github.com/rust-lang/rust/issues/84186
------------------------
"##,
},
Lint {
label: "noop_waker",
description: r##"# `noop_waker`
The tracking issue for this feature is: [#98286]
[#98286]: https://github.com/rust-lang/rust/issues/98286
------------------------
"##,
},
Lint {
label: "num_midpoint",
description: r##"# `num_midpoint`
The tracking issue for this feature is: [#110840]
[#110840]: https://github.com/rust-lang/rust/issues/110840
------------------------
"##,
},
Lint {
label: "numfmt",
description: r##"# `numfmt`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "object_safe_for_dispatch",
description: r##"# `object_safe_for_dispatch`
The tracking issue for this feature is: [#43561]
[#43561]: https://github.com/rust-lang/rust/issues/43561
------------------------
"##,
},
Lint {
label: "offset_of",
description: r##"# `offset_of`
The tracking issue for this feature is: [#106655]
[#106655]: https://github.com/rust-lang/rust/issues/106655
------------------------
"##,
},
Lint {
label: "omit_gdb_pretty_printer_section",
description: r##"# `omit_gdb_pretty_printer_section`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "once_cell_try",
description: r##"# `once_cell_try`
The tracking issue for this feature is: [#109737]
[#109737]: https://github.com/rust-lang/rust/issues/109737
------------------------
"##,
},
Lint {
label: "one_sided_range",
description: r##"# `one_sided_range`
The tracking issue for this feature is: [#69780]
[#69780]: https://github.com/rust-lang/rust/issues/69780
------------------------
"##,
},
Lint {
label: "optimize_attribute",
description: r##"# `optimize_attribute`
The tracking issue for this feature is: [#54882]
[#54882]: https://github.com/rust-lang/rust/issues/54882
------------------------
"##,
},
Lint {
label: "option_get_or_insert_default",
description: r##"# `option_get_or_insert_default`
The tracking issue for this feature is: [#82901]
[#82901]: https://github.com/rust-lang/rust/issues/82901
------------------------
"##,
},
Lint {
label: "option_take_if",
description: r##"# `option_take_if`
The tracking issue for this feature is: [#98934]
[#98934]: https://github.com/rust-lang/rust/issues/98934
------------------------
"##,
},
Lint {
label: "option_zip",
description: r##"# `option_zip`
The tracking issue for this feature is: [#70086]
[#70086]: https://github.com/rust-lang/rust/issues/70086
------------------------
"##,
},
Lint {
label: "panic_abort",
description: r##"# `panic_abort`
The tracking issue for this feature is: [#32837]
[#32837]: https://github.com/rust-lang/rust/issues/32837
------------------------
"##,
},
Lint {
label: "panic_always_abort",
description: r##"# `panic_always_abort`
The tracking issue for this feature is: [#84438]
[#84438]: https://github.com/rust-lang/rust/issues/84438
------------------------
"##,
},
Lint {
label: "panic_backtrace_config",
description: r##"# `panic_backtrace_config`
The tracking issue for this feature is: [#93346]
[#93346]: https://github.com/rust-lang/rust/issues/93346
------------------------
"##,
},
Lint {
label: "panic_can_unwind",
description: r##"# `panic_can_unwind`
The tracking issue for this feature is: [#92988]
[#92988]: https://github.com/rust-lang/rust/issues/92988
------------------------
"##,
},
Lint {
label: "panic_info_message",
description: r##"# `panic_info_message`
The tracking issue for this feature is: [#66745]
[#66745]: https://github.com/rust-lang/rust/issues/66745
------------------------
"##,
},
Lint {
label: "panic_internals",
description: r##"# `panic_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "panic_runtime",
description: r##"# `panic_runtime`
The tracking issue for this feature is: [#32837]
[#32837]: https://github.com/rust-lang/rust/issues/32837
------------------------
"##,
},
Lint {
label: "panic_unwind",
description: r##"# `panic_unwind`
The tracking issue for this feature is: [#32837]
[#32837]: https://github.com/rust-lang/rust/issues/32837
------------------------
"##,
},
Lint {
label: "panic_update_hook",
description: r##"# `panic_update_hook`
The tracking issue for this feature is: [#92649]
[#92649]: https://github.com/rust-lang/rust/issues/92649
------------------------
"##,
},
Lint {
label: "path_file_prefix",
description: r##"# `path_file_prefix`
The tracking issue for this feature is: [#86319]
[#86319]: https://github.com/rust-lang/rust/issues/86319
------------------------
"##,
},
Lint {
label: "pattern",
description: r##"# `pattern`
The tracking issue for this feature is: [#27721]
[#27721]: https://github.com/rust-lang/rust/issues/27721
------------------------
"##,
},
Lint {
label: "peer_credentials_unix_socket",
description: r##"# `peer_credentials_unix_socket`
The tracking issue for this feature is: [#42839]
[#42839]: https://github.com/rust-lang/rust/issues/42839
------------------------
"##,
},
Lint {
label: "pin_deref_mut",
description: r##"# `pin_deref_mut`
The tracking issue for this feature is: [#86918]
[#86918]: https://github.com/rust-lang/rust/issues/86918
------------------------
"##,
},
Lint {
label: "platform_intrinsics",
description: r##"# `platform_intrinsics`
The tracking issue for this feature is: [#27731]
[#27731]: https://github.com/rust-lang/rust/issues/27731
------------------------
"##,
},
Lint {
@@ -3608,24 +6944,24 @@ fn foo() {
Plugins can extend [Rust's lint
infrastructure](../../reference/attributes/diagnostics.md#lint-check-attributes) with
additional checks for code style, safety, etc. Now let's write a plugin
[`lint-plugin-test.rs`](https://github.com/rust-lang/rust/blob/master/tests/ui-fulldeps/auxiliary/lint-plugin-test.rs)
[`lint-plugin-test.rs`](https://github.com/rust-lang/rust/blob/master/tests/ui-fulldeps/plugin/auxiliary/lint-plugin-test.rs)
that warns about any item named `lintme`.
```rust,ignore (requires-stage-2)
#![feature(box_syntax, rustc_private)]
#![feature(rustc_private)]
extern crate rustc_ast;
// Load rustc as a plugin to get macros
extern crate rustc_driver;
#[macro_use]
extern crate rustc_lint;
#[macro_use]
extern crate rustc_session;
use rustc_driver::plugin::Registry;
use rustc_lint::{EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
use rustc_ast::ast;
use rustc_driver::plugin::Registry;
use rustc_lint::{EarlyContext, EarlyLintPass, LintContext};
declare_lint!(TEST_LINT, Warn, "Warn about items named 'lintme'");
declare_lint_pass!(Pass => [TEST_LINT]);
@@ -3633,9 +6969,7 @@ fn foo() {
impl EarlyLintPass for Pass {
fn check_item(&mut self, cx: &EarlyContext, it: &ast::Item) {
if it.ident.name.as_str() == "lintme" {
cx.lint(TEST_LINT, |lint| {
lint.build("item is named 'lintme'").set_span(it.span).emit()
});
cx.lint(TEST_LINT, "item is named 'lintme'", |lint| lint.set_span(it.span));
}
}
}
@@ -3643,7 +6977,7 @@ fn check_item(&mut self, cx: &EarlyContext, it: &ast::Item) {
#[no_mangle]
fn __rustc_plugin_registrar(reg: &mut Registry) {
reg.lint_store.register_lints(&[&TEST_LINT]);
reg.lint_store.register_early_pass(|| box Pass);
reg.lint_store.register_early_pass(|| Box::new(Pass));
}
```
@@ -3677,7 +7011,7 @@ fn lintme() { }
Lint passes are syntax traversals, but they run at a late stage of compilation
where type information is available. `rustc`'s [built-in
lints](https://github.com/rust-lang/rust/blob/master/src/librustc_session/lint/builtin.rs)
lints](https://github.com/rust-lang/rust/blob/master/compiler/rustc_lint_defs/src/builtin.rs)
mostly use the same infrastructure as lint plugins, and provide examples of how
to access type information.
@@ -3689,6 +7023,88 @@ fn lintme() { }
You can run `rustc -W help foo.rs` to see a list of lints known to `rustc`,
including those provided by plugins loaded by `foo.rs`.
"##,
},
Lint {
label: "pointer_byte_offsets",
description: r##"# `pointer_byte_offsets`
The tracking issue for this feature is: [#96283]
[#96283]: https://github.com/rust-lang/rust/issues/96283
------------------------
"##,
},
Lint {
label: "pointer_is_aligned",
description: r##"# `pointer_is_aligned`
The tracking issue for this feature is: [#96284]
[#96284]: https://github.com/rust-lang/rust/issues/96284
------------------------
"##,
},
Lint {
label: "pointer_like_trait",
description: r##"# `pointer_like_trait`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "portable_simd",
description: r##"# `portable_simd`
The tracking issue for this feature is: [#86656]
[#86656]: https://github.com/rust-lang/rust/issues/86656
------------------------
"##,
},
Lint {
label: "powerpc_target_feature",
description: r##"# `powerpc_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "precise_pointer_size_matching",
description: r##"# `precise_pointer_size_matching`
The tracking issue for this feature is: [#56354]
[#56354]: https://github.com/rust-lang/rust/issues/56354
------------------------
"##,
},
Lint {
label: "prelude_2024",
description: r##"# `prelude_2024`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "prelude_import",
description: r##"# `prelude_import`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
@@ -3697,6 +7113,123 @@ fn lintme() { }
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "proc_macro_byte_character",
description: r##"# `proc_macro_byte_character`
The tracking issue for this feature is: [#115268]
[#115268]: https://github.com/rust-lang/rust/issues/115268
------------------------
"##,
},
Lint {
label: "proc_macro_def_site",
description: r##"# `proc_macro_def_site`
The tracking issue for this feature is: [#54724]
[#54724]: https://github.com/rust-lang/rust/issues/54724
------------------------
"##,
},
Lint {
label: "proc_macro_diagnostic",
description: r##"# `proc_macro_diagnostic`
The tracking issue for this feature is: [#54140]
[#54140]: https://github.com/rust-lang/rust/issues/54140
------------------------
"##,
},
Lint {
label: "proc_macro_expand",
description: r##"# `proc_macro_expand`
The tracking issue for this feature is: [#90765]
[#90765]: https://github.com/rust-lang/rust/issues/90765
------------------------
"##,
},
Lint {
label: "proc_macro_hygiene",
description: r##"# `proc_macro_hygiene`
The tracking issue for this feature is: [#54727]
[#54727]: https://github.com/rust-lang/rust/issues/54727
------------------------
"##,
},
Lint {
label: "proc_macro_internals",
description: r##"# `proc_macro_internals`
The tracking issue for this feature is: [#27812]
[#27812]: https://github.com/rust-lang/rust/issues/27812
------------------------
"##,
},
Lint {
label: "proc_macro_quote",
description: r##"# `proc_macro_quote`
The tracking issue for this feature is: [#54722]
[#54722]: https://github.com/rust-lang/rust/issues/54722
------------------------
"##,
},
Lint {
label: "proc_macro_span",
description: r##"# `proc_macro_span`
The tracking issue for this feature is: [#54725]
[#54725]: https://github.com/rust-lang/rust/issues/54725
------------------------
"##,
},
Lint {
label: "proc_macro_tracked_env",
description: r##"# `proc_macro_tracked_env`
The tracking issue for this feature is: [#99515]
[#99515]: https://github.com/rust-lang/rust/issues/99515
------------------------
"##,
},
Lint {
label: "process_exitcode_internals",
description: r##"# `process_exitcode_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "process_internals",
description: r##"# `process_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
@@ -3719,41 +7252,204 @@ fn lintme() { }
"##,
},
Lint {
label: "raw_dylib",
description: r##"# `raw_dylib`
label: "ptr_addr_eq",
description: r##"# `ptr_addr_eq`
The tracking issue for this feature is: [#58713]
The tracking issue for this feature is: [#116324]
[#58713]: https://github.com/rust-lang/rust/issues/58713
[#116324]: https://github.com/rust-lang/rust/issues/116324
------------------------
"##,
},
Lint {
label: "ptr_alignment_type",
description: r##"# `ptr_alignment_type`
The `raw_dylib` feature allows you to link against the implementations of functions in an `extern`
block without, on Windows, linking against an import library.
The tracking issue for this feature is: [#102070]
```rust,ignore (partial-example)
#![feature(raw_dylib)]
[#102070]: https://github.com/rust-lang/rust/issues/102070
#[link(name="library", kind="raw-dylib")]
extern {
fn extern_function(x: i32);
}
------------------------
"##,
},
Lint {
label: "ptr_as_uninit",
description: r##"# `ptr_as_uninit`
fn main() {
unsafe {
extern_function(14);
}
}
```
The tracking issue for this feature is: [#75402]
## Limitations
[#75402]: https://github.com/rust-lang/rust/issues/75402
Currently, this feature is only supported on `-windows-msvc` targets. Non-Windows platforms don't have import
libraries, and an incompatibility between LLVM and the BFD linker means that it is not currently supported on
`-windows-gnu` targets.
------------------------
"##,
},
Lint {
label: "ptr_from_ref",
description: r##"# `ptr_from_ref`
On the `i686-pc-windows-msvc` target, this feature supports only the `cdecl`, `stdcall`, `system`, and `fastcall`
calling conventions.
The tracking issue for this feature is: [#106116]
[#106116]: https://github.com/rust-lang/rust/issues/106116
------------------------
"##,
},
Lint {
label: "ptr_internals",
description: r##"# `ptr_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "ptr_mask",
description: r##"# `ptr_mask`
The tracking issue for this feature is: [#98290]
[#98290]: https://github.com/rust-lang/rust/issues/98290
------------------------
"##,
},
Lint {
label: "ptr_metadata",
description: r##"# `ptr_metadata`
The tracking issue for this feature is: [#81513]
[#81513]: https://github.com/rust-lang/rust/issues/81513
------------------------
"##,
},
Lint {
label: "ptr_sub_ptr",
description: r##"# `ptr_sub_ptr`
The tracking issue for this feature is: [#95892]
[#95892]: https://github.com/rust-lang/rust/issues/95892
------------------------
"##,
},
Lint {
label: "ptr_to_from_bits",
description: r##"# `ptr_to_from_bits`
The tracking issue for this feature is: [#91126]
[#91126]: https://github.com/rust-lang/rust/issues/91126
------------------------
"##,
},
Lint {
label: "pub_crate_should_not_need_unstable_attr",
description: r##"# `pub_crate_should_not_need_unstable_attr`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "raw_os_error_ty",
description: r##"# `raw_os_error_ty`
The tracking issue for this feature is: [#107792]
[#107792]: https://github.com/rust-lang/rust/issues/107792
------------------------
"##,
},
Lint {
label: "raw_os_nonzero",
description: r##"# `raw_os_nonzero`
The tracking issue for this feature is: [#82363]
[#82363]: https://github.com/rust-lang/rust/issues/82363
------------------------
"##,
},
Lint {
label: "raw_ref_op",
description: r##"# `raw_ref_op`
The tracking issue for this feature is: [#64490]
[#64490]: https://github.com/rust-lang/rust/issues/64490
------------------------
"##,
},
Lint {
label: "raw_slice_split",
description: r##"# `raw_slice_split`
The tracking issue for this feature is: [#95595]
[#95595]: https://github.com/rust-lang/rust/issues/95595
------------------------
"##,
},
Lint {
label: "raw_vec_internals",
description: r##"# `raw_vec_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "read_buf",
description: r##"# `read_buf`
The tracking issue for this feature is: [#78485]
[#78485]: https://github.com/rust-lang/rust/issues/78485
------------------------
"##,
},
Lint {
label: "ready_into_inner",
description: r##"# `ready_into_inner`
The tracking issue for this feature is: [#101196]
[#101196]: https://github.com/rust-lang/rust/issues/101196
------------------------
"##,
},
Lint {
label: "receiver_trait",
description: r##"# `receiver_trait`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "register_tool",
description: r##"# `register_tool`
The tracking issue for this feature is: [#66079]
[#66079]: https://github.com/rust-lang/rust/issues/66079
------------------------
"##,
},
Lint {
@@ -3776,6 +7472,103 @@ enum Foo {
Bar(u64),
}
```
"##,
},
Lint {
label: "repr_simd",
description: r##"# `repr_simd`
The tracking issue for this feature is: [#27731]
[#27731]: https://github.com/rust-lang/rust/issues/27731
------------------------
"##,
},
Lint {
label: "restricted_std",
description: r##"# `restricted_std`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "result_flattening",
description: r##"# `result_flattening`
The tracking issue for this feature is: [#70142]
[#70142]: https://github.com/rust-lang/rust/issues/70142
------------------------
"##,
},
Lint {
label: "result_option_inspect",
description: r##"# `result_option_inspect`
The tracking issue for this feature is: [#91345]
[#91345]: https://github.com/rust-lang/rust/issues/91345
------------------------
"##,
},
Lint {
label: "return_position_impl_trait_in_trait",
description: r##"# `return_position_impl_trait_in_trait`
The tracking issue for this feature is: [#91611]
[#91611]: https://github.com/rust-lang/rust/issues/91611
------------------------
"##,
},
Lint {
label: "return_type_notation",
description: r##"# `return_type_notation`
The tracking issue for this feature is: [#109417]
[#109417]: https://github.com/rust-lang/rust/issues/109417
------------------------
"##,
},
Lint {
label: "riscv_target_feature",
description: r##"# `riscv_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "round_char_boundary",
description: r##"# `round_char_boundary`
The tracking issue for this feature is: [#93743]
[#93743]: https://github.com/rust-lang/rust/issues/93743
------------------------
"##,
},
Lint {
label: "round_ties_even",
description: r##"# `round_ties_even`
The tracking issue for this feature is: [#96710]
[#96710]: https://github.com/rust-lang/rust/issues/96710
------------------------
"##,
},
Lint {
@@ -3784,6 +7577,39 @@ enum Foo {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "rtm_target_feature",
description: r##"# `rtm_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "rust_cold_cc",
description: r##"# `rust_cold_cc`
The tracking issue for this feature is: [#97544]
[#97544]: https://github.com/rust-lang/rust/issues/97544
------------------------
"##,
},
Lint {
label: "rustc_allow_const_fn_unstable",
description: r##"# `rustc_allow_const_fn_unstable`
The tracking issue for this feature is: [#69399]
[#69399]: https://github.com/rust-lang/rust/issues/69399
------------------------
"##,
},
@@ -3842,6 +7668,326 @@ pub enum X {
error: aborting due to 2 previous errors
```
"##,
},
Lint {
label: "rustc_private",
description: r##"# `rustc_private`
The tracking issue for this feature is: [#27812]
[#27812]: https://github.com/rust-lang/rust/issues/27812
------------------------
"##,
},
Lint {
label: "rustdoc_internals",
description: r##"# `rustdoc_internals`
The tracking issue for this feature is: [#90418]
[#90418]: https://github.com/rust-lang/rust/issues/90418
------------------------
"##,
},
Lint {
label: "rustdoc_missing_doc_code_examples",
description: r##"# `rustdoc_missing_doc_code_examples`
The tracking issue for this feature is: [#101730]
[#101730]: https://github.com/rust-lang/rust/issues/101730
------------------------
"##,
},
Lint {
label: "sealed",
description: r##"# `sealed`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "seek_stream_len",
description: r##"# `seek_stream_len`
The tracking issue for this feature is: [#59359]
[#59359]: https://github.com/rust-lang/rust/issues/59359
------------------------
"##,
},
Lint {
label: "set_ptr_value",
description: r##"# `set_ptr_value`
The tracking issue for this feature is: [#75091]
[#75091]: https://github.com/rust-lang/rust/issues/75091
------------------------
"##,
},
Lint {
label: "setgroups",
description: r##"# `setgroups`
The tracking issue for this feature is: [#90747]
[#90747]: https://github.com/rust-lang/rust/issues/90747
------------------------
"##,
},
Lint {
label: "sgx_platform",
description: r##"# `sgx_platform`
The tracking issue for this feature is: [#56975]
[#56975]: https://github.com/rust-lang/rust/issues/56975
------------------------
"##,
},
Lint {
label: "simd_ffi",
description: r##"# `simd_ffi`
The tracking issue for this feature is: [#27731]
[#27731]: https://github.com/rust-lang/rust/issues/27731
------------------------
"##,
},
Lint {
label: "sized_type_properties",
description: r##"# `sized_type_properties`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "slice_as_chunks",
description: r##"# `slice_as_chunks`
The tracking issue for this feature is: [#74985]
[#74985]: https://github.com/rust-lang/rust/issues/74985
------------------------
"##,
},
Lint {
label: "slice_concat_ext",
description: r##"# `slice_concat_ext`
The tracking issue for this feature is: [#27747]
[#27747]: https://github.com/rust-lang/rust/issues/27747
------------------------
"##,
},
Lint {
label: "slice_concat_trait",
description: r##"# `slice_concat_trait`
The tracking issue for this feature is: [#27747]
[#27747]: https://github.com/rust-lang/rust/issues/27747
------------------------
"##,
},
Lint {
label: "slice_first_last_chunk",
description: r##"# `slice_first_last_chunk`
The tracking issue for this feature is: [#111774]
[#111774]: https://github.com/rust-lang/rust/issues/111774
------------------------
"##,
},
Lint {
label: "slice_flatten",
description: r##"# `slice_flatten`
The tracking issue for this feature is: [#95629]
[#95629]: https://github.com/rust-lang/rust/issues/95629
------------------------
"##,
},
Lint {
label: "slice_from_ptr_range",
description: r##"# `slice_from_ptr_range`
The tracking issue for this feature is: [#89792]
[#89792]: https://github.com/rust-lang/rust/issues/89792
------------------------
"##,
},
Lint {
label: "slice_group_by",
description: r##"# `slice_group_by`
The tracking issue for this feature is: [#80552]
[#80552]: https://github.com/rust-lang/rust/issues/80552
------------------------
"##,
},
Lint {
label: "slice_index_methods",
description: r##"# `slice_index_methods`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "slice_internals",
description: r##"# `slice_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "slice_iter_mut_as_mut_slice",
description: r##"# `slice_iter_mut_as_mut_slice`
The tracking issue for this feature is: [#93079]
[#93079]: https://github.com/rust-lang/rust/issues/93079
------------------------
"##,
},
Lint {
label: "slice_partition_dedup",
description: r##"# `slice_partition_dedup`
The tracking issue for this feature is: [#54279]
[#54279]: https://github.com/rust-lang/rust/issues/54279
------------------------
"##,
},
Lint {
label: "slice_pattern",
description: r##"# `slice_pattern`
The tracking issue for this feature is: [#56345]
[#56345]: https://github.com/rust-lang/rust/issues/56345
------------------------
"##,
},
Lint {
label: "slice_ptr_get",
description: r##"# `slice_ptr_get`
The tracking issue for this feature is: [#74265]
[#74265]: https://github.com/rust-lang/rust/issues/74265
------------------------
"##,
},
Lint {
label: "slice_ptr_len",
description: r##"# `slice_ptr_len`
The tracking issue for this feature is: [#71146]
[#71146]: https://github.com/rust-lang/rust/issues/71146
------------------------
"##,
},
Lint {
label: "slice_range",
description: r##"# `slice_range`
The tracking issue for this feature is: [#76393]
[#76393]: https://github.com/rust-lang/rust/issues/76393
------------------------
"##,
},
Lint {
label: "slice_split_at_unchecked",
description: r##"# `slice_split_at_unchecked`
The tracking issue for this feature is: [#76014]
[#76014]: https://github.com/rust-lang/rust/issues/76014
------------------------
"##,
},
Lint {
label: "slice_swap_unchecked",
description: r##"# `slice_swap_unchecked`
The tracking issue for this feature is: [#88539]
[#88539]: https://github.com/rust-lang/rust/issues/88539
------------------------
"##,
},
Lint {
label: "slice_take",
description: r##"# `slice_take`
The tracking issue for this feature is: [#62280]
[#62280]: https://github.com/rust-lang/rust/issues/62280
------------------------
"##,
},
Lint {
label: "solid_ext",
description: r##"# `solid_ext`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "sort_floats",
description: r##"# `sort_floats`
The tracking issue for this feature is: [#93396]
[#93396]: https://github.com/rust-lang/rust/issues/93396
------------------------
"##,
},
Lint {
@@ -3850,6 +7996,184 @@ pub enum X {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "spec_option_partial_eq",
description: r##"# `spec_option_partial_eq`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "specialization",
description: r##"# `specialization`
The tracking issue for this feature is: [#31844]
[#31844]: https://github.com/rust-lang/rust/issues/31844
------------------------
"##,
},
Lint {
label: "split_array",
description: r##"# `split_array`
The tracking issue for this feature is: [#90091]
[#90091]: https://github.com/rust-lang/rust/issues/90091
------------------------
"##,
},
Lint {
label: "split_as_slice",
description: r##"# `split_as_slice`
The tracking issue for this feature is: [#96137]
[#96137]: https://github.com/rust-lang/rust/issues/96137
------------------------
"##,
},
Lint {
label: "sse4a_target_feature",
description: r##"# `sse4a_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "staged_api",
description: r##"# `staged_api`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "start",
description: r##"# `start`
The tracking issue for this feature is: [#29633]
[#29633]: https://github.com/rust-lang/rust/issues/29633
------------------------
Allows you to mark a function as the entry point of the executable, which is
necessary in `#![no_std]` environments.
The function marked `#[start]` is passed the command line parameters in the same
format as the C main function (aside from the integer types being used).
It has to be non-generic and have the following signature:
```rust,ignore (only-for-syntax-highlight)
# let _:
fn(isize, *const *const u8) -> isize
# ;
```
This feature should not be confused with the `start` *lang item* which is
defined by the `std` crate and is written `#[lang = "start"]`.
## Usage together with the `std` crate
`#[start]` can be used in combination with the `std` crate, in which case the
normal `main` function (which would get called from the `std` crate) won't be
used as an entry point.
The initialization code in `std` will be skipped this way.
Example:
```rust
#![feature(start)]
#[start]
fn start(_argc: isize, _argv: *const *const u8) -> isize {
0
}
```
Unwinding the stack past the `#[start]` function is currently considered
Undefined Behavior (for any unwinding implementation):
```rust,ignore (UB)
#![feature(start)]
#[start]
fn start(_argc: isize, _argv: *const *const u8) -> isize {
std::panic::catch_unwind(|| {
panic!(); // panic safely gets caught or safely aborts execution
});
panic!(); // UB!
0
}
```
"##,
},
Lint {
label: "std_internals",
description: r##"# `std_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "stdio_makes_pipe",
description: r##"# `stdio_makes_pipe`
The tracking issue for this feature is: [#98288]
[#98288]: https://github.com/rust-lang/rust/issues/98288
------------------------
"##,
},
Lint {
label: "stdsimd",
description: r##"# `stdsimd`
The tracking issue for this feature is: [#48556]
[#48556]: https://github.com/rust-lang/rust/issues/48556
------------------------
"##,
},
Lint {
label: "step_trait",
description: r##"# `step_trait`
The tracking issue for this feature is: [#42168]
[#42168]: https://github.com/rust-lang/rust/issues/42168
------------------------
"##,
},
Lint {
label: "stmt_expr_attributes",
description: r##"# `stmt_expr_attributes`
The tracking issue for this feature is: [#15701]
[#15701]: https://github.com/rust-lang/rust/issues/15701
------------------------
"##,
},
@@ -3859,6 +8183,186 @@ pub enum X {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "str_split_inclusive_remainder",
description: r##"# `str_split_inclusive_remainder`
The tracking issue for this feature is: [#77998]
[#77998]: https://github.com/rust-lang/rust/issues/77998
------------------------
"##,
},
Lint {
label: "str_split_remainder",
description: r##"# `str_split_remainder`
The tracking issue for this feature is: [#77998]
[#77998]: https://github.com/rust-lang/rust/issues/77998
------------------------
"##,
},
Lint {
label: "str_split_whitespace_remainder",
description: r##"# `str_split_whitespace_remainder`
The tracking issue for this feature is: [#77998]
[#77998]: https://github.com/rust-lang/rust/issues/77998
------------------------
"##,
},
Lint {
label: "strict_provenance",
description: r##"# `strict_provenance`
The tracking issue for this feature is: [#95228]
[#95228]: https://github.com/rust-lang/rust/issues/95228
-----
The `strict_provenance` feature allows to enable the `fuzzy_provenance_casts` and `lossy_provenance_casts` lints.
These lint on casts between integers and pointers, that are recommended against or invalid in the strict provenance model.
The same feature gate is also used for the experimental strict provenance API in `std` (actually `core`).
## Example
```rust
#![feature(strict_provenance)]
#![warn(fuzzy_provenance_casts)]
fn main() {
let _dangling = 16_usize as *const u8;
//~^ WARNING: strict provenance disallows casting integer `usize` to pointer `*const u8`
}
```
"##,
},
Lint {
label: "strict_provenance_atomic_ptr",
description: r##"# `strict_provenance_atomic_ptr`
The tracking issue for this feature is: [#99108]
[#99108]: https://github.com/rust-lang/rust/issues/99108
------------------------
"##,
},
Lint {
label: "string_deref_patterns",
description: r##"# `string_deref_patterns`
The tracking issue for this feature is: [#87121]
[#87121]: https://github.com/rust-lang/rust/issues/87121
------------------------
"##,
},
Lint {
label: "string_extend_from_within",
description: r##"# `string_extend_from_within`
The tracking issue for this feature is: [#103806]
[#103806]: https://github.com/rust-lang/rust/issues/103806
------------------------
"##,
},
Lint {
label: "string_remove_matches",
description: r##"# `string_remove_matches`
The tracking issue for this feature is: [#72826]
[#72826]: https://github.com/rust-lang/rust/issues/72826
------------------------
"##,
},
Lint {
label: "structural_match",
description: r##"# `structural_match`
The tracking issue for this feature is: [#31434]
[#31434]: https://github.com/rust-lang/rust/issues/31434
------------------------
"##,
},
Lint {
label: "sync_unsafe_cell",
description: r##"# `sync_unsafe_cell`
The tracking issue for this feature is: [#95439]
[#95439]: https://github.com/rust-lang/rust/issues/95439
------------------------
"##,
},
Lint {
label: "target_feature_11",
description: r##"# `target_feature_11`
The tracking issue for this feature is: [#69098]
[#69098]: https://github.com/rust-lang/rust/issues/69098
------------------------
"##,
},
Lint {
label: "tbm_target_feature",
description: r##"# `tbm_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "tcp_linger",
description: r##"# `tcp_linger`
The tracking issue for this feature is: [#88494]
[#88494]: https://github.com/rust-lang/rust/issues/88494
------------------------
"##,
},
Lint {
label: "tcp_quickack",
description: r##"# `tcp_quickack`
The tracking issue for this feature is: [#96256]
[#96256]: https://github.com/rust-lang/rust/issues/96256
------------------------
"##,
},
Lint {
label: "tcplistener_into_incoming",
description: r##"# `tcplistener_into_incoming`
The tracking issue for this feature is: [#88339]
[#88339]: https://github.com/rust-lang/rust/issues/88339
------------------------
"##,
},
@@ -4022,6 +8526,57 @@ fn bench_xor_1000_ints(b: &mut Bencher) {
However, the optimizer can still modify a testcase in an undesirable manner
even when using either of the above.
"##,
},
Lint {
label: "test_2018_feature",
description: r##"# `test_2018_feature`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "test_unstable_lint",
description: r##"# `test_unstable_lint`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "thin_box",
description: r##"# `thin_box`
The tracking issue for this feature is: [#92791]
[#92791]: https://github.com/rust-lang/rust/issues/92791
------------------------
"##,
},
Lint {
label: "thread_id_value",
description: r##"# `thread_id_value`
The tracking issue for this feature is: [#67939]
[#67939]: https://github.com/rust-lang/rust/issues/67939
------------------------
"##,
},
Lint {
label: "thread_local",
description: r##"# `thread_local`
The tracking issue for this feature is: [#29594]
[#29594]: https://github.com/rust-lang/rust/issues/29594
------------------------
"##,
},
Lint {
@@ -4030,6 +8585,28 @@ fn bench_xor_1000_ints(b: &mut Bencher) {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "thread_sleep_until",
description: r##"# `thread_sleep_until`
The tracking issue for this feature is: [#113752]
[#113752]: https://github.com/rust-lang/rust/issues/113752
------------------------
"##,
},
Lint {
label: "thread_spawn_unchecked",
description: r##"# `thread_spawn_unchecked`
The tracking issue for this feature is: [#55132]
[#55132]: https://github.com/rust-lang/rust/issues/55132
------------------------
"##,
},
@@ -4074,6 +8651,17 @@ fn main() {
Finished dev [unoptimized + debuginfo] target(s) in 0.60 secs
```
"##,
},
Lint {
label: "track_path",
description: r##"# `track_path`
The tracking issue for this feature is: [#99515]
[#99515]: https://github.com/rust-lang/rust/issues/99515
------------------------
"##,
},
Lint {
@@ -4143,6 +8731,28 @@ impl<T: Foo + ?Sized> Bar for T {}
let bar: &dyn Bar = &123;
let foo: &dyn Foo = bar;
```
"##,
},
Lint {
label: "transmutability",
description: r##"# `transmutability`
The tracking issue for this feature is: [#99571]
[#99571]: https://github.com/rust-lang/rust/issues/99571
------------------------
"##,
},
Lint {
label: "transmute_generic_consts",
description: r##"# `transmute_generic_consts`
The tracking issue for this feature is: [#109929]
[#109929]: https://github.com/rust-lang/rust/issues/109929
------------------------
"##,
},
Lint {
@@ -4230,6 +8840,59 @@ pub union GenericUnion<T: Copy> { // Unions with non-`Copy` fields are unstable.
it is transparent). The Rust compiler is free to perform this optimization if
possible, but is not required to, and different compiler versions may differ in
their application of these optimizations.
"##,
},
Lint {
label: "trivial_bounds",
description: r##"# `trivial_bounds`
The tracking issue for this feature is: [#48214]
[#48214]: https://github.com/rust-lang/rust/issues/48214
------------------------
"##,
},
Lint {
label: "trusted_len",
description: r##"# `trusted_len`
The tracking issue for this feature is: [#37572]
[#37572]: https://github.com/rust-lang/rust/issues/37572
------------------------
"##,
},
Lint {
label: "trusted_len_next_unchecked",
description: r##"# `trusted_len_next_unchecked`
The tracking issue for this feature is: [#37572]
[#37572]: https://github.com/rust-lang/rust/issues/37572
------------------------
"##,
},
Lint {
label: "trusted_random_access",
description: r##"# `trusted_random_access`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "trusted_step",
description: r##"# `trusted_step`
The tracking issue for this feature is: [#85731]
[#85731]: https://github.com/rust-lang/rust/issues/85731
------------------------
"##,
},
Lint {
@@ -4264,6 +8927,92 @@ pub union GenericUnion<T: Copy> { // Unions with non-`Copy` fields are unstable.
};
assert!(result.is_err());
```
"##,
},
Lint {
label: "try_find",
description: r##"# `try_find`
The tracking issue for this feature is: [#63178]
[#63178]: https://github.com/rust-lang/rust/issues/63178
------------------------
"##,
},
Lint {
label: "try_reserve_kind",
description: r##"# `try_reserve_kind`
The tracking issue for this feature is: [#48043]
[#48043]: https://github.com/rust-lang/rust/issues/48043
------------------------
"##,
},
Lint {
label: "try_trait_v2",
description: r##"# `try_trait_v2`
The tracking issue for this feature is: [#84277]
[#84277]: https://github.com/rust-lang/rust/issues/84277
------------------------
"##,
},
Lint {
label: "try_trait_v2_residual",
description: r##"# `try_trait_v2_residual`
The tracking issue for this feature is: [#91285]
[#91285]: https://github.com/rust-lang/rust/issues/91285
------------------------
"##,
},
Lint {
label: "try_trait_v2_yeet",
description: r##"# `try_trait_v2_yeet`
The tracking issue for this feature is: [#96374]
[#96374]: https://github.com/rust-lang/rust/issues/96374
------------------------
"##,
},
Lint {
label: "tuple_trait",
description: r##"# `tuple_trait`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "type_alias_impl_trait",
description: r##"# `type_alias_impl_trait`
The tracking issue for this feature is: [#63063]
[#63063]: https://github.com/rust-lang/rust/issues/63063
------------------------
"##,
},
Lint {
label: "type_ascription",
description: r##"# `type_ascription`
The tracking issue for this feature is: [#23416]
[#23416]: https://github.com/rust-lang/rust/issues/23416
------------------------
"##,
},
Lint {
@@ -4301,6 +9050,39 @@ struct Foo<T, U> {
};
}
```
"##,
},
Lint {
label: "type_name_of_val",
description: r##"# `type_name_of_val`
The tracking issue for this feature is: [#66359]
[#66359]: https://github.com/rust-lang/rust/issues/66359
------------------------
"##,
},
Lint {
label: "type_privacy_lints",
description: r##"# `type_privacy_lints`
The tracking issue for this feature is: [#48054]
[#48054]: https://github.com/rust-lang/rust/issues/48054
------------------------
"##,
},
Lint {
label: "uefi_std",
description: r##"# `uefi_std`
The tracking issue for this feature is: [#100499]
[#100499]: https://github.com/rust-lang/rust/issues/100499
------------------------
"##,
},
Lint {
@@ -4319,7 +9101,7 @@ struct Foo<T, U> {
required for implementing the [`Fn*`] family of traits. `"rust-call"` functions must have
exactly one (non self) argument, a tuple representing the argument list.
[`Fn*`]: https://doc.rust-lang.org/std/ops/trait.Fn.html
[`Fn*`]: ../../std/ops/trait.Fn.html
```rust
#![feature(unboxed_closures)]
@@ -4330,6 +9112,200 @@ extern "rust-call" fn add_args(args: (u32, u32)) -> u32 {
fn main() {}
```
"##,
},
Lint {
label: "unchecked_math",
description: r##"# `unchecked_math`
The tracking issue for this feature is: [#85122]
[#85122]: https://github.com/rust-lang/rust/issues/85122
------------------------
"##,
},
Lint {
label: "unicode_internals",
description: r##"# `unicode_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "unique_rc_arc",
description: r##"# `unique_rc_arc`
The tracking issue for this feature is: [#112566]
[#112566]: https://github.com/rust-lang/rust/issues/112566
------------------------
"##,
},
Lint {
label: "unix_file_vectored_at",
description: r##"# `unix_file_vectored_at`
The tracking issue for this feature is: [#89517]
[#89517]: https://github.com/rust-lang/rust/issues/89517
------------------------
"##,
},
Lint {
label: "unix_set_mark",
description: r##"# `unix_set_mark`
The tracking issue for this feature is: [#96467]
[#96467]: https://github.com/rust-lang/rust/issues/96467
------------------------
"##,
},
Lint {
label: "unix_sigpipe",
description: r##"# `unix_sigpipe`
The tracking issue for this feature is: [#97889]
[#97889]: https://github.com/rust-lang/rust/issues/97889
---
The `#[unix_sigpipe = "..."]` attribute on `fn main()` can be used to specify how libstd shall setup `SIGPIPE` on Unix platforms before invoking `fn main()`. This attribute is ignored on non-Unix targets. There are three variants:
* `#[unix_sigpipe = "inherit"]`
* `#[unix_sigpipe = "sig_dfl"]`
* `#[unix_sigpipe = "sig_ign"]`
## `#[unix_sigpipe = "inherit"]`
Leave `SIGPIPE` untouched before entering `fn main()`. Unless the parent process has changed the default `SIGPIPE` handler from `SIG_DFL` to something else, this will behave the same as `#[unix_sigpipe = "sig_dfl"]`.
## `#[unix_sigpipe = "sig_dfl"]`
Set the `SIGPIPE` handler to `SIG_DFL`. This will result in your program getting killed if it tries to write to a closed pipe. This is normally what you want if your program produces textual output.
### Example
```rust,no_run
#![feature(unix_sigpipe)]
#[unix_sigpipe = "sig_dfl"]
fn main() { loop { println!("hello world"); } }
```
```bash
% ./main | head -n 1
hello world
```
## `#[unix_sigpipe = "sig_ign"]`
Set the `SIGPIPE` handler to `SIG_IGN` before invoking `fn main()`. This will result in `ErrorKind::BrokenPipe` errors if you program tries to write to a closed pipe. This is normally what you want if you for example write socket servers, socket clients, or pipe peers.
This is what libstd has done by default since 2014. (However, see the note on child processes below.)
### Example
```rust,no_run
#![feature(unix_sigpipe)]
#[unix_sigpipe = "sig_ign"]
fn main() { loop { println!("hello world"); } }
```
```bash
% ./main | head -n 1
hello world
thread 'main' panicked at 'failed printing to stdout: Broken pipe (os error 32)', library/std/src/io/stdio.rs:1016:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
### Note on child processes
When spawning child processes, the legacy Rust behavior if `#[unix_sigpipe]` is not specified is to
reset `SIGPIPE` to `SIG_DFL`.
If `#[unix_sigpipe = "..."]` is specified, no matter what its value is, the signal disposition of
`SIGPIPE` is no longer reset. This means that the child inherits the parent's `SIGPIPE` behavior.
"##,
},
Lint {
label: "unix_socket_ancillary_data",
description: r##"# `unix_socket_ancillary_data`
The tracking issue for this feature is: [#76915]
[#76915]: https://github.com/rust-lang/rust/issues/76915
------------------------
"##,
},
Lint {
label: "unix_socket_peek",
description: r##"# `unix_socket_peek`
The tracking issue for this feature is: [#76923]
[#76923]: https://github.com/rust-lang/rust/issues/76923
------------------------
"##,
},
Lint {
label: "unnamed_fields",
description: r##"# `unnamed_fields`
The tracking issue for this feature is: [#49804]
[#49804]: https://github.com/rust-lang/rust/issues/49804
------------------------
"##,
},
Lint {
label: "unsafe_cell_from_mut",
description: r##"# `unsafe_cell_from_mut`
The tracking issue for this feature is: [#111645]
[#111645]: https://github.com/rust-lang/rust/issues/111645
------------------------
"##,
},
Lint {
label: "unsafe_pin_internals",
description: r##"# `unsafe_pin_internals`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "unsize",
description: r##"# `unsize`
The tracking issue for this feature is: [#18598]
[#18598]: https://github.com/rust-lang/rust/issues/18598
------------------------
"##,
},
Lint {
label: "unsized_fn_params",
description: r##"# `unsized_fn_params`
The tracking issue for this feature is: [#48055]
[#48055]: https://github.com/rust-lang/rust/issues/48055
------------------------
"##,
},
Lint {
@@ -4540,6 +9516,17 @@ fn main() {
```
[RFC0401]: https://github.com/rust-lang/rfcs/blob/master/text/0401-coercions.md
"##,
},
Lint {
label: "unwrap_infallible",
description: r##"# `unwrap_infallible`
The tracking issue for this feature is: [#61695]
[#61695]: https://github.com/rust-lang/rust/issues/61695
------------------------
"##,
},
Lint {
@@ -4548,6 +9535,149 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "used_with_arg",
description: r##"# `used_with_arg`
The tracking issue for this feature is: [#93798]
[#93798]: https://github.com/rust-lang/rust/issues/93798
------------------------
"##,
},
Lint {
label: "utf16_extra",
description: r##"# `utf16_extra`
The tracking issue for this feature is: [#94919]
[#94919]: https://github.com/rust-lang/rust/issues/94919
------------------------
"##,
},
Lint {
label: "utf16_extra_const",
description: r##"# `utf16_extra_const`
The tracking issue for this feature is: [#94919]
[#94919]: https://github.com/rust-lang/rust/issues/94919
------------------------
"##,
},
Lint {
label: "utf8_chunks",
description: r##"# `utf8_chunks`
The tracking issue for this feature is: [#99543]
[#99543]: https://github.com/rust-lang/rust/issues/99543
------------------------
"##,
},
Lint {
label: "variant_count",
description: r##"# `variant_count`
The tracking issue for this feature is: [#73662]
[#73662]: https://github.com/rust-lang/rust/issues/73662
------------------------
"##,
},
Lint {
label: "vec_into_raw_parts",
description: r##"# `vec_into_raw_parts`
The tracking issue for this feature is: [#65816]
[#65816]: https://github.com/rust-lang/rust/issues/65816
------------------------
"##,
},
Lint {
label: "vec_push_within_capacity",
description: r##"# `vec_push_within_capacity`
The tracking issue for this feature is: [#100486]
[#100486]: https://github.com/rust-lang/rust/issues/100486
------------------------
"##,
},
Lint {
label: "vec_split_at_spare",
description: r##"# `vec_split_at_spare`
The tracking issue for this feature is: [#81944]
[#81944]: https://github.com/rust-lang/rust/issues/81944
------------------------
"##,
},
Lint {
label: "waker_getters",
description: r##"# `waker_getters`
The tracking issue for this feature is: [#87021]
[#87021]: https://github.com/rust-lang/rust/issues/87021
------------------------
"##,
},
Lint {
label: "wasi_ext",
description: r##"# `wasi_ext`
The tracking issue for this feature is: [#71213]
[#71213]: https://github.com/rust-lang/rust/issues/71213
------------------------
"##,
},
Lint {
label: "wasm_abi",
description: r##"# `wasm_abi`
The tracking issue for this feature is: [#83788]
[#83788]: https://github.com/rust-lang/rust/issues/83788
------------------------
"##,
},
Lint {
label: "wasm_target_feature",
description: r##"# `wasm_target_feature`
The tracking issue for this feature is: [#44839]
[#44839]: https://github.com/rust-lang/rust/issues/44839
------------------------
"##,
},
Lint {
label: "windows_by_handle",
description: r##"# `windows_by_handle`
The tracking issue for this feature is: [#63010]
[#63010]: https://github.com/rust-lang/rust/issues/63010
------------------------
"##,
},
@@ -4575,6 +9705,59 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "windows_process_exit_code_from",
description: r##"# `windows_process_exit_code_from`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "windows_process_extensions_async_pipes",
description: r##"# `windows_process_extensions_async_pipes`
The tracking issue for this feature is: [#98289]
[#98289]: https://github.com/rust-lang/rust/issues/98289
------------------------
"##,
},
Lint {
label: "windows_process_extensions_force_quotes",
description: r##"# `windows_process_extensions_force_quotes`
The tracking issue for this feature is: [#82227]
[#82227]: https://github.com/rust-lang/rust/issues/82227
------------------------
"##,
},
Lint {
label: "windows_process_extensions_main_thread_handle",
description: r##"# `windows_process_extensions_main_thread_handle`
The tracking issue for this feature is: [#96723]
[#96723]: https://github.com/rust-lang/rust/issues/96723
------------------------
"##,
},
Lint {
label: "windows_process_extensions_raw_attribute",
description: r##"# `windows_process_extensions_raw_attribute`
The tracking issue for this feature is: [#114854]
[#114854]: https://github.com/rust-lang/rust/issues/114854
------------------------
"##,
},
@@ -4585,17 +9768,129 @@ fn main() {
This feature is internal to the Rust compiler and is not intended for general use.
------------------------
"##,
},
Lint {
label: "with_negative_coherence",
description: r##"# `with_negative_coherence`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "wrapping_int_impl",
description: r##"# `wrapping_int_impl`
The tracking issue for this feature is: [#32463]
[#32463]: https://github.com/rust-lang/rust/issues/32463
------------------------
"##,
},
Lint {
label: "wrapping_next_power_of_two",
description: r##"# `wrapping_next_power_of_two`
The tracking issue for this feature is: [#32463]
[#32463]: https://github.com/rust-lang/rust/issues/32463
------------------------
"##,
},
Lint {
label: "write_all_vectored",
description: r##"# `write_all_vectored`
The tracking issue for this feature is: [#70436]
[#70436]: https://github.com/rust-lang/rust/issues/70436
------------------------
"##,
},
Lint {
label: "yeet_desugar_details",
description: r##"# `yeet_desugar_details`
This feature has no tracking issue, and is therefore likely internal to the compiler, not being intended for general use.
------------------------
"##,
},
Lint {
label: "yeet_expr",
description: r##"# `yeet_expr`
The tracking issue for this feature is: [#96373]
[#96373]: https://github.com/rust-lang/rust/issues/96373
------------------------
The `yeet_expr` feature adds support for `do yeet` expressions,
which can be used to early-exit from a function or `try` block.
These are highly experimental, thus the placeholder syntax.
```rust,edition2021
#![feature(yeet_expr)]
fn foo() -> Result<String, i32> {
do yeet 4;
}
assert_eq!(foo(), Err(4));
fn bar() -> Option<String> {
do yeet;
}
assert_eq!(bar(), None);
```
"##,
},
];
pub const CLIPPY_LINTS: &[Lint] = &[
Lint {
label: "clippy::absolute_paths",
description: r##"Checks for usage of items through absolute paths, like `std::env::current_dir`."##,
},
Lint {
label: "clippy::absurd_extreme_comparisons",
description: r##"Checks for comparisons where one side of the relation is
either the minimum or maximum value for its type and warns if it involves a
case that is always true or always false. Only integer and boolean types are
checked."##,
},
Lint {
label: "clippy::alloc_instead_of_core",
description: r##"Finds items imported through `alloc` when available through `core`."##,
},
Lint {
label: "clippy::allow_attributes",
description: r##"Checks for usage of the `#[allow]` attribute and suggests replacing it with
the `#[expect]` (See [RFC 2383](https://rust-lang.github.io/rfcs/2383-lint-reasons.html))
The expect attribute is still unstable and requires the `lint_reasons`
on nightly. It can be enabled by adding `#![feature(lint_reasons)]` to
the crate root.
This lint only warns outer attributes (`#[allow]`), as inner attributes
(`#![allow]`) are usually used to enable or disable lints on a global scale."##,
},
Lint {
label: "clippy::allow_attributes_without_reason",
description: r##"Checks for attributes that allow lints without a reason.
(This requires the `lint_reasons` feature)"##,
},
Lint {
label: "clippy::almost_complete_range",
description: r##"Checks for ranges which almost include the entire range of letters from 'a' to 'z'
or digits from '0' to '9', but don't because they're a half open range."##,
},
Lint {
label: "clippy::almost_swapped",
@@ -4609,6 +9904,22 @@ fn main() {
or
[`std::f64::consts`](https://doc.rust-lang.org/stable/std/f64/consts/#constants),
respectively, suggesting to use the predefined constant."##,
},
Lint {
label: "clippy::arc_with_non_send_sync",
description: r##".
This lint warns when you use `Arc` with a type that does not implement `Send` or `Sync`."##,
},
Lint {
label: "clippy::arithmetic_side_effects",
description: r##"Checks any kind of arithmetic operation of any type.
Operators like `+`, `-`, `*` or `<<` are usually capable of overflowing according to the [Rust
Reference](https://doc.rust-lang.org/reference/expressions/operator-expr.html#overflow),
or can panic (`/`, `%`).
Known safe built-in types like `Wrapping` or `Saturating`, floats, operations in constant
environments, allowed types and non-constant operations that won't overflow are ignored."##,
},
Lint {
label: "clippy::as_conversions",
@@ -4617,15 +9928,27 @@ fn main() {
Note that this lint is specialized in linting *every single* use of `as`
regardless of whether good alternatives exist or not.
If you want more precise lints for `as`, please consider using these separate lints:
`unnecessary_cast`, `cast_lossless/possible_truncation/possible_wrap/precision_loss/sign_loss`,
`unnecessary_cast`, `cast_lossless/cast_possible_truncation/cast_possible_wrap/cast_precision_loss/cast_sign_loss`,
`fn_to_numeric_cast(_with_truncation)`, `char_lit_as_u8`, `ref_to_mut` and `ptr_as_ptr`.
There is a good explanation the reason why this lint should work in this way and how it is useful
[in this issue](https://github.com/rust-lang/rust-clippy/issues/5122)."##,
},
Lint {
label: "clippy::as_ptr_cast_mut",
description: r##"Checks for the result of a `&self`-taking `as_ptr` being cast to a mutable pointer"##,
},
Lint {
label: "clippy::as_underscore",
description: r##"Checks for the usage of `as _` conversion using inferred type."##,
},
Lint {
label: "clippy::assertions_on_constants",
description: r##"Checks for `assert!(true)` and `assert!(false)` calls."##,
},
Lint {
label: "clippy::assertions_on_result_states",
description: r##"Checks for `assert!(r.is_ok())` or `assert!(r.is_err())` calls."##,
},
Lint {
label: "clippy::assign_op_pattern",
description: r##"Checks for `a = a op b` or `a = b commutative_op a`
@@ -4639,16 +9962,19 @@ fn main() {
label: "clippy::async_yields_async",
description: r##"Checks for async blocks that yield values of types
that can themselves be awaited."##,
},
Lint {
label: "clippy::await_holding_invalid_type",
description: r##"Allows users to configure types which should not be held across `await`
suspension points."##,
},
Lint {
label: "clippy::await_holding_lock",
description: r##"Checks for calls to await while holding a
non-async-aware MutexGuard."##,
description: r##"Checks for calls to await while holding a non-async-aware MutexGuard."##,
},
Lint {
label: "clippy::await_holding_refcell_ref",
description: r##"Checks for calls to await while holding a
`RefCell` `Ref` or `RefMut`."##,
description: r##"Checks for calls to await while holding a `RefCell` `Ref` or `RefMut`."##,
},
Lint {
label: "clippy::bad_bit_mask",
@@ -4659,24 +9985,23 @@ fn main() {
{`!=`, `>=`, `>`, `!=`, `>=`, `>`}) can be determined from the following
table:
|Comparison |Bit Op|Example |is always|Formula |
|------------|------|------------|---------|----------------------|
|`==` or `!=`| `&` |`x & 2 == 3`|`false` |`c & m != c` |
|`<` or `>=`| `&` |`x & 2 < 3` |`true` |`m < c` |
|`>` or `<=`| `&` |`x & 1 > 1` |`false` |`m <= c` |
|`==` or `!=`| `|` |`x | 1 == 0`|`false` |`c | m != c` |
|`<` or `>=`| `|` |`x | 1 < 1` |`false` |`m >= c` |
|`<=` or `>` | `|` |`x | 1 > 0` |`true` |`m > c` |"##,
|Comparison |Bit Op|Example |is always|Formula |
|------------|------|-------------|---------|----------------------|
|`==` or `!=`| `&` |`x & 2 == 3` |`false` |`c & m != c` |
|`<` or `>=`| `&` |`x & 2 < 3` |`true` |`m < c` |
|`>` or `<=`| `&` |`x & 1 > 1` |`false` |`m <= c` |
|`==` or `!=`| `\\|` |`x \\| 1 == 0`|`false` |`c \\| m != c` |
|`<` or `>=`| `\\|` |`x \\| 1 < 1` |`false` |`m >= c` |
|`<=` or `>` | `\\|` |`x \\| 1 > 0` |`true` |`m > c` |"##,
},
Lint {
label: "clippy::big_endian_bytes",
description: r##"Checks for the usage of the `to_be_bytes` method and/or the function `from_be_bytes`."##,
},
Lint {
label: "clippy::bind_instead_of_map",
description: r##"Checks for usage of `_.and_then(|x| Some(y))`, `_.and_then(|x| Ok(y))` or
`_.or_else(|x| Err(y))`."##,
},
Lint {
label: "clippy::blacklisted_name",
description: r##"Checks for usage of blacklisted names for variables, such
as `foo`."##,
},
Lint {
label: "clippy::blanket_clippy_restriction_lints",
@@ -4697,6 +10022,18 @@ fn main() {
`x != true` and order comparisons such as `x < true` (or vice versa) and
suggest using the variable directly."##,
},
Lint {
label: "clippy::bool_to_int_with_if",
description: r##"Instead of using an if statement to convert a bool to an int,
this lint suggests using a `from()` function or an `as` coercion."##,
},
Lint {
label: "clippy::borrow_as_ptr",
description: r##"Checks for the usage of `&expr as *const T` or
`&mut expr as *mut T`, and suggest using `ptr::addr_of` or
`ptr::addr_of_mut` instead."##,
},
Lint { label: "clippy::borrow_deref_ref", description: r##"Checks for `&*(&T)`."## },
Lint {
label: "clippy::borrow_interior_mutable_const",
description: r##"Checks if `const` items which is interior mutable (e.g.,
@@ -4704,13 +10041,18 @@ fn main() {
},
Lint {
label: "clippy::borrowed_box",
description: r##"Checks for use of `&Box<T>` anywhere in the code.
description: r##"Checks for usage of `&Box<T>` anywhere in the code.
Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information."##,
},
Lint {
label: "clippy::box_collection",
description: r##"Checks for use of `Box<T>` where T is a collection such as Vec anywhere in the code.
description: r##"Checks for usage of `Box<T>` where T is a collection such as Vec anywhere in the code.
Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information."##,
},
Lint {
label: "clippy::box_default",
description: r##"checks for `Box::new(T::default())`, which is better written as
`Box::<T>::default()`."##,
},
Lint {
label: "clippy::boxed_local",
@@ -4726,6 +10068,11 @@ fn main() {
label: "clippy::builtin_type_shadow",
description: r##"Warns if a generic shadows a built-in type."##,
},
Lint {
label: "clippy::bytes_count_to_len",
description: r##"It checks for `str::bytes().count()` and suggests replacing it with
`str::len()`."##,
},
Lint {
label: "clippy::bytes_nth",
description: r##"Checks for the use of `.bytes().nth()`."##,
@@ -4739,24 +10086,43 @@ fn main() {
label: "clippy::case_sensitive_file_extension_comparisons",
description: r##"Checks for calls to `ends_with` with possible file extensions
and suggests to use a case-insensitive approach instead."##,
},
Lint {
label: "clippy::cast_abs_to_unsigned",
description: r##"Checks for usage of the `abs()` method that cast the result to unsigned."##,
},
Lint {
label: "clippy::cast_enum_constructor",
description: r##"Checks for casts from an enum tuple constructor to an integer."##,
},
Lint {
label: "clippy::cast_enum_truncation",
description: r##"Checks for casts from an enum type to an integral type which will definitely truncate the
value."##,
},
Lint {
label: "clippy::cast_lossless",
description: r##"Checks for casts between numerical types that may
be replaced by safe conversion functions."##,
},
Lint {
label: "clippy::cast_nan_to_int",
description: r##"Checks for a known NaN float being cast to an integer"##,
},
Lint {
label: "clippy::cast_possible_truncation",
description: r##"Checks for casts between numerical types that may
truncate large values. This is expected behavior, so the cast is `Allow` by
default."##,
default. It suggests user either explicitly ignore the lint,
or use `try_from()` and handle the truncation, default, or panic explicitly."##,
},
Lint {
label: "clippy::cast_possible_wrap",
description: r##"Checks for casts from an unsigned type to a signed type of
the same size. Performing such a cast is a 'no-op' for the compiler,
i.e., nothing is changed at the bit level, and the binary representation of
the value is reinterpreted. This can cause wrapping if the value is too big
the same size, or possibly smaller due to target dependent integers.
Performing such a cast is a 'no-op' for the compiler, i.e., nothing is
changed at the bit level, and the binary representation of the value is
reinterpreted. This can cause wrapping if the value is too big
for the target signed type. However, the cast works as defined, so this lint
is `Allow` by default."##,
},
@@ -4775,10 +10141,6 @@ fn main() {
description: r##"Checks for casts, using `as` or `pointer::cast`,
from a less-strictly-aligned pointer to a more-strictly-aligned pointer"##,
},
Lint {
label: "clippy::cast_ref_to_mut",
description: r##"Checks for casts of `&T` to `&mut T` anywhere in the code."##,
},
Lint {
label: "clippy::cast_sign_loss",
description: r##"Checks for casts from a signed to an unsigned numerical
@@ -4786,6 +10148,14 @@ fn main() {
which can be quite surprising in practice. However, as the cast works as
defined, this lint is `Allow` by default."##,
},
Lint {
label: "clippy::cast_slice_different_sizes",
description: r##"Checks for `as` casts between raw pointers to slices with differently sized elements."##,
},
Lint {
label: "clippy::cast_slice_from_raw_parts",
description: r##"Checks for a raw slice being cast to a slice pointer"##,
},
Lint {
label: "clippy::char_lit_as_u8",
description: r##"Checks for expressions where a character literal is cast
@@ -4806,8 +10176,8 @@ fn main() {
description: r##"Checks for explicit bounds checking when casting."##,
},
Lint {
label: "clippy::clone_double_ref",
description: r##"Checks for usage of `.clone()` on an `&&T`."##,
label: "clippy::clear_with_drain",
description: r##"Checks for usage of `.drain(..)` for the sole purpose of clearing a container."##,
},
Lint {
label: "clippy::clone_on_copy",
@@ -4821,10 +10191,9 @@ fn main() {
},
Lint {
label: "clippy::cloned_instead_of_copied",
description: r##"Checks for usages of `cloned()` on an `Iterator` or `Option` where
description: r##"Checks for usage of `cloned()` on an `Iterator` or `Option` where
`copied()` could be used instead."##,
},
Lint { label: "clippy::cmp_nan", description: r##"Checks for comparisons to NaN."## },
Lint {
label: "clippy::cmp_null",
description: r##"This lint checks for equality comparisons with `ptr::null`"##,
@@ -4856,6 +10225,15 @@ fn main() {
Note that this lint is not intended to find _all_ cases where nested match patterns can be merged, but only
cases where merging would most likely make the code more readable."##,
},
Lint {
label: "clippy::collapsible_str_replace",
description: r##"Checks for consecutive calls to `str::replace` (2 or more)
that can be collapsed into a single call."##,
},
Lint {
label: "clippy::collection_is_never_read",
description: r##"Checks for collections that are never queried."##,
},
Lint {
label: "clippy::comparison_chain",
description: r##"Checks comparison chains written with `if` that can be
@@ -4871,6 +10249,10 @@ fn main() {
description: r##"Checks for types that implement `Copy` as well as
`Iterator`."##,
},
Lint {
label: "clippy::crate_in_macro_def",
description: r##"Checks for usage of `crate` as opposed to `$crate` in a macro definition."##,
},
Lint {
label: "clippy::create_dir",
description: r##"Checks usage of `std::fs::create_dir` and suggest using `std::fs::create_dir_all` instead."##,
@@ -4879,7 +10261,10 @@ fn main() {
label: "clippy::crosspointer_transmute",
description: r##"Checks for transmutes between a type `T` and `*T`."##,
},
Lint { label: "clippy::dbg_macro", description: r##"Checks for usage of dbg!() macro."## },
Lint {
label: "clippy::dbg_macro",
description: r##"Checks for usage of the [`dbg!`](https://doc.rust-lang.org/std/macro.dbg.html) macro."##,
},
Lint {
label: "clippy::debug_assert_with_mut_call",
description: r##"Checks for function/method calls with a mutable
@@ -4893,6 +10278,15 @@ fn main() {
label: "clippy::declare_interior_mutable_const",
description: r##"Checks for declaration of `const` items which is interior
mutable (e.g., contains a `Cell`, `Mutex`, `AtomicXxxx`, etc.)."##,
},
Lint {
label: "clippy::default_constructed_unit_structs",
description: r##"Checks for construction on unit struct using `default`."##,
},
Lint {
label: "clippy::default_instead_of_iter_empty",
description: r##"It checks for `std::iter::Empty::default()` and suggests replacing it with
`std::iter::empty()`."##,
},
Lint {
label: "clippy::default_numeric_fallback",
@@ -4909,6 +10303,10 @@ fn main() {
label: "clippy::default_trait_access",
description: r##"Checks for literal calls to `Default::default()`."##,
},
Lint {
label: "clippy::default_union_representation",
description: r##"Displays a warning when a union is declared with the default representation (without a `#[repr(C)]` attribute)."##,
},
Lint {
label: "clippy::deprecated_cfg_attr",
description: r##"Checks for `#[cfg_attr(rustfmt, rustfmt_skip)]` and suggests to replace it
@@ -4923,23 +10321,47 @@ fn main() {
label: "clippy::deref_addrof",
description: r##"Checks for usage of `*&` and `*&mut` in expressions."##,
},
Lint {
label: "clippy::deref_by_slicing",
description: r##"Checks for slicing expressions which are equivalent to dereferencing the
value."##,
},
Lint {
label: "clippy::derivable_impls",
description: r##"Detects manual `std::default::Default` implementations that are identical to a derived implementation."##,
},
Lint {
label: "clippy::derive_hash_xor_eq",
description: r##"Checks for deriving `Hash` but implementing `PartialEq`
explicitly or vice versa."##,
label: "clippy::derive_ord_xor_partial_ord",
description: r##"Lints against manual `PartialOrd` and `Ord` implementations for types with a derived `Ord`
or `PartialOrd` implementation."##,
},
Lint {
label: "clippy::derive_ord_xor_partial_ord",
description: r##"Checks for deriving `Ord` but implementing `PartialOrd`
explicitly or vice versa."##,
label: "clippy::derive_partial_eq_without_eq",
description: r##"Checks for types that derive `PartialEq` and could implement `Eq`."##,
},
Lint {
label: "clippy::derived_hash_with_manual_eq",
description: r##"Lints against manual `PartialEq` implementations for types with a derived `Hash`
implementation."##,
},
Lint {
label: "clippy::disallowed_macros",
description: r##"Denies the configured macros in clippy.toml
Note: Even though this lint is warn-by-default, it will only trigger if
macros are defined in the clippy.toml file."##,
},
Lint {
label: "clippy::disallowed_methods",
description: r##"Denies the configured methods and functions in clippy.toml"##,
description: r##"Denies the configured methods and functions in clippy.toml
Note: Even though this lint is warn-by-default, it will only trigger if
methods are defined in the clippy.toml file."##,
},
Lint {
label: "clippy::disallowed_names",
description: r##"Checks for usage of disallowed names for variables, such
as `foo`."##,
},
Lint {
label: "clippy::disallowed_script_idents",
@@ -4958,12 +10380,20 @@ fn main() {
},
Lint {
label: "clippy::disallowed_types",
description: r##"Denies the configured types in clippy.toml."##,
description: r##"Denies the configured types in clippy.toml.
Note: Even though this lint is warn-by-default, it will only trigger if
types are defined in the clippy.toml file."##,
},
Lint {
label: "clippy::diverging_sub_expression",
description: r##"Checks for diverging calls that are not match arms or
statements."##,
},
Lint {
label: "clippy::doc_link_with_quotes",
description: r##"Detects the syntax `['foo']` in documentation comments (notice quotes instead of backticks)
outside of code blocks"##,
},
Lint {
label: "clippy::doc_markdown",
@@ -4989,14 +10419,19 @@ fn main() {
description: r##"Checks for unnecessary double parentheses."##,
},
Lint {
label: "clippy::drop_copy",
description: r##"Checks for calls to `std::mem::drop` with a value
that derives the Copy trait"##,
label: "clippy::drain_collect",
description: r##"Checks for calls to `.drain()` that clear the collection, immediately followed by a call to `.collect()`.
> Collection in this context refers to any type with a `drain` method:
> `Vec`, `VecDeque`, `BinaryHeap`, `HashSet`,`HashMap`, `String`"##,
},
Lint {
label: "clippy::drop_ref",
description: r##"Checks for calls to `std::mem::drop` with a reference
instead of an owned value."##,
label: "clippy::drop_non_drop",
description: r##"Checks for calls to `std::mem::drop` with a value that does not implement `Drop`."##,
},
Lint {
label: "clippy::duplicate_mod",
description: r##"Checks for files that are included as modules multiple times."##,
},
Lint {
label: "clippy::duplicate_underscore_argument",
@@ -5013,6 +10448,10 @@ fn main() {
description: r##"Checks for usage of if expressions with an `else if` branch,
but without a final `else` branch."##,
},
Lint {
label: "clippy::empty_drop",
description: r##"Checks for empty `Drop` implementations."##,
},
Lint {
label: "clippy::empty_enum",
description: r##"Checks for `enum`s with no variants.
@@ -5021,11 +10460,19 @@ fn main() {
nightly-only experimental API. Therefore, this lint is only triggered
if the `never_type` is enabled."##,
},
Lint {
label: "clippy::empty_line_after_doc_comments",
description: r##"Checks for empty lines after documenation comments."##,
},
Lint {
label: "clippy::empty_line_after_outer_attr",
description: r##"Checks for empty lines after outer attributes"##,
},
Lint { label: "clippy::empty_loop", description: r##"Checks for empty `loop` expressions."## },
Lint {
label: "clippy::empty_structs_with_brackets",
description: r##"Finds structs without fields (a so-called empty struct) that are declared with brackets."##,
},
Lint {
label: "clippy::enum_clike_unportable_variant",
description: r##"Checks for C-like enumerations that are
@@ -5052,10 +10499,18 @@ fn main() {
description: r##"Checks for erasing operations, e.g., `x * 0`."##,
},
Lint {
label: "clippy::eval_order_dependence",
description: r##"Checks for a read and a write to the same variable where
whether the read occurs before or after the write depends on the evaluation
order of sub-expressions."##,
label: "clippy::err_expect",
description: r##"Checks for `.err().expect()` calls on the `Result` type."##,
},
Lint {
label: "clippy::error_impl_error",
description: r##"Checks for types named `Error` that implement `Error`."##,
},
Lint {
label: "clippy::excessive_nesting",
description: r##"Checks for blocks which are nested beyond a certain threshold.
Note: Even though this lint is warn-by-default, it will only trigger if a maximum nesting level is defined in the clippy.toml file."##,
},
Lint {
label: "clippy::excessive_precision",
@@ -5072,8 +10527,7 @@ fn main() {
},
Lint {
label: "clippy::exit",
description: r##"`exit()` terminates the program and doesn't provide a
stack trace."##,
description: r##"Detects calls to the `exit()` function which terminates the program."##,
},
Lint {
label: "clippy::expect_fun_call",
@@ -5082,13 +10536,17 @@ fn main() {
},
Lint {
label: "clippy::expect_used",
description: r##"Checks for `.expect()` calls on `Option`s and `Result`s."##,
description: r##"Checks for `.expect()` or `.expect_err()` calls on `Result`s and `.expect()` call on `Option`s."##,
},
Lint {
label: "clippy::expl_impl_clone_on_copy",
description: r##"Checks for explicit `Clone` implementations for `Copy`
types."##,
},
Lint {
label: "clippy::explicit_auto_deref",
description: r##"Checks for dereferencing expressions which would be covered by auto-deref."##,
},
Lint {
label: "clippy::explicit_counter_loop",
description: r##"Checks `for` loops over slices with an explicit counter
@@ -5126,6 +10584,10 @@ fn main() {
description: r##"Checks for lifetimes in generics that are never used
anywhere else."##,
},
Lint {
label: "clippy::extra_unused_type_parameters",
description: r##"Checks for type parameters in generics that are never used anywhere else."##,
},
Lint {
label: "clippy::fallible_impl_from",
description: r##"Checks for impls of `From<..>` that contain `panic!()` or `unwrap()`"##,
@@ -5143,6 +10605,10 @@ fn main() {
label: "clippy::filter_map",
description: r##"Nothing. This lint has been deprecated."##,
},
Lint {
label: "clippy::filter_map_bool_then",
description: r##"Checks for usage of `bool::then` in `Iterator::filter_map`."##,
},
Lint {
label: "clippy::filter_map_identity",
description: r##"Checks for usage of `filter_map(|x| x)`."##,
@@ -5162,7 +10628,7 @@ fn main() {
},
Lint {
label: "clippy::flat_map_option",
description: r##"Checks for usages of `Iterator::flat_map()` where `filter_map()` could be
description: r##"Checks for usage of `Iterator::flat_map()` where `filter_map()` could be
used instead."##,
},
Lint { label: "clippy::float_arithmetic", description: r##"Checks for float arithmetic."## },
@@ -5211,18 +10677,12 @@ fn main() {
ignoring either the keys or values."##,
},
Lint {
label: "clippy::for_loops_over_fallibles",
description: r##"Checks for `for` loops over `Option` or `Result` values."##,
label: "clippy::forget_non_drop",
description: r##"Checks for calls to `std::mem::forget` with a value that does not implement `Drop`."##,
},
Lint {
label: "clippy::forget_copy",
description: r##"Checks for calls to `std::mem::forget` with a value that
derives the Copy trait"##,
},
Lint {
label: "clippy::forget_ref",
description: r##"Checks for calls to `std::mem::forget` with a reference
instead of an owned value."##,
label: "clippy::format_collect",
description: r##"Checks for usage of `.map(|_| format!(..)).collect::<String>()`."##,
},
Lint {
label: "clippy::format_in_format_args",
@@ -5230,6 +10690,15 @@ fn main() {
formatting such as `format!` itself, `write!` or `println!`. Suggests
inlining the `format!` call."##,
},
Lint {
label: "clippy::format_push_string",
description: r##"Detects cases where the result of a `format!` call is
appended to an existing `String`."##,
},
Lint {
label: "clippy::four_forward_slashes",
description: r##"Checks for outer doc comments written with 4 forward slashes (`////`)."##,
},
Lint {
label: "clippy::from_iter_instead_of_collect",
description: r##"Checks for `from_iter()` function calls on types that implement the `FromIterator`
@@ -5239,6 +10708,10 @@ fn main() {
label: "clippy::from_over_into",
description: r##"Searches for implementations of the `Into<..>` trait and suggests to implement `From<..>` instead."##,
},
Lint {
label: "clippy::from_raw_with_void_ptr",
description: r##"Checks if we're passing a `c_void` raw pointer to `{Box,Rc,Arc,Weak}::from_raw(_)`"##,
},
Lint {
label: "clippy::from_str_radix_10",
description: r##"Checks for function invocations of the form `primitive::from_str_radix(s, 10)`"##,
@@ -5249,17 +10722,26 @@ fn main() {
functions and methods to implement the `Send` marker trait. It is mostly
used by library authors (public and internal) that target an audience where
multithreaded executors are likely to be used for running these Futures."##,
},
Lint {
label: "clippy::get_first",
description: r##"Checks for usage of `x.get(0)` instead of
`x.first()`."##,
},
Lint {
label: "clippy::get_last_with_len",
description: r##"Checks for using `x.get(x.len() - 1)` instead of
description: r##"Checks for usage of `x.get(x.len() - 1)` instead of
`x.last()`."##,
},
Lint {
label: "clippy::get_unwrap",
description: r##"Checks for use of `.get().unwrap()` (or
description: r##"Checks for usage of `.get().unwrap()` (or
`.get_mut().unwrap`) on a standard library type which implements `Index`"##,
},
Lint {
label: "clippy::host_endian_bytes",
description: r##"Checks for the usage of the `to_ne_bytes` method and/or the function `from_ne_bytes`."##,
},
Lint {
label: "clippy::identity_op",
description: r##"Checks for identity operations, e.g., `x + 0`."##,
@@ -5285,12 +10767,20 @@ fn main() {
},
Lint {
label: "clippy::if_then_some_else_none",
description: r##"Checks for if-else that could be written to `bool::then`."##,
description: r##"Checks for if-else that could be written using either `bool::then` or `bool::then_some`."##,
},
Lint {
label: "clippy::ifs_same_cond",
description: r##"Checks for consecutive `if`s with the same condition."##,
},
Lint {
label: "clippy::ignored_unit_patterns",
description: r##"Checks for usage of `_` in patterns of type `()`."##,
},
Lint {
label: "clippy::impl_trait_in_params",
description: r##"Lints when `impl Trait` is being used in a function's parameters."##,
},
Lint {
label: "clippy::implicit_clone",
description: r##"Checks for the usage of `_.to_owned()`, `vec.to_vec()`, or similar when calling `_.clone()` would be clearer."##,
@@ -5305,10 +10795,25 @@ fn main() {
label: "clippy::implicit_return",
description: r##"Checks for missing return statements at the end of a block."##,
},
Lint {
label: "clippy::implicit_saturating_add",
description: r##"Checks for implicit saturating addition."##,
},
Lint {
label: "clippy::implicit_saturating_sub",
description: r##"Checks for implicit saturating subtraction."##,
},
Lint {
label: "clippy::implied_bounds_in_impls",
description: r##"Looks for bounds in `impl Trait` in return position that are implied by other bounds.
This can happen when a trait is specified that another trait already has as a supertrait
(e.g. `fn() -> impl Deref + DerefMut<Target = i32>` has an unnecessary `Deref` bound,
because `Deref` is a supertrait of `DerefMut`)"##,
},
Lint {
label: "clippy::impossible_comparisons",
description: r##"Checks for double comparisons that can never succeed"##,
},
Lint {
label: "clippy::imprecise_flops",
description: r##"Looks for floating-point expressions that
@@ -5343,10 +10848,10 @@ fn main() {
without changing the outcome. The basic structure can be seen in the
following table:
|Comparison| Bit Op |Example |equals |
|----------|---------|-----------|-------|
|`>` / `<=`|`|` / `^`|`x | 2 > 3`|`x > 3`|
|`<` / `>=`|`|` / `^`|`x ^ 1 < 4`|`x < 4`|"##,
|Comparison| Bit Op |Example |equals |
|----------|----------|------------|-------|
|`>` / `<=`|`\\|` / `^`|`x \\| 2 > 3`|`x > 3`|
|`<` / `>=`|`\\|` / `^`|`x ^ 1 < 4` |`x < 4`|"##,
},
Lint {
label: "clippy::inefficient_to_string",
@@ -5370,6 +10875,12 @@ fn main() {
label: "clippy::inherent_to_string_shadow_display",
description: r##"Checks for the definition of inherent methods with a signature of `to_string(&self) -> String` and if the type implementing this method also implements the `Display` trait."##,
},
Lint {
label: "clippy::init_numbered_fields",
description: r##"Checks for tuple structs initialized with field syntax.
It will however not lint if a base initializer is present.
The lint will also ignore code in macros."##,
},
Lint {
label: "clippy::inline_always",
description: r##"Checks for items annotated with `#[inline(always)]`,
@@ -5395,21 +10906,17 @@ fn main() {
label: "clippy::int_plus_one",
description: r##"Checks for usage of `x >= y + 1` or `x - 1 >= y` (and `<=`) in a block"##,
},
Lint {
label: "clippy::integer_arithmetic",
description: r##"Checks for integer arithmetic operations which could overflow or panic.
Specifically, checks for any operators (`+`, `-`, `*`, `<<`, etc) which are capable
of overflowing according to the [Rust
Reference](https://doc.rust-lang.org/reference/expressions/operator-expr.html#overflow),
or which can panic (`/`, `%`). No bounds analysis or sophisticated reasoning is
attempted."##,
},
Lint { label: "clippy::integer_division", description: r##"Checks for division of integers"## },
Lint {
label: "clippy::into_iter_on_ref",
description: r##"Checks for `into_iter` calls on references which should be replaced by `iter`
or `iter_mut`."##,
},
Lint {
label: "clippy::into_iter_without_iter",
description: r##"This is the opposite of the `iter_without_into_iter` lint.
It looks for `IntoIterator for (&|&mut) Type` implementations without an inherent `iter` or `iter_mut` method
on the type or on any of the types in its `Deref` chain."##,
},
Lint {
label: "clippy::invalid_null_ptr_usage",
@@ -5431,10 +10938,20 @@ fn main() {
label: "clippy::invisible_characters",
description: r##"Checks for invisible Unicode characters in the code."##,
},
Lint {
label: "clippy::is_digit_ascii_radix",
description: r##"Finds usages of [`char::is_digit`](https://doc.rust-lang.org/stable/std/primitive.char.html#method.is_digit) that
can be replaced with [`is_ascii_digit`](https://doc.rust-lang.org/stable/std/primitive.char.html#method.is_ascii_digit) or
[`is_ascii_hexdigit`](https://doc.rust-lang.org/stable/std/primitive.char.html#method.is_ascii_hexdigit)."##,
},
Lint {
label: "clippy::items_after_statements",
description: r##"Checks for items declared after some statement in a block."##,
},
Lint {
label: "clippy::items_after_test_module",
description: r##"Triggers if an item is declared after the testing module marked with `#[cfg(test)]`."##,
},
Lint {
label: "clippy::iter_cloned_collect",
description: r##"Checks for the use of `.cloned().collect()` on slice to
@@ -5444,6 +10961,11 @@ fn main() {
label: "clippy::iter_count",
description: r##"Checks for the use of `.iter().count()`."##,
},
Lint {
label: "clippy::iter_kv_map",
description: r##"Checks for iterating a map (`HashMap` or `BTreeMap`) and
ignoring either the keys or values."##,
},
Lint { label: "clippy::iter_next_loop", description: r##"Checks for loops on `x.next()`."## },
Lint {
label: "clippy::iter_next_slice",
@@ -5455,16 +10977,45 @@ fn main() {
},
Lint {
label: "clippy::iter_nth",
description: r##"Checks for use of `.iter().nth()` (and the related
description: r##"Checks for usage of `.iter().nth()` (and the related
`.iter_mut().nth()`) on standard library types with *O*(1) element access."##,
},
Lint {
label: "clippy::iter_nth_zero",
description: r##"Checks for the use of `iter.nth(0)`."##,
},
Lint {
label: "clippy::iter_on_empty_collections",
description: r##"Checks for calls to `iter`, `iter_mut` or `into_iter` on empty collections"##,
},
Lint {
label: "clippy::iter_on_single_items",
description: r##"Checks for calls to `iter`, `iter_mut` or `into_iter` on collections containing a single item"##,
},
Lint {
label: "clippy::iter_out_of_bounds",
description: r##"Looks for iterator combinator calls such as `.take(x)` or `.skip(x)`
where `x` is greater than the amount of items that an iterator will produce."##,
},
Lint {
label: "clippy::iter_overeager_cloned",
description: r##"Checks for usage of `_.cloned().<func>()` where call to `.cloned()` can be postponed."##,
},
Lint {
label: "clippy::iter_skip_next",
description: r##"Checks for use of `.skip(x).next()` on iterators."##,
description: r##"Checks for usage of `.skip(x).next()` on iterators."##,
},
Lint {
label: "clippy::iter_skip_zero",
description: r##"Checks for usage of `.skip(0)` on iterators."##,
},
Lint {
label: "clippy::iter_with_drain",
description: r##"Checks for usage of `.drain(..)` on `Vec` and `VecDeque` for iteration."##,
},
Lint {
label: "clippy::iter_without_into_iter",
description: r##"Looks for `iter` and `iter_mut` methods without an associated `IntoIterator for (&|&mut) Type` implementation."##,
},
Lint {
label: "clippy::iterator_step_by_zero",
@@ -5490,11 +11041,30 @@ fn main() {
label: "clippy::large_enum_variant",
description: r##"Checks for large size differences between variants on
`enum`s."##,
},
Lint {
label: "clippy::large_futures",
description: r##"It checks for the size of a `Future` created by `async fn` or `async {}`."##,
},
Lint {
label: "clippy::large_include_file",
description: r##"Checks for the inclusion of large files via `include_bytes!()`
and `include_str!()`"##,
},
Lint {
label: "clippy::large_stack_arrays",
description: r##"Checks for local arrays that may be too large."##,
},
Lint {
label: "clippy::large_stack_frames",
description: r##"Checks for functions that use a lot of stack space.
This often happens when constructing a large type, such as an array with a lot of elements,
or constructing *many* smaller-but-still-large structs, or copying around a lot of large types.
This lint is a more general version of [`large_stack_arrays`](https://rust-lang.github.io/rust-clippy/master/#large_stack_arrays)
that is intended to look at functions as a whole instead of only individual array expressions inside of a function."##,
},
Lint {
label: "clippy::large_types_passed_by_value",
description: r##"Checks for functions taking arguments by value, where
@@ -5519,29 +11089,42 @@ fn main() {
returned."##,
},
Lint {
label: "clippy::let_underscore_drop",
description: r##"Checks for `let _ = <expr>`
where expr has a type that implements `Drop`"##,
label: "clippy::let_underscore_future",
description: r##"Checks for `let _ = <expr>` where the resulting type of expr implements `Future`"##,
},
Lint {
label: "clippy::let_underscore_lock",
description: r##"Checks for `let _ = sync_lock`.
This supports `mutex` and `rwlock` in `std::sync` and `parking_lot`."##,
description: r##"Checks for `let _ = sync_lock`. This supports `mutex` and `rwlock` in
`parking_lot`. For `std` locks see the `rustc` lint
[`let_underscore_lock`](https://doc.rust-lang.org/nightly/rustc/lints/listing/deny-by-default.html#let-underscore-lock)"##,
},
Lint {
label: "clippy::let_underscore_must_use",
description: r##"Checks for `let _ = <expr>` where expr is `#[must_use]`"##,
},
Lint {
label: "clippy::let_underscore_untyped",
description: r##"Checks for `let _ = <expr>` without a type annotation, and suggests to either provide one,
or remove the `let` keyword altogether."##,
},
Lint { label: "clippy::let_unit_value", description: r##"Checks for binding a unit value."## },
Lint {
label: "clippy::let_with_type_underscore",
description: r##"Detects when a variable is declared with an explicit type of `_`."##,
},
Lint {
label: "clippy::lines_filter_map_ok",
description: r##"Checks for usage of `lines.filter_map(Result::ok)` or `lines.flat_map(Result::ok)`
when `lines` has type `std::io::Lines`."##,
},
Lint {
label: "clippy::linkedlist",
description: r##"Checks for usage of any `LinkedList`, suggesting to use a
`Vec` or a `VecDeque` (formerly called `RingBuf`)."##,
},
Lint {
label: "clippy::logic_bug",
description: r##"Checks for boolean expressions that contain terminals that
can be eliminated."##,
label: "clippy::little_endian_bytes",
description: r##"Checks for the usage of the `to_le_bytes` method and/or the function `from_le_bytes`."##,
},
Lint {
label: "clippy::lossy_float_literal",
@@ -5564,11 +11147,28 @@ fn main() {
label: "clippy::manual_async_fn",
description: r##"It checks for manual implementations of `async` functions."##,
},
Lint {
label: "clippy::manual_bits",
description: r##"Checks for usage of `std::mem::size_of::<T>() * 8` when
`T::BITS` is available."##,
},
Lint {
label: "clippy::manual_clamp",
description: r##"Identifies good opportunities for a clamp function from std or core, and suggests using it."##,
},
Lint {
label: "clippy::manual_filter",
description: r##"Checks for usage of `match` which could be implemented using `filter`"##,
},
Lint {
label: "clippy::manual_filter_map",
description: r##"Checks for usage of `_.filter(_).map(_)` that can be written more simply
as `filter_map(_)`."##,
},
Lint {
label: "clippy::manual_find",
description: r##"Checks for manual implementations of Iterator::find"##,
},
Lint {
label: "clippy::manual_find_map",
description: r##"Checks for usage of `_.find(_).map(_)` that can be written more simply
@@ -5576,18 +11176,56 @@ fn main() {
},
Lint {
label: "clippy::manual_flatten",
description: r##"Check for unnecessary `if let` usage in a for loop
description: r##"Checks for unnecessary `if let` usage in a for loop
where only the `Some` or `Ok` variant of the iterator element is used."##,
},
Lint {
label: "clippy::manual_hash_one",
description: r##"Checks for cases where [`BuildHasher::hash_one`] can be used.
[`BuildHasher::hash_one`]: https://doc.rust-lang.org/std/hash/trait.BuildHasher.html#method.hash_one"##,
},
Lint {
label: "clippy::manual_instant_elapsed",
description: r##"Lints subtraction between `Instant::now()` and another `Instant`."##,
},
Lint {
label: "clippy::manual_is_ascii_check",
description: r##"Suggests to use dedicated built-in methods,
`is_ascii_(lowercase|uppercase|digit)` for checking on corresponding ascii range"##,
},
Lint {
label: "clippy::manual_is_finite",
description: r##"Checks for manual `is_finite` reimplementations
(i.e., `x != <float>::INFINITY && x != <float>::NEG_INFINITY`)."##,
},
Lint {
label: "clippy::manual_is_infinite",
description: r##"Checks for manual `is_infinite` reimplementations
(i.e., `x == <float>::INFINITY || x == <float>::NEG_INFINITY`)."##,
},
Lint {
label: "clippy::manual_let_else",
description: r##"Warn of cases where `let...else` could be used"##,
},
Lint {
label: "clippy::manual_main_separator_str",
description: r##"Checks for references on `std::path::MAIN_SEPARATOR.to_string()` used
to build a `&str`."##,
},
Lint {
label: "clippy::manual_map",
description: r##"Checks for usages of `match` which could be implemented using `map`"##,
description: r##"Checks for usage of `match` which could be implemented using `map`"##,
},
Lint {
label: "clippy::manual_memcpy",
description: r##"Checks for for-loops that manually copy items between
slices that could be optimized by having a memcpy."##,
},
Lint {
label: "clippy::manual_next_back",
description: r##"Checks for `.rev().next()` on a `DoubleEndedIterator`"##,
},
Lint {
label: "clippy::manual_non_exhaustive",
description: r##"Checks for manual implementations of the non-exhaustive pattern."##,
@@ -5601,28 +11239,66 @@ fn main() {
description: r##"Checks for expressions like `x >= 3 && x < 8` that could
be more readably expressed as `(3..8).contains(x)`."##,
},
Lint {
label: "clippy::manual_range_patterns",
description: r##"Looks for combined OR patterns that are all contained in a specific range,
e.g. `6 | 4 | 5 | 9 | 7 | 8` can be rewritten as `4..=9`."##,
},
Lint {
label: "clippy::manual_rem_euclid",
description: r##"Checks for an expression like `((x % 4) + 4) % 4` which is a common manual reimplementation
of `x.rem_euclid(4)`."##,
},
Lint {
label: "clippy::manual_retain",
description: r##"Checks for code to be replaced by `.retain()`."##,
},
Lint {
label: "clippy::manual_saturating_arithmetic",
description: r##"Checks for `.checked_add/sub(x).unwrap_or(MAX/MIN)`."##,
},
Lint {
label: "clippy::manual_slice_size_calculation",
description: r##"When `a` is `&[T]`, detect `a.len() * size_of::<T>()` and suggest `size_of_val(a)`
instead."##,
},
Lint {
label: "clippy::manual_split_once",
description: r##"Checks for usages of `str::splitn(2, _)`"##,
description: r##"Checks for usage of `str::splitn(2, _)`"##,
},
Lint {
label: "clippy::manual_str_repeat",
description: r##"Checks for manual implementations of `str::repeat`"##,
},
Lint {
label: "clippy::manual_string_new",
description: r##"Checks for usage of `` to create a `String`, such as `.to_string()`, `.to_owned()`,
`String::from()` and others."##,
},
Lint {
label: "clippy::manual_strip",
description: r##"Suggests using `strip_{prefix,suffix}` over `str::{starts,ends}_with` and slicing using
the pattern's length."##,
},
Lint { label: "clippy::manual_swap", description: r##"Checks for manual swapping."## },
Lint {
label: "clippy::manual_swap",
description: r##"Checks for manual swapping.
Note that the lint will not be emitted in const blocks, as the suggestion would not be applicable."##,
},
Lint {
label: "clippy::manual_try_fold",
description: r##"Checks for usage of `Iterator::fold` with a type that implements `Try`."##,
},
Lint {
label: "clippy::manual_unwrap_or",
description: r##"Finds patterns that reimplement `Option::unwrap_or` or `Result::unwrap_or`."##,
},
Lint {
label: "clippy::manual_while_let_some",
description: r##"Looks for loops that check for emptiness of a `Vec` in the condition and pop an element
in the body as a separate operation."##,
},
Lint {
label: "clippy::many_single_char_names",
description: r##"Checks for too many variables whose name consists of a
@@ -5640,7 +11316,7 @@ fn main() {
},
Lint {
label: "clippy::map_entry",
description: r##"Checks for uses of `contains_key` + `insert` on `HashMap`
description: r##"Checks for usage of `contains_key` + `insert` on `HashMap`
or `BTreeMap`."##,
},
Lint {
@@ -5695,7 +11371,10 @@ fn main() {
},
Lint {
label: "clippy::match_same_arms",
description: r##"Checks for `match` with identical arm bodies."##,
description: r##"Checks for `match` with identical arm bodies.
Note: Does not lint on wildcards if the `non_exhaustive_omitted_patterns_lint` feature is
enabled and disallowed."##,
},
Lint {
label: "clippy::match_single_binding",
@@ -5718,10 +11397,15 @@ fn main() {
label: "clippy::maybe_infinite_iter",
description: r##"Checks for iteration that may be infinite."##,
},
Lint {
label: "clippy::maybe_misused_cfg",
description: r##"Checks for `#[cfg(features = ...)]` and suggests to replace it with
`#[cfg(feature = ...)]`."##,
},
Lint {
label: "clippy::mem_forget",
description: r##"Checks for usage of `std::mem::forget(t)` where `t` is
`Drop`."##,
`Drop` or has a field that implements `Drop`."##,
},
Lint {
label: "clippy::mem_replace_option_with_none",
@@ -5737,6 +11421,13 @@ fn main() {
label: "clippy::mem_replace_with_uninit",
description: r##"Checks for `mem::replace(&mut _, mem::uninitialized())`
and `mem::replace(&mut _, mem::zeroed())`."##,
},
Lint {
label: "clippy::min_ident_chars",
description: r##"Checks for idents which comprise of a single letter.
Note: This lint can be very noisy when enabled; it may be desirable to only enable it
temporarily."##,
},
Lint {
label: "clippy::min_max",
@@ -5751,18 +11442,38 @@ fn main() {
label: "clippy::mismatched_target_os",
description: r##"Checks for cfg attributes having operating systems used in target family position."##,
},
Lint {
label: "clippy::mismatching_type_param_order",
description: r##"Checks for type parameters which are positioned inconsistently between
a type definition and impl block. Specifically, a parameter in an impl
block which has the same name as a parameter in the type def, but is in
a different place."##,
},
Lint {
label: "clippy::misnamed_getters",
description: r##"Checks for getter methods that return a field that doesn't correspond
to the name of the method, when there is a field's whose name matches that of the method."##,
},
Lint {
label: "clippy::misrefactored_assign_op",
description: r##"Checks for `a op= a op b` or `a op= b op a` patterns."##,
},
Lint {
label: "clippy::missing_assert_message",
description: r##"Checks assertions without a custom panic message."##,
},
Lint {
label: "clippy::missing_asserts_for_indexing",
description: r##"Checks for repeated slice indexing without asserting beforehand that the length
is greater than the largest index used to index into the slice."##,
},
Lint {
label: "clippy::missing_const_for_fn",
description: r##"Suggests the use of `const` in functions and methods where possible."##,
},
Lint {
label: "clippy::missing_docs_in_private_items",
description: r##"Warns if there is missing doc for any documentable item
(public or private)."##,
description: r##"Warns if there is missing doc for any private documentable item"##,
},
Lint {
label: "clippy::missing_enforced_import_renames",
@@ -5774,6 +11485,10 @@ fn main() {
description: r##"Checks the doc comments of publicly visible functions that
return a `Result` type and warns if there is no `# Errors` section."##,
},
Lint {
label: "clippy::missing_fields_in_debug",
description: r##"Checks for manual [`core::fmt::Debug`](https://doc.rust-lang.org/core/fmt/trait.Debug.html) implementations that do not use all fields."##,
},
Lint {
label: "clippy::missing_inline_in_public_items",
description: r##"It lints if an exported function, method, trait method with default impl,
@@ -5788,6 +11503,17 @@ fn main() {
label: "clippy::missing_safety_doc",
description: r##"Checks for the doc comments of publicly visible
unsafe functions and warns if there is no `# Safety` section."##,
},
Lint { label: "clippy::missing_spin_loop", description: r##"Checks for empty spin loops"## },
Lint {
label: "clippy::missing_trait_methods",
description: r##"Checks if a provided method is used implicitly by a trait
implementation. A usage example would be a wrapper where every method
should perform some operation before delegating to the inner type's
implementation.
This lint should typically be enabled on a specific trait `impl` item
rather than globally."##,
},
Lint {
label: "clippy::mistyped_literal_suffixes",
@@ -5797,10 +11523,16 @@ fn main() {
label: "clippy::mixed_case_hex_literals",
description: r##"Warns on hexadecimal literals with mixed-case letter
digits."##,
},
Lint {
label: "clippy::mixed_read_write_in_expression",
description: r##"Checks for a read and a write to the same variable where
whether the read occurs before or after the write depends on the evaluation
order of sub-expressions."##,
},
Lint {
label: "clippy::mod_module_files",
description: r##"Checks that module layout uses only self named module files, bans mod.rs files."##,
description: r##"Checks that module layout uses only self named module files, bans `mod.rs` files."##,
},
Lint {
label: "clippy::module_inception",
@@ -5818,6 +11550,7 @@ fn main() {
description: r##"Checks for getting the remainder of a division by one or minus
one."##,
},
Lint { label: "clippy::multi_assignments", description: r##"Checks for nested assignments."## },
Lint {
label: "clippy::multiple_crate_versions",
description: r##"Checks to see if multiple versions of a crate are being
@@ -5827,6 +11560,10 @@ fn main() {
label: "clippy::multiple_inherent_impl",
description: r##"Checks for multiple inherent implementations of a struct"##,
},
Lint {
label: "clippy::multiple_unsafe_ops_per_block",
description: r##"Checks for `unsafe` blocks that contain more than one unsafe operation."##,
},
Lint {
label: "clippy::must_use_candidate",
description: r##"Checks for public functions that have no
@@ -5840,8 +11577,12 @@ fn main() {
},
Lint {
label: "clippy::mut_from_ref",
description: r##"This lint checks for functions that take immutable
references and return mutable ones."##,
description: r##"This lint checks for functions that take immutable references and return
mutable ones. This will not trigger if no unsafe code exists as there
are multiple safe functions which will do this transformation
To be on the conservative side, if there's at least one mutable
reference with the output lifetime, this lint will not trigger."##,
},
Lint {
label: "clippy::mut_mut",
@@ -5861,11 +11602,11 @@ fn main() {
},
Lint {
label: "clippy::mutex_atomic",
description: r##"Checks for usages of `Mutex<X>` where an atomic will do."##,
description: r##"Checks for usage of `Mutex<X>` where an atomic will do."##,
},
Lint {
label: "clippy::mutex_integer",
description: r##"Checks for usages of `Mutex<X>` where `X` is an integral
description: r##"Checks for usage of `Mutex<X>` where `X` is an integral
type."##,
},
Lint { label: "clippy::naive_bytecount", description: r##"Checks for naive byte counts"## },
@@ -5876,13 +11617,19 @@ fn main() {
},
Lint {
label: "clippy::needless_bitwise_bool",
description: r##"Checks for uses of bitwise and/or operators between booleans, where performance may be improved by using
description: r##"Checks for usage of bitwise and/or operators between booleans, where performance may be improved by using
a lazy and."##,
},
Lint {
label: "clippy::needless_bool",
description: r##"Checks for expressions of the form `if c { true } else {
false }` (or vice versa) and suggests using the condition directly."##,
},
Lint {
label: "clippy::needless_bool_assign",
description: r##"Checks for expressions of the form `if c { x = true } else { x = false }`
(or vice versa) and suggest assigning the variable directly from the
condition."##,
},
Lint {
label: "clippy::needless_borrow",
@@ -5891,8 +11638,13 @@ fn main() {
},
Lint {
label: "clippy::needless_borrowed_reference",
description: r##"Checks for bindings that destructure a reference and borrow the inner
description: r##"Checks for bindings that needlessly destructure a reference and borrow the inner
value with `&ref`."##,
},
Lint {
label: "clippy::needless_borrows_for_generic_args",
description: r##"Checks for borrow operations (`&`) that used as a generic argument to a
function when the borrowed value could be used."##,
},
Lint {
label: "clippy::needless_collect",
@@ -5910,11 +11662,16 @@ fn main() {
label: "clippy::needless_doctest_main",
description: r##"Checks for `fn main() { .. }` in doctests"##,
},
Lint { label: "clippy::needless_else", description: r##"Checks for empty `else` branches."## },
Lint {
label: "clippy::needless_for_each",
description: r##"Checks for usage of `for_each` that would be more simply written as a
`for` loop."##,
},
Lint {
label: "clippy::needless_if",
description: r##"Checks for empty `if` branches with no else branch."##,
},
Lint {
label: "clippy::needless_late_init",
description: r##"Checks for late initializations that can be replaced by a `let` statement
@@ -5924,11 +11681,32 @@ fn main() {
label: "clippy::needless_lifetimes",
description: r##"Checks for lifetime annotations which can be removed by
relying on lifetime elision."##,
},
Lint {
label: "clippy::needless_match",
description: r##"Checks for unnecessary `match` or match-like `if let` returns for `Option` and `Result`
when function signatures are the same."##,
},
Lint {
label: "clippy::needless_option_as_deref",
description: r##"Checks for no-op uses of Option::{as_deref,as_deref_mut},
description: r##"Checks for no-op uses of `Option::{as_deref, as_deref_mut}`,
for example, `Option<&T>::as_deref()` returns the same type."##,
},
Lint {
label: "clippy::needless_option_take",
description: r##"Checks for calling `take` function after `as_ref`."##,
},
Lint {
label: "clippy::needless_parens_on_range_literals",
description: r##"The lint checks for parenthesis on literals in range statements that are
superfluous."##,
},
Lint {
label: "clippy::needless_pass_by_ref_mut",
description: r##"Check if a `&mut` function argument is actually used mutably.
Be careful if the function is publicly reexported as it would break compatibility with
users of this function."##,
},
Lint {
label: "clippy::needless_pass_by_value",
@@ -5936,6 +11714,10 @@ fn main() {
consuming them in its
body."##,
},
Lint {
label: "clippy::needless_pub_self",
description: r##"Checks for usage of `pub(self)` and `pub(in self)`."##,
},
Lint {
label: "clippy::needless_question_mark",
description: r##"Suggests alternatives for useless applications of `?` in terminating expressions"##,
@@ -5945,13 +11727,25 @@ fn main() {
description: r##"Checks for looping over the range of `0..len` of some
collection just to get the values by index."##,
},
Lint {
label: "clippy::needless_raw_string_hashes",
description: r##"Checks for raw string literals with an unnecessary amount of hashes around them."##,
},
Lint {
label: "clippy::needless_raw_strings",
description: r##"Checks for raw string literals where a string literal can be used instead."##,
},
Lint {
label: "clippy::needless_return",
description: r##"Checks for return statements at the end of a block."##,
},
Lint {
label: "clippy::needless_return_with_question_mark",
description: r##"Checks for return statements on `Err` paired with the `?` operator."##,
},
Lint {
label: "clippy::needless_splitn",
description: r##"Checks for usages of `str::splitn` (or `str::rsplitn`) where using `str::split` would be the same."##,
description: r##"Checks for usage of `str::splitn` (or `str::rsplitn`) where using `str::split` would be the same."##,
},
Lint {
label: "clippy::needless_update",
@@ -5985,7 +11779,7 @@ fn main() {
},
Lint {
label: "clippy::new_without_default",
description: r##"Checks for types with a `fn new() -> Self` method and no
description: r##"Checks for public types with a `pub fn new() -> Self` method and no
implementation of
[`Default`](https://doc.rust-lang.org/std/default/trait.Default.html)."##,
},
@@ -5993,14 +11787,34 @@ fn main() {
label: "clippy::no_effect",
description: r##"Checks for statements which have no effect."##,
},
Lint {
label: "clippy::no_effect_replace",
description: r##"Checks for `replace` statements which have no effect."##,
},
Lint {
label: "clippy::no_effect_underscore_binding",
description: r##"Checks for binding to underscore prefixed variable without side-effects."##,
},
Lint {
label: "clippy::no_mangle_with_rust_abi",
description: r##"Checks for Rust ABI functions with the `#[no_mangle]` attribute."##,
},
Lint {
label: "clippy::non_ascii_literal",
description: r##"Checks for non-ASCII characters in string and char literals."##,
},
Lint {
label: "clippy::non_canonical_clone_impl",
description: r##"Checks for non-canonical implementations of `Clone` when `Copy` is already implemented."##,
},
Lint {
label: "clippy::non_canonical_partial_ord_impl",
description: r##"Checks for non-canonical implementations of `PartialOrd` when `Ord` is already implemented."##,
},
Lint {
label: "clippy::non_minimal_cfg",
description: r##"Checks for `any` and `all` combinators in `cfg` with only one condition."##,
},
Lint {
label: "clippy::non_octal_unix_permissions",
description: r##"Checks for non-octal values used to set Unix file permissions."##,
@@ -6032,12 +11846,20 @@ fn main() {
description: r##"Checks for public functions that dereference raw pointer
arguments but are not marked `unsafe`."##,
},
Lint {
label: "clippy::obfuscated_if_else",
description: r##"Checks for usage of `.then_some(..).unwrap_or(..)`"##,
},
Lint {
label: "clippy::octal_escapes",
description: r##"Checks for `\\0` escapes in string and byte literals that look like octal
character escapes in C."##,
},
Lint { label: "clippy::ok_expect", description: r##"Checks for usage of `ok().expect(..)`."## },
Lint {
label: "clippy::only_used_in_recursion",
description: r##"Checks for arguments that are only used in recursion with no side-effects."##,
},
Lint {
label: "clippy::op_ref",
description: r##"Checks for arguments to `==` which have their address
@@ -6046,7 +11868,7 @@ fn main() {
},
Lint {
label: "clippy::option_as_ref_deref",
description: r##"Checks for usage of `_.as_ref().map(Deref::deref)` or it's aliases (such as String::as_str)."##,
description: r##"Checks for usage of `_.as_ref().map(Deref::deref)` or its aliases (such as String::as_str)."##,
},
Lint {
label: "clippy::option_env_unwrap",
@@ -6059,7 +11881,8 @@ fn main() {
},
Lint {
label: "clippy::option_if_let_else",
description: r##"Lints usage of `if let Some(v) = ... { y } else { x }` which is more
description: r##"Lints usage of `if let Some(v) = ... { y } else { x }` and
`match .. { Some(v) => y, None/_ => x }` which are more
idiomatically done with `Option::map_or` (if the else bit is a pure
expression) or `Option::map_or_else` (if the else bit is an impure
expression)."##,
@@ -6075,14 +11898,19 @@ fn main() {
},
Lint {
label: "clippy::option_option",
description: r##"Checks for use of `Option<Option<_>>` in function signatures and type
description: r##"Checks for usage of `Option<Option<_>>` in function signatures and type
definitions"##,
},
Lint {
label: "clippy::or_fun_call",
description: r##"Checks for calls to `.or(foo(..))`, `.unwrap_or(foo(..))`,
etc., and suggests to use `or_else`, `unwrap_or_else`, etc., or
`unwrap_or_default` instead."##,
`.or_insert(foo(..))` etc., and suggests to use `.or_else(|| foo(..))`,
`.unwrap_or_else(|| foo(..))`, `.unwrap_or_default()` or `.or_default()`
etc. instead."##,
},
Lint {
label: "clippy::or_then_unwrap",
description: r##"Checks for `.or(…).unwrap()` calls to Options and Results."##,
},
Lint {
label: "clippy::out_of_bounds_indexing",
@@ -6093,23 +11921,47 @@ fn main() {
label: "clippy::overflow_check_conditional",
description: r##"Detects classic underflow/overflow checks."##,
},
Lint {
label: "clippy::overly_complex_bool_expr",
description: r##"Checks for boolean expressions that contain terminals that
can be eliminated."##,
},
Lint { label: "clippy::panic", description: r##"Checks for usage of `panic!`."## },
Lint {
label: "clippy::panic_in_result_fn",
description: r##"Checks for usage of `panic!`, `unimplemented!`, `todo!`, `unreachable!` or assertions in a function of type result."##,
description: r##"Checks for usage of `panic!` or assertions in a function of type result."##,
},
Lint {
label: "clippy::panicking_unwrap",
description: r##"Checks for calls of `unwrap[_err]()` that will always fail."##,
},
Lint {
label: "clippy::partial_pub_fields",
description: r##"Checks whether partial fields of a struct are public.
Either make all fields of a type public, or make none of them public"##,
},
Lint {
label: "clippy::partialeq_ne_impl",
description: r##"Checks for manual re-implementations of `PartialEq::ne`."##,
},
Lint {
label: "clippy::partialeq_to_none",
description: r##"Checks for binary comparisons to a literal `Option::None`."##,
},
Lint {
label: "clippy::path_buf_push_overwrite",
description: r##"* Checks for [push](https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.push)
calls on `PathBuf` that can cause overwrites."##,
},
Lint {
label: "clippy::path_ends_with_ext",
description: r##"Looks for calls to `Path::ends_with` calls where the argument looks like a file extension.
By default, Clippy has a short list of known filenames that start with a dot
but aren't necessarily file extensions (e.g. the `.git` folder), which are allowed by default.
The `allowed-dotfiles` configuration can be used to allow additional
file extensions that Clippy should not lint."##,
},
Lint {
label: "clippy::pattern_type_mismatch",
@@ -6132,6 +11984,10 @@ fn main() {
this lint can still be used to highlight areas of interest and ensure a good understanding
of ownership semantics."##,
},
Lint {
label: "clippy::permissions_set_readonly_false",
description: r##"Checks for calls to `std::fs::Permissions.set_readonly` with argument `false`."##,
},
Lint {
label: "clippy::possible_missing_comma",
description: r##"Checks for possible missing comma in an array. It lints if
@@ -6146,6 +12002,11 @@ fn main() {
* a negative numeric literal (which is really a unary `-` followed by a
numeric literal)
followed by a method call"##,
},
Lint {
label: "clippy::print_in_format_impl",
description: r##"Checks for usage of `println`, `print`, `eprintln` or `eprint` in an
implementation of a formatting trait."##,
},
Lint {
label: "clippy::print_literal",
@@ -6173,15 +12034,19 @@ fn main() {
},
Lint {
label: "clippy::ptr_arg",
description: r##"This lint checks for function arguments of type `&String`
or `&Vec` unless the references are mutable. It will also suggest you
replace `.clone()` calls with the appropriate `.to_owned()`/`to_string()`
calls."##,
description: r##"This lint checks for function arguments of type `&String`, `&Vec`,
`&PathBuf`, and `Cow<_>`. It will also suggest you replace `.clone()` calls
with the appropriate `.to_owned()`/`to_string()` calls."##,
},
Lint {
label: "clippy::ptr_as_ptr",
description: r##"Checks for `as` casts between raw pointers without changing its mutability,
namely `*const T` to `*const U` and `*mut T` to `*mut U`."##,
},
Lint {
label: "clippy::ptr_cast_constness",
description: r##"Checks for `as` casts between raw pointers which change its constness, namely `*const T` to
`*mut T` and `*mut T` to `*const T`."##,
},
Lint { label: "clippy::ptr_eq", description: r##"Use `std::ptr::eq` when applicable"## },
Lint {
@@ -6193,10 +12058,26 @@ fn main() {
label: "clippy::pub_enum_variant_names",
description: r##"Nothing. This lint has been deprecated."##,
},
Lint { label: "clippy::pub_use", description: r##"Restricts the usage of `pub use ...`"## },
Lint {
label: "clippy::pub_with_shorthand",
description: r##"Checks for usage of `pub(<loc>)` with `in`."##,
},
Lint {
label: "clippy::pub_without_shorthand",
description: r##"Checks for usage of `pub(<loc>)` without `in`.
Note: As you cannot write a module's path in `pub(<loc>)`, this will only trigger on
`pub(super)` and the like."##,
},
Lint {
label: "clippy::question_mark",
description: r##"Checks for expressions that could be replaced by the question mark operator."##,
},
Lint {
label: "clippy::question_mark_used",
description: r##"Checks for expressions that use the question mark operator and rejects them."##,
},
Lint {
label: "clippy::range_minus_one",
description: r##"Checks for inclusive ranges where 1 is subtracted from
@@ -6220,10 +12101,49 @@ fn main() {
label: "clippy::rc_buffer",
description: r##"Checks for `Rc<T>` and `Arc<T>` when `T` is a mutable buffer type such as `String` or `Vec`."##,
},
Lint {
label: "clippy::rc_clone_in_vec_init",
description: r##"Checks for reference-counted pointers (`Arc`, `Rc`, `rc::Weak`, and `sync::Weak`)
in `vec![elem; len]`"##,
},
Lint { label: "clippy::rc_mutex", description: r##"Checks for `Rc<Mutex<T>>`."## },
Lint {
label: "clippy::read_line_without_trim",
description: r##"Looks for calls to [`Stdin::read_line`] to read a line from the standard input
into a string, then later attempting to parse this string into a type without first trimming it, which will
always fail because the string has a trailing newline in it."##,
},
Lint {
label: "clippy::read_zero_byte_vec",
description: r##"This lint catches reads into a zero-length `Vec`.
Especially in the case of a call to `with_capacity`, this lint warns that read
gets the number of bytes from the `Vec`'s length, not its capacity."##,
},
Lint {
label: "clippy::readonly_write_lock",
description: r##"Looks for calls to `RwLock::write` where the lock is only used for reading."##,
},
Lint {
label: "clippy::recursive_format_impl",
description: r##"Checks for format trait implementations (e.g. `Display`) with a recursive call to itself
which uses `self` as a parameter.
This is typically done indirectly with the `write!` macro or with `to_string()`."##,
},
Lint {
label: "clippy::redundant_allocation",
description: r##"Checks for use of redundant allocations anywhere in the code."##,
description: r##"Checks for usage of redundant allocations anywhere in the code."##,
},
Lint {
label: "clippy::redundant_as_str",
description: r##"Checks for usage of `as_str()` on a `String`` chained with a method available on the `String` itself."##,
},
Lint {
label: "clippy::redundant_async_block",
description: r##"Checks for `async` block that only returns `await` on a future."##,
},
Lint {
label: "clippy::redundant_at_rest_pattern",
description: r##"Checks for `[all @ ..]` patterns."##,
},
Lint {
label: "clippy::redundant_clone",
@@ -6246,6 +12166,10 @@ fn main() {
description: r##"Checks for closures which only invoke a method on the closure
argument and can be replaced by referencing the method directly."##,
},
Lint {
label: "clippy::redundant_comparisons",
description: r##"Checks for ineffective double comparisons against constants."##,
},
Lint {
label: "clippy::redundant_else",
description: r##"Checks for `else` blocks that can be removed without changing semantics."##,
@@ -6259,6 +12183,14 @@ fn main() {
description: r##"Checks for fields in struct literals where shorthands
could be used."##,
},
Lint {
label: "clippy::redundant_guards",
description: r##"Checks for unnecessary guards in match expressions."##,
},
Lint {
label: "clippy::redundant_locals",
description: r##"Checks for redundant redefinitions of local bindings."##,
},
Lint {
label: "clippy::redundant_pattern",
description: r##"Checks for patterns in the form `name @ _`."##,
@@ -6282,19 +12214,22 @@ fn main() {
label: "clippy::redundant_static_lifetimes",
description: r##"Checks for constants and statics with an explicit `'static` lifetime."##,
},
Lint {
label: "clippy::redundant_type_annotations",
description: r##"Warns about needless / redundant type annotations."##,
},
Lint {
label: "clippy::ref_binding_to_reference",
description: r##"Checks for `ref` bindings which create a reference to a reference."##,
},
Lint {
label: "clippy::ref_in_deref",
description: r##"Checks for references in expressions that use
auto dereference."##,
},
Lint {
label: "clippy::ref_option_ref",
description: r##"Checks for usage of `&Option<&T>`."##,
},
Lint {
label: "clippy::ref_patterns",
description: r##"Checks for usages of the `ref` keyword."##,
},
Lint {
label: "clippy::regex_macro",
description: r##"Nothing. This lint has been deprecated."##,
@@ -6313,10 +12248,19 @@ fn main() {
label: "clippy::replace_consts",
description: r##"Nothing. This lint has been deprecated."##,
},
Lint {
label: "clippy::reserve_after_initialization",
description: r##"Informs the user about a more concise way to create a vector with a known capacity."##,
},
Lint {
label: "clippy::rest_pat_in_fully_bound_structs",
description: r##"Checks for unnecessary '..' pattern binding on struct when all fields are explicitly matched."##,
},
Lint {
label: "clippy::result_large_err",
description: r##"Checks for functions that return `Result` with an unusually large
`Err`-variant."##,
},
Lint {
label: "clippy::result_map_or_into_option",
description: r##"Checks for usage of `_.map_or(None, Some)`."##,
@@ -6339,7 +12283,7 @@ fn main() {
Lint {
label: "clippy::reversed_empty_ranges",
description: r##"Checks for range expressions `x..y` where both `x` and `y`
are constant and `x` is greater or equal to `y`."##,
are constant and `x` is greater to `y`. Also triggers if `x` is equal to `y` when they are conditions to a `for` loop."##,
},
Lint {
label: "clippy::same_functions_in_if_condition",
@@ -6359,6 +12303,16 @@ fn main() {
label: "clippy::search_is_some",
description: r##"Checks for an iterator or string search (such as `find()`,
`position()`, or `rposition()`) followed by a call to `is_some()` or `is_none()`."##,
},
Lint {
label: "clippy::seek_from_current",
description: r##"Checks an argument of `seek` method of `Seek` trait
and if it start seek from `SeekFrom::Current(0)`, suggests `stream_position` instead."##,
},
Lint {
label: "clippy::seek_to_start_instead_of_rewind",
description: r##"Checks for jumps to the start of a stream that implements `Seek`
and uses the `seek` method providing `Start` as parameter."##,
},
Lint {
label: "clippy::self_assignment",
@@ -6370,13 +12324,22 @@ fn main() {
},
Lint {
label: "clippy::self_named_module_files",
description: r##"Checks that module layout uses only mod.rs files."##,
description: r##"Checks that module layout uses only `mod.rs` files."##,
},
Lint {
label: "clippy::semicolon_if_nothing_returned",
description: r##"Looks for blocks of expressions and fires if the last expression returns
`()` but is not followed by a semicolon."##,
},
Lint {
label: "clippy::semicolon_inside_block",
description: r##"Suggests moving the semicolon after a block to the inside of the block, after its last
expression."##,
},
Lint {
label: "clippy::semicolon_outside_block",
description: r##"Suggests moving the semicolon from a block's final expression outside of the block."##,
},
Lint {
label: "clippy::separated_literal_suffix",
description: r##"Warns if literal suffixes are separated by an underscore.
@@ -6419,15 +12382,43 @@ fn main() {
implementation of a `std` trait (see [llogiq's blog
post](http://llogiq.github.io/2015/07/30/traits.html) for further
information) instead of an inherent implementation."##,
},
Lint {
label: "clippy::should_panic_without_expect",
description: r##"Checks for `#[should_panic]` attributes without specifying the expected panic message."##,
},
Lint {
label: "clippy::significant_drop_in_scrutinee",
description: r##"Checks for temporaries returned from function calls in a match scrutinee that have the
`clippy::has_significant_drop` attribute."##,
},
Lint {
label: "clippy::significant_drop_tightening",
description: r##"Searches for elements marked with `#[clippy::has_significant_drop]` that could be early
dropped but are in fact dropped at the end of their scopes. In other words, enforces the
tightening of their possible lifetimes."##,
},
Lint {
label: "clippy::similar_names",
description: r##"Checks for names that are very similar and thus confusing."##,
description: r##"Checks for names that are very similar and thus confusing.
Note: this lint looks for similar names throughout each
scope. To allow it, you need to allow it on the scope
level, not on the name that is reported."##,
},
Lint {
label: "clippy::single_call_fn",
description: r##"Checks for functions that are only used once. Does not lint tests."##,
},
Lint {
label: "clippy::single_char_add_str",
description: r##"Warns when using `push_str`/`insert_str` with a single-character string literal
where `push`/`insert` with a `char` would work fine."##,
},
Lint {
label: "clippy::single_char_lifetime_names",
description: r##"Checks for lifetimes with names which are one character
long."##,
},
Lint {
label: "clippy::single_char_pattern",
@@ -6445,18 +12436,32 @@ fn main() {
Lint {
label: "clippy::single_match",
description: r##"Checks for matches with a single arm where an `if let`
will usually suffice."##,
will usually suffice.
This intentionally does not lint if there are comments
inside of the other arm, so as to allow the user to document
why having another explicit pattern with an empty body is necessary,
or because the comments need to be preserved for other reasons."##,
},
Lint {
label: "clippy::single_match_else",
description: r##"Checks for matches with two arms where an `if let else` will
usually suffice."##,
},
Lint {
label: "clippy::single_range_in_vec_init",
description: r##"Checks for `Vec` or array initializations that contain only one range."##,
},
Lint {
label: "clippy::size_of_in_element_count",
description: r##"Detects expressions where
`size_of::<T>` or `size_of_val::<T>` is used as a
count of elements of type `T`"##,
},
Lint {
label: "clippy::size_of_ref",
description: r##"Checks for calls to `std::mem::size_of_val()` where the argument is
a reference to a reference."##,
},
Lint {
label: "clippy::skip_while_next",
@@ -6469,9 +12474,17 @@ fn main() {
Lint {
label: "clippy::stable_sort_primitive",
description: r##"When sorting primitive values (integers, bools, chars, as well
as arrays, slices, and tuples of such items), it is better to
as arrays, slices, and tuples of such items), it is typically better to
use an unstable sort than a stable sort."##,
},
Lint {
label: "clippy::std_instead_of_alloc",
description: r##"Finds items imported through `std` when available through `alloc`."##,
},
Lint {
label: "clippy::std_instead_of_core",
description: r##"Finds items imported through `std` when available through `core`."##,
},
Lint {
label: "clippy::str_to_string",
description: r##"This lint checks for `.to_string()` method calls on values of type `&str`."##,
@@ -6501,6 +12514,10 @@ fn main() {
description: r##"Checks for the `as_bytes` method called on string literals
that contain only ASCII characters."##,
},
Lint {
label: "clippy::string_lit_chars_any",
description: r##"Checks for `<string_lit>.chars().any(|i| i == c)`."##,
},
Lint {
label: "clippy::string_slice",
description: r##"Checks for slice operations on strings"##,
@@ -6532,9 +12549,18 @@ fn main() {
},
Lint {
label: "clippy::suspicious_assignment_formatting",
description: r##"Checks for use of the nonexistent `=*`, `=!` and `=-`
description: r##"Checks for usage of the non-existent `=*`, `=!` and `=-`
operators."##,
},
Lint {
label: "clippy::suspicious_command_arg_space",
description: r##"Checks for `Command::arg()` invocations that look like they
should be multiple arguments instead, such as `arg(-t ext2)`."##,
},
Lint {
label: "clippy::suspicious_doc_comments",
description: r##"Detects the use of outer doc comments (`///`, `/**`) followed by a bang (`!`): `///!`"##,
},
Lint {
label: "clippy::suspicious_else_formatting",
description: r##"Checks for formatting of `else`. It lints if the `else`
@@ -6561,12 +12587,24 @@ fn main() {
(https://doc.rust-lang.org/std/primitive.str.html#method.splitn) and
related functions with either zero or one splits."##,
},
Lint {
label: "clippy::suspicious_to_owned",
description: r##"Checks for the usage of `_.to_owned()`, on a `Cow<'_, _>`."##,
},
Lint {
label: "clippy::suspicious_unary_op_formatting",
description: r##"Checks the formatting of a unary operator on the right hand side
of a binary operator. It lints if there is no space between the binary and unary operators,
but there is a space between the unary and its operand."##,
},
Lint {
label: "clippy::suspicious_xor_used_as_pow",
description: r##"Warns for a Bitwise XOR (`^`) operator being probably confused as a powering. It will not trigger if any of the numbers are not in decimal."##,
},
Lint {
label: "clippy::swap_ptr_to_ref",
description: r##"Checks for calls to `core::mem::swap` where either parameter is derived from a pointer"##,
},
Lint {
label: "clippy::tabs_in_doc_comments",
description: r##"Checks doc comments for usage of tab characters."##,
@@ -6577,12 +12615,13 @@ fn main() {
assign a value in it."##,
},
Lint {
label: "clippy::to_digit_is_some",
description: r##"Checks for `.to_digit(..).is_some()` on `char`s."##,
label: "clippy::tests_outside_test_module",
description: r##"Triggers when a testing function (marked with the `#[test]` attribute) isn't inside a testing module
(marked with `#[cfg(test)]`)."##,
},
Lint {
label: "clippy::to_string_in_display",
description: r##"Checks for uses of `to_string()` in `Display` traits."##,
label: "clippy::to_digit_is_some",
description: r##"Checks for `.to_digit(..).is_some()` on `char`s."##,
},
Lint {
label: "clippy::to_string_in_format_args",
@@ -6610,7 +12649,7 @@ fn main() {
},
Lint {
label: "clippy::trait_duplication_in_bounds",
description: r##"Checks for cases where generics are being used and multiple
description: r##"Checks for cases where generics or trait objects are being used and multiple
syntax specifications for trait bounds are used simultaneously."##,
},
Lint {
@@ -6633,6 +12672,15 @@ fn main() {
label: "clippy::transmute_int_to_float",
description: r##"Checks for transmutes from an integer to a float."##,
},
Lint {
label: "clippy::transmute_int_to_non_zero",
description: r##"Checks for transmutes from integers to `NonZero*` types, and suggests their `new_unchecked`
method instead."##,
},
Lint {
label: "clippy::transmute_null_to_fn",
description: r##"Checks for null function pointer creation through transmute."##,
},
Lint {
label: "clippy::transmute_num_to_bytes",
description: r##"Checks for transmutes from a number to an array of `u8`"##,
@@ -6646,6 +12694,11 @@ fn main() {
label: "clippy::transmute_ptr_to_ref",
description: r##"Checks for transmutes from a pointer to a reference."##,
},
Lint {
label: "clippy::transmute_undefined_repr",
description: r##"Checks for transmutes between types which do not have a representation defined relative to
each other."##,
},
Lint {
label: "clippy::transmutes_expressible_as_ptr_casts",
description: r##"Checks for transmutes that could be a pointer cast."##,
@@ -6654,6 +12707,10 @@ fn main() {
label: "clippy::transmuting_null",
description: r##"Checks for transmute calls which would receive a null pointer."##,
},
Lint {
label: "clippy::trim_split_whitespace",
description: r##"Warns about calling `str::trim` (or variants) before `str::split_whitespace`."##,
},
Lint {
label: "clippy::trivial_regex",
description: r##"Checks for trivial [regex](https://crates.io/crates/regex)
@@ -6665,25 +12722,51 @@ fn main() {
the argument type is `Copy` and small enough to be more efficient to always
pass by value."##,
},
Lint { label: "clippy::try_err", description: r##"Checks for usages of `Err(x)?`."## },
Lint { label: "clippy::try_err", description: r##"Checks for usage of `Err(x)?`."## },
Lint {
label: "clippy::tuple_array_conversions",
description: r##"Checks for tuple<=>array conversions that are not done with `.into()`."##,
},
Lint {
label: "clippy::type_complexity",
description: r##"Checks for types used in structs, parameters and `let`
declarations above a certain complexity threshold."##,
},
Lint {
label: "clippy::type_id_on_box",
description: r##"Looks for calls to `<Box<dyn Any> as Any>::type_id`."##,
},
Lint {
label: "clippy::type_repetition_in_bounds",
description: r##"This lint warns about unnecessary type repetitions in trait bounds"##,
},
Lint {
label: "clippy::undocumented_unsafe_blocks",
description: r##"Checks for `unsafe` blocks without a `// Safety: ` comment
explaining why the unsafe operations performed inside
the block are safe."##,
label: "clippy::unchecked_duration_subtraction",
description: r##"Lints subtraction between an [`Instant`] and a [`Duration`]."##,
},
Lint {
label: "clippy::undropped_manually_drops",
description: r##"Prevents the safe `std::mem::drop` function from being called on `std::mem::ManuallyDrop`."##,
label: "clippy::undocumented_unsafe_blocks",
description: r##"Checks for `unsafe` blocks and impls without a `// SAFETY: ` comment
explaining why the unsafe operations performed inside
the block are safe.
Note the comment must appear on the line(s) preceding the unsafe block
with nothing appearing in between. The following is ok:
```rust
foo(
// SAFETY:
// This is a valid safety comment
unsafe { *x }
)
```
But neither of these are:
```rust
// SAFETY:
// This is not a valid safety comment
foo(
/* SAFETY: Neither is this */ unsafe { *x },
);
```"##,
},
Lint {
label: "clippy::unicode_not_nfc",
@@ -6704,6 +12787,11 @@ fn main() {
description: r##"Checks for `set_len()` call that creates `Vec` with uninitialized elements.
This is commonly caused by calling `set_len()` right after allocating or
reserving a buffer with `new()`, `default()`, `with_capacity()`, or `reserve()`."##,
},
Lint {
label: "clippy::uninlined_format_args",
description: r##"Detect when a variable is not inlined in a format string,
and suggests to inline it."##,
},
Lint {
label: "clippy::unit_arg",
@@ -6721,24 +12809,41 @@ fn main() {
description: r##"Checks for functions that expect closures of type
Fn(...) -> Ord where the implemented closure returns the unit type.
The lint also suggests to remove the semi-colon at the end of the statement if present."##,
},
Lint {
label: "clippy::unnecessary_box_returns",
description: r##"Checks for a return type containing a `Box<T>` where `T` implements `Sized`
The lint ignores `Box<T>` where `T` is larger than `unnecessary_box_size`,
as returning a large `T` directly may be detrimental to performance."##,
},
Lint {
label: "clippy::unnecessary_cast",
description: r##"Checks for casts to the same type, casts of int literals to integer types
and casts of float literals to float types."##,
description: r##"Checks for casts to the same type, casts of int literals to integer types, casts of float
literals to float types and casts between raw pointers without changing type or constness."##,
},
Lint {
label: "clippy::unnecessary_filter_map",
description: r##"Checks for `filter_map` calls which could be replaced by `filter` or `map`.
description: r##"Checks for `filter_map` calls that could be replaced by `filter` or `map`.
More specifically it checks if the closure provided is only performing one of the
filter or map operations and suggests the appropriate option."##,
},
Lint {
label: "clippy::unnecessary_find_map",
description: r##"Checks for `find_map` calls that could be replaced by `find` or `map`. More
specifically it checks if the closure provided is only performing one of the
find or map operations and suggests the appropriate option."##,
},
Lint {
label: "clippy::unnecessary_fold",
description: r##"Checks for using `fold` when a more succinct alternative exists.
description: r##"Checks for usage of `fold` when a more succinct alternative exists.
Specifically, this checks for `fold`s which could be replaced by `any`, `all`,
`sum` or `product`."##,
},
Lint {
label: "clippy::unnecessary_join",
description: r##"Checks for usage of `.collect::<Vec<String>>().join()` on iterators."##,
},
Lint {
label: "clippy::unnecessary_lazy_evaluations",
description: r##"As the counterpart to `or_fun_call`, this lint looks for unnecessary
@@ -6750,7 +12855,16 @@ fn main() {
- `and_then` to `and`
- `or_else` to `or`
- `get_or_insert_with` to `get_or_insert`
- `ok_or_else` to `ok_or`"##,
- `ok_or_else` to `ok_or`
- `then` to `then_some` (for msrv >= 1.62.0)"##,
},
Lint {
label: "clippy::unnecessary_literal_unwrap",
description: r##"Checks for `.unwrap()` related calls on `Result`s and `Option`s that are constructed."##,
},
Lint {
label: "clippy::unnecessary_map_on_constructor",
description: r##"Suggest removing the use of a may (or map_err) method when an Option or Result is being construted."##,
},
Lint {
label: "clippy::unnecessary_mut_passed",
@@ -6761,6 +12875,19 @@ fn main() {
label: "clippy::unnecessary_operation",
description: r##"Checks for expression statements that can be reduced to a
sub-expression."##,
},
Lint {
label: "clippy::unnecessary_owned_empty_strings",
description: r##"Detects cases of owned empty strings being passed as an argument to a function expecting `&str`"##,
},
Lint {
label: "clippy::unnecessary_safety_comment",
description: r##"Checks for `// SAFETY: ` comments on safe code."##,
},
Lint {
label: "clippy::unnecessary_safety_doc",
description: r##"Checks for the doc comments of publicly visible
safe functions and traits and warns if there is a `# Safety` section."##,
},
Lint {
label: "clippy::unnecessary_self_imports",
@@ -6768,8 +12895,13 @@ fn main() {
},
Lint {
label: "clippy::unnecessary_sort_by",
description: r##"Detects uses of `Vec::sort_by` passing in a closure
description: r##"Checks for usage of `Vec::sort_by` passing in a closure
which compares the two arguments, either directly or indirectly."##,
},
Lint {
label: "clippy::unnecessary_struct_initialization",
description: r##"Checks for initialization of a `struct` by copying a base without setting
any field."##,
},
Lint {
label: "clippy::unnecessary_to_owned",
@@ -6854,10 +12986,24 @@ fn main() {
label: "clippy::unused_collect",
description: r##"Nothing. This lint has been deprecated."##,
},
Lint {
label: "clippy::unused_format_specs",
description: r##"Detects [formatting parameters] that have no effect on the output of
`format!()`, `println!()` or similar macros."##,
},
Lint {
label: "clippy::unused_io_amount",
description: r##"Checks for unused written/read amount."##,
},
Lint {
label: "clippy::unused_peekable",
description: r##"Checks for the creation of a `peekable` iterator that is never `.peek()`ed"##,
},
Lint {
label: "clippy::unused_rounding",
description: r##"Detects cases where a whole-number literal float is being rounded, using
the `floor`, `ceil`, or `round` methods."##,
},
Lint {
label: "clippy::unused_self",
description: r##"Checks methods that contain a `self` argument but don't use it"##,
@@ -6876,13 +13022,17 @@ fn main() {
description: r##"Checks for functions of type `Result` that contain `expect()` or `unwrap()`"##,
},
Lint {
label: "clippy::unwrap_or_else_default",
description: r##"Checks for usages of `_.unwrap_or_else(Default::default)` on `Option` and
`Result` values."##,
label: "clippy::unwrap_or_default",
description: r##"Checks for usages of the following functions with an argument that constructs a default value
(e.g., `Default::default` or `String::new`):
- `unwrap_or`
- `unwrap_or_else`
- `or_insert`
- `or_insert_with`"##,
},
Lint {
label: "clippy::unwrap_used",
description: r##"Checks for `.unwrap()` calls on `Option`s and on `Result`s."##,
description: r##"Checks for `.unwrap()` or `.unwrap_err()` calls on `Result`s and `.unwrap()` call on `Option`s."##,
},
Lint {
label: "clippy::upper_case_acronyms",
@@ -6890,7 +13040,7 @@ fn main() {
},
Lint {
label: "clippy::use_debug",
description: r##"Checks for use of `Debug` formatting. The purpose of this
description: r##"Checks for usage of `Debug` formatting. The purpose of this
lint is to catch debugging remnants."##,
},
Lint {
@@ -6913,10 +13063,17 @@ fn main() {
description: r##"Checks for `extern crate` and `use` items annotated with
lint attributes.
This lint permits `#[allow(unused_imports)]`, `#[allow(deprecated)]`,
`#[allow(unreachable_pub)]`, `#[allow(clippy::wildcard_imports)]` and
`#[allow(clippy::enum_glob_use)]` on `use` items and `#[allow(unused_imports)]` on
`extern crate` items with a `#[macro_use]` attribute."##,
This lint permits lint attributes for lints emitted on the items themself.
For `use` items these lints are:
* deprecated
* unreachable_pub
* unused_imports
* clippy::enum_glob_use
* clippy::macro_use_imports
* clippy::wildcard_imports
For `extern crate` items these lints are:
* `unused_imports` on items with `#[macro_use]`"##,
},
Lint {
label: "clippy::useless_conversion",
@@ -6940,17 +13097,24 @@ fn main() {
},
Lint {
label: "clippy::useless_vec",
description: r##"Checks for usage of `&vec![..]` when using `&[..]` would
description: r##"Checks for usage of `vec![..]` when using `[..]` would
be possible."##,
},
Lint {
label: "clippy::vec_box",
description: r##"Checks for use of `Vec<Box<T>>` where T: Sized anywhere in the code.
description: r##"Checks for usage of `Vec<Box<T>>` where T: Sized anywhere in the code.
Check the [Box documentation](https://doc.rust-lang.org/std/boxed/index.html) for more information."##,
},
Lint {
label: "clippy::vec_init_then_push",
description: r##"Checks for calls to `push` immediately after creating a new `Vec`."##,
description: r##"Checks for calls to `push` immediately after creating a new `Vec`.
If the `Vec` is created using `with_capacity` this will only lint if the capacity is a
constant and the number of pushes is greater than or equal to the initial capacity.
If the `Vec` is extended after the initial sequence of pushes and it was default initialized
then this will only lint after there were at least four pushes. This number may change in
the future."##,
},
Lint {
label: "clippy::vec_resize_to_zero",
@@ -6963,7 +13127,7 @@ fn main() {
},
Lint {
label: "clippy::verbose_file_reads",
description: r##"Checks for use of File::read_to_end and File::read_to_string."##,
description: r##"Checks for usage of File::read_to_end and File::read_to_string."##,
},
Lint {
label: "clippy::vtable_address_comparisons",
@@ -7020,18 +13184,19 @@ fn main() {
},
Lint {
label: "clippy::wrong_self_convention",
description: r##"Checks for methods with certain name prefixes and which
doesn't match how self is taken. The actual rules are:
description: r##"Checks for methods with certain name prefixes or suffixes, and which
do not adhere to standard conventions regarding how `self` is taken.
The actual rules are:
|Prefix |Postfix |`self` taken | `self` type |
|-------|------------|-----------------------|--------------|
|`as_` | none |`&self` or `&mut self` | any |
|`from_`| none | none | any |
|`into_`| none |`self` | any |
|`is_` | none |`&self` or none | any |
|`to_` | `_mut` |`&mut self` | any |
|`to_` | not `_mut` |`self` | `Copy` |
|`to_` | not `_mut` |`&self` | not `Copy` |
|Prefix |Postfix |`self` taken | `self` type |
|-------|------------|-------------------------------|--------------|
|`as_` | none |`&self` or `&mut self` | any |
|`from_`| none | none | any |
|`into_`| none |`self` | any |
|`is_` | none |`&mut self` or `&self` or none | any |
|`to_` | `_mut` |`&mut self` | any |
|`to_` | not `_mut` |`self` | `Copy` |
|`to_` | not `_mut` |`&self` | not `Copy` |
Note: Clippy doesn't trigger methods with `to_` prefix in:
- Traits definition.
@@ -7086,15 +13251,18 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::complexity",
description: r##"lint group for: clippy::bind_instead_of_map, clippy::bool_comparison, clippy::borrowed_box, clippy::char_lit_as_u8, clippy::clone_on_copy, clippy::crosspointer_transmute, clippy::deprecated_cfg_attr, clippy::deref_addrof, clippy::derivable_impls, clippy::diverging_sub_expression, clippy::double_comparisons, clippy::double_parens, clippy::duration_subsec, clippy::explicit_counter_loop, clippy::explicit_write, clippy::extra_unused_lifetimes, clippy::filter_map_identity, clippy::filter_next, clippy::flat_map_identity, clippy::get_last_with_len, clippy::identity_op, clippy::inspect_for_each, clippy::int_plus_one, clippy::iter_count, clippy::manual_filter_map, clippy::manual_find_map, clippy::manual_flatten, clippy::manual_split_once, clippy::manual_strip, clippy::manual_swap, clippy::manual_unwrap_or, clippy::map_flatten, clippy::map_identity, clippy::match_as_ref, clippy::match_single_binding, clippy::needless_arbitrary_self_type, clippy::needless_bool, clippy::needless_borrowed_reference, clippy::needless_lifetimes, clippy::needless_option_as_deref, clippy::needless_question_mark, clippy::needless_splitn, clippy::needless_update, clippy::neg_cmp_op_on_partial_ord, clippy::no_effect, clippy::nonminimal_bool, clippy::option_as_ref_deref, clippy::option_filter_map, clippy::option_map_unit_fn, clippy::overflow_check_conditional, clippy::partialeq_ne_impl, clippy::precedence, clippy::ptr_offset_with_cast, clippy::range_zip_with_len, clippy::redundant_closure_call, clippy::redundant_slicing, clippy::ref_in_deref, clippy::repeat_once, clippy::result_map_unit_fn, clippy::search_is_some, clippy::short_circuit_statement, clippy::single_element_loop, clippy::skip_while_next, clippy::string_from_utf8_as_bytes, clippy::strlen_on_c_strings, clippy::temporary_assignment, clippy::too_many_arguments, clippy::transmute_bytes_to_str, clippy::transmute_float_to_int, clippy::transmute_int_to_bool, clippy::transmute_int_to_char, clippy::transmute_int_to_float, clippy::transmute_num_to_bytes, clippy::transmute_ptr_to_ref, clippy::transmutes_expressible_as_ptr_casts, clippy::type_complexity, clippy::unit_arg, clippy::unnecessary_cast, clippy::unnecessary_filter_map, clippy::unnecessary_operation, clippy::unnecessary_sort_by, clippy::unnecessary_unwrap, clippy::unneeded_wildcard_pattern, clippy::useless_asref, clippy::useless_conversion, clippy::useless_format, clippy::vec_box, clippy::while_let_loop, clippy::wildcard_in_or_patterns, clippy::zero_divided_by_zero, clippy::zero_prefixed_literal"##,
description: r##"lint group for: clippy::bind_instead_of_map, clippy::bool_comparison, clippy::borrow_deref_ref, clippy::borrowed_box, clippy::bytes_count_to_len, clippy::char_lit_as_u8, clippy::clone_on_copy, clippy::crosspointer_transmute, clippy::default_constructed_unit_structs, clippy::deprecated_cfg_attr, clippy::deref_addrof, clippy::derivable_impls, clippy::diverging_sub_expression, clippy::double_comparisons, clippy::double_parens, clippy::duration_subsec, clippy::excessive_nesting, clippy::explicit_auto_deref, clippy::explicit_counter_loop, clippy::explicit_write, clippy::extra_unused_lifetimes, clippy::extra_unused_type_parameters, clippy::filter_map_identity, clippy::filter_next, clippy::flat_map_identity, clippy::get_last_with_len, clippy::identity_op, clippy::inspect_for_each, clippy::int_plus_one, clippy::iter_count, clippy::iter_kv_map, clippy::let_with_type_underscore, clippy::manual_filter, clippy::manual_filter_map, clippy::manual_find, clippy::manual_find_map, clippy::manual_flatten, clippy::manual_hash_one, clippy::manual_main_separator_str, clippy::manual_range_patterns, clippy::manual_rem_euclid, clippy::manual_slice_size_calculation, clippy::manual_split_once, clippy::manual_strip, clippy::manual_swap, clippy::manual_unwrap_or, clippy::map_flatten, clippy::map_identity, clippy::match_as_ref, clippy::match_single_binding, clippy::needless_arbitrary_self_type, clippy::needless_bool, clippy::needless_bool_assign, clippy::needless_borrowed_reference, clippy::needless_if, clippy::needless_lifetimes, clippy::needless_match, clippy::needless_option_as_deref, clippy::needless_option_take, clippy::needless_question_mark, clippy::needless_splitn, clippy::needless_update, clippy::neg_cmp_op_on_partial_ord, clippy::no_effect, clippy::nonminimal_bool, clippy::only_used_in_recursion, clippy::option_as_ref_deref, clippy::option_filter_map, clippy::option_map_unit_fn, clippy::or_then_unwrap, clippy::overflow_check_conditional, clippy::partialeq_ne_impl, clippy::precedence, clippy::ptr_offset_with_cast, clippy::range_zip_with_len, clippy::redundant_as_str, clippy::redundant_async_block, clippy::redundant_at_rest_pattern, clippy::redundant_closure_call, clippy::redundant_guards, clippy::redundant_slicing, clippy::repeat_once, clippy::reserve_after_initialization, clippy::result_map_unit_fn, clippy::search_is_some, clippy::seek_from_current, clippy::seek_to_start_instead_of_rewind, clippy::short_circuit_statement, clippy::single_element_loop, clippy::skip_while_next, clippy::string_from_utf8_as_bytes, clippy::strlen_on_c_strings, clippy::temporary_assignment, clippy::too_many_arguments, clippy::transmute_bytes_to_str, clippy::transmute_float_to_int, clippy::transmute_int_to_bool, clippy::transmute_int_to_char, clippy::transmute_int_to_float, clippy::transmute_int_to_non_zero, clippy::transmute_num_to_bytes, clippy::transmute_ptr_to_ref, clippy::transmutes_expressible_as_ptr_casts, clippy::type_complexity, clippy::unit_arg, clippy::unnecessary_cast, clippy::unnecessary_filter_map, clippy::unnecessary_find_map, clippy::unnecessary_literal_unwrap, clippy::unnecessary_map_on_constructor, clippy::unnecessary_operation, clippy::unnecessary_sort_by, clippy::unnecessary_unwrap, clippy::unneeded_wildcard_pattern, clippy::unused_format_specs, clippy::useless_asref, clippy::useless_conversion, clippy::useless_format, clippy::useless_transmute, clippy::vec_box, clippy::while_let_loop, clippy::wildcard_in_or_patterns, clippy::zero_divided_by_zero, clippy::zero_prefixed_literal"##,
},
children: &[
"clippy::bind_instead_of_map",
"clippy::bool_comparison",
"clippy::borrow_deref_ref",
"clippy::borrowed_box",
"clippy::bytes_count_to_len",
"clippy::char_lit_as_u8",
"clippy::clone_on_copy",
"clippy::crosspointer_transmute",
"clippy::default_constructed_unit_structs",
"clippy::deprecated_cfg_attr",
"clippy::deref_addrof",
"clippy::derivable_impls",
@@ -7102,9 +13270,12 @@ fn main() {
"clippy::double_comparisons",
"clippy::double_parens",
"clippy::duration_subsec",
"clippy::excessive_nesting",
"clippy::explicit_auto_deref",
"clippy::explicit_counter_loop",
"clippy::explicit_write",
"clippy::extra_unused_lifetimes",
"clippy::extra_unused_type_parameters",
"clippy::filter_map_identity",
"clippy::filter_next",
"clippy::flat_map_identity",
@@ -7113,9 +13284,18 @@ fn main() {
"clippy::inspect_for_each",
"clippy::int_plus_one",
"clippy::iter_count",
"clippy::iter_kv_map",
"clippy::let_with_type_underscore",
"clippy::manual_filter",
"clippy::manual_filter_map",
"clippy::manual_find",
"clippy::manual_find_map",
"clippy::manual_flatten",
"clippy::manual_hash_one",
"clippy::manual_main_separator_str",
"clippy::manual_range_patterns",
"clippy::manual_rem_euclid",
"clippy::manual_slice_size_calculation",
"clippy::manual_split_once",
"clippy::manual_strip",
"clippy::manual_swap",
@@ -7126,29 +13306,41 @@ fn main() {
"clippy::match_single_binding",
"clippy::needless_arbitrary_self_type",
"clippy::needless_bool",
"clippy::needless_bool_assign",
"clippy::needless_borrowed_reference",
"clippy::needless_if",
"clippy::needless_lifetimes",
"clippy::needless_match",
"clippy::needless_option_as_deref",
"clippy::needless_option_take",
"clippy::needless_question_mark",
"clippy::needless_splitn",
"clippy::needless_update",
"clippy::neg_cmp_op_on_partial_ord",
"clippy::no_effect",
"clippy::nonminimal_bool",
"clippy::only_used_in_recursion",
"clippy::option_as_ref_deref",
"clippy::option_filter_map",
"clippy::option_map_unit_fn",
"clippy::or_then_unwrap",
"clippy::overflow_check_conditional",
"clippy::partialeq_ne_impl",
"clippy::precedence",
"clippy::ptr_offset_with_cast",
"clippy::range_zip_with_len",
"clippy::redundant_as_str",
"clippy::redundant_async_block",
"clippy::redundant_at_rest_pattern",
"clippy::redundant_closure_call",
"clippy::redundant_guards",
"clippy::redundant_slicing",
"clippy::ref_in_deref",
"clippy::repeat_once",
"clippy::reserve_after_initialization",
"clippy::result_map_unit_fn",
"clippy::search_is_some",
"clippy::seek_from_current",
"clippy::seek_to_start_instead_of_rewind",
"clippy::short_circuit_statement",
"clippy::single_element_loop",
"clippy::skip_while_next",
@@ -7161,6 +13353,7 @@ fn main() {
"clippy::transmute_int_to_bool",
"clippy::transmute_int_to_char",
"clippy::transmute_int_to_float",
"clippy::transmute_int_to_non_zero",
"clippy::transmute_num_to_bytes",
"clippy::transmute_ptr_to_ref",
"clippy::transmutes_expressible_as_ptr_casts",
@@ -7168,13 +13361,18 @@ fn main() {
"clippy::unit_arg",
"clippy::unnecessary_cast",
"clippy::unnecessary_filter_map",
"clippy::unnecessary_find_map",
"clippy::unnecessary_literal_unwrap",
"clippy::unnecessary_map_on_constructor",
"clippy::unnecessary_operation",
"clippy::unnecessary_sort_by",
"clippy::unnecessary_unwrap",
"clippy::unneeded_wildcard_pattern",
"clippy::unused_format_specs",
"clippy::useless_asref",
"clippy::useless_conversion",
"clippy::useless_format",
"clippy::useless_transmute",
"clippy::vec_box",
"clippy::while_let_loop",
"clippy::wildcard_in_or_patterns",
@@ -7185,7 +13383,7 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::correctness",
description: r##"lint group for: clippy::absurd_extreme_comparisons, clippy::almost_swapped, clippy::approx_constant, clippy::async_yields_async, clippy::bad_bit_mask, clippy::cast_ref_to_mut, clippy::clone_double_ref, clippy::cmp_nan, clippy::deprecated_semver, clippy::derive_hash_xor_eq, clippy::derive_ord_xor_partial_ord, clippy::drop_copy, clippy::drop_ref, clippy::enum_clike_unportable_variant, clippy::eq_op, clippy::erasing_op, clippy::fn_address_comparisons, clippy::forget_copy, clippy::forget_ref, clippy::if_let_mutex, clippy::if_same_then_else, clippy::ifs_same_cond, clippy::ineffective_bit_mask, clippy::infinite_iter, clippy::inherent_to_string_shadow_display, clippy::inline_fn_without_body, clippy::invalid_null_ptr_usage, clippy::invalid_regex, clippy::invisible_characters, clippy::iter_next_loop, clippy::iterator_step_by_zero, clippy::let_underscore_lock, clippy::logic_bug, clippy::match_str_case_mismatch, clippy::mem_replace_with_uninit, clippy::min_max, clippy::mismatched_target_os, clippy::mistyped_literal_suffixes, clippy::modulo_one, clippy::mut_from_ref, clippy::never_loop, clippy::non_octal_unix_permissions, clippy::nonsensical_open_options, clippy::not_unsafe_ptr_arg_deref, clippy::option_env_unwrap, clippy::out_of_bounds_indexing, clippy::panicking_unwrap, clippy::possible_missing_comma, clippy::reversed_empty_ranges, clippy::self_assignment, clippy::serde_api_misuse, clippy::size_of_in_element_count, clippy::suspicious_splitn, clippy::to_string_in_display, clippy::transmuting_null, clippy::undropped_manually_drops, clippy::uninit_assumed_init, clippy::uninit_vec, clippy::unit_cmp, clippy::unit_hash, clippy::unit_return_expecting_ord, clippy::unsound_collection_transmute, clippy::unused_io_amount, clippy::useless_attribute, clippy::vec_resize_to_zero, clippy::vtable_address_comparisons, clippy::while_immutable_condition, clippy::wrong_transmute, clippy::zst_offset"##,
description: r##"lint group for: clippy::absurd_extreme_comparisons, clippy::almost_swapped, clippy::approx_constant, clippy::async_yields_async, clippy::bad_bit_mask, clippy::cast_slice_different_sizes, clippy::deprecated_semver, clippy::derive_ord_xor_partial_ord, clippy::derived_hash_with_manual_eq, clippy::enum_clike_unportable_variant, clippy::eq_op, clippy::erasing_op, clippy::fn_address_comparisons, clippy::if_let_mutex, clippy::if_same_then_else, clippy::ifs_same_cond, clippy::impossible_comparisons, clippy::ineffective_bit_mask, clippy::infinite_iter, clippy::inherent_to_string_shadow_display, clippy::inline_fn_without_body, clippy::invalid_null_ptr_usage, clippy::invalid_regex, clippy::invisible_characters, clippy::iter_next_loop, clippy::iter_skip_zero, clippy::iterator_step_by_zero, clippy::let_underscore_lock, clippy::match_str_case_mismatch, clippy::mem_replace_with_uninit, clippy::min_max, clippy::mismatched_target_os, clippy::mistyped_literal_suffixes, clippy::modulo_one, clippy::mut_from_ref, clippy::never_loop, clippy::non_octal_unix_permissions, clippy::nonsensical_open_options, clippy::not_unsafe_ptr_arg_deref, clippy::option_env_unwrap, clippy::out_of_bounds_indexing, clippy::overly_complex_bool_expr, clippy::panicking_unwrap, clippy::possible_missing_comma, clippy::read_line_without_trim, clippy::read_zero_byte_vec, clippy::recursive_format_impl, clippy::redundant_comparisons, clippy::redundant_locals, clippy::reversed_empty_ranges, clippy::self_assignment, clippy::serde_api_misuse, clippy::size_of_in_element_count, clippy::suspicious_splitn, clippy::transmute_null_to_fn, clippy::transmuting_null, clippy::uninit_assumed_init, clippy::uninit_vec, clippy::unit_cmp, clippy::unit_hash, clippy::unit_return_expecting_ord, clippy::unsound_collection_transmute, clippy::unused_io_amount, clippy::useless_attribute, clippy::vec_resize_to_zero, clippy::vtable_address_comparisons, clippy::while_immutable_condition, clippy::wrong_transmute, clippy::zst_offset"##,
},
children: &[
"clippy::absurd_extreme_comparisons",
@@ -7193,23 +13391,18 @@ fn main() {
"clippy::approx_constant",
"clippy::async_yields_async",
"clippy::bad_bit_mask",
"clippy::cast_ref_to_mut",
"clippy::clone_double_ref",
"clippy::cmp_nan",
"clippy::cast_slice_different_sizes",
"clippy::deprecated_semver",
"clippy::derive_hash_xor_eq",
"clippy::derive_ord_xor_partial_ord",
"clippy::drop_copy",
"clippy::drop_ref",
"clippy::derived_hash_with_manual_eq",
"clippy::enum_clike_unportable_variant",
"clippy::eq_op",
"clippy::erasing_op",
"clippy::fn_address_comparisons",
"clippy::forget_copy",
"clippy::forget_ref",
"clippy::if_let_mutex",
"clippy::if_same_then_else",
"clippy::ifs_same_cond",
"clippy::impossible_comparisons",
"clippy::ineffective_bit_mask",
"clippy::infinite_iter",
"clippy::inherent_to_string_shadow_display",
@@ -7218,9 +13411,9 @@ fn main() {
"clippy::invalid_regex",
"clippy::invisible_characters",
"clippy::iter_next_loop",
"clippy::iter_skip_zero",
"clippy::iterator_step_by_zero",
"clippy::let_underscore_lock",
"clippy::logic_bug",
"clippy::match_str_case_mismatch",
"clippy::mem_replace_with_uninit",
"clippy::min_max",
@@ -7234,16 +13427,21 @@ fn main() {
"clippy::not_unsafe_ptr_arg_deref",
"clippy::option_env_unwrap",
"clippy::out_of_bounds_indexing",
"clippy::overly_complex_bool_expr",
"clippy::panicking_unwrap",
"clippy::possible_missing_comma",
"clippy::read_line_without_trim",
"clippy::read_zero_byte_vec",
"clippy::recursive_format_impl",
"clippy::redundant_comparisons",
"clippy::redundant_locals",
"clippy::reversed_empty_ranges",
"clippy::self_assignment",
"clippy::serde_api_misuse",
"clippy::size_of_in_element_count",
"clippy::suspicious_splitn",
"clippy::to_string_in_display",
"clippy::transmute_null_to_fn",
"clippy::transmuting_null",
"clippy::undropped_manually_drops",
"clippy::uninit_assumed_init",
"clippy::uninit_vec",
"clippy::unit_cmp",
@@ -7286,45 +13484,66 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::nursery",
description: r##"lint group for: clippy::branches_sharing_code, clippy::cognitive_complexity, clippy::debug_assert_with_mut_call, clippy::disallowed_methods, clippy::disallowed_types, clippy::empty_line_after_outer_attr, clippy::equatable_if_let, clippy::fallible_impl_from, clippy::future_not_send, clippy::imprecise_flops, clippy::index_refutable_slice, clippy::missing_const_for_fn, clippy::mutex_integer, clippy::non_send_fields_in_send_ty, clippy::nonstandard_macro_braces, clippy::option_if_let_else, clippy::path_buf_push_overwrite, clippy::redundant_pub_crate, clippy::string_lit_as_bytes, clippy::suboptimal_flops, clippy::suspicious_operation_groupings, clippy::trailing_empty_array, clippy::trivial_regex, clippy::use_self, clippy::useless_let_if_seq, clippy::useless_transmute"##,
description: r##"lint group for: clippy::as_ptr_cast_mut, clippy::branches_sharing_code, clippy::clear_with_drain, clippy::cognitive_complexity, clippy::collection_is_never_read, clippy::debug_assert_with_mut_call, clippy::derive_partial_eq_without_eq, clippy::empty_line_after_doc_comments, clippy::empty_line_after_outer_attr, clippy::equatable_if_let, clippy::fallible_impl_from, clippy::future_not_send, clippy::implied_bounds_in_impls, clippy::imprecise_flops, clippy::iter_on_empty_collections, clippy::iter_on_single_items, clippy::iter_with_drain, clippy::large_stack_frames, clippy::manual_clamp, clippy::missing_const_for_fn, clippy::mutex_integer, clippy::needless_collect, clippy::needless_pass_by_ref_mut, clippy::non_send_fields_in_send_ty, clippy::nonstandard_macro_braces, clippy::option_if_let_else, clippy::or_fun_call, clippy::path_buf_push_overwrite, clippy::readonly_write_lock, clippy::redundant_clone, clippy::redundant_pub_crate, clippy::significant_drop_in_scrutinee, clippy::significant_drop_tightening, clippy::string_lit_as_bytes, clippy::suboptimal_flops, clippy::suspicious_operation_groupings, clippy::trailing_empty_array, clippy::trait_duplication_in_bounds, clippy::transmute_undefined_repr, clippy::trivial_regex, clippy::tuple_array_conversions, clippy::type_repetition_in_bounds, clippy::unnecessary_struct_initialization, clippy::unused_peekable, clippy::unused_rounding, clippy::use_self, clippy::useless_let_if_seq"##,
},
children: &[
"clippy::as_ptr_cast_mut",
"clippy::branches_sharing_code",
"clippy::clear_with_drain",
"clippy::cognitive_complexity",
"clippy::collection_is_never_read",
"clippy::debug_assert_with_mut_call",
"clippy::disallowed_methods",
"clippy::disallowed_types",
"clippy::derive_partial_eq_without_eq",
"clippy::empty_line_after_doc_comments",
"clippy::empty_line_after_outer_attr",
"clippy::equatable_if_let",
"clippy::fallible_impl_from",
"clippy::future_not_send",
"clippy::implied_bounds_in_impls",
"clippy::imprecise_flops",
"clippy::index_refutable_slice",
"clippy::iter_on_empty_collections",
"clippy::iter_on_single_items",
"clippy::iter_with_drain",
"clippy::large_stack_frames",
"clippy::manual_clamp",
"clippy::missing_const_for_fn",
"clippy::mutex_integer",
"clippy::needless_collect",
"clippy::needless_pass_by_ref_mut",
"clippy::non_send_fields_in_send_ty",
"clippy::nonstandard_macro_braces",
"clippy::option_if_let_else",
"clippy::or_fun_call",
"clippy::path_buf_push_overwrite",
"clippy::readonly_write_lock",
"clippy::redundant_clone",
"clippy::redundant_pub_crate",
"clippy::significant_drop_in_scrutinee",
"clippy::significant_drop_tightening",
"clippy::string_lit_as_bytes",
"clippy::suboptimal_flops",
"clippy::suspicious_operation_groupings",
"clippy::trailing_empty_array",
"clippy::trait_duplication_in_bounds",
"clippy::transmute_undefined_repr",
"clippy::trivial_regex",
"clippy::tuple_array_conversions",
"clippy::type_repetition_in_bounds",
"clippy::unnecessary_struct_initialization",
"clippy::unused_peekable",
"clippy::unused_rounding",
"clippy::use_self",
"clippy::useless_let_if_seq",
"clippy::useless_transmute",
],
},
LintGroup {
lint: Lint {
label: "clippy::pedantic",
description: r##"lint group for: clippy::await_holding_lock, clippy::await_holding_refcell_ref, clippy::case_sensitive_file_extension_comparisons, clippy::cast_lossless, clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_precision_loss, clippy::cast_ptr_alignment, clippy::cast_sign_loss, clippy::checked_conversions, clippy::cloned_instead_of_copied, clippy::copy_iterator, clippy::default_trait_access, clippy::doc_markdown, clippy::empty_enum, clippy::enum_glob_use, clippy::expl_impl_clone_on_copy, clippy::explicit_deref_methods, clippy::explicit_into_iter_loop, clippy::explicit_iter_loop, clippy::filter_map_next, clippy::flat_map_option, clippy::float_cmp, clippy::fn_params_excessive_bools, clippy::from_iter_instead_of_collect, clippy::if_not_else, clippy::implicit_clone, clippy::implicit_hasher, clippy::implicit_saturating_sub, clippy::inconsistent_struct_constructor, clippy::inefficient_to_string, clippy::inline_always, clippy::invalid_upcast_comparisons, clippy::items_after_statements, clippy::iter_not_returning_iterator, clippy::large_digit_groups, clippy::large_stack_arrays, clippy::large_types_passed_by_value, clippy::let_underscore_drop, clippy::let_unit_value, clippy::linkedlist, clippy::macro_use_imports, clippy::manual_assert, clippy::manual_ok_or, clippy::many_single_char_names, clippy::map_unwrap_or, clippy::match_bool, clippy::match_on_vec_items, clippy::match_same_arms, clippy::match_wild_err_arm, clippy::match_wildcard_for_single_variants, clippy::maybe_infinite_iter, clippy::missing_errors_doc, clippy::missing_panics_doc, clippy::module_name_repetitions, clippy::must_use_candidate, clippy::mut_mut, clippy::naive_bytecount, clippy::needless_bitwise_bool, clippy::needless_continue, clippy::needless_for_each, clippy::needless_pass_by_value, clippy::no_effect_underscore_binding, clippy::option_option, clippy::ptr_as_ptr, clippy::range_minus_one, clippy::range_plus_one, clippy::redundant_closure_for_method_calls, clippy::redundant_else, clippy::ref_binding_to_reference, clippy::ref_option_ref, clippy::same_functions_in_if_condition, clippy::semicolon_if_nothing_returned, clippy::similar_names, clippy::single_match_else, clippy::string_add_assign, clippy::struct_excessive_bools, clippy::too_many_lines, clippy::trait_duplication_in_bounds, clippy::transmute_ptr_to_ptr, clippy::trivially_copy_pass_by_ref, clippy::type_repetition_in_bounds, clippy::unicode_not_nfc, clippy::unnecessary_wraps, clippy::unnested_or_patterns, clippy::unreadable_literal, clippy::unsafe_derive_deserialize, clippy::unused_async, clippy::unused_self, clippy::used_underscore_binding, clippy::verbose_bit_mask, clippy::wildcard_imports, clippy::zero_sized_map_values"##,
description: r##"lint group for: clippy::bool_to_int_with_if, clippy::borrow_as_ptr, clippy::case_sensitive_file_extension_comparisons, clippy::cast_lossless, clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_precision_loss, clippy::cast_ptr_alignment, clippy::cast_sign_loss, clippy::checked_conversions, clippy::cloned_instead_of_copied, clippy::copy_iterator, clippy::default_trait_access, clippy::doc_link_with_quotes, clippy::doc_markdown, clippy::empty_enum, clippy::enum_glob_use, clippy::expl_impl_clone_on_copy, clippy::explicit_deref_methods, clippy::explicit_into_iter_loop, clippy::explicit_iter_loop, clippy::filter_map_next, clippy::flat_map_option, clippy::float_cmp, clippy::fn_params_excessive_bools, clippy::from_iter_instead_of_collect, clippy::if_not_else, clippy::ignored_unit_patterns, clippy::implicit_clone, clippy::implicit_hasher, clippy::inconsistent_struct_constructor, clippy::index_refutable_slice, clippy::inefficient_to_string, clippy::inline_always, clippy::into_iter_without_iter, clippy::invalid_upcast_comparisons, clippy::items_after_statements, clippy::iter_not_returning_iterator, clippy::iter_without_into_iter, clippy::large_digit_groups, clippy::large_futures, clippy::large_stack_arrays, clippy::large_types_passed_by_value, clippy::linkedlist, clippy::macro_use_imports, clippy::manual_assert, clippy::manual_instant_elapsed, clippy::manual_let_else, clippy::manual_ok_or, clippy::manual_string_new, clippy::many_single_char_names, clippy::map_unwrap_or, clippy::match_bool, clippy::match_on_vec_items, clippy::match_same_arms, clippy::match_wild_err_arm, clippy::match_wildcard_for_single_variants, clippy::maybe_infinite_iter, clippy::mismatching_type_param_order, clippy::missing_errors_doc, clippy::missing_fields_in_debug, clippy::missing_panics_doc, clippy::module_name_repetitions, clippy::must_use_candidate, clippy::mut_mut, clippy::naive_bytecount, clippy::needless_bitwise_bool, clippy::needless_continue, clippy::needless_for_each, clippy::needless_pass_by_value, clippy::needless_raw_string_hashes, clippy::no_effect_underscore_binding, clippy::no_mangle_with_rust_abi, clippy::option_option, clippy::ptr_as_ptr, clippy::ptr_cast_constness, clippy::range_minus_one, clippy::range_plus_one, clippy::redundant_closure_for_method_calls, clippy::redundant_else, clippy::ref_binding_to_reference, clippy::ref_option_ref, clippy::return_self_not_must_use, clippy::same_functions_in_if_condition, clippy::semicolon_if_nothing_returned, clippy::should_panic_without_expect, clippy::similar_names, clippy::single_match_else, clippy::stable_sort_primitive, clippy::string_add_assign, clippy::struct_excessive_bools, clippy::too_many_lines, clippy::transmute_ptr_to_ptr, clippy::trivially_copy_pass_by_ref, clippy::unchecked_duration_subtraction, clippy::unicode_not_nfc, clippy::uninlined_format_args, clippy::unnecessary_box_returns, clippy::unnecessary_join, clippy::unnecessary_wraps, clippy::unnested_or_patterns, clippy::unreadable_literal, clippy::unsafe_derive_deserialize, clippy::unused_async, clippy::unused_self, clippy::used_underscore_binding, clippy::verbose_bit_mask, clippy::wildcard_imports, clippy::zero_sized_map_values"##,
},
children: &[
"clippy::await_holding_lock",
"clippy::await_holding_refcell_ref",
"clippy::bool_to_int_with_if",
"clippy::borrow_as_ptr",
"clippy::case_sensitive_file_extension_comparisons",
"clippy::cast_lossless",
"clippy::cast_possible_truncation",
@@ -7336,6 +13555,7 @@ fn main() {
"clippy::cloned_instead_of_copied",
"clippy::copy_iterator",
"clippy::default_trait_access",
"clippy::doc_link_with_quotes",
"clippy::doc_markdown",
"clippy::empty_enum",
"clippy::enum_glob_use",
@@ -7349,24 +13569,29 @@ fn main() {
"clippy::fn_params_excessive_bools",
"clippy::from_iter_instead_of_collect",
"clippy::if_not_else",
"clippy::ignored_unit_patterns",
"clippy::implicit_clone",
"clippy::implicit_hasher",
"clippy::implicit_saturating_sub",
"clippy::inconsistent_struct_constructor",
"clippy::index_refutable_slice",
"clippy::inefficient_to_string",
"clippy::inline_always",
"clippy::into_iter_without_iter",
"clippy::invalid_upcast_comparisons",
"clippy::items_after_statements",
"clippy::iter_not_returning_iterator",
"clippy::iter_without_into_iter",
"clippy::large_digit_groups",
"clippy::large_futures",
"clippy::large_stack_arrays",
"clippy::large_types_passed_by_value",
"clippy::let_underscore_drop",
"clippy::let_unit_value",
"clippy::linkedlist",
"clippy::macro_use_imports",
"clippy::manual_assert",
"clippy::manual_instant_elapsed",
"clippy::manual_let_else",
"clippy::manual_ok_or",
"clippy::manual_string_new",
"clippy::many_single_char_names",
"clippy::map_unwrap_or",
"clippy::match_bool",
@@ -7375,7 +13600,9 @@ fn main() {
"clippy::match_wild_err_arm",
"clippy::match_wildcard_for_single_variants",
"clippy::maybe_infinite_iter",
"clippy::mismatching_type_param_order",
"clippy::missing_errors_doc",
"clippy::missing_fields_in_debug",
"clippy::missing_panics_doc",
"clippy::module_name_repetitions",
"clippy::must_use_candidate",
@@ -7385,27 +13612,35 @@ fn main() {
"clippy::needless_continue",
"clippy::needless_for_each",
"clippy::needless_pass_by_value",
"clippy::needless_raw_string_hashes",
"clippy::no_effect_underscore_binding",
"clippy::no_mangle_with_rust_abi",
"clippy::option_option",
"clippy::ptr_as_ptr",
"clippy::ptr_cast_constness",
"clippy::range_minus_one",
"clippy::range_plus_one",
"clippy::redundant_closure_for_method_calls",
"clippy::redundant_else",
"clippy::ref_binding_to_reference",
"clippy::ref_option_ref",
"clippy::return_self_not_must_use",
"clippy::same_functions_in_if_condition",
"clippy::semicolon_if_nothing_returned",
"clippy::should_panic_without_expect",
"clippy::similar_names",
"clippy::single_match_else",
"clippy::stable_sort_primitive",
"clippy::string_add_assign",
"clippy::struct_excessive_bools",
"clippy::too_many_lines",
"clippy::trait_duplication_in_bounds",
"clippy::transmute_ptr_to_ptr",
"clippy::trivially_copy_pass_by_ref",
"clippy::type_repetition_in_bounds",
"clippy::unchecked_duration_subtraction",
"clippy::unicode_not_nfc",
"clippy::uninlined_format_args",
"clippy::unnecessary_box_returns",
"clippy::unnecessary_join",
"clippy::unnecessary_wraps",
"clippy::unnested_or_patterns",
"clippy::unreadable_literal",
@@ -7421,29 +13656,33 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::perf",
description: r##"lint group for: clippy::box_collection, clippy::boxed_local, clippy::cmp_owned, clippy::expect_fun_call, clippy::extend_with_drain, clippy::format_in_format_args, clippy::iter_nth, clippy::large_const_arrays, clippy::large_enum_variant, clippy::manual_memcpy, clippy::manual_str_repeat, clippy::map_entry, clippy::mutex_atomic, clippy::needless_collect, clippy::or_fun_call, clippy::redundant_allocation, clippy::redundant_clone, clippy::single_char_pattern, clippy::slow_vector_initialization, clippy::stable_sort_primitive, clippy::to_string_in_format_args, clippy::unnecessary_to_owned, clippy::useless_vec, clippy::vec_init_then_push"##,
description: r##"lint group for: clippy::box_collection, clippy::box_default, clippy::boxed_local, clippy::cmp_owned, clippy::collapsible_str_replace, clippy::drain_collect, clippy::expect_fun_call, clippy::extend_with_drain, clippy::format_collect, clippy::format_in_format_args, clippy::iter_nth, clippy::iter_overeager_cloned, clippy::large_const_arrays, clippy::large_enum_variant, clippy::manual_memcpy, clippy::manual_retain, clippy::manual_str_repeat, clippy::manual_try_fold, clippy::map_entry, clippy::missing_spin_loop, clippy::redundant_allocation, clippy::result_large_err, clippy::single_char_pattern, clippy::slow_vector_initialization, clippy::to_string_in_format_args, clippy::unnecessary_to_owned, clippy::useless_vec, clippy::vec_init_then_push"##,
},
children: &[
"clippy::box_collection",
"clippy::box_default",
"clippy::boxed_local",
"clippy::cmp_owned",
"clippy::collapsible_str_replace",
"clippy::drain_collect",
"clippy::expect_fun_call",
"clippy::extend_with_drain",
"clippy::format_collect",
"clippy::format_in_format_args",
"clippy::iter_nth",
"clippy::iter_overeager_cloned",
"clippy::large_const_arrays",
"clippy::large_enum_variant",
"clippy::manual_memcpy",
"clippy::manual_retain",
"clippy::manual_str_repeat",
"clippy::manual_try_fold",
"clippy::map_entry",
"clippy::mutex_atomic",
"clippy::needless_collect",
"clippy::or_fun_call",
"clippy::missing_spin_loop",
"clippy::redundant_allocation",
"clippy::redundant_clone",
"clippy::result_large_err",
"clippy::single_char_pattern",
"clippy::slow_vector_initialization",
"clippy::stable_sort_primitive",
"clippy::to_string_in_format_args",
"clippy::unnecessary_to_owned",
"clippy::useless_vec",
@@ -7453,17 +13692,30 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::restriction",
description: r##"lint group for: clippy::as_conversions, clippy::clone_on_ref_ptr, clippy::create_dir, clippy::dbg_macro, clippy::decimal_literal_representation, clippy::default_numeric_fallback, clippy::disallowed_script_idents, clippy::else_if_without_else, clippy::exhaustive_enums, clippy::exhaustive_structs, clippy::exit, clippy::expect_used, clippy::filetype_is_file, clippy::float_arithmetic, clippy::float_cmp_const, clippy::fn_to_numeric_cast_any, clippy::get_unwrap, clippy::if_then_some_else_none, clippy::implicit_return, clippy::indexing_slicing, clippy::inline_asm_x86_att_syntax, clippy::inline_asm_x86_intel_syntax, clippy::integer_arithmetic, clippy::integer_division, clippy::let_underscore_must_use, clippy::lossy_float_literal, clippy::map_err_ignore, clippy::mem_forget, clippy::missing_docs_in_private_items, clippy::missing_enforced_import_renames, clippy::missing_inline_in_public_items, clippy::mod_module_files, clippy::modulo_arithmetic, clippy::multiple_inherent_impl, clippy::non_ascii_literal, clippy::panic, clippy::panic_in_result_fn, clippy::pattern_type_mismatch, clippy::print_stderr, clippy::print_stdout, clippy::rc_buffer, clippy::rc_mutex, clippy::rest_pat_in_fully_bound_structs, clippy::same_name_method, clippy::self_named_module_files, clippy::separated_literal_suffix, clippy::shadow_reuse, clippy::shadow_same, clippy::shadow_unrelated, clippy::str_to_string, clippy::string_add, clippy::string_slice, clippy::string_to_string, clippy::todo, clippy::undocumented_unsafe_blocks, clippy::unimplemented, clippy::unnecessary_self_imports, clippy::unneeded_field_pattern, clippy::unreachable, clippy::unseparated_literal_suffix, clippy::unwrap_in_result, clippy::unwrap_used, clippy::use_debug, clippy::verbose_file_reads, clippy::wildcard_enum_match_arm"##,
description: r##"lint group for: clippy::absolute_paths, clippy::alloc_instead_of_core, clippy::allow_attributes, clippy::allow_attributes_without_reason, clippy::arithmetic_side_effects, clippy::as_conversions, clippy::as_underscore, clippy::assertions_on_result_states, clippy::big_endian_bytes, clippy::clone_on_ref_ptr, clippy::create_dir, clippy::dbg_macro, clippy::decimal_literal_representation, clippy::default_numeric_fallback, clippy::default_union_representation, clippy::deref_by_slicing, clippy::disallowed_script_idents, clippy::else_if_without_else, clippy::empty_drop, clippy::empty_structs_with_brackets, clippy::error_impl_error, clippy::exhaustive_enums, clippy::exhaustive_structs, clippy::exit, clippy::expect_used, clippy::filetype_is_file, clippy::float_arithmetic, clippy::float_cmp_const, clippy::fn_to_numeric_cast_any, clippy::format_push_string, clippy::get_unwrap, clippy::host_endian_bytes, clippy::if_then_some_else_none, clippy::impl_trait_in_params, clippy::implicit_return, clippy::indexing_slicing, clippy::inline_asm_x86_att_syntax, clippy::inline_asm_x86_intel_syntax, clippy::integer_division, clippy::large_include_file, clippy::let_underscore_must_use, clippy::let_underscore_untyped, clippy::little_endian_bytes, clippy::lossy_float_literal, clippy::map_err_ignore, clippy::mem_forget, clippy::min_ident_chars, clippy::missing_assert_message, clippy::missing_asserts_for_indexing, clippy::missing_docs_in_private_items, clippy::missing_enforced_import_renames, clippy::missing_inline_in_public_items, clippy::missing_trait_methods, clippy::mixed_read_write_in_expression, clippy::mod_module_files, clippy::modulo_arithmetic, clippy::multiple_inherent_impl, clippy::multiple_unsafe_ops_per_block, clippy::mutex_atomic, clippy::needless_raw_strings, clippy::non_ascii_literal, clippy::panic, clippy::panic_in_result_fn, clippy::partial_pub_fields, clippy::pattern_type_mismatch, clippy::print_stderr, clippy::print_stdout, clippy::pub_use, clippy::pub_with_shorthand, clippy::pub_without_shorthand, clippy::question_mark_used, clippy::rc_buffer, clippy::rc_mutex, clippy::redundant_type_annotations, clippy::ref_patterns, clippy::rest_pat_in_fully_bound_structs, clippy::same_name_method, clippy::self_named_module_files, clippy::semicolon_inside_block, clippy::semicolon_outside_block, clippy::separated_literal_suffix, clippy::shadow_reuse, clippy::shadow_same, clippy::shadow_unrelated, clippy::single_call_fn, clippy::single_char_lifetime_names, clippy::std_instead_of_alloc, clippy::std_instead_of_core, clippy::str_to_string, clippy::string_add, clippy::string_lit_chars_any, clippy::string_slice, clippy::string_to_string, clippy::suspicious_xor_used_as_pow, clippy::tests_outside_test_module, clippy::todo, clippy::try_err, clippy::undocumented_unsafe_blocks, clippy::unimplemented, clippy::unnecessary_safety_comment, clippy::unnecessary_safety_doc, clippy::unnecessary_self_imports, clippy::unneeded_field_pattern, clippy::unreachable, clippy::unseparated_literal_suffix, clippy::unwrap_in_result, clippy::unwrap_used, clippy::use_debug, clippy::verbose_file_reads, clippy::wildcard_enum_match_arm"##,
},
children: &[
"clippy::absolute_paths",
"clippy::alloc_instead_of_core",
"clippy::allow_attributes",
"clippy::allow_attributes_without_reason",
"clippy::arithmetic_side_effects",
"clippy::as_conversions",
"clippy::as_underscore",
"clippy::assertions_on_result_states",
"clippy::big_endian_bytes",
"clippy::clone_on_ref_ptr",
"clippy::create_dir",
"clippy::dbg_macro",
"clippy::decimal_literal_representation",
"clippy::default_numeric_fallback",
"clippy::default_union_representation",
"clippy::deref_by_slicing",
"clippy::disallowed_script_idents",
"clippy::else_if_without_else",
"clippy::empty_drop",
"clippy::empty_structs_with_brackets",
"clippy::error_impl_error",
"clippy::exhaustive_enums",
"clippy::exhaustive_structs",
"clippy::exit",
@@ -7472,46 +13724,78 @@ fn main() {
"clippy::float_arithmetic",
"clippy::float_cmp_const",
"clippy::fn_to_numeric_cast_any",
"clippy::format_push_string",
"clippy::get_unwrap",
"clippy::host_endian_bytes",
"clippy::if_then_some_else_none",
"clippy::impl_trait_in_params",
"clippy::implicit_return",
"clippy::indexing_slicing",
"clippy::inline_asm_x86_att_syntax",
"clippy::inline_asm_x86_intel_syntax",
"clippy::integer_arithmetic",
"clippy::integer_division",
"clippy::large_include_file",
"clippy::let_underscore_must_use",
"clippy::let_underscore_untyped",
"clippy::little_endian_bytes",
"clippy::lossy_float_literal",
"clippy::map_err_ignore",
"clippy::mem_forget",
"clippy::min_ident_chars",
"clippy::missing_assert_message",
"clippy::missing_asserts_for_indexing",
"clippy::missing_docs_in_private_items",
"clippy::missing_enforced_import_renames",
"clippy::missing_inline_in_public_items",
"clippy::missing_trait_methods",
"clippy::mixed_read_write_in_expression",
"clippy::mod_module_files",
"clippy::modulo_arithmetic",
"clippy::multiple_inherent_impl",
"clippy::multiple_unsafe_ops_per_block",
"clippy::mutex_atomic",
"clippy::needless_raw_strings",
"clippy::non_ascii_literal",
"clippy::panic",
"clippy::panic_in_result_fn",
"clippy::partial_pub_fields",
"clippy::pattern_type_mismatch",
"clippy::print_stderr",
"clippy::print_stdout",
"clippy::pub_use",
"clippy::pub_with_shorthand",
"clippy::pub_without_shorthand",
"clippy::question_mark_used",
"clippy::rc_buffer",
"clippy::rc_mutex",
"clippy::redundant_type_annotations",
"clippy::ref_patterns",
"clippy::rest_pat_in_fully_bound_structs",
"clippy::same_name_method",
"clippy::self_named_module_files",
"clippy::semicolon_inside_block",
"clippy::semicolon_outside_block",
"clippy::separated_literal_suffix",
"clippy::shadow_reuse",
"clippy::shadow_same",
"clippy::shadow_unrelated",
"clippy::single_call_fn",
"clippy::single_char_lifetime_names",
"clippy::std_instead_of_alloc",
"clippy::std_instead_of_core",
"clippy::str_to_string",
"clippy::string_add",
"clippy::string_lit_chars_any",
"clippy::string_slice",
"clippy::string_to_string",
"clippy::suspicious_xor_used_as_pow",
"clippy::tests_outside_test_module",
"clippy::todo",
"clippy::try_err",
"clippy::undocumented_unsafe_blocks",
"clippy::unimplemented",
"clippy::unnecessary_safety_comment",
"clippy::unnecessary_safety_doc",
"clippy::unnecessary_self_imports",
"clippy::unneeded_field_pattern",
"clippy::unreachable",
@@ -7526,12 +13810,11 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::style",
description: r##"lint group for: clippy::assertions_on_constants, clippy::assign_op_pattern, clippy::blacklisted_name, clippy::blocks_in_if_conditions, clippy::bool_assert_comparison, clippy::borrow_interior_mutable_const, clippy::builtin_type_shadow, clippy::bytes_nth, clippy::chars_last_cmp, clippy::chars_next_cmp, clippy::cmp_null, clippy::collapsible_else_if, clippy::collapsible_if, clippy::collapsible_match, clippy::comparison_chain, clippy::comparison_to_empty, clippy::declare_interior_mutable_const, clippy::double_must_use, clippy::double_neg, clippy::duplicate_underscore_argument, clippy::enum_variant_names, clippy::excessive_precision, clippy::field_reassign_with_default, clippy::fn_to_numeric_cast, clippy::fn_to_numeric_cast_with_truncation, clippy::for_kv_map, clippy::from_over_into, clippy::from_str_radix_10, clippy::inconsistent_digit_grouping, clippy::infallible_destructuring_match, clippy::inherent_to_string, clippy::into_iter_on_ref, clippy::iter_cloned_collect, clippy::iter_next_slice, clippy::iter_nth_zero, clippy::iter_skip_next, clippy::just_underscores_and_digits, clippy::len_without_is_empty, clippy::len_zero, clippy::let_and_return, clippy::main_recursion, clippy::manual_async_fn, clippy::manual_map, clippy::manual_non_exhaustive, clippy::manual_range_contains, clippy::manual_saturating_arithmetic, clippy::map_clone, clippy::map_collect_result_unit, clippy::match_like_matches_macro, clippy::match_overlapping_arm, clippy::match_ref_pats, clippy::match_result_ok, clippy::mem_replace_option_with_none, clippy::mem_replace_with_default, clippy::missing_safety_doc, clippy::mixed_case_hex_literals, clippy::module_inception, clippy::must_use_unit, clippy::mut_mutex_lock, clippy::needless_borrow, clippy::needless_doctest_main, clippy::needless_late_init, clippy::needless_range_loop, clippy::needless_return, clippy::neg_multiply, clippy::new_ret_no_self, clippy::new_without_default, clippy::ok_expect, clippy::op_ref, clippy::option_map_or_none, clippy::print_literal, clippy::print_with_newline, clippy::println_empty_string, clippy::ptr_arg, clippy::ptr_eq, clippy::question_mark, clippy::redundant_closure, clippy::redundant_field_names, clippy::redundant_pattern, clippy::redundant_pattern_matching, clippy::redundant_static_lifetimes, clippy::result_map_or_into_option, clippy::result_unit_err, clippy::same_item_push, clippy::self_named_constructors, clippy::should_implement_trait, clippy::single_char_add_str, clippy::single_component_path_imports, clippy::single_match, clippy::string_extend_chars, clippy::tabs_in_doc_comments, clippy::to_digit_is_some, clippy::toplevel_ref_arg, clippy::try_err, clippy::unnecessary_fold, clippy::unnecessary_lazy_evaluations, clippy::unnecessary_mut_passed, clippy::unsafe_removed_from_name, clippy::unused_unit, clippy::unusual_byte_groupings, clippy::unwrap_or_else_default, clippy::upper_case_acronyms, clippy::while_let_on_iterator, clippy::write_literal, clippy::write_with_newline, clippy::writeln_empty_string, clippy::wrong_self_convention, clippy::zero_ptr"##,
description: r##"lint group for: clippy::assertions_on_constants, clippy::assign_op_pattern, clippy::blocks_in_if_conditions, clippy::bool_assert_comparison, clippy::borrow_interior_mutable_const, clippy::builtin_type_shadow, clippy::bytes_nth, clippy::chars_last_cmp, clippy::chars_next_cmp, clippy::cmp_null, clippy::collapsible_else_if, clippy::collapsible_if, clippy::collapsible_match, clippy::comparison_chain, clippy::comparison_to_empty, clippy::declare_interior_mutable_const, clippy::default_instead_of_iter_empty, clippy::disallowed_macros, clippy::disallowed_methods, clippy::disallowed_names, clippy::disallowed_types, clippy::double_must_use, clippy::double_neg, clippy::duplicate_underscore_argument, clippy::enum_variant_names, clippy::err_expect, clippy::excessive_precision, clippy::field_reassign_with_default, clippy::filter_map_bool_then, clippy::fn_to_numeric_cast, clippy::fn_to_numeric_cast_with_truncation, clippy::for_kv_map, clippy::from_over_into, clippy::from_str_radix_10, clippy::get_first, clippy::implicit_saturating_add, clippy::implicit_saturating_sub, clippy::inconsistent_digit_grouping, clippy::infallible_destructuring_match, clippy::inherent_to_string, clippy::init_numbered_fields, clippy::into_iter_on_ref, clippy::is_digit_ascii_radix, clippy::items_after_test_module, clippy::iter_cloned_collect, clippy::iter_next_slice, clippy::iter_nth_zero, clippy::iter_skip_next, clippy::just_underscores_and_digits, clippy::len_without_is_empty, clippy::len_zero, clippy::let_and_return, clippy::let_unit_value, clippy::main_recursion, clippy::manual_async_fn, clippy::manual_bits, clippy::manual_is_ascii_check, clippy::manual_is_finite, clippy::manual_is_infinite, clippy::manual_map, clippy::manual_next_back, clippy::manual_non_exhaustive, clippy::manual_range_contains, clippy::manual_saturating_arithmetic, clippy::manual_while_let_some, clippy::map_clone, clippy::map_collect_result_unit, clippy::match_like_matches_macro, clippy::match_overlapping_arm, clippy::match_ref_pats, clippy::match_result_ok, clippy::mem_replace_option_with_none, clippy::mem_replace_with_default, clippy::missing_safety_doc, clippy::mixed_case_hex_literals, clippy::module_inception, clippy::must_use_unit, clippy::mut_mutex_lock, clippy::needless_borrow, clippy::needless_borrows_for_generic_args, clippy::needless_doctest_main, clippy::needless_else, clippy::needless_late_init, clippy::needless_parens_on_range_literals, clippy::needless_pub_self, clippy::needless_range_loop, clippy::needless_return, clippy::needless_return_with_question_mark, clippy::neg_multiply, clippy::new_ret_no_self, clippy::new_without_default, clippy::non_minimal_cfg, clippy::obfuscated_if_else, clippy::ok_expect, clippy::op_ref, clippy::option_map_or_none, clippy::partialeq_to_none, clippy::print_literal, clippy::print_with_newline, clippy::println_empty_string, clippy::ptr_arg, clippy::ptr_eq, clippy::question_mark, clippy::redundant_closure, clippy::redundant_field_names, clippy::redundant_pattern, clippy::redundant_pattern_matching, clippy::redundant_static_lifetimes, clippy::result_map_or_into_option, clippy::result_unit_err, clippy::same_item_push, clippy::self_named_constructors, clippy::should_implement_trait, clippy::single_char_add_str, clippy::single_component_path_imports, clippy::single_match, clippy::string_extend_chars, clippy::tabs_in_doc_comments, clippy::to_digit_is_some, clippy::toplevel_ref_arg, clippy::trim_split_whitespace, clippy::unnecessary_fold, clippy::unnecessary_lazy_evaluations, clippy::unnecessary_mut_passed, clippy::unnecessary_owned_empty_strings, clippy::unsafe_removed_from_name, clippy::unused_unit, clippy::unusual_byte_groupings, clippy::unwrap_or_default, clippy::upper_case_acronyms, clippy::while_let_on_iterator, clippy::write_literal, clippy::write_with_newline, clippy::writeln_empty_string, clippy::wrong_self_convention, clippy::zero_ptr"##,
},
children: &[
"clippy::assertions_on_constants",
"clippy::assign_op_pattern",
"clippy::blacklisted_name",
"clippy::blocks_in_if_conditions",
"clippy::bool_assert_comparison",
"clippy::borrow_interior_mutable_const",
@@ -7546,21 +13829,34 @@ fn main() {
"clippy::comparison_chain",
"clippy::comparison_to_empty",
"clippy::declare_interior_mutable_const",
"clippy::default_instead_of_iter_empty",
"clippy::disallowed_macros",
"clippy::disallowed_methods",
"clippy::disallowed_names",
"clippy::disallowed_types",
"clippy::double_must_use",
"clippy::double_neg",
"clippy::duplicate_underscore_argument",
"clippy::enum_variant_names",
"clippy::err_expect",
"clippy::excessive_precision",
"clippy::field_reassign_with_default",
"clippy::filter_map_bool_then",
"clippy::fn_to_numeric_cast",
"clippy::fn_to_numeric_cast_with_truncation",
"clippy::for_kv_map",
"clippy::from_over_into",
"clippy::from_str_radix_10",
"clippy::get_first",
"clippy::implicit_saturating_add",
"clippy::implicit_saturating_sub",
"clippy::inconsistent_digit_grouping",
"clippy::infallible_destructuring_match",
"clippy::inherent_to_string",
"clippy::init_numbered_fields",
"clippy::into_iter_on_ref",
"clippy::is_digit_ascii_radix",
"clippy::items_after_test_module",
"clippy::iter_cloned_collect",
"clippy::iter_next_slice",
"clippy::iter_nth_zero",
@@ -7569,12 +13865,19 @@ fn main() {
"clippy::len_without_is_empty",
"clippy::len_zero",
"clippy::let_and_return",
"clippy::let_unit_value",
"clippy::main_recursion",
"clippy::manual_async_fn",
"clippy::manual_bits",
"clippy::manual_is_ascii_check",
"clippy::manual_is_finite",
"clippy::manual_is_infinite",
"clippy::manual_map",
"clippy::manual_next_back",
"clippy::manual_non_exhaustive",
"clippy::manual_range_contains",
"clippy::manual_saturating_arithmetic",
"clippy::manual_while_let_some",
"clippy::map_clone",
"clippy::map_collect_result_unit",
"clippy::match_like_matches_macro",
@@ -7589,16 +13892,24 @@ fn main() {
"clippy::must_use_unit",
"clippy::mut_mutex_lock",
"clippy::needless_borrow",
"clippy::needless_borrows_for_generic_args",
"clippy::needless_doctest_main",
"clippy::needless_else",
"clippy::needless_late_init",
"clippy::needless_parens_on_range_literals",
"clippy::needless_pub_self",
"clippy::needless_range_loop",
"clippy::needless_return",
"clippy::needless_return_with_question_mark",
"clippy::neg_multiply",
"clippy::new_ret_no_self",
"clippy::new_without_default",
"clippy::non_minimal_cfg",
"clippy::obfuscated_if_else",
"clippy::ok_expect",
"clippy::op_ref",
"clippy::option_map_or_none",
"clippy::partialeq_to_none",
"clippy::print_literal",
"clippy::print_with_newline",
"clippy::println_empty_string",
@@ -7622,14 +13933,15 @@ fn main() {
"clippy::tabs_in_doc_comments",
"clippy::to_digit_is_some",
"clippy::toplevel_ref_arg",
"clippy::try_err",
"clippy::trim_split_whitespace",
"clippy::unnecessary_fold",
"clippy::unnecessary_lazy_evaluations",
"clippy::unnecessary_mut_passed",
"clippy::unnecessary_owned_empty_strings",
"clippy::unsafe_removed_from_name",
"clippy::unused_unit",
"clippy::unusual_byte_groupings",
"clippy::unwrap_or_else_default",
"clippy::unwrap_or_default",
"clippy::upper_case_acronyms",
"clippy::while_let_on_iterator",
"clippy::write_literal",
@@ -7642,25 +13954,58 @@ fn main() {
LintGroup {
lint: Lint {
label: "clippy::suspicious",
description: r##"lint group for: clippy::blanket_clippy_restriction_lints, clippy::empty_loop, clippy::eval_order_dependence, clippy::float_equality_without_abs, clippy::for_loops_over_fallibles, clippy::misrefactored_assign_op, clippy::mut_range_bound, clippy::mutable_key_type, clippy::octal_escapes, clippy::return_self_not_must_use, clippy::suspicious_arithmetic_impl, clippy::suspicious_assignment_formatting, clippy::suspicious_else_formatting, clippy::suspicious_map, clippy::suspicious_op_assign_impl, clippy::suspicious_unary_op_formatting"##,
description: r##"lint group for: clippy::almost_complete_range, clippy::arc_with_non_send_sync, clippy::await_holding_invalid_type, clippy::await_holding_lock, clippy::await_holding_refcell_ref, clippy::blanket_clippy_restriction_lints, clippy::cast_abs_to_unsigned, clippy::cast_enum_constructor, clippy::cast_enum_truncation, clippy::cast_nan_to_int, clippy::cast_slice_from_raw_parts, clippy::crate_in_macro_def, clippy::drop_non_drop, clippy::duplicate_mod, clippy::empty_loop, clippy::float_equality_without_abs, clippy::forget_non_drop, clippy::four_forward_slashes, clippy::from_raw_with_void_ptr, clippy::iter_out_of_bounds, clippy::let_underscore_future, clippy::lines_filter_map_ok, clippy::maybe_misused_cfg, clippy::misnamed_getters, clippy::misrefactored_assign_op, clippy::multi_assignments, clippy::mut_range_bound, clippy::mutable_key_type, clippy::no_effect_replace, clippy::non_canonical_clone_impl, clippy::non_canonical_partial_ord_impl, clippy::octal_escapes, clippy::path_ends_with_ext, clippy::permissions_set_readonly_false, clippy::print_in_format_impl, clippy::rc_clone_in_vec_init, clippy::single_range_in_vec_init, clippy::size_of_ref, clippy::suspicious_arithmetic_impl, clippy::suspicious_assignment_formatting, clippy::suspicious_command_arg_space, clippy::suspicious_doc_comments, clippy::suspicious_else_formatting, clippy::suspicious_map, clippy::suspicious_op_assign_impl, clippy::suspicious_to_owned, clippy::suspicious_unary_op_formatting, clippy::swap_ptr_to_ref, clippy::type_id_on_box"##,
},
children: &[
"clippy::almost_complete_range",
"clippy::arc_with_non_send_sync",
"clippy::await_holding_invalid_type",
"clippy::await_holding_lock",
"clippy::await_holding_refcell_ref",
"clippy::blanket_clippy_restriction_lints",
"clippy::cast_abs_to_unsigned",
"clippy::cast_enum_constructor",
"clippy::cast_enum_truncation",
"clippy::cast_nan_to_int",
"clippy::cast_slice_from_raw_parts",
"clippy::crate_in_macro_def",
"clippy::drop_non_drop",
"clippy::duplicate_mod",
"clippy::empty_loop",
"clippy::eval_order_dependence",
"clippy::float_equality_without_abs",
"clippy::for_loops_over_fallibles",
"clippy::forget_non_drop",
"clippy::four_forward_slashes",
"clippy::from_raw_with_void_ptr",
"clippy::iter_out_of_bounds",
"clippy::let_underscore_future",
"clippy::lines_filter_map_ok",
"clippy::maybe_misused_cfg",
"clippy::misnamed_getters",
"clippy::misrefactored_assign_op",
"clippy::multi_assignments",
"clippy::mut_range_bound",
"clippy::mutable_key_type",
"clippy::no_effect_replace",
"clippy::non_canonical_clone_impl",
"clippy::non_canonical_partial_ord_impl",
"clippy::octal_escapes",
"clippy::return_self_not_must_use",
"clippy::path_ends_with_ext",
"clippy::permissions_set_readonly_false",
"clippy::print_in_format_impl",
"clippy::rc_clone_in_vec_init",
"clippy::single_range_in_vec_init",
"clippy::size_of_ref",
"clippy::suspicious_arithmetic_impl",
"clippy::suspicious_assignment_formatting",
"clippy::suspicious_command_arg_space",
"clippy::suspicious_doc_comments",
"clippy::suspicious_else_formatting",
"clippy::suspicious_map",
"clippy::suspicious_op_assign_impl",
"clippy::suspicious_to_owned",
"clippy::suspicious_unary_op_formatting",
"clippy::swap_ptr_to_ref",
"clippy::type_id_on_box",
],
},
];
src/tools/rust-analyzer/crates/ide-db/src/imports/import_assets.rs
+36 -11
View File
@@ -68,22 +68,29 @@ pub struct FirstSegmentUnresolved {
pub enum NameToImport {
/// Requires items with names that exactly match the given string, bool indicates case-sensitivity.
Exact(String, bool),
/// Requires items with names that case-insensitively contain all letters from the string,
/// Requires items with names that match the given string by prefix, bool indicates case-sensitivity.
Prefix(String, bool),
/// Requires items with names contain all letters from the string,
/// in the same order, but not necessary adjacent.
Fuzzy(String),
Fuzzy(String, bool),
}
impl NameToImport {
pub fn exact_case_sensitive(s: String) -> NameToImport {
NameToImport::Exact(s, true)
}
}
impl NameToImport {
pub fn fuzzy(s: String) -> NameToImport {
// unless all chars are lowercase, we do a case sensitive search
let case_sensitive = s.chars().any(|c| c.is_uppercase());
NameToImport::Fuzzy(s, case_sensitive)
}
pub fn text(&self) -> &str {
match self {
NameToImport::Exact(text, _) => text.as_str(),
NameToImport::Fuzzy(text) => text.as_str(),
NameToImport::Prefix(text, _)
| NameToImport::Exact(text, _)
| NameToImport::Fuzzy(text, _) => text.as_str(),
}
}
}
@@ -165,7 +172,7 @@ pub fn for_fuzzy_method_call(
Some(Self {
import_candidate: ImportCandidate::TraitMethod(TraitImportCandidate {
receiver_ty,
assoc_item_name: NameToImport::Fuzzy(fuzzy_method_name),
assoc_item_name: NameToImport::fuzzy(fuzzy_method_name),
}),
module_with_candidate: module_with_method_call,
candidate_node,
@@ -228,12 +235,30 @@ pub fn search_for_relative_paths(
self.search_for(sema, None, prefer_no_std)
}
pub fn path_fuzzy_name_to_exact(&mut self, case_sensitive: bool) {
/// Requires imports to by prefix instead of fuzzily.
pub fn path_fuzzy_name_to_prefix(&mut self) {
if let ImportCandidate::Path(PathImportCandidate { name: to_import, .. }) =
&mut self.import_candidate
{
let name = match to_import {
NameToImport::Fuzzy(name) => std::mem::take(name),
let (name, case_sensitive) = match to_import {
NameToImport::Fuzzy(name, case_sensitive) => {
(std::mem::take(name), *case_sensitive)
}
_ => return,
};
*to_import = NameToImport::Prefix(name, case_sensitive);
}
}
/// Requires imports to match exactly instead of fuzzily.
pub fn path_fuzzy_name_to_exact(&mut self) {
if let ImportCandidate::Path(PathImportCandidate { name: to_import, .. }) =
&mut self.import_candidate
{
let (name, case_sensitive) = match to_import {
NameToImport::Fuzzy(name, case_sensitive) => {
(std::mem::take(name), *case_sensitive)
}
_ => return,
};
*to_import = NameToImport::Exact(name, case_sensitive);
@@ -623,7 +648,7 @@ fn for_fuzzy_path(
fuzzy_name: String,
sema: &Semantics<'_, RootDatabase>,
) -> Option<Self> {
path_import_candidate(sema, qualifier, NameToImport::Fuzzy(fuzzy_name))
path_import_candidate(sema, qualifier, NameToImport::fuzzy(fuzzy_name))
}
}
src/tools/rust-analyzer/crates/ide-db/src/imports/insert_use.rs
+26 -2
View File
@@ -9,7 +9,7 @@
algo,
ast::{
self, edit_in_place::Removable, make, AstNode, HasAttrs, HasModuleItem, HasVisibility,
PathSegmentKind,
PathSegmentKind, UseTree,
},
ted, Direction, NodeOrToken, SyntaxKind, SyntaxNode,
};
@@ -157,6 +157,29 @@ pub fn clone_for_update(&self) -> Self {
/// Insert an import path into the given file/node. A `merge` value of none indicates that no import merging is allowed to occur.
pub fn insert_use(scope: &ImportScope, path: ast::Path, cfg: &InsertUseConfig) {
insert_use_with_alias_option(scope, path, cfg, None);
}
pub fn insert_use_as_alias(scope: &ImportScope, path: ast::Path, cfg: &InsertUseConfig) {
let text: &str = "use foo as _";
let parse = syntax::SourceFile::parse(text);
let node = parse
.tree()
.syntax()
.descendants()
.find_map(UseTree::cast)
.expect("Failed to make ast node `Rename`");
let alias = node.rename();
insert_use_with_alias_option(scope, path, cfg, alias);
}
fn insert_use_with_alias_option(
scope: &ImportScope,
path: ast::Path,
cfg: &InsertUseConfig,
alias: Option<ast::Rename>,
) {
let _p = profile::span("insert_use");
let mut mb = match cfg.granularity {
ImportGranularity::Crate => Some(MergeBehavior::Crate),
@@ -176,7 +199,8 @@ pub fn insert_use(scope: &ImportScope, path: ast::Path, cfg: &InsertUseConfig) {
}
let use_item =
make::use_(None, make::use_tree(path.clone(), None, None, false)).clone_for_update();
make::use_(None, make::use_tree(path.clone(), None, alias, false)).clone_for_update();
// merge into existing imports if possible
if let Some(mb) = mb {
let filter = |it: &_| !(cfg.skip_glob_imports && ast::Use::is_simple_glob(it));
src/tools/rust-analyzer/crates/ide-db/src/imports/insert_use/tests.rs
+40
View File
@@ -993,6 +993,46 @@ fn guess_grouping_matters() {
);
}
#[test]
fn insert_with_renamed_import_simple_use() {
check_with_config(
"use self::foo::Foo",
r#"
use self::foo::Foo as _;
"#,
r#"
use self::foo::Foo;
"#,
&InsertUseConfig {
granularity: ImportGranularity::Crate,
prefix_kind: hir::PrefixKind::BySelf,
enforce_granularity: true,
group: true,
skip_glob_imports: true,
},
);
}
#[test]
fn insert_with_renamed_import_complex_use() {
check_with_config(
"use self::foo::Foo;",
r#"
use self::foo::{self, Foo as _, Bar};
"#,
r#"
use self::foo::{self, Foo, Bar};
"#,
&InsertUseConfig {
granularity: ImportGranularity::Crate,
prefix_kind: hir::PrefixKind::BySelf,
enforce_granularity: true,
group: true,
skip_glob_imports: true,
},
);
}
fn check_with_config(
path: &str,
ra_fixture_before: &str,
src/tools/rust-analyzer/crates/ide-db/src/imports/merge_imports.rs
+11
View File
@@ -78,6 +78,10 @@ fn try_merge_trees_mut(lhs: &ast::UseTree, rhs: &ast::UseTree, merge: MergeBehav
{
lhs.split_prefix(&lhs_prefix);
rhs.split_prefix(&rhs_prefix);
} else {
ted::replace(lhs.syntax(), rhs.syntax());
// we can safely return here, in this case `recursive_merge` doesn't do anything
return Some(());
}
recursive_merge(lhs, rhs, merge)
}
@@ -123,6 +127,13 @@ fn recursive_merge(lhs: &ast::UseTree, rhs: &ast::UseTree, merge: MergeBehavior)
// so they need to be handled explicitly
.or_else(|| tree.star_token().map(|_| false))
};
if lhs_t.rename().and_then(|x| x.underscore_token()).is_some() {
ted::replace(lhs_t.syntax(), rhs_t.syntax());
*lhs_t = rhs_t;
continue;
}
match (tree_contains_self(lhs_t), tree_contains_self(&rhs_t)) {
(Some(true), None) => continue,
(None, Some(true)) => {
src/tools/rust-analyzer/crates/ide-db/src/items_locator.rs
+19 -11
View File
@@ -31,26 +31,34 @@ pub fn items_with_name<'a>(
)
});
let prefix = matches!(name, NameToImport::Prefix(..));
let (mut local_query, mut external_query) = match name {
NameToImport::Exact(exact_name, case_sensitive) => {
NameToImport::Prefix(exact_name, case_sensitive)
| NameToImport::Exact(exact_name, case_sensitive) => {
let mut local_query = symbol_index::Query::new(exact_name.clone());
local_query.exact();
let external_query = import_map::Query::new(exact_name);
(
local_query,
if case_sensitive { external_query.case_sensitive() } else { external_query },
)
let mut external_query = import_map::Query::new(exact_name);
if prefix {
local_query.prefix();
external_query = external_query.prefix();
} else {
local_query.exact();
external_query = external_query.exact();
}
if case_sensitive {
local_query.case_sensitive();
external_query = external_query.case_sensitive();
}
(local_query, external_query)
}
NameToImport::Fuzzy(fuzzy_search_string) => {
NameToImport::Fuzzy(fuzzy_search_string, case_sensitive) => {
let mut local_query = symbol_index::Query::new(fuzzy_search_string.clone());
local_query.fuzzy();
let mut external_query = import_map::Query::new(fuzzy_search_string.clone())
.fuzzy()
.assoc_search_mode(assoc_item_search);
if fuzzy_search_string.to_lowercase() != fuzzy_search_string {
if case_sensitive {
local_query.case_sensitive();
external_query = external_query.case_sensitive();
}
src/tools/rust-analyzer/crates/ide-db/src/symbol_index.rs
+34 -9
View File
@@ -43,13 +43,20 @@
use crate::RootDatabase;
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
enum SearchMode {
Fuzzy,
Exact,
Prefix,
}
#[derive(Debug)]
pub struct Query {
query: String,
lowercased: String,
only_types: bool,
libs: bool,
exact: bool,
mode: SearchMode,
case_sensitive: bool,
limit: usize,
}
@@ -62,7 +69,7 @@ pub fn new(query: String) -> Query {
lowercased,
only_types: false,
libs: false,
exact: false,
mode: SearchMode::Fuzzy,
case_sensitive: false,
limit: usize::max_value(),
}
@@ -76,8 +83,16 @@ pub fn libs(&mut self) {
self.libs = true;
}
pub fn fuzzy(&mut self) {
self.mode = SearchMode::Fuzzy;
}
pub fn exact(&mut self) {
self.exact = true;
self.mode = SearchMode::Exact;
}
pub fn prefix(&mut self) {
self.mode = SearchMode::Prefix;
}
pub fn case_sensitive(&mut self) {
@@ -329,13 +344,23 @@ pub(crate) fn search(self, indices: &[Arc<SymbolIndex>]) -> Vec<FileSymbol> {
{
continue;
}
if self.exact {
if symbol.name != self.query {
continue;
let skip = match self.mode {
SearchMode::Fuzzy => {
self.case_sensitive
&& self.query.chars().any(|c| !symbol.name.contains(c))
}
} else if self.case_sensitive
&& self.query.chars().any(|c| !symbol.name.contains(c))
{
SearchMode::Exact => symbol.name != self.query,
SearchMode::Prefix if self.case_sensitive => {
!symbol.name.starts_with(&self.query)
}
SearchMode::Prefix => symbol
.name
.chars()
.zip(self.lowercased.chars())
.all(|(n, q)| n.to_lowercase().next() == Some(q)),
};
if skip {
continue;
}
src/tools/rust-analyzer/crates/ide-db/src/tests/sourcegen_lints.rs
+115 -58
View File
@@ -1,4 +1,5 @@
//! Generates descriptors structure for unstable feature from Unstable Book
//! Generates descriptor structures for unstable features from the unstable book
//! and lints from rustc, rustdoc, and clippy.
use std::{borrow::Cow, fs, path::Path};
use itertools::Itertools;
@@ -6,6 +7,8 @@
use test_utils::project_root;
use xshell::{cmd, Shell};
const DESTINATION: &str = "crates/ide-db/src/generated/lints.rs";
/// This clones rustc repo, and so is not worth to keep up-to-date. We update
/// manually by un-ignoring the test from time to time.
#[test]
@@ -14,11 +17,21 @@ fn sourcegen_lint_completions() {
let sh = &Shell::new().unwrap();
let rust_repo = project_root().join("./target/rust");
if !rust_repo.exists() {
if rust_repo.exists() {
cmd!(sh, "git -C {rust_repo} pull --rebase").run().unwrap();
} else {
cmd!(sh, "git clone --depth=1 https://github.com/rust-lang/rust {rust_repo}")
.run()
.unwrap();
}
// need submodules for Cargo to parse the workspace correctly
cmd!(
sh,
"git -C {rust_repo} submodule update --init --recursive --depth=1 --
compiler library src/tools"
)
.run()
.unwrap();
let mut contents = String::from(
r"
@@ -27,17 +40,28 @@ pub struct Lint {
pub label: &'static str,
pub description: &'static str,
}
pub struct LintGroup {
pub lint: Lint,
pub children: &'static [&'static str],
}
",
);
generate_lint_descriptor(sh, &mut contents);
contents.push('\n');
generate_feature_descriptor(&mut contents, &rust_repo.join("src/doc/unstable-book/src"));
let cargo = std::env::var("CARGO").unwrap_or_else(|_| "cargo".to_string());
let unstable_book = project_root().join("./target/unstable-book-gen");
cmd!(
sh,
"{cargo} run --manifest-path {rust_repo}/src/tools/unstable-book-gen/Cargo.toml --
{rust_repo}/library {rust_repo}/compiler {rust_repo}/src {unstable_book}"
)
.run()
.unwrap();
generate_feature_descriptor(&mut contents, &unstable_book.join("src"));
contents.push('\n');
let lints_json = project_root().join("./target/clippy_lints.json");
@@ -51,41 +75,60 @@ pub struct LintGroup {
let contents = sourcegen::add_preamble("sourcegen_lints", sourcegen::reformat(contents));
let destination = project_root().join("crates/ide_db/src/generated/lints.rs");
let destination = project_root().join(DESTINATION);
sourcegen::ensure_file_contents(destination.as_path(), &contents);
}
/// Parses the output of `rustdoc -Whelp` and prints `Lint` and `LintGroup` constants into `buf`.
///
/// As of writing, the output of `rustc -Whelp` (not rustdoc) has the following format:
///
/// ```text
/// Lint checks provided by rustc:
///
/// name default meaning
/// ---- ------- -------
///
/// ...
///
/// Lint groups provided by rustc:
///
/// name sub-lints
/// ---- ---------
///
/// ...
/// ```
///
/// `rustdoc -Whelp` (and any other custom `rustc` driver) adds another two
/// tables after the `rustc` ones, with a different title but the same format.
fn generate_lint_descriptor(sh: &Shell, buf: &mut String) {
// FIXME: rustdoc currently requires an input file for -Whelp cc https://github.com/rust-lang/rust/pull/88831
let file = project_root().join(file!());
let stdout = cmd!(sh, "rustdoc -W help {file}").read().unwrap();
let start_lints = stdout.find("---- ------- -------").unwrap();
let start_lint_groups = stdout.find("---- ---------").unwrap();
let start_lints_rustdoc =
stdout.find("Lint checks provided by plugins loaded by this crate:").unwrap();
let start_lint_groups_rustdoc =
stdout.find("Lint groups provided by plugins loaded by this crate:").unwrap();
let stdout = cmd!(sh, "rustdoc -Whelp").read().unwrap();
let lints_pat = "---- ------- -------\n";
let lint_groups_pat = "---- ---------\n";
let lints = find_and_slice(&stdout, lints_pat);
let lint_groups = find_and_slice(lints, lint_groups_pat);
let lints_rustdoc = find_and_slice(lint_groups, lints_pat);
let lint_groups_rustdoc = find_and_slice(lints_rustdoc, lint_groups_pat);
buf.push_str(r#"pub const DEFAULT_LINTS: &[Lint] = &["#);
buf.push('\n');
let lints = stdout[start_lints..].lines().skip(1).take_while(|l| !l.is_empty()).map(|line| {
let lints = lints.lines().take_while(|l| !l.is_empty()).map(|line| {
let (name, rest) = line.trim().split_once(char::is_whitespace).unwrap();
let (_default_level, description) = rest.trim().split_once(char::is_whitespace).unwrap();
(name.trim(), Cow::Borrowed(description.trim()), vec![])
});
let lint_groups =
stdout[start_lint_groups..].lines().skip(1).take_while(|l| !l.is_empty()).map(|line| {
let (name, lints) = line.trim().split_once(char::is_whitespace).unwrap();
(
name.trim(),
format!("lint group for: {}", lints.trim()).into(),
lints
.split_ascii_whitespace()
.map(|s| s.trim().trim_matches(',').replace('-', "_"))
.collect(),
)
});
let lint_groups = lint_groups.lines().take_while(|l| !l.is_empty()).map(|line| {
let (name, lints) = line.trim().split_once(char::is_whitespace).unwrap();
(
name.trim(),
format!("lint group for: {}", lints.trim()).into(),
lints
.split_ascii_whitespace()
.map(|s| s.trim().trim_matches(',').replace('-', "_"))
.collect(),
)
});
let lints = lints
.chain(lint_groups)
@@ -94,7 +137,8 @@ fn generate_lint_descriptor(sh: &Shell, buf: &mut String) {
for (name, description, ..) in &lints {
push_lint_completion(buf, &name.replace('-', "_"), description);
}
buf.push_str("];\n");
buf.push_str("];\n\n");
buf.push_str(r#"pub const DEFAULT_LINT_GROUPS: &[LintGroup] = &["#);
for (name, description, children) in &lints {
if !children.is_empty() {
@@ -115,27 +159,23 @@ fn generate_lint_descriptor(sh: &Shell, buf: &mut String) {
buf.push_str(r#"pub const RUSTDOC_LINTS: &[Lint] = &["#);
buf.push('\n');
let lints_rustdoc =
stdout[start_lints_rustdoc..].lines().skip(2).take_while(|l| !l.is_empty()).map(|line| {
let (name, rest) = line.trim().split_once(char::is_whitespace).unwrap();
let (_default_level, description) =
rest.trim().split_once(char::is_whitespace).unwrap();
(name.trim(), Cow::Borrowed(description.trim()), vec![])
});
let lints_rustdoc = lints_rustdoc.lines().take_while(|l| !l.is_empty()).map(|line| {
let (name, rest) = line.trim().split_once(char::is_whitespace).unwrap();
let (_default_level, description) = rest.trim().split_once(char::is_whitespace).unwrap();
(name.trim(), Cow::Borrowed(description.trim()), vec![])
});
let lint_groups_rustdoc =
stdout[start_lint_groups_rustdoc..].lines().skip(2).take_while(|l| !l.is_empty()).map(
|line| {
let (name, lints) = line.trim().split_once(char::is_whitespace).unwrap();
(
name.trim(),
format!("lint group for: {}", lints.trim()).into(),
lints
.split_ascii_whitespace()
.map(|s| s.trim().trim_matches(',').replace('-', "_"))
.collect(),
)
},
);
lint_groups_rustdoc.lines().take_while(|l| !l.is_empty()).map(|line| {
let (name, lints) = line.trim().split_once(char::is_whitespace).unwrap();
(
name.trim(),
format!("lint group for: {}", lints.trim()).into(),
lints
.split_ascii_whitespace()
.map(|s| s.trim().trim_matches(',').replace('-', "_"))
.collect(),
)
});
let lints_rustdoc = lints_rustdoc
.chain(lint_groups_rustdoc)
@@ -145,7 +185,7 @@ fn generate_lint_descriptor(sh: &Shell, buf: &mut String) {
for (name, description, ..) in &lints_rustdoc {
push_lint_completion(buf, &name.replace('-', "_"), description)
}
buf.push_str("];\n");
buf.push_str("];\n\n");
buf.push_str(r#"pub const RUSTDOC_LINT_GROUPS: &[LintGroup] = &["#);
for (name, description, children) in &lints_rustdoc {
@@ -157,14 +197,24 @@ fn generate_lint_descriptor(sh: &Shell, buf: &mut String) {
buf.push_str("];\n");
}
#[track_caller]
fn find_and_slice<'a>(i: &'a str, p: &str) -> &'a str {
let idx = i.find(p).unwrap();
&i[idx + p.len()..]
}
/// Parses the unstable book `src_dir` and prints a constant with the list of
/// unstable features into `buf`.
///
/// It does this by looking for all `.md` files in the `language-features` and
/// `library-features` directories, and using the file name as the feature
/// name, and the file contents as the feature description.
fn generate_feature_descriptor(buf: &mut String, src_dir: &Path) {
let mut features = ["language-features", "library-features"]
.into_iter()
.flat_map(|it| sourcegen::list_files(&src_dir.join(it)))
.filter(|path| {
// Get all `.md ` files
path.extension().unwrap_or_default().to_str().unwrap_or_default() == "md"
})
// Get all `.md` files
.filter(|path| path.extension() == Some("md".as_ref()))
.map(|path| {
let feature_ident = path.file_stem().unwrap().to_str().unwrap().replace('-', "_");
let doc = fs::read_to_string(path).unwrap();
@@ -196,7 +246,7 @@ fn generate_descriptor_clippy(buf: &mut String, path: &Path) {
let mut clippy_lints: Vec<ClippyLint> = Vec::new();
let mut clippy_groups: std::collections::BTreeMap<String, Vec<String>> = Default::default();
for line in file_content.lines().map(|line| line.trim()) {
for line in file_content.lines().map(str::trim) {
if let Some(line) = line.strip_prefix(r#""id": ""#) {
let clippy_lint = ClippyLint {
id: line.strip_suffix(r#"","#).expect("should be suffixed by comma").into(),
@@ -211,12 +261,19 @@ fn generate_descriptor_clippy(buf: &mut String, path: &Path) {
.push(clippy_lints.last().unwrap().id.clone());
}
} else if let Some(line) = line.strip_prefix(r#""docs": ""#) {
let prefix_to_strip = r#" ### What it does"#;
let line = match line.strip_prefix(prefix_to_strip) {
Some(line) => line,
let header = "### What it does";
let line = match line.find(header) {
Some(idx) => &line[idx + header.len()..],
None => {
eprintln!("unexpected clippy prefix for {}", clippy_lints.last().unwrap().id);
continue;
let id = &clippy_lints.last().unwrap().id;
// these just don't have the common header
let allowed = ["allow_attributes", "read_line_without_trim"];
if allowed.contains(&id.as_str()) {
line
} else {
eprintln!("\nunexpected clippy prefix for {id}, line={line:?}\n",);
continue;
}
}
};
// Only take the description, any more than this is a lot of additional data we would embed into the exe
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/field_shorthand.rs
+5 -1
View File
@@ -166,7 +166,7 @@ fn test_check_pat_field_shorthand() {
check_diagnostics(
r#"
struct A { a: &'static str }
fn f(a: A) { let A { a: hello } = a; }
fn f(a: A) { let A { a: _hello } = a; }
"#,
);
check_diagnostics(
@@ -181,12 +181,14 @@ struct A { a: &'static str }
struct A { a: &'static str }
fn f(a: A) {
let A { a$0: a } = a;
_ = a;
}
"#,
r#"
struct A { a: &'static str }
fn f(a: A) {
let A { a } = a;
_ = a;
}
"#,
);
@@ -196,12 +198,14 @@ fn f(a: A) {
struct A { a: &'static str, b: &'static str }
fn f(a: A) {
let A { a$0: a, b } = a;
_ = (a, b);
}
"#,
r#"
struct A { a: &'static str, b: &'static str }
fn f(a: A) {
let A { a, b } = a;
_ = (a, b);
}
"#,
);
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/incorrect_case.rs
+67 -5
View File
@@ -111,6 +111,31 @@ fn some_fn() {
let what_aweird_formatting = 10;
another_func(what_aweird_formatting);
}
"#,
);
check_fix(
r#"
static S: i32 = M::A;
mod $0M {
pub const A: i32 = 10;
}
mod other {
use crate::M::A;
}
"#,
r#"
static S: i32 = m::A;
mod m {
pub const A: i32 = 10;
}
mod other {
use crate::m::A;
}
"#,
);
}
@@ -175,10 +200,10 @@ fn NonSnakeCaseName() {}
fn incorrect_function_params() {
check_diagnostics(
r#"
fn foo(SomeParam: u8) {}
fn foo(SomeParam: u8) { _ = SomeParam; }
// ^^^^^^^^^ 💡 warn: Parameter `SomeParam` should have snake_case name, e.g. `some_param`
fn foo2(ok_param: &str, CAPS_PARAM: u8) {}
fn foo2(ok_param: &str, CAPS_PARAM: u8) { _ = (ok_param, CAPS_PARAM); }
// ^^^^^^^^^^ 💡 warn: Parameter `CAPS_PARAM` should have snake_case name, e.g. `caps_param`
"#,
);
@@ -188,6 +213,7 @@ fn foo2(ok_param: &str, CAPS_PARAM: u8) {}
fn incorrect_variable_names() {
check_diagnostics(
r#"
#[allow(unused)]
fn foo() {
let SOME_VALUE = 10;
// ^^^^^^^^^^ 💡 warn: Variable `SOME_VALUE` should have snake_case name, e.g. `some_value`
@@ -294,6 +320,7 @@ fn SomeFunc(&self) {
// ^^^^^^^^ 💡 warn: Function `SomeFunc` should have snake_case name, e.g. `some_func`
let WHY_VAR_IS_CAPS = 10;
// ^^^^^^^^^^^^^^^ 💡 warn: Variable `WHY_VAR_IS_CAPS` should have snake_case name, e.g. `why_var_is_caps`
_ = WHY_VAR_IS_CAPS;
}
}
"#,
@@ -306,6 +333,7 @@ fn no_diagnostic_for_enum_variants() {
r#"
enum Option { Some, None }
#[allow(unused)]
fn main() {
match Option::None {
None => (),
@@ -322,6 +350,7 @@ fn non_let_bind() {
r#"
enum Option { Some, None }
#[allow(unused)]
fn main() {
match Option::None {
SOME_VAR @ None => (),
@@ -349,7 +378,9 @@ enum E {
}
mod F {
fn CheckItWorksWithCrateAttr(BAD_NAME_HI: u8) {}
fn CheckItWorksWithCrateAttr(BAD_NAME_HI: u8) {
_ = BAD_NAME_HI;
}
}
"#,
);
@@ -395,7 +426,7 @@ mod foo {
#[test] // Issue #8809.
fn parenthesized_parameter() {
check_diagnostics(r#"fn f((O): _) {}"#)
check_diagnostics(r#"fn f((O): _) { _ = O; }"#)
}
#[test]
@@ -472,7 +503,9 @@ mod CheckBadStyle {
mod F {
#![allow(non_snake_case)]
fn CheckItWorksWithModAttr(BAD_NAME_HI: u8) {}
fn CheckItWorksWithModAttr(BAD_NAME_HI: u8) {
_ = BAD_NAME_HI;
}
}
#[allow(non_snake_case, non_camel_case_types)]
@@ -510,17 +543,20 @@ fn NonSnakeCaseName(some_var: u8) -> u8 {
#[deny(nonstandard_style)]
mod CheckNonstandardStyle {
//^^^^^^^^^^^^^^^^^^^^^ 💡 error: Module `CheckNonstandardStyle` should have snake_case name, e.g. `check_nonstandard_style`
fn HiImABadFnName() {}
//^^^^^^^^^^^^^^ 💡 error: Function `HiImABadFnName` should have snake_case name, e.g. `hi_im_abad_fn_name`
}
#[deny(warnings)]
mod CheckBadStyle {
//^^^^^^^^^^^^^ 💡 error: Module `CheckBadStyle` should have snake_case name, e.g. `check_bad_style`
struct fooo;
//^^^^ 💡 error: Structure `fooo` should have CamelCase name, e.g. `Fooo`
}
mod F {
//^ 💡 warn: Module `F` should have snake_case name, e.g. `f`
#![deny(non_snake_case)]
fn CheckItWorksWithModAttr() {}
//^^^^^^^^^^^^^^^^^^^^^^^ 💡 error: Function `CheckItWorksWithModAttr` should have snake_case name, e.g. `check_it_works_with_mod_attr`
@@ -641,4 +677,30 @@ fn BAZ() {}
"#,
);
}
#[test]
fn module_name_inline() {
check_diagnostics(
r#"
mod M {
//^ 💡 warn: Module `M` should have snake_case name, e.g. `m`
mod IncorrectCase {}
//^^^^^^^^^^^^^ 💡 warn: Module `IncorrectCase` should have snake_case name, e.g. `incorrect_case`
}
"#,
);
}
#[test]
fn module_name_decl() {
check_diagnostics(
r#"
//- /Foo.rs
//- /main.rs
mod Foo;
//^^^ 💡 warn: Module `Foo` should have snake_case name, e.g. `foo`
"#,
)
}
}
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/mismatched_arg_count.rs
+12 -17
View File
@@ -23,12 +23,7 @@ pub(crate) fn mismatched_tuple_struct_pat_arg_count(
Diagnostic::new(
DiagnosticCode::RustcHardError("E0023"),
message,
invalid_args_range(
ctx,
d.expr_or_pat.clone().map(|it| it.either(Into::into, Into::into)),
d.expected,
d.found,
),
invalid_args_range(ctx, d.expr_or_pat.clone().map(Into::into), d.expected, d.found),
)
}
@@ -131,7 +126,7 @@ fn zero() {}
fn simple_free_fn_one() {
check_diagnostics(
r#"
fn one(arg: u8) {}
fn one(_arg: u8) {}
fn f() { one(); }
//^^ error: expected 1 argument, found 0
"#,
@@ -139,7 +134,7 @@ fn one(arg: u8) {}
check_diagnostics(
r#"
fn one(arg: u8) {}
fn one(_arg: u8) {}
fn f() { one(1); }
"#,
);
@@ -176,7 +171,7 @@ fn method_with_arg() {
check_diagnostics(
r#"
struct S;
impl S { fn method(&self, arg: u8) {} }
impl S { fn method(&self, _arg: u8) {} }
fn f() {
S.method();
@@ -187,7 +182,7 @@ fn f() {
check_diagnostics(
r#"
struct S;
impl S { fn method(&self, arg: u8) {} }
impl S { fn method(&self, _arg: u8) {} }
fn f() {
S::method(&S, 0);
@@ -335,8 +330,8 @@ fn foo(#[cfg(NEVER)] x: ()) {}
impl S {
fn method(#[cfg(NEVER)] self) {}
fn method2(#[cfg(NEVER)] self, arg: u8) {}
fn method3(self, #[cfg(NEVER)] arg: u8) {}
fn method2(#[cfg(NEVER)] self, _arg: u8) {}
fn method3(self, #[cfg(NEVER)] _arg: u8) {}
}
extern "C" {
@@ -365,8 +360,8 @@ fn legacy_const_generics() {
r#"
#[rustc_legacy_const_generics(1, 3)]
fn mixed<const N1: &'static str, const N2: bool>(
a: u8,
b: i8,
_a: u8,
_b: i8,
) {}
fn f() {
@@ -376,8 +371,8 @@ fn f() {
#[rustc_legacy_const_generics(1, 3)]
fn b<const N1: u8, const N2: u8>(
a: u8,
b: u8,
_a: u8,
_b: u8,
) {}
fn g() {
@@ -403,7 +398,7 @@ fn f(
// ^^ error: this pattern has 0 fields, but the corresponding tuple struct has 2 fields
S(e, f, .., g, d): S
// ^^^^^^^^^ error: this pattern has 4 fields, but the corresponding tuple struct has 2 fields
) {}
) { _ = (a, b, c, d, e, f, g); }
"#,
)
}
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/missing_fields.rs
+8 -11
View File
@@ -39,7 +39,7 @@ pub(crate) fn missing_fields(ctx: &DiagnosticsContext<'_>, d: &hir::MissingField
d.field_list_parent_path
.clone()
.map(SyntaxNodePtr::from)
.unwrap_or_else(|| d.field_list_parent.clone().either(|it| it.into(), |it| it.into())),
.unwrap_or_else(|| d.field_list_parent.clone().into()),
);
Diagnostic::new_with_syntax_node_ptr(ctx, DiagnosticCode::RustcHardError("E0063"), message, ptr)
@@ -58,10 +58,8 @@ fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::MissingFields) -> Option<Vec<Ass
let root = ctx.sema.db.parse_or_expand(d.file);
let current_module = match &d.field_list_parent {
Either::Left(ptr) => ctx.sema.scope(ptr.to_node(&root).syntax()).map(|it| it.module()),
Either::Right(ptr) => ctx.sema.scope(ptr.to_node(&root).syntax()).map(|it| it.module()),
};
let current_module =
ctx.sema.scope(d.field_list_parent.to_node(&root).syntax()).map(|it| it.module());
let build_text_edit = |parent_syntax, new_syntax: &SyntaxNode, old_syntax| {
let edit = {
@@ -87,9 +85,8 @@ fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::MissingFields) -> Option<Vec<Ass
)])
};
match &d.field_list_parent {
Either::Left(record_expr) => {
let field_list_parent = record_expr.to_node(&root);
match &d.field_list_parent.to_node(&root) {
Either::Left(field_list_parent) => {
let missing_fields = ctx.sema.record_literal_missing_fields(&field_list_parent);
let mut locals = FxHashMap::default();
@@ -152,8 +149,7 @@ fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::MissingFields) -> Option<Vec<Ass
old_field_list.syntax(),
)
}
Either::Right(record_pat) => {
let field_list_parent = record_pat.to_node(&root);
Either::Right(field_list_parent) => {
let missing_fields = ctx.sema.record_pattern_missing_fields(&field_list_parent);
let old_field_list = field_list_parent.record_pat_field_list()?;
@@ -290,6 +286,7 @@ fn missing_record_pat_field_ref() {
struct S { s: u32 }
fn x(a: S) {
let S { ref s } = a;
_ = s;
}
",
)
@@ -626,7 +623,7 @@ struct TestStruct { one: i32, two: i64 }
fn test_fn() {
let one = 1;
let s = TestStruct{ one, two: 2 };
let _s = TestStruct{ one, two: 2 };
}
"#,
);
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/missing_match_arms.rs
+4 -2
View File
@@ -19,6 +19,7 @@ pub(crate) fn missing_match_arms(
mod tests {
use crate::tests::check_diagnostics;
#[track_caller]
fn check_diagnostics_no_bails(ra_fixture: &str) {
cov_mark::check_count!(validate_match_bailed_out, 0);
crate::tests::check_diagnostics(ra_fixture)
@@ -564,6 +565,7 @@ fn unknown_type() {
r#"
enum Option<T> { Some(T), None }
#[allow(unused)]
fn main() {
// `Never` is deliberately not defined so that it's an uninferred type.
match Option::<Never>::None {
@@ -719,7 +721,7 @@ fn no_panic_at_unimplemented_subpattern_type() {
r#"
struct S { a: char}
fn main(v: S) {
match v { S{ a } => {} }
match v { S{ a } => { _ = a; } }
match v { S{ a: _x } => {} }
match v { S{ a: 'a' } => {} }
match v { S{..} => {} }
@@ -901,7 +903,7 @@ enum E{ A, B }
fn foo() {
match &E::A {
E::A => {}
x => {}
_x => {}
}
}",
);
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/missing_unsafe.rs
+24 -24
View File
@@ -100,9 +100,9 @@ fn missing_unsafe_diagnostic_with_raw_ptr() {
r#"
fn main() {
let x = &5 as *const usize;
unsafe { let y = *x; }
let z = *x;
} //^^💡 error: this operation is unsafe and requires an unsafe function or block
unsafe { let _y = *x; }
let _z = *x;
} //^^💡 error: this operation is unsafe and requires an unsafe function or block
"#,
)
}
@@ -116,13 +116,13 @@ fn missing_unsafe_diagnostic_with_unsafe_call() {
impl HasUnsafe {
unsafe fn unsafe_fn(&self) {
let x = &5 as *const usize;
let y = *x;
let _y = *x;
}
}
unsafe fn unsafe_fn() {
let x = &5 as *const usize;
let y = *x;
let _y = *x;
}
fn main() {
@@ -152,10 +152,10 @@ struct Ty {
static mut STATIC_MUT: Ty = Ty { a: 0 };
fn main() {
let x = STATIC_MUT.a;
//^^^^^^^^^^💡 error: this operation is unsafe and requires an unsafe function or block
let _x = STATIC_MUT.a;
//^^^^^^^^^^💡 error: this operation is unsafe and requires an unsafe function or block
unsafe {
let x = STATIC_MUT.a;
let _x = STATIC_MUT.a;
}
}
"#,
@@ -187,13 +187,13 @@ fn add_unsafe_block_when_dereferencing_a_raw_pointer() {
r#"
fn main() {
let x = &5 as *const usize;
let z = *x$0;
let _z = *x$0;
}
"#,
r#"
fn main() {
let x = &5 as *const usize;
let z = unsafe { *x };
let _z = unsafe { *x };
}
"#,
);
@@ -231,7 +231,7 @@ fn add_unsafe_block_when_calling_unsafe_method() {
impl S {
unsafe fn func(&self) {
let x = &self.0 as *const usize;
let z = *x;
let _z = *x;
}
}
fn main() {
@@ -244,7 +244,7 @@ fn main() {
impl S {
unsafe fn func(&self) {
let x = &self.0 as *const usize;
let z = *x;
let _z = *x;
}
}
fn main() {
@@ -267,7 +267,7 @@ struct Ty {
static mut STATIC_MUT: Ty = Ty { a: 0 };
fn main() {
let x = STATIC_MUT$0.a;
let _x = STATIC_MUT$0.a;
}
"#,
r#"
@@ -278,7 +278,7 @@ struct Ty {
static mut STATIC_MUT: Ty = Ty { a: 0 };
fn main() {
let x = unsafe { STATIC_MUT.a };
let _x = unsafe { STATIC_MUT.a };
}
"#,
)
@@ -382,16 +382,16 @@ fn unsafe_expr_as_right_hand_side_of_assignment() {
static mut STATIC_MUT: u8 = 0;
fn main() {
let x;
x = STATIC_MUT$0;
let _x;
_x = STATIC_MUT$0;
}
"#,
r#"
static mut STATIC_MUT: u8 = 0;
fn main() {
let x;
x = unsafe { STATIC_MUT };
let _x;
_x = unsafe { STATIC_MUT };
}
"#,
)
@@ -405,14 +405,14 @@ fn unsafe_expr_in_binary_plus() {
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = STATIC_MUT$0 + 1;
let _x = STATIC_MUT$0 + 1;
}
"#,
r#"
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = unsafe { STATIC_MUT } + 1;
let _x = unsafe { STATIC_MUT } + 1;
}
"#,
)
@@ -425,14 +425,14 @@ fn ref_to_unsafe_expr() {
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = &STATIC_MUT$0;
let _x = &STATIC_MUT$0;
}
"#,
r#"
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = unsafe { &STATIC_MUT };
let _x = unsafe { &STATIC_MUT };
}
"#,
)
@@ -445,14 +445,14 @@ fn ref_ref_to_unsafe_expr() {
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = &&STATIC_MUT$0;
let _x = &&STATIC_MUT$0;
}
"#,
r#"
static mut STATIC_MUT: u8 = 0;
fn main() {
let x = unsafe { &&STATIC_MUT };
let _x = unsafe { &&STATIC_MUT };
}
"#,
)
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/moved_out_of_ref.rs
+20 -3
View File
@@ -29,6 +29,7 @@ fn main() {
let a = &X;
let b = *a;
//^ error: cannot move `X` out of reference
_ = b;
}
"#,
);
@@ -46,6 +47,7 @@ fn main() {
let b = a.0;
//^ error: cannot move `X` out of reference
let y = a.1;
_ = (b, y);
}
"#,
);
@@ -59,8 +61,8 @@ fn move_out_of_static() {
struct X;
fn main() {
static S: X = X;
let s = S;
//^ error: cannot move `X` out of reference
let _s = S;
//^^ error: cannot move `X` out of reference
}
"#,
);
@@ -165,7 +167,7 @@ enum X {
fn main() {
let x = &X::Bar;
let c = || match *x {
let _c = || match *x {
X::Foo(t) => t,
_ => 5,
};
@@ -173,4 +175,19 @@ fn main() {
"#,
);
}
#[test]
fn regression_15787() {
check_diagnostics(
r#"
//- minicore: coerce_unsized, slice, copy
fn foo(mut slice: &[u32]) -> usize {
slice = match slice {
[0, rest @ ..] | rest => rest,
};
slice.len()
}
"#,
);
}
}
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/mutability_errors.rs
+49 -17
View File
@@ -324,6 +324,7 @@ fn main() {
let x_own = 2;
let ref mut x_ref = x_own;
//^^^^^^^^^^^^^ 💡 error: cannot mutate immutable variable `x_own`
_ = x_ref;
}
"#,
);
@@ -331,7 +332,7 @@ fn main() {
r#"
struct Foo;
impl Foo {
fn method(&mut self, x: i32) {}
fn method(&mut self, _x: i32) {}
}
fn main() {
let x = Foo;
@@ -391,6 +392,7 @@ fn main() {
//^^^^^ 💡 warn: variable does not need to be mutable
x = 7;
//^^^^^ 💡 error: cannot mutate immutable variable `x`
_ = y;
}
}
}
@@ -404,12 +406,14 @@ fn mutation_in_dead_code() {
// there would be no mutability error for locals in dead code. Rustc tries to
// not emit `unused_mut` in this case, but since it works without `mut`, and
// special casing it is not trivial, we emit it.
// Update: now MIR based `unused-variable` is taking over `unused-mut` for the same reason.
check_diagnostics(
r#"
fn main() {
return;
let mut x = 2;
//^^^^^ 💡 warn: variable does not need to be mutable
//^^^^^ warn: unused variable
&mut x;
}
"#,
@@ -419,7 +423,7 @@ fn main() {
fn main() {
loop {}
let mut x = 2;
//^^^^^ 💡 warn: variable does not need to be mutable
//^^^^^ warn: unused variable
&mut x;
}
"#,
@@ -440,7 +444,7 @@ fn main(b: bool) {
g();
}
let mut x = 2;
//^^^^^ 💡 warn: variable does not need to be mutable
//^^^^^ warn: unused variable
&mut x;
}
"#,
@@ -454,7 +458,7 @@ fn main(b: bool) {
return;
}
let mut x = 2;
//^^^^^ 💡 warn: variable does not need to be mutable
//^^^^^ warn: unused variable
&mut x;
}
"#,
@@ -536,6 +540,7 @@ fn main() {
(k @ 5, ref mut t) if { continue; } => {
//^^^^^^^^^ 💡 error: cannot mutate immutable variable `z`
*t = 5;
_ = k;
}
_ => {
let y = (1, 2);
@@ -588,6 +593,7 @@ fn main() {
b = 1;
c = (2, 3);
d = 3;
_ = (c, b, d);
}
}
"#,
@@ -600,6 +606,7 @@ fn function_arguments_are_initialized() {
r#"
fn f(mut x: i32) {
//^^^^^ 💡 warn: variable does not need to be mutable
f(x + 2);
}
"#,
);
@@ -615,8 +622,11 @@ fn f(x: i32) {
r#"
fn f((x, y): (i32, i32)) {
let t = [0; 2];
x = 5;
//^^^^^ 💡 error: cannot mutate immutable variable `x`
x = 5;
//^^^^^ 💡 error: cannot mutate immutable variable `x`
_ = x;
_ = y;
_ = t;
}
"#,
);
@@ -645,6 +655,7 @@ fn for_loop() {
//^^^^^ 💡 warn: variable does not need to be mutable
a = 2;
//^^^^^ 💡 error: cannot mutate immutable variable `a`
_ = b;
}
}
"#,
@@ -666,6 +677,7 @@ fn while_let() {
//^^^^^ 💡 error: cannot mutate immutable variable `a`
c = 2;
//^^^^^ 💡 error: cannot mutate immutable variable `c`
_ = (b, d);
}
}
}
@@ -696,18 +708,18 @@ fn f() {
fn overloaded_index() {
check_diagnostics(
r#"
//- minicore: index
//- minicore: index, copy
use core::ops::{Index, IndexMut};
struct Foo;
impl Index<usize> for Foo {
type Output = (i32, u8);
fn index(&self, index: usize) -> &(i32, u8) {
fn index(&self, _index: usize) -> &(i32, u8) {
&(5, 2)
}
}
impl IndexMut<usize> for Foo {
fn index_mut(&mut self, index: usize) -> &mut (i32, u8) {
fn index_mut(&mut self, _index: usize) -> &mut (i32, u8) {
&mut (5, 2)
}
}
@@ -715,26 +727,32 @@ fn f() {
let mut x = Foo;
//^^^^^ 💡 warn: variable does not need to be mutable
let y = &x[2];
_ = (x, y);
let x = Foo;
let y = &mut x[2];
//^💡 error: cannot mutate immutable variable `x`
_ = (x, y);
let mut x = &mut Foo;
//^^^^^ 💡 warn: variable does not need to be mutable
let y: &mut (i32, u8) = &mut x[2];
_ = (x, y);
let x = Foo;
let ref mut y = x[7];
//^ 💡 error: cannot mutate immutable variable `x`
_ = (x, y);
let (ref mut y, _) = x[3];
//^ 💡 error: cannot mutate immutable variable `x`
_ = y;
match x[10] {
//^ 💡 error: cannot mutate immutable variable `x`
(ref y, _) => (),
(_, ref mut y) => (),
(ref y, 5) => _ = y,
(_, ref mut y) => _ = y,
}
let mut x = Foo;
let mut i = 5;
//^^^^^ 💡 warn: variable does not need to be mutable
let y = &mut x[i];
_ = y;
}
"#,
);
@@ -744,7 +762,7 @@ fn f() {
fn overloaded_deref() {
check_diagnostics(
r#"
//- minicore: deref_mut
//- minicore: deref_mut, copy
use core::ops::{Deref, DerefMut};
struct Foo;
@@ -763,21 +781,27 @@ fn f() {
let mut x = Foo;
//^^^^^ 💡 warn: variable does not need to be mutable
let y = &*x;
_ = (x, y);
let x = Foo;
let y = &mut *x;
//^^ 💡 error: cannot mutate immutable variable `x`
_ = (x, y);
let x = Foo;
//^ warn: unused variable
let x = Foo;
let y: &mut (i32, u8) = &mut x;
//^^^^^^ 💡 error: cannot mutate immutable variable `x`
_ = (x, y);
let ref mut y = *x;
//^^ 💡 error: cannot mutate immutable variable `x`
_ = y;
let (ref mut y, _) = *x;
//^^ 💡 error: cannot mutate immutable variable `x`
_ = y;
match *x {
//^^ 💡 error: cannot mutate immutable variable `x`
(ref y, _) => (),
(_, ref mut y) => (),
(ref y, 5) => _ = y,
(_, ref mut y) => _ = y,
}
}
"#,
@@ -866,6 +890,7 @@ pub fn test() {
data: 0
}
);
_ = tree;
}
"#,
);
@@ -925,6 +950,7 @@ fn f() {
let x = X;
let closure4 = || { x.mutate(); };
//^ 💡 error: cannot mutate immutable variable `x`
_ = (closure2, closure3, closure4);
}
"#,
);
@@ -941,7 +967,9 @@ fn f() {
z = 3;
let mut k = z;
//^^^^^ 💡 warn: variable does not need to be mutable
_ = k;
};
_ = (x, closure);
}
"#,
);
@@ -958,6 +986,7 @@ fn f() {
}
}
};
_ = closure;
}
"#,
);
@@ -972,7 +1001,8 @@ fn f() {
let mut x = X;
let c2 = || { x = X; x };
let mut x = X;
let c2 = move || { x = X; };
let c3 = move || { x = X; };
_ = (c1, c2, c3);
}
"#,
);
@@ -1023,7 +1053,7 @@ fn x(t: &[u8]) {
a = 2;
//^^^^^ 💡 error: cannot mutate immutable variable `a`
_ = b;
}
_ => {}
}
@@ -1079,6 +1109,7 @@ fn f() {
let x = Box::new(5);
let closure = || *x = 2;
//^ 💡 error: cannot mutate immutable variable `x`
_ = closure;
}
"#,
);
@@ -1156,6 +1187,7 @@ macro_rules! mac {
fn main2() {
let mut x = mac![];
//^^^^^ 💡 warn: variable does not need to be mutable
_ = x;
}
"#,
);
src/tools/rust-analyzer/crates/ide-diagnostics/src/handlers/no_such_field.rs
+8 -10
View File
@@ -13,7 +13,7 @@
//
// This diagnostic is triggered if created structure does not have field provided in record.
pub(crate) fn no_such_field(ctx: &DiagnosticsContext<'_>, d: &hir::NoSuchField) -> Diagnostic {
let node = d.field.clone().map(|it| it.either(Into::into, Into::into));
let node = d.field.clone().map(Into::into);
if d.private {
// FIXME: quickfix to add required visibility
Diagnostic::new_with_syntax_node_ptr(
@@ -35,15 +35,13 @@ pub(crate) fn no_such_field(ctx: &DiagnosticsContext<'_>, d: &hir::NoSuchField)
fn fixes(ctx: &DiagnosticsContext<'_>, d: &hir::NoSuchField) -> Option<Vec<Assist>> {
// FIXME: quickfix for pattern
match &d.field.value {
Either::Left(ptr) => {
let root = ctx.sema.db.parse_or_expand(d.field.file_id);
missing_record_expr_field_fixes(
&ctx.sema,
d.field.file_id.original_file(ctx.sema.db),
&ptr.to_node(&root),
)
}
let root = ctx.sema.db.parse_or_expand(d.field.file_id);
match &d.field.value.to_node(&root) {
Either::Left(node) => missing_record_expr_field_fixes(
&ctx.sema,
d.field.file_id.original_file(ctx.sema.db),
node,
),
_ => None,
}
}

Some files were not shown because too many files have changed in this diff Show More