Don't lint single_component_path_imports in macros

This commit is contained in:
Yuki Okushi
2020-02-17 05:44:38 +09:00
parent 578960d61d
commit 09165ff576
3 changed files with 20 additions and 1 deletions
@@ -1,4 +1,4 @@
use crate::utils::span_lint_and_sugg;
use crate::utils::{in_macro, span_lint_and_sugg};
use if_chain::if_chain;
use rustc_errors::Applicability;
use rustc_lint::{EarlyContext, EarlyLintPass};
@@ -39,6 +39,7 @@
impl EarlyLintPass for SingleComponentPathImports {
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
if_chain! {
if !in_macro(item.span);
if cx.sess.opts.edition == Edition::Edition2018;
if !item.vis.node.is_pub();
if let ItemKind::Use(use_tree) = &item.kind;
@@ -7,6 +7,15 @@
use serde as edres;
pub use serde;
macro_rules! m {
() => {
use regex;
};
}
fn main() {
regex::Regex::new(r"^\d{4}-\d{2}-\d{2}$").unwrap();
// False positive #5154, shouldn't trigger lint.
m!();
}
@@ -7,6 +7,15 @@
use serde as edres;
pub use serde;
macro_rules! m {
() => {
use regex;
};
}
fn main() {
regex::Regex::new(r"^\d{4}-\d{2}-\d{2}$").unwrap();
// False positive #5154, shouldn't trigger lint.
m!();
}