Files
zig/test/incremental/add_remove_toplevel_fields
Matthew Lugg 291addadf8 tests: move incremental target matrix out of manifests
Having the matrix of test targets for incremental compilation in the
individual test manifests has turned out to be inconvenient for a few
reasons: the tests are almost certain to accidentally get out of sync,
disabling targets entirely is annoying to do, and incr-check needs to
take care to print the target in all error messages (which currently
does not always happen).

If I recall correctly, I originally designed it this way because it
allows targets to be disabled at the granularity of individual tests,
but there's an easier approach to that: just let a test manifest that it
should be *skipped* on a certain target! As skipping is the rare case,
and also the case you want readers to notice, it makes sense for *it* to
be explicitly specified, like how unit tests use `error.SkipZigTest`.

So, `incr-check` no longer runs through a list of targets specified in
the manifest. Instead, it accepts (and, in fact, requires) a single
target on the command line, and runs the test for that specific target.
If the file contains a `#skip_target` directive for that target, then
`incr-check` exits immediately, so we can still disable targets at
individual test granularity, but you can also disable a target for all
tests by just commenting it out of the matrix in `test/tests.zig`.

As a nice bonus, this also allows the build system to run different
incremental test targets in parallel, because the targets are now
different steps.

This definitely seems like a better way to split the work between the
build system and incr-check---sorry for getting this wrong initially!
2026-04-15 00:06:18 +02:00

97 lines
3.2 KiB
Plaintext

#update=initial version
#file=main.zig
const S = @This();
x: u8,
pub fn main(init: std.process.Init) !void {
var stdout_writer = std.Io.File.stdout().writerStreaming(init.io, &.{});
printFieldCount(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
printOneField(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
}
fn printFieldCount(w: *Writer) Writer.Error!void {
try w.print("{d} ", .{@typeInfo(S).@"struct".fields.len});
}
fn printOneField(w: *Writer) Writer.Error!void {
const val: S = .{ .x = 100 };
try w.print("{d}\n", .{val.x});
}
const std = @import("std");
const Writer = std.Io.Writer;
#expect_stdout="1 100\n"
#update=add a field
#file=main.zig
const S = @This();
x: u8,
y: u16 = 200,
pub fn main(init: std.process.Init) !void {
var stdout_writer = std.Io.File.stdout().writerStreaming(init.io, &.{});
printFieldCount(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
printOneField(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
}
fn printFieldCount(w: *Writer) Writer.Error!void {
try w.print("{d} ", .{@typeInfo(S).@"struct".fields.len});
}
fn printOneField(w: *Writer) Writer.Error!void {
const val: S = .{ .x = 100 };
try w.print("{d}\n", .{val.x});
}
const std = @import("std");
const Writer = std.Io.Writer;
#expect_stdout="2 100\n"
#update=remove all fields
#file=main.zig
const S = @This();
pub fn main(init: std.process.Init) !void {
var stdout_writer = std.Io.File.stdout().writerStreaming(init.io, &.{});
printFieldCount(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
printOneField(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
}
fn printFieldCount(w: *Writer) Writer.Error!void {
try w.print("{d} ", .{@typeInfo(S).@"struct".fields.len});
}
fn printOneField(w: *Writer) Writer.Error!void {
const val: S = .{ .x = 100 };
try w.print("{d}\n", .{val.x});
}
const std = @import("std");
const Writer = std.Io.Writer;
#expect_error=main.zig:15:24: error: no field named 'x' in struct 'main'
#expect_error=main.zig:1:1: note: struct declared here
#update=remove reference to non-existent field
#file=main.zig
const S = @This();
pub fn main(init: std.process.Init) !void {
var stdout_writer = std.Io.File.stdout().writerStreaming(init.io, &.{});
printFieldCount(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
printOneField(&stdout_writer.interface) catch |err| switch (err) {
error.WriteFailed => return stdout_writer.err.?,
};
}
fn printFieldCount(w: *Writer) Writer.Error!void {
try w.print("{d} ", .{@typeInfo(S).@"struct".fields.len});
}
fn printOneField(w: *Writer) Writer.Error!void {
//const val: S = .{ .x = 100 };
//try w.print("{d}\n", .{val.x});
try w.writeAll("<no fields>\n");
}
const std = @import("std");
const Writer = std.Io.Writer;
#expect_stdout="0 <no fields>\n"