From be0a77efd2aad5108d3357914cbc71f560ea0161 Mon Sep 17 00:00:00 2001 From: Matthew Lugg Date: Tue, 6 Jan 2026 11:13:13 +0000 Subject: [PATCH] std: re-enable some disabled tests I believe these tests may have been flaky as a result of the bug fixed in the previous commit. A big hint is that they were all crashing with SIGSEGV with no stack trace. I suspect that some lingering SIGIOs from cancelations were being delivered to a thread after its `munmap` call, which was happening because the test runner called `Io.Threaded.deinit` to cause all of the (detached) worker threads to exit. If this passes, I'll re-run the x86_64-linux CI jobs on this commit a few times before merge to try and be sure there are no lingering failures. Resolves: https://codeberg.org/ziglang/zig/issues/30096 Resolves: https://codeberg.org/ziglang/zig/issues/30592 Resolves: https://codeberg.org/ziglang/zig/issues/30682 --- lib/std/Io/test.zig | 4 ---- lib/std/crypto/argon2.zig | 2 -- 2 files changed, 6 deletions(-) diff --git a/lib/std/Io/test.zig b/lib/std/Io/test.zig index 6af9a5bad9..a467ee1a93 100644 --- a/lib/std/Io/test.zig +++ b/lib/std/Io/test.zig @@ -254,8 +254,6 @@ test "Group.cancel" { } test "Group.concurrent" { - if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30096 - const io = testing.io; var group: Io.Group = .init; @@ -421,8 +419,6 @@ test "Event" { } test "recancel" { - if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30592 - const global = struct { fn worker(io: Io) Io.Cancelable!void { var dummy_event: Io.Event = .unset; diff --git a/lib/std/crypto/argon2.zig b/lib/std/crypto/argon2.zig index 2bb5a49a45..0fd76e1282 100644 --- a/lib/std/crypto/argon2.zig +++ b/lib/std/crypto/argon2.zig @@ -907,8 +907,6 @@ test "kdf" { } test "phc format hasher" { - if (true) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30682 - const allocator = std.testing.allocator; const password = "testpass"; const io = std.testing.io;