Prefer <err> => |e| return e over <err> => return <err>

Avoids the potential for a typo on the `return <err>` side of the prong
This commit is contained in:
Ryan Liptak
2026-04-20 18:01:44 -07:00
parent 98cc059622
commit 3252a05531
62 changed files with 170 additions and 201 deletions
+1 -1
View File
@@ -11363,7 +11363,7 @@ fn writeToMemory(isel: *Select, constant: Constant, buffer: []u8) error{OutOfMem
const ip = &zcu.intern_pool;
if (try isel.writeKeyToMemory(ip.indexToKey(constant.toIntern()), buffer)) return true;
constant.writeToMemory(zcu, buffer) catch |err| switch (err) {
error.OutOfMemory => return error.OutOfMemory,
error.OutOfMemory => |e| return e,
error.ReinterpretDeclRef, error.Unimplemented, error.IllDefinedMemoryLayout => return false,
};
return true;
+3 -3
View File
@@ -812,7 +812,7 @@ pub fn generate(
const fn_info = zcu.typeToFunc(fn_type).?;
var call_info = function.resolveCallingConventionValues(fn_info, &.{}) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
else => |e| return e,
};
@@ -841,7 +841,7 @@ pub fn generate(
}));
function.gen() catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
error.OutOfRegisters => return function.fail("ran out of registers (Zig compiler bug)", .{}),
else => |e| return e,
};
@@ -893,7 +893,7 @@ pub fn generateLazy(
defer function.mir_instructions.deinit(gpa);
function.genLazy(lazy_sym) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
error.OutOfRegisters => return function.fail("ran out of registers (Zig compiler bug)", .{}),
else => |e| return e,
};
+2 -2
View File
@@ -308,7 +308,7 @@ pub fn generate(
defer function.exitlude_jump_relocs.deinit(gpa);
var call_info = function.resolveCallingConventionValues(func_ty, .callee) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
else => |e| return e,
};
defer call_info.deinit(&function);
@@ -319,7 +319,7 @@ pub fn generate(
function.max_end_stack = call_info.stack_byte_count;
function.gen() catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
error.OutOfRegisters => return function.fail("ran out of registers (Zig compiler bug)", .{}),
else => |e| return e,
};
+3 -3
View File
@@ -938,7 +938,7 @@ pub fn generate(
const fn_info = zcu.typeToFunc(fn_type).?;
var call_info = function.resolveCallingConventionValues(fn_info, &.{}, .args_frame) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
else => |e| return e,
};
defer call_info.deinit(&function);
@@ -983,7 +983,7 @@ pub fn generate(
}
function.gen(&file.zir.?, func_zir.inst, func.comptime_args, call_info.air_arg_count) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
error.OutOfRegisters => return function.fail("ran out of registers (Zig compiler bug)", .{}),
else => |e| return e,
};
@@ -1071,7 +1071,7 @@ pub fn generateLazy(
}
function.genLazy(lazy_sym) catch |err| switch (err) {
error.CodegenFail => return error.CodegenFail,
error.CodegenFail => |e| return e,
error.OutOfRegisters => return function.fail("ran out of registers (Zig compiler bug)", .{}),
else => |e| return e,
};