From ea17226a2e99e721baf13a824c036cafd2f5542e Mon Sep 17 00:00:00 2001 From: kud1ing Date: Tue, 21 May 2013 23:17:31 -0700 Subject: [PATCH] merge the two sections about impls `pub` --- Note-style-guide.md | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/Note-style-guide.md b/Note-style-guide.md index f180472..378bc37 100644 --- a/Note-style-guide.md +++ b/Note-style-guide.md @@ -21,10 +21,6 @@ Here are some rough guidelines to Rust style. They are followed unevenly and the - extension traits: XUtil? When do you prefer default methods to extensions? - avoid words with suffixes (able, etc). try to use transitive verbs, nouns, and then adjectives in that order -# Privacy - -* Avoid (`pub impl Type { ... }`). Instead mark the individual methods public. This allows a reader to immediately tell which methods are public at a glance. - # Function declarations Wrapped functions: @@ -206,8 +202,7 @@ A ```for``` loop is always preferable to a ```while``` loop unless the loop coun # Impls -Put `pub` modifiers on method names, not on the impls. - +* Avoid `pub impl Type { ... }`. Instead put `pub ` modifiers on the method names. This allows a reader to immediately tell which methods are public at a glance. # Questions and TODO