Stuart Cook 417bea36ef Rollup merge of #148508 - estebank:issue-74617, r=nnethercote ...

Provide more context when mutably borrowing an imutably borrowed value

Point at statics and consts being mutable borrowed or written to:

```
error[E0594]: cannot assign to immutable static item `NUM`
  --> $DIR/E0594.rs:4:5
   |
LL | static NUM: i32 = 18;
   | --------------- this `static` cannot be written to
...
LL |     NUM = 20;
   |     ^^^^^^^^ cannot assign
```

Point at the expression that couldn't be mutably borrowed from a pattern:

```
error[E0596]: cannot borrow data in a `&` reference as mutable
  --> $DIR/mut-pattern-of-immutable-borrow.rs:19:14
   |
LL |     match &arg.field {
   |           ---------- this cannot be borrowed as mutable
LL |         Some(ref mut s) => s.push('a'),
   |              ^^^^^^^^^ cannot borrow as mutable
```

Partially address rust-lang/rust#74617.

2025-11-11 21:09:38 +11:00

..

2229_closure_analysis

Rollup merge of #148508 - estebank:issue-74617, r=nnethercote

2025-11-11 21:09:38 +11:00

binder

stabilize gai

2025-06-11 15:30:15 +01:00

closure-expected-type

Remove all dead files inside tests/ui/

2025-01-27 02:28:04 +01:00

deduce-signature

Fix; correct placement of type inference error for method calls

2025-10-07 09:51:16 +01:00

print

Do not gather local all together at the beginning of typeck

2025-05-05 14:27:09 +00:00

add_semicolon_non_block_closure.rs

Don't suggest adding return type for closures with default return type

2024-08-28 12:54:39 +08:00

add_semicolon_non_block_closure.stderr

Don't suggest adding return type for closures with default return type

2024-08-28 12:54:39 +08:00

aliasability-violation-with-closure-21600.rs

Rehome tests/ui/issues/ tests [3/?]

2025-08-04 16:43:53 -04:00

aliasability-violation-with-closure-21600.stderr

Provide more context on Fn closure modifying binding

2025-11-03 20:26:18 +00:00

basic-closure-syntax.rs

cleaned up some tests

2025-06-30 11:50:19 +05:00

boxed-closure-lifetime-13808.rs

comments

2025-08-05 19:34:46 +05:00

cannot-call-unsized-via-ptr-2.rs

Always register sized obligation for argument

2023-06-15 03:18:21 +00:00

cannot-call-unsized-via-ptr-2.stderr

Always register sized obligation for argument

2023-06-15 03:18:21 +00:00

cannot-call-unsized-via-ptr.rs

Always register sized obligation for argument

2023-06-15 03:18:21 +00:00

cannot-call-unsized-via-ptr.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

capture-unsized-by-move.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

capture-unsized-by-move.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

capture-unsized-by-ref.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure_cap_coerce_many_fail.rs

…

closure_cap_coerce_many_fail.stderr

adjust how closure/generator types and rvalues are printed

2023-09-21 22:20:58 +02:00

closure_no_cap_coerce_many_check_pass.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure_no_cap_coerce_many_run_pass.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure_no_cap_coerce_many_unsafe_0.rs

Remove revisions for THIR unsafeck

2024-01-05 09:30:27 +00:00

closure_no_cap_coerce_many_unsafe_0.stderr

Remove revisions for THIR unsafeck

2024-01-05 09:30:27 +00:00

closure_no_cap_coerce_many_unsafe_1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure_promotion.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure-array-break-length.rs

…

closure-array-break-length.stderr

…

closure-bounds-cant-promote-superkind-in-struct.rs

Continue compilation after check_mod_type_wf errors

2024-02-14 11:00:30 +00:00

closure-bounds-cant-promote-superkind-in-struct.stderr

Mention type parameter in more cases and don't suggest ~const bound already there

2024-12-07 21:37:13 +00:00

closure-bounds-static-cant-capture-borrowed.rs

…

closure-bounds-static-cant-capture-borrowed.stderr

…

closure-bounds-subtype.rs

…

closure-bounds-subtype.stderr

Mention type parameter in more cases and don't suggest ~const bound already there

2024-12-07 21:37:13 +00:00

closure-capture-after-clone.rs

cleaned up some tests

2025-07-01 16:26:57 +05:00

closure-clone-requires-captured-clone.rs

cleaned up some tests

2025-07-01 15:16:56 +05:00

closure-clone-requires-captured-clone.stderr

cleaned up some tests

2025-07-01 15:16:56 +05:00

closure-expected.rs

Pretty print Fn traits in rustc_on_unimplemented

2023-11-02 20:57:05 +00:00

closure-expected.stderr

Use parenthetical notation for Fn traits

2024-05-29 22:26:54 +00:00

closure-immut-capture-error.rs

cleaned up some tests

2025-06-04 17:48:50 +05:00

closure-immut-capture-error.stderr

cleaned up some tests

2025-06-04 17:48:50 +05:00

closure-immutable-outer-variable.fixed

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure-immutable-outer-variable.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

closure-immutable-outer-variable.rs.fixed

…

closure-immutable-outer-variable.stderr

More accurate mutability suggestion

2024-07-04 05:36:34 +00:00

closure-last-use-move.rs

cleaned up some tests

2025-07-01 16:26:57 +05:00

closure-move-sync.rs

update failing ui tests

2023-06-20 19:46:01 -04:00

closure-move-sync.stderr

Remove detail from label/note that is already available in other note

2024-10-29 16:26:57 +00:00

closure-mut-argument-6153.rs

Add test batch 1

2025-08-27 00:23:26 -04:00

closure-no-copy-mut-env.rs

cleaned up some tests

2025-07-05 01:25:48 +05:00

closure-no-copy-mut-env.stderr

cleaned up some tests

2025-07-05 01:25:48 +05:00

closure-no-fn-1.rs

…

closure-no-fn-1.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-no-fn-2.rs

…

closure-no-fn-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-no-fn-3.rs

…

closure-no-fn-3.stderr

Note closure captures when reporting deferred cast to fn ptr failed

2024-07-22 21:51:44 -04:00

closure-no-fn-4.rs

…

closure-no-fn-4.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-no-fn-5.rs

…

closure-no-fn-5.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-referencing-itself-issue-25954.rs

…

closure-referencing-itself-issue-25954.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-reform-bad.rs

…

closure-reform-bad.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

closure-return-type-mismatch.rs

Pass correct HirId to late_bound_vars in diagnostic code

2024-09-26 19:26:08 +02:00

closure-return-type-mismatch.stderr

Merge typeck loop with static/const item eval loop

2025-05-09 15:31:27 +00:00

closure-return-type-must-be-sized.rs

…

closure-return-type-must-be-sized.stderr

Remove detail from label/note that is already available in other note

2024-10-29 16:26:57 +00:00

closure-type-inference-in-context-9129.rs

Rehome tests/ui/issues/ tests [4/?]

2025-08-10 11:54:15 -04:00

closure-upvar-last-use-analysis.rs

cleaned up some tests

2025-07-01 16:26:57 +05:00

closure-wrong-kind.rs

…

closure-wrong-kind.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

coerce-unsafe-closure-to-unsafe-fn-ptr.rs

Remove revisions for THIR unsafeck

2024-01-05 09:30:27 +00:00

coerce-unsafe-closure-to-unsafe-fn-ptr.stderr

update ui tests

2024-01-07 08:56:20 -08:00

coerce-unsafe-to-closure.rs

…

coerce-unsafe-to-closure.stderr

remove support for extern-block const intrinsics

2024-11-04 23:27:45 +01:00

correct-args-on-call-suggestion.rs

Fix closure arg extraction in extract_callable_info

2024-11-02 03:42:10 +00:00

correct-args-on-call-suggestion.stderr

Fix closure arg extraction in extract_callable_info

2024-11-02 03:42:10 +00:00

deduce-from-object-supertrait.rs

Do not deduplicate list of associated types provided by dyn principal

2025-02-21 19:32:45 +00:00

deeply-nested_closures.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

diverging-closure.rs

tests: use needs-subprocess instead of ignore-{wasm32,emscripten,sgx}

2025-01-23 20:51:29 +08:00

eager-mono-with-normalizable-upvars.rs

Normalize closure instance before eagerly monomorphizing it

2025-02-14 19:18:43 +00:00

fnonce-call-twice-error.rs

cleaned up some tests

2025-07-05 00:50:51 +05:00

fnonce-call-twice-error.stderr

cleaned up some tests

2025-07-05 00:50:51 +05:00

fnonce-moved-twice-12127.rs

comments

2025-07-31 21:25:49 +05:00

fnonce-moved-twice-12127.stderr

comments

2025-07-31 21:25:49 +05:00

generic-typed-nested-closures-59494.rs

Add test batch 3

2025-09-12 14:45:12 -04:00

generic-typed-nested-closures-59494.stderr

Add test batch 3

2025-09-12 14:45:12 -04:00

impl-closure-147146.rs

added error for closures case in impl

2025-10-01 12:38:16 +00:00

impl-closure-147146.stderr

added error for closures case in impl

2025-10-01 12:38:16 +00:00

issue-868.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-1460.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-1460.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

issue-5239-1.rs

Move some tests

2024-04-21 15:43:43 -03:00

issue-5239-1.stderr

Move some tests

2024-04-21 15:43:43 -03:00

issue-5239-2.rs

Move some tests

2024-04-21 15:43:43 -03:00

issue-6801.rs

…

issue-6801.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-10398.rs

…

issue-10398.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-10682.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-11873.rs

Move tests

2023-08-28 17:47:37 -03:00

issue-11873.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-22864-1.rs

Move some tests

2024-04-21 15:43:43 -03:00

issue-22864-2.rs

Move some tests

2024-04-21 15:43:43 -03:00

issue-25439.rs

s/generator/coroutine/

2023-10-20 21:14:01 +00:00

issue-25439.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-41366.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-42463.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-46742.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-48109.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-52437.rs

address review comments

2025-08-22 13:16:44 +08:00

issue-52437.stderr

address review comments

2025-08-22 13:16:44 +08:00

issue-67123.rs

…

issue-67123.stderr

reword trait bound suggestion message to include the bounds

2024-12-07 21:26:20 +00:00

issue-68025.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-72408-nested-closures-exponential.rs

Gate the type length limit check behind a nightly flag

2024-07-12 21:16:09 -04:00

issue-78720.rs

re-use sized fast path

2025-04-09 10:42:26 +00:00

issue-78720.stderr

fix: Add col separator before secondary messages with no source

2025-08-26 15:15:17 -06:00

issue-80313-mutable-borrow-in-closure.rs

…

issue-80313-mutable-borrow-in-closure.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-80313-mutable-borrow-in-move-closure.rs

…

issue-80313-mutable-borrow-in-move-closure.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-80313-mutation-in-closure.rs

…

issue-80313-mutation-in-closure.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-80313-mutation-in-move-closure.rs

…

issue-80313-mutation-in-move-closure.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-81700-mut-borrow.rs

…

issue-81700-mut-borrow.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-82438-mut-without-upvar.rs

…

issue-82438-mut-without-upvar.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-84044-drop-non-mut.rs

…

issue-84044-drop-non-mut.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-84128.rs

…

issue-84128.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-87461.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-87461.stderr

Emit a hint for bad call return types due to generic arguments

2023-01-13 13:34:55 +09:00

issue-87814-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-87814-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-90871.rs

…

issue-90871.stderr

fix: Add col separator before secondary messages with no source

2025-08-26 15:15:17 -06:00

issue-97607.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-99565.rs

…

issue-99565.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-101696.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-102089-multiple-opaque-cast.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-109188.rs

Continue to borrowck even if there were previous errors

2024-02-08 08:10:43 +00:00

issue-109188.stderr

Return equal for two identical projections

2023-03-21 15:28:11 +08:00

issue-111932.rs

diagnostics: do not suggest type name tweaks on type-inferred closure args

2023-06-05 19:05:15 -07:00

issue-111932.stderr

Implement DesugaringKind::FormatLiteral

2025-06-22 10:58:25 +02:00

issue-113087.rs

don't suggest move for borrows that aren't closures

2023-06-28 23:56:58 +02:00

issue-113087.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

labeled-break-inside-closure-62480.rs

Add test batch 4

2025-10-11 21:59:51 -04:00

labeled-break-inside-closure-62480.stderr

Add test batch 4

2025-10-11 21:59:51 -04:00

local-type-mix.rs

Stabilize async closures

2024-12-13 00:04:56 +00:00

local-type-mix.stderr

Stabilize async closures

2024-12-13 00:04:56 +00:00

many-closures.rs

cleaned up some tests

2025-07-01 15:29:29 +05:00

missing-body.rs

Replace ItemCtxt::report_placeholder_type_error match with a call to TyCtxt::def_descr

2025-06-30 20:36:16 +02:00

missing-body.stderr

Replace ItemCtxt::report_placeholder_type_error match with a call to TyCtxt::def_descr

2025-06-30 20:36:16 +02:00

moved-upvar-mut-rebind-11958.rs

Diagnose liveness on MIR.

2025-10-11 20:50:21 +00:00

moved-upvar-mut-rebind-11958.stderr

Diagnose liveness on MIR.

2025-10-11 20:50:21 +00:00

multiple-fn-bounds.rs

…

multiple-fn-bounds.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

no-capture-closure-call.rs

cleaned up some tests

2025-07-10 18:50:35 +05:00

old-closure-arg-call-as.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-arg.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-explicit-types.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-expr-precedence.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-expr-precedence.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

old-closure-expression-remove-semicolon.fixed

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-expression-remove-semicolon.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-expression-remove-semicolon.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

old-closure-fn-coerce.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-iter-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

old-closure-iter-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

once-move-out-on-heap.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

opaque-upvar.rs

Be a bit more relaxed about not yet constrained infer vars in closure upvar analysis

2025-05-05 19:06:45 +00:00

return-type-doesnt-match-bound.rs

Shorten error message for callable with wrong return type

2025-02-02 01:00:33 +00:00

return-type-doesnt-match-bound.stderr

Shorten error message for callable with wrong return type

2025-02-02 01:00:33 +00:00

return-value-lifetime-error.fixed

Provide suggestion to dereference closure tail if appropriate

2024-04-05 19:42:55 +00:00

return-value-lifetime-error.rs

Provide suggestion to dereference closure tail if appropriate

2024-04-05 19:42:55 +00:00

return-value-lifetime-error.stderr

Provide suggestion to dereference closure tail if appropriate

2024-04-05 19:42:55 +00:00

self-supertrait-bounds.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

semistatement-in-lambda.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

static-closures-with-nonstatic-return.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

supertrait-hint-cycle-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

supertrait-hint-cycle-3.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

supertrait-hint-cycle.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

supertrait-hint-references-assoc-ty.rs

"normalize" signature before checking mentions self

2025-01-28 14:11:29 +00:00

thir-unsafeck-issue-85871.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unused-closure-ice-16256.rs

comments

2025-08-09 16:27:20 +05:00

unused-closure-ice-16256.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

upvar-or-pattern-issue-138958.rs

Add a regression test for TestCase::Or without place

2025-03-26 02:25:01 +01:00

wrong-closure-arg-suggestion-125325.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

wrong-closure-arg-suggestion-125325.stderr

Provide more context on Fn closure modifying binding

2025-11-03 20:26:18 +00:00