bors e20cb77021 Auto merge of #116391 - Nadrieril:constructorset, r=cjgillot ...

exhaustiveness: Rework constructor splitting

`SplitWildcard` was pretty opaque. I replaced it with a more legible abstraction: `ConstructorSet` represents the set of constructors for patterns of a given type. This clarifies responsibilities: `ConstructorSet` handles one clear task, and diagnostic-related shenanigans can be done separately.

I'm quite excited, I had has this in mind for years but could never quite introduce it. This opens up possibilities, including type-specific optimisations (like using a `FxHashSet` to collect enum variants, which had been [hackily attempted some years ago](https://github.com/rust-lang/rust/pull/76918)), my one-pass rewrite (https://github.com/rust-lang/rust/pull/116042), and future librarification.

2023-10-12 21:33:31 +00:00

..

auxiliary

Add note when matching on nested non-exhaustive enums

2023-08-28 14:50:32 +08:00

integer-ranges

Add note when matching on tuples/ADTs containing non-exhaustive types

2023-08-21 11:18:20 +08:00

always-inhabited-union-ref.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

always-inhabited-union-ref.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

const-partial_eq-fallback-ice.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

const-partial_eq-fallback-ice.stderr

Add notes to non-structural const in pattern error message

2023-03-27 11:08:11 -04:00

const-pat-ice.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

const-private-fields.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

consts-opaque.rs

Prevent spurious unreachable pattern lints

2023-10-11 12:49:57 +00:00

consts-opaque.stderr

Prevent spurious unreachable pattern lints

2023-10-11 12:49:57 +00:00

deny-irrefutable-let-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

deny-irrefutable-let-patterns.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

doc-hidden-fields.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

doc-hidden-fields.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

doc-hidden-non-exhaustive.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

doc-hidden-non-exhaustive.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

empty-match.exhaustive_patterns.stderr

add note for non-exhaustive matches with guards

2023-06-28 01:51:53 -04:00

empty-match.normal.stderr

add note for non-exhaustive matches with guards

2023-06-28 01:51:53 -04:00

empty-match.rs

add note for non-exhaustive matches with guards

2023-06-28 01:51:53 -04:00

floats.rs

Evaluate float consts eagerly

2023-10-01 00:00:37 +02:00

floats.stderr

Evaluate float consts eagerly

2023-10-01 00:00:37 +02:00

guards.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

guards.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

irrefutable-let-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

irrefutable-unit.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-2111.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-2111.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

issue-3096-1.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-3096-1.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-3096-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-3096-2.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-3601.rs

add comment back

2023-06-28 01:51:53 -04:00

issue-3601.stderr

add comment back

2023-06-28 01:51:53 -04:00

issue-4321.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-4321.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-12116.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-12116.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-12369.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-12369.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-13727.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-13727.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-15129.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-15129.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-30240-b.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-30240-b.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-30240-rpass.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-30240.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-30240.stderr

Improve clarity of diagnostic message on non-exhaustive matches

2023-09-03 19:55:11 +08:00

issue-31221.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-31221.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-31561.rs

Migrate pattern matching

2023-01-11 14:40:02 -08:00

issue-31561.stderr

Don't recommend if let if let else works

2023-01-11 14:40:07 -08:00

issue-35609.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-35609.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

issue-39362.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-39362.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-40221.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-40221.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-50900.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-50900.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

issue-53820-slice-pattern-large-array.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-56379.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-56379.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

issue-57472.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-57472.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-65413-constants-and-slices-exhaustiveness.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-66501.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-71930-type-of-match-scrutinee.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72377.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72377.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72476-and-89393-associated-type.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-78123-non-exhaustive-reference.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-78123-non-exhaustive-reference.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-78549-ref-pat-and-str.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-80501-or-pat-and-macro.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-82772-match-box-as-struct.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-82772-match-box-as-struct.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-85222-types-containing-non-exhaustive-types.rs

Add note when matching on tuples/ADTs containing non-exhaustive types

2023-08-21 11:18:20 +08:00

issue-85222-types-containing-non-exhaustive-types.stderr

Add note when matching on tuples/ADTs containing non-exhaustive types

2023-08-21 11:18:20 +08:00

issue-88747.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-105479-str-non-exhaustiveness.rs

Improve clarity of diagnostic message on non-exhaustive matches

2023-09-03 19:55:11 +08:00

issue-105479-str-non-exhaustiveness.stderr

Improve clarity of diagnostic message on non-exhaustive matches

2023-09-03 19:55:11 +08:00

match-arm-statics-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-arm-statics-2.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-arm-statics.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-arm-statics.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-byte-array-patterns-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-byte-array-patterns-2.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

match-byte-array-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-byte-array-patterns.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-non-exhaustive.rs

add note for non-exhaustive matches with guards

2023-06-28 01:51:53 -04:00

match-non-exhaustive.stderr

add note for non-exhaustive matches with guards

2023-06-28 01:51:53 -04:00

match-privately-empty.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-privately-empty.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

match-ref-ice.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-ref-ice.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-slice-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-slice-patterns.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

match-vec-fixed.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-vec-fixed.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-vec-unreachable.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

match-vec-unreachable.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

nested-exhaustive-match.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

nested-non-exhaustive-enums.rs

Add note when matching on nested non-exhaustive enums

2023-08-28 14:50:32 +08:00

nested-non-exhaustive-enums.stderr

Improve clarity of diagnostic message on non-exhaustive matches

2023-09-03 19:55:11 +08:00

non-exhaustive-defined-here.rs

Migrate pattern matching

2023-01-11 14:40:02 -08:00

non-exhaustive-defined-here.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

non-exhaustive-match-nested.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

non-exhaustive-match-nested.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

non-exhaustive-match.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

non-exhaustive-match.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

non-exhaustive-pattern-witness.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

non-exhaustive-pattern-witness.stderr

Add note when matching on tuples/ADTs containing non-exhaustive types

2023-08-21 11:18:20 +08:00

refutable-pattern-errors.rs

Migrate pattern matching

2023-01-11 14:40:02 -08:00

refutable-pattern-errors.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

refutable-pattern-in-fn-arg.rs

Migrate pattern matching

2023-01-11 14:40:02 -08:00

refutable-pattern-in-fn-arg.stderr

Reinstate confusion note.

2023-04-03 15:59:21 +00:00

slice_of_empty.rs

Fix handling slices of empty types

2023-10-05 00:58:14 +02:00

slice_of_empty.stderr

Fix handling slices of empty types

2023-10-05 00:58:14 +02:00

slice-pattern-const-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-pattern-const-2.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-pattern-const-3.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-pattern-const-3.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-pattern-const.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-pattern-const.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-patterns-exhaustiveness.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-patterns-exhaustiveness.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

slice-patterns-irrefutable.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-patterns-reachability.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

slice-patterns-reachability.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

stable-gated-fields.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

stable-gated-fields.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

stable-gated-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

stable-gated-patterns.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

struct-like-enum-nonexhaustive.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

struct-like-enum-nonexhaustive.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00

struct-pattern-match-useless.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

struct-pattern-match-useless.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

top-level-alternation.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

top-level-alternation.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

tuple-struct-nonexhaustive.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

tuple-struct-nonexhaustive.stderr

Add note when matching on tuples/ADTs containing non-exhaustive types

2023-08-21 11:18:20 +08:00

type_polymorphic_byte_str_literals.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

type_polymorphic_byte_str_literals.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

uninhabited.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

unstable-gated-fields.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

unstable-gated-fields.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

unstable-gated-patterns.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

unstable-gated-patterns.stderr

Perform match checking on THIR.

2023-04-03 15:59:21 +00:00