Jacob Pratt e3676b5ab9 Rollup merge of #155428 - lapla-cogito:issue_139089, r=mejrs ...

Fix ICE in borrowck mutability suggestion with multi-byte ref sigil

Fixes rust-lang/rust#139089

Similarly to rust-lang/rust#155068, this is another instance where span arithmetic did not account for multi-byte characters. (Note that the ampersand in the test is full-width)

This change also results in correcting some inappropriate suggestions.

2026-04-18 00:05:19 -04:00

..

auxiliary

…

borrowck-borrow-overloaded-auto-deref-mut.rs

…

borrowck-borrow-overloaded-auto-deref-mut.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-borrow-overloaded-deref-mut.rs

…

borrowck-borrow-overloaded-deref-mut.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-call-is-borrow-issue-12224.rs

…

borrowck-call-is-borrow-issue-12224.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-call-method-from-mut-aliasable.rs

…

borrowck-call-method-from-mut-aliasable.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-fn-in-const-b.rs

…

borrowck-fn-in-const-b.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-let-suggestion-suffixes.rs

Improve diagnostics for buffer reuse with borrowed references

2025-10-22 21:11:02 +09:00

borrowck-let-suggestion-suffixes.stderr

Improve diagnostics for buffer reuse with borrowed references

2025-10-22 21:11:02 +09:00

borrowck-object-mutability.rs

…

borrowck-object-mutability.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

borrowck-ref-into-rvalue.fixed

…

borrowck-ref-into-rvalue.rs

…

borrowck-ref-into-rvalue.stderr

…

coerce-suggestions.rs

…

coerce-suggestions.stderr

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic

2026-01-26 17:34:31 +00:00

destructor-restrictions.rs

…

destructor-restrictions.stderr

…

drop-location-span-error-rust-2021-incompatible-closure-captures-93117.rs

…

drop-location-span-error-rust-2021-incompatible-closure-captures-93117.stderr

…

drop-location-span-error-rust-2021-incompatible-closure-captures-96258.rs

…

drop-location-span-error-rust-2021-incompatible-closure-captures-96258.stderr

Merge E0412 into E0425

2025-12-02 18:25:13 +00:00

dropck_arr_cycle_checked.rs

…

dropck_arr_cycle_checked.stderr

…

dropck_direct_cycle_with_drop.rs

…

dropck_direct_cycle_with_drop.stderr

…

dropck_misc_variants.rs

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

dropck_misc_variants.stderr

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

dropck_vec_cycle_checked.rs

…

dropck_vec_cycle_checked.stderr

…

dropck-object-cycle.rs

…

dropck-object-cycle.stderr

…

E0046.rs

…

E0046.stderr

…

E0072.rs

…

E0072.stderr

…

E0204.rs

Keep span of type in builtin derive macros expansions

2026-02-01 18:20:30 +00:00

E0204.stderr

Keep span of type in builtin derive macros expansions

2026-02-01 18:20:30 +00:00

E0493.rs

…

E0493.stderr

…

E0537.rs

…

E0537.stderr

…

E0539.rs

make error codes reflect reality better

2025-06-17 23:22:51 +02:00

E0539.stderr

Add more docs to templates for attrs with incorrect arguments

2025-08-11 17:02:32 +00:00

E0805.rs

Port cfg!() macro to the new attribute parsing system

2025-11-03 18:23:41 +01:00

E0805.stderr

Make span_suggestions always verbose

2026-04-15 01:38:14 +00:00

gated-features-attr-spans.rs

…

gated-features-attr-spans.stderr

…

impl-wrong-item-for-trait.rs

…

impl-wrong-item-for-trait.stderr

…

import-ty-params.rs

…

import-ty-params.stderr

…

issue28498-reject-ex1.rs

…

issue28498-reject-ex1.stderr

…

issue28498-reject-lifetime-param.rs

…

issue28498-reject-lifetime-param.stderr

…

issue28498-reject-passed-to-fn.rs

…

issue28498-reject-passed-to-fn.stderr

…

issue28498-reject-trait-bound.rs

…

issue28498-reject-trait-bound.stderr

…

issue-11925.rs

…

issue-11925.stderr

…

issue-23338-locals-die-before-temps-of-body.rs

…

issue-23338-locals-die-before-temps-of-body.stderr

…

issue-23729.rs

…

issue-23729.stderr

…

issue-23827.rs

…

issue-23827.stderr

…

issue-24356.rs

…

issue-24356.stderr

…

issue-24690.rs

…

issue-24690.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

issue-24805-dropck-child-has-items-via-parent.rs

…

issue-24805-dropck-child-has-items-via-parent.stderr

…

issue-24805-dropck-trait-has-items.rs

…

issue-24805-dropck-trait-has-items.stderr

…

issue-24895-copy-clone-dropck.rs

…

issue-24895-copy-clone-dropck.stderr

…

issue-25199.rs

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

issue-25199.stderr

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

issue-26656.rs

…

issue-26656.stderr

…

issue-27522.rs

…

issue-27522.stderr

…

issue-29106.rs

…

issue-29106.stderr

…

issue-29595.rs

…

issue-29595.stderr

…

issue-33884.rs

…

issue-33884.stderr

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic

2026-01-26 17:34:31 +00:00

issue-34264.rs

…

issue-34264.stderr

Add FnContext in parser for diagnostic

2025-08-14 21:31:47 +08:00

issue-35987.rs

…

issue-35987.stderr

…

issue-36537.rs

…

issue-36537.stderr

…

issue-37767.rs

…

issue-37767.stderr

…

issue-39018.rs

…

issue-39018.stderr

…

issue-39698.rs

…

issue-39698.stderr

bless tests

2026-02-22 17:10:36 +03:00

issue-40157.rs

…

issue-40157.stderr

…

issue-42234-unknown-receiver-type.full.stderr

…

issue-42234-unknown-receiver-type.generic_arg.stderr

…

issue-42234-unknown-receiver-type.rs

…

issue-42234-unknown-receiver-type.stderr

Point turbofish inference errors at the uninferred generic arg

2026-03-13 07:29:05 -04:00

issue-43927-non-ADT-derive.rs

…

issue-43927-non-ADT-derive.stderr

check earlier for misused crate-level attributes

2026-03-22 07:51:23 +00:00

issue-71363.rs

Fix terminal dependent tests

2026-01-19 18:54:02 +00:00

issue-71363.stderr

On E0277, point at type that doesn't implement bound

2025-08-22 17:55:15 +00:00

issue-81800.rs

…

issue-81800.stderr

…

issue-107353.rs

…

let-offset-of.rs

Regression test for let x = offset_of!(..) else { .. } span

2026-02-07 23:41:23 +11:00

let-offset-of.stderr

Improve irrefutable let-else lint wording

2026-03-03 03:39:56 +03:00

lint-unused-unsafe.rs

…

lint-unused-unsafe.stderr

…

macro-span-caller-replacement.rs

Point at span within local macros even when error happens in nested external macro

2025-12-10 19:27:40 +00:00

macro-span-caller-replacement.stderr

Point at span within local macros even when error happens in nested external macro

2025-12-10 19:27:40 +00:00

macro-span-replacement.rs

…

macro-span-replacement.stderr

…

macro-ty-params.rs

…

macro-ty-params.stderr

…

method-and-field-eager-resolution.rs

…

method-and-field-eager-resolution.stderr

…

missing-unit-argument.rs

…

missing-unit-argument.stderr

…

move-closure.rs

…

move-closure.stderr

…

multiline-span-E0072.rs

…

multiline-span-E0072.stderr

…

multiline-span-simple.rs

…

multiline-span-simple.stderr

Point at binop lhs and rhs when expression is multiline

2026-03-29 21:07:54 +00:00

multispan-import-lint.rs

…

multispan-import-lint.stderr

…

mut-arg-hint.rs

…

mut-arg-hint.stderr

Provide more context when mutably borrowing an imutable borrow

2025-11-09 22:14:48 +00:00

mut-ptr-cant-outlive-ref.rs

…

mut-ptr-cant-outlive-ref.stderr

…

mutability-suggestion-fullwidth-ampersand.rs

Fix ICE in borrowck mutability suggestion with multi-byte ref sigil

2026-04-18 08:52:11 +09:00

mutability-suggestion-fullwidth-ampersand.stderr

Fix ICE in borrowck mutability suggestion with multi-byte ref sigil

2026-04-18 08:52:11 +09:00

non-existing-module-import.rs

…

non-existing-module-import.stderr

…

pub-struct-field.rs

…

pub-struct-field.stderr

…

range-2.rs

…

range-2.stderr

…

recursive-type-field.rs

…

recursive-type-field.stderr

…

regionck-unboxed-closure-lifetimes.rs

…

regionck-unboxed-closure-lifetimes.stderr

…

regions-close-over-borrowed-ref-in-obj.rs

…

regions-close-over-borrowed-ref-in-obj.stderr

…

regions-close-over-type-parameter-2.rs

…

regions-close-over-type-parameter-2.stderr

…

regions-escape-loop-via-variable.rs

…

regions-escape-loop-via-variable.stderr

…

regions-escape-loop-via-vec.rs

…

regions-escape-loop-via-vec.stderr

Improve diagnostics for buffer reuse with borrowed references

2025-10-22 21:11:02 +09:00

regions-infer-borrow-scope-within-loop.rs

…

regions-infer-borrow-scope-within-loop.stderr

…

send-is-not-static-ensures-scoping.rs

…

send-is-not-static-ensures-scoping.stderr

…

send-is-not-static-std-sync-2.rs

…

send-is-not-static-std-sync-2.stderr

…

send-is-not-static-std-sync.rs

…

send-is-not-static-std-sync.stderr

…

slice-borrow.rs

…

slice-borrow.stderr

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic

2026-01-26 17:34:31 +00:00

span-extend-prev-while-multibyte.rs

Fix ICE in span_extend_prev_while with multibyte characters

2026-04-10 06:34:12 +09:00

span-extend-prev-while-multibyte.stderr

Fix ICE in span_extend_prev_while with multibyte characters

2026-04-10 06:34:12 +09:00

suggestion-non-ascii.rs

…

suggestion-non-ascii.stderr

indexing: reword help

2025-10-01 07:39:03 +00:00

suggestion-raw-68962.rs

…

suggestion-raw-68962.stderr

Make typo in field and name suggestions verbose

2025-12-09 17:29:23 +00:00

transitive-dep-span.rs

…

transitive-dep-span.stderr

…

type-annotations-needed-expr.rs

…

type-annotations-needed-expr.stderr

…

type-binding.rs

…

type-binding.stderr

…

typo-suggestion.rs

…

typo-suggestion.stderr

Make typo in field and name suggestions verbose

2025-12-09 17:29:23 +00:00

unused-warning-point-at-identifier.rs

…

unused-warning-point-at-identifier.stderr

…

vec_refs_data_with_early_death.rs

…

vec_refs_data_with_early_death.stderr

…

vec-macro-outlives-issue-15480.fixed

add write_box_via_move intrinsic and use it for vec!

2026-02-16 17:27:40 +01:00

vec-macro-outlives-issue-15480.rs

add write_box_via_move intrinsic and use it for vec!

2026-02-16 17:27:40 +01:00

vec-macro-outlives-issue-15480.stderr

add write_box_via_move intrinsic and use it for vec!

2026-02-16 17:27:40 +01:00

vec-must-not-hide-type-from-dropck.rs

…

vec-must-not-hide-type-from-dropck.stderr

…

visibility-ty-params.rs

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

visibility-ty-params.stderr

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

wf-method-late-bound-regions.rs

…

wf-method-late-bound-regions.stderr

…