bors fa5eda19b9 Auto merge of #149917 - GuillaumeGomez:malformed-attribute-suggestions, r=JonathanBrouwer ...

If there are too many suggestions for malformed attribute, do not suggest them

Part of https://github.com/rust-lang/rust/issues/149865.

This not only covers for doc attributes but for all attributes, so don't hesitate to tell me if you want it to be limited to only doc attributes (although I think it's actually a nice improvement overall).

Also, I picked 3 as the maximum number of suggestions before it becomes noise, but it's very much open to debate.

r? `@JonathanBrouwer`

2025-12-12 18:18:14 +00:00

..

auxiliary

compiler: Add {x86_64,aarch64,riscv64gc}-unknown-managarm-mlibc targets

2025-08-29 00:49:29 +02:00

export

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

inline

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

main-removed-2

Ignore more failing ui tests for GCC backend

2025-09-26 15:33:48 +02:00

no_link

Move some tests out of tests/ui

2025-05-03 17:22:52 +02:00

positions

Update uitests

2025-08-14 18:18:42 +02:00

unsafe

Remove uses of cfg(any()/all())

2025-12-10 23:41:19 +00:00

used

Move more tests/ui tests

2025-05-12 16:35:09 +02:00

z-crate-attr

Rollup merge of #138632 - clubby789:stabilize-cfg-boolean-lit, r=davidtwco,Urgau,traviscross

2025-04-17 06:25:15 +02:00

align-on-fields-143987.rs

add issue link in test

2025-11-28 02:45:42 +05:30

align-on-fields-143987.stderr

Make typo in field and name suggestions verbose

2025-12-09 17:29:23 +00:00

arg-error-issue-121425.rs

fix spans of arguments in diagnostic

2024-03-03 10:48:40 +08:00

arg-error-issue-121425.stderr

add #[align] attribute

2025-06-18 12:37:08 +02:00

assoc-expr.rs

Overhaul token collection.

2024-08-16 09:07:55 +10:00

attr_unknown_custom_attr.rs

cleaned up some tests

2025-06-08 11:25:09 +05:00

attr_unknown_custom_attr.stderr

cleaned up some tests

2025-06-08 11:25:09 +05:00

attr-bad-crate-attr.rs

compiletest: Require //~ annotations even if error-pattern is specified

2025-04-03 11:08:55 +03:00

attr-bad-crate-attr.stderr

compiletest: Require //~ annotations even if error-pattern is specified

2025-04-03 11:08:55 +03:00

attr-before-view-item2.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

attr-before-view-item.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

attr-eq-token-tree.rs

…

attr-eq-token-tree.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

attr-mix-new.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

attr-mix-new.stderr

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

attr-on-mac-call.rs

Regression test for attributes on macro calls

2025-08-24 14:54:15 +02:00

attr-on-mac-call.stderr

sort attribute targets for more consistent error messages

2025-10-08 08:32:03 +02:00

attr-shebang.rs

Adjust tests/ui/attr-shebang.rs

2024-12-17 19:22:21 +08:00

attrs-on-params.rs

Update uitests

2025-08-14 18:18:42 +02:00

attrs-on-params.stderr

Update uitests

2025-08-14 18:18:42 +02:00

attrs-with-no-formal-in-generics-1.rs

…

attrs-with-no-formal-in-generics-1.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

attrs-with-no-formal-in-generics-2.rs

…

attrs-with-no-formal-in-generics-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

attrs-with-no-formal-in-generics-3.rs

…

attrs-with-no-formal-in-generics-3.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

builtin-attribute-prefix.rs

Fix ICE for parsed attributes with longer path not handled by CheckAttrVisitor

2025-07-11 17:02:57 +02:00

builtin-attribute-prefix.stderr

Fix ICE for parsed attributes with longer path not handled by CheckAttrVisitor

2025-07-11 17:02:57 +02:00

check-builtin-attr-ice.rs

Changes to the tests for the #[should_panic] port

2025-08-06 21:38:00 +02:00

check-builtin-attr-ice.stderr

Changes to the tests for the #[should_panic] port

2025-08-06 21:38:00 +02:00

check-cfg_attr-ice.rs

tests: add regression test to make sure cfg_attr isn't considered unhandled

2024-08-06 06:12:10 +00:00

check-cfg_attr-ice.stderr

Reword "crate not found" resolve message

2025-01-24 01:19:50 +00:00

class-attributes-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

class-attributes-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

cold-attribute-application-54044.rs

Update uitests

2025-08-14 18:18:42 +02:00

cold-attribute-application-54044.stderr

Update uitests

2025-08-14 18:18:42 +02:00

collapse-debuginfo-invalid.rs

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

collapse-debuginfo-invalid.stderr

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

const-stability-on-macro.rs

Update since stability attributes in tests

2023-10-23 13:04:47 -07:00

const-stability-on-macro.stderr

Update since stability attributes in tests

2023-10-23 13:04:47 -07:00

crate-name-attr-validation.rs

cleaned up some tests

2025-06-08 01:14:05 +05:00

crate-name-empty.rs

Add a test with an empty crate name.

2025-03-25 16:14:27 +11:00

crate-name-empty.stderr

Port crate name to the new attribute system

2025-08-24 09:20:57 +02:00

crate-name-macro-call.rs

Port crate name to the new attribute system

2025-08-24 09:20:57 +02:00

crate-name-macro-call.stderr

Port crate name to the new attribute system

2025-08-24 09:20:57 +02:00

crate-name-mismatch.rs

cleaned up some tests

2025-06-08 11:25:09 +05:00

crate-name-mismatch.stderr

Port crate name to the new attribute system

2025-08-24 09:20:57 +02:00

crate-only-as-outer.rs

Use attribute name in message for "outer attr used as inner attr" errors

2025-08-25 21:31:04 +02:00

crate-only-as-outer.stderr

Use attribute name in message for "outer attr used as inner attr" errors

2025-08-25 21:31:04 +02:00

crate-type-delimited.rs

Move #![crate_type] UI tests into attributes directory

2025-02-15 03:41:07 +01:00

crate-type-delimited.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

crate-type-empty.rs

Move #![crate_type] UI tests into attributes directory

2025-02-15 03:41:07 +01:00

crate-type-empty.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

crate-type-macro-call.rs

Move #![crate_type] UI tests into attributes directory

2025-02-15 03:41:07 +01:00

crate-type-macro-call.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

crate-type-macro-empty.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

crate-type-macro-empty.stderr

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

crate-type-macro-not-crate.rs

fix #137589

2025-02-25 18:17:32 +01:00

crate-type-macro-not-crate.stderr

fix #137589

2025-02-25 18:17:32 +01:00

crate-type-macro-not-found.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

crate-type-macro-not-found.stderr

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

custom_attr_multisegment_error.rs

cleaned up some tests

2025-06-08 11:25:09 +05:00

custom_attr_multisegment_error.stderr

cleaned up some tests

2025-06-08 11:25:09 +05:00

decl_macro_ty_in_attr_macro.rs

add test to reproduce #137662 (using ty decl macro fragment in an attr) and fix it

2025-02-28 09:43:46 +01:00

doc-attr.rs

Fix ui tests

2025-12-10 12:28:05 +01:00

doc-attr.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

doc-test-literal.rs

Fix ui tests

2025-12-10 12:28:05 +01:00

doc-test-literal.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

dont-dup-expr-attrs.rs

Fix problem causing rusqlite compilation to OOM.

2025-04-02 06:21:18 +11:00

dump_def_parents.rs

Remove the -test suffix from normalize directives

2024-12-27 19:58:16 +11:00

dump_def_parents.stderr

Filter empty lines, comments and delimiters from previous to last multiline span rendering

2024-12-12 23:36:27 +00:00

dump-preds.rs

Remove the -test suffix from normalize directives

2024-12-27 19:58:16 +11:00

dump-preds.stderr

trait_sel: skip elaboration of sizedness supertrait

2025-06-16 23:04:36 +00:00

duplicated-attributes.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

duplicated-attributes.stderr

…

empty-repr.rs

Update uitests

2025-08-14 18:18:42 +02:00

empty-repr.stderr

improve empty attribute diagnostic

2025-09-27 19:32:14 +02:00

expected-word.rs

expected word diagnostic test

2025-06-20 15:06:29 +02:00

expected-word.stderr

expected word diagnostic test

2025-06-20 15:06:29 +02:00

extented-attribute-macro-error.rs

Fix ui tests

2025-12-10 12:28:05 +01:00

extented-attribute-macro-error.stderr

Fix ui tests

2025-12-10 12:28:05 +01:00

field-attributes-vis-unresolved.rs

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

field-attributes-vis-unresolved.stderr

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

fn-align-dyn.rs

Ignore more failing ui tests for GCC backend

2025-09-26 15:33:48 +02:00

fn-align-nameres-ambiguity-143834.rs

Mitigate #[align] name resolution ambiguity regression with a rename

2025-07-19 01:42:30 +08:00

helper-attr-interpolated-non-lit-arg.rs

Add regression test for a former ICE involving helper attributes containing interpolated tokens

2025-08-14 03:39:32 +02:00

illegal-macro-use.rs

allow macro_use as first segment

2025-06-02 16:30:21 +08:00

illegal-macro-use.stderr

allow macro_use as first segment

2025-06-02 16:30:21 +08:00

inline-attribute-enum-variant-error.rs

Update uitests

2025-08-14 18:18:42 +02:00

inline-attribute-enum-variant-error.stderr

Update uitests

2025-08-14 18:18:42 +02:00

inline-main.rs

cleaned up some tests

2025-06-28 16:24:17 +05:00

inner-attr-metavar.rs

Fix a problem with metavars and inner attributes.

2025-04-02 06:21:18 +11:00

inner-attrs-impl-cfg.rs

cleaned up some tests

2025-06-29 15:37:33 +05:00

invalid_macro_export_argument.allow.stderr

Add AcceptContext::suggestions

2025-10-22 21:43:50 +02:00

invalid_macro_export_argument.deny.stderr

Add AcceptContext::suggestions

2025-10-22 21:43:50 +02:00

invalid_macro_export_argument.rs

Changes to uitests for macro_export port

2025-09-21 10:42:47 -04:00

invalid-macro-use.rs

Add more docs to templates for attrs with incorrect arguments

2025-08-11 17:02:32 +00:00

invalid-macro-use.stderr

Add more docs to templates for attrs with incorrect arguments

2025-08-11 17:02:32 +00:00

invalid-repr.rs

add #[align] attribute

2025-06-18 12:37:08 +02:00

invalid-repr.stderr

add #[align] attribute

2025-06-18 12:37:08 +02:00

invalid-reprs.rs

check if merged attributes list is empty

2025-04-05 06:09:14 +09:00

invalid-reprs.stderr

Add link to invalid repr error

2025-08-11 16:00:49 +00:00

issue-40962.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-90873.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

issue-90873.stderr

Make parse error suggestions verbose and fix spans

2024-07-12 03:02:57 +00:00

issue-100631.rs

…

issue-100631.stderr

Fix test output expectations

2025-02-24 14:31:19 +01:00

issue-105594-invalid-attr-validation.rs

Update uitests

2025-08-14 18:18:42 +02:00

issue-105594-invalid-attr-validation.stderr

Update uitests

2025-08-14 18:18:42 +02:00

issue-115264-expr-field.rs

For now, ignore target checking for doc attributes in attr_parsing

2025-12-10 20:18:42 +01:00

issue-115264-pat-field.rs

For now, ignore target checking for doc attributes in attr_parsing

2025-12-10 20:18:42 +01:00

item-attributes.rs

Remove libc from rust_get_test_int uses

2024-04-17 09:18:14 -04:00

key-value-expansion-on-mac.rs

Improve an error involving attribute values.

2023-12-12 15:54:25 +11:00

key-value-expansion-on-mac.stderr

Improve an error involving attribute values.

2023-12-12 15:54:25 +11:00

key-value-expansion-scope-pass.rs

resolve: When suppressing out_of_scope_macro_calls suppress unused_imports as well

2025-10-20 19:14:46 +03:00

key-value-expansion-scope.rs

Fix ui tests

2025-12-10 12:28:05 +01:00

key-value-expansion-scope.stderr

Fix ui tests

2025-12-10 12:28:05 +01:00

key-value-expansion.rs

Update tests.

2025-01-07 16:04:14 +01:00

key-value-expansion.stderr

Fix ui tests

2025-12-10 12:28:05 +01:00

key-value-non-ascii.rs

…

key-value-non-ascii.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

link-dl.allowed.stderr

Make #[link="dl"] a warning rather than an error

2025-10-04 11:22:56 +02:00

link-dl.default_fcw.stderr

Make #[link="dl"] a warning rather than an error

2025-10-04 11:22:56 +02:00

link-dl.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

linkage.rs

Update uitests

2025-08-14 18:18:42 +02:00

linkage.stderr

sort attribute targets for more consistent error messages

2025-10-08 08:32:03 +02:00

lint_on_root.rs

take attr style into account in attr diagnostics

2025-08-16 10:51:09 +02:00

lint_on_root.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

log-backtrace.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

macro_export_on_decl_macro.rs

check_attrs: Warn when #[macro_export] is used on macros 2.0

2023-08-07 21:14:28 +02:00

macro_export_on_decl_macro.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

main-removed-1.rs

…

main-removed-1.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

malformed-attrs.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

malformed-attrs.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

malformed-fn-align.rs

Rework attribute recovery logic

2025-12-09 01:16:05 +00:00

malformed-fn-align.stderr

Rework attribute recovery logic

2025-12-09 01:16:05 +00:00

malformed-must_use.rs

Port #[must_use] to new attribute parsing infrastructure

2025-06-22 14:51:58 +02:00

malformed-must_use.stderr

Port #[must_use] to new attribute parsing infrastructure

2025-06-22 14:51:58 +02:00

malformed-never-type-options.rs

Promote crash test.

2025-08-05 01:55:20 +00:00

malformed-never-type-options.stderr

Promote crash test.

2025-08-05 01:55:20 +00:00

malformed-no-std.rs

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

malformed-no-std.stderr

Update uitests with new unused_attributes warnings

2025-10-18 21:17:48 +02:00

malformed-reprs.rs

Regression tests for repr ICEs

2025-07-06 22:07:09 +02:00

malformed-reprs.stderr

If there are too many suggestions for malformed attribute, do not suggest them

2025-12-12 14:55:17 +01:00

malformed-static-align.rs

allow #[rustc_align_static(N)] on statics

2025-09-09 21:54:54 +02:00

malformed-static-align.stderr

sort attribute targets for more consistent error messages

2025-10-08 08:32:03 +02:00

may_dangle.rs

Check that #[may_dangle] is properly applied

2024-08-18 20:32:00 +03:00

may_dangle.stderr

Check that #[may_dangle] is properly applied

2024-08-18 20:32:00 +03:00

method-attributes.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

mixed_export_name_and_no_mangle_2024.fixed

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

mixed_export_name_and_no_mangle_2024.rs

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

mixed_export_name_and_no_mangle_2024.stderr

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

mixed_export_name_and_no_mangle.fixed

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

mixed_export_name_and_no_mangle.rs

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

mixed_export_name_and_no_mangle.stderr

Move mixed export_name/no_mangle check to check_attr.rs and improve the error

2025-06-26 08:50:42 +02:00

multiple-invalid.rs

Update uitests

2025-08-14 18:18:42 +02:00

multiple-invalid.stderr

Update uitests

2025-08-14 18:18:42 +02:00

no-mangle-closure.rs

Fix double error for #[no_mangle] on closures

2025-10-08 17:46:33 +02:00

no-mangle-closure.stderr

Fix double error for #[no_mangle] on closures

2025-10-08 17:46:33 +02:00

nonterminal-expansion.rs

Updated uitests for new parser

2025-08-22 08:58:45 +02:00

nonterminal-expansion.stderr

Updated uitests for new parser

2025-08-22 08:58:45 +02:00

obsolete-attr.rs

…

obsolete-attr.stderr

…

optimize.rs

Update uitests

2025-08-14 18:18:42 +02:00

optimize.stderr

Update uitests

2025-08-14 18:18:42 +02:00

outer-mod-attr-applies-only-to-first.rs

improves outer mod attribute test

2025-03-15 10:52:07 -06:00

pass-indirectly.rs

Add #[rustc_pass_indirectly_in_non_rustic_abis]

2025-11-04 09:56:17 +01:00

pass-indirectly.stderr

Add #[rustc_pass_indirectly_in_non_rustic_abis]

2025-11-04 09:56:17 +01:00

proc-macro-unsafe.rs

Add test for unnecessary unsafe on proc macro attr

2025-11-07 13:59:44 +01:00

proc-macro-unsafe.stderr

Add test for unnecessary unsafe on proc macro attr

2025-11-07 13:59:44 +01:00

reexport-test-harness-entry-point.rs

cleaned up some tests

2025-07-05 01:54:04 +05:00

repr-align-in-trait-issue-132391.rs

Fix test output expectations

2025-02-24 14:31:19 +01:00

repr-align-in-trait-issue-132391.stderr

Fix test output expectations

2025-02-24 14:31:19 +01:00

rustc_confusables_std_cases.rs

Add get_line confusable to Stdin::read_line()

2024-10-02 23:19:26 -05:00

rustc_confusables_std_cases.stderr

Use tcx.short_string() in more diagnostics

2025-08-07 21:18:00 +00:00

rustc_confusables.rs

Update uitests

2025-08-19 09:03:54 +02:00

rustc_confusables.stderr

Update uitests

2025-08-14 18:18:42 +02:00

rustc_pub_transparent.rs

New #[rustc_pub_transparent] attribute

2024-08-24 23:05:37 +03:00

rustc_pub_transparent.stderr

New #[rustc_pub_transparent] attribute

2024-08-24 23:05:37 +03:00

rustc_skip_during_method_dispatch.rs

Update uitests

2025-08-14 18:18:42 +02:00

rustc_skip_during_method_dispatch.stderr

Update uitests

2025-08-14 18:18:42 +02:00

statement-attribute-validation.rs

Add regression test for #117058

2023-10-24 08:21:52 +00:00

statement-attribute-validation.stderr

Add regression test for #117058

2023-10-24 08:21:52 +00:00

suffixed-literal-meta.rs

…

suffixed-literal-meta.stderr

…

tool_attributes.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unknown-attr.rs

…

unknown-attr.stderr

…

unnamed-field-attributes-dup.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unnamed-field-attributes-vis.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unnamed-field-attributes.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unrestricted-attribute-tokens.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unused-item-in-attr.rs

Improve an error involving attribute values.

2023-12-12 15:54:25 +11:00

unused-item-in-attr.stderr

Improve an error involving attribute values.

2023-12-12 15:54:25 +11:00

use-doc-alias-name.rs

collect doc alias as tips during resolution

2025-05-21 00:47:36 +08:00

use-doc-alias-name.stderr

collect doc alias as tips during resolution

2025-05-21 00:47:36 +08:00

use-extern-crate-named-macro-use.rs

allow macro_use as first segment

2025-06-02 16:30:21 +08:00

used_with_archive.rs

Make #[used] work when linking with ld64

2025-02-24 04:04:59 +01:00

used_with_archive.run.stdout

Make #[used] work when linking with ld64

2025-02-24 04:04:59 +01:00

used_with_arg_no_mangle.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

used_with_arg.rs

Port #[used] to new attribute parsing infrastructure

2025-06-27 08:58:26 +02:00

used_with_arg.stderr

Port #[used] to new attribute parsing infrastructure

2025-06-27 08:58:26 +02:00

used_with_multi_args.rs

Port #[used] to new attribute parsing infrastructure

2025-06-27 08:58:26 +02:00

used_with_multi_args.stderr

Allow attr entries to declare list of alternatives for List and NamedValueStr

2025-08-11 16:00:49 +00:00

validation-on-associated-items-issue-121537.rs

fix attribute validation on associated items in traits

2024-02-24 08:14:38 -05:00

validation-on-associated-items-issue-121537.stderr

fix attribute validation on associated items in traits

2024-02-24 08:14:38 -05:00

variant-attributes.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00