Stuart Cook 565d1bb950 Rollup merge of #151744 - enthropy7:fix-refining-impl-trait-rtn, r=davidtwco ...

fix refining_impl_trait suggestion with return_type_notation

using `#![feature(return_type_notation)] `on top of `refining_impl_trait` made the lint suggest a pretty wild “wrap the body in `<Self as Trait>::f(..)”` fix instead of the simple “just copy the return type from the trait”. this patch makes the lint always suggest the plain return-type replacement based on the trait signature (by grabbing the original snippet when possible), so you don’t get RTN-style desugarings in the help

new test here

fixes rust-lang/rust#151663

2026-02-23 13:31:59 +11:00

..

alias-liveness

…

apit

…

auto-trait-leakage

Use tcx.short_string() in more diagnostics

2025-08-07 21:18:00 +00:00

auxiliary

…

diagnostics

When a trait isn't implemented, but another similar impl is found, point at it:

2025-10-31 20:38:31 +00:00

explicit-generic-args-with-impl-trait

…

in-bindings

When more than a single impl and less than 4 could apply, point at them

2025-10-31 20:44:01 +00:00

in-ctfe

…

in-trait

fix refining_impl_trait suggestion with return_type_notation

2026-02-06 16:14:09 +03:00

issues

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

member-constraints

in opaque type handling lift region vars to static if they outlive placeholders

2025-10-13 15:26:22 +01:00

method

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

multiple-lifetimes

…

non-defining-uses

When a trait isn't implemented, but another similar impl is found, point at it:

2025-10-31 20:38:31 +00:00

precise-capturing

Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic

2026-01-26 17:34:31 +00:00

rpit

…

transmute

Separate transmute checking from typeck.

2025-08-22 20:10:27 +00:00

associated-impl-trait-type-generic-trait.rs

…

associated-impl-trait-type-issue-114325.rs

…

associated-impl-trait-type-trivial.rs

…

associated-impl-trait-type.rs

…

associated-type-cycle.rs

…

associated-type-cycle.stderr

Make all multipart suggestions verbose

2026-02-18 18:33:35 +00:00

associated-type-fn-bound-issue-72207.rs

Add a regression test for #72207

2025-10-12 08:24:39 +09:00

associated-type-undefine.rs

…

associated-type-undefine.stderr

…

async_scope_creep.rs

…

auto-trait-selection-freeze.next.stderr

support non-defining uses in HIR typeck

2025-08-25 14:20:18 +02:00

auto-trait-selection-freeze.old.stderr

Point to correct argument in Func Call when Self type fails trait bound

2025-07-07 16:47:15 +08:00

auto-trait-selection-freeze.rs

…

auto-trait-selection.next.stderr

support non-defining uses in HIR typeck

2025-08-25 14:20:18 +02:00

auto-trait-selection.old.stderr

Point to correct argument in Func Call when Self type fails trait bound

2025-07-07 16:47:15 +08:00

auto-trait-selection.rs

…

autoderef.rs

…

basic-trait-impl.rs

…

bivariant-lifetime-liveness.rs

…

bound-normalization-fail.rs

…

bound-normalization-fail.stderr

…

bound-normalization-pass.rs

…

bounds_regression.rs

…

call_method_ambiguous.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_on_inherent_impl_on_rigid_type.current.stderr

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

call_method_on_inherent_impl_on_rigid_type.next.stderr

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

call_method_on_inherent_impl_on_rigid_type.rs

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

call_method_on_inherent_impl_ref-err.current.stderr

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_on_inherent_impl_ref-err.next.stderr

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_on_inherent_impl_ref-err.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_on_inherent_impl_ref-ok.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_on_inherent_impl.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

call_method_without_import.no_import.stderr

fix: Add col separator before secondary messages with no source

2025-08-26 15:15:17 -06:00

call_method_without_import.rs

…

capture-lifetime-not-in-hir.rs

…

capture-lifetime-not-in-hir.stderr

…

captured-invalid-lifetime.rs

…

captured-invalid-lifetime.stderr

…

closure-calling-parent-fn.rs

…

closure-in-impl-trait-arg.rs

…

closure-in-impl-trait.rs

…

closure-in-type.rs

…

cross-return-site-inference.rs

…

cross-return-site-inference.stderr

…

deduce-signature-from-supertrait.rs

…

define-via-const.rs

…

define-via-extern.rs

…

define-via-extern.stderr

…

defined-by-trait-resolution.rs

…

defining-use-captured-non-universal-region.infer.stderr

…

defining-use-captured-non-universal-region.rs

…

defining-use-captured-non-universal-region.statik.stderr

…

defining-use-uncaptured-non-universal-region-2.rs

…

defining-use-uncaptured-non-universal-region-3.rs

…

defining-use-uncaptured-non-universal-region.rs

…

deprecated_annotation.rs

…

different_where_bounds.rs

…

divergence.rs

…

does-not-live-long-enough.rs

…

does-not-live-long-enough.stderr

handle opaque types before region inference

2025-08-20 11:04:38 +02:00

dont-suggest-box-on-empty-else-arm.rs

…

dont-suggest-box-on-empty-else-arm.stderr

…

dyn-impl-type-mismatch.rs

…

dyn-impl-type-mismatch.stderr

…

dyn-incompatible-trait-in-return-position-dyn-trait.rs

…

dyn-incompatible-trait-in-return-position-dyn-trait.stderr

…

dyn-incompatible-trait-in-return-position-impl-trait.rs

…

dyn-incompatible-trait-in-return-position-impl-trait.stderr

…

dyn-trait-elided-two-inputs-assoc.rs

…

dyn-trait-elided-two-inputs-param.rs

…

dyn-trait-elided-two-inputs-ref-assoc.rs

…

dyn-trait-elided-two-inputs-ref-param.rs

…

dyn-trait-return-should-be-impl-trait.edition2015.stderr

…

dyn-trait-return-should-be-impl-trait.edition2021.stderr

…

dyn-trait-return-should-be-impl-trait.rs

…

eagerly-reveal-in-local-body.rs

…

equal-hidden-lifetimes.rs

…

equality2.rs

…

equality2.stderr

…

equality-in-canonical-query.rs

…

equality-rpass.rs

…

equality-rpass.stderr

…

equality.rs

…

equality.stderr

Point at span within local macros even when error happens in nested external macro

2025-12-10 19:27:40 +00:00

erased-regions-in-hidden-ty.current.stderr

…

erased-regions-in-hidden-ty.next.stderr

…

erased-regions-in-hidden-ty.rs

…

example-calendar.rs

…

example-st.rs

…

example-st.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

extra-impl-in-trait-impl.fixed

…

extra-impl-in-trait-impl.rs

…

extra-impl-in-trait-impl.stderr

…

extra-item.rs

…

extra-item.stderr

…

failed-to-resolve-instance-ice-105488.rs

…

failed-to-resolve-instance-ice-105488.stderr

…

failed-to-resolve-instance-ice-123145.rs

…

failed-to-resolve-instance-ice-123145.stderr

…

fallback_inference.rs

…

fallback_inference.stderr

…

fallback.rs

…

feature-self-return-type.rs

…

feature-self-return-type.stderr

…

fresh-lifetime-from-bare-trait-obj-114664.rs

…

fresh-lifetime-from-bare-trait-obj-114664.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

future-no-bound-vars-ice-112347.rs

…

generic-with-implicit-hrtb-without-dyn.edition2015.stderr

…

generic-with-implicit-hrtb-without-dyn.edition2021.stderr

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

generic-with-implicit-hrtb-without-dyn.pre2021.stderr

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

generic-with-implicit-hrtb-without-dyn.rs

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

hidden-lifetimes.edition2015.stderr

…

hidden-lifetimes.edition2024.stderr

…

hidden-lifetimes.rs

…

hidden-type-is-opaque-2.default.stderr

Fix; correct placement of type inference error for method calls

2025-10-07 09:51:16 +01:00

hidden-type-is-opaque-2.next.stderr

Fix; correct placement of type inference error for method calls

2025-10-07 09:51:16 +01:00

hidden-type-is-opaque-2.rs

…

hidden-type-is-opaque.rs

…

higher-ranked-lifetime-capture-deduplication.edition2015.stderr

Deduplicate higher-ranked lifetime capture errors in impl Trait

2025-10-12 16:51:28 +09:00

higher-ranked-lifetime-capture-deduplication.edition2024.stderr

Deduplicate higher-ranked lifetime capture errors in impl Trait

2025-10-12 16:51:28 +09:00

higher-ranked-lifetime-capture-deduplication.rs

Deduplicate higher-ranked lifetime capture errors in impl Trait

2025-10-12 16:51:28 +09:00

ice-148622-opaque-as-const-generics.rs

Fix ICE when collecting opaques from trait method declarations

2025-11-21 21:42:40 +09:00

ice-148622-opaque-as-const-generics.stderr

Fix ICE when collecting opaques from trait method declarations

2025-11-21 21:42:40 +09:00

ice-unexpected-param-type-whensubstituting-in-region-112823.current.stderr

…

ice-unexpected-param-type-whensubstituting-in-region-112823.next.stderr

…

ice-unexpected-param-type-whensubstituting-in-region-112823.rs

…

impl_fn_associativity.rs

…

impl_trait_projections.rs

…

impl_trait_projections.stderr

…

impl-fn-hrtb-bounds-2.edition2015.stderr

…

impl-fn-hrtb-bounds-2.edition2024.stderr

…

impl-fn-hrtb-bounds-2.rs

…

impl-fn-hrtb-bounds.rs

…

impl-fn-hrtb-bounds.stderr

Deduplicate higher-ranked lifetime capture errors in impl Trait

2025-10-12 16:51:28 +09:00

impl-fn-parsing-ambiguities.rs

…

impl-fn-parsing-ambiguities.stderr

Deduplicate higher-ranked lifetime capture errors in impl Trait

2025-10-12 16:51:28 +09:00

impl-fn-predefined-lifetimes.edition2015.stderr

…

impl-fn-predefined-lifetimes.edition2024.stderr

…

impl-fn-predefined-lifetimes.rs

…

impl-fn-rpit-opaque-107883.rs

…

impl-generic-mismatch.rs

…

impl-generic-mismatch.stderr

fix: Add col separator before secondary messages with no source

2025-08-26 15:15:17 -06:00

impl-subtyper2.rs

…

impl-subtyper.rs

…

impl-trait-in-generic-param.rs

clean up some tests

2026-01-22 19:50:00 +01:00

impl-trait-in-generic-param.stderr

clean up some tests

2026-01-22 19:50:00 +01:00

impl-trait-in-macro.rs

…

impl-trait-in-macro.stderr

…

impl-trait-plus-priority.rs

…

impl-trait-plus-priority.stderr

…

implicit-capture-late.rs

…

implicit-capture-late.stderr

…

in-assoc-type-unconstrained.rs

…

in-assoc-type-unconstrained.stderr

…

in-assoc-type.rs

…

in-assoc-type.stderr

…

inside-item-nested-in-anon-const.rs

…

lazy_subtyping_of_opaques.rs

rename select_where_possible and select_all_or_error

2025-10-07 23:02:23 +01:00

lifetime-ambiguity-regression.rs

…

lifetimes.rs

…

mapping-duplicated-lifetimes-issue-114597.rs

…

multiple-defining-usages-in-body.rs

…

multiple-defining-usages-in-body.stderr

…

must_outlive_least_region_or_bound.rs

…

must_outlive_least_region_or_bound.stderr

…

name-mentioning-macro.rs

…

name-mentioning-macro.stderr

…

needs_least_region_or_bound.rs

…

negative-reasoning.rs

…

negative-reasoning.stderr

…

nested_impl_trait.rs

…

nested_impl_trait.stderr

When more than a single impl and less than 4 could apply, point at them

2025-10-31 20:44:01 +00:00

nested-hkl-lifetime.rs

…

nested-return-type2-tait2.rs

…

nested-return-type2-tait2.stderr

…

nested-return-type2-tait3.rs

…

nested-return-type2-tait3.stderr

…

nested-return-type2-tait.rs

…

nested-return-type2-tait.stderr

…

nested-return-type2.rs

…

nested-return-type3-tait2.rs

…

nested-return-type3-tait2.stderr

…

nested-return-type3-tait3.rs

…

nested-return-type3-tait3.stderr

…

nested-return-type3-tait.rs

…

nested-return-type3-tait.stderr

…

nested-return-type3.rs

…

nested-return-type4.rs

…

nested-return-type4.stderr

…

nested-return-type.rs

…

nested-rpit-hrtb-2.rs

…

nested-rpit-hrtb-2.stderr

…

nested-rpit-hrtb.rs

in opaque type handling lift region vars to static if they outlive placeholders

2025-10-13 15:26:22 +01:00

nested-rpit-hrtb.stderr

Auto merge of #147602 - JohnTitor:dedup-lifetime-capture-errors, r=estebank

2025-12-10 06:52:27 +00:00

nested-rpit-with-anonymous-lifetimes.rs

…

nesting.rs

…

no-anonymize-regions.rs

handle opaque types before region inference

2025-08-20 11:04:38 +02:00

no-method-suggested-traits.rs

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

no-method-suggested-traits.stderr

Gate 2015 UI tests

2025-11-27 11:19:00 -05:00

no-trait.rs

…

no-trait.stderr

…

normalize-opaque-with-bound-vars.rs

…

normalize-tait-in-const.rs

…

normalize-tait-in-const.stderr

Constify Fn* traits

2025-07-08 14:36:43 +00:00

not_general_enough_regression_106630.rs

…

opaque-cast-field-access-in-future.rs

…

opaque-cast-field-access-in-future.stderr

…

opaque-hidden-inferred-rpitit.rs

…

opaque-used-in-extraneous-argument.rs

…

opaque-used-in-extraneous-argument.stderr

Merge E0412 into E0425

2025-12-02 18:25:13 +00:00

opt-out-bound-not-satisfied.rs

Reword diagnostic about relaxing non-Sized bound

2025-07-18 12:13:30 +02:00

opt-out-bound-not-satisfied.stderr

Reword diagnostic about relaxing non-Sized bound

2025-07-18 12:13:30 +02:00

point-to-type-err-cause-on-impl-trait-return.rs

…

point-to-type-err-cause-on-impl-trait-return.stderr

…

printing-binder.rs

…

printing-binder.stderr

…

private_unused.rs

…

projection-mismatch-in-impl-where-clause.rs

…

projection-mismatch-in-impl-where-clause.stderr

…

projection.rs

…

question_mark.rs

…

recursive-auto-trait.rs

…

recursive-bound-eval.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

recursive-coroutine-boxed.rs

allow method calls on opaques

2025-09-26 16:33:15 +02:00

recursive-coroutine-indirect.current.stderr

…

recursive-coroutine-indirect.next.stderr

…

recursive-coroutine-indirect.rs

…

recursive-ice-101862.rs

…

recursive-ice-101862.stderr

…

recursive-impl-trait-type-direct.rs

…

recursive-impl-trait-type-indirect.rs

…

recursive-impl-trait-type-indirect.stderr

…

recursive-impl-trait-type-through-non-recursive.rs

…

recursive-impl-trait-type-through-non-recursive.stderr

…

recursive-in-exhaustiveness.current.stderr

support non-defining uses in HIR typeck

2025-08-25 14:20:18 +02:00

recursive-in-exhaustiveness.next.stderr

pass sub_relations into canonical queries

2025-09-08 14:17:56 +02:00

recursive-in-exhaustiveness.rs

support non-defining uses in HIR typeck

2025-08-25 14:20:18 +02:00

recursive-parent-trait-method-call.rs

…

recursive-type-alias-impl-trait-declaration-too-subtle-2.rs

…

recursive-type-alias-impl-trait-declaration-too-subtle.rs

…

recursive-type-alias-impl-trait-declaration-too-subtle.stderr

…

recursive-type-alias-impl-trait-declaration.rs

…

recursive-type-alias-impl-trait-declaration.stderr

When more than a single impl and less than 4 could apply, point at them

2025-10-31 20:44:01 +00:00

region-escape-via-bound-contravariant-closure.rs

…

region-escape-via-bound-contravariant.rs

…

region-escape-via-bound.rs

…

region-escape-via-bound.stderr

…

return-position-impl-trait-minimal.rs

…

reveal-during-codegen.rs

…

rpit-assoc-pair-with-lifetime.rs

Reword mismatched-lifetime-syntaxes text based on feedback

2025-07-14 09:52:58 -04:00

rpit-assoc-pair-with-lifetime.stderr

Use unnamed lifetime spans as primary spans for MISMATCHED_LIFETIME_SYNTAXES

2025-08-23 22:11:43 +00:00

rpit-not-sized.rs

…

rpit-not-sized.stderr

…

stashed-diag-issue-121504.rs

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

stashed-diag-issue-121504.stderr

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

static-lifetime-return-position-impl-trait.rs

…

static-return-lifetime-infered.rs

…

static-return-lifetime-infered.stderr

…

stranded-opaque.rs

…

stranded-opaque.stderr

…

struct-field-fragment-in-name.rs

…

suggest-calling-rpit-closure.rs

…

suggest-calling-rpit-closure.stderr

…

trait_resolution.rs

…

trait_type.rs

…

trait_type.stderr

…

trait_upcasting_reference_mismatch.rs

…

trait_upcasting_reference_mismatch.stderr

…

trait_upcasting.rs

…

two_tait_defining_each_other2.current.stderr

…

two_tait_defining_each_other2.next.stderr

add tests, silence type annotations needed errors for opaques

2025-09-18 12:58:39 +02:00

two_tait_defining_each_other2.rs

add tests, silence type annotations needed errors for opaques

2025-09-18 12:58:39 +02:00

two_tait_defining_each_other3.current.stderr

…

two_tait_defining_each_other3.rs

…

two_tait_defining_each_other.current.stderr

…

two_tait_defining_each_other.rs

…

type_parameters_captured.rs

…

type_parameters_captured.stderr

…

type-alias-generic-param.rs

…

type-alias-generic-param.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

type-alias-impl-trait-in-fn-body.rs

…

type-alias-impl-trait-in-fn-body.stderr

…

type-arg-mismatch-due-to-impl-trait.rs

…

type-arg-mismatch-due-to-impl-trait.stderr

…

unactionable_diagnostic.fixed

…

unactionable_diagnostic.rs

…

unactionable_diagnostic.stderr

…

universal_hrtb_anon.rs

…

universal_hrtb_named.rs

…

universal_in_adt_in_parameters.rs

…

universal_in_impl_trait_in_parameters.rs

…

universal_in_trait_defn_parameters.rs

…

universal_multiple_bounds.rs

…

universal_wrong_bounds.rs

…

universal_wrong_bounds.stderr

…

universal_wrong_hrtb.rs

…

universal_wrong_hrtb.stderr

…

universal-mismatched-type.rs

…

universal-mismatched-type.stderr

…

universal-two-impl-traits.rs

…

universal-two-impl-traits.stderr

…

unsafety-checking-cycle.rs

…

unsize_adt.rs

…

unsize_slice.rs

…

unsize-cast-validation-rpit.rs

…

unsized_coercion2.old.stderr

…

unsized_coercion2.rs

…

unsized_coercion3.next.stderr

When more than a single impl and less than 4 could apply, point at them

2025-10-31 20:44:01 +00:00

unsized_coercion3.old.stderr

…

unsized_coercion3.rs

…

unsized_coercion4.rs

…

unsized_coercion5.old.stderr

…

unsized_coercion5.rs

…

unsized_coercion.next.stderr

…

unsized_coercion.rs

…

upvar_captures.rs

…

upvar_captures.stderr

…

variance.e2024.stderr

…

variance.old.stderr

…

variance.rs

…

wf-check-hidden-type.rs

…

wf-check-hidden-type.stderr

diagnostics :3

2025-08-20 11:10:38 +02:00

wf-eval-order.rs

…

where-allowed-2.rs

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

where-allowed-2.stderr

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

where-allowed.rs

Gate 2018 UI tests

2025-11-27 14:13:58 -05:00

where-allowed.stderr

add write_box_via_move intrinsic and use it for vec!

2026-02-16 17:27:40 +01:00

xcrate_simple.rs

…

xcrate.rs

…