Dylan DPC b22559f547 Rollup merge of #103346 - HeroicKatora:metadata_of_const_pointer_argument, r=dtolnay ...

Adjust argument type for mutable with_metadata_of (#75091)

The method takes two pointer arguments: one `self` supplying the pointer value, and a second pointer supplying the metadata.

The new parameter type more clearly reflects the actual requirements. The provenance of the metadata parameter is disregarded completely. Using a mutable pointer in the call site can be coerced to a const pointer while the reverse is not true.

In some cases, the current parameter type can thus lead to a very slightly confusing additional cast. [Example](https://github.com/HeroicKatora/static-alloc/commit/cad93775eb9adc62f744651e3abf19513e69e7d0).

```rust
// Manually taking an unsized object from a `ManuallyDrop` into another allocation.
let val: &core::mem::ManuallyDrop<T> = …;

let ptr = val as *const _ as *mut T;
let ptr = uninit.as_ptr().with_metadata_of(ptr);
```

This could then instead be simplified to:

```rust
// Manually taking an unsized object from a `ManuallyDrop` into another allocation.
let val: &core::mem::ManuallyDrop<T> = …;

let ptr = uninit.as_ptr().with_metadata_of(&**val);
```

Tracking issue: https://github.com/rust-lang/rust/issues/75091

``@dtolnay`` you're reviewed #95249, would you mind chiming in?

2022-10-22 16:28:09 +05:30

..

benches

Stabilize map_first_last

2022-09-30 17:00:07 +02:00

src

Rollup merge of #103346 - HeroicKatora:metadata_of_const_pointer_argument, r=dtolnay

2022-10-22 16:28:09 +05:30

tests

Add regression test for lifetimes in alloc internals autotraits

2022-10-05 12:15:17 -07:00

Cargo.toml

Switch all libraries to the 2021 edition

2021-12-23 19:03:47 +08:00