Matthias Krüger 15a8b490ea Rollup merge of #123841 - Kohei316:remove_qualifier_sugg, r=wesleywiser ...

Improve diagnostic by suggesting to remove visibility qualifier

Resolves #123529
This PR improve diagnostic by suggesting to remove visibility qualifier.

2024-04-12 17:41:35 +02:00

..

auxiliary

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

pub-priv-dep

Fixed the private-dependency bug: If the directly dependent crate is loaded last and is not configured with --extern, it may be incorrectly set to private-dependency

2024-03-20 16:33:50 +08:00

restricted

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

sealed-traits

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

associated-item-privacy-inherent.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

associated-item-privacy-inherent.stderr

…

associated-item-privacy-trait.rs

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

associated-item-privacy-trait.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

associated-item-privacy-type-binding.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

associated-item-privacy-type-binding.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

crate-private-reexport.rs

…

crate-private-reexport.stderr

…

ctor.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

decl-macro-infinite-global-import-cycle-ice-64784.rs

add issue numbers via // issue: rust-lang/rust#ISSUE_NUM directive

2024-03-24 09:34:11 +01:00

decl-macro.rs

…

decl-macro.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

effective_visibilities_full_priv.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

effective_visibilities_full_priv.stderr

Add a note to duplicate diagnostics

2023-10-05 01:04:41 +00:00

effective_visibilities_glob.rs

…

effective_visibilities_glob.stderr

…

effective_visibilities_invariants.rs

…

effective_visibilities_invariants.stderr

When displaying multispans, ignore empty lines adjacent to ...

2024-03-18 16:25:36 +00:00

effective_visibilities.rs

…

effective_visibilities.stderr

Add a note to duplicate diagnostics

2023-10-05 01:04:41 +00:00

export-tag-variant.rs

…

export-tag-variant.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

generic_struct_field_projection.rs

Only inspect user-written predicates for privacy concerns

2024-04-04 14:43:44 +00:00

impl-privacy-xc-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

import-list-stem-visibility-issue-119126.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-11593.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-11593.stderr

Move some tests

2024-02-09 15:43:08 -03:00

issue-13641.rs

…

issue-13641.stderr

…

issue-17718-const-privacy.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-17718-const-privacy.stderr

…

issue-29161.rs

…

issue-29161.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

issue-30079.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

issue-30079.stderr

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

issue-46209-private-enum-variant-reexport.rs

use visibility to check unused imports and delete some stmts

2023-10-22 21:27:46 +08:00

issue-46209-private-enum-variant-reexport.stderr

vis note for no pub reexports glob import

2023-12-01 12:10:07 +08:00

issue-57264-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-57264-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-75062-fieldless-tuple-struct.rs

…

issue-75062-fieldless-tuple-struct.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-75906.rs

…

issue-75906.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-75907_b.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-75907_b.stderr

…

issue-75907.rs

…

issue-75907.stderr

…

issue-79593.rs

…

issue-79593.stderr

Tweak message on ADT with private fields building

2023-11-29 18:11:57 +00:00

issue-92755.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-111220-2-tuple-struct-fields-projection.rs

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-111220-2-tuple-struct-fields-projection.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-111220-tuple-struct-fields.rs

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-111220-tuple-struct-fields.stderr

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-113860-1.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860-1.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

issue-113860-2.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860-2.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

issue-113860.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

issue-117997.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-119463.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-119463.stderr

fallback visibility for unexpected trait item

2024-01-04 02:02:57 +08:00

legacy-ctor-visibility.rs

…

legacy-ctor-visibility.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

macro-private-reexport.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

macro-private-reexport.stderr

…

priv-impl-prim-ty.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

priv-in-bad-locations.rs

…

priv-in-bad-locations.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

privacy1-rpass.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy1.rs

…

privacy1.stderr

Add a note to duplicate diagnostics

2023-10-05 01:04:41 +00:00

privacy2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy2.stderr

Structured use suggestion on privacy error

2023-12-04 22:26:08 +00:00

privacy3.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy3.stderr

typeck in parallel

2023-07-11 17:52:43 +08:00

privacy4.rs

…

privacy4.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

privacy5.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy5.stderr

…

privacy-in-paths.rs

…

privacy-in-paths.stderr

Tweak privacy errors to account for reachable items

2023-06-22 16:50:31 +00:00

privacy-ns1.rs

…

privacy-ns1.stderr

…

privacy-ns2.rs

…

privacy-ns2.stderr

…

privacy-ns.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy-reexport.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy-sanity.rs

…

privacy-sanity.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

privacy-ufcs.rs

…

privacy-ufcs.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-bounds-locally-allowed.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-class-field.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-field-ty-err.rs

…

private-field-ty-err.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-impl-method.rs

…

private-impl-method.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-in-public-assoc-ty.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-assoc-ty.stderr

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-expr-pat.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-in-public-ill-formed.rs

…

private-in-public-ill-formed.stderr

…

private-in-public-non-principal-2.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-non-principal-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-in-public-non-principal.rs

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

private-in-public-non-principal.stderr

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

private-in-public-type-alias-impl-trait.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-in-public-warn.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-warn.stderr

Extend impl's def_span to include where clauses

2023-10-09 11:47:02 +00:00

private-in-public.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-in-public.stderr

privacy: visit trait def id of projections

2023-12-08 14:26:03 +00:00

private-inferred-type-1.rs

Private-in-public lints implementation

2023-06-12 01:02:19 +03:00

private-inferred-type-1.stderr

Private-in-public lints implementation

2023-06-12 01:02:19 +03:00

private-inferred-type-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-inferred-type-2.stderr

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-inferred-type-3.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-inferred-type-3.stderr

…

private-inferred-type.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-inferred-type.stderr

…

private-item-simple.rs

…

private-item-simple.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-cross-crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-method-cross-crate.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-inherited.rs

…

private-method-inherited.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-rpass.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-method.rs

…

private-method.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field-cross-crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-struct-field-cross-crate.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field-ctor.rs

…

private-struct-field-ctor.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field-pattern.rs

…

private-struct-field-pattern.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field.rs

…

private-struct-field.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-type-in-interface.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-type-in-interface.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

private-variant-reexport.rs

use visibility to check unused imports and delete some stmts

2023-10-22 21:27:46 +08:00

private-variant-reexport.stderr

vis note for no pub reexports glob import

2023-12-01 12:10:07 +08:00

projections2.rs

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections2.stderr

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections.rs

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections.stderr

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

pub_use_mods_xcrate_exe.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

pub-extern-privacy.rs

Update test directives for wasm32-wasip1

2024-03-11 09:36:35 -07:00

pub-use-xcrate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

reachable-unnameable-items.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

struct-field-type.rs

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

struct-field-type.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

suggest-box-new.rs

Suggest builder functions on struct literal with private fields

2023-11-19 17:50:47 +00:00

suggest-box-new.stderr

Tweak message on ADT with private fields building

2023-11-29 18:11:57 +00:00

suggest-making-field-public.fixed

Allow unused fields in some tests

2024-03-12 10:59:41 +01:00

suggest-making-field-public.rs

Allow unused fields in some tests

2024-03-12 10:59:41 +01:00

suggest-making-field-public.stderr

…

union-field-privacy-1.rs

…

union-field-privacy-1.stderr

…

union-field-privacy-2.rs

…

union-field-privacy-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

unnameable_types.rs

privacy: Stabilize lint unnameable_types

2024-03-13 18:37:40 +03:00

unnameable_types.stderr

privacy: Stabilize lint unnameable_types

2024-03-13 18:37:40 +03:00

unreachable-issue-121455.rs

Allow for a missing adt_def in NamePrivacyVisitor.

2024-02-23 10:57:11 +11:00

unreachable-issue-121455.stderr

Allow for a missing adt_def in NamePrivacyVisitor.

2024-02-23 10:57:11 +11:00

unresolved-trait-impl-item.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unresolved-trait-impl-item.stderr

resolve: Feed visibilities for unresolved trait impl items

2023-12-19 22:33:26 +03:00

useless-pub.rs

…

useless-pub.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

where-priv-type.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

where-priv-type.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

where-pub-type-impls-priv-trait.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

where-pub-type-impls-priv-trait.stderr

Extend impl's def_span to include where clauses

2023-10-09 11:47:02 +00:00

xc-private-method2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

xc-private-method2.stderr

…

xc-private-method.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

xc-private-method.stderr

…