Guillaume Gomez a5945b5d8d Rollup merge of #121669 - nnethercote:count-stashed-errs-again, r=estebank ...

Count stashed errors again

Stashed diagnostics are such a pain. Their "might be emitted, might not" semantics messes with lots of things.

#120828 and #121206 made some big changes to how they work, improving some things, but still leaving some problems, as seen by the issues caused by #121206. This PR aims to fix all of them by restricting them in a way that eliminates the "might be emitted, might not" semantics while still allowing 98% of their benefit. Details in the individual commit logs.

r? `@oli-obk`

2024-02-29 17:08:38 +01:00

..

json

Rename many DiagCtxt and EarlyDiagCtxt locals.

2023-12-18 16:06:22 +11:00

markdown

apply fmt

2024-01-11 15:04:48 +03:00

annotate_snippet_emitter_writer.rs

Rename SubDiagnostic as Subdiag.

2024-02-28 08:33:25 +11:00

codes.rs

Stop using String for error codes.

2024-01-29 07:41:41 +11:00

diagnostic_impls.rs

Rename DiagnosticSymbolList as DiagSymbolList.

2024-02-28 08:55:37 +11:00

diagnostic.rs

Rollup merge of #121669 - nnethercote:count-stashed-errs-again, r=estebank

2024-02-29 17:08:38 +01:00

emitter.rs

Rename DiagnosticLocation as DiagLocation.

2024-02-28 08:55:37 +11:00

error.rs

Make translate_message return result and add tests

2023-01-08 23:35:43 +01:00

json.rs

Rename SubDiagnostic as Subdiag.

2024-02-28 08:33:25 +11:00

lib.rs

Rollup merge of #121669 - nnethercote:count-stashed-errs-again, r=estebank

2024-02-29 17:08:38 +01:00

lock.rs

windows bump to 0.52

2024-02-18 16:02:16 +03:00

registry.rs

Stop using String for error codes.

2024-01-29 07:41:41 +11:00

snippet.rs

Rework StringPart.

2024-02-01 19:23:01 +11:00

styled_buffer.rs

Replace some _ == _ || _ == _s with matches!(_, _ | _)s

2023-01-30 12:26:26 +00:00

tests.rs

Format all the let chains in compiler

2023-10-13 08:59:36 +00:00

translation.rs

Rename DiagnosticArg{,Map,Name,Value} as DiagArg{,Map,Name,Value}.

2024-02-28 08:55:37 +11:00