Jacob Pratt 402748551a Rollup merge of #154595 - mu001999-contrib:fix/154539, r=BoxyUwU ...

Emit fatal on invalid const args with nested defs

Fixed https://github.com/rust-lang/rust/issues/123629
Fixes https://github.com/rust-lang/rust/issues/154539

Invalid const args are rejected, so their surrounding HIR is not preserved. But nested defs inside them can still get created, leaving children lowered without a valid HIR parent and causing an ICE when later error handling walks HIR parents.

r? @BoxyUwU

2026-04-16 01:54:05 -04:00

..

assoc_const_unification

MGCA: Support tuple expressions as direct const arguments

2026-01-07 08:44:23 +08:00

auxiliary

Allow provisional mgca syntax of type const <IDENT> = <EXPR> to be reconized.

2026-02-09 07:59:24 -08:00

const_kind_expr

stabilize gai

2025-06-11 15:30:15 +01:00

abstract-const-as-cast-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

abstract-const-as-cast-2.fixed

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

abstract-const-as-cast-2.rs

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

abstract-const-as-cast-2.stderr

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

abstract-const-as-cast-3.rs

compiletest: Stricter parsing for diagnostic kinds

2025-04-07 19:13:31 +03:00

abstract-const-as-cast-3.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

abstract-const-as-cast-4.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

abstract-consts-as-cast-5.rs

…

abstract-consts-as-cast-5.stderr

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

adt_wf_hang.rs

Tweak wording of E0275 WF errors

2026-03-29 18:25:55 +00:00

adt_wf_hang.stderr

Tweak wording of E0275 WF errors

2026-03-29 18:25:55 +00:00

array-size-in-generic-struct-param.full.stderr

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

array-size-in-generic-struct-param.min.stderr

gate primitives behind min_adt_const_params; change suggestion to min_adt_const_params

2026-04-13 22:26:05 +02:00

array-size-in-generic-struct-param.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

associated-const.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

associated-consts.rs

Revert "Rollup merge of #125572 - mu001999-contrib:dead/enhance, r=pnkfelix"

2024-08-03 07:57:31 -04:00

bad-defaults-for-generic-param-in-binder-123629.rs

Emit fatal on defaults for generic params in binders if with nested defs

2026-04-15 21:41:19 +08:00

bad-defaults-for-generic-param-in-binder-123629.stderr

Emit fatal on defaults for generic params in binders if with nested defs

2026-04-15 21:41:19 +08:00

bad-multiply.rs

Stop being so bail-y in candidate assembly

2024-11-21 01:35:34 +00:00

bad-multiply.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

cannot-convert-refree-ice-114463.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

cannot-convert-refree-ice-114463.stderr

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

closures.rs

…

closures.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

const_eval_resolve_canonical.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

const-block-is-poly.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

const-block-is-poly.stderr

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

const-generics-closure.rs

Add regression test for #127424

2025-04-12 22:16:08 +09:00

const-generics-closure.stderr

Add regression test for #127424

2025-04-12 22:16:08 +09:00

convert-refree-region-vid-ice-114464.rs

add test for #114464

2024-03-24 10:09:56 +01:00

convert-refree-region-vid-ice-114464.stderr

add test for #114464

2024-03-24 10:09:56 +01:00

cross_crate_predicate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

cross_crate_predicate.stderr

Set groundwork for proper const normalization

2025-05-01 20:05:02 +01:00

cross_crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

cross-crate-2.rs

Fix tests

2025-05-21 20:20:19 +01:00

dependence_lint.full.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

dependence_lint.gce.stderr

Fix tests

2025-05-21 20:20:19 +01:00

dependence_lint.rs

Fix tests

2025-05-21 20:20:19 +01:00

different-fn.rs

…

different-fn.stderr

Fix tests

2025-05-21 20:20:19 +01:00

division.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

dont-eagerly-error-in-is-const-evaluatable.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

double-opaque-parent-predicates.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

drop_impl.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

dyn-compatibility-err-ret.rs

Do not try to confirm non-dyn compatible method

2025-05-23 12:20:35 +00:00

dyn-compatibility-err-ret.stderr

Do not try to confirm non-dyn compatible method

2025-05-23 12:20:35 +00:00

dyn-compatibility-err-where-bounds.rs

Do not try to confirm non-dyn compatible method

2025-05-23 12:20:35 +00:00

dyn-compatibility-err-where-bounds.stderr

Do not try to confirm non-dyn compatible method

2025-05-23 12:20:35 +00:00

dyn-compatibility-ok-infer-err.rs

Revert "Auto merge of #151380 - ShoyuVanilla:shallow-resolve-to-root-var, r=lcnr"

2026-03-24 22:31:37 +09:00

dyn-compatibility-ok-infer-err.stderr

Revert "Auto merge of #151380 - ShoyuVanilla:shallow-resolve-to-root-var, r=lcnr"

2026-03-24 22:31:37 +09:00

dyn-compatibility-ok.rs

UI tests: Rename "object safe" to "dyn compatible"

2024-10-10 01:13:29 +02:00

elaborate-trait-pred.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

error_in_ty.rs

Bless tests and handle tests/crashes

2024-06-05 22:25:42 +01:00

error_in_ty.stderr

gate primitives behind min_adt_const_params; change suggestion to min_adt_const_params

2026-04-13 22:26:05 +02:00

escaping-late-bound-region-in-canonical-ice-113870.rs

Add a regression test for an escaping late-bound region ICE during canonicalisation

2026-04-03 17:30:54 +01:00

escaping-late-bound-region-in-canonical-ice-113870.stderr

Add a regression test for an escaping late-bound region ICE during canonicalisation

2026-04-03 17:30:54 +01:00

eval-privacy.rs

Bless tests and handle tests/crashes

2024-06-05 22:25:42 +01:00

eval-privacy.stderr

Bless tests and handle tests/crashes

2024-06-05 22:25:42 +01:00

eval-try-unify.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

evaluated-to-ambig.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

expected-type-of-closure-body-to-be-a-closure-or-coroutine-ice-113776.rs

Remove a bunch of diagnostic stashing that doesn't do anything

2025-01-11 19:22:06 +00:00

expected-type-of-closure-body-to-be-a-closure-or-coroutine-ice-113776.stderr

Merge E0412 into E0425

2025-12-02 18:25:13 +00:00

failed-to-normalize-ice-issue-88421.rs

add issue numbers via // issue: rust-lang/rust#ISSUE_NUM directive

2024-03-24 09:34:11 +01:00

failed-to-resolve-instance-ice-111667.rs

add test for ICE failed to resolve instance for <[f32; 2] as CrossProduct

2024-04-28 10:23:10 +02:00

feature-attribute-missing-in-dependent-crate-ice.rs

Use more principled check for generics in const ops

2026-01-01 18:12:34 -08:00

feature-attribute-missing-in-dependent-crate-ice.stderr

Add a regression test for an ICE with the generic_const_exprs feature attribute.

2025-07-29 09:35:36 +02:00

feature-gate-generic_const_exprs.rs

…

feature-gate-generic_const_exprs.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

fn_call.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

from-sig-fail.rs

Use the informative error as the main const eval error message

2025-06-02 15:37:15 +00:00

from-sig-fail.stderr

Clarify why we are talking about a failed const eval at a random place

2025-06-02 15:37:15 +00:00

from-sig.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

function-call.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

function-call.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

ice-generics_of-no-entry-found-for-key-113017.rs

address review comments

2024-03-22 11:35:31 +01:00

ice-generics_of-no-entry-found-for-key-113017.stderr

address review comments

2024-03-22 11:35:31 +01:00

ice-predicates-of-no-entry-found-for-key-119275.rs

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

ice-predicates-of-no-entry-found-for-key-119275.stderr

Unify wording of resolve error

2026-02-17 16:51:44 +00:00

ice-wrapper-impl-trait-with-const-bound-118278.rs

Add a regression test for an ICE when using impl Trait with a const generic bound

2026-04-03 17:31:00 +01:00

impl-bounds.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

infer-too-generic.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

inline-const-in-const-generic-defaults.rs

Fix tests and bless

2024-04-24 13:12:33 +01:00

issue-62504.full.stderr

fallout :skull_emoji:

2025-02-14 00:37:23 +01:00

issue-62504.min.stderr

fallout :skull_emoji:

2025-02-14 00:37:23 +01:00

issue-62504.rs

Taint infcx when reporting errors

2024-06-19 04:41:56 +00:00

issue-69654.rs

Make messages more generic

2026-03-28 16:18:11 +09:00

issue-69654.stderr

Make messages more generic

2026-03-28 16:18:11 +09:00

issue-72787.min.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

issue-72787.rs

compiletest: Stricter parsing for diagnostic kinds

2025-04-07 19:13:31 +03:00

issue-72819-generic-in-const-eval.full.stderr

Specify what 'this' actually is

2023-02-21 05:21:07 +00:00

issue-72819-generic-in-const-eval.min.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

issue-72819-generic-in-const-eval.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-73298.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-73899.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-74634.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-74713.rs

improve diagnostics and bless tests

2023-05-05 21:42:54 +01:00

issue-74713.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

issue-76595.rs

…

issue-76595.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-79518-default_trait_method_normalization.rs

compiletest: Stricter parsing for diagnostic kinds

2025-04-07 19:13:31 +03:00

issue-79518-default_trait_method_normalization.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-80561-incorrect-param-env.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-80742.rs

Make messages more generic

2026-03-28 16:18:11 +09:00

issue-80742.stderr

Make messages more generic

2026-03-28 16:18:11 +09:00

issue-82268.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-83765.rs

…

issue-83765.stderr

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

issue-83972.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-84408.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-84669.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-85848.rs

…

issue-85848.stderr

Remove detail from label/note that is already available in other note

2024-10-29 16:26:57 +00:00

issue-86710.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-89851.rs

Split part of adt_const_params into unsized_const_params

2024-07-17 11:01:29 +01:00

issue-90847.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-94293.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-96699.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-97047-ice-1.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

issue-97047-ice-2.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

issue-99647.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-99705.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-100217.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-100360.rs

Split part of adt_const_params into unsized_const_params

2024-07-17 11:01:29 +01:00

issue-102074.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-102768.rs

Do not emit solver errors that contain error types

2025-10-31 08:17:44 +00:00

issue-102768.stderr

Do not emit solver errors that contain error types

2025-10-31 08:17:44 +00:00

issue-105257.rs

modify error comment and bless test, delete tests/ui/const-generics/generic_const_exprs/lit_type_mismatch.rs

2026-02-14 04:12:46 +00:00

issue-105257.stderr

Provide more context on type errors in const context

2026-03-14 20:13:43 +00:00

issue-105608.rs

…

issue-105608.stderr

Point turbofish inference errors at the uninferred generic arg

2026-03-13 07:29:05 -04:00

issue-109141.rs

Normalize unevaluated consts in GCE

2024-09-20 20:24:22 -04:00

issue-109141.stderr

Normalize unevaluated consts in GCE

2024-09-20 20:24:22 -04:00

less_than.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

let-bindings.rs

…

let-bindings.stderr

Properly pluralize 'generic constants'

2023-01-16 20:21:29 +00:00

mismatched-gat-subst-kind.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

mismatched-gat-subst-kind.stderr

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

needs_where_clause.rs

…

needs_where_clause.stderr

Provide structured suggestion for unconstrained generic constant

2024-03-21 00:03:59 +00:00

negative-coherence-ice-140609.rs

instantiate predicate binder without recanonicalizing goal in new solver

2025-10-20 10:31:08 +02:00

nested_uneval_unification-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

nested_uneval_unification-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

nested-abstract-consts-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

nested-abstract-consts-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

no_dependence.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

no_where_clause.rs

WF-check struct field types at construction site

2024-08-05 17:37:12 -07:00

no_where_clause.stderr

WF-check struct field types at construction site

2024-08-05 17:37:12 -07:00

no-entry-found-for-key-ice-gce-nlb-113133.rs

Just totally fully deny late-bound consts

2024-07-20 19:45:24 -04:00

no-entry-found-for-key-ice-gce-nlb-113133.stderr

Just totally fully deny late-bound consts

2024-07-20 19:45:24 -04:00

non_local_anon_const_diagnostics.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

non_local_anon_const_diagnostics.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

non-local-const.rs

MGCA: require #[type_const] on free consts too

2026-02-06 15:35:18 +01:00

non-local-const.stderr

MGCA: require #[type_const] on free consts too

2026-02-06 15:35:18 +01:00

normed_to_param_is_evaluatable.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

obligation-cause.rs

…

obligation-cause.stderr

Deduplicate more sized errors on call exprs

2024-01-24 02:53:15 +00:00

opaque_type.rs

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

opaque_type.stderr

Provide more context on type errors in const context

2026-03-14 20:13:43 +00:00

poly-const-uneval-ice-106423.rs

stabilize gai

2025-06-11 15:30:15 +01:00

post-analysis-user-facing-param-env.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

post-analysis-user-facing-param-env.stderr

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

serializing_error_guaranteed.rs

Fix tests

2025-05-21 20:20:19 +01:00

simple_fail.rs

Use the informative error as the main const eval error message

2025-06-02 15:37:15 +00:00

simple_fail.stderr

Clarify why we are talking about a failed const eval at a random place

2025-06-02 15:37:15 +00:00

single-satisfied-ConstEvaluatable-in-probe.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

size_of-dyn-trait-2.rs

Replace NullOp::SizeOf and NullOp::AlignOf by lang items.

2025-10-23 00:38:28 +00:00

size_of-dyn-trait-2.stderr

Replace NullOp::SizeOf and NullOp::AlignOf by lang items.

2025-10-23 00:38:28 +00:00

size_of-dyn-trait-3.rs

Make messages more generic

2026-03-28 16:18:11 +09:00

size_of-dyn-trait-3.stderr

Make messages more generic

2026-03-28 16:18:11 +09:00

size_of-dyn-trait.rs

Replace NullOp::SizeOf and NullOp::AlignOf by lang items.

2025-10-23 00:38:28 +00:00

size_of-dyn-trait.stderr

Replace NullOp::SizeOf and NullOp::AlignOf by lang items.

2025-10-23 00:38:28 +00:00

specialization-fuzzing-ice-133639.rs

allow incomplete_features in more tests

2026-03-23 20:08:24 +00:00

subexprs_are_const_evalutable.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

trivial-anon-const-use-cases.full.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

trivial-anon-const-use-cases.min.stderr

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

trivial-anon-const-use-cases.rs

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording

2025-06-07 13:01:16 +02:00

ty-alias-substitution.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

type_mismatch.rs

Re-enable ConstArgKind::Path lowering by default

2024-09-12 13:56:01 -04:00

type_mismatch.stderr

Unconditionally run check_item_type on all items

2025-06-30 08:06:08 +00:00

type-alias-bounds.neg.stderr

Consider parent predicates in ImpossiblePredicates pass.

2025-07-20 22:45:07 +00:00

type-alias-bounds.rs

Consider parent predicates in ImpossiblePredicates pass.

2025-07-20 22:45:07 +00:00

unevaluated-const-ice-119731.rs

const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns

2025-06-26 18:09:47 +02:00

unevaluated-const-ice-119731.stderr

gate primitives behind min_adt_const_params; change suggestion to min_adt_const_params

2026-04-13 22:26:05 +02:00

unknown-alias-defkind-anonconst-ice-116710.rs

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

unknown-alias-defkind-anonconst-ice-116710.stderr

stabilize -Znext-solver=coherence

2024-10-15 13:11:00 +02:00

unop.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unresolved_lifetimes_error.rs

improve diagnostics and bless tests

2023-05-05 21:42:54 +01:00

unresolved_lifetimes_error.stderr

Make missing lifetime suggestion verbose

2025-06-24 18:59:42 +00:00

unused_expr.rs

…

unused_expr.stderr

Properly pluralize 'generic constants'

2023-01-16 20:21:29 +00:00

unused-complex-default-expr.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00