Nicholas Nethercote 8a9b38fd3b Avoid &format("...") calls in error message code. ...

Error message all end up passing into a function as an `impl
Into<{D,Subd}iagnosticMessage>`. If an error message is creatd as
`&format("...")` that means we allocate a string (in the `format!`
call), then take a reference, and then clone (allocating again) the
reference to produce the `{D,Subd}iagnosticMessage`, which is silly.

This commit removes the leading `&` from a lot of these cases. This
means the original `String` is moved into the
`{D,Subd}iagnosticMessage`, avoiding the double allocations. This
requires changing some function argument types from `&str` to `String`
(when all arguments are `String`) or `impl
Into<{D,Subd}iagnosticMessage>` (when some arguments are `String` and
some are `&str`).

2023-05-16 17:59:56 +10:00

..

abi

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

debuginfo

Merge commit 'dec0daa8f6d0a0e1c702f169abb6bf3eee198c67' into sync_cg_clif-2023-03-15

2023-03-15 14:41:48 +00:00

driver

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

intrinsics

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

optimize

Merge commit '598f0909568a51de8a2d1148f55a644fd8dffad0' into sync_cg_clif-2023-01-24

2023-01-24 18:56:42 +01:00

allocator.rs

Revert "Remove #[alloc_error_handler] from the compiler and library"

2023-04-25 00:08:35 +02:00

analyze.rs

Split {Idx, IndexVec, IndexSlice} into their own modules

2023-04-24 13:53:35 +00:00

archive.rs

Rewrite LLVM's archive writer in Rust

2022-11-26 19:35:32 +00:00

base.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

cast.rs

Merge commit 'ef07e8e60f994ec014d049a95591426fb92ebb79' into sync_cg_clif-2023-04-29

2023-04-29 12:00:43 +00:00

codegen_i128.rs

Merge commit 'ef07e8e60f994ec014d049a95591426fb92ebb79' into sync_cg_clif-2023-04-29

2023-04-29 12:00:43 +00:00

common.rs

use EarlyBinder in tcx.(try_)subst_mir_and_normalize_erasing_regions

2023-05-06 22:32:39 -06:00

compiler_builtins.rs

Merge commit 'dec0daa8f6d0a0e1c702f169abb6bf3eee198c67' into sync_cg_clif-2023-03-15

2023-03-15 14:41:48 +00:00

concurrency_limiter.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

config.rs

Merge commit '7d53619064ab7045c383644cb445052d2a3d46db' into sync_cg_clif-2023-02-09

2023-02-09 12:38:16 +01:00

constant.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

discriminant.rs

Remove from cranelift too.

2023-04-14 16:26:11 +00:00

global_asm.rs

Merge commit 'ef07e8e60f994ec014d049a95591426fb92ebb79' into sync_cg_clif-2023-04-29

2023-04-29 12:00:43 +00:00

inline_asm.rs

Merge commit 'dec0daa8f6d0a0e1c702f169abb6bf3eee198c67' into sync_cg_clif-2023-03-15

2023-03-15 14:41:48 +00:00

lib.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

linkage.rs

Sync rustc_codegen_cranelift 'ddd4ce25535cf71203ba3700896131ce55fde795'

2021-04-30 14:49:58 +02:00

main_shim.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

num.rs

Merge commit 'ef07e8e60f994ec014d049a95591426fb92ebb79' into sync_cg_clif-2023-04-29

2023-04-29 12:00:43 +00:00

pointer.rs

Merge commit 'dec0daa8f6d0a0e1c702f169abb6bf3eee198c67' into sync_cg_clif-2023-03-15

2023-03-15 14:41:48 +00:00

pretty_clif.rs

Avoid &format("...") calls in error message code.

2023-05-16 17:59:56 +10:00

toolchain.rs

Merge commit 'e9d1a0a7b0b28dd422f1a790ccde532acafbf193' into sync_cg_clif-2022-08-24

2022-08-24 18:40:58 +02:00

trap.rs

Merge commit 'e9d1a0a7b0b28dd422f1a790ccde532acafbf193' into sync_cg_clif-2022-08-24

2022-08-24 18:40:58 +02:00

unsize.rs

Move mir::Field → abi::FieldIdx

2023-03-28 22:22:37 -07:00

value_and_place.rs

Restrict From<S> for {D,Subd}iagnosticMessage.

2023-05-03 08:44:39 +10:00

vtable.rs

Move mir::Field → abi::FieldIdx

2023-03-28 22:22:37 -07:00