bors 85e08cd3b9 Auto merge of #12169 - GuillaumeGomez:unnecessary_result_map_or_else, r=llogiq ...

Add new `unnecessary_result_map_or_else` lint

Fixes https://github.com/rust-lang/rust-clippy/issues/7328.

r? `@llogiq`

changelog: Add new `unnecessary_result_map_or_else` lint

2024-01-27 12:42:18 +00:00

..

bind_instead_of_map.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

bytecount.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

bytes_count_to_len.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

bytes_nth.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

case_sensitive_file_extension_comparisons.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

chars_cmp_with_unwrap.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

chars_cmp.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

chars_last_cmp_with_unwrap.rs

Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup

2022-11-21 20:51:52 +01:00

chars_last_cmp.rs

Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup

2022-11-21 20:51:52 +01:00

chars_next_cmp_with_unwrap.rs

Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup

2022-11-21 20:51:52 +01:00

chars_next_cmp.rs

Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup

2022-11-21 20:51:52 +01:00

clear_with_drain.rs

Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup

2023-04-11 15:31:08 +02:00

clone_on_copy.rs

Appease the clippy

2023-11-25 18:02:11 +00:00

clone_on_ref_ptr.rs

Add more diagnostic items for clippy

2023-10-05 18:21:47 -04:00

cloned_instead_of_copied.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

collapsible_str_replace.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

drain_collect.rs

Rustdoc and Clippy stop misusing Key for Ty -> (adt) DefId

2024-01-08 20:30:10 +00:00

err_expect.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

expect_fun_call.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

extend_with_drain.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

filetype_is_file.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

filter_map_bool_then.rs

rustc: hir().local_def_id_to_hir_id() -> tcx.local_def_id_to_hir_id() cleanup

2023-11-26 12:41:21 +03:00

filter_map_identity.rs

Minimize pub usage in source_map.rs.

2023-11-02 19:35:00 +11:00

filter_map_next.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

filter_map.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

filter_next.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

flat_map_identity.rs

Minimize pub usage in source_map.rs.

2023-11-02 19:35:00 +11:00

flat_map_option.rs

Minimize pub usage in source_map.rs.

2023-11-02 19:35:00 +11:00

format_collect.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

from_iter_instead_of_collect.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

get_first.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

get_last_with_len.rs

Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup

2022-10-06 09:44:38 +02:00

get_unwrap.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

implicit_clone.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

inefficient_to_string.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

inspect_for_each.rs

Minimize pub usage in source_map.rs.

2023-11-02 19:35:00 +11:00

into_iter_on_ref.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

is_digit_ascii_radix.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

iter_cloned_collect.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

iter_count.rs

Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup

2022-10-06 09:44:38 +02:00

iter_filter.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

iter_kv_map.rs

Fix clippy's usage of Body's coroutine_kind

2023-12-25 21:13:41 +00:00

iter_next_slice.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

iter_nth_zero.rs

Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup

2023-07-02 14:59:02 +02:00

iter_nth.rs

Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup

2023-07-02 14:59:02 +02:00

iter_on_single_or_empty_collections.rs

Use std_or_core instead of doing check by hand every time

2024-01-15 20:53:00 +01:00

iter_out_of_bounds.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

iter_overeager_cloned.rs

Address unused tuple struct fields in clippy

2024-01-01 17:47:54 -05:00

iter_skip_next.rs

Move some methods from tcx.hir() to tcx

2023-12-12 06:40:29 -08:00

iter_skip_zero.rs

Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup

2023-07-31 23:53:53 +02:00

iter_with_drain.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

iterator_step_by_zero.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

join_absolute_paths.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

manual_is_variant_and.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

manual_next_back.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

manual_ok_or.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

manual_saturating_arithmetic.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

manual_str_repeat.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

manual_try_fold.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

map_clone.rs

Fix suggestion for map_clone on types implementing Copy

2024-01-11 17:44:07 +01:00

map_collect_result_unit.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

map_err_ignore.rs

refactor(rustc_middle): Substs -> GenericArg

2023-07-14 13:27:35 +01:00

map_flatten.rs

rename bound region instantiation

2023-11-17 09:29:48 +00:00

map_identity.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

map_unwrap_or.rs

Add new unnecessary_result_map_or_else lint

2024-01-23 16:12:30 +01:00

mod.rs

Auto merge of #12169 - GuillaumeGomez:unnecessary_result_map_or_else, r=llogiq

2024-01-27 12:42:18 +00:00

mut_mutex_lock.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

needless_collect.rs

Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync

2023-12-01 18:21:58 +01:00

needless_option_as_deref.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

needless_option_take.rs

Merge commit '7c21f91b15b7604f818565646b686d90f99d1baf' into clippyup

2022-05-05 15:12:52 +01:00

no_effect_replace.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

obfuscated_if_else.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

ok_expect.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

open_options.rs

fix false positive in suspicious_open_options, make paths work

2024-01-15 17:15:09 +00:00

option_as_ref_cloned.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

option_as_ref_deref.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

option_map_or_err_ok.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

option_map_or_none.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

option_map_unwrap_or.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

or_fun_call.rs

Fix clippy

2024-01-17 10:02:32 +00:00

or_then_unwrap.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

path_buf_push_overwrite.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

path_ends_with_ext.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

range_zip_with_len.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

read_line_without_trim.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

readonly_write_lock.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

redundant_as_str.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

repeat_once.rs

Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup

2023-05-20 15:39:26 +02:00

result_map_or_else_none.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

search_is_some.rs

Improve help message for search_is_some lint

2024-01-12 22:48:30 +01:00

seek_from_current.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

seek_to_start_instead_of_rewind.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

single_char_add_str.rs

separate the receiver from arguments in HIR under /clippy

2022-09-05 22:25:57 +09:00

single_char_insert_string.rs

Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup

2022-10-06 09:44:38 +02:00

single_char_pattern.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

single_char_push_string.rs

Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup

2022-10-06 09:44:38 +02:00

skip_while_next.rs

Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup

2021-04-08 17:50:13 +02:00

stable_sort_primitive.rs

refactor(rustc_middle): Substs -> GenericArg

2023-07-14 13:27:35 +01:00

str_split.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

str_splitn.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

string_extend_chars.rs

Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup

2023-07-17 10:22:32 +02:00

string_lit_chars_any.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

suspicious_command_arg_space.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

suspicious_map.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

suspicious_splitn.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

suspicious_to_owned.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

type_id_on_box.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

uninit_assumed_init.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

unit_hash.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

unnecessary_fallible_conversions.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

unnecessary_filter_map.rs

Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup

2023-07-31 23:53:53 +02:00

unnecessary_fold.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

unnecessary_iter_cloned.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00

unnecessary_join.rs

Improve wording for suggestion messages

2024-01-20 16:47:08 +01:00

unnecessary_lazy_eval.rs

Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup

2023-12-16 14:12:50 +01:00

unnecessary_literal_unwrap.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

unnecessary_result_map_or_else.rs

Add new unnecessary_result_map_or_else lint

2024-01-23 16:12:30 +01:00

unnecessary_sort_by.rs

Correctly suggest std or core path depending if this is a no_std crate

2024-01-14 14:45:24 +01:00

unnecessary_to_owned.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

unwrap_expect_used.rs

Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup

2023-08-11 14:05:13 +02:00

useless_asref.rs

lint on .map(|&x| x.clone())

2024-01-13 17:46:46 +01:00

utils.rs

Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'

2024-01-11 17:27:03 +01:00

vec_resize_to_zero.rs

Pack the u128 in LitKind::Int

2024-01-19 20:10:39 -08:00

verbose_file_reads.rs

Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup

2022-08-31 09:24:45 -04:00

waker_clone_wake.rs

Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup

2023-11-02 17:35:56 +01:00

wrong_self_convention.rs

Minimize pub usage in source_map.rs.

2023-11-02 19:35:00 +11:00

zst_offset.rs

Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup

2023-11-16 19:13:24 +01:00