janwi_mac d02b4c8e77 Improve suggestions for unconstrained parameters in impl blocks ...

When an unconstrained type or lifetime parameter is detected in an
`impl`, provide more specific help based on its usage:
- If the parameter is entirely unused, suggest removing it.
- If it is used in the `impl` body but not the `Self` type, suggest
  including it in the `Self` type and the struct definition.

This also adds a comprehensive UI test for these cases.

2026-05-09 17:50:35 +12:00

..

auxiliary

Rehome tests/ui/issues/ tests [1/?]

2025-07-24 17:01:44 -04:00

autobind.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

bad-mid-path-type-params.rs

…

bad-mid-path-type-params.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

box-missing-generics-14092.rs

comments

2025-08-05 19:34:46 +05:00

box-missing-generics-14092.stderr

comments

2025-08-05 19:34:46 +05:00

default-type-params-well-formedness.rs

cleaned up some tests

2025-06-23 18:53:56 +05:00

empty-generic-brackets-equiv.rs

cleaned up some tests

2025-06-11 17:49:03 +05:00

empty-generic-brackets-equiv.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

enum-definition-with-outer-generic-parameter-5997.rs

Add test batch 1

2025-08-27 00:23:26 -04:00

enum-definition-with-outer-generic-parameter-5997.stderr

Add note to E0401

2025-11-03 16:24:36 +00:00

export-name-on-generics.fixed

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

export-name-on-generics.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

export-name-on-generics.stderr

Remove hir::AssocItemKind.

2025-07-13 13:50:00 +00:00

foreign-generic-mismatch.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

foreign-generic-mismatch.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

generic-alias-unique.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-arg-mismatch-recover.rs

…

generic-arg-mismatch-recover.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

generic-associated-type-deref-target-56237.rs

Add test batch 3

2025-09-12 14:45:12 -04:00

generic-default-type-params-cross-crate.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-default-type-params.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-derived-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-enum-errors.rs

cleaned up some tests

2025-07-13 00:03:31 +05:00

generic-enum-errors.stderr

cleaned up some tests

2025-07-13 00:03:31 +05:00

generic-exterior-unique.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-extern-lifetime.rs

…

generic-extern-lifetime.stderr

Make missing lifetime suggestion verbose

2025-06-24 18:59:42 +00:00

generic-extern-mangle.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-extern.rs

Fortify generic param default checks

2025-08-06 01:26:26 +02:00

generic-extern.stderr

Fortify generic param default checks

2025-08-06 01:26:26 +02:00

generic-fn-infer.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-fn-twice.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-fn-unique.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-fn.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-function-item-where-type.rs

Automatically taint when reporting errors from ItemCtxt

2024-07-09 07:44:17 +00:00

generic-function-item-where-type.stderr

Automatically taint when reporting errors from ItemCtxt

2024-07-09 07:44:17 +00:00

generic-higher-ranked-lifetime-issue-122714.rs

Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.

2024-05-20 20:28:57 +08:00

generic-higher-ranked-lifetime-issue-122714.stderr

Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.

2024-05-20 20:28:57 +08:00

generic-impl-less-params-with-defaults.rs

…

generic-impl-less-params-with-defaults.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

generic-impl-method-match-autoderef-18514.rs

Rehome tests/ui/issues/ tests [1/?]

2025-07-24 17:01:44 -04:00

generic-impl-method-params-2311.rs

filename changes

2026-01-21 13:44:01 +00:00

generic-impl-more-params-with-defaults.rs

…

generic-impl-more-params-with-defaults.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

generic-ivec-leak.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-lifetime-trait-impl.rs

…

generic-lifetime-trait-impl.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

generic-newtype-struct.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-no-mangle.fixed

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

generic-no-mangle.rs

Replace elided_named_lifetimes with mismatched_lifetime_syntaxes

2025-06-04 10:40:04 -04:00

generic-no-mangle.stderr

Remove hir::AssocItemKind.

2025-07-13 13:50:00 +00:00

generic-non-trailing-defaults.rs

Disentangle ForwardGenericParamBan and ConstParamTy ribs

2025-03-12 16:56:26 +00:00

generic-non-trailing-defaults.stderr

Disentangle ForwardGenericParamBan and ConstParamTy ribs

2025-03-12 16:56:26 +00:00

generic-object.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-param-attrs.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-params-nested-fn-scope-error.rs

cleaned up some tests

2025-07-01 15:29:29 +05:00

generic-params-nested-fn-scope-error.stderr

Add note to E0401

2025-11-03 16:24:36 +00:00

generic-recursive-tag.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-static-methods.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-struct-self-unconstrained-inference-vars-69306.rs

Add test batch 4

2025-10-11 21:59:51 -04:00

generic-struct-self-unconstrained-inference-vars-69306.stderr

Provide more context on type errors in const context

2026-03-14 20:13:43 +00:00

generic-tag-corruption.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-tag-local.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-tag-match.rs

Remove some unnecessary parens in assert! conditions

2025-02-06 22:28:44 +00:00

generic-tag-values.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-tag.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-temporary.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-trait-method-params-2311.rs

filename changes

2026-01-21 13:44:01 +00:00

generic-tup.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-type-less-params-with-defaults.rs

Test generic arg suggestion inside nested item

2024-03-17 23:40:12 +00:00

generic-type-less-params-with-defaults.stderr

Test generic arg suggestion inside nested item

2024-03-17 23:40:12 +00:00

generic-type-more-params-with-defaults.rs

…

generic-type-more-params-with-defaults.stderr

Revert suggestion verbosity change

2024-07-22 22:51:53 +00:00

generic-type-params-forward-mention.rs

Disentangle ForwardGenericParamBan and ConstParamTy ribs

2025-03-12 16:56:26 +00:00

generic-type-params-forward-mention.stderr

Disentangle ForwardGenericParamBan and ConstParamTy ribs

2025-03-12 16:56:26 +00:00

generic-type-params-name-repr.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

generic-type-params-name-repr.stderr

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

generic-type-synonym.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

generic-type.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generic-unique.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

generics-on-self-mod-segment.rs

Store resolution for self and crate root module segments

2024-11-20 18:57:02 +00:00

generics-on-self-mod-segment.stderr

Store resolution for self and crate root module segments

2024-11-20 18:57:02 +00:00

impl-block-params-declared-in-wrong-spot-issue-113073.rs

Update Tests

2024-06-05 20:08:00 -04:00

impl-block-params-declared-in-wrong-spot-issue-113073.stderr

Make missing lifetime suggestion verbose

2025-06-24 18:59:42 +00:00

invalid-type-param-default.rs

Fortify generic param default checks

2025-08-06 01:26:26 +02:00

invalid-type-param-default.stderr

Use more accurate span in resolve_ident_in_lexical_scope

2025-11-03 16:24:35 +00:00

issue-333.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-1112.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-2936.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-32498.rs

Replace NullOp::SizeOf and NullOp::AlignOf by lang items.

2025-10-23 00:38:28 +00:00

issue-59508-1.rs

…

issue-59508-1.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-59508.fixed

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-59508.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-59508.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-61631-default-type-param-can-reference-self-in-trait.rs

…

issue-61631-default-type-param-can-reference-self-in-trait.stderr

On E0277 be clearer about implicit Sized bounds on type params and assoc types

2024-02-01 03:30:26 +00:00

issue-61631-default-type-param-cannot-reference-self.rs

…

issue-61631-default-type-param-cannot-reference-self.stderr

Disentangle ForwardGenericParamBan and ConstParamTy ribs

2025-03-12 16:56:26 +00:00

issue-65285-incorrect-explicit-lifetime-name-needed.rs

…

issue-65285-incorrect-explicit-lifetime-name-needed.stderr

…

issue-79605.rs

…

issue-79605.stderr

Bless and add tests

2025-01-23 06:01:36 +00:00

issue-80512-param-reordering-with-defaults.rs

…

issue-80512-param-reordering-with-defaults.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-83556.rs

…

issue-83556.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-94432-garbage-ice.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-94923.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-95208-ignore-qself.fixed

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-95208-ignore-qself.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-95208-ignore-qself.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-95208.fixed

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-95208.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-95208.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-98432.rs

…

issue-98432.stderr

Add note to E0401

2025-11-03 16:24:36 +00:00

issue-106694.rs

…

issue-106694.stderr

…

lifetime-before-type-params.rs

…

lifetime-before-type-params.stderr

…

mid-path-type-params.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

missing-param-but-has-colon-144215.rs

add enum to address lifetime with colon problem

2025-11-02 15:31:46 +00:00

missing-param-but-has-colon-144215.stderr

add enum to address lifetime with colon problem

2025-11-02 15:31:46 +00:00

newtype-with-generics.rs

cleaned up some tests

2025-06-30 11:50:19 +05:00

overlapping-errors-span-issue-123861.rs

Fortify generic param default checks

2025-08-06 01:26:26 +02:00

overlapping-errors-span-issue-123861.stderr

bless tests with new lint messages

2025-08-19 21:27:10 +02:00

param-in-ct-in-ty-param-default.rs

…

param-in-ct-in-ty-param-default.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

post_monomorphization_error_backtrace.rs

Use the informative error as the main const eval error message

2025-06-02 15:37:15 +00:00

post_monomorphization_error_backtrace.stderr

Revert "Rollup merge of #122661 - estebank:assert-macro-span, r=petrochenkov"

2025-09-11 09:10:46 +08:00

resolve-generic-method-param-2312.rs

filename changes

2026-01-21 13:44:01 +00:00

single-colon-path-not-const-generics.rs

…

single-colon-path-not-const-generics.stderr

Revert overzealous parse recovery for single colons

2025-04-24 02:57:10 +02:00

slightly-nice-generic-literal-messages.rs

compiletest: Make diagnostic kind mandatory on line annotations

2025-04-30 10:44:24 +03:00

slightly-nice-generic-literal-messages.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

trait-incorrect-generic-args.rs

cleaned up some tests

2025-07-05 01:54:04 +05:00

trait-incorrect-generic-args.stderr

cleaned up some tests

2025-07-05 01:54:04 +05:00

type-args-on-module-in-bound.rs

cleaned up some tests

2026-01-16 06:50:34 +09:00

type-args-on-module-in-bound.stderr

cleaned up some tests

2026-01-16 06:50:34 +09:00

type-params-in-for-each.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

unclosed-generics-in-impl-def.rs

Tweak unclosed generics errors

2023-12-01 20:01:39 +00:00

unclosed-generics-in-impl-def.stderr

Tweak unclosed generics errors

2023-12-01 20:01:39 +00:00

unconstrained-param-default-available.rs

Improve suggestions for unconstrained parameters in impl blocks

2026-05-09 17:50:35 +12:00

unconstrained-param-default-available.stderr

Improve suggestions for unconstrained parameters in impl blocks

2026-05-09 17:50:35 +12:00

unconstrained-type-params-inherent-impl.rs

cleaned up some tests

2025-06-28 16:24:17 +05:00

unconstrained-type-params-inherent-impl.stderr

Improve suggestions for unconstrained parameters in impl blocks

2026-05-09 17:50:35 +12:00

unconstrained-used-param.rs

Improve suggestions for unconstrained parameters in impl blocks

2026-05-09 17:50:35 +12:00

unconstrained-used-param.stderr

Improve suggestions for unconstrained parameters in impl blocks

2026-05-09 17:50:35 +12:00

unnecessary-path-disambiguator-36116.rs

Rehome tests/ui/issues/ tests [2/?]

2025-08-02 15:29:16 -04:00

unused-type-parameter-regression-36075.rs

Rehome tests/ui/issues/ tests [3/?]

2025-08-04 16:43:53 -04:00

wrong-number-of-args-in-macro.rs

check if redundant args spans belong to the same context

2026-01-02 16:01:35 +09:00

wrong-number-of-args-in-macro.stderr

check if redundant args spans belong to the same context

2026-01-02 16:01:35 +09:00

wrong-number-of-args.rs

Add generics info for structs in type info

2026-02-10 13:45:09 +01:00

wrong-number-of-args.stderr

Increase span_look_ahead limit to handle whitespace

2026-04-03 11:28:53 +09:00