Matthias Krüger 7fa99bfb71 Rollup merge of #120556 - fmease:improve-unused-generic-param-diags, r=oli-obk ...

Improve the diagnostics for unused generic parameters

* Don't emit two errors (namely E0091 *and* E0392) for unused type parameters on *lazy* type aliases
* Fix the diagnostic help message of E0392 for *lazy* type aliases: Don't talk about the “fields” of lazy type aliases (use the term “body” instead) and don't suggest `PhantomData` for them, it doesn't make much sense
* Consolidate the diagnostics for E0091 (unused type parameters in type aliases) and E0392 (unused generic parameters due to bivariance) and make it translatable
  * Still keep the error codes distinct (for now)
  * Naturally leads to better diagnostics for E0091

r? ```@oli-obk``` (to ballast your review load :P) or compiler

2024-02-04 19:42:12 +01:00

..

auxiliary

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-56445-1.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-56445-1.min.stderr

make adt_const_params feature suggestion more consistent with others and only suggest it when the type can probably work

2023-09-28 23:10:04 +00:00

issue-56445-1.rs

improve diagnostics and bless tests

2023-05-05 21:42:54 +01:00

issue-56445-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-56445-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-56445-3.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-56445-3.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-60818-struct-constructors.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-61336-1.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-61336-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-61336-2.stderr

Remove extra # from url

2024-01-24 00:41:45 +01:00

issue-61336.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-61336.stderr

Remove extra # from url

2024-01-24 00:41:45 +01:00

issue-61422.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-61432.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-62187-encountered-polymorphic-const.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-62878.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-62878.min.stderr

make adt_const_params feature suggestion more consistent with others and only suggest it when the type can probably work

2023-09-28 23:10:04 +00:00

issue-62878.rs

defer array len printing to const arg printing

2023-01-18 04:07:39 +00:00

issue-63322-forbid-dyn.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-63322-forbid-dyn.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-63322-forbid-dyn.rs

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-64519.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-66596-impl-trait-for-str-const-arg.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-66906.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67185-1.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67185-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67185-2.stderr

Provide more context on derived obligation error primary label

2024-01-30 21:28:18 +00:00

issue-67375.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67375.min.stderr

Improve the diagnostics for unused generic parameters

2024-02-01 16:18:03 +01:00

issue-67375.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67739.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67739.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67739.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67945-1.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67945-1.min.stderr

Improve the diagnostics for unused generic parameters

2024-02-01 16:18:03 +01:00

issue-67945-1.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67945-2.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67945-2.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67945-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67945-3.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67945-3.min.stderr

Improve the diagnostics for unused generic parameters

2024-02-01 16:18:03 +01:00

issue-67945-3.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-67945-4.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-67945-4.min.stderr

Improve the diagnostics for unused generic parameters

2024-02-01 16:18:03 +01:00

issue-67945-4.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68104-print-stack-overflow.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68366.full.stderr

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68366.min.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

issue-68366.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68596.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68615-adt.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-68615-adt.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-68615-array.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-68615-array.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-69654-run-pass.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70125-1.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70125-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70167.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70180-1-stalled_on.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70180-2-stalled_on.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70225.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-70273-assoc-fn.rs

Adjust UI tests for unit_bindings

2023-06-12 20:24:48 +08:00

issue-71169.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-71169.min.stderr

make adt_const_params feature suggestion more consistent with others and only suggest it when the type can probably work

2023-09-28 23:10:04 +00:00

issue-71169.rs

defer array len printing to const arg printing

2023-01-18 04:07:39 +00:00

issue-71202.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-71202.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-71381.full.stderr

Silence follow up errors if astconv already errored

2024-01-11 09:03:26 +00:00

issue-71381.min.stderr

Silence follow up errors if astconv already errored

2024-01-11 09:03:26 +00:00

issue-71381.rs

Silence follow up errors if astconv already errored

2024-01-11 09:03:26 +00:00

issue-71382.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-71382.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-71382.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-71547.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-71611.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-71611.min.stderr

Silence follow up errors if astconv already errored

2024-01-11 09:03:26 +00:00

issue-71611.rs

Silence follow up errors if astconv already errored

2024-01-11 09:03:26 +00:00

issue-71986.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72352.full.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-72352.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-72352.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72845.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-72845.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-73120.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-73260.rs

Remove save-analysis.

2023-02-16 15:14:45 +11:00

issue-73260.stderr

Specify what 'this' actually is

2023-02-21 05:21:07 +00:00

issue-73491.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-73491.rs

defer array len printing to const arg printing

2023-01-18 04:07:39 +00:00

issue-73727-static-reference-array-const-param.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-73727-static-reference-array-const-param.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-74101.min.stderr

make adt_const_params feature suggestion more consistent with others and only suggest it when the type can probably work

2023-09-28 23:10:04 +00:00

issue-74101.rs

defer array len printing to const arg printing

2023-01-18 04:07:39 +00:00

issue-74255.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-74255.rs

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-74906.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-74950.min.stderr

remove StructuralEq trait

2024-01-24 07:56:23 +01:00

issue-74950.rs

remove StructuralEq trait

2024-01-24 07:56:23 +01:00

issue-75047.min.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-75047.rs

defer array len printing to const arg printing

2023-01-18 04:07:39 +00:00

issue-75299.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-76701-ty-param-in-const.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-76701-ty-param-in-const.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

issue-79674.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-79674.stderr

Deduplicate more sized errors on call exprs

2024-01-24 02:53:15 +00:00

issue-80062.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-80062.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

issue-80375.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-80375.stderr

generic_const_exprs: suggest to add the feature, not use it

2023-11-30 20:59:51 +01:00

issue-82956.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-82956.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-83249.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-83249.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-83288.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-83466.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-83466.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-83765.rs

Reorder check_item_type diagnostics so they occur next to the corresponding check_well_formed diagnostics

2024-01-02 14:17:56 +00:00

issue-83765.stderr

Reorder check_item_type diagnostics so they occur next to the corresponding check_well_formed diagnostics

2024-01-02 14:17:56 +00:00

issue-84659.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-84659.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-85031-2.rs

Fix known-bug, silence ICE stderr

2023-01-19 20:20:58 +00:00

issue-85031-2.stderr

Fix known-bug, silence ICE stderr

2023-01-19 20:20:58 +00:00

issue-86033.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-86530.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-86530.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-86535-2.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-86535.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-86820.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-86820.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-87076.rs

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-87470.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-87493.rs

diagnostics: remove inconsistent English article "this" from E0107

2023-02-23 10:27:06 -07:00

issue-87493.stderr

diagnostics: remove inconsistent English article "this" from E0107

2023-02-23 10:27:06 -07:00

issue-87964.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-88119.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-88468.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-88997.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-88997.stderr

improve diagnostics and bless tests

2023-05-05 21:42:54 +01:00

issue-89146.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-89304.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-89320.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-89334.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-90318.rs

Constify TypeId ordering impls

2023-01-16 21:26:03 +01:00

issue-90318.stderr

Constify TypeId ordering impls

2023-01-16 21:26:03 +01:00

issue-90364.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-90364.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-90455.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-90455.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-92186.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-96654.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-97278.rs

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-97278.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-97634.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-98629.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-98629.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-99641.rs

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-99641.stderr

Implement custom diagnostic for ConstParamTy

2023-06-01 18:21:42 +00:00

issue-100313.rs

Adjust some tests for invalid_reference_casting improvements

2023-07-29 12:20:59 +02:00

issue-100313.stderr

Normalize alloc-id in tests.

2023-10-16 16:29:35 +00:00

issue-105037.rs

Move /src/test to /tests

2023-01-11 09:32:08 +00:00

issue-105821.rs

Stabilize const_ptr_read

2023-05-05 20:36:21 +02:00