mirror of
https://github.com/rust-lang/rust.git
synced 2026-04-27 18:57:42 +03:00
c5b9918540
The end goal being to completely remove `AttributeLint`.
530 lines
21 KiB
Rust
530 lines
21 KiB
Rust
use std::convert::identity;
|
|
|
|
use rustc_ast as ast;
|
|
use rustc_ast::token::DocFragmentKind;
|
|
use rustc_ast::{AttrItemKind, AttrStyle, NodeId, Safety};
|
|
use rustc_data_structures::sync::{DynSend, DynSync};
|
|
use rustc_errors::{Diag, DiagCtxtHandle, Level, MultiSpan};
|
|
use rustc_feature::{AttributeTemplate, Features};
|
|
use rustc_hir::attrs::AttributeKind;
|
|
use rustc_hir::lints::AttributeLintKind;
|
|
use rustc_hir::{AttrArgs, AttrItem, AttrPath, Attribute, HashIgnoredAttrId, Target};
|
|
use rustc_session::Session;
|
|
use rustc_session::lint::LintId;
|
|
use rustc_span::{DUMMY_SP, Span, Symbol, sym};
|
|
|
|
use crate::attributes::AttributeSafety;
|
|
use crate::context::{AcceptContext, FinalizeContext, FinalizeFn, SharedContext, Stage};
|
|
use crate::early_parsed::{EARLY_PARSED_ATTRIBUTES, EarlyParsedState};
|
|
use crate::parser::{AllowExprMetavar, ArgParser, PathParser, RefPathParser};
|
|
use crate::session_diagnostics::ParsedDescription;
|
|
use crate::{Early, Late, OmitDoc, ShouldEmit};
|
|
|
|
pub enum EmitAttribute {
|
|
Static(AttributeLintKind),
|
|
Dynamic(
|
|
Box<
|
|
dyn for<'a> Fn(DiagCtxtHandle<'a>, Level) -> Diag<'a, ()> + DynSend + DynSync + 'static,
|
|
>,
|
|
),
|
|
}
|
|
|
|
/// Context created once, for example as part of the ast lowering
|
|
/// context, through which all attributes can be lowered.
|
|
pub struct AttributeParser<'sess, S: Stage = Late> {
|
|
pub(crate) tools: Vec<Symbol>,
|
|
pub(crate) features: Option<&'sess Features>,
|
|
pub(crate) sess: &'sess Session,
|
|
pub(crate) stage: S,
|
|
|
|
/// *Only* parse attributes with this symbol.
|
|
///
|
|
/// Used in cases where we want the lowering infrastructure for parse just a single attribute.
|
|
parse_only: Option<&'static [Symbol]>,
|
|
}
|
|
|
|
impl<'sess> AttributeParser<'sess, Early> {
|
|
/// This method allows you to parse attributes *before* you have access to features or tools.
|
|
/// One example where this is necessary, is to parse `feature` attributes themselves for
|
|
/// example.
|
|
///
|
|
/// Try to use this as little as possible. Attributes *should* be lowered during
|
|
/// `rustc_ast_lowering`. Some attributes require access to features to parse, which would
|
|
/// crash if you tried to do so through [`parse_limited`](Self::parse_limited).
|
|
///
|
|
/// To make sure use is limited, supply a `Symbol` you'd like to parse. Only attributes with
|
|
/// that symbol are picked out of the list of instructions and parsed. Those are returned.
|
|
///
|
|
/// No diagnostics will be emitted when parsing limited. Lints are not emitted at all, while
|
|
/// errors will be emitted as a delayed bugs. in other words, we *expect* attributes parsed
|
|
/// with `parse_limited` to be reparsed later during ast lowering where we *do* emit the errors
|
|
pub fn parse_limited(
|
|
sess: &'sess Session,
|
|
attrs: &[ast::Attribute],
|
|
sym: &'static [Symbol],
|
|
target_span: Span,
|
|
target_node_id: NodeId,
|
|
features: Option<&'sess Features>,
|
|
) -> Option<Attribute> {
|
|
Self::parse_limited_should_emit(
|
|
sess,
|
|
attrs,
|
|
sym,
|
|
target_span,
|
|
target_node_id,
|
|
Target::Crate, // Does not matter, we're not going to emit errors anyways
|
|
features,
|
|
ShouldEmit::Nothing,
|
|
)
|
|
}
|
|
|
|
/// This does the same as `parse_limited`, except it has a `should_emit` parameter which allows it to emit errors.
|
|
/// Usually you want `parse_limited`, which emits no errors.
|
|
pub fn parse_limited_should_emit(
|
|
sess: &'sess Session,
|
|
attrs: &[ast::Attribute],
|
|
sym: &'static [Symbol],
|
|
target_span: Span,
|
|
target_node_id: NodeId,
|
|
target: Target,
|
|
features: Option<&'sess Features>,
|
|
should_emit: ShouldEmit,
|
|
) -> Option<Attribute> {
|
|
let mut parsed = Self::parse_limited_all(
|
|
sess,
|
|
attrs,
|
|
Some(sym),
|
|
target,
|
|
target_span,
|
|
target_node_id,
|
|
features,
|
|
should_emit,
|
|
);
|
|
assert!(parsed.len() <= 1);
|
|
parsed.pop()
|
|
}
|
|
|
|
/// This method allows you to parse a list of attributes *before* `rustc_ast_lowering`.
|
|
/// This can be used for attributes that would be removed before `rustc_ast_lowering`, such as attributes on macro calls.
|
|
///
|
|
/// Try to use this as little as possible. Attributes *should* be lowered during
|
|
/// `rustc_ast_lowering`. Some attributes require access to features to parse, which would
|
|
/// crash if you tried to do so through [`parse_limited_all`](Self::parse_limited_all).
|
|
/// Therefore, if `parse_only` is None, then features *must* be provided.
|
|
pub fn parse_limited_all(
|
|
sess: &'sess Session,
|
|
attrs: &[ast::Attribute],
|
|
parse_only: Option<&'static [Symbol]>,
|
|
target: Target,
|
|
target_span: Span,
|
|
target_node_id: NodeId,
|
|
features: Option<&'sess Features>,
|
|
emit_errors: ShouldEmit,
|
|
) -> Vec<Attribute> {
|
|
let mut p =
|
|
Self { features, tools: Vec::new(), parse_only, sess, stage: Early { emit_errors } };
|
|
p.parse_attribute_list(
|
|
attrs,
|
|
target_span,
|
|
target,
|
|
OmitDoc::Skip,
|
|
std::convert::identity,
|
|
|lint_id, span, kind| match kind {
|
|
EmitAttribute::Static(kind) => {
|
|
sess.psess.buffer_lint(lint_id.lint, span, target_node_id, kind)
|
|
}
|
|
EmitAttribute::Dynamic(callback) => {
|
|
sess.psess.dyn_buffer_lint(lint_id.lint, span, target_node_id, callback)
|
|
}
|
|
},
|
|
)
|
|
}
|
|
|
|
/// This method parses a single attribute, using `parse_fn`.
|
|
/// This is useful if you already know what exact attribute this is, and want to parse it.
|
|
pub fn parse_single<T>(
|
|
sess: &'sess Session,
|
|
attr: &ast::Attribute,
|
|
target_span: Span,
|
|
target_node_id: NodeId,
|
|
target: Target,
|
|
features: Option<&'sess Features>,
|
|
emit_errors: ShouldEmit,
|
|
parse_fn: fn(cx: &mut AcceptContext<'_, '_, Early>, item: &ArgParser) -> Option<T>,
|
|
template: &AttributeTemplate,
|
|
allow_expr_metavar: AllowExprMetavar,
|
|
expected_safety: AttributeSafety,
|
|
) -> Option<T> {
|
|
let ast::AttrKind::Normal(normal_attr) = &attr.kind else {
|
|
panic!("parse_single called on a doc attr")
|
|
};
|
|
let parts =
|
|
normal_attr.item.path.segments.iter().map(|seg| seg.ident.name).collect::<Vec<_>>();
|
|
|
|
let path = AttrPath::from_ast(&normal_attr.item.path, identity);
|
|
let args = ArgParser::from_attr_args(
|
|
&normal_attr.item.args.unparsed_ref().unwrap(),
|
|
&parts,
|
|
&sess.psess,
|
|
emit_errors,
|
|
allow_expr_metavar,
|
|
)?;
|
|
Self::parse_single_args(
|
|
sess,
|
|
attr.span,
|
|
normal_attr.item.span(),
|
|
attr.style,
|
|
path,
|
|
Some(normal_attr.item.unsafety),
|
|
expected_safety,
|
|
ParsedDescription::Attribute,
|
|
target_span,
|
|
target_node_id,
|
|
target,
|
|
features,
|
|
emit_errors,
|
|
&args,
|
|
parse_fn,
|
|
template,
|
|
)
|
|
}
|
|
|
|
/// This method is equivalent to `parse_single`, but parses arguments using `parse_fn` using manually created `args`.
|
|
/// This is useful when you want to parse other things than attributes using attribute parsers.
|
|
pub fn parse_single_args<T, I>(
|
|
sess: &'sess Session,
|
|
attr_span: Span,
|
|
inner_span: Span,
|
|
attr_style: AttrStyle,
|
|
attr_path: AttrPath,
|
|
attr_safety: Option<Safety>,
|
|
expected_safety: AttributeSafety,
|
|
parsed_description: ParsedDescription,
|
|
target_span: Span,
|
|
target_node_id: NodeId,
|
|
target: Target,
|
|
features: Option<&'sess Features>,
|
|
emit_errors: ShouldEmit,
|
|
args: &I,
|
|
parse_fn: fn(cx: &mut AcceptContext<'_, '_, Early>, item: &I) -> T,
|
|
template: &AttributeTemplate,
|
|
) -> T {
|
|
let mut parser = Self {
|
|
features,
|
|
tools: Vec::new(),
|
|
parse_only: None,
|
|
sess,
|
|
stage: Early { emit_errors },
|
|
};
|
|
let mut emit_lint = |lint_id: LintId, span: MultiSpan, kind: EmitAttribute| match kind {
|
|
EmitAttribute::Static(kind) => {
|
|
sess.psess.buffer_lint(lint_id.lint, span, target_node_id, kind)
|
|
}
|
|
EmitAttribute::Dynamic(callback) => {
|
|
sess.psess.dyn_buffer_lint(lint_id.lint, span, target_node_id, callback)
|
|
}
|
|
};
|
|
if let Some(safety) = attr_safety {
|
|
parser.check_attribute_safety(
|
|
&attr_path,
|
|
inner_span,
|
|
safety,
|
|
expected_safety,
|
|
&mut emit_lint,
|
|
);
|
|
}
|
|
let mut cx: AcceptContext<'_, 'sess, Early> = AcceptContext {
|
|
shared: SharedContext {
|
|
cx: &mut parser,
|
|
target_span,
|
|
target,
|
|
emit_lint: &mut emit_lint,
|
|
},
|
|
attr_span,
|
|
inner_span,
|
|
attr_style,
|
|
parsed_description,
|
|
template,
|
|
attr_path,
|
|
};
|
|
parse_fn(&mut cx, args)
|
|
}
|
|
}
|
|
|
|
impl<'sess, S: Stage> AttributeParser<'sess, S> {
|
|
pub fn new(
|
|
sess: &'sess Session,
|
|
features: &'sess Features,
|
|
tools: Vec<Symbol>,
|
|
stage: S,
|
|
) -> Self {
|
|
Self { features: Some(features), tools, parse_only: None, sess, stage }
|
|
}
|
|
|
|
pub(crate) fn sess(&self) -> &'sess Session {
|
|
&self.sess
|
|
}
|
|
|
|
pub(crate) fn features(&self) -> &'sess Features {
|
|
self.features.expect("features not available at this point in the compiler")
|
|
}
|
|
|
|
pub(crate) fn features_option(&self) -> Option<&'sess Features> {
|
|
self.features
|
|
}
|
|
|
|
pub(crate) fn dcx(&self) -> DiagCtxtHandle<'sess> {
|
|
self.sess().dcx()
|
|
}
|
|
|
|
/// Parse a list of attributes.
|
|
///
|
|
/// `target_span` is the span of the thing this list of attributes is applied to,
|
|
/// and when `omit_doc` is set, doc attributes are filtered out.
|
|
pub fn parse_attribute_list(
|
|
&mut self,
|
|
attrs: &[ast::Attribute],
|
|
target_span: Span,
|
|
target: Target,
|
|
omit_doc: OmitDoc,
|
|
lower_span: impl Copy + Fn(Span) -> Span,
|
|
mut emit_lint: impl FnMut(LintId, MultiSpan, EmitAttribute),
|
|
) -> Vec<Attribute> {
|
|
let mut attributes = Vec::new();
|
|
// We store the attributes we intend to discard at the end of this function in order to
|
|
// check they are applied to the right target and error out if necessary. In practice, we
|
|
// end up dropping only derive attributes and derive helpers, both being fully processed
|
|
// at macro expansion.
|
|
let mut dropped_attributes = Vec::new();
|
|
let mut attr_paths: Vec<RefPathParser<'_>> = Vec::new();
|
|
let mut early_parsed_state = EarlyParsedState::default();
|
|
|
|
let mut finalizers: Vec<&FinalizeFn<S>> = Vec::with_capacity(attrs.len());
|
|
|
|
for attr in attrs {
|
|
// If we're only looking for a single attribute, skip all the ones we don't care about.
|
|
if let Some(expected) = self.parse_only {
|
|
if !attr.path_matches(expected) {
|
|
continue;
|
|
}
|
|
}
|
|
|
|
// Sometimes, for example for `#![doc = include_str!("readme.md")]`,
|
|
// doc still contains a non-literal. You might say, when we're lowering attributes
|
|
// that's expanded right? But no, sometimes, when parsing attributes on macros,
|
|
// we already use the lowering logic and these are still there. So, when `omit_doc`
|
|
// is set we *also* want to ignore these.
|
|
let is_doc_attribute = attr.has_name(sym::doc);
|
|
if omit_doc == OmitDoc::Skip && is_doc_attribute {
|
|
continue;
|
|
}
|
|
|
|
let attr_span = lower_span(attr.span);
|
|
match &attr.kind {
|
|
ast::AttrKind::DocComment(comment_kind, symbol) => {
|
|
if omit_doc == OmitDoc::Skip {
|
|
continue;
|
|
}
|
|
|
|
attributes.push(Attribute::Parsed(AttributeKind::DocComment {
|
|
style: attr.style,
|
|
kind: DocFragmentKind::Sugared(*comment_kind),
|
|
span: attr_span,
|
|
comment: *symbol,
|
|
}));
|
|
}
|
|
ast::AttrKind::Normal(n) => {
|
|
attr_paths.push(PathParser(&n.item.path));
|
|
let attr_path = AttrPath::from_ast(&n.item.path, lower_span);
|
|
|
|
let args = match &n.item.args {
|
|
AttrItemKind::Unparsed(args) => args,
|
|
AttrItemKind::Parsed(parsed) => {
|
|
early_parsed_state
|
|
.accept_early_parsed_attribute(attr_span, lower_span, parsed);
|
|
continue;
|
|
}
|
|
};
|
|
|
|
let parts =
|
|
n.item.path.segments.iter().map(|seg| seg.ident.name).collect::<Vec<_>>();
|
|
|
|
if let Some(accept) = S::parsers().accepters.get(parts.as_slice()) {
|
|
self.check_attribute_safety(
|
|
&attr_path,
|
|
lower_span(n.item.span()),
|
|
n.item.unsafety,
|
|
accept.safety,
|
|
&mut emit_lint,
|
|
);
|
|
|
|
let Some(args) = ArgParser::from_attr_args(
|
|
args,
|
|
&parts,
|
|
&self.sess.psess,
|
|
self.stage.should_emit(),
|
|
AllowExprMetavar::No,
|
|
) else {
|
|
continue;
|
|
};
|
|
|
|
// Special-case handling for `#[doc = "..."]`: if we go through with
|
|
// `DocParser`, the order of doc comments will be messed up because `///`
|
|
// doc comments are added into `attributes` whereas attributes parsed with
|
|
// `DocParser` are added into `parsed_attributes` which are then appended
|
|
// to `attributes`. So if you have:
|
|
//
|
|
// /// bla
|
|
// #[doc = "a"]
|
|
// /// blob
|
|
//
|
|
// You would get:
|
|
//
|
|
// bla
|
|
// blob
|
|
// a
|
|
if is_doc_attribute
|
|
&& let ArgParser::NameValue(nv) = &args
|
|
// If not a string key/value, it should emit an error, but to make
|
|
// things simpler, it's handled in `DocParser` because it's simpler to
|
|
// emit an error with `AcceptContext`.
|
|
&& let Some(comment) = nv.value_as_str()
|
|
{
|
|
attributes.push(Attribute::Parsed(AttributeKind::DocComment {
|
|
style: attr.style,
|
|
kind: DocFragmentKind::Raw(nv.value_span),
|
|
span: attr_span,
|
|
comment,
|
|
}));
|
|
continue;
|
|
}
|
|
|
|
let mut cx: AcceptContext<'_, 'sess, S> = AcceptContext {
|
|
shared: SharedContext {
|
|
cx: self,
|
|
target_span,
|
|
target,
|
|
emit_lint: &mut emit_lint,
|
|
},
|
|
attr_span,
|
|
inner_span: lower_span(n.item.span()),
|
|
attr_style: attr.style,
|
|
parsed_description: ParsedDescription::Attribute,
|
|
template: &accept.template,
|
|
attr_path: attr_path.clone(),
|
|
};
|
|
|
|
(accept.accept_fn)(&mut cx, &args);
|
|
finalizers.push(&accept.finalizer);
|
|
|
|
if !matches!(cx.stage.should_emit(), ShouldEmit::Nothing) {
|
|
Self::check_target(&accept.allowed_targets, target, &mut cx);
|
|
}
|
|
} else {
|
|
let attr = AttrItem {
|
|
path: attr_path.clone(),
|
|
args: self
|
|
.lower_attr_args(n.item.args.unparsed_ref().unwrap(), lower_span),
|
|
id: HashIgnoredAttrId { attr_id: attr.id },
|
|
style: attr.style,
|
|
span: attr_span,
|
|
};
|
|
|
|
self.check_attribute_safety(
|
|
&attr_path,
|
|
lower_span(n.item.span()),
|
|
n.item.unsafety,
|
|
AttributeSafety::Normal,
|
|
&mut emit_lint,
|
|
);
|
|
|
|
if !matches!(self.stage.should_emit(), ShouldEmit::Nothing)
|
|
&& target == Target::Crate
|
|
{
|
|
self.check_invalid_crate_level_attr_item(&attr, n.item.span());
|
|
}
|
|
|
|
let attr = Attribute::Unparsed(Box::new(attr));
|
|
|
|
if self.tools.contains(&parts[0])
|
|
// FIXME: this can be removed once #152369 has been merged.
|
|
// https://github.com/rust-lang/rust/pull/152369
|
|
|| [sym::allow, sym::deny, sym::expect, sym::forbid, sym::warn]
|
|
.contains(&parts[0])
|
|
{
|
|
attributes.push(attr);
|
|
} else {
|
|
dropped_attributes.push(attr);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
early_parsed_state.finalize_early_parsed_attributes(&mut attributes);
|
|
for f in &finalizers {
|
|
if let Some(attr) = f(&mut FinalizeContext {
|
|
shared: SharedContext { cx: self, target_span, target, emit_lint: &mut emit_lint },
|
|
all_attrs: &attr_paths,
|
|
}) {
|
|
attributes.push(Attribute::Parsed(attr));
|
|
}
|
|
}
|
|
|
|
if !matches!(self.stage.should_emit(), ShouldEmit::Nothing)
|
|
&& target == Target::WherePredicate
|
|
{
|
|
self.check_invalid_where_predicate_attrs(attributes.iter().chain(&dropped_attributes));
|
|
}
|
|
|
|
attributes
|
|
}
|
|
|
|
/// Returns whether there is a parser for an attribute with this name
|
|
pub fn is_parsed_attribute(path: &[Symbol]) -> bool {
|
|
/// The list of attributes that are parsed attributes,
|
|
/// even though they don't have a parser in `Late::parsers()`
|
|
const SPECIAL_ATTRIBUTES: &[&[Symbol]] = &[
|
|
// Cfg attrs are removed after being early-parsed, so don't need to be in the parser list
|
|
&[sym::cfg],
|
|
&[sym::cfg_attr],
|
|
];
|
|
|
|
Late::parsers().accepters.contains_key(path)
|
|
|| EARLY_PARSED_ATTRIBUTES.contains(&path)
|
|
|| SPECIAL_ATTRIBUTES.contains(&path)
|
|
}
|
|
|
|
fn lower_attr_args(&self, args: &ast::AttrArgs, lower_span: impl Fn(Span) -> Span) -> AttrArgs {
|
|
match args {
|
|
ast::AttrArgs::Empty => AttrArgs::Empty,
|
|
ast::AttrArgs::Delimited(args) => AttrArgs::Delimited(args.clone()),
|
|
// This is an inert key-value attribute - it will never be visible to macros
|
|
// after it gets lowered to HIR. Therefore, we can extract literals to handle
|
|
// nonterminals in `#[doc]` (e.g. `#[doc = $e]`).
|
|
ast::AttrArgs::Eq { eq_span, expr } => {
|
|
// In valid code the value always ends up as a single literal. Otherwise, a dummy
|
|
// literal suffices because the error is handled elsewhere.
|
|
let lit = if let ast::ExprKind::Lit(token_lit) = expr.kind
|
|
&& let Ok(lit) =
|
|
ast::MetaItemLit::from_token_lit(token_lit, lower_span(expr.span))
|
|
{
|
|
lit
|
|
} else {
|
|
let guar = self.dcx().span_delayed_bug(
|
|
args.span().unwrap_or(DUMMY_SP),
|
|
"expr in place where literal is expected (builtin attr parsing)",
|
|
);
|
|
ast::MetaItemLit {
|
|
symbol: sym::dummy,
|
|
suffix: None,
|
|
kind: ast::LitKind::Err(guar),
|
|
span: DUMMY_SP,
|
|
}
|
|
};
|
|
AttrArgs::Eq { eq_span: lower_span(*eq_span), expr: lit }
|
|
}
|
|
}
|
|
}
|
|
}
|