Esteban Küber 8f7d61b9ef Detect unconstructable re-exported tuple structs ...

When a tuple-struct is re-exported that has inaccessible fields at the `use` scope, the type's constructor cannot be accessed through that re-export. We now account for this case and extend the resulting resolution error. We also check if the constructor would be accessible directly, not through the re-export, and if so, we suggest using the full path instead.

```
error[E0423]: cannot initialize a tuple struct which contains private fields
  --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:12:33
   |
LL |             let crate::Foo(x) = crate::Foo(42);
   |                                 ^^^^^^^^^^
   |
note: the type is accessed through this re-export, but the type's constructor is not visible in this import's scope due to private fields
  --> $DIR/ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs:3:9
   |
LL | pub use my_mod::Foo;
   |         ^^^^^^^^^^^
help: the type can be constructed directly, because its fields are available from the current scope
   |
LL |             let crate::Foo(x) = crate::my_mod::Foo(42);
   |                                 ~~~~~~~~~~~~~~~~~~
```

Fix #133343.

2025-09-28 21:33:34 +00:00

..

auxiliary

Add test batch 1

2025-08-27 00:23:26 -04:00

pub-priv-dep

tests: cover more exported_private_dependencies cases

2025-07-20 21:11:39 +02:00

restricted

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

sealed-traits

On E0277, point at type that doesn't implement bound

2025-08-22 17:55:15 +00:00

associated-item-privacy-inherent.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

associated-item-privacy-inherent.stderr

…

associated-item-privacy-trait.rs

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

associated-item-privacy-trait.stderr

Use less HIR in check_private_in_public.

2025-07-22 01:40:45 +00:00

associated-item-privacy-type-binding.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

associated-item-privacy-type-binding.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

crate-private-reexport.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

crate-private-reexport.stderr

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

ctor-not-accessible-due-to-inaccessible-field-in-reexport.fixed

Detect unconstructable re-exported tuple structs

2025-09-28 21:33:34 +00:00

ctor-not-accessible-due-to-inaccessible-field-in-reexport.rs

Detect unconstructable re-exported tuple structs

2025-09-28 21:33:34 +00:00

ctor-not-accessible-due-to-inaccessible-field-in-reexport.stderr

Detect unconstructable re-exported tuple structs

2025-09-28 21:33:34 +00:00

ctor.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

decl-macro-infinite-global-import-cycle-ice-64784.rs

add issue numbers via // issue: rust-lang/rust#ISSUE_NUM directive

2024-03-24 09:34:11 +01:00

decl-macro.rs

…

decl-macro.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

deref-separate-compile-unit-6919.rs

Add test batch 1

2025-08-27 00:23:26 -04:00

effective_visibilities_full_priv.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

effective_visibilities_full_priv.stderr

Add a note to duplicate diagnostics

2023-10-05 01:04:41 +00:00

effective_visibilities_glob.rs

…

effective_visibilities_glob.stderr

…

effective_visibilities_invariants.rs

…

effective_visibilities_invariants.stderr

Integrate stable feature checking into a query.

2025-07-17 23:19:12 +00:00

effective_visibilities.rs

resolve: Restore some effective visibility optimizations

2023-03-31 17:07:59 +04:00

effective_visibilities.stderr

Filter empty lines, comments and delimiters from previous to last multiline span rendering

2024-12-12 23:36:27 +00:00

export-tag-variant.rs

…

export-tag-variant.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

generic_struct_field_projection.rs

Only inspect user-written predicates for privacy concerns

2024-04-04 14:43:44 +00:00

impl-privacy-cross-crate-1.rs

Move some tests out of tests/ui

2025-05-03 17:22:52 +02:00

impl-privacy-cross-crate-2.rs

Move some tests out of tests/ui

2025-05-03 17:22:52 +02:00

import-list-stem-visibility-issue-119126.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

inaccessible-fields-pattern-matching-76077.fixed

Rehome tests/ui/issues/ tests [5/?]

2025-08-17 13:01:02 -04:00

inaccessible-fields-pattern-matching-76077.rs

Rehome tests/ui/issues/ tests [5/?]

2025-08-17 13:01:02 -04:00

inaccessible-fields-pattern-matching-76077.stderr

Rehome tests/ui/issues/ tests [5/?]

2025-08-17 13:01:02 -04:00

issue-11593.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-11593.stderr

Move some tests

2024-02-09 15:43:08 -03:00

issue-13641.rs

…

issue-13641.stderr

…

issue-17718-const-privacy.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-17718-const-privacy.stderr

…

issue-29161.rs

Update ui tests involving invalid visibility qualifiers

2023-04-03 22:28:55 -05:00

issue-29161.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

issue-30079.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

issue-30079.stderr

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

issue-46209-private-enum-variant-reexport.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

issue-46209-private-enum-variant-reexport.stderr

Make early lints translatable

2024-05-21 20:16:39 +00:00

issue-57264-1.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-57264-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-75062-fieldless-tuple-struct.rs

…

issue-75062-fieldless-tuple-struct.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-75906.rs

…

issue-75906.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-75907_b.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-75907_b.stderr

…

issue-75907.rs

…

issue-75907.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-79593.rs

…

issue-79593.stderr

Tweak message on ADT with private fields building

2023-11-29 18:11:57 +00:00

issue-92755.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-111220-2-tuple-struct-fields-projection.rs

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-111220-2-tuple-struct-fields-projection.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

issue-111220-tuple-struct-fields.rs

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-111220-tuple-struct-fields.stderr

fix for Self not respecting tuple Ctor privacy

2023-05-26 06:23:03 +00:00

issue-113860-1.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860-1.stderr

Integrate stable feature checking into a query.

2025-07-17 23:19:12 +00:00

issue-113860-2.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860-2.stderr

Integrate stable feature checking into a query.

2025-07-17 23:19:12 +00:00

issue-113860.rs

privacy: no nominal visibility for assoc fns

2023-07-28 14:28:02 +01:00

issue-113860.stderr

Integrate stable feature checking into a query.

2025-07-17 23:19:12 +00:00

issue-117997.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-119463.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

issue-119463.stderr

fallback visibility for unexpected trait item

2024-01-04 02:02:57 +08:00

legacy-ctor-visibility.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

legacy-ctor-visibility.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

macro-private-reexport.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

macro-private-reexport.stderr

suggest using pub(crate) for E0364

2025-08-13 20:22:18 +08:00

no-ice-on-inference-failure.rs

Do not ICE in privacy when type inference fails.

2024-06-17 10:09:27 +00:00

no-ice-on-inference-failure.stderr

Do not ICE in privacy when type inference fails.

2024-06-17 10:09:27 +00:00

priv-impl-prim-ty.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

priv-in-bad-locations.rs

Update ui tests involving invalid visibility qualifiers

2023-04-03 22:28:55 -05:00

priv-in-bad-locations.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

privacy1-rpass.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

privacy1.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

privacy1.stderr

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

privacy2.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

privacy2.stderr

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

privacy3.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

privacy3.stderr

Run wfcheck in one big loop instead of per module

2025-06-03 15:16:51 +00:00

privacy4.rs

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

privacy4.stderr

tests: {Meta,Pointee}Sized in non-minicore tests

2025-06-16 23:04:33 +00:00

privacy5.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

privacy5.stderr

Use underline suggestions for purely 'additive' replacements

2025-02-14 00:27:13 -08:00

privacy-in-paths.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

privacy-in-paths.stderr

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

privacy-ns1.rs

…

privacy-ns1.stderr

Note potential but private items in show_candidates

2025-03-22 11:41:42 +08:00

privacy-ns2.rs

…

privacy-ns2.stderr

Note potential but private items in show_candidates

2025-03-22 11:41:42 +08:00

privacy-ns.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

privacy-reexport.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

privacy-sanity.rs

Update ui tests involving invalid visibility qualifiers

2023-04-03 22:28:55 -05:00

privacy-sanity.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

privacy-ufcs.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

privacy-ufcs.stderr

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

private-bounds-locally-allowed.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-class-field.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-field-access-in-mutex-54062.rs

add nonpoison::mutex implementation

2025-07-29 10:32:15 +02:00

private-field-access-in-mutex-54062.stderr

add nonpoison::mutex implementation

2025-07-29 10:32:15 +02:00

private-field-access-violation-3763.rs

Rehome tests/ui/issues/ tests [3/?]

2025-08-04 16:43:53 -04:00

private-field-access-violation-3763.stderr

Rehome tests/ui/issues/ tests [3/?]

2025-08-04 16:43:53 -04:00

private-field-struct-construction-76077.rs

Rehome tests/ui/issues/ tests [5/?]

2025-08-17 13:01:02 -04:00

private-field-struct-construction-76077.stderr

Rehome tests/ui/issues/ tests [5/?]

2025-08-17 13:01:02 -04:00

private-field-ty-err.rs

…

private-field-ty-err.stderr

suggest method name with maybe ty mismatch

2025-08-31 10:55:14 +08:00

private-impl-method.rs

…

private-impl-method.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-in-public-assoc-ty.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-assoc-ty.stderr

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-expr-pat.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-in-public-ill-formed.rs

…

private-in-public-ill-formed.stderr

…

private-in-public-non-principal-2.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-in-public-non-principal-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-in-public-non-principal.rs

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

private-in-public-non-principal.stderr

Allow newly added non_local_definitions lint in tests

2024-02-17 13:59:45 +01:00

private-in-public-type-alias-impl-trait.rs

Implement #[define_opaque] attribute for functions.

2025-03-11 12:05:02 +00:00

private-in-public-warn.rs

Do not check privacy for RPITIT.

2025-07-17 23:59:41 +00:00

private-in-public-warn.stderr

Perform check_private_in_public by module.

2025-07-26 21:21:04 +00:00

private-in-public.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-in-public.stderr

privacy: visit trait def id of projections

2023-12-08 14:26:03 +00:00

private-inferred-type-1.rs

Use non-2015 edition paths in tests that do not test for their resolution

2025-06-03 13:35:31 +02:00

private-inferred-type-1.stderr

Private-in-public lints implementation

2023-06-12 01:02:19 +03:00

private-inferred-type-2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-inferred-type-2.stderr

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-inferred-type-3.rs

compiletest: Require //~ annotations even if error-pattern is specified

2025-04-03 11:08:55 +03:00

private-inferred-type-3.stderr

compiletest: Require //~ annotations even if error-pattern is specified

2025-04-03 11:08:55 +03:00

private-inferred-type.rs

Replace old private-in-public diagnostic with type privacy lints

2023-08-02 13:40:28 +03:00

private-inferred-type.stderr

…

private-item-simple.rs

…

private-item-simple.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-cross-crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-method-cross-crate.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-inherited.rs

…

private-method-inherited.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-method-rpass.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

private-method.rs

…

private-method.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field-cross-crate.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

private-struct-field-cross-crate.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-struct-field-ctor.rs

…

private-struct-field-ctor.stderr

Emit a single privacy error for multiple fields on the same struct expression

2025-01-18 20:33:15 +00:00

private-struct-field-pattern.rs

…

private-struct-field-pattern.stderr

Emit a single privacy error for multiple fields on the same struct expression

2025-01-18 20:33:15 +00:00

private-struct-field.rs

…

private-struct-field.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

private-type-in-interface.rs

Bless ui tests.

2024-10-04 23:38:41 +00:00

private-type-in-interface.stderr

Bless ui tests.

2024-10-04 23:38:41 +00:00

private-unit-struct-assignment.rs

comments

2025-07-31 21:25:49 +05:00

private-unit-struct-assignment.stderr

comments

2025-07-31 21:25:49 +05:00

private-variant-reexport.rs

use visibility to check unused imports and delete some stmts

2023-10-22 21:27:46 +08:00

private-variant-reexport.stderr

vis note for no pub reexports glob import

2023-12-01 12:10:07 +08:00

projections2.rs

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections2.stderr

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections.rs

Add some tests for associated type normalization edge cases

2024-02-08 12:28:35 +00:00

projections.stderr

Perform check_private_in_public by module.

2025-07-26 21:21:04 +00:00

pub_use_mods_xcrate_exe.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

pub-extern-privacy.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

pub-restricted-path-usage-55376.rs

Add test batch 2

2025-08-27 15:06:05 -04:00

pub-use-xcrate.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

reachable-unnameable-items.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

struct-field-and-impl-expose-10545.rs

comments

2025-07-25 20:38:54 +05:00

struct-field-and-impl-expose-10545.stderr

comments

2025-07-25 20:38:54 +05:00

struct-field-type.rs

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

struct-field-type.stderr

Stop using hir_ty_to_ty in rustc_privacy

2024-02-07 14:59:26 +00:00

suggest-box-new.rs

fix ICE when suggesting ::new

2025-09-04 22:56:24 +02:00

suggest-box-new.stderr

fix ICE when suggesting ::new

2025-09-04 22:56:24 +02:00

suggest-making-field-public.fixed

Allow unused fields in some tests

2024-03-12 10:59:41 +01:00

suggest-making-field-public.rs

Allow unused fields in some tests

2024-03-12 10:59:41 +01:00

suggest-making-field-public.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

suggest-new-projection-ice.rs

fix ICE when suggesting ::new

2025-09-04 22:56:24 +02:00

suggest-new-projection-ice.stderr

fix ICE when suggesting ::new

2025-09-04 22:56:24 +02:00

sysroot-private.default.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

sysroot-private.rs

Fix tests/ui/privacy/sysroot-private

2025-01-28 19:42:32 +03:00

sysroot-private.rustc_private_enabled.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

trait-object-method-error.rs

cleaned up some tests

2025-06-04 19:32:06 +05:00

trait-object-method-error.stderr

cleaned up some tests

2025-06-04 19:32:06 +05:00

ufc-method-call.different_name.stderr

Add test description

2024-06-04 15:34:04 +00:00

ufc-method-call.rs

Add test description

2024-06-04 15:34:04 +00:00

ufc-method-call.same_name.stderr

Add test description

2024-06-04 15:34:04 +00:00

union-field-privacy-1.rs

…

union-field-privacy-1.stderr

Emit a single privacy error for multiple fields on the same struct expression

2025-01-18 20:33:15 +00:00

union-field-privacy-2.rs

…

union-field-privacy-2.stderr

Show number in error message even for one error

2023-11-24 19:15:52 +01:00

unnameable_types.rs

privacy: Stabilize lint unnameable_types

2024-03-13 18:37:40 +03:00

unnameable_types.stderr

privacy: Stabilize lint unnameable_types

2024-03-13 18:37:40 +03:00

unreachable-issue-121455.rs

Allow for a missing adt_def in NamePrivacyVisitor.

2024-02-23 10:57:11 +11:00

unreachable-issue-121455.stderr

Allow for a missing adt_def in NamePrivacyVisitor.

2024-02-23 10:57:11 +11:00

unresolved-trait-impl-item.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

unresolved-trait-impl-item.stderr

resolve: Feed visibilities for unresolved trait impl items

2023-12-19 22:33:26 +03:00

use-in-impl-scope-12729.rs

comments

2025-07-31 21:25:49 +05:00

useless-pub.rs

Update ui tests involving invalid visibility qualifiers

2023-04-03 22:28:55 -05:00

useless-pub.stderr

Improve diagnostic by suggesting to remove visibility qualifier

2024-04-12 12:59:40 +09:00

where-priv-type.rs

Bless tests and handle tests/crashes

2024-06-05 22:25:42 +01:00

where-priv-type.stderr

Bless tests and handle tests/crashes

2024-06-05 22:25:42 +01:00

where-pub-type-impls-priv-trait.rs

Don't mark privacy test as needing GCE

2025-03-24 16:57:07 +00:00

where-pub-type-impls-priv-trait.stderr

Don't mark privacy test as needing GCE

2025-03-24 16:57:07 +00:00

xc-private-method2.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

xc-private-method2.stderr

Move some UI tests into subdirectories

2023-04-02 19:42:30 -04:00

xc-private-method.rs

[AUTO-GENERATED] Migrate ui tests from // to //@ directives

2024-02-16 20:02:50 +00:00

xc-private-method.stderr

Move some UI tests into subdirectories

2023-04-02 19:42:30 -04:00