rust/library at 060bdfd9f38fd1e59e9d3ae7bbb4484b737de1f4 - rust

mirror of https://github.com/rust-lang/rust.git synced 2026-05-22 02:00:00 +03:00

Files

T

Matthias Krüger 845c414fae Rollup merge of #116714 - WaffleLapkin:order-the-order, r=joshtriplett

Derive `Ord`, `PartialOrd` and `Hash` for `SocketAddr*`

Fixes #116711

The main pain of this PR is to fix the buggy impl of `Ord` for `SocketAddrV6`, which ignored half of the fields (while `PartialEq` is derived):
https://github.com/rust-lang/rust/blob/4603f0b8afb495ae56cd4c8f70d5d478d906ac54/library/core/src/net/socket_addr.rs#L99-L106

https://github.com/rust-lang/rust/blob/4603f0b8afb495ae56cd4c8f70d5d478d906ac54/library/core/src/net/socket_addr.rs#L676

For me it looks like a simple copy-paste error made in https://github.com/rust-lang/rust/pull/72239 (copy from v4 impl) (cc `@hch12907),` as I don't see this behavior being mentioned anywhere on the PR and it also does not respect `cmp` trait "rules". I also do not see any reasons for those impls to _not_ be derived.

It's a shame we did not notice this for 28 versions/3 years. I guess this is a bug fix, but I'm not sure what the process here should be.

r? libs

2023-10-24 19:29:54 +02:00

alloc

Update boxed.rs

2023-10-21 23:41:32 +05:30

backtrace @ 99faef833f

Bump backtrace to 0.3.69

2023-08-22 15:01:14 -07:00

core

Rollup merge of #116714 - WaffleLapkin:order-the-order, r=joshtriplett

2023-10-24 19:29:54 +02:00

panic_abort

Rebase to master