Ivan Komarov 00a20bceff Fix formatting failures on Windows ...

When newline_style is set to Windows, an empty line inside of a macro
results in `\r` being passed to the `fold()` in `MacroBranch::rewrite()`.

`\r` is technically not an empty string, so we try to indent it, leaving
trailing whitespaces behind, even though that was not intended
(as far as I can see).

This commit replaces the `!l.is_empty()` check with calling
`is_empty_line()`, since trying to indent any whitespace-only string
will probably result in problematic trailing whitespaces.

Fixes: #2810

2018-10-28 02:37:55 +03:00

..

configs

No trailing comma in struct literals (Visual)

2018-10-06 10:59:47 +03:00

format_strings

format_strings: take into account newline occurring within a rewritten line

2018-10-02 00:41:56 +02:00

issue-1210

…

issue-2482

…

issue-2673-nonmodrs-mods

…

issue-2917

Prevent right-shifting of block comments with bare lines.

2018-09-22 00:09:11 +02:00

issue-2977

propagate errors about failing to rewrite a macro

2018-09-07 14:48:52 +02:00

issue-3055

do not format a code block in documentation if it is annotated with ignore or text (#3058)

2018-09-28 11:06:29 +09:00

itemized-blocks

try to fix comment bad wrapping (#3099)

2018-10-15 11:18:37 +09:00

nested_skipped

…

nestedmod

…

array_comment.rs

…

assignment.rs

…

associated_type_defaults.rs

…

associated-items.rs

…

associated-types-bounds-wrapping.rs

…

async_block.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

async_closure.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

async_fn.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

attrib-block-expr.rs

…

attrib-extern-crate.rs

…

attrib.rs

add non-regression test to existing doc attributes

2018-09-13 01:06:02 +02:00

big-impl-block.rs

Makes brace behavior consistent with empty bodies for traits and impls

2018-09-26 09:44:13 -03:00

big-impl-visual.rs

…

binary-expr.rs

…

break-and-continue.rs

…

catch.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

chains_with_comment.rs

Update tests

2018-08-31 18:20:28 +09:00

chains-visual.rs

Overflow Visual functions even with one argument

2018-10-06 16:32:38 +03:00

chains.rs

add test

2018-10-15 12:09:53 +13:00

closure-block-inside-macro.rs

…

closure.rs

Update tests

2018-09-19 23:19:24 +09:00

comment2.rs

…

comment3.rs

…

comment4.rs

…

comment5.rs

rewrite_string: allow to break on a boundary character that is on edge

2018-10-08 14:48:15 +02:00

comment_crlf_newline.rs

…

comment-inside-const.rs

…

comment-not-disappear.rs

…

comment.rs

…

comments-fn.rs

…

control-brace-style-always-next-line.rs

…

control-brace-style-always-same-line.rs

…

doc-attrib.rs

add test ensuring only doc = "" attributes are normalized to comments

2018-09-13 02:40:24 +02:00

doc-comment-with-example.rs

Add format_doc_comments

2018-10-11 23:34:36 +09:00

doc.rs

…

dyn_trait.rs

…

else-if-brace-style-always-next-line.rs

…

else-if-brace-style-always-same-line.rs

…

else-if-brace-style-closing-next-line.rs

…

empty_file.rs

…

empty-tuple-no-conversion-to-unit-struct.rs

…

enum.rs

Add attr_fn_like_width to the width heuristics

2018-10-12 15:20:42 +13:00

existential_type.rs

…

expr-block.rs

lists: Detect block comment by starting from the end.

2018-09-22 12:16:38 +02:00

expr.rs

Add a test for #3003

2018-09-30 23:28:03 +09:00

extern_not_explicit.rs

…

extern.rs

…

file-lines-1.rs

Update tests

2018-09-19 23:19:24 +09:00

file-lines-2.rs

…

file-lines-3.rs

Update tests

2018-09-19 23:19:24 +09:00

file-lines-4.rs

…

file-lines-5.rs

…

file-lines-6.rs

…

file-lines-item.rs

…

fn_args_density-vertical.rs

…

fn_args_indent-block.rs

…

fn_once.rs

…

fn-args-with-last-line-comment.rs

…

fn-custom-2.rs

…

fn-custom-3.rs

…

fn-custom-4.rs

…

fn-custom-6.rs

…

fn-custom-7.rs

…

fn-custom-8.rs

…

fn-custom.rs

…

fn-simple.rs

Add a test for #2956

2018-08-30 23:38:40 +09:00

fn-single-line.rs

…

fn-ty.rs

…

fn.rs

…

hard-tabs.rs

…

hello.rs

…

if_while_or_patterns.rs

…

immovable_generators.rs

…

impl.rs

fix a few typos found via codespell.

2018-10-19 12:28:00 +02:00

impls.rs

Makes brace behavior consistent with empty bodies for traits and impls

2018-09-26 09:44:13 -03:00

import-fencepost-length.rs

…

imports_block_indent.rs

…

imports-impl-only-use.rs

Impl only use (#2951)

2018-08-24 14:39:05 +09:00

imports-reorder-lines-and-items.rs

…

imports-reorder-lines.rs

…

imports-reorder.rs

…

imports.rs

…

indented-impl.rs

…

invalid-rust-code-in-doc-comment.rs

Catch parser panic in format_snippet (#3103)

2018-10-17 14:21:04 +09:00

issue-64.rs

…

issue-447.rs

…

issue-510.rs

…

issue-539.rs

fix the identification of a block comment.

2018-08-16 19:55:15 +02:00

issue-683.rs

fix the identification of a block comment.

2018-08-16 19:55:15 +02:00

issue-691.rs

…

issue-770.rs

…

issue-811.rs

…

issue-831.rs

…

issue-850.rs

…

issue-855.rs

…

issue-913.rs

…

issue-945.rs

…

issue-977.rs

…

issue-1021.rs

…

issue-1049.rs

…

issue-1055.rs

…

issue-1111.rs

…

issue-1113.rs

…

issue-1120.rs

…

issue-1124.rs

…

issue-1127.rs

…

issue-1158.rs

…

issue-1177.rs

…

issue-1192.rs

…

issue-1211.rs

…

issue-1214.rs

…

issue-1216.rs

…

issue-1239.rs

…

issue-1247.rs

…

issue-1255.rs

…

issue-1278.rs

…

issue-1350.rs

…

issue-1366.rs

…

issue-1397.rs

…

issue-1468.rs

…

issue-1598.rs

…

issue-1624.rs

…

issue-1681.rs

Update tests

2018-09-19 23:19:24 +09:00

issue-1693.rs

…

issue-1703.rs

…

issue-1800.rs

…

issue-1802.rs

…

issue-1824.rs

…

issue-1914.rs

…

issue-2025.rs

…

issue-2103.rs

…

issue-2111.rs

…

issue-2123.rs

…

issue-2164.rs

…

issue-2179.rs

…

issue-2197.rs

…

issue-2256.rs

…

issue-2324.rs

…

issue-2329.rs

…

issue-2342.rs

…

issue-2346.rs

…

issue-2401.rs

…

issue-2445.rs

…

issue-2446.rs

…

issue-2479.rs

…

issue-2496.rs

Add a test for #2496

2018-09-11 08:54:43 +03:00

issue-2520.rs

…

issue-2523.rs

Add a test for #3031 and update test

2018-10-08 13:50:00 +09:00

issue-2526.rs

…

issue-2551.rs

…

issue-2554.rs

…

issue-2582.rs

…

issue-2633.rs

do not vertically align list items in case the tactic is Horizontal

2018-10-12 20:41:56 +02:00

issue-2641.rs

…

issue-2644.rs

…

issue-2728.rs

…

issue-2759.rs

Update tests

2018-09-19 23:19:24 +09:00

issue-2761.rs

…

issue-2794.rs

…

issue-2810.rs

Fix formatting failures on Windows

2018-10-28 02:37:55 +03:00

issue-2863.rs

…

issue-2896.rs

Prevent right-shifting of block comments with bare lines.

2018-09-22 00:09:11 +02:00

issue-2922.rs

Add a test for #2922

2018-08-31 16:25:01 +03:00

issue-2927-2.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

issue-2927.rs

Accept 2015 and 2018 instead of Edition2015 and Edition2018 for edition option

2018-08-31 00:04:23 -07:00

issue-2930.rs

Add a test for #2930

2018-08-31 15:25:08 +03:00

issue-2936.rs

Fixed ellipsis bug where rustfmt was creating code that could not be parsed

2018-08-24 00:58:21 -04:00

issue-2955.rs

Merge branch 'master' of https://github.com/rust-lang-nursery/rustfmt into fix-optional-arg-condensing

2018-08-27 13:44:56 -04:00

issue-2973.rs

Fix indent computation of a macro with braces.

2018-09-18 00:01:51 +02:00

issue-2985.rs

force a newline after the if condition if there is a different

2018-10-15 23:24:35 +02:00

issue-3029.rs

Avoid control flow expressions conditions to go multi line

2018-10-13 14:12:43 -03:00

issue-3038.rs

force a newline after the if condition if there is a different

2018-10-15 23:24:35 +02:00

issue-3043.rs

Fix bug in import where two consecutive module separators were possible.

2018-09-21 18:51:19 +01:00

issue-3049.rs

Add a test for #3049

2018-10-06 16:32:27 +03:00

issue-3059.rs

try to fix comment bad wrapping (#3099)

2018-10-15 11:18:37 +09:00

issue-3066.rs

Add a test for #3066

2018-10-06 10:59:47 +03:00

issue-3105.rs

keep track of lines which formatting was disabled in order to prevent indentation which would cause code right-shifting

2018-10-24 12:11:11 +02:00

issue-3118.rs

Added test for crate non-alphabetizing

2018-10-23 19:00:42 -04:00

item-brace-style-always-next-line.rs

…

item-brace-style-prefer-same-line.rs

…

item-brace-style-same-line-where.rs

…

label_break.rs

…

large_vec.rs

…

large-block.rs

…

lazy_static.rs

…

long_field_access.rs

…

long-fn-1.rs

Add a test for #3009

2018-09-11 13:30:36 +09:00

long-match-arms-brace-newline.rs

…

loop.rs

…

macro_not_expr.rs

…

macro_rules.rs

Handle raw string literal without any sharps

2018-08-31 10:49:39 +09:00

macros.rs

Add a test for #3031 and update test

2018-10-08 13:50:00 +09:00

markdown-comment-with-options.rs

…

markdown-comment.rs

…

match-block-trailing-comma.rs

…

match-flattening.rs

Add a test for match flattening

2018-09-11 08:54:43 +03:00

match-nowrap-trailing-comma.rs

…

match-nowrap.rs

…

match.rs

fix a few typos found via codespell.

2018-10-19 12:28:00 +02:00

max-line-length-in-chars.rs

…

merge_imports.rs

…

mod_skip_child.rs

…

mod-1.rs

…

mod-2.rs

…

mulit-file.rs

…

multiple.rs

…

nested-if-else.rs

…

nested-visual-block.rs

Update tests

2018-09-19 23:19:24 +09:00

no_new_line_beginning.rs

…

obsolete_in_place.rs

Add a test for #2953

2018-08-26 13:19:44 +09:00

other.rs

…

paren.rs

…

paths.rs

…

pattern-condense-wildcards.rs

fix a few typos found via codespell.

2018-10-19 12:28:00 +02:00

pattern.rs

Add a test for slice patterns

2018-08-12 23:55:34 +09:00

pub-restricted.rs

…

raw_identifiers.rs

Handle raw identifiers in chain

2018-09-01 16:18:27 +09:00

remove_blank_lines.rs

fix a few typos found via codespell.

2018-10-19 12:28:00 +02:00

reorder-impl-items.rs

fix a few typos found via codespell.

2018-10-19 12:28:00 +02:00

single-line-if-else.rs

…

skip_mod.rs

…

skip.rs

…

soft-wrapping.rs

…

space-not-before-newline.rs

…

spaces-around-ranges.rs

…

static.rs

…

string_punctuation.rs

…

string-lit-2.rs

…

string-lit-custom.rs

…

string-lit.rs

…

struct_lits_multiline.rs

rewrite_string: allow to break on a boundary character that is on edge

2018-10-08 14:48:15 +02:00

struct_lits_visual_multiline.rs

No trailing comma in struct literals (Visual)

2018-10-06 10:59:47 +03:00

struct_lits_visual.rs

No trailing comma in struct literals (Visual)

2018-10-06 10:59:47 +03:00

struct_lits.rs

rewrite_string: allow to break on a boundary character that is on edge

2018-10-08 14:48:15 +02:00

struct_tuple_visual.rs

…

struct-field-attributes.rs

…

structs.rs

…

trailing_commas.rs

…

trailing-comma-never.rs

…

trait.rs

Add a test for #3092

2018-10-14 21:47:50 +09:00

try-conversion.rs

…

tuple.rs

…

type_alias.rs

…

type-ascription.rs

…

type.rs

Add a test for #3137

2018-10-26 16:36:01 +09:00

unindent_if_else_cond_comment.rs

…

unions.rs

…

visibility.rs

…

visual-fn-type.rs

Add a visual fn type alias test

2018-09-11 12:34:21 +03:00

where-clause-rfc.rs

…

where-clause.rs

…

width-heuristics.rs

…

wrapped_hidden_code_block.rs

handle lines prefixed with a # inside code blocks

2018-10-13 09:57:43 +02:00