Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-04-30 23:03:06 +03:00
Code Issues Packages Projects Releases Wiki Activity
Files
perf-tmp
rust/tests/ui/span
T
History
Jonathan Brouwer 8ee783610d Rollup merge of #154325 - WeiTheShinobi:tweak-let-else-output, r=davidtwco 
Tweak irrefutable let else warning output

Fixes https://github.com/rust-lang/rust/issues/153454

Greeting!
This PR tweak diagnostic output for `irrefutable-let-else` patterns and adds a check for `let a = Some(b) else {...}`
Thanks for the review!

```
help: consider using `let Some(name) = case` to match on a specific variant
   |
LL -     let name = Some(case) else {
LL +     let Some(name) = case else {
   |
```
2026-04-28 20:24:30 +02:00
..
auxiliary
…
borrowck-borrow-overloaded-auto-deref-mut.rs
…
borrowck-borrow-overloaded-auto-deref-mut.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-borrow-overloaded-deref-mut.rs
…
borrowck-borrow-overloaded-deref-mut.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-call-is-borrow-issue-12224.rs
…
borrowck-call-is-borrow-issue-12224.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-call-method-from-mut-aliasable.rs
…
borrowck-call-method-from-mut-aliasable.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-fn-in-const-b.rs
…
borrowck-fn-in-const-b.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-let-suggestion-suffixes.rs
Improve diagnostics for buffer reuse with borrowed references
2025-10-22 21:11:02 +09:00
borrowck-let-suggestion-suffixes.stderr
Improve diagnostics for buffer reuse with borrowed references
2025-10-22 21:11:02 +09:00
borrowck-object-mutability.rs
…
borrowck-object-mutability.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
borrowck-ref-into-rvalue.fixed
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
borrowck-ref-into-rvalue.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
borrowck-ref-into-rvalue.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
coerce-suggestions.rs
remove sub_relations from infcx, recompute in diagnostics
2024-02-22 17:29:25 +01:00
coerce-suggestions.stderr
Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic
2026-01-26 17:34:31 +00:00
destructor-restrictions.rs
…
destructor-restrictions.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
drop-location-span-error-rust-2021-incompatible-closure-captures-93117.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
drop-location-span-error-rust-2021-incompatible-closure-captures-93117.stderr
Be more accurate about calculating display_col from a BytePos
2024-07-18 20:08:38 +00:00
drop-location-span-error-rust-2021-incompatible-closure-captures-96258.rs
Add more missing 2015 edition directives
2025-06-05 09:20:19 +02:00
drop-location-span-error-rust-2021-incompatible-closure-captures-96258.stderr
Merge E0412 into E0425
2025-12-02 18:25:13 +00:00
dropck_arr_cycle_checked.rs
Use non-2015 edition paths in tests that do not test for their resolution
2025-06-05 09:19:31 +02:00
dropck_arr_cycle_checked.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
dropck_direct_cycle_with_drop.rs
…
dropck_direct_cycle_with_drop.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
dropck_misc_variants.rs
Gate 2018 UI tests
2025-11-27 14:13:58 -05:00
dropck_misc_variants.stderr
Gate 2018 UI tests
2025-11-27 14:13:58 -05:00
dropck_vec_cycle_checked.rs
Use non-2015 edition paths in tests that do not test for their resolution
2025-06-05 09:19:31 +02:00
dropck_vec_cycle_checked.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
dropck-object-cycle.rs
…
dropck-object-cycle.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
E0046.rs
…
E0046.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
E0072.rs
…
E0072.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
E0204.rs
Keep span of type in builtin derive macros expansions
2026-02-01 18:20:30 +00:00
E0204.stderr
Keep span of type in builtin derive macros expansions
2026-02-01 18:20:30 +00:00
E0493.rs
…
E0493.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
E0537.rs
…
E0537.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
E0539.rs
make error codes reflect reality better
2025-06-17 23:22:51 +02:00
E0539.stderr
Add more docs to templates for attrs with incorrect arguments
2025-08-11 17:02:32 +00:00
E0805.rs
Port cfg!() macro to the new attribute parsing system
2025-11-03 18:23:41 +01:00
E0805.stderr
Make span_suggestions always verbose
2026-04-15 01:38:14 +00:00
gated-features-attr-spans.rs
Ban non-array SIMD
2024-09-09 19:39:43 -07:00
gated-features-attr-spans.stderr
Bless tests
2024-01-13 12:46:58 -05:00
impl-wrong-item-for-trait.rs
…
impl-wrong-item-for-trait.stderr
…
import-ty-params.rs
…
import-ty-params.stderr
…
issue28498-reject-ex1.rs
…
issue28498-reject-ex1.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue28498-reject-lifetime-param.rs
…
issue28498-reject-lifetime-param.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue28498-reject-passed-to-fn.rs
…
issue28498-reject-passed-to-fn.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue28498-reject-trait-bound.rs
…
issue28498-reject-trait-bound.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-11925.rs
…
issue-11925.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-23338-locals-die-before-temps-of-body.rs
…
issue-23338-locals-die-before-temps-of-body.stderr
Do not set up wrong span for adjustments
2023-07-10 20:09:26 +00:00
issue-23729.rs
…
issue-23729.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-23827.rs
Continue to borrowck even if there were previous errors
2024-02-08 08:10:43 +00:00
issue-23827.stderr
Continue to borrowck even if there were previous errors
2024-02-08 08:10:43 +00:00
issue-24356.rs
…
issue-24356.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-24690.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
issue-24690.stderr
bless tests with new lint messages
2025-08-19 21:27:10 +02:00
issue-24805-dropck-child-has-items-via-parent.rs
…
issue-24805-dropck-child-has-items-via-parent.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-24805-dropck-trait-has-items.rs
…
issue-24805-dropck-trait-has-items.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
issue-24895-copy-clone-dropck.rs
…
issue-24895-copy-clone-dropck.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-25199.rs
Gate 2018 UI tests
2025-11-27 14:13:58 -05:00
issue-25199.stderr
Gate 2018 UI tests
2025-11-27 14:13:58 -05:00
issue-26656.rs
…
issue-26656.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-27522.rs
…
issue-27522.stderr
Arbitrary self types v2: adjust diagnostic.
2024-12-13 15:40:37 +00:00
issue-29106.rs
…
issue-29106.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
issue-29595.rs
…
issue-29595.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-33884.rs
…
issue-33884.stderr
Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic
2026-01-26 17:34:31 +00:00
issue-34264.rs
…
issue-34264.stderr
Add FnContext in parser for diagnostic
2025-08-14 21:31:47 +08:00
issue-35987.rs
Merge collect_mod_item_types query into check_well_formed
2024-03-07 14:26:31 +00:00
issue-35987.stderr
Show diff suggestion format on verbose replacement
2025-02-10 20:21:39 +00:00
issue-36537.rs
…
issue-36537.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-37767.rs
…
issue-37767.stderr
Show diff suggestion format on verbose replacement
2025-02-10 20:21:39 +00:00
issue-39018.rs
…
issue-39018.stderr
Tweak borrow suggestion
2023-05-08 03:36:30 +00:00
issue-39698.rs
Continue to borrowck even if there were previous errors
2024-02-08 08:10:43 +00:00
issue-39698.stderr
bless tests
2026-02-22 17:10:36 +03:00
issue-40157.rs
…
issue-40157.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
issue-42234-unknown-receiver-type.full.stderr
Do not underline suggestions for code that is already there
2024-08-01 18:53:42 +00:00
issue-42234-unknown-receiver-type.generic_arg.stderr
Bless and add tests
2025-01-23 06:01:36 +00:00
issue-42234-unknown-receiver-type.rs
stabilize gai
2025-06-11 15:30:15 +01:00
issue-42234-unknown-receiver-type.stderr
Make E0284 generic argument suggestions more explicit
2026-04-20 16:46:57 +06:00
issue-43927-non-ADT-derive.rs
Supress unhelpful diagnostics for unresolved top level attributes
2024-01-29 17:43:07 +08:00
issue-43927-non-ADT-derive.stderr
check earlier for misused crate-level attributes
2026-03-22 07:51:23 +00:00
issue-71363.rs
Fix terminal dependent tests
2026-01-19 18:54:02 +00:00
issue-71363.stderr
On E0277, point at type that doesn't implement bound
2025-08-22 17:55:15 +00:00
issue-81800.rs
…
issue-81800.stderr
Show diff suggestion format on verbose replacement
2025-02-10 20:21:39 +00:00
issue-107353.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
let-offset-of.rs
Tweak irrefutable let else warning output, add new suggestion
2026-04-18 13:03:47 +08:00
let-offset-of.stderr
Tweak irrefutable let else warning output, add new suggestion
2026-04-18 13:03:47 +08:00
lint-unused-unsafe.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
lint-unused-unsafe.stderr
Remove revisions for THIR unsafeck
2024-01-05 09:30:27 +00:00
macro-span-caller-replacement.rs
Point at span within local macros even when error happens in nested external macro
2025-12-10 19:27:40 +00:00
macro-span-caller-replacement.stderr
Point at span within local macros even when error happens in nested external macro
2025-12-10 19:27:40 +00:00
macro-span-replacement.rs
macro_rules: Preserve all metavariable spans in a global side table
2024-02-18 11:19:24 +03:00
macro-span-replacement.stderr
macro_rules: Preserve all metavariable spans in a global side table
2024-02-18 11:19:24 +03:00
macro-ty-params.rs
ignore generics args in attribute paths
2024-05-11 00:13:27 +08:00
macro-ty-params.stderr
ignore generics args in attribute paths
2024-05-11 00:13:27 +08:00
method-and-field-eager-resolution.rs
…
method-and-field-eager-resolution.stderr
…
missing-unit-argument.rs
…
missing-unit-argument.stderr
More sophisticated span trimming
2025-02-21 00:41:17 +00:00
move-closure.rs
…
move-closure.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
multiline-span-E0072.rs
…
multiline-span-E0072.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
multiline-span-simple.rs
…
multiline-span-simple.stderr
Point at binop lhs and rhs when expression is multiline
2026-03-29 21:07:54 +00:00
multispan-import-lint.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
multispan-import-lint.stderr
Make early lints translatable
2024-05-21 20:16:39 +00:00
mut-arg-hint.rs
…
mut-arg-hint.stderr
Provide more context when mutably borrowing an imutable borrow
2025-11-09 22:14:48 +00:00
mut-ptr-cant-outlive-ref.rs
…
mut-ptr-cant-outlive-ref.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
mutability-suggestion-fullwidth-ampersand.rs
Fix ICE in borrowck mutability suggestion with multi-byte ref sigil
2026-04-18 08:52:11 +09:00
mutability-suggestion-fullwidth-ampersand.stderr
Fix ICE in borrowck mutability suggestion with multi-byte ref sigil
2026-04-18 08:52:11 +09:00
non-existing-module-import.rs
…
non-existing-module-import.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
pub-struct-field.rs
…
pub-struct-field.stderr
…
range-2.rs
Remove attribute #[rustc_error]
2025-03-30 01:32:21 +03:00
range-2.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
recursive-type-field.rs
…
recursive-type-field.stderr
Fix ... in multline code-skips in suggestions
2024-06-20 04:25:17 +00:00
regionck-unboxed-closure-lifetimes.rs
Remove attribute #[rustc_error]
2025-03-30 01:32:21 +03:00
regionck-unboxed-closure-lifetimes.stderr
Remove attribute #[rustc_error]
2025-03-30 01:32:21 +03:00
regions-close-over-borrowed-ref-in-obj.rs
…
regions-close-over-borrowed-ref-in-obj.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
regions-close-over-type-parameter-2.rs
…
regions-close-over-type-parameter-2.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
regions-escape-loop-via-variable.rs
…
regions-escape-loop-via-variable.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
regions-escape-loop-via-vec.rs
…
regions-escape-loop-via-vec.stderr
Improve diagnostics for buffer reuse with borrowed references
2025-10-22 21:11:02 +09:00
regions-infer-borrow-scope-within-loop.rs
…
regions-infer-borrow-scope-within-loop.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
send-is-not-static-ensures-scoping.rs
…
send-is-not-static-ensures-scoping.stderr
Modify find_expr from Span to better account for closures
2024-04-24 22:21:13 +00:00
send-is-not-static-std-sync-2.rs
…
send-is-not-static-std-sync-2.stderr
Evaluate place expression in PlaceMention.
2023-04-21 21:34:59 +00:00
send-is-not-static-std-sync.rs
Remove Drop impl of mpsc Receiver and (Sync)Sender
2023-08-18 14:46:20 +02:00
send-is-not-static-std-sync.stderr
Peel off explicit (or implicit) deref before suggesting clone on move error in borrowck
2024-07-26 14:41:56 -04:00
slice-borrow.rs
…
slice-borrow.stderr
Do not mention -Zmacro-backtrace for std macros that are a wrapper around a compiler intrinsic
2026-01-26 17:34:31 +00:00
span-extend-prev-while-multibyte.rs
Fix ICE in span_extend_prev_while with multibyte characters
2026-04-10 06:34:12 +09:00
span-extend-prev-while-multibyte.stderr
Fix ICE in span_extend_prev_while with multibyte characters
2026-04-10 06:34:12 +09:00
suggestion-non-ascii.rs
…
suggestion-non-ascii.stderr
indexing: reword help
2025-10-01 07:39:03 +00:00
suggestion-raw-68962.rs
Add raw identifier in a typo suggestion
2024-04-29 15:02:12 +08:00
suggestion-raw-68962.stderr
Make typo in field and name suggestions verbose
2025-12-09 17:29:23 +00:00
transitive-dep-span.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
transitive-dep-span.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
type-annotations-needed-expr.rs
…
type-annotations-needed-expr.stderr
Make E0284 generic argument suggestions more explicit
2026-04-20 16:46:57 +06:00
type-binding.rs
…
type-binding.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00
typo-suggestion.rs
…
typo-suggestion.stderr
Make typo in field and name suggestions verbose
2025-12-09 17:29:23 +00:00
unused-warning-point-at-identifier.rs
[AUTO-GENERATED] Migrate ui tests from // to //@ directives
2024-02-16 20:02:50 +00:00
unused-warning-point-at-identifier.stderr
…
vec_refs_data_with_early_death.rs
…
vec_refs_data_with_early_death.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
vec-macro-outlives-issue-15480.fixed
add write_box_via_move intrinsic and use it for vec!
2026-02-16 17:27:40 +01:00
vec-macro-outlives-issue-15480.rs
add write_box_via_move intrinsic and use it for vec!
2026-02-16 17:27:40 +01:00
vec-macro-outlives-issue-15480.stderr
add write_box_via_move intrinsic and use it for vec!
2026-02-16 17:27:40 +01:00
vec-must-not-hide-type-from-dropck.rs
Use non-2015 edition paths in tests that do not test for their resolution
2025-06-05 09:19:31 +02:00
vec-must-not-hide-type-from-dropck.stderr
Tweak E0597
2023-01-15 19:46:20 +00:00
visibility-ty-params.rs
Unify wording of resolve error
2026-02-17 16:51:44 +00:00
visibility-ty-params.stderr
Unify wording of resolve error
2026-02-17 16:51:44 +00:00
wf-method-late-bound-regions.rs
…
wf-method-late-bound-regions.stderr
Show number in error message even for one error
2023-11-24 19:15:52 +01:00