f07d10db7c
Stabilize #[track_caller].
...
Does not yet make its constness stable, though. Use of
`Location::caller` in const contexts is still gated by
`#![feature(const_caller_location)]`.
2020-06-30 22:22:32 -07:00
596af5ae5d
Rollup merge of #73763 - davidtwco:terminal-width-json-emitter, r=estebank
...
errors: use `-Z terminal-width` in JSON emitter
This PR makes the JSON emitter use `-Z terminal-width` in the "rendered" field of the JSON output.
r? @estebank
2020-06-27 22:30:01 -07:00
3678e5c97e
errors: use -Z terminal-width in JSON emitter
...
This commit makes the JSON emitter use `-Z terminal-width` in the
"rendered" field of the JSON output.
Signed-off-by: David Wood <david@davidtw.co >
2020-06-26 16:01:51 +01:00
11a3584de4
emitter: column width defaults to 140
...
This commit modifies the column width computation in the emitter when
`termize::dimensions` returns `None` so that it uses the default value
of 140 (which is used in UI testing currently) instead of `usize::MAX`
which just ends up causing overflows in later computations. This is hard
to test but appears to produce the same output as using saturating
functions instead.
Signed-off-by: David Wood <david@davidtw.co >
2020-06-25 11:56:15 +01:00
e855b90a8e
track caller for delay_span_bug
2020-06-15 18:25:58 -05:00
d97e8ca335
Rollup merge of #72740 - estebank:recursive-indirection, r=matthewjasper
...
On recursive ADT, provide indirection structured suggestion
2020-06-15 12:00:59 +02:00
b34111591c
Rollup merge of #73169 - Amanieu:asm-warnings, r=petrochenkov
...
Handle assembler warnings properly
Previously all inline asm diagnostics were treated as errors, but LLVM sometimes emits warnings and notes as well.
Fixes #73160
r? @petrochenkov
2020-06-11 19:04:14 +02:00
c29b3fa148
On recursive ADT, provide indirection structured suggestion
2020-06-10 14:09:51 -07:00
58023fedfc
Fix more clippy warnings
...
Fixes more of:
clippy::unused_unit
clippy::op_ref
clippy::useless_format
clippy::needless_return
clippy::useless_conversion
clippy::bind_instead_of_map
clippy::into_iter_on_ref
clippy::redundant_clone
clippy::nonminimal_bool
clippy::redundant_closure
clippy::option_as_ref_deref
clippy::len_zero
clippy::iter_cloned_collect
clippy::filter_next
2020-06-09 18:51:08 +02:00
5541f689e9
Handle assembler warnings properly
2020-06-09 15:01:02 +01:00
8484b9935c
Rollup merge of #72026 - botika:master, r=estebank
...
Update annotate-snippets-rs to 0.8.0
#59346
I made major changes to this library. In the previous version we worked with owned while in the current one with borrowed.
I have adapted it without changing the behavior.
I have modified the coverage since the previous one did not return correctly the index of the character in the line.
2020-06-08 09:55:18 +02:00
11d951492c
Make things build again
2020-06-02 20:38:24 +03:00
3fea832fd7
Fix spacing of expected/found notes without a label
2020-05-27 16:27:15 -07:00
8fc6202911
Fix make sure out primary file comes first
2020-05-16 04:57:40 +02:00
e9c78db086
Update annotate-snippets-rs to 0.8.0
2020-05-08 22:48:26 +02:00
1a439d2865
Simplify the error Registry methods a little
2020-05-04 11:52:15 -07:00
2b5325dbff
Rollup merge of #71489 - spastorino:fix-treat-err-as-bug-handling, r=eddyb
...
Fix off by one in treat err as bug
`-Ztreat-err-as-bug` doesn't work properly with delay_span_bug.
r? @eddyb
2020-04-28 13:12:14 +02:00
230e40644b
Fix off by one error for delay_span_bug
...
delay_span_bug bumps error_count after checking treat_err_as_bug
2020-04-27 09:14:30 -03:00
4282776b1c
Replace filter_map().next() calls with find_map()
...
These are semantically the same, but `find_map()` is more concise.
2020-04-24 20:03:45 -07:00
3837df2992
don't clone types that are copy (clippy::clone_on_copy)
2020-04-16 00:17:38 +02:00
57ed3d378d
fix issue 69130
2020-04-12 11:36:37 -04:00
b85c64c3ea
rustc: Add a warning count upon completion
2020-04-11 16:15:24 +02:00
f7778d36c7
Use assoc integer constants in librustc_*
2020-04-07 00:43:16 +02:00
eea91c308f
Rollup merge of #70519 - estebank:constraints-before-args-spans, r=Centril
...
Tweak output of type params and constraints in the wrong order
r? @Centril @varkor
2020-04-06 04:24:15 +02:00
9bba047c2e
Use if let instead of match when only matching a single variant (clippy::single_match)
...
Makes code more compact and reduces nestig.
2020-03-30 10:52:29 +02:00
7710f2dd5c
rustc -> rustc_middle part 1
2020-03-30 07:02:56 +02:00
c2e0e71a09
Suggest correct order for arguments when encountering early constraints
...
When encountering constraints before type arguments or lifetimes,
suggest the correct order.
2020-03-29 11:31:58 -07:00
fda3378e3f
introduce negative_impls feature gate and document
...
They used to be covered by `optin_builtin_traits` but negative impls
are now applicable to all traits, not just auto traits.
This also adds docs in the unstable book for the current state of auto traits.
2020-03-26 06:52:55 -04:00
560eae31c5
Rollup merge of #70199 - pnkfelix:issue-68808-dont-turn-dummy-spans-into-invalid-lines, r=estebank
...
Revised span-to-lines conversion to produce an empty vec on DUMMY_SP.
This required revising some of the client code to stop relying on the returned set of lines being non-empty.
Fix #68808
2020-03-23 19:04:51 +01:00
263cbd1bbe
remove redundant closures (clippy::redundant_closure)
2020-03-22 12:43:19 +01:00
ebf27fac81
Revised span-to-lines conversion to produce an empty vec on DUMMY_SP.
...
This required revising some of the client code to stop relying on
the returned set of lines being non-empty.
2020-03-20 14:11:16 -04:00
4392a8b73c
use direct imports for rustc::{lint, session}.
2020-03-16 02:52:06 +01:00
4809be0137
rustc_errors: Use ensure_source_file_source_present where necessary.
2020-03-10 07:26:27 +01:00
fd302f46dc
Store TokenStream in rmeta::MacroDef.
...
This removes a hack from `load_macro_untracked` in which parsing is used.
2020-03-10 07:26:27 +01:00
80ed505c41
Use single-char patter on {ends,starts}_with and remove clone on copy type.
...
These were introduced since I last fixed most of these occurences. (clippy::clone_on_copy, clippy::single_char_pattern)
2020-03-04 20:47:05 +01:00
d8d2004c6f
Don't use "if let" bindings to only check a value and not actually bind anything.
...
For example: `if let Some(_) = foo() {}` can be reduced to `if foo().is_some() {}` (clippy::redundant_pattern_matching)
2020-03-04 20:41:03 +01:00
ef311d5ab4
Rollup merge of #69628 - nnethercote:fix-DiagnosticBuilder-into_diagnostic-leak, r=Centril
...
Fix a leak in `DiagnosticBuilder::into_diagnostic`.
Fixes #69600 .
r? @Centril
2020-03-03 17:50:13 +09:00
f19684c7cf
Rollup merge of #69619 - matthiaskrgr:misc, r=eddyb
...
more cleanups
* use starts_with() instead of chars().next() == Some(x)
* use subsec_micros() instead of subsec_nanos() / 1000
* use for (idx, item) in iter.enumerate() instead of manually counting loop iterations with variables
* use values() or keys() respectively when iterating only over keys or values of maps.
2020-03-03 17:50:08 +09:00
0255561dea
Rollup merge of #69623 - Centril:fix-69396-tmp, r=petrochenkov
...
stash API: remove panic to fix ICE.
Implements the temporary solution suggested in https://github.com/rust-lang/rust/pull/69537#issuecomment-593143975 .
Fixes https://github.com/rust-lang/rust/issues/69396 .
r? @petrochenkov
2020-03-02 13:42:41 +01:00
99a595e406
Fix a leak in DiagnosticBuilder::into_diagnostic.
...
Fixes #69600 .
2020-03-02 14:42:46 +11:00
df20036848
stash API: remove panic to fix ICE.
2020-03-02 00:07:23 +01:00
22339c3406
use for (idx, item) in iter.enumerate() instead of manually counting loop iterations by variables
2020-03-01 21:17:48 +01:00
5f3ffee6b7
added try_find_description to distinguish no desc from invalid code
2020-02-29 11:53:51 -07:00
3f9bddc7fe
Auto merge of #69570 - Dylan-DPC:rollup-d6boczt, r=Dylan-DPC
...
Rollup of 6 pull requests
Successful merges:
- #69477 (docs: add mention of async blocks in move keyword docs)
- #69504 (Use assert_ne in hash tests)
- #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.)
- #69551 (use is_empty() instead of len() == x to determine if structs are empty.)
- #69563 (Fix no_std detection for target triples)
- #69567 (use .to_string() instead of format!() macro to create strings)
Failed merges:
r? @ghost
2020-02-29 10:43:32 +00:00
04e7f96dd8
Auto merge of #69227 - Marwes:buffer_stderr, r=varkor
...
perf: Buffer stderr when writing json errors/warnings
Since `stderr` is unbuffered, writing out json messages actually take up
about ~10%/0.1s of the runtime of the `inflate` benchmark as it generates a fair number of warnings.
cc #64413
2020-02-29 07:27:29 +00:00
bbfec7ca41
Rollup merge of #69567 - matthiaskrgr:useless_fmt, r=nagisa
...
use .to_string() instead of format!() macro to create strings
handles what is left after https://github.com/rust-lang/rust/pull/69541
2020-02-29 02:16:24 +01:00
85e59b7664
use .to_string() instead of format!() macro to create strings
2020-02-29 01:32:42 +01:00
9523c89f18
use is_empty() instead of len() == x to determine if structs are empty.
2020-02-28 15:16:27 +01:00
20c9a40fec
Rename CodeMap to SourceMap follow up
2020-02-22 16:17:31 +02:00
ee064befa0
Ensure diagnostics are printed in the correct order
...
Even when buffered. Ideally we would flush only when the emitter is
done, but that requires larger changes. This gives most of the benefit
of buffering in any case.
2020-02-17 16:46:53 +01:00
Adam Perry