Mirrors/rust
1
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2026-05-07 17:18:32 +03:00
Code Issues Packages Projects Releases Wiki Activity
208,176 Commits 10 Branches 157 Tags
faab68eb29121f25b577b50e2e00e33bafc60a36
Commit Graph

411 Commits

Author SHA1 Message Date
Michael Howell 2ac29f6808 rustdoc: remove unused CSS class .result-description 
It was added to the CSS in d8de2b4c33, but
was never actually used in that PR.
 2022-10-21 22:14:21 -07:00
Matthias Krüger 1d3aa7bce7 Rollup merge of #103370 - notriddle:notriddle/out-of-band, r=GuillaumeGomez 
rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`

This CSS was added in 083c3952e0 to normalize the appearance of out-of-band elements that were nested directly below headers.

Now, the only use of `out-of-band` is in the main page header, and it is nested below a wrapper, not the `<h1>` itself.
 2022-10-22 00:14:04 +02:00
Michael Howell 1adb4c338a rustdoc: remove unused CSS .out-of-band { font-weight: normal } 
This CSS was added in 083c3952e0 to
normalize the appearance of out-of-band elements that were nested directly
below headers.

Now, the only use of `out-of-band` is in the main page header, and it is
nested below a wrapper, not the `<h1>` itself.
 2022-10-21 14:13:18 -07:00
Michael Howell 526c1d32f6 rustdoc: prevent method summary margin from being applied to docblocks 2022-10-21 10:48:41 -07:00
Michael Howell 0dbf233fc9 rustdoc: merge identical CSS blocks 2022-10-21 10:31:33 -07:00
Michael Howell f6dd4708cf rustdoc: improve appearance of source page navigation bar 
This commit changes things so that the search bar is exactly centered between
the top of the page and the top of the source code content area.
 2022-10-20 13:31:06 -07:00
Matthias Krüger f8dfddb98c Rollup merge of #103268 - notriddle:notriddle/nav-sub-font-size, r=GuillaumeGomez 
rustdoc: remove no-op CSS `nav.sub { font-size: 1rem }`

This rule originated as a `font-size: 16px`, when body had `font-size: 13px` set in 4fd061c426.

It remained even when body's font size was bumped up to 16px, 4d5f4ff5e9, making the rule a no-op, and was carried forward when it was converted to 1rem in cc18120425.
 2022-10-20 07:58:57 +02:00
Matthias Krüger e5514b9377 Rollup merge of #103251 - GuillaumeGomez:item-decl-highlighting, r=notriddle 
Fix item declaration highlighting

Fixes https://github.com/rust-lang/rust/issues/103050.

As mentioned in the issue, https://github.com/rust-lang/rust/pull/102924 introduced this regression. This PR partially reverts it and adds a regression test.

r? `@notriddle`
 2022-10-20 07:58:56 +02:00
Michael Howell 0dd329f687 rustdoc: remove no-op CSS nav.sub { font-size: 1rem } 
This rule originated as a `font-size: 16px`, when body had `font-size: 13px`
set in 4fd061c426.

It remained even when body's font size was bumped up to 16px,
4d5f4ff5e9, making the rule a no-op, and was
carried forward when it was converted to 1rem in
cc18120425.
 2022-10-19 13:57:39 -07:00
Matthias Krüger 952c15622a Rollup merge of #103257 - notriddle:notriddle/setting-line, r=GuillaumeGomez 
rustdoc: move `setting-line` color CSS to settings.css
 2022-10-19 21:38:42 +02:00
Matthias Krüger 433f736b86 Rollup merge of #103211 - notriddle:notriddle/dot-location, r=GuillaumeGomez 
rustdoc: remove class name `location` from sidebar sibling nav

Preview: https://notriddle.com/notriddle-rustdoc-demos/sidebar-location/std/vec/struct.Vec.html

This change tweaks the CSS to apply most of its styles to `.sidebar h2`, cleaning up a few redundant rules from `.mobile-topbar .location` and restoring useful navigation aids in mobile mode.

## Before

![location-before](https://user-images.githubusercontent.com/1593513/196521014-d8730830-c3a2-4ed7-9266-05454cd31e05.png)

## After

![location-after](https://user-images.githubusercontent.com/1593513/196521020-75ec1fa5-b3dc-4c5d-97b6-afccb5fbe00a.png)
 2022-10-19 21:38:39 +02:00
Michael Howell db570586a5 rustdoc: move setting-line color CSS to settings.css 2022-10-19 09:24:09 -07:00
Guillaume Gomez a1d4ebe496 Fix regression in item-decl highlighting 2022-10-19 17:14:50 +02:00
Michael Howell a01b88575e rustdoc: remove class name location from sidebar sibling nav 
This change tweaks the CSS to apply most of its styles to `.sidebar h2`,
cleaning up a few redundant rules from `.mobile-topbar .location` and
restoring useful navigation aids in mobile mode.
 2022-10-18 12:01:53 -07:00
Michael Howell bbac29c095 rustdoc: remove CSS @media (min-width: 701px) 
The two rules within it can and should be done without the separate
media query:

  * There ain't no rule saying a viewport can't be `700.5px` wide, since
    hardware pixels can be finer than CSS pixels.

  * The rule for the first example-wrap child should probably apply
    on mobile.

  * The rule for the source sidebar is overriden by the mobile rule
    setting `max-width: 100vw`, so it can be merged with the rest
    of the styles.
 2022-10-17 19:09:26 -07:00
Matthias Krüger 8a467c3215 Rollup merge of #103162 - notriddle:notriddle/crate-search, r=GuillaumeGomez 
rustdoc: remove redundant CSS `#crate-search { border-radius }`

This is the same border-radius that's always set on that ID:

https://github.com/rust-lang/rust/blob/a9d1cafa878ecc04a4aa7aaa7df0414a29a2bd0b/src/librustdoc/html/static/css/rustdoc.css#L825-L836
 2022-10-17 23:09:08 +02:00
Michael Howell 642bb0d54f rustdoc: remove redundant CSS #crate-search { border-radius } 
This is the same border-radius that's always set on that ID:

https://github.com/rust-lang/rust/blob/a9d1cafa878ecc04a4aa7aaa7df0414a29a2bd0b/src/librustdoc/html/static/css/rustdoc.css#L825-L836
 2022-10-17 12:16:40 -07:00
Michael Howell 3aa3b8be4e rustdoc: remove redundant CSS on #copy-path 
The border and background were removed in
5d004c1e20, but not all the CSS was.
 2022-10-17 11:59:01 -07:00
Michael Howell bcf4cfe790 rustdoc: clean up .sub-logo-container CSS 
* Since it's used exclusively on source pages, no need to explicitly
  select.

* No need to hide it when the sidebar is open, since it fills the whole
  page.
 2022-10-16 17:57:26 -07:00
Michael Howell ae4ad9adb6 rustdoc: make the help button a link to a page 
This allows you to open the help section in a new browser tab, which is a
pretty reasonable thing to want for a documentation page.
 2022-10-15 11:38:42 -07:00
Dylan DPC 587b9c1a97 Rollup merge of #103025 - notriddle:notriddle/search-container-star, r=GuillaumeGomez 
rustdoc: remove unused CSS `.search-container > *`

The two items it was really intended to target were the buttons, and those both need to have the style set directly on them anyway because the buttons are both child elements of wrappers.

https://github.com/rust-lang/rust/blob/6b3ede3f7bc502eba7bbd202b4b9312d812adcd7/src/librustdoc/html/static/css/rustdoc.css#L1406-L1411
 2022-10-14 16:19:16 +05:30
Dylan DPC 20e1268d25 Rollup merge of #102914 - GuillaumeGomez:migrate-css-highlight-without-change, r=notriddle 
Migrate css highlight without change

This is a "previous" version of https://github.com/rust-lang/rust/pull/102663: only migrating to CSS variables, no changes. It's a bit more verbose because rules are not coherent between themes.

r? ``@notriddle``
 2022-10-14 16:19:13 +05:30
Michael Howell 513f699eac rustdoc: remove unused CSS .search-container > * 
The two items it was really intended to target were the buttons, and those
both need to have the style set directly on them anyway because the buttons
are both child elements of wrappers.
 2022-10-13 14:53:57 -07:00
Yuki Okushi e8029368d3 Rollup merge of #102980 - notriddle:notriddle/content, r=GuillaumeGomez 
rustdoc: merge separate `.item-info` CSS

Rough timeline:

* The longer `.content .item-info` selector originated in 110e7270ab. No reason seems to be given in the PR why it needed the `.content` part, but it was probably added because of <https://github.com/rust-lang/rust/blob/110e7270ab7b0700ce714b8b1c7e509195dea2c4/src/librustdoc/html/static/rustdoc.css#L476-L478>. That selector with the margin-bottom was removed when CSS containment was added in 8846c0853d.
* `.stability` was renamed `.item-info` in caf6c5790a.
* The selector without the `.content` was added in d48a39a5e2.
 2022-10-13 09:41:28 +09:00
Michael Howell f8da2295de rustdoc: merge separate .item-info CSS 
Rough timeline:

* The longer `.content .item-info` selector originated in
  110e7270ab. No reason seems to be given in
  the PR why it needed the `.content` part, but it was probably added because
  of <https://github.com/rust-lang/rust/blob/110e7270ab7b0700ce714b8b1c7e509195dea2c4/src/librustdoc/html/static/rustdoc.css#L476-L478>.
  That selector with the margin-bottom was removed when CSS containment
  was added in 8846c0853d.
* `.stability` was renamed `.item-info` in
  caf6c5790a.
* The selector without the `.content` was added in
  d48a39a5e2.
 2022-10-12 11:24:23 -07:00
Dylan DPC dcf7052b13 Rollup merge of #102936 - notriddle:notriddle/nav-sum, r=Dylan-DPC 
rustdoc: remove unused CSS `nav.sum`

This was added in 4fd061c426, but never actually used.
 2022-10-12 22:13:26 +05:30
Michael Howell 46169e6658 rustdoc: merge identical CSS selectors 2022-10-11 15:05:22 -07:00
Michael Howell 87060c42ff rustdoc: remove unused CSS nav.sum 
This was added in 4fd061c426, but never
actually used.
 2022-10-11 14:46:49 -07:00
Michael Howell 062284af6e rustdoc: remove unneeded .content selector from link colors 
Since 98f05a0282 and
b5963f07e6 removed color classes from sidebar
items, there's no need for the selectors to be so specific any more.

This commit does have to change `h1.fqn a` to just be `h1 a`, so that the
header link color selector is less specific than the typed link at the end.
Since #89506 made docblocks start at `h2`, the main page link header should
be the only h1 in the page now.
 2022-10-11 09:22:40 -07:00
Yuki Okushi 3011538b80 Rollup merge of #102898 - notriddle:notriddle/sidebar-block, r=GuillaumeGomez 
rustdoc: remove unneeded `<div>` wrapper from sidebar DOM

When this was added, the sidebar had a bit more complex style. It can be removed, now.

Preview: https://notriddle.com/notriddle-rustdoc-demos/sidebar-block/std/index.html
 2022-10-11 18:37:55 +09:00
Guillaume Gomez 202ccc50dd Migrate highlight style to CSS variables 2022-10-11 11:34:29 +02:00
Michael Howell b63b02f872 rustdoc: remove unneeded <div> wrapper from sidebar DOM 
When this was added, the sidebar had a bit more complex style. It can be
removed, now.
 2022-10-10 11:40:15 -07:00
Michael Howell 03fe005f49 rustdoc: clean up overly complex .trait-impl CSS selectors 
When added in 45964368f4, these multi-class
selectors were present in the initial commit, but no reason was given why
the shorter selector wouldn't work.
 2022-10-09 23:19:50 -07:00
Yuki Okushi fb27d01922 Rollup merge of #102799 - rol1510:issue-100421-fix, r=notriddle 
rustdoc: remove hover gap in file picker

Fixes #100421

Before:
<img width="385" alt="image" src="https://user-images.githubusercontent.com/29011024/194677087-fda2db3e-126d-47cf-8152-c554e3c25a54.png">

After:
<img width="388" alt="image" src="https://user-images.githubusercontent.com/29011024/194676774-7a50ace9-4060-492e-849a-ad85d9132630.png">

longe module names also wrap nicely:
<img width="389" alt="image" src="https://user-images.githubusercontent.com/29011024/194678516-f2497b3a-8d50-439b-9d69-3fa9fb43b84d.png">

Also if you zoom out very far, the arrows did move to the left, in relation to the text below. This is now also fixed.
<img width="818" alt="image" src="https://user-images.githubusercontent.com/29011024/194677652-cfdf129d-f5db-4f26-ac3c-3d0853e89619.png">

CSS doesn't have a lot of controll over the `::marker` element, so now the `::after` element is used to draw the arrows.

Now the whole line is clickable wihtout gaps.
 2022-10-10 00:09:41 +09:00
Roland Strasser 7fdce6498a rustdoc: fix file picker marker renders twice on ios 2022-10-09 11:02:44 +02:00
Matthias Krüger 92628633ee Rollup merge of #102815 - notriddle:notriddle/mobile-topbar, r=GuillaumeGomez 
rustdoc: remove mobile topbar from source pages instead of hiding it
 2022-10-08 23:32:05 +02:00
Michael Howell d2e14e2d11 rustdoc: remove mobile topbar from source pages instead of hiding it 2022-10-08 10:48:19 -07:00
Matthias Krüger b8ac02b27b Rollup merge of #102798 - notriddle:notriddle/text-decoration-underline, r=GuillaumeGomez 
rustdoc: add main-heading and example-wrap link CSS to big selector

This makes the stylesheet more consistent about how it handles link hover.
 2022-10-08 14:38:21 +02:00
Michael Howell b2369cb636 rustdoc: add main-heading and example-wrap link CSS to big selector 
This makes the stylesheet more consistent about how it handles link hover.
 2022-10-07 17:05:30 -07:00
Michael Howell 38743ec07d rustdoc: remove no-op CSS .rightside { position: initial } 
This CSS, added in 34bd2b845b, overrode CSS
that was applied to the `.since` class:

https://github.com/rust-lang/rust/blob/34bd2b845b3acd84c5a9bddae3ff8081c19ec5e9/src/librustdoc/html/static/rustdoc.css#L782-L795

The absolute positioning for `.since` was abandoned in favor of always
floating it, so this is no longer needed:

https://github.com/rust-lang/rust/commit/5de1391b88007a1d4f7b1517657a86aae352af1e#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413L902-L904
 2022-10-07 16:47:44 -07:00
Roland Strasser 468acca108 rustdoc: remove hover gap in file picker 2022-10-08 01:30:13 +02:00
Matthias Krüger d6c05fb9f1 Rollup merge of #102747 - notriddle:notriddle/docblock-a-not-srclink, r=GuillaumeGomez 
rustdoc: remove unused CSS `.docblock a:not(.srclink)`

This selector was added in c7312fbae4, because the list of impl items could be nested below `docblock`.

https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845

Now that rustdoc toggles have been switched to `<details>`, there shouldn't be any need to put things inside docblock containers just to give them disclosure toggles.
 2022-10-07 07:28:11 +02:00
Matthias Krüger a636398897 Rollup merge of #102744 - notriddle:notriddle/content-item-list, r=GuillaumeGomez 
rustdoc: remove unused CSS `.content .item-list`

When these rules were added in 4fd061c426 (yeah, that's the very first commit of rustdoc_ng), `.item-list` was a `<ul>`, and this would override the default style for that tag.

In c1b1d6804b, it was changed to use a `<div>` tag, so these rules are both no-ops.
 2022-10-07 07:28:10 +02:00
Michael Howell 28b26b7aa6 rustdoc: remove unused CSS .docblock a:not(.srclink) 
This selector was added in c7312fbae4,
because the list of impl items could be nested below `docblock`.

https://github.com/rust-lang/rust/blob/c7312fbae4979c6d4fdfbd1f55a71cd47d82a480/src/librustdoc/html/render.rs#L3841-L3845

Now that rustdoc toggles have been switched to `<details>`, there shouldn't
be any need to put things inside docblock containers just to give them
disclosure toggles.
 2022-10-06 11:21:42 -07:00
Michael Howell 50f662e99e rustdoc: remove unused CSS .content .item-list 
When these rules were added in 4fd061c426
(yeah, that's the very first commit of rustdoc_ng), `.item-list` was a
`<ul>`, and this would override the default style for that tag.

In c1b1d6804b, it was changed to use a
`<div>` tag, so these rules are both no-ops.
 2022-10-06 10:18:43 -07:00
Guillaume Gomez 694f0a1e35 Migrate search input color to CSS variable 2022-10-06 13:01:07 +02:00
Michael Howell 3cb03cb342 rustdoc: remove unused CSS class in-band 
Since a7c25b2957 removed `in-band` from code
headers, the only remaining uses of the `in-band` class are:

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/render/write_shared.rs#L520-L521

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/templates/print_item.html#L2-L3

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/render/context.rs#L637-L638

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/render/mod.rs#L368-L369

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/render/mod.rs#L401-L402

https://github.com/rust-lang/rust/blob/02cd79afb8080fce8c8ce35533c54d8ecf8f390e/src/librustdoc/html/static/js/main.js#L525

Since all of these uses are nested below `h1.fqn`, we can get rid of it,
and the support code that was used for when `in-band` was part of item
rendering.
 2022-10-05 16:56:07 -07:00
Dylan DPC 4c644cdbf6 Rollup merge of #102699 - GuillaumeGomez:fix-hamburger-button-color, r=Dylan-DPC 
Fix hamburger button color

Before:

![Screenshot from 2022-10-05 11-14-20](https://user-images.githubusercontent.com/3050060/194026621-e4df5750-92df-4194-a163-9787b45ace26.png)

After:

![Screenshot from 2022-10-05 11-14-15](https://user-images.githubusercontent.com/3050060/194026618-6a365623-5181-4174-b6af-66962e5ba6a5.png)

No need to backport it, beta doesn't seem affected.

r? `@notriddle`
 2022-10-05 17:27:34 +05:30
Guillaume Gomez 48b2a5d0b4 Fix hamburger button color in mobile sidebar 2022-10-05 11:19:53 +02:00
Michael Howell 8f8125ecfb rustdoc: remove no-op CSS .code-header { display: block } 
Since 76a3b609d0 converted code headers to
real headers, `display: block` is now the default.
 2022-10-04 08:37:10 -07:00