Commit Graph

1293 Commits

Author SHA1 Message Date
Michael Recachinas d504290839 Add edge case with env! arg to test and known problems 2018-04-02 21:14:29 +01:00
Michael Recachinas 511aa654d7 Change declare_lint! to declare_clippy_lint! 2018-04-02 00:25:57 +01:00
Michael Recachinas 62220abfa6 Add implementation and tests for literal checking in print/println format args 2018-04-01 23:19:53 +01:00
Philipp Hansch db1ec44616 Handle nested block comments 2018-03-30 12:36:50 +02:00
Philipp Hansch bb4af196be Move empty_line_after_outer_attribute to nursery
From the clippy side it's difficult to detect empty lines between
an attributes and the following item because empty lines and comments
are not part of the AST. The parsing currently works for basic cases
but is not perfect and can cause false positives.

Maybe libsyntax 2.0 will fix some of the problems around attributes but
comments will probably be never part of the AST so we would still have
to do some manual parsing.
2018-03-30 12:36:50 +02:00
Philipp Hansch b7929cafe1 Fix false positive in empty_line_after_outer_attr
Before, when you had a block comment between an attribute and the
following item like this:

```rust
\#[crate_type = "lib"]
/*

*/
pub struct Rust;
```

It would cause a false positive on the lint, because there is an empty
line inside the block comment.

This makes sure that basic block comments are detected and removed from
the snippet that was created before.
2018-03-30 12:36:50 +02:00
Manish Goregaokar b09e115404 Bump to 0.191 2018-03-30 10:38:42 +02:00
Manish Goregaokar 83748f5e48 Rustup to rustc 1.26.0-nightly (ae544ee1c 2018-03-29) 2018-03-30 10:35:51 +02:00
Manish Goregaokar 9887b972d4 Merge pull request #2589 from rust-lang-nursery/rangearg
Move RangeArgument
2018-03-29 16:21:45 +02:00
Oliver Schneider c1bbc173da Address review comments 2018-03-29 13:41:53 +02:00
Manish Goregaokar b75618206c Move RangeArgument 2018-03-29 13:13:27 +02:00
Oliver Schneider eafb9fe8df Update test suite 2018-03-28 23:49:32 +02:00
Oliver Schneider d6344c47e3 Categorize all the lints! 2018-03-28 15:24:26 +02:00
Oliver Schneider ef9fdbb8a9 Implementation + move one lint 2018-03-27 17:13:55 +02:00
Oliver Schneider 96d5af36f8 Version bump 2018-03-27 12:14:46 +02:00
Oliver Schneider b6e2c47df0 Merge pull request #2572 from flip1995/immut_while
Fix check of immutable condition in closure
2018-03-27 07:07:27 +02:00
Michael Wright 546d2fec29 Fix enum_glob_use false positives
Closes #2397.

This checks the def of the `ItemUse` path instead of checking the
capitalization of the path segements. It was noted that this def would
sometimes be `Def::Mod` instead of `Def::Enum` but it seems correct now.
2018-03-27 06:34:11 +02:00
flip1995 7d29075132 Skip the mutation in while body case for closures 2018-03-27 02:13:06 +02:00
flip1995 d458f22d89 Fix check of immutable condition in closure 2018-03-27 01:21:25 +02:00
Oliver Schneider b01b0083ba Merge pull request #2576 from kimsnj/infinite_loop
while_immutable_condition: fix handling of self
2018-03-27 00:06:16 +02:00
Karim Snj 737247e50e while_immutable_condition: limit suggestion span to condition 2018-03-26 23:24:57 +02:00
Karim Snj 85bcaad412 while_immutable_condition: fix handling of self 2018-03-26 23:16:54 +02:00
Philipp Hansch 034c81b761 Fix false positive in empty_line_after_outer_attribute
`empty_line_after_outer_attribute` produced a false positive warning when
deriving `Copy` and/or `Clone` for an item.

It looks like the second point in [this comment][that_comment] is related,
as the attribute that causes the false positive has a path of
`rustc_copy_clone_marker`.

Fixes #2475

[that_comment]: https://github.com/rust-lang/rust/issues/35900#issuecomment-245978831
2018-03-26 21:57:42 +02:00
Oliver Schneider 9fb63d5fc4 Merge pull request #2574 from mark-i-m/i128
i128 is stabilizing
2018-03-26 07:04:42 +02:00
Mark Mansi f25d4fd253 make it pass for now 2018-03-25 21:04:05 -05:00
Mark Mansi a4d869ca76 i128 is stable 2018-03-25 20:35:23 -05:00
Michael Wright 70d8f85e7e Minor refactoring (walk_ptrs_ty_depth)
Replace `walk_ptrs_ty_depth` with `walk_ptrs_ty` when the depth value is
ignored.
2018-03-21 20:10:10 +02:00
Oliver Schneider 2d01f42dde Merge pull request #2539 from Baelyk/master
Add suggestion to useless_format
2018-03-20 08:22:04 +01:00
Baelyk 48027105dc Add suggestion to useless_format
Resolves #2505

Suggests that you use `"foo".to_string()` instead of `format!("foo")`.
2018-03-19 09:27:15 -05:00
Oliver Schneider 47a706682c Version bump 2018-03-19 09:26:05 +01:00
Oliver Schneider 4edd140e57 Rustup 2018-03-18 13:26:57 +01:00
flip1995 ad459184a3 Don't lint comparison operators in arithmetic impls 2018-03-17 22:02:34 +01:00
flip1995 4fdc81dd7a Check if the panic message was created by the assert-macro 2018-03-17 21:19:32 +01:00
Mateusz Mikuła 3b387eaabe Allow float_cmp in consts lint code
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-16 11:36:14 +01:00
Mateusz Mikuła c7770bf907 Remove attributes for stable features
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-16 11:09:05 +01:00
Mateusz Mikuła 4c94dd238f Fix BiRem for floats
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-16 10:54:49 +01:00
Mateusz Mikuła cfb9b982c5 Apply clippy suggestions
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-16 10:54:49 +01:00
Oliver Schneider 8749927973 Rustup 2018-03-16 09:44:20 +01:00
Mateusz Mikuła a54e4661b7 Fix warning
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-15 13:24:51 +01:00
Mateusz Mikuła 3662ee76ab Merge branch 'miri' 2018-03-15 10:49:13 +01:00
Mateusz Mikuła fd6542d0de Rustup
Signed-off-by: Mateusz Mikuła <mati865@gmail.com>
2018-03-15 10:25:40 +01:00
Oliver Schneider 21f387d278 Update dependencies 2018-03-13 16:54:13 +01:00
Oliver Schneider f7b2578aea Update to rustc master 2018-03-13 11:38:21 +01:00
Hidehito Yabuuchi d637163435 Fix comment 2018-03-11 14:03:09 +09:00
Hidehito Yabuuchi ed769a3bc4 Ignore all macros in redundant_field_names 2018-03-11 13:57:28 +09:00
Karim Snj ae5354e6ef lint: while immutable condition: do not lint constants 2018-03-07 18:25:09 +01:00
Oliver Schneider 4cf02c7e1a Merge pull request #2483 from kimsnj/infinite_loop
immutable while condition
2018-03-07 08:09:48 +01:00
Oliver Schneider 7d5ecd5ad5 Merge pull request #2511 from flip1995/sus_impl
UnNeg and UnNot count as additional operations now
2018-03-06 14:35:54 +01:00
Niklas Fiekas d55890a2b1 Increase unreadable_literal digits (fixes #1958) 2018-03-06 14:24:01 +01:00
flip1995 ed4535641b UnNeg and UnNot count as additional operations now 2018-03-06 13:58:03 +01:00