Commit Graph

100 Commits

Author SHA1 Message Date
flip1995 e674d0a599 Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup 2021-11-04 12:52:36 +00:00
flip1995 f2f2a005b4 Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup 2021-03-12 15:30:50 +01:00
flip1995 d3d2018ead Merge commit '3e7c6dec244539970b593824334876f8b6ed0b18' into clippyup 2020-11-23 13:51:04 +01:00
flip1995 34244190d4 Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup 2020-11-05 14:29:48 +01:00
flip1995 282c59820b Merge commit '3d0b0e66afdfaa519d8855b338b35b4605775945' into clippyup 2020-08-28 18:43:25 +02:00
Rabi Guha c2e5534157 Check fn header along with decl when suggesting to implement trait
When checking for functions that are potential candidates for trait
implementations check the function header to make sure modifiers like
asyncness, constness and safety match before triggering the lint.

Fixes #5413, #4290
2020-04-08 21:24:20 +05:30
Micha Ober c5046fdce5 Add real suggestion to option_map_unwrap_or 2019-12-28 23:24:45 +01:00
Heinz N. Gies 7f454d8d06 Split out tests 2019-10-18 07:40:48 +02:00
James Wang e23a424b31 Change lint to be pedantic 2019-10-15 09:58:11 +02:00
Andre Bogus cc622608db new lints around #[must_use] fns
`must_use_unit` lints unit-returning functions with a `#[must_use]`
attribute, suggesting to remove it.

`double_must_use` lints functions with a plain `#[must_use]`
attribute, but which return a type which is already `#[must_use]`,
so the attribute has no benefit.

`must_use_candidate` is a pedantic lint that lints functions and
methods that return some non-unit type that is not already
`#[must_use]` and suggests to add the annotation.
2019-10-14 12:09:04 +02:00
BO41 64cd9e4d60 Try to fix .fixed 2019-09-03 18:56:23 +02:00
BO41 945d4cf69f Dereference one less on search_is_some and make it auto-fixable 2019-08-29 17:34:02 +02:00
Lzu Tao 2a66196013 Remove feature gate for async_await 2019-08-20 23:21:39 +00:00
Lukas Markeffsky d55315808d fixed tests (again) and added a test that should actually cause a warning for new_ret_no_self 2019-08-09 23:15:49 +02:00
Lukas Markeffsky 54efffcec1 removed unused imports #2 2019-08-09 19:47:25 +02:00
Lukas Markeffsky 1d2c23a2a5 removed unused imports 2019-08-09 19:44:20 +02:00
Lukas Markeffsky 4fbe9f67ee upgrade test to rust 2018 2019-08-09 19:19:49 +02:00
Lukas Markeffsky d7b9a845aa new_ret_no_self: walk associated types in impl Trait return types 2019-08-09 17:44:05 +02:00
Philipp Hansch 533abfa613 UI Test Cleanup: No wrong_self_convention in methods.rs
These cases are already covered in `tests/ui/wrong_self_convention.rs`.

cc #2038
2019-08-01 06:54:57 +02:00
Michael Wright 98585a0324 Fix .map(..).unwrap_or_else(..) bad suggestion
Closes #4144
2019-06-02 08:50:20 +02:00
airt 2d4d275519 change |&x| to |x| in stderr file 2019-05-01 01:06:15 +08:00
Philipp Hansch 0f69aac3d9 Add run-rustfix for option_map_or_none lint 2019-04-18 08:12:59 +02:00
Philipp Hansch 25e2affd31 UI test cleanup: Extract iter_nth tests 2019-04-11 08:23:43 +02:00
Philipp Hansch fdc2255e81 UI test cleanup: Extract or_fun_call tests 2019-04-11 07:47:04 +02:00
flip1995 3282955238 Update tests 2019-03-10 22:07:10 +01:00
Wilco Kusee eb70a72459 Fix false negative 2019-02-26 17:29:36 +01:00
Wilco Kusee 54ab22f6db Only suggest map_or for copy types 2019-02-26 17:27:40 +01:00
Michael Wright 7a43509cc4 rustfmt tests/ui/methods.rs 2019-02-22 08:05:21 +02:00
Michael Wright b96c4329db Add #[rustfmt::skip] to methods tests
Many people run rustfmt automatically on save. Format-dependent tests
should be marked with `#[rustfmt::skip]` to prevent accidental
reformatting from this. As a bonus the rest of the code can the formatted.
2019-02-22 07:49:17 +02:00
Philipp Hansch 38d4ac7cea Remove all copyright license headers
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
Philipp Hansch a5d3f37c5a Use compiletest's aux-build header instead of include macro 2019-01-02 22:48:44 +01:00
Philipp Hansch 0c54913afe Extract IteratorFalsePositives into option_helpers.rs
This was previously duplicated in #3605
2019-01-02 07:49:28 +01:00
Philipp Hansch eaaee23847 UI test cleanup: Extract lint from methods.rs test 2019-01-02 07:23:00 +01:00
Philipp Hansch 8c4c458ee9 UI test cleanup: Extract iter_skip_next from methods.rs
cc #2038
2018-12-30 13:46:21 +01:00
Russell Greene d127aed737 Merge new_without_default_derive into new_without_default 2018-12-28 10:57:58 -07:00
flip1995 d2dbd0b8a5 Update *.stderr files 2018-12-28 12:41:12 +01:00
Matthias Krüger 9b839cd4b5 update line numbers of tests 2018-12-09 17:24:08 +01:00
Philipp Hansch 26569f3dde UI test cleanup: Extract expect_fun_call tests
Note that the new stderr file does not include a `shadow-unrelated`
error, because the new UI test file does not use `#![warn(clippy::all)]`
2018-11-02 07:18:56 +01:00
Philipp Hansch 840e50e97f Don't expand macro in or_fun_call suggestion 2018-10-27 15:47:56 +02:00
Josh Mcguigan 348d18ebd8 Removed new_ret_no_self tests from method.rs 2018-10-13 06:25:10 -07:00
Michael Wright 7499cb543d Fix #2937 2018-10-10 07:52:58 +02:00
Manish Goregaokar e9c025ea70 Add license header to Rust files 2018-10-06 09:43:08 -07:00
flip1995 e9af09c274 Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
Dale Wijnand 7933d445d1 Move shadow_unrelated to pedantic 2018-08-14 09:52:27 +01:00
Michael Wright 534d546c81 Fix #2979 2018-08-02 08:56:53 +02:00
Michael Wright b90fc5edfa Fix #2894 2018-07-15 10:38:40 +02:00
Daniel Wagner-Hall d3124731b7 Fix some existing test expectations 2018-06-14 23:13:12 +01:00
Donald Robertson 451fd5feb9 Extracting arguments to format to pass directly to panic when appropriate 2018-06-05 21:15:08 +01:00
Donald Robertson 1ead12c500 Adding handling and tests for custom type with implemented expect method 2018-06-04 19:43:03 +01:00
Donald Robertson fe8c9d5965 Ensuring correct lint message is output for Option and Result type 2018-06-04 19:43:03 +01:00