Commit Graph

58 Commits

Author SHA1 Message Date
Aleksey Kladov d4a51241ce internal: explain why sentence-per-line 2021-05-06 17:40:36 +03:00
Aleksey Kladov 3f6980e4e1 simplify macro expansion code
Using `Option` arguments such that you always pass `None` or `Some` at
the call site is a code smell.
2021-05-04 22:41:46 +03:00
Laurențiu Nicola bb4952da04 internal: Add guidelines for release notes PR descriptions 2021-04-19 21:30:44 +03:00
Jonas Schievink 6e575d8c73 Fix typo in style guide 2021-04-15 18:38:52 +02:00
Aleksey Kladov db2a989565 internal: don't use #[should_panic] for tests 2021-04-13 12:21:59 +03:00
Kirill Bulatov b5f3815aee Small grammar fixes 2021-04-06 21:42:27 +03:00
Aleksey Kladov a01fd1af19 internal: explain "extract if condition" refactoring 2021-04-05 13:02:47 +03:00
Aleksey Kladov 636c3c49d2 internal: document style for helper functions and variables 2021-04-02 14:52:00 +03:00
Aleksey Kladov 27b779d1fd internal: document Cargo.lock maintenance process 2021-04-02 13:59:36 +03:00
Aleksey Kladov 30dea3a727 Prefer match to if let else 2021-03-16 10:51:05 +03:00
Laurențiu Nicola dd9974c59d Fix cargo xtask lint references 2021-03-14 15:24:34 +02:00
Laurențiu Nicola fc9eed4836 Use upstream cov-mark 2021-03-08 22:19:44 +02:00
Aleksey Kladov e15621482c Clarify comparison rule 2021-03-03 11:23:05 +03:00
azzamsa ae50b18503 Fix typos 2021-02-20 17:53:19 +07:00
Aleksey Kladov 799810eaaa Document config pattern 2021-02-12 18:10:16 +03:00
Lukas Wirth f82ce500a9 Fix spelling mistakes in docs/dev 2021-02-03 13:46:51 +01:00
Aleksey Kladov 283c3b0133 add useless types to the styleguide 2021-02-02 15:41:57 +03:00
Aleksey Kladov d35bda6429 Make always-assert crate reusable 2021-01-26 22:13:42 +03:00
Laurențiu Nicola f0cffb66b3 Fix typo in style guide 2021-01-25 14:14:43 +02:00
Aleksey Kladov e54a398bfb Promote marks 2021-01-22 17:58:00 +03:00
Aleksey Kladov 4c92ef03ac Style: use the right string 2021-01-22 15:29:31 +03:00
Aleksey Kladov 74f8201586 Avoid intermediate collections 2021-01-20 14:49:29 +03:00
Aleksey Kladov 724059569b Don't show runnable suggestions for other files
It't be actually great to have these once we have run anything dialog,
but for run the thing at point it makes sense to show a limited set.
2021-01-20 14:30:50 +03:00
Aleksey Kladov 8dc68ecdfc Introduce more appropriate assertion mechanism
rust-analyzer is a long-running program, so we *should* handle assertion
failures.

See also https://www.sqlite.org/assert.html.
2021-01-14 18:25:19 +03:00
Aleksey Kladov 2d0464a6f3 Encourage gifs 2021-01-11 16:29:29 +03:00
Laurențiu Nicola a7db8abab7 Use T! for bool keywords 2021-01-10 17:47:12 +02:00
Aleksey Kladov 8f994dda68 typo 2021-01-07 20:27:22 +03:00
Aleksey Kladov 5aed769afe Styleguide readability 2021-01-07 20:11:55 +03:00
Aleksey Kladov eb710a63ca Document std::ops style 2021-01-07 19:27:47 +03:00
Kevaundray Wedderburn 72b9a4fbd3 Change <|> to $0 - Rebase 2021-01-07 12:09:23 +00:00
Aleksey Kladov 9c0c5f8e37 Improve commit message style 2020-12-28 13:43:07 +03:00
Aleksey Kladov 51f42db1d5 Add # to canonical test example 2020-12-15 11:49:22 +03:00
Aleksey Kladov 17f236c2b0 Normalize spelling to American English 2020-12-10 17:51:56 +03:00
Aleksey Kladov 9b1d4cc8ab don\t indent tests 2020-11-06 20:29:41 +01:00
Aleksey Kladov 412d6b3db5 Update docs/dev/style.md
Co-authored-by: Laurențiu Nicola <lnicola@users.noreply.github.com>
2020-11-02 12:17:34 +01:00
Aleksey Kladov 4318828f21 Document doer object anti-pattern 2020-11-02 12:13:59 +01:00
Aleksey Kladov 0c67edc0f7 Expand code order section 2020-10-16 12:50:09 +02:00
Aleksey Kladov 86cc93ebe3 Document awkward names 2020-10-15 18:14:30 +02:00
Aleksey Kladov dedfaa3844 Cleanup alloc advice 2020-10-15 12:21:38 +02:00
Aleksey Kladov 9c285b0341 Style: default over new 2020-10-14 20:02:03 +02:00
Aleksey Kladov 5359e8f742 minor 2020-10-07 13:11:33 +02:00
Aleksey Kladov 1688e481b3 minor 2020-10-07 13:03:13 +02:00
Aleksey Kladov 6976494781 Add comparisons guideline to style 2020-10-07 12:57:49 +02:00
Aleksey Kladov fdf2f6226b Reorg style 2020-10-07 12:50:46 +02:00
Aleksey Kladov 0599e64bb2 Document Clippy strategy 2020-10-02 10:13:58 +02:00
Laurențiu Nicola 2233749692 Improve grammar and fix code example in style guide 2020-10-01 21:02:39 +03:00
Aleksey Kladov b069c1c69a More style advice 2020-09-29 14:42:09 +02:00
Aleksey Kladov 4f5d2ffac2 fmt import 2020-08-28 16:53:49 +02:00
bors[bot] 951c7c157a Merge #5852
5852: Add Early Return rule to style r=matklad a=matklad

bors r+

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-08-24 10:56:04 +00:00
Aleksey Kladov fc3e591bdb Avoid monomorphization 2020-08-24 12:49:36 +02:00