6a204e2dec
use Rust SnakeCase
2022-06-29 22:17:46 -04:00
5974e7d4a9
Auto merge of #2287 - RalfJung:field-retagging, r=RalfJung
...
stacked borrows: add option for recursive field retagging
2022-06-29 23:04:07 +00:00
c4e86e103e
add option for recursive field retagging
2022-06-29 18:22:30 -04:00
73a1a27a45
Support gettimeofday on more than macos
...
This appears to be in linux and in openbsd as well:
* https://github.com/torvalds/linux/blob/master/lib/vdso/gettimeofday.c
* https://github.com/openbsd/src/blob/master/sys/sys/time.h#L439
Co-authored-by: Ralf Jung <post@ralfj.de >
2022-06-29 17:48:04 -04:00
839c120b40
fmt
2022-06-29 10:09:18 -04:00
f389d46b04
also prune caller_location frames when backtrace=off
2022-06-29 09:33:12 -04:00
28dea673be
rustup
2022-06-29 08:33:06 -04:00
8bd4bbe3e4
tweak int2ptr diagnostics
2022-06-28 08:52:22 -04:00
aaaed51ab8
Auto merge of #2279 - RalfJung:adjacent-allocs, r=RalfJung
...
Allow non-ZST allocations to be adjacent
Also `cargo update` in test-cargo-miri... no need to make a separate PR for that right?...
2022-06-28 02:52:23 +00:00
c16b380d6b
finally we can actually have adjacent allocations :)
2022-06-27 22:52:02 -04:00
098704e10f
make use of get_alloc_info
2022-06-27 21:22:46 -04:00
7fafbde038
Auto merge of #2275 - RalfJung:permissive-provenance-for-all, r=RalfJung
...
Enable permissive provenance by default
This completes the plan laid out in https://github.com/rust-lang/miri/issues/2133 :
- We use permissive provenance with wildcard pointers by default.
- We print a warning on int2ptr casts. `-Zmiri-permissive-provenance` suppresses the warning; `-Zmiri-strict-provenance` turns it into a hard error.
- Raw pointer tagging is now always enabled, so we remove the `-Zmiri-tag-raw-pointers` flag and the code for untagged pointers. (Passing the flag still works, for compatibility -- but we just ignore it, with a warning.)
We also fix an intptrcast issue:
- Only live allocations are considered when computing the AllocId from an address.
So, finally, Miri has a good story for ptr2int2ptr roundtrips *and* no weird false negatives when doing raw pointer stuff with Stacked Borrows. :-) 🎉 Thanks a lot to everyone who helped with this, in particular `@carbotaniuman` who convinced me this is even possible.
Fixes https://github.com/rust-lang/miri/issues/2133
Fixes https://github.com/rust-lang/miri/issues/1866
Fixes https://github.com/rust-lang/miri/issues/1993
2022-06-28 01:20:40 +00:00
c1eddbc7fe
show int2ptr warning once for each span (but don't duplicate the long help)
2022-06-27 20:50:45 -04:00
67e89b53e2
fix warning text
2022-06-27 20:04:46 -04:00
5719897fb0
improve old comment
2022-06-27 13:38:32 -04:00
d9e7a3ae82
typo
...
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de >
2022-06-27 09:08:56 -04:00
b479f092a8
avoid unnecessary indirection in miri-track-raw-pointers warning
2022-06-26 23:14:16 -04:00
1a5dfbeb7a
fmt
2022-06-26 22:36:45 -04:00
5c16713056
remove support for untagged pointers
...
good riddance!
2022-06-26 22:19:56 -04:00
294ef15adb
more int2ptr cast tests, and fix casting of addresses inside dead allocations
2022-06-26 22:19:56 -04:00
13d425daeb
make permissive provenance and raw-ptr tagging the default
2022-06-26 21:14:42 -04:00
aa072d72cc
Cargo fmt
2022-06-27 01:39:25 +02:00
84a02787d8
Address code review
...
- Merge pthread_attr_getstack shim to unix/foreign_items.rs
2022-06-27 01:39:24 +02:00
93c61f3905
Add pthread_attr_get_np shim
2022-06-27 01:39:24 +02:00
f2cbd3e2bc
Add pthread_attr_getstack shim
2022-06-27 01:39:24 +02:00
e89b4d6df2
Fix panicking ui_tests framework
2022-06-27 01:39:24 +02:00
97a512070a
Fix pending reviews
2022-06-27 01:39:24 +02:00
9130034337
Initial freebsd work
2022-06-27 01:39:24 +02:00
34be937d5f
add -Zmiri-report-progress to regularly print a stacktrace of what we are executing
2022-06-26 14:31:57 -04:00
1589ba3bbc
Auto merge of #2264 - RalfJung:not-a-fixme, r=RalfJung
...
remove a FIXME that is not actually a bug
2022-06-25 15:54:31 +00:00
f66c64bed2
remove a FIXME that is not actually a bug
2022-06-25 11:52:29 -04:00
58c79c5b6f
tweaks and feedback
2022-06-24 22:02:17 -04:00
4fbb284a99
implement 'delimited' expose tracking so we still detect some UB
2022-06-24 20:05:56 -04:00
8d6fdaa024
make the tests pass
...
(and some formatting)
2022-06-24 18:03:02 -04:00
c0f7118342
reorganize exposure code a bit
2022-06-24 16:45:22 -04:00
d1e7de117c
Try fix stuff
2022-06-24 16:10:23 -04:00
c7feb014b0
Maybe this wil work
2022-06-24 16:10:23 -04:00
57ce47b728
Handle wildcard pointers in SB
2022-06-24 16:10:23 -04:00
655eed35b7
Auto merge of #2248 - RalfJung:arc-drop-fix, r=RalfJung
...
do not protect SRW items
This is the Miri version of https://github.com/rust-lang/rust/pull/98017 .
2022-06-22 21:39:41 +00:00
f992099820
fix ICE when const refers to extern static
2022-06-21 21:03:40 -07:00
8d1b2ca3ec
check that tag_alloc_base_pointer is not called on the wrong things
2022-06-21 21:03:40 -07:00
1b214a0d12
do not protect SRW items
2022-06-21 09:32:58 -07:00
c4dd3f4ef9
Auto merge of #2228 - cbeuw:futex-fix, r=RalfJung
...
Prevent futex_wait from actually waiting if a concurrent waker was executed before us
Fixes #2223
Two SC fences were placed in `futex_wake` (after the caller has changed `addr`), and in `futex_wait` (before we read `addr`). This guarantees that `futex_wait` sees the value written to `addr` before the last `futex_wake` call, should one exists, and avoid going into sleep with no one else to wake us up.
https://github.com/rust-lang/miri/blob/ada7b72a879d79aaa06f0a2a95edd520615da1a2/src/concurrency/weak_memory.rs#L324-L326
Earlier I proposed to use `fetch_add(0)` to read the latest value in MO, though this isn't the proper way to do it and breaks aliasing: syscall caller may pass in a `*const` from a `&` and Miri complains about write to a `SharedReadOnly` location, causing this test to fail.
https://github.com/rust-lang/miri/blob/ada7b72a879d79aaa06f0a2a95edd520615da1a2/tests/pass/concurrency/linux-futex.rs#L56-L68
2022-06-18 15:10:56 +00:00
737a5b3b98
tweak correctness comment
2022-06-18 07:59:46 -07:00
807a19a50a
Elaborate correctness comments
2022-06-15 01:44:32 +01:00
2bbb70f584
Auto merge of #2203 - RalfJung:deprecate, r=oli-obk
...
deprecate -Zmiri-allow-uninit-numbers and -Zmiri-allow-ptr-int-transmute
Cc https://github.com/rust-lang/miri/issues/2187 https://github.com/rust-lang/miri/issues/2188
2022-06-13 10:23:42 +00:00
238bbd63ab
Add #![feature(yeet_expr)]
2022-06-12 18:39:44 -07:00
03a05ae211
Auto merge of #2195 - RalfJung:vtable-validation, r=RalfJung
...
test for Stacked Borrows error during vtable validation
Fixes https://github.com/rust-lang/miri/issues/2123
Needs https://github.com/rust-lang/rust/pull/97761
2022-06-12 05:34:22 +00:00
c3b8509654
rename ExperimentalUb → StackedBorrowsUb
2022-06-11 17:42:23 -07:00
b6bcbf76fd
Prevent futex_wait from reading outdated value
2022-06-11 20:45:45 +01:00
Ralf Jung