9fbbb8f609
Don't use the reserved error code
2019-01-26 20:58:50 +00:00
d9456c3989
Return an lsp error
2019-01-26 20:43:51 +00:00
0974e6abeb
Merge #682
...
682: remove Option<SourceFileItemId> hack r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 20:27:30 +00:00
a128075af9
remove Option<SourceFileItemId> hack
2019-01-26 23:27:01 +03:00
632b0f2902
Use the correct working directory for cargo metadata and rustfmt
2019-01-26 20:16:15 +00:00
9c1a18a626
store syntax ptr in FileItems
...
we cache the tree in file_item query anyway
2019-01-26 22:48:04 +03:00
ae97a45c35
remove dead code
2019-01-26 22:43:07 +03:00
2d337c88b0
Merge #680
...
680: Struct literals should not be a `BlockLike::Block` r=DJMcNab a=DJMcNab
Fix #674 .
Co-authored-by: DJMcNab <36049421+djmcnab@users.noreply.github.com >
2019-01-26 19:17:48 +00:00
7a76433c45
Struct literals should not be a BlockLike::Block
2019-01-26 18:45:29 +00:00
1662eb1f8d
Merge #679
...
679: ⬆️ salsa r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 18:24:30 +00:00
a1fb8efd7a
⬆️ salsa
2019-01-26 21:23:59 +03:00
d0ef1bde89
Merge #676
...
676: ⬆️ rowan r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 16:41:40 +00:00
6f862a6704
⬆️ rowan
...
The new rowan uses arena allocator for red nodes which helps
slightly (5% on std completion test) with performance but should help
quite a bit with avoiding memory fragmentation.
2019-01-26 19:39:31 +03:00
a892067951
Make doc comments optional
2019-01-26 10:35:23 -05:00
a8d32c4d1a
Merge #671
...
671: Makre VFS slightly less super obscure r=vemoo a=matklad
I've decided to better understand what we do in VFS, and this turns out to be really hard. Jugling threads and channels is one of the most unfortunately arcane bits of rust...
I had some success though by flattenning the structure so that all channel & thread creation routines are on one screen.
r? @vemoo
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 15:13:44 +00:00
e9e0ea0398
Do not unconditionally trim comments
2019-01-26 09:55:30 -05:00
8c08b6825e
Preserve indentation in doc comments
2019-01-26 09:50:17 -05:00
9f16892b94
remove watcher ctx
2019-01-26 17:17:28 +03:00
bf98fc609e
remove mutexes
2019-01-26 17:04:00 +03:00
012ea3fac6
handle all the reads on the "main" watcher thread
2019-01-26 17:01:58 +03:00
3ce531f95d
cleanup: add result alias
2019-01-26 16:40:24 +03:00
390a20787e
consolidate error handling
2019-01-26 16:28:04 +03:00
20d7a431fd
refactor-fvs
2019-01-26 16:28:04 +03:00
5af7b2f4af
Merge #673
...
673: minor cleanups r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 13:26:56 +00:00
bf7a0f43d0
minor cleanups
2019-01-26 16:26:30 +03:00
3feaf2a008
Merge #659
...
659: Fold blocks of mod items r=matklad a=eulerdisk
Fixes #572
As requested, we ignore `mod`s with a visibility specifier.
Co-authored-by: Andrea Pretto <eulerdisk@gmail.com >
2019-01-26 12:49:08 +00:00
05d0c493c9
Merge #672
...
672: dont overwrite memfies r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 12:42:14 +00:00
07a4b9f1a0
dont overwrite memfies
2019-01-26 15:41:52 +03:00
b9ca8ab868
Better visibility check.
2019-01-26 13:32:48 +01:00
2acaa92c93
Merge #660
...
660: Support macro calls in type position r=matklad a=regiontog
A [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fdc6dd4ddaece92a72fa2a292b75e27c ) demonstrating the syntax in question.
Co-authored-by: Erlend Tobiassen <erlend.tobiassen@gmail.com >
2019-01-26 10:23:28 +00:00
8b6dea348f
Merge #666
...
666: rename source_file -> parse r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2019-01-26 08:55:38 +00:00
9457b1f0e6
rename source_file -> parse
2019-01-26 11:51:36 +03:00
c869ee219a
Merge #665
...
665: Pr 556 r=matklad a=matklad
Rebased #556
Thanks @vemoo, now I can change branches without reopening VS Code!
Co-authored-by: Bernardo <berublan@gmail.com >
2019-01-26 08:47:56 +00:00
410a3ae6e8
use entry file_type, improve test
2019-01-26 11:46:37 +03:00
d63e1cebff
use Roots in watcher
2019-01-26 11:46:37 +03:00
86fadbd4e5
extract Roots struct
2019-01-26 11:46:37 +03:00
cfbf47b002
review fixes
2019-01-26 11:46:37 +03:00
34a34f9399
use released notifiy version, add TODO comment
2019-01-26 11:46:37 +03:00
be14ab217c
better test, avoid duplicated events
2019-01-26 11:46:27 +03:00
0a08650852
hardcode ".git" and "node_modules" also
2019-01-26 11:46:27 +03:00
10a24cf649
simplify and optimize RootFilterby determining if is contained first
2019-01-26 11:46:27 +03:00
eeed6cf53b
fix recursive watch
2019-01-26 11:46:27 +03:00
2a1afad3ed
avoid boxing
2019-01-26 11:46:27 +03:00
277e0f1baa
move watcher to io module
2019-01-26 11:46:27 +03:00
7f7c4e7465
do not emit create for directory again
2019-01-26 11:46:27 +03:00
f88355ccb5
refactor, put watcher with io::Worker
...
use `RootFilter` to filter recursive watches
untested
2019-01-26 11:46:27 +03:00
eacf7aeb42
ignore check event dir for ignore, cleanup tests
2019-01-26 11:46:27 +03:00
fb1d748a2c
actually drop watcher, use parking_lot::Mutex
2019-01-26 11:46:27 +03:00
f181e36a44
handle recursive watching ourselves
2019-01-26 11:46:27 +03:00
e69b620f0d
add missing Task::HandleChange
2019-01-26 11:46:27 +03:00
DJMcNab