f29796da61
Replace if let Some(_) = foo with if foo.is_some()
2021-10-05 09:00:18 +11:00
a248f39cb4
make Some(1..) parsed
2021-10-04 17:33:48 +08:00
eff195852d
Fix miscellaneous Clippy lints
2021-10-03 23:53:30 +11:00
55c0b86cde
Add semicolons for consistency
...
`clippy::semicolon_if_nothing_returned`
2021-10-03 23:39:43 +11:00
ebe6c38a44
Merge #10438
...
10438: minor: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-10-03 11:06:06 +00:00
0943c4be8b
minor: Simplify
2021-10-03 13:05:42 +02:00
61643513b6
fix: await insertion with try_expr during extract_function
2021-10-03 09:41:21 +00:00
116c7aef7f
move outer_attrs call before the match
2021-10-03 09:22:02 +08:00
7dbf24fc7a
minor: dead code
2021-10-02 15:42:10 +03:00
d5c5b7cd12
internal: remove deprecated method
2021-10-02 15:28:55 +03:00
f04f8ddb0d
minor: regen
2021-10-02 15:20:16 +03:00
f3a1ff786f
minor: generated code readability
2021-10-02 15:20:03 +03:00
0ee6b70b34
Parse outer attributes on StructPatternEtCetera
2021-10-02 09:57:44 +08:00
774a8cf08b
Fix inline_call breaking RecordExprField shorthands
2021-09-28 19:22:32 +02:00
b6ed91a6de
Rename *Owner traits to Has*
2021-09-27 12:54:24 +02:00
a28c5d7311
Rename Dyn* nodes to Any* nodes
2021-09-27 12:45:36 +02:00
2bf81922f7
internal: more reasonable grammar for blocks
...
Consider these expples
{ 92 }
async { 92 }
'a: { 92 }
#[a] { 92 }
Previously the tree for them were
BLOCK_EXPR
{ ... }
EFFECT_EXPR
async
BLOCK_EXPR
{ ... }
EFFECT_EXPR
'a:
BLOCK_EXPR
{ ... }
BLOCK_EXPR
#[a]
{ ... }
As you see, it gets progressively worse :) The last two items are
especially odd. The last one even violates the balanced curleys
invariant we have (#10357 ) The new approach is to say that the stuff in
`{}` is stmt_list, and the block is stmt_list + optional modifiers
BLOCK_EXPR
STMT_LIST
{ ... }
BLOCK_EXPR
async
STMT_LIST
{ ... }
BLOCK_EXPR
'a:
STMT_LIST
{ ... }
BLOCK_EXPR
#[a]
STMT_LIST
{ ... }
2021-09-26 19:16:09 +03:00
c51a3c78cf
Merge #10358
...
10358: internal: Remove inherent methods from ast nodes that do non-syntactic complex tasks r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-09-26 14:49:25 +00:00
151afdfe5c
Remove inherent methods from ast node that carry semantic meaning
2021-09-26 16:49:03 +02:00
defe805fb7
internal: fix and force-disable block validation ;-(
...
Originally we tried to maintain the invariant that `{}` always match.
That is, that in the parse tree the pair of corresponding `{}` is always
first and last tokens of some nodes.
We had the code to validate that, but apparently it's been broken for
**years** since we introduced tokens/nodes split. Fixing it now makes
some tests fail.
It's unclear if we want to keep this invariant: there's a strong
motivation for breaking it in the following case:
```
use std::{ // unclosed paren
fn main() {
}
} // don't actually want to pair up this with the one from `use`
```
So let's fix the code, but disable it for the time being
2021-09-26 15:49:23 +03:00
56964c9bd3
feat: allow attributes on all expressions
...
Attrs are syntactically valid on any expression, even if they are not
allowed semantically everywhere yet.
2021-09-25 22:19:27 +03:00
0cb9ee2054
Merge #10346
...
10346: minor: align code with code-style r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2021-09-25 11:56:23 +00:00
5767f31cbf
minor: align code with code-style
2021-09-25 14:55:42 +03:00
929fca5adc
minore: improve consistency
2021-09-25 14:36:46 +03:00
f27cda6865
minor: more condensed tests
2021-09-25 14:24:57 +03:00
1567bbb73e
minor: more focusted tests
2021-09-25 14:04:27 +03:00
42eb4efb5b
Cleanup
2021-09-23 16:28:03 +02:00
83e97adfff
Simplify
2021-09-21 16:15:30 +02:00
b36f12dba5
Simplify
2021-09-21 16:05:21 +02:00
6d6e0b8f21
Generate ast nodes for each ast trait
2021-09-21 15:52:11 +02:00
b7bedf16a1
Merge #10289
...
10289: fix: Only strip derive attributes when preparing macro input r=Veykril a=Veykril
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/10246
cc https://github.com/rust-analyzer/rowan/pull/114 , follow up to https://github.com/rust-analyzer/rust-analyzer/pull/10025
Co-authored-by: Lukas Wirth <lukastw97@gmail.com >
2021-09-19 21:46:51 +00:00
a6dde501df
Only strip derive attributes when preparing macro input
2021-09-19 23:38:38 +02:00
9c39363ada
Simplify
2021-09-19 23:34:07 +02:00
3987bf5d6f
Simplify
2021-09-19 19:00:06 +02:00
a6181bfdb7
internal: more focused tests for const arguments
2021-09-19 16:35:10 +03:00
f99bdf4cc0
fix: don't allow two turbo-fishes in generic arguments
2021-09-19 12:09:50 +03:00
8ae1f9c335
internal: add erroneous test for double turbo fish
...
We parse `f` successfully, but that is a bug.
2021-09-19 11:42:10 +03:00
c0556bd8c1
minor: improve readability
2021-09-18 15:56:26 +03:00
3dc2aeea0f
internal: parser cleanup
2021-09-18 15:46:28 +03:00
af9fd37cd9
internal: minimize use_tree parser tests
...
The code here is intentionally dense and does exactly what is written.
Explaining semantic difference between Rust 2015 and 2018 doesn't help
with understanding syntax. Better to just add more targeted tests.
2021-09-18 15:22:49 +03:00
1d2e9818d6
internal: parser cleanups
2021-09-18 14:53:46 +03:00
aaadaa40bd
internal: more focused trait item parsing tests
2021-09-18 14:34:29 +03:00
3474e3b3b1
intenral: more local tests for statics
2021-09-18 01:02:43 +03:00
2195ecd7e7
internal: cleanup adt parsing
2021-09-18 00:50:27 +03:00
d890c767c4
internal: cleanup item parsing
2021-09-18 00:33:42 +03:00
4badd2faf8
Merge #10265
...
10265: internal: parser cleanups r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2021-09-17 19:27:32 +00:00
77e8421d0f
internal: more local parsing tests for macros
2021-09-17 22:21:57 +03:00
073d5f7733
internal: more focused parsing tests
2021-09-17 22:15:12 +03:00
55078c81e0
internal: more local test for mod item
2021-09-17 21:53:24 +03:00
715cd8d938
internal: more local parsing tests
2021-09-17 21:49:01 +03:00
Aramis Razzaghipour