Commit Graph

1064 Commits

Author SHA1 Message Date
Manish Goregaokar 81c5a05648 Bump to 0.0.183 2018-01-29 11:20:29 +05:30
Seiichi Uchida e40bc64f4f Rustup to rustc 1.25.0-nightly (7d6e5b9da 2018-01-27) 2018-01-28 16:28:48 +09:00
Michael Wright daa39b3be1 Fix compilation
Fix the compilation broken by these two changes:
+ https://github.com/rust-lang/rust/commit/2d56abfbebdc905dafc9cf9edc0a6f58e4de7cbd#diff-7fceb7ede15b205bf5ad812c31d75384L1459
+ https://github.com/rust-lang/rust/commit/ccf0d8399e1ef3ed6bf7005650ce42aa646b5cc7#diff-64b696b0ef6ad44140e973801ed82b25L2771
2018-01-27 15:03:17 +02:00
Devon Hollowood 0413b3f6cf Add misaligned_transmute lint 2018-01-25 00:48:36 -08:00
Oliver Schneider 930a8c6cab Version Bump 2018-01-25 08:58:47 +01:00
Manish Goregaokar 5437050013 Rustup to rustc 1.25.0-nightly (a0dcecff9 2018-01-24) 2018-01-25 13:14:04 +05:30
Manish Goregaokar 383cc9e545 Add known false positive for enum_glob_use 2018-01-25 12:55:58 +05:30
Oliver Schneider ea042657e5 Enable more patterns in the author lint 2018-01-24 13:04:06 +01:00
flip1995 31892e205e let invalid_regex point to the right place for raw strings 2018-01-23 16:52:14 +01:00
Oliver Schneider 8e7f76db9a Merge pull request #2362 from flip1995/master
Lint for numeric literals that have a better representation
2018-01-23 15:54:35 +01:00
flip1995 600147926b Apply requested changes 2018-01-23 15:29:31 +01:00
flip1995 23f90afa1b Add configurable threshold, default: 4096 2018-01-23 12:34:40 +01:00
Phil Ellison 29f8cea5fd Use existing match_var function 2018-01-22 05:46:32 +00:00
Phil Ellison 2132e5c58c Fix unnecessary_fold bug 2018-01-22 05:34:42 +00:00
Manish Goregaokar 96cba36b46 Rustup to rustc 1.25.0-nightly (97520ccb1 2018-01-21) 2018-01-22 10:35:02 +05:30
mcarton eb009e2de9 Small documentation formatting fix 2018-01-20 23:32:02 +01:00
Oliver Schneider 70302595a4 Merge branch 'master' of github.com:Manishearth/rust-clippy into fold_any 2018-01-19 12:10:24 +01:00
Oliver Schneider 9a2c50f3d6 Merge pull request #2364 from flip1995/precedence
Add macro check to precedence lint
2018-01-19 12:07:00 +01:00
Oliver Schneider 3c6064130b Merge pull request #2367 from etaoins/inline-fn-without-body-lint
Lint for trait methods without bodies
2018-01-19 09:14:46 +01:00
Oliver Schneider 26c415ab2d Merge pull request #2381 from HMPerson1/remove_is_unit_expr
Replace `is_unit_expr`
2018-01-19 09:14:04 +01:00
Michael Wright fca248957b Merge branch 'master' into option_option_pr 2018-01-19 07:56:46 +02:00
HMPerson1 e09805e8ca Use unit_expr 2018-01-18 17:33:09 -05:00
HMPerson1 7a6c03f876 Add is_unit_expr to deprecated lints list 2018-01-18 17:29:14 -05:00
HMPerson1 8081f6fd6e Replace is_unit_expr 2018-01-18 17:04:26 -05:00
Oliver Schneider 8217e33718 Only suggest implementing Copy if it can actually be done 2018-01-18 14:27:47 +01:00
Ryan Cumming 7467b83377 Suggest removing inline attributes
This adds a `suggest_remove_item` helper that will remove an item and
all trailing whitespace. This should handle both attributes on the same
line as the function and on a separate line; the function takes the
position of the original attribute.
2018-01-18 20:02:42 +11:00
Ryan Cumming 5f3c340bfb Lint for trait methods without bodies
As discussed in rust-lang/rust#47475 the #[inline] attribute is
currently allowed on trait methods without bodies (i.e. without a
default implementation). This is misleading as it could be interpreted
as affecting the implementations of the trait method. Add a lint for any
use of #[inline] on a trait method without a body.

Fixes rust-lang/rust#47475
2018-01-18 20:01:24 +11:00
Manish Goregaokar 552e950080 needless_pass_by_value: Whitelist RangeArgument (fixes #2357) 2018-01-18 14:30:53 +05:30
Manish Goregaokar 2a30c8a194 needless_pass_by_value: Add suggestion for implementing Copy (fixes #2222) 2018-01-18 14:30:47 +05:30
Manish Goregaokar cf1fbaa36a needless_pass_by_value: Ignore for extern funcs (fixes #1844) 2018-01-18 14:30:32 +05:30
Michael Wright bf7efead17 Rename variable
Rename `vec` to `ty` in `match_type_parameter`. This variable is a type
and not a vector. Previously it would only refer to `Vec<_>` so the name used
to make sense.
2018-01-18 07:52:24 +02:00
Michael Wright ec60baa864 Merge branch 'master' into option_option_pr 2018-01-18 07:21:48 +02:00
Phil Ellison a324a2bc38 Fix typos 2018-01-17 21:54:09 +00:00
Phil Ellison b73efad600 Add some reviewer comments 2018-01-17 21:06:16 +00:00
Phil Ellison 9806b31d53 Rename lint, improve documentation 2018-01-17 20:21:29 +00:00
Phil Ellison 1cac693bc7 Lint on folds implementing .all, .sum and .product 2018-01-17 19:12:44 +00:00
Vlad-Shcherbina ada0d2c548 Document map_clone known problems #498 2018-01-17 21:40:47 +03:00
Oliver Schneider a2fdfc05d7 Merge pull request #2298 from goodmanjonathan/else_if_without_else
add new lint else_if_without_else
2018-01-17 09:35:58 +01:00
Michael Wright e7567f2eac Made requested changes 2018-01-17 07:24:33 +02:00
Michael Wright 21fde9a9d1 Merge branch 'master' into option_option_pr 2018-01-17 06:52:00 +02:00
Phil Ellison a64d19cc0e Fix error span to play nicely with rustfix 2018-01-16 21:20:55 +00:00
Manish Goregaokar 37f62a54f8 Show wider and more accurate suggestion for const_static_lifetime
fixes #2365
2018-01-16 20:46:44 +05:30
flip1995 877321ba32 Add macro check to precedence lint 2018-01-16 15:52:16 +01:00
flip1995 647da97622 Lint for numeric literals that have a better representation in another format 2018-01-16 14:01:07 +01:00
Oliver Schneider 61e2b7a4d6 Merge pull request #2355 from alusch/clone_on_ref_ptr_restriction
Fix #2048: Move `clone_on_ref_ptr` to the restriction lints
2018-01-16 10:40:12 +01:00
Oliver Schneider d011dae96d Rustup 2018-01-15 12:08:17 +01:00
Jonathan Goodman 40c6f431da add new lint else_if_without_else 2018-01-14 22:53:00 -06:00
Adam Lusch f343cd22f6 Adds the missing turbofish 2018-01-14 20:19:55 -08:00
Adam Lusch 1615813960 Moves clone_on_ref_ptr to be a restriction lint
Also updates the suggestion to include the full type (e.g. `Arc<Foo>::clone(&rc)`)
and adds a case using trait objects to the UI tests.
2018-01-14 19:58:09 -08:00
Phil Ellison ad164939ed Check that we're calling Iterator::fold 2018-01-14 20:04:34 +00:00