Commit Graph

741 Commits

Author SHA1 Message Date
Philipp Krones f30cf51a70 Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219
Closes #1219 false positive for explicit_counter_loop
2018-09-09 23:49:03 +02:00
Matthias Krüger 160959d27f add tests for #3057 and #2651
Fixes #3057
Fixes #2651
2018-09-08 09:04:04 +02:00
Josh Mcguigan 9168746c38 Corrected explicit_counter_loop behavior with nested loops 2018-09-07 20:46:36 -07:00
Josh Mcguigan 53c262048c Fix #1219 false positive for explicit_counter_loop 2018-09-07 19:58:19 -07:00
flip1995 90f7997771 Add regression test 2018-09-07 17:41:03 +02:00
Josh Mcguigan ce554267b8 Updated explicit_counter_loop tests based on discussion in #3135 2018-09-07 05:32:56 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer 63a46b1e1a Merge pull request #3129 from mipli/3091-numeric-typo
Add lint for misstyped literal casting
2018-09-07 09:54:43 +02:00
Josh Mcguigan edfa9feac2 Corrected explicit_counter_loop missing lints if variable used after loop 2018-09-06 06:20:25 -07:00
Matthias Krüger a0f56edfc3 print_with_newline / write_with_newline: don't warn about string with several \ns in them.
Fixes #3126
2018-09-06 12:59:34 +02:00
Josh Mcguigan 4b668159d2 Closes #1219 false positive for explicit_counter_loop 2018-09-05 19:14:01 -07:00
Michael A. Plikk 38d287fecd Add lint for misstyped literal casting 2018-09-05 19:46:49 +02:00
Josh Mcguigan 0f6d422817 Added test case for ptr_arg 2018-09-05 05:59:07 -07:00
daubaris db391c4613 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-04 18:52:18 +03:00
Josh Holmer 48e6be42d7 Rustup 2018-09-03 23:50:24 -04:00
Josh Holmer 061b2f3057 Apply applicability 2018-09-03 23:29:44 -04:00
Josh Holmer dfed9751bd Majority of PR changes 2018-09-03 23:29:44 -04:00
Josh Holmer fbc93c0166 Lint against needless uses of collect()
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.

Closes #3034
2018-09-03 23:29:44 -04:00
daubaris 1f3676f7d0 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-03 18:24:47 +03:00
daubaris b825578a4a backticks and testcase 2018-09-03 18:24:38 +03:00
Philipp Hansch c0513097ab Merge pull request #3092 from illicitonion/issue-2879
default_trait_access skips <F as Default>::default()
2018-09-03 17:24:33 +02:00
daubaris 1615a8a2b6 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-03 17:21:13 +03:00
Josh Triplett 779988303a iter conservation efforts: save the endangered .iter() and .into_iter()
Make explicit_iter_loop and explicit_into_iter_loop allow-by-default, so
that people can turn them on if they want to enforce that style; avoid
presenting them as *the* idiomatic Rust style, rather than just *a* style.
2018-09-03 01:24:46 -07:00
Daniel Wagner-Hall 9f0216d520 Merge branch 'master' into issue-2879 2018-09-03 00:01:57 +01:00
daubaris 846c3dba2c resolved conflicts 2018-09-01 09:37:42 +03:00
Manish Goregaokar c81d70e6bd Merge pull request #2977 from flip1995/tool_lints
Implement tool_lints
2018-09-01 11:22:23 +05:30
Manish Goregaokar 9abf6fca9c Fix ptr offset tests 2018-08-31 00:38:27 -07:00
Oliver Schneider 73e8416df3 Merge pull request #3081 from mikerite/fix-3078
Fix #3078
2018-08-31 09:05:39 +02:00
daubaris 679bc32f46 range_plus_one suggestion should not remove braces fix 2018-08-30 20:06:13 +03:00
flip1995 e9af09c274 Adapt the *.stderr files of the ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
flip1995 1b6f6051a8 Adapt ui-tests to the tool_lints 2018-08-29 11:08:29 -07:00
Corey Farwell 2fa7351c1e suggest wrapping_offset as well 2018-08-29 07:40:00 -05:00
Corey Farwell 5ebae01c1e New lint: Suggest ptr.add([usize]) over ptr.offset([usize] as isize).
First part of #3047.
2018-08-28 23:21:29 -05:00
Daniel Wagner-Hall 350036a0c7 default_trait_access skips <F as Default>::default()
This includes the type name, so is clear, and may be necessary.

There doesn't seem to be an obviously cleaner way to pull out the
literal text of the named type here.

Fixes #2879
2018-08-27 23:22:07 +01:00
Michael Wright 45ceecc79c Fix #3078 2018-08-25 14:49:56 +02:00
Philipp Krones e91147832c Merge pull request #3048 from goodmanjonathan/assign_op
deprecate assign_ops lint
2018-08-24 18:29:31 +02:00
Philipp Krones 562c576ed3 Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion
#3016 writeln_empty_string Hardcoded suggestion
2018-08-24 18:28:50 +02:00
Niklas Fiekas afdf350060 Add copy_iterator lint (#1534) 2018-08-24 11:57:48 +02:00
flip1995 37099ae034 Remove now stable tool_attributes feature 2018-08-23 15:36:07 +02:00
Lachezar Lechev 76f7bfcefd #3016 Add backticks for the msg 2018-08-20 15:50:15 +02:00
Lachezar Lechev c292b80783 #3016 Add feedback and implement test for fixed hardcoded suggestion 2018-08-20 15:33:43 +02:00
Michael Wright bbd67c9b78 Fix #2927 2018-08-15 08:11:07 +02:00
Philipp Krones 84aa49935d Merge pull request #3026 from dwijnand/fxhash
Add an internal lint for FxHashMap/FxHashSet
2018-08-14 13:04:48 +02:00
Philipp Krones 72b8c9b211 Merge pull request #3049 from mikerite/fix-2799
Add a test to ensure that #2799 is fixed
2018-08-14 12:55:13 +02:00
Philipp Krones b2a4013c14 Merge pull request #3014 from estk/allow-write-multi-newline
Allow print/write with multiple newlines
2018-08-14 12:54:05 +02:00
Dale Wijnand 7933d445d1 Move shadow_unrelated to pedantic 2018-08-14 09:52:27 +01:00
Michael Wright a1f8e129fd Add a test to ensure that #2799 is fixed
Closes #2799
2018-08-14 07:27:56 +02:00
Jonathan Goodman 160b41dae3 deprecate assign_ops lint 2018-08-13 16:12:41 -05:00
Dale Wijnand 1812707d39 Use utils::span_lint_and_sugg in default_hash_types 2018-08-13 11:49:57 +01:00
Dale Wijnand 8fc425b676 Add an internal lint for FxHashMap/FxHashSet 2018-08-12 16:15:36 +01:00
Evan Simmons 550ff84ecd Allow print/write with multiple newlines 2018-08-07 12:01:10 -08:00