19157c02cb
Fix #3112
2018-09-02 09:38:25 +02:00
c81d70e6bd
Merge pull request #2977 from flip1995/tool_lints
...
Implement tool_lints
2018-09-01 11:22:23 +05:30
20dfaf7842
declare_lint -> declare_tool_lint
2018-08-31 00:34:48 -07:00
73e8416df3
Merge pull request #3081 from mikerite/fix-3078
...
Fix #3078
2018-08-31 09:05:39 +02:00
c6074a94b9
Merge branch 'master' into fix-3078
2018-08-31 06:17:11 +02:00
daacac6b97
Revert "fix-3078: verify test case"
...
This reverts commit 6256ad05ba
2018-08-31 06:15:55 +02:00
b87ab5ccf2
Merge pull request #3076 from mbrubeck/patch-1
...
Remove incorrect note from string_add_assign docs
2018-08-29 20:09:38 +01:00
e0ad732226
Merge pull request #3105 from frewsxcv/frewsxcv-private
...
Make clippy_lints::{utils,consts} modules private, remove unused items.
2018-08-29 11:24:00 -07:00
daa4f0ad34
Implement backwards compatibility changes introduced by rust-lang/rust#53762
2018-08-29 11:08:29 -07:00
d1f2f0c34c
Fix some rebase fallout
2018-08-29 11:08:29 -07:00
f3bb161f0e
Adapt codebase to the tool_lints
2018-08-29 11:08:29 -07:00
8c07772dbb
Switch to declare_tool_lint macro
2018-08-29 11:08:29 -07:00
392235d6e1
Switch to tool_lints
2018-08-29 11:08:29 -07:00
f42442b6e0
dont deref
2018-08-29 09:07:09 -05:00
53928d5367
clippy suggestion
2018-08-29 08:27:32 -05:00
6445a5d79d
derive copy/clone
2018-08-29 08:01:05 -05:00
d5534ca9db
bring back sugg::range
2018-08-29 07:46:03 -05:00
9a8f206662
eof newline
2018-08-29 07:43:40 -05:00
2a486528ee
utilize carrier
2018-08-29 07:42:43 -05:00
2fa7351c1e
suggest wrapping_offset as well
2018-08-29 07:40:00 -05:00
61c20c148e
if no suggestion, dont add suggestion
2018-08-29 07:12:22 -05:00
f7d1ef90a0
utilize .is_unsafe_ptr
2018-08-29 07:08:59 -05:00
a48a6ef10f
utilize cx.tcx.types.usize
2018-08-29 07:07:23 -05:00
a7c1ea96c4
tweak comment
2018-08-29 07:03:50 -05:00
feb3e9fd5f
switch lint from 'style' to 'complexity'
2018-08-29 07:02:26 -05:00
5ebae01c1e
New lint: Suggest ptr.add([usize]) over ptr.offset([usize] as isize).
...
First part of #3047 .
2018-08-28 23:21:29 -05:00
05f637cf88
Make clippy_lints::{utils,consts} modules private, remove unused items.
2018-08-28 21:32:20 -05:00
d99cea0f16
Update imports and rustup
2018-08-28 13:13:42 +02:00
fc31dc01de
docs: make example in new_without_default lint syntax highlighted
2018-08-27 17:35:30 +02:00
9ce826ade1
Merge pull request #3082 from mikerite/move-range-lints
...
Move some range lints to complexity
2018-08-26 15:08:21 +02:00
eef3ffab35
Remove iterator_find_map feature attribute
...
Closes #3083
2018-08-26 11:11:47 +02:00
cc87dc7539
Move some range lints to complexity
...
Recategorize `range_plus_one` and `range_minus_one` to `complexity`.
This moves `range_plus_one` out of the nursery as the inclusive range
syntax is now stable. Both are moved to `complexity` as it is more
consistent with other lints such as `int_plus_one`.
2018-08-26 10:57:04 +02:00
6256ad05ba
fix-3078: verify test case
...
Check the crash test case by commenting out the fix
2018-08-25 22:35:06 +02:00
45ceecc79c
Fix #3078
2018-08-25 14:49:56 +02:00
296b79bdb8
Merge pull request #3079 from matthiaskrgr/update_cargo_metadata
...
deps: update cargo_metadata from 0.5 to 0.6.
2018-08-24 20:09:50 +02:00
b1620f5d3a
Merge pull request #3080 from matthiaskrgr/manual_swap_example
...
add how-to example for std::mem::transmute() usage instead of manual swap
2018-08-24 19:47:17 +02:00
f7be2a0416
add how-to example for std::mem::transmute() usage instead of manual swap
2018-08-24 18:41:49 +02:00
e91147832c
Merge pull request #3048 from goodmanjonathan/assign_op
...
deprecate assign_ops lint
2018-08-24 18:29:31 +02:00
562c576ed3
Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion
...
#3016 writeln_empty_string Hardcoded suggestion
2018-08-24 18:28:50 +02:00
2224fbb5f7
deps: update cargo_metadata from 0.5 to 0.6.
2018-08-24 18:14:49 +02:00
afdf350060
Add copy_iterator lint ( #1534 )
2018-08-24 11:57:48 +02:00
c98987f390
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
2018-08-23 21:41:30 +02:00
6a0703664b
Remove incorrect note from string_add_assign docs
...
The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true. In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`. Their performance is identical since `add` is just a wrapper for `push_str`:
```
fn add(mut self, other: &str) -> String {
self.push_str(other);
self
}
```
https://github.com/rust-lang/rust/blob/35bf1ae25799a4e62131159f052e0a3cbd27c960/src/liballoc/string.rs#L1922-L1925
2018-08-23 08:38:41 -07:00
8ab16b678c
remove macro_vis_matcher feature gate since it is stable now.
...
Warning was:
warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable
--> src/lib.rs:4:12
|
4 | #![feature(macro_vis_matcher)]
| ^^^^^^^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
2018-08-23 15:40:51 +02:00
37099ae034
Remove now stable tool_attributes feature
2018-08-23 15:36:07 +02:00
712d2d4fa1
rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581
2018-08-22 23:34:52 +02:00
76f7bfcefd
#3016 Add backticks for the msg
2018-08-20 15:50:15 +02:00
c292b80783
#3016 Add feedback and implement test for fixed hardcoded suggestion
2018-08-20 15:33:43 +02:00
3015987f27
#3016 [WIP] Implement feedback and suggestions
2018-08-20 14:03:13 +02:00
a7bea134d3
Remove implied rust_2018 feature
...
We are already on the edition and this feature is implied.
2018-08-19 19:14:47 -07:00
Michael Wright